wp-model-core 0.8.7

Typed data model crate providing Value, Field, and Record primitives for the Warp PASE stack.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
use crate::model::DataType;
use crate::model::FieldRef;
use crate::model::Value;
use crate::model::format::LevelFormatAble;
use crate::model::{FNameStr, FValueStr};
use serde::{Deserialize, Deserializer, Serialize, Serializer};
use std::fmt::{Display, Formatter};
use std::net::IpAddr;
use std::sync::Arc;

use super::field::Field;
use super::record::{RecordItem, RecordItemFactory};

/// Storage mode for the underlying field value.
#[derive(Clone, Debug)]
pub enum ValueStorage {
    /// Arc shared (zero-copy passing)
    Shared(Arc<Field<Value>>),

    /// Exclusive ownership
    Owned(Field<Value>),
}

/// Field storage with zero-copy name override support.
///
/// Design principles:
/// - `cur_name` acts as an overlay, never modifying the underlying DataField
/// - Name lookup priority: cur_name > field.name
/// - `set_name()` only modifies cur_name, achieving zero-copy
///
/// # Performance
/// - Cloning `Shared` variant: ~5ns (Arc reference count increment)
/// - Cloning `Owned` variant: 50-500ns (deep copy of Field<Value>)
/// - Accessing field via `as_field()`: ~0-1ns
/// - `set_name()`: ~0ns (only sets cur_name, no field clone)
///
/// # Examples
///
/// ```ignore
/// use std::sync::Arc;
/// use wp_model_core::model::{FieldStorage, Field, Value, DataType};
///
/// // Create a shared field (for static/constant values)
/// let static_field = Arc::new(Field::new(DataType::Chars, "app_name", Value::from("myapp")));
/// let shared = FieldStorage::from_shared(static_field);
///
/// // Zero-copy rename
/// let mut renamed = shared.clone();
/// renamed.set_name("application_name");  // Only sets cur_name, no clone!
///
/// // Create an owned field (for dynamic values)
/// let dynamic_field = Field::new(DataType::Digit, "counter", Value::from(42));
/// let owned = FieldStorage::from_owned(dynamic_field);
/// ```
#[derive(Clone, Debug)]
pub struct FieldStorage {
    /// Current field name (overrides field.name).
    /// None means use the underlying field's original name.
    pub(crate) cur_name: Option<FNameStr>,

    /// Field value storage
    value: ValueStorage,
}

impl FieldStorage {
    /// Create from Arc<DataField> as Shared variant (zero-copy).
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use std::sync::Arc;
    /// use wp_model_core::model::{FieldStorage, Field, Value, DataType};
    ///
    /// let field = Arc::new(Field::new(DataType::Chars, "name", Value::from("Alice")));
    /// let storage = FieldStorage::from_shared(field);
    ///
    /// assert!(storage.is_shared());
    /// ```
    #[inline]
    pub fn from_shared(field: Arc<Field<Value>>) -> Self {
        Self {
            cur_name: None,
            value: ValueStorage::Shared(field),
        }
    }

    /// Create Owned variant from owned field.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use wp_model_core::model::{FieldStorage, Field, Value, DataType};
    ///
    /// let field = Field::new(DataType::Digit, "count", Value::from(10));
    /// let storage = FieldStorage::from_owned(field);
    ///
    /// assert!(storage.is_owned());
    /// ```
    #[inline]
    pub fn from_owned(field: Field<Value>) -> Self {
        Self {
            cur_name: None,
            value: ValueStorage::Owned(field),
        }
    }

    /// Zero-copy set field name.
    ///
    /// Only modifies `cur_name`, does not affect the underlying Arc<DataField>.
    /// This is the core method of the zero-copy optimization!
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use std::sync::Arc;
    /// use wp_model_core::model::{FieldStorage, Field, Value, DataType};
    ///
    /// let field = Arc::new(Field::new(DataType::Chars, "HOST", Value::from("192.168.1.1")));
    /// let mut storage = FieldStorage::from_shared(Arc::clone(&field));
    /// storage.set_name("server_ip");  // Zero-copy!
    ///
    /// assert_eq!(storage.get_name(), "server_ip");
    /// assert_eq!(field.get_name(), "HOST");  // Original unchanged
    /// ```
    #[inline]
    pub fn set_name(&mut self, name: impl Into<FNameStr>) {
        self.cur_name = Some(name.into());
    }

    /// Get the current effective field name.
    ///
    /// Priority: cur_name > field.name
    #[inline]
    pub fn get_name(&self) -> &str {
        if let Some(ref name) = self.cur_name {
            name.as_str()
        } else {
            self.as_field().get_name()
        }
    }

    /// Get a reference to the underlying field (unified interface).
    ///
    /// Note: This returns the underlying field, whose name may differ from
    /// `get_name()` if `set_name()` was called.
    ///
    /// # Performance
    /// - Shared variant: ~1ns (dereference)
    /// - Owned variant: 0ns (direct reference)
    #[inline]
    pub fn as_field(&self) -> &Field<Value> {
        match &self.value {
            ValueStorage::Shared(arc) => arc.as_ref(),
            ValueStorage::Owned(field) => field,
        }
    }

    /// Convert to owned Field<Value>.
    ///
    /// If `cur_name` is set, it will be applied to the returned field.
    /// If `cur_name` is None and this is an Owned variant, returns without cloning.
    ///
    /// # Performance
    /// - Shared variant: ~50-500ns (clone the inner field if multiple references exist)
    /// - Owned variant: 0ns (move)
    pub fn into_owned(self) -> Field<Value> {
        let mut field = match self.value {
            ValueStorage::Shared(arc) => {
                // Try to unwrap if this is the only reference, otherwise clone
                Arc::try_unwrap(arc).unwrap_or_else(|arc| (*arc).clone())
            }
            ValueStorage::Owned(field) => field,
        };

        // Apply cur_name override
        if let Some(name) = self.cur_name {
            field.set_name(name);
        }

        field
    }

    /// Check if this is a Shared variant.
    #[inline]
    pub fn is_shared(&self) -> bool {
        matches!(self.value, ValueStorage::Shared(_))
    }

    /// Check if this is an Owned variant.
    #[inline]
    pub fn is_owned(&self) -> bool {
        matches!(self.value, ValueStorage::Owned(_))
    }

    /// Get Arc reference count (for debugging/diagnostics).
    ///
    /// Returns `Some(count)` for Shared variant, `None` for Owned variant.
    pub fn shared_count(&self) -> Option<usize> {
        match &self.value {
            ValueStorage::Shared(arc) => Some(Arc::strong_count(arc)),
            ValueStorage::Owned(_) => None,
        }
    }

    /// Get a mutable reference to the underlying field.
    ///
    /// For the `Shared` variant, this converts to `Owned` first (clone-on-write).
    /// If `cur_name` is set, it will be applied to the field before returning.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use wp_model_core::model::{FieldStorage, Field, Value, DataType};
    ///
    /// let mut storage = FieldStorage::from_owned(Field::from_chars("name", "Alice"));
    /// storage.as_field_mut().set_name("renamed");
    /// assert_eq!(storage.as_field().get_name(), "renamed");
    /// ```
    pub fn as_field_mut(&mut self) -> &mut Field<Value> {
        // Convert Shared to Owned if needed
        if let ValueStorage::Shared(_) = self.value {
            let old_value = std::mem::replace(
                &mut self.value,
                ValueStorage::Owned(Field::new(DataType::Ignore, "", Value::from(false))),
            );
            let field = match old_value {
                ValueStorage::Shared(arc) => {
                    Arc::try_unwrap(arc).unwrap_or_else(|arc| (*arc).clone())
                }
                ValueStorage::Owned(field) => field,
            };
            self.value = ValueStorage::Owned(field);
        }

        // Apply cur_name if set
        if let Some(name) = self.cur_name.take()
            && let ValueStorage::Owned(ref mut field) = self.value
        {
            field.set_name(name);
        }

        match &mut self.value {
            ValueStorage::Owned(field) => field,
            ValueStorage::Shared(_) => unreachable!(),
        }
    }

    /// Get field value reference.
    #[inline]
    pub fn get_value(&self) -> &Value {
        self.as_field().get_value()
    }

    /// Get type metadata.
    #[inline]
    pub fn get_meta(&self) -> &DataType {
        self.as_field().get_meta()
    }

    /// Get field reference with cur_name overlay applied (zero-copy).
    ///
    /// Returns a [`FieldRef`] that provides consistent `cur_name`-aware access.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use wp_model_core::model::{FieldStorage, Field, Value, DataType};
    ///
    /// let mut storage = FieldStorage::from_owned(
    ///     Field::new(DataType::Chars, "old", Value::from("test"))
    /// );
    /// storage.set_name("new");
    ///
    /// let field_ref = storage.field_ref();
    /// assert_eq!(field_ref.get_name(), "new");
    /// ```
    #[inline]
    pub fn field_ref(&self) -> FieldRef<'_> {
        FieldRef { storage: self }
    }
}

// Implement Display by delegating to inner field
impl Display for FieldStorage {
    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
        self.as_field().fmt(f)
    }
}

// Implement PartialEq by comparing effective names and field contents
impl PartialEq for FieldStorage {
    fn eq(&self, other: &Self) -> bool {
        self.get_name() == other.get_name()
            && self.as_field().get_meta() == other.as_field().get_meta()
            && self.as_field().get_value() == other.as_field().get_value()
    }
}

impl Eq for FieldStorage {}

// Serialize: Transparently serialize as Field<Value> with effective name
impl Serialize for FieldStorage {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: Serializer,
    {
        if let Some(ref name) = self.cur_name {
            // Serialize with the effective name
            let mut field = self.as_field().clone();
            field.set_name(name.as_str());
            field.serialize(serializer)
        } else {
            self.as_field().serialize(serializer)
        }
    }
}

// Deserialize: Always deserialize to Owned variant
impl<'de> Deserialize<'de> for FieldStorage {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: Deserializer<'de>,
    {
        Field::<Value>::deserialize(deserializer).map(FieldStorage::from_owned)
    }
}

// Implement RecordItem trait by delegating to the inner field
impl RecordItem for FieldStorage {
    fn get_name(&self) -> &str {
        if let Some(ref name) = self.cur_name {
            name.as_str()
        } else {
            self.as_field().get_name()
        }
    }

    fn get_meta(&self) -> &DataType {
        self.as_field().get_meta()
    }

    fn get_value(&self) -> &Value {
        self.as_field().get_value()
    }

    fn get_value_mut(&mut self) -> &mut Value {
        self.as_field_mut().get_value_mut()
    }
}

// Implement RecordItemFactory trait
impl RecordItemFactory for FieldStorage {
    fn from_digit<S: Into<FNameStr>>(name: S, val: i64) -> Self {
        FieldStorage::from_owned(Field::from_digit(name, val))
    }

    fn from_ip<S: Into<FNameStr>>(name: S, ip: IpAddr) -> Self {
        FieldStorage::from_owned(Field::from_ip(name, ip))
    }

    fn from_chars<N: Into<FNameStr>, Val: Into<FValueStr>>(name: N, val: Val) -> Self {
        FieldStorage::from_owned(Field::from_chars(name, val))
    }
}

// Implement LevelFormatAble
impl LevelFormatAble for FieldStorage {
    fn level_fmt(&self, f: &mut Formatter<'_>, level: usize) -> std::fmt::Result {
        if let Some(ref name) = self.cur_name {
            let meta: String = From::from(self.as_field().get_meta());
            writeln!(
                f,
                "{:width$}[{:<16}] {:<20} : {}",
                "",
                meta,
                name,
                self.as_field().value,
                width = level * 6
            )
        } else {
            self.as_field().level_fmt(f, level)
        }
    }
}

// Auto conversion (reduce migration cost)
impl From<Field<Value>> for FieldStorage {
    fn from(field: Field<Value>) -> Self {
        FieldStorage::from_owned(field)
    }
}

impl From<Arc<Field<Value>>> for FieldStorage {
    fn from(arc: Arc<Field<Value>>) -> Self {
        FieldStorage::from_shared(arc)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::model::DataType;

    #[test]
    fn test_field_storage_shared_variant() {
        let field = Field::new(DataType::Chars, "test", Value::from("hello"));
        let storage = FieldStorage::from_shared(Arc::new(field.clone()));

        // as_field returns correct reference
        assert_eq!(storage.as_field().get_name(), "test");
        assert!(storage.is_shared());
        assert_eq!(storage.shared_count(), Some(1));

        // Clone Shared variant only increments reference count
        let storage2 = storage.clone();
        assert_eq!(storage.shared_count(), Some(2));
        assert_eq!(storage2.shared_count(), Some(2));
    }

    #[test]
    fn test_field_storage_owned_variant() {
        let field = Field::new(DataType::Digit, "test", Value::from(42));
        let storage = FieldStorage::from_owned(field);

        assert_eq!(storage.as_field().get_name(), "test");
        assert!(!storage.is_shared());
        assert_eq!(storage.shared_count(), None);
    }

    #[test]
    fn test_into_owned() {
        // Shared variant
        let field1 = Field::new(DataType::Chars, "shared_field", Value::from("value"));
        let storage1 = FieldStorage::from_shared(Arc::new(field1));
        let owned1 = storage1.into_owned();
        assert_eq!(owned1.get_name(), "shared_field");

        // Owned variant
        let field2 = Field::new(DataType::Digit, "owned_field", Value::from(123));
        let storage2 = FieldStorage::from_owned(field2);
        let owned2 = storage2.into_owned();
        assert_eq!(owned2.get_name(), "owned_field");
    }

    #[test]
    fn test_from_shared() {
        let field = Field::new(DataType::Chars, "name", Value::from("Alice"));
        let storage = FieldStorage::from_shared(Arc::new(field));

        assert!(storage.is_shared());
        assert_eq!(storage.as_field().get_name(), "name");
    }

    #[test]
    fn test_from_owned() {
        let field = Field::new(DataType::Digit, "count", Value::from(10));
        let storage = FieldStorage::from_owned(field);

        assert!(!storage.is_shared());
        assert_eq!(storage.as_field().get_name(), "count");
    }

    #[test]
    fn test_display() {
        let field = Field::new(DataType::Digit, "num", Value::from(42));
        let storage = FieldStorage::from_owned(field);

        let display = format!("{}", storage);
        assert!(display.contains("42"));
    }

    #[test]
    fn test_equality() {
        let field1 = Field::new(DataType::Chars, "test", Value::from("value"));
        let field2 = Field::new(DataType::Chars, "test", Value::from("value"));
        let field3 = Field::new(DataType::Chars, "test", Value::from("different"));

        let shared1 = FieldStorage::from_shared(Arc::new(field1.clone()));
        let owned1 = FieldStorage::from_owned(field1);
        let shared2 = FieldStorage::from_shared(Arc::new(field2));
        let owned3 = FieldStorage::from_owned(field3);

        // Same content should be equal regardless of storage type
        assert_eq!(shared1, owned1);
        assert_eq!(shared1, shared2);

        // Different content should not be equal
        assert_ne!(shared1, owned3);
    }

    #[test]
    fn test_equality_with_cur_name() {
        let field = Field::new(DataType::Chars, "test", Value::from("value"));

        let mut storage1 = FieldStorage::from_owned(field.clone());
        storage1.set_name("renamed");

        let storage2 = FieldStorage::from_owned(field);

        // Different effective names should not be equal
        assert_ne!(storage1, storage2);
    }

    #[test]
    fn test_serde_serialization() {
        let field1 = Field::new(DataType::Chars, "f1", Value::from("shared"));
        let field2 = Field::new(DataType::Digit, "f2", Value::from(99));

        let shared = FieldStorage::from_shared(Arc::new(field1));
        let owned = FieldStorage::from_owned(field2);

        // Serialize
        let json_shared = serde_json::to_string(&shared).unwrap();
        let json_owned = serde_json::to_string(&owned).unwrap();

        // Deserialize (should always get Owned variant)
        let deserialized_shared: FieldStorage = serde_json::from_str(&json_shared).unwrap();
        let deserialized_owned: FieldStorage = serde_json::from_str(&json_owned).unwrap();

        // Verify values are correct
        assert_eq!(deserialized_shared.as_field().get_name(), "f1");
        assert_eq!(deserialized_owned.as_field().get_name(), "f2");

        // Verify both are Owned variant after deserialization
        assert!(!deserialized_shared.is_shared());
        assert!(!deserialized_owned.is_shared());
    }

    #[test]
    fn test_serde_with_cur_name() {
        let field = Field::new(DataType::Chars, "original", Value::from("value"));
        let mut storage = FieldStorage::from_owned(field);
        storage.set_name("renamed");

        // Serialize should use the effective name
        let json = serde_json::to_string(&storage).unwrap();
        let deserialized: FieldStorage = serde_json::from_str(&json).unwrap();

        assert_eq!(deserialized.get_name(), "renamed");
    }

    #[test]
    fn test_clone_performance_difference() {
        // This is more of a documentation test showing the usage pattern
        use crate::model::FValueStr;
        let large_str = FValueStr::from("x".repeat(1000));
        let field = Field::new(DataType::Chars, "large", Value::from(large_str));

        // Shared: cheap clone
        let shared = FieldStorage::from_shared(Arc::new(field.clone()));
        let _shared2 = shared.clone();
        assert_eq!(shared.shared_count(), Some(2));

        // Owned: deep clone
        let owned = FieldStorage::from_owned(field);
        let _owned2 = owned.clone();
        assert!(owned.shared_count().is_none());
    }

    #[test]
    fn test_from_arc_to_fieldstorage() {
        let field = Field::new(DataType::Chars, "name", Value::from("Alice"));
        let arc = Arc::new(field);
        let storage: FieldStorage = arc.into();

        assert!(storage.is_shared());
        assert_eq!(storage.as_field().get_name(), "name");
    }

    #[test]
    fn test_is_owned() {
        let field = Field::new(DataType::Digit, "x", Value::from(1));
        let owned = FieldStorage::from_owned(field.clone());
        let shared = FieldStorage::from_shared(Arc::new(field));

        assert!(owned.is_owned());
        assert!(!shared.is_owned());
    }

    #[test]
    fn test_as_field_mut_owned() {
        let mut storage = FieldStorage::from_owned(Field::from_chars("name", "Alice"));
        storage.as_field_mut().set_name("renamed");
        assert_eq!(storage.as_field().get_name(), "renamed");
        assert!(storage.is_owned());
    }

    #[test]
    fn test_as_field_mut_shared() {
        let field = Field::from_chars("name", "Alice");
        let mut storage = FieldStorage::from_shared(Arc::new(field));
        assert!(storage.is_shared());

        // Mutating converts Shared to Owned
        storage.as_field_mut().set_name("renamed");
        assert!(storage.is_owned());
        assert_eq!(storage.as_field().get_name(), "renamed");
    }

    #[test]
    fn test_as_field_mut_applies_cur_name() {
        let field = Field::from_chars("original", "value");
        let mut storage = FieldStorage::from_owned(field);
        storage.set_name("override");

        // as_field_mut should apply cur_name
        let field_mut = storage.as_field_mut();
        assert_eq!(field_mut.get_name(), "override");

        // After as_field_mut, cur_name should be consumed
        assert_eq!(storage.as_field().get_name(), "override");
    }

    // ===== Zero-copy specific tests =====

    #[test]
    fn test_zero_copy_set_name() {
        // Create Arc field
        let field = Arc::new(Field::from_chars("original", "value"));
        let original_count = Arc::strong_count(&field);

        // Create Shared storage
        let mut storage = FieldStorage::from_shared(Arc::clone(&field));
        assert_eq!(Arc::strong_count(&field), original_count + 1);

        // Zero-copy set name
        storage.set_name("renamed");

        // Verify: Arc reference count unchanged (no clone happened)
        assert_eq!(Arc::strong_count(&field), original_count + 1);

        // Verify: name updated
        assert_eq!(storage.get_name(), "renamed");

        // Verify: underlying field name unchanged
        assert_eq!(field.get_name(), "original");

        // Verify: value unchanged
        assert_eq!(storage.get_value().as_str().unwrap(), "value");
    }

    #[test]
    fn test_name_priority() {
        let field = Field::from_chars("field_name", "value");
        let mut storage = FieldStorage::from_owned(field);

        // Initial: use field.name
        assert_eq!(storage.get_name(), "field_name");

        // Set cur_name
        storage.set_name("override_name");

        // cur_name takes priority
        assert_eq!(storage.get_name(), "override_name");

        // Underlying field name unchanged
        assert_eq!(storage.as_field().get_name(), "field_name");
    }

    #[test]
    fn test_into_owned_applies_cur_name() {
        let field = Arc::new(Field::from_chars("original", "value"));
        let mut storage = FieldStorage::from_shared(field);

        storage.set_name("renamed");

        let owned = storage.into_owned();

        // Verify: name applied
        assert_eq!(owned.get_name(), "renamed");
        assert_eq!(owned.get_value().as_str().unwrap(), "value");
    }

    #[test]
    fn test_shared_vs_owned() {
        let arc_field = Arc::new(Field::from_chars("arc", "value1"));
        let owned_field = Field::from_chars("owned", "value2");

        let shared = FieldStorage::from_shared(arc_field);
        let owned = FieldStorage::from_owned(owned_field);

        assert!(shared.is_shared());
        assert!(!shared.is_owned());

        assert!(!owned.is_shared());
        assert!(owned.is_owned());
    }

    #[test]
    fn test_arc_strong_count() {
        let field = Arc::new(Field::from_chars("test", "value"));
        let initial_count = Arc::strong_count(&field);

        let storage1 = FieldStorage::from_shared(Arc::clone(&field));
        assert_eq!(storage1.shared_count(), Some(initial_count + 1));

        let storage2 = FieldStorage::from_shared(Arc::clone(&field));
        assert_eq!(storage2.shared_count(), Some(initial_count + 2));

        let owned = FieldStorage::from_owned(Field::from_chars("test", "value"));
        assert_eq!(owned.shared_count(), None);
    }

    #[test]
    fn test_multi_stage_zero_copy() {
        // Simulate multi-stage processing
        let field = Arc::new(Field::from_chars("HOST", "192.168.1.1"));
        let initial_count = Arc::strong_count(&field);

        // Stage 1: rename to server_ip
        let mut stage1 = FieldStorage::from_shared(Arc::clone(&field));
        stage1.set_name("server_ip");

        // Stage 2: rename to host_address
        let mut stage2 = FieldStorage::from_shared(Arc::clone(&field));
        stage2.set_name("host_address");

        // Stage 3: rename to ip_addr
        let mut stage3 = FieldStorage::from_shared(Arc::clone(&field));
        stage3.set_name("ip_addr");

        // Verify: all stages share the same Arc
        assert_eq!(stage1.shared_count(), Some(initial_count + 3));
        assert_eq!(stage2.shared_count(), Some(initial_count + 3));
        assert_eq!(stage3.shared_count(), Some(initial_count + 3));

        // Verify: each stage has independent name
        assert_eq!(stage1.get_name(), "server_ip");
        assert_eq!(stage2.get_name(), "host_address");
        assert_eq!(stage3.get_name(), "ip_addr");

        // Verify: all stages share the same value
        assert_eq!(stage1.get_value().as_str().unwrap(), "192.168.1.1");
        assert_eq!(stage2.get_value().as_str().unwrap(), "192.168.1.1");
        assert_eq!(stage3.get_value().as_str().unwrap(), "192.168.1.1");
    }

    #[test]
    fn test_record_item_get_name_with_cur_name() {
        let field = Field::from_chars("original", "value");
        let mut storage = FieldStorage::from_owned(field);
        storage.set_name("overridden");

        // RecordItem::get_name should return the effective name
        let name: &str = RecordItem::get_name(&storage);
        assert_eq!(name, "overridden");
    }
}