1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
use std::fs::File;
use std::io::BufReader;
use calamine_styles::{Data, Reader, Xlsx};
use chrono::{NaiveDate, NaiveDateTime, NaiveTime};
use crate::cell::{Cell, CellValue};
use crate::error::{Error, Result};
type XlsxReader = Xlsx<BufReader<File>>;
pub struct Sheet {
pub name: String,
rows: Vec<Vec<Cell>>,
}
impl Sheet {
pub(crate) fn load(wb: &mut XlsxReader, name: &str) -> Result<Self> {
let value_range = wb
.worksheet_range(name)
.map_err(|e| Error::Xlsx(format!("read range for {name:?}: {e}")))?;
let style_range = wb.worksheet_style(name).ok();
let (h, w) = value_range.get_size();
let mut rows: Vec<Vec<Cell>> = Vec::with_capacity(h);
for r in 0..h {
let mut row: Vec<Cell> = Vec::with_capacity(w);
for c in 0..w {
let value = value_range
.get((r, c))
.map(data_to_cell_value)
.unwrap_or(CellValue::Empty);
let number_format = style_range
.as_ref()
.and_then(|sr| sr.get((r, c)))
.and_then(extract_number_format);
row.push(Cell {
value,
number_format,
});
}
rows.push(row);
}
Ok(Self {
name: name.to_string(),
rows,
})
}
pub fn dimensions(&self) -> (usize, usize) {
let h = self.rows.len();
let w = self.rows.first().map(|r| r.len()).unwrap_or(0);
(h, w)
}
/// Test-only constructor: build a `Sheet` from a pre-shaped grid without
/// round-tripping through xlsx. Lets crate-internal tests (e.g. the
/// classifier in `map.rs`) cover branches the committed fixtures don't
/// exercise.
#[cfg(test)]
pub(crate) fn from_rows_for_test(name: &str, rows: Vec<Vec<Cell>>) -> Self {
Self {
name: name.to_string(),
rows,
}
}
pub fn rows(&self) -> &[Vec<Cell>] {
&self.rows
}
pub fn row(&self, idx: usize) -> Option<&[Cell]> {
self.rows.get(idx).map(|r| r.as_slice())
}
/// First row stringified - the conventional "header" row for table-shaped
/// sheets. Empty cells become empty strings so position is preserved.
pub fn headers(&self) -> Vec<String> {
self.rows
.first()
.map(|row| {
row.iter()
.map(|c| match &c.value {
CellValue::String(s) => s.clone(),
CellValue::Empty => String::new(),
other => format_value_plain(other),
})
.collect()
})
.unwrap_or_default()
}
}
fn format_value_plain(v: &CellValue) -> String {
match v {
CellValue::Empty => String::new(),
CellValue::String(s) => s.clone(),
CellValue::Int(n) => n.to_string(),
CellValue::Float(n) => n.to_string(),
CellValue::Bool(b) => if *b { "TRUE" } else { "FALSE" }.to_string(),
CellValue::Date(d) => d.format("%Y-%m-%d").to_string(),
CellValue::DateTime(dt) => dt.format("%Y-%m-%d %H:%M:%S").to_string(),
CellValue::Time(t) => t.format("%H:%M:%S").to_string(),
CellValue::Error(e) => e.clone(),
}
}
fn data_to_cell_value(d: &Data) -> CellValue {
match d {
Data::Empty => CellValue::Empty,
Data::String(s) => CellValue::String(s.clone()),
Data::Int(i) => CellValue::Int(*i),
Data::Float(f) => {
if f.fract() == 0.0 && f.abs() < (i64::MAX as f64) {
CellValue::Int(*f as i64)
} else {
CellValue::Float(*f)
}
}
Data::Bool(b) => CellValue::Bool(*b),
Data::DateTime(dt) => excel_serial_to_datetime(dt.as_f64()),
Data::DateTimeIso(s) => parse_iso_datetime_or_string(s),
Data::DurationIso(s) => CellValue::String(s.clone()),
Data::Error(e) => CellValue::Error(format!("{e:?}")),
Data::RichText(rt) => CellValue::String(rt.plain_text().to_string()),
}
}
/// Excel serial date → chrono. Sub-day fractions become Time; ≥1.0 with no
/// fractional part becomes Date; otherwise DateTime. Serial 0.0 is the Excel
/// epoch but for time-formatted cells means midnight; route it to Time(0,0,0)
/// to match openpyxl rather than returning the epoch date.
fn excel_serial_to_datetime(serial: f64) -> CellValue {
if serial < 1.0 && serial >= 0.0 {
let mut secs = (serial * 86_400.0).round() as u32;
// 0.99999999 rounds to 86_400, which makes h=24 and `from_hms_opt`
// returns None — without this carry, the prior fallback emitted
// `CellValue::Float(serial)` and silently demoted a time-typed
// cell to a numeric. Mirror the day-carry the date+time branch
// does below: for a pure sub-day value, "next midnight" is just
// 00:00:00.
if secs >= 86_400 {
secs -= 86_400;
}
let h = secs / 3600;
let m = (secs % 3600) / 60;
let s = secs % 60;
return NaiveTime::from_hms_opt(h, m, s)
.map(CellValue::Time)
.unwrap_or_else(|| CellValue::Float(serial));
}
let mut days = serial.trunc() as i64;
let frac = serial - (days as f64);
// Excel's 1900 leap-year bug: serial 60 maps to the non-existent
// 1900-02-29. openpyxl uses base 1899-12-30 (instead of 1899-12-31) to
// dodge the bug for serials >= 60, but that leaves serials 1..59 off by
// one day. The +1 correction restores serial 1 -> 1900-01-01 etc., which
// matches openpyxl.utils.datetime.from_excel.
if serial > 0.0 && serial < 60.0 {
days += 1;
}
if frac.abs() < f64::EPSILON {
return CellValue::Date(days_to_date_from_excel_base(days));
}
// Keep the day-fraction arithmetic signed until normalized into
// [0, 86_400) — a negative serial like -0.5 produces frac = -0.5 here,
// and the prior `(frac * 86_400).round() as u32` would wrap a negative
// f64 to a huge positive u32, then the next-day carry branch would
// emit a corrupted pre-1900 datetime. Borrow whole days off `days`
// until secs lands in the valid range; then carry forward the same
// way the existing 0.99999999 → 86_400 case does.
let mut secs_signed = (frac * 86_400.0).round() as i64;
if secs_signed < 0 {
let borrow_days = (-secs_signed + 86_399) / 86_400; // ceil division
secs_signed += borrow_days * 86_400;
days -= borrow_days;
} else if secs_signed >= 86_400 {
let carry_days = secs_signed / 86_400;
secs_signed -= carry_days * 86_400;
days += carry_days;
}
let secs = secs_signed as u32; // now in [0, 86_400)
let date = days_to_date_from_excel_base(days);
let h = secs / 3600;
let m = (secs % 3600) / 60;
let s = secs % 60;
let time = NaiveTime::from_hms_opt(h, m, s)
.unwrap_or_else(|| NaiveTime::from_hms_opt(0, 0, 0).unwrap());
CellValue::DateTime(NaiveDateTime::new(date, time))
}
fn days_to_date_from_excel_base(days: i64) -> NaiveDate {
let base = NaiveDate::from_ymd_opt(1899, 12, 30).expect("static date");
if days >= 0 {
base.checked_add_days(chrono::Days::new(days as u64))
} else {
// u64 cast on negative i64 wraps; subtract the absolute value.
base.checked_sub_days(chrono::Days::new((-days) as u64))
}
.unwrap_or(base)
}
fn parse_iso_datetime_or_string(s: &str) -> CellValue {
if let Ok(dt) = NaiveDateTime::parse_from_str(s, "%Y-%m-%dT%H:%M:%S%.f") {
return CellValue::DateTime(dt);
}
if let Ok(dt) = NaiveDateTime::parse_from_str(s, "%Y-%m-%dT%H:%M:%S") {
return CellValue::DateTime(dt);
}
if let Ok(d) = NaiveDate::parse_from_str(s, "%Y-%m-%d") {
return CellValue::Date(d);
}
CellValue::String(s.to_string())
}
/// Pull the resolved format-code string off a calamine-styles `Style`. The
/// upstream crate handles built-in vs custom (>=164) resolution; we just
/// normalize the result and skip the no-op "General".
fn extract_number_format(style: &calamine_styles::Style) -> Option<String> {
let nf = style.get_number_format()?;
let code = nf.format_code.trim();
if code.is_empty() || code.eq_ignore_ascii_case("general") {
None
} else {
Some(code.to_string())
}
}
#[cfg(test)]
mod tests {
use chrono::Datelike;
use super::*;
fn date(value: CellValue) -> NaiveDate {
match value {
CellValue::Date(d) => d,
other => panic!("expected Date, got {other:?}"),
}
}
#[test]
fn excel_serial_matches_openpyxl_for_pre_leap_serials() {
// openpyxl maps serial 1 -> 1900-01-01 thanks to its +1 correction
// for serials in (0, 60). Serial 59 -> 1900-02-28.
assert_eq!(
date(excel_serial_to_datetime(1.0)),
NaiveDate::from_ymd_opt(1900, 1, 1).unwrap()
);
assert_eq!(
date(excel_serial_to_datetime(59.0)),
NaiveDate::from_ymd_opt(1900, 2, 28).unwrap()
);
// Serial 61 -> 1900-03-01 (Excel's fake serial-60 leap day is skipped).
assert_eq!(
date(excel_serial_to_datetime(61.0)),
NaiveDate::from_ymd_opt(1900, 3, 1).unwrap()
);
// A modern serial: 44197 -> 2021-01-01.
assert_eq!(
date(excel_serial_to_datetime(44197.0)),
NaiveDate::from_ymd_opt(2021, 1, 1).unwrap()
);
}
#[test]
fn excel_serial_negative_does_not_wrap() {
// Bad/sentinel serials shouldn't panic or produce a date in the
// far future via u64 wrap. Fall back to the epoch.
let value = excel_serial_to_datetime(-100.0);
let d = date(value);
assert!(d.year() < 1900, "got {d}");
}
#[test]
fn excel_serial_sub_day_near_midnight_carries_to_zero_time() {
// 0.99999999 rounds to 86_400 secs (h=24 is invalid). The prior
// fallback emitted CellValue::Float(serial), silently demoting a
// time-typed cell to a numeric. The carry should land on
// Time(00:00:00) — equivalent of "next midnight" with no date to
// carry into.
let value = excel_serial_to_datetime(0.99999999);
match value {
CellValue::Time(t) => {
assert_eq!(t, NaiveTime::from_hms_opt(0, 0, 0).unwrap());
}
other => panic!("expected Time(00:00:00), got {other:?}"),
}
}
#[test]
fn excel_serial_zero_returns_midnight_time() {
// Serial 0 is the Excel epoch (1899-12-30) but for time-formatted
// cells means midnight. openpyxl returns Time(0,0,0) here; we
// match that rather than emitting the epoch date.
let value = excel_serial_to_datetime(0.0);
match value {
CellValue::Time(t) => {
assert_eq!(t, NaiveTime::from_hms_opt(0, 0, 0).unwrap());
}
other => panic!("expected Time(00:00:00), got {other:?}"),
}
}
#[test]
fn excel_serial_negative_fractional_borrows_into_prior_day() {
// Serial -0.5 means "12:00 the day before 1899-12-30", i.e.
// 1899-12-29 12:00:00. The prior code computed
// `(frac * 86_400).round() as u32` where frac was -0.5; the
// negative→u32 cast wrapped to a huge positive, and the
// "carry into next day" branch then emitted a corrupted
// far-future datetime. Signed arithmetic with a borrow keeps
// the result in chrono's representable range and on the
// correct calendar day.
let value = excel_serial_to_datetime(-0.5);
match value {
CellValue::DateTime(dt) => {
assert_eq!(
dt.date(),
NaiveDate::from_ymd_opt(1899, 12, 29).unwrap(),
"expected borrow into prior day, got {dt}",
);
assert_eq!(dt.time(), NaiveTime::from_hms_opt(12, 0, 0).unwrap());
}
other => panic!("expected DateTime, got {other:?}"),
}
}
#[test]
fn excel_serial_carries_near_midnight_fraction_to_next_day() {
// 44197 + 0.99999999 rounds up to 86_400 secs in the day-fraction
// calc; that must carry into 2021-01-02 00:00:00 instead of clamping
// to 23:00:00 on 2021-01-01.
let value = excel_serial_to_datetime(44197.0 + 0.99999999);
match value {
CellValue::DateTime(dt) => {
assert_eq!(
dt.date(),
NaiveDate::from_ymd_opt(2021, 1, 2).unwrap(),
);
assert_eq!(dt.time(), NaiveTime::from_hms_opt(0, 0, 0).unwrap());
}
other => panic!("expected DateTime, got {other:?}"),
}
}
}