winshift 0.0.6

A cross-platform window change hook library
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
//! # Thread Safety Warning
//!
//! This implementation uses `static mut` variables which are not thread-safe.
//! It assumes single-threaded usage on the main thread only.
//!
//! TODO: Replace `static mut` with thread-safe alternatives (Mutex/RwLock)

use std::collections::HashMap;
use std::ffi;
use std::ptr;
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::{Arc, Mutex, RwLock};

use core_foundation::base::{CFGetTypeID, CFType, TCFType};
use core_foundation::runloop::{kCFRunLoopDefaultMode, CFRunLoop};
use core_foundation::string::{CFString, CFStringGetTypeID, CFStringRef};
use log::{debug, error, info, trace, warn};
use objc2::declare::ClassDecl;
use objc2::rc::autoreleasepool;
use objc2::runtime;
use objc2::runtime::{Class, Object, Sel};
use objc2::{class, msg_send, sel, sel_impl};

use crate::error::WinshiftError;
use crate::FocusChangeHandler;

#[link(name = "AppKit", kind = "framework")]
extern "C" {}
// TODO: Make these thread-safe
static mut CURRENT_RUN_LOOP: Option<CFRunLoop> = None;
// Controls whether we compute and emit embedded ActiveWindowInfo in callbacks
static EMBED_ACTIVE_INFO: AtomicBool = AtomicBool::new(false);

#[derive(Clone, Default)]
pub struct HookStopHandle {
    inner: Arc<HookStopState>,
}

#[derive(Default)]
struct HookStopState {
    run_loop: Mutex<Option<CFRunLoop>>,
}

impl HookStopHandle {
    pub(crate) fn set_run_loop(&self, run_loop: &CFRunLoop) {
        *self.inner.run_loop.lock().unwrap() = Some(run_loop.clone());
    }

    pub(crate) fn clear(&self) {
        *self.inner.run_loop.lock().unwrap() = None;
    }

    pub fn stop(&self) -> Result<(), WinshiftError> {
        if let Some(run_loop) = self.inner.run_loop.lock().unwrap().clone() {
            run_loop.stop();
            return Ok(());
        }
        Err(WinshiftError::Stop)
    }
}

static GLOBAL_STOP_HANDLE: Mutex<Option<HookStopHandle>> = Mutex::new(None);

fn install_global_stop_handle(handle: &HookStopHandle) {
    *GLOBAL_STOP_HANDLE.lock().unwrap() = Some(handle.clone());
}

fn clear_global_stop_handle() {
    *GLOBAL_STOP_HANDLE.lock().unwrap() = None;
}

pub(crate) fn run_hook_with_config(
    handler: Arc<RwLock<dyn FocusChangeHandler>>,
    config: &crate::hook::WindowHookConfig,
    stop_handle: HookStopHandle,
) -> Result<(), WinshiftError> {
    trace!(
        "Starting macOS hook with monitoring mode: {:?}",
        config.monitoring_mode
    );
    EMBED_ACTIVE_INFO.store(config.embed_active_info, Ordering::Relaxed);
    run_accessibility_hook_with_mode(handler, config.monitoring_mode, stop_handle)
}

// ===== Active window info (CG + AX comparison) =====

#[link(name = "CoreGraphics", kind = "framework")]
extern "C" {
    fn CFRelease(cf: *const ffi::c_void);
    fn CGWindowListCopyWindowInfo(option: u32, relativeToWindow: u32) -> *mut ffi::c_void;
}

// libproc for resolving executable path from PID
#[link(name = "proc")]
extern "C" {
    fn proc_pidpath(pid: i32, buffer: *mut libc::c_char, buffersize: u32) -> i32;
}

use core_foundation::array::CFArray;
use core_foundation::boolean::{kCFBooleanTrue, CFBooleanRef};
use core_foundation::dictionary::CFDictionary;
use core_foundation::dictionary::__CFDictionary;
use core_foundation::number::CFNumber;
use core_foundation::number::__CFNumber;

const K_CGWINDOW_LIST_OPTION_ON_SCREEN_ONLY: u32 = 1 << 0;
const K_CGWINDOW_LIST_EXCLUDE_DESKTOP_ELEMENTS: u32 = 1 << 4;
const K_CGNULL_WINDOW_ID: u32 = 0;
const INVALID_WINDOW_ID: u32 = u32::MAX;
const PROC_PIDPATHINFO_MAXSIZE: usize = 4096;

#[derive(Debug, Clone, Copy)]
pub struct WindowBounds {
    pub x: f64,
    pub y: f64,
    pub width: f64,
    pub height: f64,
}

#[derive(Debug, Clone)]
pub struct ActiveWindowInfo {
    pub title: String,
    pub app_name: String,
    pub window_id: u32,
    pub process_id: i32,
    pub bounds: WindowBounds,
    pub proc_path: String,
}

// Get the current active window info by first asking AX for the focused
// window's PID/title/bounds, then matching a CoreGraphics window to retrieve
// its stable window_id. This function does not require inputs.
pub fn get_active_window_info() -> Result<ActiveWindowInfo, WinshiftError> {
    autoreleasepool(|| {
        // Find frontmost application (PID + name)
        let (pid, app_name) = unsafe {
            let workspace_class = class!(NSWorkspace);
            let workspace: *mut runtime::Object = msg_send![workspace_class, sharedWorkspace];
            let frontmost_app: *mut runtime::Object = msg_send![workspace, frontmostApplication];
            if frontmost_app.is_null() {
                return Err(WinshiftError::MacOS("No frontmost application".into()));
            }
            let pid: i32 = msg_send![frontmost_app, processIdentifier];
            let name = get_app_name_by_pid(pid).unwrap_or_else(|| String::from("Unknown"));
            (pid, name)
        };

        // Build a partial ActiveWindowInfo with AX data when available.
        let mut info = ActiveWindowInfo {
            title: String::new(),
            app_name,
            window_id: INVALID_WINDOW_ID,
            process_id: pid,
            bounds: WindowBounds {
                x: 0.0,
                y: 0.0,
                width: 0.0,
                height: 0.0,
            },
            proc_path: get_proc_path_by_pid(pid).unwrap_or_default(),
        };

        unsafe {
            if accessibility_sys::AXIsProcessTrusted() {
                let app_element = accessibility_sys::AXUIElementCreateApplication(pid);

                let mut focused_window: *mut ffi::c_void = ptr::null_mut();
                let focused_attr =
                    CFString::from_static_string(accessibility_sys::kAXFocusedWindowAttribute);
                let res = accessibility_sys::AXUIElementCopyAttributeValue(
                    app_element,
                    focused_attr.as_concrete_TypeRef(),
                    std::ptr::from_mut::<*mut ffi::c_void>(&mut focused_window)
                        .cast::<*const ffi::c_void>(),
                );
                if res == 0 && !focused_window.is_null() {
                    let mut title_ptr: *mut ffi::c_void = ptr::null_mut();
                    let title_attr =
                        CFString::from_static_string(accessibility_sys::kAXTitleAttribute);
                    let _ = accessibility_sys::AXUIElementCopyAttributeValue(
                        focused_window as _,
                        title_attr.as_concrete_TypeRef(),
                        std::ptr::from_mut::<*mut ffi::c_void>(&mut title_ptr)
                            .cast::<*const ffi::c_void>(),
                    );
                    if !title_ptr.is_null() {
                        let cf_value = CFType::wrap_under_create_rule(title_ptr);
                        if let Some(s) = cf_value.downcast::<CFString>() {
                            info.title = s.to_string();
                        }
                    }

                    let mut pos_ptr: *mut ffi::c_void = ptr::null_mut();
                    let pos_attr =
                        CFString::from_static_string(accessibility_sys::kAXPositionAttribute);
                    let _ = accessibility_sys::AXUIElementCopyAttributeValue(
                        focused_window as _,
                        pos_attr.as_concrete_TypeRef(),
                        std::ptr::from_mut::<*mut ffi::c_void>(&mut pos_ptr)
                            .cast::<*const ffi::c_void>(),
                    );

                    let mut size_ptr: *mut ffi::c_void = ptr::null_mut();
                    let size_attr =
                        CFString::from_static_string(accessibility_sys::kAXSizeAttribute);
                    let _ = accessibility_sys::AXUIElementCopyAttributeValue(
                        focused_window as _,
                        size_attr.as_concrete_TypeRef(),
                        std::ptr::from_mut::<*mut ffi::c_void>(&mut size_ptr)
                            .cast::<*const ffi::c_void>(),
                    );

                    if !pos_ptr.is_null() && !size_ptr.is_null() {
                        #[repr(C)]
                        struct CGPoint64 {
                            x: f64,
                            y: f64,
                        }
                        #[repr(C)]
                        struct CGSize64 {
                            width: f64,
                            height: f64,
                        }
                        if accessibility_sys::AXValueGetType(
                            pos_ptr as accessibility_sys::AXValueRef,
                        ) == accessibility_sys::kAXValueTypeCGPoint
                            && accessibility_sys::AXValueGetType(
                                size_ptr as accessibility_sys::AXValueRef,
                            ) == accessibility_sys::kAXValueTypeCGSize
                        {
                            let mut p = CGPoint64 { x: 0.0, y: 0.0 };
                            let mut s = CGSize64 {
                                width: 0.0,
                                height: 0.0,
                            };
                            let ok_p = accessibility_sys::AXValueGetValue(
                                pos_ptr as accessibility_sys::AXValueRef,
                                accessibility_sys::kAXValueTypeCGPoint,
                                &mut p as *mut _ as *mut ffi::c_void,
                            );
                            let ok_s = accessibility_sys::AXValueGetValue(
                                size_ptr as accessibility_sys::AXValueRef,
                                accessibility_sys::kAXValueTypeCGSize,
                                &mut s as *mut _ as *mut ffi::c_void,
                            );
                            if ok_p && ok_s {
                                info.bounds = WindowBounds {
                                    x: p.x,
                                    y: p.y,
                                    width: s.width,
                                    height: s.height,
                                };
                            }
                        }
                    }

                    if !pos_ptr.is_null() {
                        CFRelease(pos_ptr);
                    }
                    if !size_ptr.is_null() {
                        CFRelease(size_ptr);
                    }
                    CFRelease(focused_window);
                }
                CFRelease(app_element as *const ffi::c_void);
            }
        }

        match_active_window(
            &mut info,
            MatchOptions {
                match_title: false,
                match_bounds: false,
                bounds_tolerance: 1.0,
            },
        )?;
        Ok(info)
    })
}

// Lazy field accessors for CG window dictionaries
fn dict_get_i32(d: &CFDictionary, key: &'static str) -> Option<i32> {
    unsafe {
        let k = CFString::from_static_string(key);
        let v = *d.get(k.as_concrete_TypeRef() as *const _);
        if v.is_null() {
            return None;
        }
        let n = v as *const __CFNumber;
        if n.is_null() {
            return None;
        }
        CFNumber::wrap_under_get_rule(n).to_i32()
    }
}

fn dict_get_bool(d: &CFDictionary, key: &'static str) -> Option<bool> {
    unsafe {
        let k = CFString::from_static_string(key);
        let v = *d.get(k.as_concrete_TypeRef() as *const _);
        if v.is_null() {
            return None;
        }
        let b = v as CFBooleanRef;
        Some(b == kCFBooleanTrue)
    }
}

fn dict_get_f64(d: &CFDictionary, key: &'static str) -> Option<f64> {
    unsafe {
        let k = CFString::from_static_string(key);
        let v = *d.get(k.as_concrete_TypeRef() as *const _);
        if v.is_null() {
            return None;
        }
        let n = v as *const __CFNumber;
        if n.is_null() {
            return None;
        }
        CFNumber::wrap_under_get_rule(n).to_f64()
    }
}

fn dict_get_string(d: &CFDictionary, key: &'static str) -> Option<String> {
    unsafe {
        let k = CFString::from_static_string(key);

        if !d.contains_key(&(k.as_concrete_TypeRef() as *const _)) {
            return None;
        }

        let v = *d.get(k.as_concrete_TypeRef() as *const _);
        if v.is_null() {
            return None;
        }

        if CFGetTypeID(v) != CFStringGetTypeID() {
            return None;
        }

        let s = CFString::wrap_under_get_rule(v as CFStringRef);
        Some(s.to_string())
    }
}

fn dict_get_bounds(d: &CFDictionary) -> Option<WindowBounds> {
    unsafe {
        let bounds_key = CFString::from_static_string("kCGWindowBounds");
        let ptr = *d.get(bounds_key.as_concrete_TypeRef() as *const _);
        if ptr.is_null() {
            return None;
        }
        let dict =
            CFDictionary::<CFString, CFNumber>::wrap_under_get_rule(ptr as *const __CFDictionary);
        let x = dict
            .get(CFString::from_static_string("X").as_concrete_TypeRef() as *const _)
            .to_f64();
        let y = dict
            .get(CFString::from_static_string("Y").as_concrete_TypeRef() as *const _)
            .to_f64();
        let w = dict
            .get(CFString::from_static_string("Width").as_concrete_TypeRef() as *const _)
            .to_f64();
        let h = dict
            .get(CFString::from_static_string("Height").as_concrete_TypeRef() as *const _)
            .to_f64();
        match (x, y, w, h) {
            (Some(x), Some(y), Some(w), Some(h)) => Some(WindowBounds {
                x,
                y,
                width: w,
                height: h,
            }),
            _ => None,
        }
    }
}

#[derive(Debug, Clone, Copy)]
pub struct MatchOptions {
    pub match_title: bool,
    pub match_bounds: bool,
    pub bounds_tolerance: f64,
}

pub fn match_active_window(
    info: &mut ActiveWindowInfo,
    opts: MatchOptions,
) -> Result<(), WinshiftError> {
    // Single CoreGraphics call: returns CFArray of window dictionaries
    let info_arr = unsafe {
        CGWindowListCopyWindowInfo(
            K_CGWINDOW_LIST_OPTION_ON_SCREEN_ONLY | K_CGWINDOW_LIST_EXCLUDE_DESKTOP_ELEMENTS,
            K_CGNULL_WINDOW_ID,
        )
    };
    if info_arr.is_null() {
        return Err(WinshiftError::MacOS(
            "CGWindowListCopyWindowInfo failed".into(),
        ));
    }
    let arr = unsafe {
        CFArray::<CFDictionary>::wrap_under_get_rule(
            info_arr as *const core_foundation::array::__CFArray,
        )
    };

    for i in 0..arr.len() {
        if let Some(d) = arr.get(i) {
            // Fast reject order: layer -> pid -> onscreen -> alpha
            if dict_get_i32(&d, "kCGWindowLayer") != Some(0) {
                continue;
            }
            if dict_get_i32(&d, "kCGWindowOwnerPID") != Some(info.process_id) {
                continue;
            }
            if dict_get_bool(&d, "kCGWindowIsOnscreen") != Some(true) {
                continue;
            }
            if !dict_get_f64(&d, "kCGWindowAlpha")
                .map(|a| a > 0.0)
                .unwrap_or(false)
            {
                continue;
            }

            if opts.match_title && !info.title.is_empty() {
                if let Some(cg_title) = dict_get_string(&d, "kCGWindowName") {
                    if info.title != cg_title {
                        continue;
                    }
                } else {
                    // No CG title present; cannot match title -> skip title check
                }
            }
            if opts.match_bounds && (info.bounds.width > 0.0 || info.bounds.height > 0.0) {
                if let Some(cb) = dict_get_bounds(&d) {
                    let tol = opts.bounds_tolerance;
                    if (info.bounds.x - cb.x).abs() > tol
                        || (info.bounds.y - cb.y).abs() > tol
                        || (info.bounds.width - cb.width).abs() > tol
                        || (info.bounds.height - cb.height).abs() > tol
                    {
                        continue;
                    }
                } else {
                    // No CG bounds present; cannot match bounds -> skip bounds check
                }
            }

            if let Some(id_i32) = dict_get_i32(&d, "kCGWindowNumber") {
                info.window_id = id_i32 as u32;
                // Fill missing fields by default if available from CG
                if info.title.is_empty() {
                    if let Some(cg_title) = dict_get_string(&d, "kCGWindowName") {
                        info.title = cg_title;
                    }
                }
                if (info.bounds.width == 0.0 && info.bounds.height == 0.0)
                    || (info.bounds.width.is_nan() || info.bounds.height.is_nan())
                {
                    if let Some(cb) = dict_get_bounds(&d) {
                        info.bounds = cb;
                    }
                }
                break;
            }
        }
    }

    unsafe { CFRelease(info_arr) };

    if info.window_id == INVALID_WINDOW_ID {
        return Err(WinshiftError::MacOS("No qualifying window found".into()));
    }
    Ok(())
}

unsafe extern "C" fn window_focus_callback(
    observer: accessibility_sys::AXObserverRef,
    element: accessibility_sys::AXUIElementRef,
    _notification: core_foundation::string::CFStringRef,
    user_info: *mut ffi::c_void,
) {
    use accessibility_sys::{kAXTitleAttribute, AXUIElementCopyAttributeValue};
    use core_foundation::base::{CFType, TCFType};
    use core_foundation::string::CFString;
    use std::ptr;

    trace!(
        "Window focus callback entry - observer: {:p}, element: {:p}, user_info: {:p}",
        observer,
        element,
        user_info
    );

    if user_info.is_null() {
        error!("FATAL: user_info is null in window_focus_callback!");
        return;
    }

    if element.is_null() {
        error!("FATAL: element is null in window_focus_callback!");
        return;
    }

    trace!("Pointers validated, dereferencing handler...");
    let handler = &*(user_info as *const Arc<RwLock<dyn FocusChangeHandler>>);
    trace!("Handler dereferenced successfully");

    let mut title_ptr: *mut ffi::c_void = ptr::null_mut();
    let title_attr = CFString::from_static_string(kAXTitleAttribute);

    let result = AXUIElementCopyAttributeValue(
        element,
        title_attr.as_concrete_TypeRef(),
        std::ptr::from_mut::<*mut ffi::c_void>(&mut title_ptr).cast::<*const ffi::c_void>(),
    );

    if result == 0 && !title_ptr.is_null() {
        let cf_title = CFType::wrap_under_create_rule(title_ptr);

        if let Some(cf_string) = cf_title.downcast::<CFString>() {
            let window_title = cf_string.to_string();

            if !window_title.is_empty() {
                debug!("Window focus changed to: '{}'", window_title);

                trace!("Acquiring handler read lock...");
                if let Ok(guard) = handler.read() {
                    guard.on_window_change(window_title.clone());
                    // Optionally emit embedded ActiveWindowInfo to avoid separate user calls
                    if EMBED_ACTIVE_INFO.load(Ordering::Relaxed) {
                        if let Ok(info) = get_active_window_info() {
                            guard.on_window_change_info(info);
                        }
                    }
                } else {
                    error!("Failed to acquire handler read lock");
                }
            }
        } else {
            warn!("Failed to downcast CFType to CFString");
        }
    } else {
        warn!(
            "Failed to get window title, result: {}, ptr null: {}",
            result,
            title_ptr.is_null()
        );
    }

    trace!("Window focus callback exit");
}

struct ObserverInfo {
    run_loop_source: core_foundation::runloop::CFRunLoopSource,
    observer: accessibility_sys::AXObserverRef,
    app_element: accessibility_sys::AXUIElementRef,
    handler_ptr: *mut Arc<RwLock<dyn FocusChangeHandler>>,
}

fn run_accessibility_hook_with_mode(
    handler: Arc<RwLock<dyn FocusChangeHandler>>,
    mode: crate::hook::MonitoringMode,
    stop_handle: HookStopHandle,
) -> Result<(), WinshiftError> {
    use crate::hook::MonitoringMode;

    match mode {
        MonitoringMode::Combined => run_accessibility_hook(handler, stop_handle),
        MonitoringMode::AppOnly => run_app_only_hook(handler, stop_handle),
        MonitoringMode::WindowOnly => run_window_only_hook(handler, stop_handle),
    }
}

fn run_accessibility_hook(
    handler: Arc<RwLock<dyn FocusChangeHandler>>,
    stop_handle: HookStopHandle,
) -> Result<(), WinshiftError> {
    use accessibility_sys::{
        kAXFocusedWindowChangedNotification, AXIsProcessTrusted, AXObserverAddNotification,
        AXObserverCallback, AXObserverCreate, AXObserverGetRunLoopSource,
        AXObserverRemoveNotification,
        AXUIElementCreateApplication,
    };

    info!("Using Accessibility API for event-driven window monitoring");

    if !unsafe { AXIsProcessTrusted() } {
        return Err(WinshiftError::Platform(
                "Accessibility permissions required. Please enable accessibility access in system settings".to_string(),
            ));
    }

    info!("Accessibility permissions verified");

    // Handler pointer for NSWorkspace observer glue
    let handler_ptr = Box::into_raw(Box::new(handler.clone()));

    static mut OBSERVERS: Option<HashMap<i32, ObserverInfo>> = None;
    unsafe {
        OBSERVERS = Some(HashMap::new());
    }
    static mut WINDOW_MONITOR_OBSERVER: *mut Object = ptr::null_mut();

    unsafe fn cleanup_observer_info(pid: i32, observer_info: ObserverInfo) {
        let window_notification = CFString::from_static_string(kAXFocusedWindowChangedNotification);
        let run_loop = CFRunLoop::get_current();
        run_loop.remove_source(&observer_info.run_loop_source, kCFRunLoopDefaultMode);

        let result = AXObserverRemoveNotification(
            observer_info.observer,
            observer_info.app_element,
            window_notification.as_concrete_TypeRef(),
        );
        trace!(
            "AXObserverRemoveNotification result for PID {}: {}",
            pid,
            result
        );

        let _ = Box::from_raw(observer_info.handler_ptr);
        CFRelease(observer_info.app_element as *const ffi::c_void);
        CFRelease(observer_info.observer as *const ffi::c_void);
    }

    unsafe fn create_observer_for_app(
        pid: i32,
        handler: &Arc<RwLock<dyn FocusChangeHandler>>,
    ) -> Result<ObserverInfo, WinshiftError> {
        trace!("Creating observer for PID: {}", pid);
        let mut observer = ptr::null_mut();
        let callback: AXObserverCallback = window_focus_callback;

        let result = AXObserverCreate(pid, callback, &mut observer);
        trace!("AXObserverCreate result for PID {}: {}", pid, result);
        if result != 0 {
            return Err(WinshiftError::Platform(format!(
                "Failed to create AX observer for PID {pid}: {result}"
            )));
        }

        let app_element = AXUIElementCreateApplication(pid);
        trace!("Created AXUIElement for PID: {}", pid);

        let window_notification = CFString::from_static_string(kAXFocusedWindowChangedNotification);

        let handler_ptr = Box::into_raw(Box::new(handler.clone()));

        let result = AXObserverAddNotification(
            observer,
            app_element,
            window_notification.as_concrete_TypeRef(),
            handler_ptr.cast::<ffi::c_void>(),
        );

        trace!(
            "AXObserverAddNotification result for PID {}: {}",
            pid,
            result
        );
        if result != 0 {
            use accessibility_sys::error_string;
            warn!(
                "Failed to add window focus notification for PID {}: {} ({})",
                pid,
                result,
                error_string(result)
            );
            let _ = Box::from_raw(handler_ptr);
            CFRelease(app_element as *const ffi::c_void);
            CFRelease(observer as *const ffi::c_void);
            return Err(WinshiftError::Platform(format!(
                "Failed to add notification for PID {}: {} ({})",
                pid,
                result,
                error_string(result)
            )));
        }

        let run_loop_source = AXObserverGetRunLoopSource(observer);
        let run_loop = CFRunLoop::get_current();
        use core_foundation::runloop::CFRunLoopSource;
        let cf_source = CFRunLoopSource::wrap_under_get_rule(run_loop_source);
        run_loop.add_source(&cf_source, kCFRunLoopDefaultMode);

        info!(
            "Successfully created accessibility observer for application PID: {}",
            pid
        );
        Ok(ObserverInfo {
            run_loop_source: cf_source,
            observer,
            app_element,
            handler_ptr,
        })
    }

    static mut GLOBAL_HANDLER: Option<Arc<RwLock<dyn FocusChangeHandler>>> = None;

    unsafe fn setup_nsworkspace_notifications(
        handler_ptr: *mut Arc<RwLock<dyn FocusChangeHandler>>,
    ) -> Result<(), WinshiftError> {
        trace!("Setting up NSWorkspace notifications");

        GLOBAL_HANDLER = Some((*handler_ptr).clone());

        extern "C" fn application_did_activate(
            this: &Object,
            _cmd: Sel,
            notification: *mut Object,
        ) {
            unsafe {
                trace!(
                    "NSWorkspace callback entry - this: {:p}, notification: {:p}",
                    this,
                    notification
                );

                if notification.is_null() {
                    error!("FATAL: notification is null!");
                    return;
                }

                trace!("Getting global handler...");
                if let Some(handler) = (&raw const GLOBAL_HANDLER).as_ref().unwrap() {
                    trace!("Global handler found, extracting application info...");

                    trace!("Getting userInfo from notification...");
                    let user_info: *mut Object = msg_send![notification, userInfo];
                    trace!("userInfo result: {:p}", user_info);

                    if !user_info.is_null() {
                        trace!("Creating app key...");
                        let app_key = CFString::from_static_string("NSWorkspaceApplicationKey");
                        trace!("Getting app object from userInfo...");
                        let app: *mut Object =
                            msg_send![user_info, objectForKey: app_key.as_concrete_TypeRef()];
                        trace!("App object result: {:p}", app);

                        if !app.is_null() {
                            trace!("Getting process identifier...");
                            let pid: i32 = msg_send![app, processIdentifier];
                            // Use localizedName directly from the NSRunningApplication
                            let app_name = {
                                let localized_name: *mut Object = msg_send![app, localizedName];
                                if !localized_name.is_null() {
                                    let name_str: *const std::ffi::c_char =
                                        msg_send![localized_name, UTF8String];
                                    if !name_str.is_null() {
                                        if let Ok(name) =
                                            std::ffi::CStr::from_ptr(name_str).to_str()
                                        {
                                            name.to_string()
                                        } else {
                                            format!("Unknown (PID: {pid})")
                                        }
                                    } else {
                                        format!("Unknown (PID: {pid})")
                                    }
                                } else {
                                    format!("Unknown (PID: {pid})")
                                }
                            };
                            debug!("Application switched to PID {} ({})", pid, app_name);

                            trace!("Checking if observer already exists for PID {}...", pid);
                            if let Some(observers) = (&raw mut OBSERVERS).as_mut().unwrap() {
                                if !observers.contains_key(&pid) {
                                    trace!(
                                        "No existing observer, creating new one for PID {}",
                                        pid
                                    );

                                    trace!(
                                        "Calling create_observer_for_app with handler reference..."
                                    );

                                    match create_observer_for_app(pid, handler) {
                                        Ok(observer_info) => {
                                            trace!("Observer created successfully, cleaning up old observers...");
                                            for (old_pid, old_observer_info) in observers.drain() {
                                                trace!(
                                                    "Cleaning up observer for old PID: {}",
                                                    old_pid
                                                );
                                                cleanup_observer_info(old_pid, old_observer_info);
                                            }

                                            trace!("Inserting new observer for PID {}...", pid);
                                            observers.insert(pid, observer_info);
                                            info!("Created AX observer for app PID: {}", pid);

                                            // Optionally gather full ActiveWindowInfo once
                                            let maybe_info =
                                                if EMBED_ACTIVE_INFO.load(Ordering::Relaxed) {
                                                    get_active_window_info().ok()
                                                } else {
                                                    None
                                                };

                                            // Notify app change
                                            if let Ok(guard) = handler.read() {
                                                guard.on_app_change(pid, app_name.clone());
                                                if let Some(ref info) = maybe_info {
                                                    guard.on_app_change_info(info.clone());
                                                }
                                            }

                                            // Notify window change using either computed info or AX title
                                            if let Some(info) = maybe_info {
                                                if let Ok(guard) = handler.read() {
                                                    if !info.title.is_empty() {
                                                        guard.on_window_change(info.title.clone());
                                                    }
                                                    guard.on_window_change_info(info);
                                                }
                                            } else if let Some(title) = get_current_window_title() {
                                                if let Ok(guard) = handler.read() {
                                                    guard.on_window_change(title);
                                                }
                                            }
                                        }
                                        Err(e) => {
                                            warn!("Failed to create AX observer for activated app PID {}: {}", pid, e);
                                        }
                                    }

                                    trace!("Observer creation completed successfully");
                                } else {
                                    trace!(
                                        "Observer already exists for PID {}, skipping creation",
                                        pid
                                    );
                                }
                            } else {
                                error!("OBSERVERS is None!");
                            }
                        } else {
                            warn!("App object is null from userInfo");
                        }
                    } else {
                        warn!("userInfo is null from notification");
                    }
                } else {
                    error!("GLOBAL_HANDLER is None!");
                }

                trace!("NSWorkspace callback exit");
            }
        }

        let observer_class = if let Some(existing) = Class::get("WindowMonitorObserver") {
            trace!("Reusing existing WindowMonitorObserver class");
            existing
        } else {
            let superclass = class!(NSObject);
            let mut decl =
                ClassDecl::new("WindowMonitorObserver", superclass).ok_or_else(|| {
                    WinshiftError::Platform("Failed to create observer class".to_string())
                })?;
            decl.add_method(
                sel!(applicationDidActivate:),
                application_did_activate as extern "C" fn(&Object, Sel, *mut Object),
            );
            let observer_class = decl.register();
            trace!("Created WindowMonitorObserver class");
            observer_class
        };

        let observer_instance: *mut Object = msg_send![observer_class, alloc];
        let observer_instance: *mut Object = msg_send![observer_instance, init];

        let workspace_class = class!(NSWorkspace);
        let workspace: *mut Object = msg_send![workspace_class, sharedWorkspace];
        let notification_center: *mut Object = msg_send![workspace, notificationCenter];

        if !WINDOW_MONITOR_OBSERVER.is_null() {
            let _: () = msg_send![notification_center, removeObserver: WINDOW_MONITOR_OBSERVER];
            let _: () = msg_send![WINDOW_MONITOR_OBSERVER, release];
            WINDOW_MONITOR_OBSERVER = ptr::null_mut();
        }

        let notification_name =
            CFString::from_static_string("NSWorkspaceDidActivateApplicationNotification");
        let _: () = msg_send![
            notification_center,
            addObserver: observer_instance
            selector: sel!(applicationDidActivate:)
            name: notification_name.as_concrete_TypeRef()
            object: ptr::null_mut::<Object>()
        ];
        WINDOW_MONITOR_OBSERVER = observer_instance;

        info!("Successfully registered for NSWorkspaceDidActivateApplicationNotification");
        Ok(())
    }

    unsafe {
        let workspace_class = class!(NSWorkspace);
        let workspace: *mut Object = msg_send![workspace_class, sharedWorkspace];
        let frontmost_app: *mut Object = msg_send![workspace, frontmostApplication];

        if !frontmost_app.is_null() {
            let initial_pid: i32 = msg_send![frontmost_app, processIdentifier];
            trace!("Initial frontmost app PID: {}", initial_pid);

            if initial_pid > 0 {
                match create_observer_for_app(initial_pid, &handler) {
                    Ok(observer_info) => {
                        if let Some(observers) = (&raw mut OBSERVERS).as_mut().unwrap() {
                            observers.insert(initial_pid, observer_info);
                            info!(
                                "Created initial observer for current app PID: {}",
                                initial_pid
                            );

                            let app_name = get_app_name_by_pid(initial_pid)
                                .unwrap_or_else(|| format!("Unknown (PID: {initial_pid})"));
                            info!("Initial app: {} (PID: {})", app_name, initial_pid);
                            if let Ok(guard) = handler.read() {
                                guard.on_app_change(initial_pid, app_name);
                            }

                            if let Some(title) = get_current_window_title() {
                                info!("Initial window: '{}'", title);
                                if let Ok(guard) = handler.read() {
                                    guard.on_window_change(title);
                                }
                            }
                        }
                    }
                    Err(e) => {
                        warn!("Failed to create initial observer: {}", e);
                    }
                }
            }
        }

        info!("Accessibility observer started - event-driven window monitoring active");

        setup_nsworkspace_notifications(handler_ptr)?;

        info!("Event-driven NSWorkspace monitoring active");
        run_cfrunloop(&stop_handle);

        if let Some(observers) = (&raw mut OBSERVERS).as_mut().unwrap() {
            for (pid, observer_info) in observers.drain() {
                trace!("Cleaning up observer for PID: {}", pid);
                cleanup_observer_info(pid, observer_info);
            }
        }

        let workspace_class = class!(NSWorkspace);
        let workspace: *mut Object = msg_send![workspace_class, sharedWorkspace];
        let notification_center: *mut Object = msg_send![workspace, notificationCenter];
        if !WINDOW_MONITOR_OBSERVER.is_null() {
            let _: () = msg_send![notification_center, removeObserver: WINDOW_MONITOR_OBSERVER];
            let _: () = msg_send![WINDOW_MONITOR_OBSERVER, release];
            WINDOW_MONITOR_OBSERVER = ptr::null_mut();
        }

        CURRENT_RUN_LOOP = None;
        GLOBAL_HANDLER = None;
        let _ = Box::from_raw(handler_ptr);
        trace!("Accessibility hook stopped");
    }

    Ok(())
}

fn run_app_only_hook(
    handler: Arc<RwLock<dyn FocusChangeHandler>>,
    stop_handle: HookStopHandle,
) -> Result<(), WinshiftError> {
    use core_foundation::base::TCFType;
    use core_foundation::string::CFString;
    use objc2::declare::ClassDecl;
    use objc2::runtime::{Object, Sel};
    use objc2::{class, msg_send, sel};
    use std::ptr;

    info!("Using NSWorkspace for app-only monitoring (no window observers)");

    if !unsafe { accessibility_sys::AXIsProcessTrusted() } {
        return Err(WinshiftError::Platform(
            "Accessibility permissions required. Please enable accessibility access in system settings".to_string(),
        ));
    }

    info!("Accessibility permissions verified");

    static mut GLOBAL_HANDLER: Option<Arc<RwLock<dyn FocusChangeHandler>>> = None;
    static mut APP_ONLY_OBSERVER: *mut Object = ptr::null_mut();
    unsafe fn setup_nsworkspace_notifications_only(
        handler_ptr: *mut Arc<RwLock<dyn FocusChangeHandler>>,
    ) -> Result<(), WinshiftError> {
        trace!("Setting up NSWorkspace notifications (app-only mode)");

        GLOBAL_HANDLER = Some((*handler_ptr).clone());

        extern "C" fn application_did_activate(
            this: &Object,
            _cmd: Sel,
            notification: *mut Object,
        ) {
            unsafe {
                trace!(
                    "NSWorkspace callback entry - this: {:p}, notification: {:p}",
                    this,
                    notification
                );

                if notification.is_null() {
                    error!("FATAL: notification is null!");
                    return;
                }

                if let Some(handler) = (&raw const GLOBAL_HANDLER).as_ref().unwrap() {
                    let user_info: *mut Object = msg_send![notification, userInfo];

                    if !user_info.is_null() {
                        let app_key = CFString::from_static_string("NSWorkspaceApplicationKey");
                        let app: *mut Object =
                            msg_send![user_info, objectForKey: app_key.as_concrete_TypeRef()];

                        if !app.is_null() {
                            let pid: i32 = msg_send![app, processIdentifier];
                            let app_name = {
                                let localized_name: *mut Object = msg_send![app, localizedName];
                                if !localized_name.is_null() {
                                    let name_str: *const std::ffi::c_char =
                                        msg_send![localized_name, UTF8String];
                                    if !name_str.is_null() {
                                        if let Ok(name) =
                                            std::ffi::CStr::from_ptr(name_str).to_str()
                                        {
                                            name.to_string()
                                        } else {
                                            format!("Unknown (PID: {pid})")
                                        }
                                    } else {
                                        format!("Unknown (PID: {pid})")
                                    }
                                } else {
                                    format!("Unknown (PID: {pid})")
                                }
                            };
                            debug!("Application switched to PID {} ({})", pid, app_name);

                            // Optionally attach ActiveWindowInfo to this app event
                            let maybe_info = if EMBED_ACTIVE_INFO.load(Ordering::Relaxed) {
                                get_active_window_info().ok()
                            } else {
                                None
                            };

                            if let Ok(guard) = handler.read() {
                                guard.on_app_change(pid, app_name);
                                if let Some(info) = maybe_info {
                                    guard.on_app_change_info(info);
                                }
                            }
                        }
                    }
                }
            }
        }

        let observer_class = if let Some(existing) = Class::get("AppOnlyObserver") {
            trace!("Reusing existing AppOnlyObserver class");
            existing
        } else {
            let superclass = class!(NSObject);
            let mut decl = ClassDecl::new("AppOnlyObserver", superclass).ok_or_else(|| {
                WinshiftError::Platform("Failed to create observer class".to_string())
            })?;
            decl.add_method(
                sel!(applicationDidActivate:),
                application_did_activate as extern "C" fn(&Object, Sel, *mut Object),
            );
            decl.register()
        };
        let observer_instance: *mut Object = msg_send![observer_class, alloc];
        let observer_instance: *mut Object = msg_send![observer_instance, init];

        let workspace_class = class!(NSWorkspace);
        let workspace: *mut Object = msg_send![workspace_class, sharedWorkspace];
        let notification_center: *mut Object = msg_send![workspace, notificationCenter];

        if !APP_ONLY_OBSERVER.is_null() {
            let _: () = msg_send![notification_center, removeObserver: APP_ONLY_OBSERVER];
            let _: () = msg_send![APP_ONLY_OBSERVER, release];
            APP_ONLY_OBSERVER = ptr::null_mut();
        }

        let notification_name =
            CFString::from_static_string("NSWorkspaceDidActivateApplicationNotification");
        let _: () = msg_send![
            notification_center,
            addObserver: observer_instance
            selector: sel!(applicationDidActivate:)
            name: notification_name.as_concrete_TypeRef()
            object: ptr::null_mut::<Object>()
        ];
        APP_ONLY_OBSERVER = observer_instance;

        info!("App-only monitoring active - no window observers created");
        Ok(())
    }

    let handler_ptr = Box::into_raw(Box::new(handler.clone()));

    unsafe {
        // Get initial app state
        let workspace_class = class!(NSWorkspace);
        let workspace: *mut Object = msg_send![workspace_class, sharedWorkspace];
        let frontmost_app: *mut Object = msg_send![workspace, frontmostApplication];

        if !frontmost_app.is_null() {
            let initial_pid: i32 = msg_send![frontmost_app, processIdentifier];
            let app_name = {
                let localized_name: *mut Object = msg_send![frontmost_app, localizedName];
                if !localized_name.is_null() {
                    let name_str: *const std::ffi::c_char = msg_send![localized_name, UTF8String];
                    if !name_str.is_null() {
                        std::ffi::CStr::from_ptr(name_str)
                            .to_str()
                            .map(|s| s.to_string())
                            .unwrap_or_else(|_| format!("Unknown (PID: {initial_pid})"))
                    } else {
                        format!("Unknown (PID: {initial_pid})")
                    }
                } else {
                    format!("Unknown (PID: {initial_pid})")
                }
            };
            info!("Initial app: {} (PID: {})", app_name, initial_pid);
            if let Ok(guard) = handler.read() {
                guard.on_app_change(initial_pid, app_name);
            }
        }

        setup_nsworkspace_notifications_only(handler_ptr)?;
        run_cfrunloop(&stop_handle);

        let workspace_class = class!(NSWorkspace);
        let workspace: *mut Object = msg_send![workspace_class, sharedWorkspace];
        let notification_center: *mut Object = msg_send![workspace, notificationCenter];
        if !APP_ONLY_OBSERVER.is_null() {
            let _: () = msg_send![notification_center, removeObserver: APP_ONLY_OBSERVER];
            let _: () = msg_send![APP_ONLY_OBSERVER, release];
            APP_ONLY_OBSERVER = ptr::null_mut();
        }
        GLOBAL_HANDLER = None;
        let _ = Box::from_raw(handler_ptr);
        trace!("App-only hook stopped");
    }

    Ok(())
}

fn run_window_only_hook(
    handler: Arc<RwLock<dyn FocusChangeHandler>>,
    stop_handle: HookStopHandle,
) -> Result<(), WinshiftError> {
    use accessibility_sys::{
        kAXFocusedWindowChangedNotification, AXIsProcessTrusted, AXObserverAddNotification,
        AXObserverCallback, AXObserverCreate, AXObserverGetRunLoopSource,
        AXObserverRemoveNotification,
        AXUIElementCreateApplication,
    };

    info!("Using Accessibility API for window-only monitoring (no app notifications)");

    if !unsafe { AXIsProcessTrusted() } {
        return Err(WinshiftError::Platform(
            "Accessibility permissions required. Please enable accessibility access in system settings".to_string(),
        ));
    }

    info!("Accessibility permissions verified");

    let handler_ptr = Box::into_raw(Box::new(handler.clone()));

    unsafe fn create_observer_for_current_app(
        handler: &Arc<RwLock<dyn FocusChangeHandler>>,
    ) -> Result<ObserverInfo, WinshiftError> {
        let workspace_class = class!(NSWorkspace);
        let workspace: *mut Object = msg_send![workspace_class, sharedWorkspace];
        let frontmost_app: *mut Object = msg_send![workspace, frontmostApplication];

        if frontmost_app.is_null() {
            return Err(WinshiftError::Platform(
                "No frontmost application found".to_string(),
            ));
        }

        let pid: i32 = msg_send![frontmost_app, processIdentifier];
        trace!("Creating window observer for current app PID: {}", pid);

        let mut observer = ptr::null_mut();
        let callback: AXObserverCallback = window_focus_callback;

        let result = AXObserverCreate(pid, callback, &mut observer);
        if result != 0 {
            return Err(WinshiftError::Platform(format!(
                "Failed to create AX observer: {result}"
            )));
        }

        let app_element = AXUIElementCreateApplication(pid);
        let window_notification = CFString::from_static_string(kAXFocusedWindowChangedNotification);
        let handler_ptr = Box::into_raw(Box::new(handler.clone()));

        let result = AXObserverAddNotification(
            observer,
            app_element,
            window_notification.as_concrete_TypeRef(),
            handler_ptr.cast::<ffi::c_void>(),
        );

        if result != 0 {
            let _ = Box::from_raw(handler_ptr);
            CFRelease(app_element as *const ffi::c_void);
            CFRelease(observer as *const ffi::c_void);
            return Err(WinshiftError::Platform(format!(
                "Failed to add notification: {result}"
            )));
        }

        let run_loop_source = AXObserverGetRunLoopSource(observer);
        let run_loop = CFRunLoop::get_current();
        use core_foundation::runloop::CFRunLoopSource;
        let cf_source = CFRunLoopSource::wrap_under_get_rule(run_loop_source);
        run_loop.add_source(&cf_source, kCFRunLoopDefaultMode);

        info!("Window-only monitoring active for current app PID: {}", pid);
        Ok(ObserverInfo {
            run_loop_source: cf_source,
            observer,
            app_element,
            handler_ptr,
        })
    }

    unsafe {
        let observer_info = create_observer_for_current_app(&handler)?;
        if EMBED_ACTIVE_INFO.load(Ordering::Relaxed) {
            if let Ok(info) = get_active_window_info() {
                if let Ok(guard) = handler.read() {
                    if !info.title.is_empty() {
                        guard.on_window_change(info.title.clone());
                    }
                    guard.on_window_change_info(info);
                }
            }
        } else if let Some(title) = get_current_window_title() {
            if let Ok(guard) = handler.read() {
                guard.on_window_change(title);
            }
        }

        run_cfrunloop(&stop_handle);

        let run_loop = CFRunLoop::get_current();
        run_loop.remove_source(&observer_info.run_loop_source, kCFRunLoopDefaultMode);
        let window_notification = CFString::from_static_string(kAXFocusedWindowChangedNotification);
        let _ = AXObserverRemoveNotification(
            observer_info.observer,
            observer_info.app_element,
            window_notification.as_concrete_TypeRef(),
        );
        let _ = Box::from_raw(observer_info.handler_ptr);
        CFRelease(observer_info.app_element as *const ffi::c_void);
        CFRelease(observer_info.observer as *const ffi::c_void);
        let _ = Box::from_raw(handler_ptr);
        trace!("Window-only hook stopped");
    }

    Ok(())
}

fn run_cfrunloop(stop_handle: &HookStopHandle) {
    info!("Getting current CFRunLoop");

    let run_loop = CFRunLoop::get_current();
    unsafe {
        CURRENT_RUN_LOOP = Some(run_loop.clone());
    }
    stop_handle.set_run_loop(&run_loop);
    install_global_stop_handle(stop_handle);

    info!("CFRunLoop starting");
    CFRunLoop::run_current();
    info!("CFRunLoop stopped");

    unsafe {
        CURRENT_RUN_LOOP = None;
    }
    stop_handle.clear();
    clear_global_stop_handle();
}

fn get_app_name_by_pid(pid: i32) -> Option<String> {
    use objc2::{class, msg_send};

    unsafe {
        // Prefer direct lookup rather than scanning all running apps
        let nsra = class!(NSRunningApplication);
        let app: *mut Object = msg_send![nsra, runningApplicationWithProcessIdentifier: pid];
        if app.is_null() {
            return None;
        }
        let localized_name: *mut Object = msg_send![app, localizedName];
        if localized_name.is_null() {
            return None;
        }
        let name_str: *const std::ffi::c_char = msg_send![localized_name, UTF8String];
        if name_str.is_null() {
            return None;
        }
        std::ffi::CStr::from_ptr(name_str)
            .to_str()
            .map(|s| s.to_string())
            .ok()
    }
}

fn get_proc_path_by_pid(pid: i32) -> Option<String> {
    unsafe {
        let mut buf = vec![0 as libc::c_char; PROC_PIDPATHINFO_MAXSIZE];
        let ret = proc_pidpath(pid, buf.as_mut_ptr(), PROC_PIDPATHINFO_MAXSIZE as u32);
        if ret > 0 {
            // Ensure null-terminated string
            let c_str = std::ffi::CStr::from_ptr(buf.as_ptr());
            if let Ok(raw) = c_str.to_str() {
                // Try to canonicalize to resolve symlinks
                if let Ok(real) = std::fs::canonicalize(raw) {
                    if let Some(s) = real.to_str() {
                        return Some(s.to_string());
                    }
                }
                return Some(raw.to_string());
            }
        }
    }
    None
}

fn get_current_window_title() -> Option<String> {
    use accessibility_sys::{
        kAXFocusedApplicationAttribute, kAXFocusedWindowAttribute, kAXTitleAttribute,
        AXUIElementCopyAttributeValue, AXUIElementCreateSystemWide,
    };

    unsafe {
        let system_element = AXUIElementCreateSystemWide();

        let mut focused_app: *mut ffi::c_void = ptr::null_mut();
        let focused_app_attr = CFString::from_static_string(kAXFocusedApplicationAttribute);
        let result = AXUIElementCopyAttributeValue(
            system_element,
            focused_app_attr.as_concrete_TypeRef(),
            std::ptr::from_mut::<*mut ffi::c_void>(&mut focused_app).cast::<*const ffi::c_void>(),
        );

        if result != 0 || focused_app.is_null() {
            return None;
        }

        let mut focused_window: *mut ffi::c_void = ptr::null_mut();
        let focused_window_attr = CFString::from_static_string(kAXFocusedWindowAttribute);
        let result = AXUIElementCopyAttributeValue(
            focused_app as accessibility_sys::AXUIElementRef,
            focused_window_attr.as_concrete_TypeRef(),
            std::ptr::from_mut::<*mut ffi::c_void>(&mut focused_window)
                .cast::<*const ffi::c_void>(),
        );

        if result != 0 || focused_window.is_null() {
            return None;
        }

        let mut title_ref: *mut ffi::c_void = ptr::null_mut();
        let title_attr = CFString::from_static_string(kAXTitleAttribute);
        let result = AXUIElementCopyAttributeValue(
            focused_window as accessibility_sys::AXUIElementRef,
            title_attr.as_concrete_TypeRef(),
            std::ptr::from_mut::<*mut ffi::c_void>(&mut title_ref).cast::<*const ffi::c_void>(),
        );

        if result != 0 || title_ref.is_null() {
            return None;
        }

        let cf_title = CFType::wrap_under_create_rule(title_ref);
        cf_title
            .downcast::<CFString>()
            .map(|cf_string| cf_string.to_string())
    }
}

#[deprecated(note = "Use instance stop(); stop_hook is a legacy static fallback")]
pub fn stop_hook() -> Result<(), WinshiftError> {
    info!("macOS stop_hook invoked");
    if let Some(handle) = GLOBAL_STOP_HANDLE.lock().unwrap().clone() {
        handle.stop()
    } else {
        warn!("No active hook instance available to stop");
        Err(WinshiftError::Stop)
    }
}