1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
use core::net::SocketAddrV4;
use super::op::OpImpl;
use crate::client::ClientSocketOp;
use crate::stack::constants::MAX_SEND_LENGTH;
use crate::stack::sock_holder::SocketStore;
use crate::stack::socket_callbacks::SocketCallbacks;
use crate::stack::socket_callbacks::{AsyncOp, AsyncState, SendRequest};
use crate::transfer::Xfer;
use crate::Handle;
use crate::StackError;
// Pure UDP send operation state - no references, fully shareable
#[derive(Debug)]
pub struct UdpSendOp<'data> {
handle: Handle,
addr: SocketAddrV4,
data: &'data [u8],
}
impl<'data> UdpSendOp<'data> {
pub fn new(handle: Handle, addr: SocketAddrV4, data: &'data [u8]) -> Self {
Self { handle, addr, data }
}
}
impl<X: Xfer> OpImpl<X> for UdpSendOp<'_> {
type Output = ();
type Error = StackError;
fn poll_impl(
&mut self,
manager: &mut crate::manager::Manager<X>,
callbacks: &mut SocketCallbacks,
) -> Result<Option<Self::Output>, Self::Error> {
// Handle empty payload early - nothing to send
if self.data.is_empty() {
let (_, op) = callbacks
.udp_sockets
.get(self.handle)
.ok_or(StackError::SocketNotFound)?;
*op = ClientSocketOp::None;
return Ok(Some(()));
}
let (sock, op) = callbacks
.udp_sockets
.get(self.handle)
.ok_or(StackError::SocketNotFound)?;
let socket = *sock;
match op {
ClientSocketOp::AsyncOp(AsyncOp::SendTo(req, Some(len)), AsyncState::Done) => {
// Validate callback length parameter
let callback_len = *len;
if callback_len < 0 {
// Negative length is invalid - treat as error
*op = ClientSocketOp::None;
return Err(StackError::OpFailed(callback_len.into()));
}
// Validate callback length doesn't exceed remaining data in buffer
let remaining_in_buffer = self.data.len() - req.offset;
let validated_len = if callback_len as usize > remaining_in_buffer {
// Clamp to remaining data if callback reports more than possible
remaining_in_buffer
} else {
callback_len as usize
};
// Update grand_total_sent using validated length
// Ensure validated_len fits in i16 for arithmetic
if validated_len > i16::MAX as usize {
*op = ClientSocketOp::None;
return Err(StackError::InvalidParameters);
}
let validated_len_i16 = validated_len as i16;
let new_grand_total_sent = req
.grand_total_sent
.checked_add(validated_len_i16)
.ok_or(StackError::InvalidParameters)?;
// Compute new offset using safe checked arithmetic
let offset = req
.offset
.checked_add(validated_len)
.ok_or(StackError::InvalidParameters)?;
if offset >= self.data.len() {
// Complete - reset operation
*op = ClientSocketOp::None;
Ok(Some(()))
} else {
// Continue sending next chunk
let remaining_data = self.data.len() - offset;
let to_send = remaining_data.min(MAX_SEND_LENGTH);
// Ensure to_send fits in i16
if to_send > i16::MAX as usize {
*op = ClientSocketOp::None;
return Err(StackError::InvalidParameters);
}
let new_req = SendRequest {
offset,
grand_total_sent: new_grand_total_sent,
total_sent: 0,
remaining: to_send as i16,
};
// Set operation state BEFORE calling send_sendto to avoid reentrancy races
let prev_op = core::mem::replace(
op,
ClientSocketOp::AsyncOp(
AsyncOp::SendTo(new_req, None),
AsyncState::Pending(None),
),
);
// Now call send_sendto - if it fails, revert to previous state
match manager.send_sendto(
socket,
self.addr,
&self.data[offset..offset + to_send],
) {
Ok(()) => Ok(None), // Still in progress
Err(e) => {
// Revert to previous state on failure
*op = prev_op;
Err(StackError::SendSendFailed(e))
}
}
}
}
ClientSocketOp::AsyncOp(AsyncOp::SendTo(_, None), AsyncState::Pending(_)) => {
// Still waiting for callback response
Ok(None)
}
_ => {
// Not started or in an unexpected state, so initialize
let to_send = self.data.len().min(MAX_SEND_LENGTH);
// Ensure to_send fits in i16
if to_send > i16::MAX as usize {
return Err(StackError::InvalidParameters);
}
let req = SendRequest {
offset: 0,
grand_total_sent: 0,
total_sent: 0,
remaining: to_send as i16,
};
// Set operation state BEFORE calling send_sendto to avoid reentrancy races
// if callbacks run synchronously
let prev_op = core::mem::replace(
op,
ClientSocketOp::AsyncOp(AsyncOp::SendTo(req, None), AsyncState::Pending(None)),
);
// Now call send_sendto - if it fails, revert to previous state
match manager.send_sendto(socket, self.addr, &self.data[..to_send]) {
Ok(()) => Ok(None), // Still in progress
Err(e) => {
// Revert to previous state on failure
*op = prev_op;
Err(StackError::SendSendFailed(e))
}
}
}
}
}
}