we-trust-redis 0.0.1

Redis compatibility layer for We-Trust, providing a high-speed key-value interface
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
#![warn(missing_docs)]

use bytes::{Buf, BufMut, Bytes, BytesMut};
use std::sync::Arc;
use tokio_util::codec::{Decoder, Encoder};
use uuid::Uuid;
use yykv_types::{DsError, DsValue, Redundancy};

use std::path::PathBuf;

type Result<T> = std::result::Result<T, DsError>;
use yykv_wal::{OpType, WalManager};

pub mod adapter;
pub mod connection;
pub mod transaction;

pub use adapter::RedisAdapter;
pub use connection::RedisConnection;
pub use transaction::RedisTransaction;

#[derive(Debug, Clone, PartialEq)]
pub enum RedisFrame {
    SimpleString(String),
    Error(String),
    Integer(i64),
    BulkString(Option<Bytes>),
    Array(Option<Vec<RedisFrame>>),
}

use futures::{SinkExt, StreamExt};
use tokio::net::TcpStream;
use tokio_util::codec::Framed;
use tracing::{error, info};

pub async fn handle_connection(stream: TcpStream, service: Arc<RedisService>) -> Result<()> {
    let mut framed = Framed::new(stream, RedisCodec);

    while let Some(result) = framed.next().await {
        let frame = match result {
            Ok(f) => f,
            Err(e) => {
                error!("Decode error: {}", e);
                break;
            }
        };

        // Parse command from frame
        let cmd = match RedisCommand::from_frame(frame) {
            Ok(c) => c,
            Err(e) => {
                let err_frame = RedisFrame::Error(format!("ERR {}", e));
                let _ = framed.send(err_frame).await;
                continue;
            }
        };

        // Handle command via RedisService (YY ecosystem)
        let response = service.handle_command(cmd).await?;

        // Send response back
        framed.send(response).await?;
    }

    info!("Connection closed");
    Ok(())
}

pub struct RedisCodec;

impl Decoder for RedisCodec {
    type Item = RedisFrame;
    type Error = DsError;

    fn decode(&mut self, src: &mut BytesMut) -> Result<Option<Self::Item>> {
        if src.is_empty() {
            return Ok(None);
        }

        match src[0] {
            b'+' => self.decode_simple_string(src),
            b'-' => self.decode_error(src),
            b':' => self.decode_integer(src),
            b'$' => self.decode_bulk_string(src),
            b'*' => self.decode_array(src),
            _ => Err(DsError::protocol(format!(
                "Invalid Redis frame type: {}",
                src[0] as char
            ))),
        }
    }
}

impl RedisCodec {
    fn decode_simple_string(&mut self, src: &mut BytesMut) -> Result<Option<RedisFrame>> {
        if let Some(i) = self.find_crlf(src) {
            let line = src.split_to(i + 2);
            let s = String::from_utf8(line[1..i].to_vec())?;
            Ok(Some(RedisFrame::SimpleString(s)))
        } else {
            Ok(None)
        }
    }

    fn decode_error(&mut self, src: &mut BytesMut) -> Result<Option<RedisFrame>> {
        if let Some(i) = self.find_crlf(src) {
            let line = src.split_to(i + 2);
            let s = String::from_utf8(line[1..i].to_vec())?;
            Ok(Some(RedisFrame::Error(s)))
        } else {
            Ok(None)
        }
    }

    fn decode_integer(&mut self, src: &mut BytesMut) -> Result<Option<RedisFrame>> {
        if let Some(i) = self.find_crlf(src) {
            let line = src.split_to(i + 2);
            let s = std::str::from_utf8(&line[1..i])?;
            let n = s.parse::<i64>()?;
            Ok(Some(RedisFrame::Integer(n)))
        } else {
            Ok(None)
        }
    }

    fn decode_bulk_string(&mut self, src: &mut BytesMut) -> Result<Option<RedisFrame>> {
        if let Some(i) = self.find_crlf(src) {
            let line = &src[..i];
            let len = std::str::from_utf8(&line[1..])?.parse::<isize>()?;

            if len == -1 {
                src.advance(i + 2);
                return Ok(Some(RedisFrame::BulkString(None)));
            }

            let bulk_len = len as usize;
            if src.len() < i + 2 + bulk_len + 2 {
                return Ok(None);
            }

            src.advance(i + 2);
            let data = src.split_to(bulk_len).freeze();
            src.advance(2); // CRLF
            Ok(Some(RedisFrame::BulkString(Some(data))))
        } else {
            Ok(None)
        }
    }

    fn decode_array(&mut self, src: &mut BytesMut) -> Result<Option<RedisFrame>> {
        if let Some(i) = self.find_crlf(src) {
            let line = &src[..i];
            let len = std::str::from_utf8(&line[1..])?.parse::<isize>()?;

            if len == -1 {
                src.advance(i + 2);
                return Ok(Some(RedisFrame::Array(None)));
            }

            let array_len = len as usize;
            src.advance(i + 2);

            let mut frames = Vec::with_capacity(array_len);
            for _ in 0..array_len {
                match self.decode(src)? {
                    Some(frame) => frames.push(frame),
                    None => return Ok(None), // Should technically buffer or error
                }
            }
            Ok(Some(RedisFrame::Array(Some(frames))))
        } else {
            Ok(None)
        }
    }

    fn find_crlf(&self, src: &[u8]) -> Option<usize> {
        src.windows(2).position(|w| w == b"\r\n")
    }
}

impl Encoder<RedisFrame> for RedisCodec {
    type Error = DsError;

    fn encode(&mut self, item: RedisFrame, dst: &mut BytesMut) -> Result<()> {
        match item {
            RedisFrame::SimpleString(s) => {
                dst.reserve(1 + s.len() + 2);
                dst.put_u8(b'+');
                dst.put_slice(s.as_bytes());
                dst.put_slice(b"\r\n");
            }
            RedisFrame::Error(s) => {
                dst.reserve(1 + s.len() + 2);
                dst.put_u8(b'-');
                dst.put_slice(s.as_bytes());
                dst.put_slice(b"\r\n");
            }
            RedisFrame::Integer(n) => {
                let s = n.to_string();
                dst.reserve(1 + s.len() + 2);
                dst.put_u8(b':');
                dst.put_slice(s.as_bytes());
                dst.put_slice(b"\r\n");
            }
            RedisFrame::BulkString(opt_data) => match opt_data {
                Some(data) => {
                    let len_s = data.len().to_string();
                    dst.reserve(1 + len_s.len() + 2 + data.len() + 2);
                    dst.put_u8(b'$');
                    dst.put_slice(len_s.as_bytes());
                    dst.put_slice(b"\r\n");
                    dst.put_slice(&data);
                    dst.put_slice(b"\r\n");
                }
                None => {
                    dst.put_slice(b"$-1\r\n");
                }
            },
            RedisFrame::Array(opt_frames) => match opt_frames {
                Some(frames) => {
                    let len_s = frames.len().to_string();
                    dst.reserve(1 + len_s.len() + 2);
                    dst.put_u8(b'*');
                    dst.put_slice(len_s.as_bytes());
                    dst.put_slice(b"\r\n");
                    for frame in frames {
                        self.encode(frame, dst)?;
                    }
                }
                None => {
                    dst.put_slice(b"*-1\r\n");
                }
            },
        }
        Ok(())
    }
}

#[derive(Debug, Clone)]
pub enum RedisCommand {
    Ping,
    Get(String),
    Set(String, Bytes),
    Del(Vec<String>),
    Exists(Vec<String>),
    // Hash commands
    HSet(String, String, Bytes),
    HGet(String, String),
    HDel(String, Vec<String>),
    // Atomic increments
    Incr(String),
    Decr(String),
    IncrBy(String, i64),
    // TTL commands
    Expire(String, u64),
    Ttl(String),
    // Pattern matching
    Keys(String),
}

impl RedisCommand {
    pub fn from_frame(frame: RedisFrame) -> Result<Self> {
        match frame {
            RedisFrame::Array(Some(frames)) => {
                if frames.is_empty() {
                    return Err(DsError::protocol("Empty command array"));
                }

                let cmd_name = match &frames[0] {
                    RedisFrame::BulkString(Some(data)) => {
                        String::from_utf8_lossy(data).to_uppercase()
                    }
                    _ => {
                        return Err(DsError::protocol("Command name must be a bulk string"));
                    }
                };

                match cmd_name.as_str() {
                    "PING" => Ok(RedisCommand::Ping),
                    "GET" => {
                        if frames.len() != 2 {
                            return Err(DsError::protocol("GET requires exactly 1 argument"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("GET key must be a bulk string"));
                            }
                        };
                        Ok(RedisCommand::Get(key))
                    }
                    "SET" => {
                        if frames.len() != 3 {
                            return Err(DsError::protocol("SET requires exactly 2 arguments"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("SET key must be a bulk string"));
                            }
                        };
                        let value = match &frames[2] {
                            RedisFrame::BulkString(Some(data)) => data.clone(),
                            _ => {
                                return Err(DsError::protocol("SET value must be a bulk string"));
                            }
                        };
                        Ok(RedisCommand::Set(key, value))
                    }
                    "DEL" => {
                        let mut keys = Vec::new();
                        for frame in frames.iter().skip(1) {
                            match frame {
                                RedisFrame::BulkString(Some(data)) => {
                                    keys.push(String::from_utf8_lossy(data).to_string())
                                }
                                _ => {
                                    return Err(DsError::protocol("DEL key must be a bulk string"));
                                }
                            }
                        }
                        Ok(RedisCommand::Del(keys))
                    }
                    "EXISTS" => {
                        let mut keys = Vec::new();
                        for frame in frames.iter().skip(1) {
                            match frame {
                                RedisFrame::BulkString(Some(data)) => {
                                    keys.push(String::from_utf8_lossy(data).to_string())
                                }
                                _ => {
                                    return Err(DsError::protocol(
                                        "EXISTS key must be a bulk string",
                                    ));
                                }
                            }
                        }
                        Ok(RedisCommand::Exists(keys))
                    }
                    "HSET" => {
                        if frames.len() != 4 {
                            return Err(DsError::protocol("HSET requires exactly 3 arguments"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("HSET key must be a bulk string"));
                            }
                        };
                        let field = match &frames[2] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("HSET field must be a bulk string"));
                            }
                        };
                        let value = match &frames[3] {
                            RedisFrame::BulkString(Some(data)) => data.clone(),
                            _ => {
                                return Err(DsError::protocol("HSET value must be a bulk string"));
                            }
                        };
                        Ok(RedisCommand::HSet(key, field, value))
                    }
                    "HGET" => {
                        if frames.len() != 3 {
                            return Err(DsError::protocol("HGET requires exactly 2 arguments"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("HGET key must be a bulk string"));
                            }
                        };
                        let field = match &frames[2] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("HGET field must be a bulk string"));
                            }
                        };
                        Ok(RedisCommand::HGet(key, field))
                    }
                    "HDEL" => {
                        if frames.len() < 3 {
                            return Err(DsError::protocol("HDEL requires at least 2 arguments"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("HDEL key must be a bulk string"));
                            }
                        };
                        let mut fields = Vec::new();
                        for frame in frames.iter().skip(2) {
                            match frame {
                                RedisFrame::BulkString(Some(data)) => {
                                    fields.push(String::from_utf8_lossy(data).to_string())
                                }
                                _ => {
                                    return Err(DsError::protocol(
                                        "HDEL field must be a bulk string",
                                    ));
                                }
                            }
                        }
                        Ok(RedisCommand::HDel(key, fields))
                    }
                    "INCR" => {
                        if frames.len() != 2 {
                            return Err(DsError::protocol("INCR requires exactly 1 argument"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("INCR key must be a bulk string"));
                            }
                        };
                        Ok(RedisCommand::Incr(key))
                    }
                    "DECR" => {
                        if frames.len() != 2 {
                            return Err(DsError::protocol("DECR requires exactly 1 argument"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("DECR key must be a bulk string"));
                            }
                        };
                        Ok(RedisCommand::Decr(key))
                    }
                    "INCRBY" => {
                        if frames.len() != 3 {
                            return Err(DsError::protocol("INCRBY requires exactly 2 arguments"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("INCRBY key must be a bulk string"));
                            }
                        };
                        let amount = match &frames[2] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).parse::<i64>().map_err(|e| {
                                    DsError::protocol(format!("Invalid INCRBY amount: {}", e))
                                })?
                            }
                            _ => {
                                return Err(DsError::protocol(
                                    "INCRBY amount must be a bulk string",
                                ));
                            }
                        };
                        Ok(RedisCommand::IncrBy(key, amount))
                    }
                    "EXPIRE" => {
                        if frames.len() != 3 {
                            return Err(DsError::protocol("EXPIRE requires exactly 2 arguments"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("EXPIRE key must be a bulk string"));
                            }
                        };
                        let seconds = match &frames[2] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).parse::<u64>().map_err(|e| {
                                    DsError::protocol(format!("Invalid EXPIRE seconds: {}", e))
                                })?
                            }
                            _ => {
                                return Err(DsError::protocol(
                                    "EXPIRE seconds must be a bulk string",
                                ));
                            }
                        };
                        Ok(RedisCommand::Expire(key, seconds))
                    }
                    "TTL" => {
                        if frames.len() != 2 {
                            return Err(DsError::protocol("TTL requires exactly 1 argument"));
                        }
                        let key = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol("TTL key must be a bulk string"));
                            }
                        };
                        Ok(RedisCommand::Ttl(key))
                    }
                    "KEYS" => {
                        if frames.len() != 2 {
                            return Err(DsError::protocol("KEYS requires exactly 1 argument"));
                        }
                        let pattern = match &frames[1] {
                            RedisFrame::BulkString(Some(data)) => {
                                String::from_utf8_lossy(data).to_string()
                            }
                            _ => {
                                return Err(DsError::protocol(
                                    "KEYS pattern must be a bulk string",
                                ));
                            }
                        };
                        Ok(RedisCommand::Keys(pattern))
                    }
                    _ => Err(DsError::protocol(format!(
                        "Unsupported command: {}",
                        cmd_name
                    ))),
                }
            }
            _ => Err(DsError::protocol("Invalid command frame: must be an array")),
        }
    }
}

pub struct RedisService {
    wal: Arc<WalManager>,
    tenant_id: Uuid,
    // In-memory state for the example to actually work
    kv: Arc<tokio::sync::RwLock<std::collections::HashMap<String, Bytes>>>,
    hash: Arc<
        tokio::sync::RwLock<
            std::collections::HashMap<String, std::collections::HashMap<String, Bytes>>,
        >,
    >,
    ttl: Arc<tokio::sync::RwLock<std::collections::HashMap<String, u64>>>,
}

impl RedisService {
    pub async fn new() -> Result<Self> {
        let wal = Arc::new(
            WalManager::new(PathBuf::from("wal_redis"))
                .await
                .map_err(|e| DsError::storage(e.to_string()))?,
        );
        // let index = Arc::new(SearchIndexManager::new_in_memory()?);

        Ok(Self {
            wal,
            tenant_id: Uuid::new_v4(),
            kv: Arc::new(tokio::sync::RwLock::new(std::collections::HashMap::new())),
            hash: Arc::new(tokio::sync::RwLock::new(std::collections::HashMap::new())),
            ttl: Arc::new(tokio::sync::RwLock::new(std::collections::HashMap::new())),
        })
    }

    pub async fn handle_command(&self, cmd: RedisCommand) -> Result<RedisFrame> {
        match cmd {
            RedisCommand::Ping => Ok(RedisFrame::SimpleString("PONG".to_string())),
            RedisCommand::Set(key, value) => {
                // 1. Update in-memory state
                {
                    let mut kv = self.kv.write().await;
                    kv.insert(key.clone(), value.clone());
                }

                // 2. Log to WAL (Simplified)
                self.wal
                    .write(
                        self.tenant_id,
                        "redis_kv".to_string(),
                        key.clone(),
                        OpType::Insert,
                        Redundancy::SINGLE,
                        DsValue::Binary(value),
                    )
                    .await?;

                Ok(RedisFrame::SimpleString("OK".to_string()))
            }
            RedisCommand::Get(key) => {
                let kv = self.kv.read().await;
                match kv.get(&key) {
                    Some(val) => Ok(RedisFrame::BulkString(Some(val.clone()))),
                    None => Ok(RedisFrame::BulkString(None)),
                }
            }
            RedisCommand::Del(keys) => {
                let mut kv = self.kv.write().await;
                let mut count = 0;
                for key in keys {
                    if kv.remove(&key).is_some() {
                        count += 1;
                        self.wal
                            .write(
                                self.tenant_id,
                                "redis_kv".to_string(),
                                key.clone(),
                                OpType::Delete,
                                Redundancy::SINGLE,
                                DsValue::Text(key),
                            )
                            .await?;
                    }
                }
                Ok(RedisFrame::Integer(count))
            }
            RedisCommand::Exists(keys) => {
                let kv = self.kv.read().await;
                let mut count = 0;
                for key in keys {
                    if kv.contains_key(&key) {
                        count += 1;
                    }
                }
                Ok(RedisFrame::Integer(count))
            }
            RedisCommand::HSet(key, field, value) => {
                let mut hash = self.hash.write().await;
                let entry = hash
                    .entry(key)
                    .or_insert_with(std::collections::HashMap::new);
                entry.insert(field, value);
                Ok(RedisFrame::Integer(1))
            }
            RedisCommand::HGet(key, field) => {
                let hash = self.hash.read().await;
                match hash.get(&key).and_then(|m| m.get(&field)) {
                    Some(val) => Ok(RedisFrame::BulkString(Some(val.clone()))),
                    None => Ok(RedisFrame::BulkString(None)),
                }
            }
            RedisCommand::HDel(key, fields) => {
                let mut hash = self.hash.write().await;
                let mut count = 0;
                if let Some(m) = hash.get_mut(&key) {
                    for field in fields {
                        if m.remove(&field).is_some() {
                            count += 1;
                        }
                    }
                }
                Ok(RedisFrame::Integer(count))
            }
            RedisCommand::Incr(key) => {
                let mut kv = self.kv.write().await;
                let val = kv
                    .get(&key)
                    .map(|v| String::from_utf8_lossy(v).parse::<i64>().unwrap_or(0))
                    .unwrap_or(0);
                let new_val = val + 1;
                kv.insert(key, Bytes::from(new_val.to_string()));
                Ok(RedisFrame::Integer(new_val))
            }
            RedisCommand::Decr(key) => {
                let mut kv = self.kv.write().await;
                let val = kv
                    .get(&key)
                    .map(|v| String::from_utf8_lossy(v).parse::<i64>().unwrap_or(0))
                    .unwrap_or(0);
                let new_val = val - 1;
                kv.insert(key, Bytes::from(new_val.to_string()));
                Ok(RedisFrame::Integer(new_val))
            }
            RedisCommand::IncrBy(key, amount) => {
                let mut kv = self.kv.write().await;
                let val = kv
                    .get(&key)
                    .map(|v| String::from_utf8_lossy(v).parse::<i64>().unwrap_or(0))
                    .unwrap_or(0);
                let new_val = val + amount;
                kv.insert(key, Bytes::from(new_val.to_string()));
                Ok(RedisFrame::Integer(new_val))
            }
            RedisCommand::Expire(key, seconds) => {
                let mut ttl = self.ttl.write().await;
                ttl.insert(key, seconds);
                Ok(RedisFrame::Integer(1))
            }
            RedisCommand::Ttl(key) => {
                let ttl = self.ttl.read().await;
                match ttl.get(&key) {
                    Some(s) => Ok(RedisFrame::Integer(*s as i64)),
                    None => Ok(RedisFrame::Integer(-1)),
                }
            }
            RedisCommand::Keys(pattern) => {
                let kv = self.kv.read().await;
                let keys: Vec<RedisFrame> = kv
                    .keys()
                    .filter(|k| k.contains(&pattern.replace("*", "")))
                    .map(|k| RedisFrame::BulkString(Some(Bytes::copy_from_slice(k.as_bytes()))))
                    .collect();
                Ok(RedisFrame::Array(Some(keys)))
            }
        }
    }
}