wdl-lint 0.26.0

Lint rules for Workflow Description Language (WDL) documents
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
//! Implementation of the linter.

use std::collections::HashSet;

use indexmap::IndexMap;
use wdl_analysis::Diagnostics;
use wdl_analysis::Document as AnalysisDocument;
use wdl_analysis::Exceptable;
use wdl_analysis::VisitReason;
use wdl_analysis::Visitor;
use wdl_ast::AstNode;
use wdl_ast::Comment;
use wdl_ast::SupportedVersion;
use wdl_ast::VersionStatement;
use wdl_ast::Whitespace;
use wdl_ast::v1;

use crate::Config;
use crate::Rule;
use crate::rules;

/// A visitor that runs linting rules.
///
/// By default, the visitor runs all lint rules.
///
/// This visitor respects `#@ except` comments that precede AST nodes.
///
/// The format for the comment is `#@ except: <ids>`, where `ids` is a
/// comma-separated list of lint rule identifiers.
///
/// Any `#@ except` comments that come before the version statement will disable
/// the rule for the entire document.
///
/// Otherwise, `#@ except` comments disable the rule for the immediately
/// following AST node.
#[allow(missing_debug_implementations)]
pub struct Linter {
    /// The map of rule name to rule.
    rules: IndexMap<&'static str, Box<dyn Rule>>,
    /// The set of rule ids that are disabled for the current document.
    document_exceptions: HashSet<String>,
}

impl Linter {
    /// Creates a new linter with the given rules.
    pub fn new(rules: impl IntoIterator<Item = Box<dyn Rule>>) -> Self {
        Self {
            rules: rules.into_iter().map(|r| (r.id(), r)).collect(),
            document_exceptions: HashSet::default(),
        }
    }

    /// Invokes a callback on each rule
    fn each_enabled_rule<F>(&mut self, diagnostics: &mut Diagnostics, mut cb: F)
    where
        F: FnMut(&mut Diagnostics, &mut dyn Rule),
    {
        for (id, rule) in &mut self.rules {
            if self.document_exceptions.contains(id.to_owned()) {
                continue;
            }
            cb(diagnostics, rule.as_mut());
        }
    }
}

impl Default for Linter {
    fn default() -> Self {
        Self {
            rules: rules(&Config::default())
                .into_iter()
                .map(|r| (r.id(), r as Box<dyn Rule>))
                .collect(),
            document_exceptions: HashSet::default(),
        }
    }
}

impl Visitor for Linter {
    fn known_rules(&self) -> HashSet<String> {
        self.rules.keys().map(ToString::to_string).collect()
    }

    fn reset(&mut self) {
        // Reset the state of each rule
        for rule in self.rules.values_mut() {
            rule.reset();
        }

        // Reset the document exceptions
        self.document_exceptions.clear();
    }

    fn document(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        doc: &AnalysisDocument,
        version: SupportedVersion,
    ) {
        if reason == VisitReason::Enter {
            self.document_exceptions.extend(
                doc.root()
                    .version_statement()
                    .expect("document should have version statement")
                    .inner()
                    .rule_exceptions()
                    .into_iter()
                    .map(|e| e.name),
            );
        }

        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.document(diagnostics, reason, doc, version);
        });
    }

    fn whitespace(&mut self, diagnostics: &mut Diagnostics, whitespace: &Whitespace) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.whitespace(diagnostics, whitespace);
        });
    }

    fn comment(&mut self, diagnostics: &mut Diagnostics, comment: &Comment) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.comment(diagnostics, comment);
        });
    }

    fn version_statement(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        stmt: &VersionStatement,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.version_statement(diagnostics, reason, stmt);
        });
    }

    fn import_statement(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        stmt: &v1::ImportStatement,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.import_statement(diagnostics, reason, stmt)
        });
    }

    fn struct_definition(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        def: &v1::StructDefinition,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.struct_definition(diagnostics, reason, def)
        });
    }

    fn task_definition(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        task: &v1::TaskDefinition,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.task_definition(diagnostics, reason, task)
        });
    }

    fn workflow_definition(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        workflow: &v1::WorkflowDefinition,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.workflow_definition(diagnostics, reason, workflow)
        });
    }

    fn input_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::InputSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.input_section(diagnostics, reason, section)
        });
    }

    fn output_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::OutputSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.output_section(diagnostics, reason, section)
        });
    }

    fn command_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::CommandSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.command_section(diagnostics, reason, section)
        });
    }

    fn command_text(&mut self, diagnostics: &mut Diagnostics, text: &v1::CommandText) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.command_text(diagnostics, text);
        });
    }

    fn requirements_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::RequirementsSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.requirements_section(diagnostics, reason, section)
        });
    }

    fn task_hints_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::TaskHintsSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.task_hints_section(diagnostics, reason, section)
        });
    }

    fn workflow_hints_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::WorkflowHintsSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.workflow_hints_section(diagnostics, reason, section)
        });
    }

    fn runtime_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::RuntimeSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.runtime_section(diagnostics, reason, section)
        });
    }

    fn runtime_item(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        item: &v1::RuntimeItem,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.runtime_item(diagnostics, reason, item)
        });
    }

    fn metadata_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::MetadataSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.metadata_section(diagnostics, reason, section)
        });
    }

    fn parameter_metadata_section(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        section: &v1::ParameterMetadataSection,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.parameter_metadata_section(diagnostics, reason, section)
        });
    }

    fn metadata_object(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        object: &v1::MetadataObject,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.metadata_object(diagnostics, reason, object)
        });
    }

    fn metadata_object_item(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        item: &v1::MetadataObjectItem,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.metadata_object_item(diagnostics, reason, item)
        });
    }

    fn metadata_array(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        item: &v1::MetadataArray,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.metadata_array(diagnostics, reason, item)
        });
    }

    fn unbound_decl(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        decl: &v1::UnboundDecl,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.unbound_decl(diagnostics, reason, decl)
        });
    }

    fn bound_decl(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        decl: &v1::BoundDecl,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.bound_decl(diagnostics, reason, decl)
        });
    }

    fn expr(&mut self, diagnostics: &mut Diagnostics, reason: VisitReason, expr: &v1::Expr) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.expr(diagnostics, reason, expr)
        });
    }

    fn string_text(&mut self, diagnostics: &mut Diagnostics, text: &v1::StringText) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.string_text(diagnostics, text);
        });
    }

    fn placeholder(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        placeholder: &v1::Placeholder,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.placeholder(diagnostics, reason, placeholder)
        });
    }

    fn conditional_statement(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        stmt: &v1::ConditionalStatement,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.conditional_statement(diagnostics, reason, stmt)
        });
    }

    fn scatter_statement(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        stmt: &v1::ScatterStatement,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.scatter_statement(diagnostics, reason, stmt)
        });
    }

    fn call_statement(
        &mut self,
        diagnostics: &mut Diagnostics,
        reason: VisitReason,
        stmt: &v1::CallStatement,
    ) {
        self.each_enabled_rule(diagnostics, |diagnostics, rule| {
            rule.call_statement(diagnostics, reason, stmt)
        });
    }
}