wavepeek 2.1.0

Command-line tool for RTL waveform inspection with deterministic machine-friendly output.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
use std::collections::{HashMap, HashSet};
use std::fs;
use std::rc::Rc;
use std::time::{Duration, Instant};

use serde::{Deserialize, Serialize};

use crate::cli::extract::GenericArgs;
use crate::cli::limits::LimitArg;
use crate::contract::schema::INPUT_SCHEMA_URL;
use crate::debug_trace::DebugTrace;
use crate::diagnostic::{Diagnostic, WarningDiagnosticCode};
use crate::engine::expr_runtime::{
    SharedWaveform, bind_waveform_event_expr, bind_waveform_logical_expr,
    candidate_sources_for_handles, eval_bound_logical_truth, event_candidate_handles,
    event_expr_is_edge_only, event_expr_matches, event_iff_handles, open_shared_waveform,
    referenced_signal_handles,
};
use crate::engine::time::{
    DumpTimeContext, TimeValidationError, format_raw_timestamp, parse_dump_time_context,
    validate_time_token_to_raw,
};
use crate::engine::value_format::format_verilog_literal;
use crate::engine::{CommandData, CommandName, CommandResult, HumanRenderOptions};
use crate::error::WavepeekError;
use crate::expr::{BoundEventExpr, BoundLogicalExpr, EventEvalFrame};
use crate::waveform::{
    ChangeCandidateCollectionMode, ExprResolvedSignal, ResolvedSignal, SampledSignalState,
    SignalId, expr_host::WaveformExprHost,
};

const DEFAULT_SOURCE_NAME: &str = "transfer";
const SOURCE_KIND: &str = "extract.generic.sources";
const EDGE_ONLY_ON_MESSAGE: &str = "extract generic requires --on with only edge event terms (posedge, negedge, or edge); wildcard, plain-signal, and mixed triggers are not supported";

#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct ExtractPayloadValue {
    #[serde(skip_serializing)]
    pub display: String,
    pub path: String,
    pub value: String,
}

#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct ExtractGenericRow {
    pub time: String,
    pub sample_time: String,
    pub source: String,
    pub payload: Vec<ExtractPayloadValue>,
}

#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct ExtractGenericData {
    #[serde(skip_serializing)]
    pub source_count: usize,
    pub rows: Vec<ExtractGenericRow>,
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ExtractPlan {
    sources: Vec<ExtractSource>,
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ExtractSource {
    declaration_index: usize,
    name: String,
    on: String,
    when: String,
    payload: Vec<String>,
}

#[derive(Debug, Clone, PartialEq, Eq)]
struct PayloadSignal {
    display: String,
    path: String,
    resolved: ResolvedSignal,
}

#[derive(Debug)]
struct BoundExtractSource {
    declaration_index: usize,
    name: String,
    on: String,
    when: String,
    payload: Vec<PayloadSignal>,
    host: WaveformExprHost,
    bound_event: BoundEventExpr,
    bound_when: BoundLogicalExpr,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
struct ExtractRunStats {
    candidate_times: usize,
    event_checks: usize,
    event_matches: usize,
    predicate_true: usize,
    skipped_no_sample_time: usize,
    emitted: usize,
    truncated: bool,
    event_match_ns: u64,
    predicate_eval_ns: u64,
    build_emit_ns: u64,
}

struct ExtractEmitContext<'a> {
    waveform: &'a SharedWaveform,
    sources: &'a [BoundExtractSource],
    event_groups: &'a [EventGroup],
    dump_start_raw: u64,
    dump_end_raw: u64,
    dump_tick: crate::engine::time::ParsedTime,
    max_entries: Option<usize>,
    profile_timing: bool,
}

#[derive(Debug, Clone, PartialEq, Eq, Hash)]
struct EventGroupKey {
    on: String,
    candidate_ids: Vec<SignalId>,
}

#[derive(Debug)]
struct EventGroup {
    source_indices: Vec<usize>,
    candidate_sources: Vec<ExprResolvedSignal>,
    candidate_key: Vec<SignalId>,
}

#[derive(Debug)]
struct EventGroupCandidateTimes {
    group_index: usize,
    times: Rc<Vec<u64>>,
    cursor: usize,
}

#[derive(Debug)]
struct ExtractCommandOutcome {
    source_count: usize,
    diagnostics: Vec<Diagnostic>,
    stats: ExtractRunStats,
}

trait ExtractRowSink {
    fn start(&mut self) -> Result<(), WavepeekError> {
        Ok(())
    }

    fn emit(&mut self, row: ExtractGenericRow) -> Result<(), WavepeekError>;
}

#[derive(Default)]
struct CollectingExtractSink {
    rows: Vec<ExtractGenericRow>,
}

impl ExtractRowSink for CollectingExtractSink {
    fn emit(&mut self, row: ExtractGenericRow) -> Result<(), WavepeekError> {
        self.rows.push(row);
        Ok(())
    }
}

struct JsonlExtractSink<'a, W: std::io::Write> {
    writer: &'a mut crate::output::JsonlWriter<W>,
}

impl<W: std::io::Write> ExtractRowSink for JsonlExtractSink<'_, W> {
    fn start(&mut self) -> Result<(), WavepeekError> {
        self.writer.begin()
    }

    fn emit(&mut self, row: ExtractGenericRow) -> Result<(), WavepeekError> {
        self.writer.item(&row)
    }
}

#[derive(Debug, Deserialize)]
struct SourceFile {
    #[serde(rename = "$schema")]
    schema: String,
    kind: String,
    sources: Vec<SourceFileSource>,
}

#[derive(Debug, Deserialize)]
struct SourceFileSource {
    name: String,
    on: String,
    when: String,
    payload: Vec<String>,
}

pub fn run(args: GenericArgs) -> Result<CommandResult, WavepeekError> {
    let output_mode = crate::output_mode::OutputMode::from_json_flags(args.json, args.jsonl);
    let signals_abs = args.abs;
    let mut sink = CollectingExtractSink::default();
    let outcome = run_with_sink(args, &mut sink)?;

    Ok(CommandResult {
        command: CommandName::ExtractGeneric,
        output_mode,
        human_options: HumanRenderOptions {
            scope_tree: false,
            signals_abs,
        },
        data: CommandData::ExtractGeneric(ExtractGenericData {
            source_count: outcome.source_count,
            rows: sink.rows,
        }),
        diagnostics: outcome.diagnostics,
    })
}

pub fn run_jsonl<W: std::io::Write>(
    args: GenericArgs,
    writer: &mut crate::output::JsonlWriter<W>,
) -> Result<(), WavepeekError> {
    let outcome = {
        let mut sink = JsonlExtractSink { writer };
        run_with_sink(args, &mut sink)?
    };

    for diagnostic in &outcome.diagnostics {
        writer.diagnostic(diagnostic)?;
    }
    writer.end(outcome.stats.truncated)
}

fn run_with_sink<S: ExtractRowSink + ?Sized>(
    args: GenericArgs,
    sink: &mut S,
) -> Result<ExtractCommandOutcome, WavepeekError> {
    let max_entries = max_entries(&args.max)?;
    let mut diagnostics = Vec::new();
    if args.max.is_unlimited() {
        diagnostics.push(Diagnostic::warning(
            WarningDiagnosticCode::LimitDisabled,
            "limit disabled: --max=unlimited",
        ));
    }

    let plan = build_plan(&args)?;
    let source_count = plan.sources.len();

    let debug = DebugTrace::for_command(CommandName::ExtractGeneric);
    debug.event("backend.open.start", || serde_json::json!({}));
    let waveform = open_shared_waveform(args.waves.as_path())?;
    {
        let waveform_ref = waveform.borrow();
        debug.event("backend.open.done", || {
            serde_json::json!({
                "backend": waveform_ref.backend_name(),
                "format": waveform_ref.format_name(),
            })
        });
    }
    let metadata = waveform.borrow().metadata()?;
    debug.event("metadata.load.done", || serde_json::json!({}));
    let dump_time = parse_dump_time_context(&metadata)?;
    let dump_tick = dump_time.dump_tick;
    let dump_start_raw =
        u64::try_from(dump_time.dump_start_zs / dump_time.dump_tick_zs).map_err(|_| {
            WavepeekError::Internal("dump start timestamp exceeds supported range".to_string())
        })?;
    let dump_end_raw =
        u64::try_from(dump_time.dump_end_zs / dump_time.dump_tick_zs).map_err(|_| {
            WavepeekError::Internal("dump end timestamp exceeds supported range".to_string())
        })?;

    let from_raw = match args.from.as_deref() {
        Some(token) => parse_bound_time(token, "--from", dump_time, &metadata)?,
        None => dump_start_raw,
    };
    let to_raw = match args.to.as_deref() {
        Some(token) => parse_bound_time(token, "--to", dump_time, &metadata)?,
        None => dump_end_raw,
    };
    if from_raw > to_raw {
        return Err(WavepeekError::Args(
            "--from must be less than or equal to --to".to_string(),
        ));
    }
    let (indexed_timestamps, window_timestamps) = {
        let waveform_ref = waveform.borrow();
        waveform_ref
            .indexed_timestamps()
            .map(|timestamps| {
                (
                    Some(timestamps.len()),
                    Some(count_timestamps_in_range(timestamps, from_raw, to_raw)),
                )
            })
            .unwrap_or((None, None))
    };
    debug.event("time.parse.done", || {
        serde_json::json!({
            "dump_start_raw": dump_start_raw,
            "dump_end_raw": dump_end_raw,
            "from_raw": from_raw,
            "to_raw": to_raw,
            "indexed_timestamps": indexed_timestamps,
            "window_timestamps": window_timestamps,
        })
    });

    let bound_sources = bind_extract_sources(&waveform, args.scope.as_deref(), plan.sources)?;
    let event_groups = build_event_groups(&bound_sources)?;
    let event_group_candidate_sources = event_groups
        .iter()
        .map(|group| group.candidate_sources.len())
        .sum::<usize>();
    debug.event("extract.bind.done", || {
        serde_json::json!({
            "sources": source_count,
            "event_groups": event_groups.len(),
            "event_group_candidate_sources": event_group_candidate_sources,
        })
    });

    let group_candidate_times =
        collect_event_group_candidate_times(&waveform, &event_groups, from_raw, to_raw)?;
    let candidate_times = if debug.is_enabled() {
        count_merged_candidate_times(&group_candidate_times)
    } else {
        0
    };
    debug.event("candidate.collect.done", || {
        serde_json::json!({
            "times": candidate_times,
            "event_groups": event_groups.len(),
            "group_times": group_candidate_times
                .iter()
                .map(|group| group.times.len())
                .collect::<Vec<_>>(),
        })
    });

    if max_entries.is_none() {
        let preload_from_raw = from_raw
            .checked_sub(1)
            .filter(|value| *value >= dump_start_raw)
            .unwrap_or(from_raw);
        preload_extract_value_changes(
            &waveform,
            &bound_sources,
            &event_groups,
            preload_from_raw,
            to_raw,
        )?;
        debug.event("value.preload.done", || {
            serde_json::json!({
                "from_raw": preload_from_raw,
                "to_raw": to_raw,
                "backend_stats": waveform.borrow().debug_stats(),
            })
        });
    } else {
        debug.event("value.preload.skipped", || {
            serde_json::json!({
                "reason": "bounded_max",
                "max_entries": max_entries,
            })
        });
    }

    sink.start()?;
    debug.event("extract.emit.start", || {
        serde_json::json!({
            "candidate_times": candidate_times,
            "sources": bound_sources.len(),
            "event_groups": event_groups.len(),
        })
    });
    let emit_context = ExtractEmitContext {
        waveform: &waveform,
        sources: &bound_sources,
        event_groups: &event_groups,
        dump_start_raw,
        dump_end_raw,
        dump_tick,
        max_entries,
        profile_timing: debug.is_enabled(),
    };
    let stats = emit_rows(emit_context, group_candidate_times, candidate_times, sink)?;
    debug.event("extract.emit.done", || {
        serde_json::json!({
            "candidate_times": stats.candidate_times,
            "event_checks": stats.event_checks,
            "event_matches": stats.event_matches,
            "predicate_true": stats.predicate_true,
            "skipped_no_sample_time": stats.skipped_no_sample_time,
            "emitted": stats.emitted,
            "truncated": stats.truncated,
            "event_match_ns": stats.event_match_ns,
            "predicate_eval_ns": stats.predicate_eval_ns,
            "build_emit_ns": stats.build_emit_ns,
            "backend_stats": waveform.borrow().debug_stats(),
        })
    });

    if stats.emitted == 0 {
        diagnostics.push(Diagnostic::warning(
            WarningDiagnosticCode::EmptyResult,
            "no extract rows found in selected time range",
        ));
    }
    if let Some(max_entries) = max_entries
        && stats.truncated
    {
        diagnostics.push(Diagnostic::warning(
            WarningDiagnosticCode::OutputTruncated,
            format!("truncated output to {max_entries} entries (use --max to increase limit)"),
        ));
    }

    Ok(ExtractCommandOutcome {
        source_count,
        diagnostics,
        stats,
    })
}

fn max_entries(max: &LimitArg) -> Result<Option<usize>, WavepeekError> {
    match max {
        LimitArg::Numeric(0) => Err(WavepeekError::Args(
            "--max must be greater than 0.".to_string(),
        )),
        LimitArg::Numeric(value) => Ok(Some(*value)),
        LimitArg::Unlimited => Ok(None),
    }
}

fn build_plan(args: &GenericArgs) -> Result<ExtractPlan, WavepeekError> {
    if let Some(path) = args.source.as_ref() {
        if args.name.is_some() || args.on.is_some() || args.when.is_some() || args.payload.is_some()
        {
            return Err(WavepeekError::Args(
                "--source cannot be combined with --name, --on, --when, or --payload. See 'wavepeek extract generic --help'.".to_string(),
            ));
        }
        return plan_from_source_file(path);
    }

    let on = args.on.clone().ok_or_else(|| {
        WavepeekError::Args(
            "--on is required unless --source is used. See 'wavepeek extract generic --help'."
                .to_string(),
        )
    })?;
    let when = args.when.clone().ok_or_else(|| {
        WavepeekError::Args(
            "--when is required unless --source is used. See 'wavepeek extract generic --help'."
                .to_string(),
        )
    })?;
    let payload = args.payload.clone().ok_or_else(|| {
        WavepeekError::Args(
            "--payload is required unless --source is used. See 'wavepeek extract generic --help'."
                .to_string(),
        )
    })?;
    let payload = normalize_payload(payload)?;
    require_unique_payloads(&payload)?;

    Ok(ExtractPlan {
        sources: vec![ExtractSource {
            declaration_index: 0,
            name: args
                .name
                .clone()
                .unwrap_or_else(|| DEFAULT_SOURCE_NAME.to_string()),
            on,
            when,
            payload,
        }],
    })
}

fn plan_from_source_file(path: &std::path::Path) -> Result<ExtractPlan, WavepeekError> {
    let contents = fs::read_to_string(path).map_err(|error| {
        WavepeekError::File(format!(
            "failed to read extract source file '{}': {error}",
            path.display()
        ))
    })?;
    let input: SourceFile = serde_json::from_str(&contents).map_err(|error| {
        WavepeekError::Args(format!(
            "invalid extract source JSON '{}': {error}",
            path.display()
        ))
    })?;

    if input.schema != INPUT_SCHEMA_URL {
        return Err(WavepeekError::Args(format!(
            "extract source file '{}' uses unsupported $schema {}; expected {}",
            path.display(),
            input.schema,
            INPUT_SCHEMA_URL
        )));
    }
    if input.kind != SOURCE_KIND {
        return Err(WavepeekError::Args(format!(
            "extract source file '{}' has kind {}; expected {}",
            path.display(),
            input.kind,
            SOURCE_KIND
        )));
    }
    if input.sources.is_empty() {
        return Err(WavepeekError::Args(format!(
            "extract source file '{}' must contain at least one source",
            path.display()
        )));
    }

    let mut names = HashSet::new();
    let mut sources = Vec::with_capacity(input.sources.len());
    for (declaration_index, source) in input.sources.into_iter().enumerate() {
        if !names.insert(source.name.clone()) {
            return Err(WavepeekError::Args(format!(
                "extract source file '{}' contains duplicate source name '{}'",
                path.display(),
                source.name
            )));
        }
        let payload = normalize_payload(source.payload)?;
        require_unique_payloads(&payload)?;
        sources.push(ExtractSource {
            declaration_index,
            name: source.name,
            on: source.on,
            when: source.when,
            payload,
        });
    }

    Ok(ExtractPlan { sources })
}

fn normalize_payload(payload: Vec<String>) -> Result<Vec<String>, WavepeekError> {
    if payload.is_empty() {
        return Err(WavepeekError::Args(
            "payload must contain at least one signal. See 'wavepeek extract generic --help'."
                .to_string(),
        ));
    }
    payload
        .into_iter()
        .map(|token| {
            let trimmed = token.trim();
            if trimmed.is_empty() {
                Err(WavepeekError::Args(
                    "payload signal names must not be empty. See 'wavepeek extract generic --help'."
                        .to_string(),
                ))
            } else {
                Ok(trimmed.to_string())
            }
        })
        .collect()
}

fn require_unique_payloads(payload: &[String]) -> Result<(), WavepeekError> {
    let mut seen = HashSet::new();
    for signal in payload {
        if !seen.insert(signal.as_str()) {
            return Err(WavepeekError::Args(format!(
                "payload contains duplicate signal '{signal}'. See 'wavepeek extract generic --help'."
            )));
        }
    }
    Ok(())
}

fn bind_extract_sources(
    waveform: &SharedWaveform,
    scope: Option<&str>,
    sources: Vec<ExtractSource>,
) -> Result<Vec<BoundExtractSource>, WavepeekError> {
    if let Some(scope) = scope {
        waveform.borrow().signals_in_scope(scope)?;
    }

    let mut bound_sources = Vec::with_capacity(sources.len());
    for source in sources {
        let (host, bound_event) =
            bind_waveform_event_expr(waveform.clone(), scope, source.on.as_str())?;
        if !event_expr_is_edge_only(&bound_event) {
            return Err(WavepeekError::Args(EDGE_ONLY_ON_MESSAGE.to_string()));
        }
        let iff_signal_handles = event_iff_handles(&bound_event);
        let iff_sources = candidate_sources_for_handles(&host, iff_signal_handles.as_slice())?;
        waveform
            .borrow()
            .validate_expr_values_supported(iff_sources.as_slice())?;
        let bound_when = bind_waveform_logical_expr(&host, scope, source.when.as_str())?;
        let eval_signal_handles = referenced_signal_handles(&bound_when);
        let eval_sources = candidate_sources_for_handles(&host, eval_signal_handles.as_slice())?;
        waveform
            .borrow()
            .validate_expr_values_supported(eval_sources.as_slice())?;
        let payload = resolve_payload_signals(waveform, scope, source.payload.as_slice())?;
        bound_sources.push(BoundExtractSource {
            declaration_index: source.declaration_index,
            name: source.name,
            on: source.on,
            when: source.when,
            payload,
            host,
            bound_event,
            bound_when,
        });
    }

    Ok(bound_sources)
}

fn resolve_payload_signals(
    waveform: &SharedWaveform,
    scope: Option<&str>,
    payload: &[String],
) -> Result<Vec<PayloadSignal>, WavepeekError> {
    let mut display_names = Vec::with_capacity(payload.len());
    let mut canonical_paths = Vec::with_capacity(payload.len());
    for token in payload {
        if scope.is_some() && token.contains('.') {
            return Err(WavepeekError::Args(format!(
                "payload signal '{token}' must be relative when --scope is set. See 'wavepeek extract generic --help'."
            )));
        }
        let path = match scope {
            Some(scope) => format!("{scope}.{token}"),
            None => token.clone(),
        };
        display_names.push(token.clone());
        canonical_paths.push(path);
    }

    let expr_resolved = waveform
        .borrow()
        .resolve_expr_signals(canonical_paths.as_slice())?;
    waveform
        .borrow()
        .validate_expr_values_supported(expr_resolved.as_slice())?;
    let resolved = waveform
        .borrow()
        .resolve_signals(canonical_paths.as_slice())?;
    Ok(display_names
        .into_iter()
        .zip(resolved)
        .map(|(display, resolved)| PayloadSignal {
            display,
            path: resolved.path.clone(),
            resolved,
        })
        .collect())
}

fn build_event_groups(sources: &[BoundExtractSource]) -> Result<Vec<EventGroup>, WavepeekError> {
    let mut groups: Vec<EventGroup> = Vec::new();
    let mut groups_by_key: HashMap<EventGroupKey, usize> = HashMap::new();

    for (source_index, source) in sources.iter().enumerate() {
        debug_assert_eq!(source.declaration_index, source_index);
        let candidate_sources = candidate_sources_for_handles(
            &source.host,
            event_candidate_handles(&source.bound_event).as_slice(),
        )?;
        let candidate_key = candidate_key_for_sources(&candidate_sources);
        let key = EventGroupKey {
            on: source.on.clone(),
            candidate_ids: candidate_key.clone(),
        };

        if let Some(group_index) = groups_by_key.get(&key).copied() {
            groups[group_index].source_indices.push(source_index);
            continue;
        }

        let group_index = groups.len();
        groups.push(EventGroup {
            source_indices: vec![source_index],
            candidate_sources,
            candidate_key,
        });
        groups_by_key.insert(key, group_index);
    }

    Ok(groups)
}

fn candidate_key_for_sources(candidate_sources: &[ExprResolvedSignal]) -> Vec<SignalId> {
    let mut candidate_ids = candidate_sources
        .iter()
        .map(|candidate| candidate.id)
        .collect::<Vec<_>>();
    candidate_ids.sort_unstable();
    candidate_ids.dedup();
    candidate_ids
}

fn collect_event_group_candidate_times(
    waveform: &SharedWaveform,
    event_groups: &[EventGroup],
    from_raw: u64,
    to_raw: u64,
) -> Result<Vec<EventGroupCandidateTimes>, WavepeekError> {
    let mut times_by_candidate_key: HashMap<Vec<SignalId>, Rc<Vec<u64>>> = HashMap::new();
    let mut group_candidate_times = Vec::with_capacity(event_groups.len());

    for (group_index, group) in event_groups.iter().enumerate() {
        let times = if let Some(times) = times_by_candidate_key.get(&group.candidate_key) {
            Rc::clone(times)
        } else {
            let times = Rc::new(
                waveform
                    .borrow_mut()
                    .collect_expr_candidate_times_with_mode(
                        group.candidate_sources.as_slice(),
                        from_raw,
                        to_raw,
                        ChangeCandidateCollectionMode::Auto,
                    )?,
            );
            times_by_candidate_key.insert(group.candidate_key.clone(), Rc::clone(&times));
            times
        };
        group_candidate_times.push(EventGroupCandidateTimes {
            group_index,
            times,
            cursor: 0,
        });
    }

    Ok(group_candidate_times)
}

fn preload_extract_value_changes(
    waveform: &SharedWaveform,
    sources: &[BoundExtractSource],
    event_groups: &[EventGroup],
    from_raw: u64,
    to_raw: u64,
) -> Result<(), WavepeekError> {
    let mut expr_sources = Vec::new();
    let mut seen_expr = HashSet::new();
    for group in event_groups {
        extend_unique_expr_sources(&mut expr_sources, &mut seen_expr, &group.candidate_sources);
    }
    for source in sources {
        let iff_handles = event_iff_handles(&source.bound_event);
        let iff_sources = candidate_sources_for_handles(&source.host, iff_handles.as_slice())?;
        extend_unique_expr_sources(&mut expr_sources, &mut seen_expr, &iff_sources);

        let when_handles = referenced_signal_handles(&source.bound_when);
        let when_sources = candidate_sources_for_handles(&source.host, when_handles.as_slice())?;
        extend_unique_expr_sources(&mut expr_sources, &mut seen_expr, &when_sources);
    }

    let mut payload_sources = Vec::new();
    let mut seen_payload = HashSet::new();
    for source in sources {
        for payload in &source.payload {
            if seen_payload.insert(payload.resolved.id) {
                payload_sources.push(payload.resolved.clone());
            }
        }
    }

    let mut waveform = waveform.borrow_mut();
    waveform.preload_expr_value_changes(expr_sources.as_slice(), from_raw, to_raw)?;
    waveform.preload_resolved_value_changes(payload_sources.as_slice(), from_raw, to_raw)
}

fn extend_unique_expr_sources(
    target: &mut Vec<ExprResolvedSignal>,
    seen: &mut HashSet<SignalId>,
    sources: &[ExprResolvedSignal],
) {
    for source in sources {
        if seen.insert(source.id) {
            target.push(source.clone());
        }
    }
}

fn count_merged_candidate_times(group_candidate_times: &[EventGroupCandidateTimes]) -> usize {
    let mut cursors = vec![0usize; group_candidate_times.len()];
    let mut count = 0usize;

    loop {
        let Some(timestamp) = group_candidate_times
            .iter()
            .enumerate()
            .filter_map(|(group_index, group)| group.times.get(cursors[group_index]).copied())
            .min()
        else {
            return count;
        };

        count += 1;
        for (group_index, group) in group_candidate_times.iter().enumerate() {
            while group
                .times
                .get(cursors[group_index])
                .is_some_and(|candidate| *candidate == timestamp)
            {
                cursors[group_index] += 1;
            }
        }
    }
}

fn next_active_event_groups(
    group_candidate_times: &mut [EventGroupCandidateTimes],
    active_groups: &mut Vec<usize>,
) -> Option<u64> {
    active_groups.clear();
    let timestamp = group_candidate_times
        .iter()
        .filter_map(|group| group.times.get(group.cursor).copied())
        .min()?;

    for group in group_candidate_times {
        while group
            .times
            .get(group.cursor)
            .is_some_and(|candidate| *candidate == timestamp)
        {
            if active_groups.last().copied() != Some(group.group_index) {
                active_groups.push(group.group_index);
            }
            group.cursor += 1;
        }
    }

    Some(timestamp)
}

fn count_timestamps_in_range(timestamps: &[u64], from_raw: u64, to_raw: u64) -> usize {
    let start_idx = timestamps.partition_point(|timestamp| *timestamp < from_raw);
    let end_idx = timestamps.partition_point(|timestamp| *timestamp <= to_raw);
    end_idx.saturating_sub(start_idx)
}

fn duration_ns(duration: Duration) -> u64 {
    u64::try_from(duration.as_nanos()).unwrap_or(u64::MAX)
}

fn emit_rows<S: ExtractRowSink + ?Sized>(
    context: ExtractEmitContext<'_>,
    mut group_candidate_times: Vec<EventGroupCandidateTimes>,
    candidate_times_total: usize,
    sink: &mut S,
) -> Result<ExtractRunStats, WavepeekError> {
    let mut candidate_count = 0usize;
    let mut event_checks = 0usize;
    let mut event_matches_count = 0usize;
    let mut predicate_true = 0usize;
    let mut skipped_no_sample_time = 0usize;
    let mut emitted = 0usize;
    let mut truncated = false;
    let mut event_match_time = Duration::ZERO;
    let mut predicate_eval_time = Duration::ZERO;
    let mut build_emit_time = Duration::ZERO;
    let mut active_groups = Vec::new();
    let mut matched_source_indices = Vec::new();

    'timestamps: while let Some(timestamp) =
        next_active_event_groups(&mut group_candidate_times, &mut active_groups)
    {
        candidate_count += 1;
        matched_source_indices.clear();
        let previous_timestamp = context.waveform.borrow().previous_sample_time(timestamp);

        let mut matching_group_count = 0usize;
        for group_index in &active_groups {
            let group = &context.event_groups[*group_index];
            let representative = &context.sources[group.source_indices[0]];
            let frame = EventEvalFrame {
                timestamp,
                previous_timestamp,
                tracked_signals: &[],
            };
            event_checks += 1;
            let started_at = context.profile_timing.then(Instant::now);
            let event_matches_row = event_expr_matches(
                representative.on.as_str(),
                &representative.bound_event,
                &representative.host,
                &frame,
            )?;
            if let Some(started_at) = started_at {
                event_match_time += started_at.elapsed();
            }
            if event_matches_row {
                event_matches_count += 1;
                matching_group_count += 1;
                matched_source_indices.extend(group.source_indices.iter().copied());
            }
        }

        if matched_source_indices.is_empty() {
            continue;
        }
        if matching_group_count > 1 {
            matched_source_indices.sort_unstable_by_key(|source_index| {
                context.sources[*source_index].declaration_index
            });
        }

        let Some(sample_timestamp) = timestamp
            .checked_sub(1)
            .filter(|value| *value >= context.dump_start_raw && *value <= context.dump_end_raw)
        else {
            skipped_no_sample_time += matched_source_indices.len();
            continue;
        };

        for source_index in &matched_source_indices {
            let source = &context.sources[*source_index];
            debug_assert_eq!(source.declaration_index, *source_index);
            let started_at = context.profile_timing.then(Instant::now);
            let predicate_matches = eval_bound_logical_truth(
                source.when.as_str(),
                &source.bound_when,
                &source.host,
                sample_timestamp,
            )?;
            if let Some(started_at) = started_at {
                predicate_eval_time += started_at.elapsed();
            }
            if !predicate_matches {
                continue;
            }
            predicate_true += 1;
            if let Some(limit) = context.max_entries
                && emitted == limit
            {
                truncated = true;
                break 'timestamps;
            }
            let started_at = context.profile_timing.then(Instant::now);
            let row = build_row(
                source,
                timestamp,
                sample_timestamp,
                context.dump_tick,
                context.waveform,
            )?;
            sink.emit(row)?;
            if let Some(started_at) = started_at {
                build_emit_time += started_at.elapsed();
            }
            emitted += 1;
        }
    }

    Ok(ExtractRunStats {
        candidate_times: if context.profile_timing {
            candidate_times_total
        } else {
            candidate_count
        },
        event_checks,
        event_matches: event_matches_count,
        predicate_true,
        skipped_no_sample_time,
        emitted,
        truncated,
        event_match_ns: duration_ns(event_match_time),
        predicate_eval_ns: duration_ns(predicate_eval_time),
        build_emit_ns: duration_ns(build_emit_time),
    })
}

fn build_row(
    source: &BoundExtractSource,
    timestamp: u64,
    sample_timestamp: u64,
    dump_tick: crate::engine::time::ParsedTime,
    waveform: &SharedWaveform,
) -> Result<ExtractGenericRow, WavepeekError> {
    let resolved = source
        .payload
        .iter()
        .map(|payload| payload.resolved.clone())
        .collect::<Vec<_>>();
    let samples = waveform
        .borrow_mut()
        .sample_resolved_optional(resolved.as_slice(), sample_timestamp)?;
    let payload = source
        .payload
        .iter()
        .zip(samples.iter())
        .map(|(requested, sampled)| build_payload_value(requested, sampled))
        .collect::<Result<Vec<_>, _>>()?;

    Ok(ExtractGenericRow {
        time: format_raw_timestamp(timestamp, dump_tick)?,
        sample_time: format_raw_timestamp(sample_timestamp, dump_tick)?,
        source: source.name.clone(),
        payload,
    })
}

fn build_payload_value(
    requested: &PayloadSignal,
    sampled: &SampledSignalState,
) -> Result<ExtractPayloadValue, WavepeekError> {
    let bits = sampled.bits.as_ref().ok_or_else(|| {
        WavepeekError::Signal(format!(
            "signal '{}' has no value at or before requested time",
            requested.path
        ))
    })?;
    Ok(ExtractPayloadValue {
        display: requested.display.clone(),
        path: requested.path.clone(),
        value: format_verilog_literal(sampled.width, bits.as_str()),
    })
}

fn parse_bound_time(
    token: &str,
    arg_name: &str,
    dump_time: DumpTimeContext,
    metadata: &crate::waveform::WaveformMetadata,
) -> Result<u64, WavepeekError> {
    match validate_time_token_to_raw(token, dump_time, true) {
        Ok(raw) => Ok(raw),
        Err(TimeValidationError::RequiresUnits) => Err(WavepeekError::Args(format!(
            "time token '{token}' requires units. See 'wavepeek extract generic --help'."
        ))),
        Err(TimeValidationError::InvalidToken) => Err(WavepeekError::Args(format!(
            "invalid time token '{token}': expected <integer><unit> (for example 10ns). See 'wavepeek extract generic --help'."
        ))),
        Err(TimeValidationError::TooLarge) => Err(WavepeekError::Args(format!(
            "time '{token}' is too large to process safely. See 'wavepeek extract generic --help'."
        ))),
        Err(TimeValidationError::OutOfBounds) => Err(WavepeekError::Args(format!(
            "time '{}' for {} is outside dump bounds [{}, {}]. See 'wavepeek extract generic --help'.",
            token, arg_name, metadata.time_start, metadata.time_end
        ))),
        Err(TimeValidationError::NotAligned) => {
            let dump_precision = format_raw_timestamp(1, dump_time.dump_tick)?;
            Err(WavepeekError::Args(format!(
                "time '{token}' cannot be represented exactly in dump precision '{}'. See 'wavepeek extract generic --help'.",
                dump_precision
            )))
        }
        Err(TimeValidationError::RawOutOfRange) => Err(WavepeekError::Args(format!(
            "time '{token}' exceeds supported raw timestamp range. See 'wavepeek extract generic --help'."
        ))),
    }
}

#[cfg(test)]
mod tests {
    use super::{build_plan, normalize_payload, require_unique_payloads};
    use crate::cli::extract::GenericArgs;
    use crate::cli::limits::LimitArg;

    #[test]
    fn cli_plan_defaults_source_name_and_payload_order() {
        let plan = build_plan(&GenericArgs {
            waves: "dump.vcd".into(),
            source: None,
            from: None,
            to: None,
            scope: None,
            name: None,
            on: Some("posedge clk".to_string()),
            when: Some("valid".to_string()),
            payload: Some(vec!["data".to_string(), "last".to_string()]),
            max: LimitArg::Numeric(50),
            abs: false,
            json: false,
            jsonl: false,
        })
        .expect("plan should build");
        assert_eq!(plan.sources[0].name, "transfer");
        assert_eq!(plan.sources[0].payload, vec!["data", "last"]);
    }

    #[test]
    fn payload_normalization_rejects_empty_and_duplicate_names() {
        assert!(normalize_payload(vec![" ".to_string()]).is_err());
        let payload = normalize_payload(vec![" data ".to_string(), "data".to_string()])
            .expect("trimmed payload should parse");
        assert_eq!(payload, vec!["data", "data"]);
        assert!(require_unique_payloads(&payload).is_err());
    }
}