vyre-self-substrate 0.6.1

Vyre self-substrate: vyre using its own primitives on its own scheduler problems. The recursion-thesis layer between vyre-primitives and vyre-driver.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
//! Release benchmark baseline validation.

use std::collections::BTreeSet;

/// Direction used when comparing an observed metric to its release threshold.
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum BenchmarkThresholdDirection {
    /// Observed value must be greater than or equal to the threshold.
    AtLeast,
    /// Observed value must be less than or equal to the threshold.
    AtMost,
}

/// One committed benchmark baseline record.
#[derive(Clone, Copy, Debug, PartialEq)]
pub struct ReleaseBenchmarkBaseline {
    /// Stable baseline id.
    pub id: &'static str,
    /// Exact command used to produce the observation.
    pub command: &'static str,
    /// Hardware label, including GPU model.
    pub hardware: &'static str,
    /// Metric name.
    pub metric: &'static str,
    /// Observed metric value.
    pub observed: f64,
    /// Release threshold.
    pub threshold: f64,
    /// Threshold comparison direction.
    pub direction: BenchmarkThresholdDirection,
}

/// Validated benchmark baseline summary.
#[derive(Clone, Copy, Debug, PartialEq)]
pub struct ReleaseBenchmarkBaselineProof {
    /// Number of accepted baselines.
    pub baseline_count: usize,
    /// Number of CUDA baselines.
    pub cuda_baseline_count: usize,
}

/// One committed benchmark artifact checked by the release baseline gate.
#[derive(Clone, Copy, Debug, PartialEq)]
pub struct ReleaseBenchmarkArtifact<'a> {
    /// Repository-relative artifact path.
    pub path: &'a str,
    /// Raw artifact contents.
    pub contents: &'a str,
    /// Human-readable workload family that must appear in the artifact.
    pub required_family: &'a str,
}

/// Validated committed benchmark artifact summary.
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub struct ReleaseBenchmarkArtifactProof {
    /// Number of accepted committed artifacts.
    pub artifact_count: usize,
}

/// Benchmark baseline validation errors.
#[derive(Clone, Debug, PartialEq)]
pub enum ReleaseBenchmarkBaselineError {
    /// No baselines provided.
    EmptyBaselines,
    /// Baseline id is duplicate.
    DuplicateId {
        /// Duplicate id.
        id: &'static str,
    },
    /// Required metadata is empty.
    EmptyMetadata {
        /// Baseline id.
        id: &'static str,
        /// Empty field name.
        field: &'static str,
    },
    /// Command does not use cargo_full.
    CommandDoesNotUseCargoFull {
        /// Baseline id.
        id: &'static str,
        /// Command.
        command: &'static str,
    },
    /// Hardware does not name a CUDA GPU.
    MissingCudaHardware {
        /// Baseline id.
        id: &'static str,
        /// Hardware label.
        hardware: &'static str,
    },
    /// Observed or threshold value is invalid.
    InvalidMetric {
        /// Baseline id.
        id: &'static str,
    },
    /// Observed value misses the release threshold.
    ThresholdMiss {
        /// Baseline id.
        id: &'static str,
        /// Observed value.
        observed: f64,
        /// Threshold value.
        threshold: f64,
        /// Direction.
        direction: BenchmarkThresholdDirection,
    },
    /// A committed benchmark artifact is missing required release evidence.
    ArtifactMissingEvidence {
        /// Artifact path.
        path: String,
        /// Missing evidence field.
        evidence: &'static str,
    },
}

impl std::fmt::Display for ReleaseBenchmarkBaselineError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::EmptyBaselines => write!(
                f,
                "release benchmark baselines are empty. Fix: commit exact benchmark command, CUDA hardware, metric, observed value, and threshold."
            ),
            Self::DuplicateId { id } => write!(
                f,
                "release benchmark baseline `{id}` is duplicated. Fix: keep one owner per release metric."
            ),
            Self::EmptyMetadata { id, field } => write!(
                f,
                "release benchmark baseline `{id}` has empty {field}. Fix: every baseline needs id, command, hardware, metric, observed value, and threshold."
            ),
            Self::CommandDoesNotUseCargoFull { id, command } => write!(
                f,
                "release benchmark baseline `{id}` uses `{command}` instead of ./cargo_full. Fix: record the exact cargo_full benchmark command."
            ),
            Self::MissingCudaHardware { id, hardware } => write!(
                f,
                "release benchmark baseline `{id}` hardware `{hardware}` does not name CUDA/NVIDIA hardware. Fix: record the RTX 5090/CUDA device used for the run."
            ),
            Self::InvalidMetric { id } => write!(
                f,
                "release benchmark baseline `{id}` has invalid metric values. Fix: observed and threshold must be positive finite values."
            ),
            Self::ThresholdMiss {
                id,
                observed,
                threshold,
                direction,
            } => write!(
                f,
                "release benchmark baseline `{id}` missed threshold: observed={observed}, threshold={threshold}, direction={direction:?}. Fix: improve performance or update the release target with explicit approval."
            ),
            Self::ArtifactMissingEvidence { path, evidence } => write!(
                f,
                "release benchmark artifact `{path}` is missing {evidence}. Fix: commit benchmark evidence with CUDA hardware, pass status, 100x contract, samples, and source fingerprint."
            ),
        }
    }
}

impl std::error::Error for ReleaseBenchmarkBaselineError {}

/// Validate committed release benchmark baselines.
pub fn validate_release_benchmark_baselines(
    baselines: &[ReleaseBenchmarkBaseline],
) -> Result<ReleaseBenchmarkBaselineProof, ReleaseBenchmarkBaselineError> {
    if baselines.is_empty() {
        return Err(ReleaseBenchmarkBaselineError::EmptyBaselines);
    }
    let mut ids = BTreeSet::new();
    let mut cuda_baseline_count = 0_usize;

    for baseline in baselines {
        validate_metadata(baseline)?;
        if !ids.insert(baseline.id) {
            return Err(ReleaseBenchmarkBaselineError::DuplicateId { id: baseline.id });
        }
        if !baseline.command.trim_start().starts_with("./cargo_full ") {
            return Err(ReleaseBenchmarkBaselineError::CommandDoesNotUseCargoFull {
                id: baseline.id,
                command: baseline.command,
            });
        }
        if !baseline.hardware.contains("CUDA")
            && !baseline.hardware.contains("NVIDIA")
            && !baseline.hardware.contains("RTX")
        {
            return Err(ReleaseBenchmarkBaselineError::MissingCudaHardware {
                id: baseline.id,
                hardware: baseline.hardware,
            });
        }
        cuda_baseline_count += 1;
        if !baseline.observed.is_finite()
            || !baseline.threshold.is_finite()
            || baseline.observed <= 0.0
            || baseline.threshold <= 0.0
        {
            return Err(ReleaseBenchmarkBaselineError::InvalidMetric { id: baseline.id });
        }
        let passed = match baseline.direction {
            BenchmarkThresholdDirection::AtLeast => baseline.observed >= baseline.threshold,
            BenchmarkThresholdDirection::AtMost => baseline.observed <= baseline.threshold,
        };
        if !passed {
            return Err(ReleaseBenchmarkBaselineError::ThresholdMiss {
                id: baseline.id,
                observed: baseline.observed,
                threshold: baseline.threshold,
                direction: baseline.direction,
            });
        }
    }

    Ok(ReleaseBenchmarkBaselineProof {
        baseline_count: baselines.len(),
        cuda_baseline_count,
    })
}

/// Validate committed benchmark artifacts, not just in-code baseline records.
pub fn validate_committed_benchmark_artifacts(
    artifacts: &[ReleaseBenchmarkArtifact<'_>],
) -> Result<ReleaseBenchmarkArtifactProof, ReleaseBenchmarkBaselineError> {
    if artifacts.is_empty() {
        return Err(ReleaseBenchmarkBaselineError::EmptyBaselines);
    }
    for artifact in artifacts {
        validate_artifact_field(artifact, "path", artifact.path)?;
        validate_artifact_field(artifact, "contents", artifact.contents)?;
        validate_artifact_field(artifact, "required_family", artifact.required_family)?;
        require_artifact_contains(
            artifact,
            "selected CUDA backend",
            "\"selected_backend\": \"cuda\"",
        )?;
        require_artifact_contains(artifact, "RTX 5090 hardware", "NVIDIA GeForce RTX 5090")?;
        require_artifact_contains(
            artifact,
            "NVIDIA driver version",
            "\"nvidia_driver_version\"",
        )?;
        require_artifact_contains(artifact, "source fingerprint", "\"source_fingerprint\"")?;
        require_artifact_contains_any(
            artifact,
            "passing case status",
            &["\"status\": \"pass\"", "\"failed_count\": 0"],
        )?;
        require_artifact_contains_any(
            artifact,
            "100x speedup floor",
            &["\"min_speedup_x\": 100", "\"cpu_sota_100x_required\": true"],
        )?;
        require_artifact_contains_any(
            artifact,
            "passed performance contract",
            &[
                "\"contract_passed\": true",
                "\"cpu_sota_100x_passing_cases\": 1",
            ],
        )?;
        require_artifact_contains_any(
            artifact,
            "wall sample count",
            &["\"samples\"", "\"min_wall_samples\""],
        )?;
        if !artifact.contents.contains(artifact.required_family) {
            return Err(ReleaseBenchmarkBaselineError::ArtifactMissingEvidence {
                path: artifact.path.to_owned(),
                evidence: "required workload family",
            });
        }
    }
    Ok(ReleaseBenchmarkArtifactProof {
        artifact_count: artifacts.len(),
    })
}

fn validate_artifact_field(
    artifact: &ReleaseBenchmarkArtifact<'_>,
    field: &'static str,
    value: &str,
) -> Result<(), ReleaseBenchmarkBaselineError> {
    if value.trim().is_empty() {
        return Err(ReleaseBenchmarkBaselineError::ArtifactMissingEvidence {
            path: artifact.path.to_owned(),
            evidence: field,
        });
    }
    Ok(())
}

fn require_artifact_contains(
    artifact: &ReleaseBenchmarkArtifact<'_>,
    evidence: &'static str,
    needle: &str,
) -> Result<(), ReleaseBenchmarkBaselineError> {
    if artifact.contents.contains(needle) {
        Ok(())
    } else {
        Err(ReleaseBenchmarkBaselineError::ArtifactMissingEvidence {
            path: artifact.path.to_owned(),
            evidence,
        })
    }
}

fn require_artifact_contains_any(
    artifact: &ReleaseBenchmarkArtifact<'_>,
    evidence: &'static str,
    needles: &[&str],
) -> Result<(), ReleaseBenchmarkBaselineError> {
    if needles
        .iter()
        .any(|needle| artifact.contents.contains(needle))
    {
        Ok(())
    } else {
        Err(ReleaseBenchmarkBaselineError::ArtifactMissingEvidence {
            path: artifact.path.to_owned(),
            evidence,
        })
    }
}

fn validate_metadata(
    baseline: &ReleaseBenchmarkBaseline,
) -> Result<(), ReleaseBenchmarkBaselineError> {
    for (field, value) in [
        ("id", baseline.id),
        ("command", baseline.command),
        ("hardware", baseline.hardware),
        ("metric", baseline.metric),
    ] {
        if value.trim().is_empty() {
            return Err(ReleaseBenchmarkBaselineError::EmptyMetadata {
                id: baseline.id,
                field,
            });
        }
    }
    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn benchmark_baselines_accept_exact_cuda_cargo_full_records() {
        let proof = validate_release_benchmark_baselines(&[
            baseline(
                "cuda-megakernel-100x",
                125.0,
                100.0,
                BenchmarkThresholdDirection::AtLeast,
            ),
            baseline(
                "cuda-readback-us",
                42.0,
                50.0,
                BenchmarkThresholdDirection::AtMost,
            ),
        ])
        .expect("Fix: valid CUDA baselines should pass");

        assert_eq!(proof.baseline_count, 2);
        assert_eq!(proof.cuda_baseline_count, 2);
    }

    #[test]
    fn benchmark_baselines_reject_non_cargo_full_commands() {
        let mut bad = baseline(
            "bad-command",
            125.0,
            100.0,
            BenchmarkThresholdDirection::AtLeast,
        );
        bad.command = "cargo bench";

        assert_eq!(
            validate_release_benchmark_baselines(&[bad]).expect_err("raw cargo bench should fail"),
            ReleaseBenchmarkBaselineError::CommandDoesNotUseCargoFull {
                id: "bad-command",
                command: "cargo bench",
            }
        );
    }

    #[test]
    fn benchmark_baselines_reject_missing_cuda_hardware_and_threshold_miss() {
        let mut cpu = baseline("cpu", 125.0, 100.0, BenchmarkThresholdDirection::AtLeast);
        cpu.hardware = "generic x86";
        assert_eq!(
            validate_release_benchmark_baselines(&[cpu])
                .expect_err("missing CUDA hardware should fail"),
            ReleaseBenchmarkBaselineError::MissingCudaHardware {
                id: "cpu",
                hardware: "generic x86",
            }
        );

        assert_eq!(
            validate_release_benchmark_baselines(&[baseline(
                "too-slow",
                99.0,
                100.0,
                BenchmarkThresholdDirection::AtLeast,
            )])
            .expect_err("threshold miss should fail"),
            ReleaseBenchmarkBaselineError::ThresholdMiss {
                id: "too-slow",
                observed: 99.0,
                threshold: 100.0,
                direction: BenchmarkThresholdDirection::AtLeast,
            }
        );
    }

    #[test]
    fn benchmark_artifacts_accept_committed_cuda_release_evidence() {
        let proof = validate_committed_benchmark_artifacts(&[
            artifact(
                "release/evidence/benchmarks/cuda-release-suite.json",
                include_str!("../../../../release/evidence/benchmarks/cuda-release-suite.json"),
                "ifds-witness",
            ),
            artifact(
                "release/evidence/benchmarks/megakernel-condition-cuda.json",
                include_str!("../../../../release/evidence/benchmarks/megakernel-condition-cuda.json"),
                "megakernel",
            ),
            artifact(
                "release/evidence/benchmarks/workload-10-megakernel-queued-batches.json",
                include_str!(
                    "../../../../release/evidence/benchmarks/workload-10-megakernel-queued-batches.json"
                ),
                "megakernel",
            ),
            artifact(
                "release/evidence/benchmarks/dataflow-analysis-release.json",
                include_str!("../../../../release/evidence/benchmarks/dataflow-analysis-release.json"),
                "dataflow",
            ),
        ])
        .expect("Fix: committed CUDA benchmark artifacts should satisfy release evidence contracts");

        assert_eq!(proof.artifact_count, 4);
    }

    #[test]
    fn benchmark_artifacts_reject_missing_100x_contract() {
        let err = validate_committed_benchmark_artifacts(&[artifact(
            "bad.json",
            "{\"selected_backend\": \"cuda\", \"gpu\": \"NVIDIA GeForce RTX 5090\", \"nvidia_driver_version\": \"570.211.01\", \"source_fingerprint\": \"git:x\", \"status\": \"pass\", \"contract_passed\": true, \"samples\": 35, \"family\": \"megakernel\"}",
            "megakernel",
        )])
        .expect_err("missing 100x contract should fail");

        assert_eq!(
            err,
            ReleaseBenchmarkBaselineError::ArtifactMissingEvidence {
                path: "bad.json".to_owned(),
                evidence: "100x speedup floor",
            }
        );
    }

    fn artifact(
        path: &'static str,
        contents: &'static str,
        required_family: &'static str,
    ) -> ReleaseBenchmarkArtifact<'static> {
        ReleaseBenchmarkArtifact {
            path,
            contents,
            required_family,
        }
    }

    fn baseline(
        id: &'static str,
        observed: f64,
        threshold: f64,
        direction: BenchmarkThresholdDirection,
    ) -> ReleaseBenchmarkBaseline {
        ReleaseBenchmarkBaseline {
            id,
            command: "./cargo_full bench -j1 -p vyre-driver-cuda",
            hardware: "NVIDIA RTX 5090 CUDA",
            metric: "speedup_x",
            observed,
            threshold,
            direction,
        }
    }
}