vyre-primitives 0.6.1

Compositional primitives for vyre - marker types (always on) + Tier 2.5 LEGO substrate (feature-gated per domain).
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
//! VAST first-child / next-sibling tree traversal primitives.

use std::sync::Arc;

use vyre_foundation::ir::model::expr::Ident;
use vyre_foundation::ir::{BufferAccess, BufferDecl, DataType, Expr, Node, Program};
use vyre_foundation::vast::{NODE_STRIDE_U32, SENTINEL};

/// Primitive op id for preorder VAST tree traversal.
pub const PREORDER_OP_ID: &str = "vyre-primitives::graph::vast_walk_preorder";
/// Primitive op id for postorder VAST tree traversal.
pub const POSTORDER_OP_ID: &str = "vyre-primitives::graph::vast_walk_postorder";

/// Traversal order for VAST first-child / next-sibling tree walks.
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum VastWalkOrder {
    /// Emit each node before its descendants.
    Preorder,
    /// Emit each node after its descendants.
    Postorder,
}

impl VastWalkOrder {
    fn op_id(self) -> &'static str {
        match self {
            Self::Preorder => PREORDER_OP_ID,
            Self::Postorder => POSTORDER_OP_ID,
        }
    }
}

/// Primitive-owned VAST traversal programs for passes that need both orders.
#[derive(Debug, Clone)]
pub struct VastTreeWalkProgramPlan {
    /// Top-down walk used by declaration discovery and source-order diagnostics.
    pub preorder: Program,
    /// Bottom-up walk used by expression typing and lowering passes.
    pub postorder: Program,
}

/// Build checked preorder and postorder VAST traversal programs together.
///
/// # Errors
///
/// Returns the same launch-shape diagnostics as the single-order builders.
pub fn try_ast_walk_plan(
    nodes: &str,
    preorder_out: &str,
    postorder_out: &str,
    node_count: u32,
    out_cap: u32,
) -> Result<VastTreeWalkProgramPlan, String> {
    Ok(VastTreeWalkProgramPlan {
        preorder: try_ast_walk_preorder(nodes, preorder_out, node_count, out_cap)?,
        postorder: try_ast_walk_postorder(nodes, postorder_out, node_count, out_cap)?,
    })
}

/// Emit preorder node indices for a VAST first-child / next-sibling tree.
#[must_use]
pub fn ast_walk_preorder(nodes: &str, out: &str, node_count: u32, out_cap: u32) -> Program {
    try_ast_walk_preorder(nodes, out, node_count, out_cap).unwrap_or_else(|err| panic!("{err}"))
}

/// Emit preorder node indices for a VAST first-child / next-sibling tree with
/// checked launch-shape validation.
pub fn try_ast_walk_preorder(
    nodes: &str,
    out: &str,
    node_count: u32,
    out_cap: u32,
) -> Result<Program, String> {
    try_ast_walk_order(VastWalkOrder::Preorder, nodes, out, node_count, out_cap)
}

/// Emit postorder node indices for a VAST first-child / next-sibling tree.
#[must_use]
pub fn ast_walk_postorder(nodes: &str, out: &str, node_count: u32, out_cap: u32) -> Program {
    try_ast_walk_postorder(nodes, out, node_count, out_cap).unwrap_or_else(|err| panic!("{err}"))
}

/// Emit postorder node indices for a VAST first-child / next-sibling tree with
/// checked launch-shape validation.
pub fn try_ast_walk_postorder(
    nodes: &str,
    out: &str,
    node_count: u32,
    out_cap: u32,
) -> Result<Program, String> {
    try_ast_walk_order(VastWalkOrder::Postorder, nodes, out, node_count, out_cap)
}

/// Emit node indices for a VAST first-child / next-sibling tree in the selected
/// traversal order with checked launch-shape validation.
pub fn try_ast_walk_order(
    order: VastWalkOrder,
    nodes: &str,
    out: &str,
    node_count: u32,
    out_cap: u32,
) -> Result<Program, String> {
    let op_id = order.op_id();
    let (stride, node_words, out_words) = checked_tree_walk_shape(node_count, out_cap, op_id)?;
    let body = match order {
        VastWalkOrder::Preorder => preorder_body(nodes, out, node_count, out_cap, stride),
        VastWalkOrder::Postorder => postorder_body(nodes, out, node_count, out_cap, stride),
    };

    Ok(tree_walk_program(
        op_id, nodes, out, node_words, out_words, body,
    ))
}

fn preorder_body(nodes: &str, out: &str, node_count: u32, out_cap: u32, stride: u32) -> Vec<Node> {
    let valid_node = |expr: Expr| valid_node_expr(expr, node_count);

    vec![
        Node::let_bind("oi", Expr::u32(0)),
        Node::let_bind("n", Expr::u32(0)),
        Node::loop_for(
            "step",
            Expr::u32(0),
            Expr::u32(node_count),
            vec![
                Node::if_then(
                    Expr::eq(Expr::u32(node_count), Expr::u32(0)),
                    vec![Node::return_()],
                ),
                Node::if_then(
                    Expr::ge(Expr::var("oi"), Expr::u32(out_cap)),
                    vec![Node::return_()],
                ),
                Node::if_then(
                    Expr::ge(Expr::var("n"), Expr::u32(node_count)),
                    vec![Node::return_()],
                ),
                Node::let_bind("base", Expr::mul(Expr::var("n"), Expr::u32(stride))),
                Node::let_bind(
                    "fc",
                    Expr::load(nodes, Expr::add(Expr::var("base"), Expr::u32(2))),
                ),
                Node::store(out, Expr::var("oi"), Expr::var("n")),
                Node::assign("oi", Expr::add(Expr::var("oi"), Expr::u32(1))),
                Node::if_then(
                    valid_node(Expr::var("fc")),
                    vec![Node::assign("n", Expr::var("fc"))],
                ),
                Node::if_then(
                    Expr::not(valid_node(Expr::var("fc"))),
                    vec![
                        Node::let_bind("next", Expr::u32(SENTINEL)),
                        Node::let_bind("walk", Expr::var("n")),
                        Node::loop_for(
                            "climb",
                            Expr::u32(0),
                            Expr::u32(node_count),
                            vec![Node::if_then(
                                Expr::and(
                                    Expr::eq(Expr::var("next"), Expr::u32(SENTINEL)),
                                    valid_node(Expr::var("walk")),
                                ),
                                vec![
                                    Node::let_bind(
                                        "walk_base",
                                        Expr::mul(Expr::var("walk"), Expr::u32(stride)),
                                    ),
                                    Node::let_bind(
                                        "sib",
                                        Expr::load(
                                            nodes,
                                            Expr::add(Expr::var("walk_base"), Expr::u32(3)),
                                        ),
                                    ),
                                    Node::if_then(
                                        valid_node(Expr::var("sib")),
                                        vec![Node::assign("next", Expr::var("sib"))],
                                    ),
                                    Node::if_then(
                                        Expr::not(valid_node(Expr::var("sib"))),
                                        vec![
                                            Node::let_bind(
                                                "parent",
                                                Expr::load(
                                                    nodes,
                                                    Expr::add(Expr::var("walk_base"), Expr::u32(1)),
                                                ),
                                            ),
                                            Node::assign("walk", Expr::var("parent")),
                                        ],
                                    ),
                                ],
                            )],
                        ),
                        Node::if_then(
                            Expr::eq(Expr::var("next"), Expr::u32(SENTINEL)),
                            vec![Node::return_()],
                        ),
                        Node::assign("n", Expr::var("next")),
                    ],
                ),
            ],
        ),
    ]
}

fn postorder_body(nodes: &str, out: &str, node_count: u32, out_cap: u32, stride: u32) -> Vec<Node> {
    let valid_node = |expr: Expr| valid_node_expr(expr, node_count);

    vec![
        Node::if_then(
            Expr::eq(Expr::u32(node_count), Expr::u32(0)),
            vec![Node::return_()],
        ),
        Node::let_bind("oi", Expr::u32(0)),
        Node::let_bind("n", Expr::u32(0)),
        descend_to_leftmost_leaf_node(nodes, node_count, stride),
        Node::loop_for(
            "emit",
            Expr::u32(0),
            Expr::u32(node_count),
            vec![
                Node::if_then(
                    Expr::ge(Expr::var("oi"), Expr::u32(out_cap)),
                    vec![Node::return_()],
                ),
                Node::if_then(
                    Expr::ge(Expr::var("n"), Expr::u32(node_count)),
                    vec![Node::return_()],
                ),
                Node::store(out, Expr::var("oi"), Expr::var("n")),
                Node::assign("oi", Expr::add(Expr::var("oi"), Expr::u32(1))),
                Node::if_then(
                    Expr::eq(Expr::var("n"), Expr::u32(0)),
                    vec![Node::return_()],
                ),
                Node::let_bind("base", Expr::mul(Expr::var("n"), Expr::u32(stride))),
                Node::let_bind(
                    "sib",
                    Expr::load(nodes, Expr::add(Expr::var("base"), Expr::u32(3))),
                ),
                Node::if_then(
                    valid_node(Expr::var("sib")),
                    vec![
                        Node::assign("n", Expr::var("sib")),
                        descend_to_leftmost_leaf_node(nodes, node_count, stride),
                    ],
                ),
                Node::if_then(
                    Expr::not(valid_node(Expr::var("sib"))),
                    vec![
                        Node::let_bind(
                            "parent",
                            Expr::load(nodes, Expr::add(Expr::var("base"), Expr::u32(1))),
                        ),
                        Node::if_then(
                            Expr::not(valid_node(Expr::var("parent"))),
                            vec![Node::return_()],
                        ),
                        Node::assign("n", Expr::var("parent")),
                    ],
                ),
            ],
        ),
    ]
}

fn checked_tree_walk_shape(
    node_count: u32,
    out_cap: u32,
    op_id: &'static str,
) -> Result<(u32, u32, u32), String> {
    let stride = NODE_STRIDE_U32 as u32;
    let node_words = checked_node_words(node_count, stride, op_id)?;
    let out_words = checked_out_words(out_cap, op_id)?;
    Ok((stride, node_words, out_words))
}

fn valid_node_expr(expr: Expr, node_count: u32) -> Expr {
    Expr::and(
        Expr::ne(expr.clone(), Expr::u32(SENTINEL)),
        Expr::lt(expr, Expr::u32(node_count)),
    )
}

fn descend_to_leftmost_leaf_node(nodes_name: &str, node_count: u32, stride: u32) -> Node {
    Node::loop_for(
        "descend",
        Expr::u32(0),
        Expr::u32(node_count),
        vec![Node::if_then(
            valid_node_expr(Expr::var("n"), node_count),
            vec![
                Node::let_bind(
                    "fc_idx",
                    Expr::add(Expr::mul(Expr::var("n"), Expr::u32(stride)), Expr::u32(2)),
                ),
                Node::let_bind("fc", Expr::load(nodes_name, Expr::var("fc_idx"))),
                Node::if_then(
                    valid_node_expr(Expr::var("fc"), node_count),
                    vec![Node::assign("n", Expr::var("fc"))],
                ),
            ],
        )],
    )
}

fn checked_node_words(node_count: u32, stride: u32, op_id: &'static str) -> Result<u32, String> {
    if node_count == 0 {
        return Ok(1);
    }
    node_count.checked_mul(stride).ok_or_else(|| {
        format!(
            "{op_id} node_count={node_count} stride={stride} overflows VAST node buffer words. Fix: shard the tree before GPU dispatch."
        )
    })
}

fn checked_out_words(out_cap: u32, op_id: &'static str) -> Result<u32, String> {
    if out_cap == 0 {
        Err(format!(
            "{op_id} requires out_cap > 0. Fix: allocate traversal output capacity before GPU dispatch."
        ))
    } else {
        Ok(out_cap)
    }
}

fn tree_walk_program(
    op_id: &'static str,
    nodes: &str,
    out: &str,
    node_words: u32,
    out_words: u32,
    body: Vec<Node>,
) -> Program {
    Program::wrapped(
        vec![
            BufferDecl::storage(nodes, 0, BufferAccess::ReadOnly, DataType::U32)
                .with_count(node_words),
            BufferDecl::storage(out, 1, BufferAccess::ReadWrite, DataType::U32)
                .with_count(out_words),
        ],
        [1, 1, 1],
        vec![Node::Region {
            generator: Ident::from(op_id),
            source_region: None,
            body: Arc::new(body),
        }],
    )
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn checked_preorder_rejects_zero_output_capacity() {
        let error = try_ast_walk_preorder("nodes", "out", 1, 0)
            .expect_err("checked preorder builder must reject zero output capacity");

        assert!(
            error.contains("out_cap > 0"),
            "error should describe the launch-shape fix: {error}"
        );
    }

    #[test]
    fn checked_postorder_rejects_node_word_overflow() {
        let error = try_ast_walk_postorder("nodes", "out", u32::MAX, 1)
            .expect_err("checked postorder builder must reject node buffer overflow");

        assert!(
            error.contains("overflows VAST node buffer words"),
            "error should describe the VAST buffer overflow: {error}"
        );
    }

    #[test]
    fn checked_plan_builds_both_orders_from_primitive_authority() {
        let plan = try_ast_walk_plan("nodes", "pre", "post", 3, 3)
            .expect("Fix: primitive VAST plan should build both traversal orders");

        assert_eq!(plan.preorder.workgroup_size(), [1, 1, 1]);
        assert_eq!(plan.postorder.workgroup_size(), [1, 1, 1]);
        assert_eq!(plan.preorder.buffers().len(), 2);
        assert_eq!(plan.postorder.buffers().len(), 2);
    }

    #[test]
    fn checked_plan_rejects_shape_before_building_partial_facade_state() {
        let error = try_ast_walk_plan("nodes", "pre", "post", 3, 0)
            .expect_err("Fix: primitive VAST plan should reject invalid shared output capacity");

        assert!(
            error.contains("out_cap > 0"),
            "Fix: VAST plan diagnostic should come from the primitive output-capacity contract: {error}"
        );
    }

    #[test]
    fn legacy_vast_walk_builders_fail_fast_on_invalid_shape() {
        let preorder_panic = std::panic::catch_unwind(|| {
            let _ = ast_walk_preorder("nodes", "out", 1, 0);
        })
        .expect_err("legacy preorder builder must fail fast on zero output capacity");
        let postorder_panic = std::panic::catch_unwind(|| {
            let _ = ast_walk_postorder("nodes", "out", u32::MAX, 1);
        })
        .expect_err("legacy postorder builder must fail fast on node_count overflow");

        let preorder_message = panic_payload_message(preorder_panic);
        let postorder_message = panic_payload_message(postorder_panic);
        assert!(
            preorder_message.contains("out_cap > 0"),
            "error should describe the launch-shape fix: {preorder_message}"
        );
        assert!(
            postorder_message.contains("node_count"),
            "error should describe the node_count overflow: {postorder_message}"
        );
    }

    fn panic_payload_message(payload: Box<dyn std::any::Any + Send>) -> String {
        if let Some(message) = payload.downcast_ref::<&str>() {
            message.to_string()
        } else if let Some(message) = payload.downcast_ref::<String>() {
            message.clone()
        } else {
            format!("{payload:?}")
        }
    }

    #[test]
    fn vast_tree_walk_release_source_has_checked_builders_without_panics() {
        let source = include_str!("vast_tree_walk.rs");
        let production = source
            .split("#[cfg(test)]")
            .next()
            .expect("Fix: VAST tree walk production source must precede tests");

        assert!(
            production.contains("pub fn try_ast_walk_preorder(")
                && production.contains("pub fn try_ast_walk_postorder(")
                && !production.contains("inert_")
                && !production.contains("Err(_) =>"),
            "Fix: VAST traversal builders must expose checked release APIs and must not compile inert no-op kernels."
        );
    }

    // -----------------------------------------------------------------------
    // CPU reference tree walk tests
    // -----------------------------------------------------------------------

    fn fixture_tree() -> Vec<u32> {
        vec![
            1, SENTINEL, 1, SENTINEL, 0, 0, 0, 0, 0,
            0, // node 0 (root): parent=SENTINEL, fc=1, ns=SENTINEL
            2, 0, SENTINEL, 2, 0, 0, 0, 0, 0, 0, // node 1: parent=0, fc=SENTINEL, ns=2
            3, 0, SENTINEL, SENTINEL, 0, 0, 0, 0, 0,
            0, // node 2: parent=0, fc=SENTINEL, ns=SENTINEL
        ]
    }

    fn valid(idx: u32, node_count: u32) -> bool {
        idx != SENTINEL && idx < node_count
    }

    fn cpu_preorder(nodes: &[u32], node_count: u32) -> Vec<u32> {
        if node_count == 0 {
            return Vec::new();
        }
        let stride = NODE_STRIDE_U32 as u32;
        let mut out = Vec::new();
        let mut n: u32 = 0;
        for _ in 0..node_count {
            if !valid(n, node_count) {
                break;
            }
            out.push(n);
            let base = (n * stride) as usize;
            let fc = nodes[base + 2];
            if valid(fc, node_count) {
                n = fc;
            } else {
                // Climb up to find a sibling
                let mut walk = n;
                let mut next = SENTINEL;
                while valid(walk, node_count) && next == SENTINEL {
                    let wb = (walk * stride) as usize;
                    let sib = nodes[wb + 3];
                    if valid(sib, node_count) {
                        next = sib;
                    } else {
                        walk = nodes[wb + 1]; // parent
                    }
                }
                if next == SENTINEL {
                    break;
                }
                n = next;
            }
        }
        out
    }

    fn cpu_postorder(nodes: &[u32], node_count: u32) -> Vec<u32> {
        if node_count == 0 {
            return Vec::new();
        }
        let stride = NODE_STRIDE_U32 as u32;
        let mut out = Vec::new();
        // Descend to leftmost leaf
        let mut n: u32 = 0;
        loop {
            let base = (n * stride) as usize;
            let fc = nodes[base + 2];
            if valid(fc, node_count) {
                n = fc;
            } else {
                break;
            }
        }
        for _ in 0..node_count {
            if !valid(n, node_count) {
                break;
            }
            out.push(n);
            if n == 0 {
                break;
            } // root emitted - done
            let base = (n * stride) as usize;
            let sib = nodes[base + 3];
            if valid(sib, node_count) {
                // Go to sibling's leftmost leaf
                n = sib;
                loop {
                    let sb = (n * stride) as usize;
                    let fc = nodes[sb + 2];
                    if valid(fc, node_count) {
                        n = fc;
                    } else {
                        break;
                    }
                }
            } else {
                n = nodes[base + 1]; // parent
            }
        }
        out
    }

    #[test]
    fn cpu_preorder_matches_inventory() {
        let tree = fixture_tree();
        let result = cpu_preorder(&tree, 3);
        assert_eq!(result, vec![0, 1, 2]);
    }

    #[test]
    fn cpu_postorder_matches_inventory() {
        let tree = fixture_tree();
        let result = cpu_postorder(&tree, 3);
        assert_eq!(result, vec![1, 2, 0]);
    }

    #[test]
    fn cpu_preorder_single_node() {
        let tree = vec![42u32, SENTINEL, SENTINEL, SENTINEL, 0, 0, 0, 0, 0, 0];
        assert_eq!(cpu_preorder(&tree, 1), vec![0]);
    }

    #[test]
    fn cpu_postorder_single_node() {
        let tree = vec![42u32, SENTINEL, SENTINEL, SENTINEL, 0, 0, 0, 0, 0, 0];
        assert_eq!(cpu_postorder(&tree, 1), vec![0]);
    }

    #[test]
    fn cpu_preorder_empty() {
        assert_eq!(cpu_preorder(&[], 0), Vec::<u32>::new());
    }

    #[test]
    fn cpu_postorder_empty() {
        assert_eq!(cpu_postorder(&[], 0), Vec::<u32>::new());
    }

    fn generated_parent(seed: u32, child: u32) -> u32 {
        seed.wrapping_mul(1_664_525)
            .wrapping_add(child.wrapping_mul(1_013_904_223))
            .rotate_left(child % 31)
            % child
    }

    fn generated_valid_tree(seed: u32, node_count: u32) -> Vec<u32> {
        let stride = NODE_STRIDE_U32 as usize;
        let mut nodes = vec![0u32; node_count as usize * stride];
        for node in 0..node_count {
            let base = node as usize * stride;
            nodes[base] = seed ^ node;
            nodes[base + 1] = SENTINEL;
            nodes[base + 2] = SENTINEL;
            nodes[base + 3] = SENTINEL;
        }

        for child in 1..node_count {
            let parent = generated_parent(seed, child);
            let child_base = child as usize * stride;
            let parent_base = parent as usize * stride;
            nodes[child_base + 1] = parent;

            if nodes[parent_base + 2] == SENTINEL {
                nodes[parent_base + 2] = child;
                continue;
            }

            let mut sibling = nodes[parent_base + 2];
            loop {
                let sibling_next = sibling as usize * stride + 3;
                if nodes[sibling_next] == SENTINEL {
                    nodes[sibling_next] = child;
                    break;
                }
                sibling = nodes[sibling_next];
            }
        }

        nodes
    }

    fn positions(order: &[u32], node_count: u32) -> Vec<u32> {
        let mut positions = vec![SENTINEL; node_count as usize];
        for (pos, node) in order.iter().copied().enumerate() {
            assert!(
                valid(node, node_count),
                "generated VAST traversal emitted invalid node {node}"
            );
            assert_eq!(
                positions[node as usize], SENTINEL,
                "generated VAST traversal emitted node {node} twice"
            );
            positions[node as usize] = pos as u32;
        }
        assert!(
            positions.iter().all(|pos| *pos != SENTINEL),
            "generated VAST traversal missed at least one node"
        );
        positions
    }

    #[test]
    fn generated_vast_walk_orders_match_tree_order_contracts() {
        for seed in 0..2048u32 {
            let node_count = seed % 37 + 1;
            let tree = generated_valid_tree(seed, node_count);
            let preorder = cpu_preorder(&tree, node_count);
            let postorder = cpu_postorder(&tree, node_count);

            assert_eq!(
                preorder.len(),
                node_count as usize,
                "preorder must emit every generated VAST node exactly once for seed {seed}"
            );
            assert_eq!(
                postorder.len(),
                node_count as usize,
                "postorder must emit every generated VAST node exactly once for seed {seed}"
            );

            let preorder_positions = positions(&preorder, node_count);
            let postorder_positions = positions(&postorder, node_count);
            let stride = NODE_STRIDE_U32 as usize;

            for child in 1..node_count {
                let parent = tree[child as usize * stride + 1];
                assert!(
                    preorder_positions[parent as usize] < preorder_positions[child as usize],
                    "preorder must emit parent {parent} before child {child} for seed {seed}"
                );
                assert!(
                    postorder_positions[child as usize] < postorder_positions[parent as usize],
                    "postorder must emit child {child} before parent {parent} for seed {seed}"
                );
            }
        }
    }
}

#[cfg(feature = "inventory-registry")]

fn fixture_u32(words: &[u32]) -> Vec<u8> {
    crate::wire::pack_u32_slice(words)
}

#[cfg(feature = "inventory-registry")]
fn fixture_tree_words() -> Vec<u32> {
    vec![
        1, SENTINEL, 1, SENTINEL, 0, 0, 0, 0, 0, 0, // root
        2, 0, SENTINEL, 2, 0, 0, 0, 0, 0, 0, // first child
        3, 0, SENTINEL, SENTINEL, 0, 0, 0, 0, 0, 0, // second child
    ]
}

#[cfg(feature = "inventory-registry")]
inventory::submit! {
    crate::harness::OpEntry::new(
        PREORDER_OP_ID,
        || ast_walk_preorder("nodes", "out", 3, 3),
        Some(|| vec![vec![
            fixture_u32(&fixture_tree_words()),
            fixture_u32(&[SENTINEL, SENTINEL, SENTINEL]),
        ]]),
        Some(|| vec![vec![fixture_u32(&[0, 1, 2])]]),
    )
}

#[cfg(feature = "inventory-registry")]
inventory::submit! {
    crate::harness::OpEntry::new(
        POSTORDER_OP_ID,
        || ast_walk_postorder("nodes", "out", 3, 3),
        Some(|| vec![vec![
            fixture_u32(&fixture_tree_words()),
            fixture_u32(&[SENTINEL, SENTINEL, SENTINEL]),
        ]]),
        Some(|| vec![vec![fixture_u32(&[1, 2, 0])]]),
    )
}