vtcode-core 0.136.3

Core library for VT Code - a Rust-based terminal coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
use rustc_hash::FxHashSet;
use std::path::Path;
use std::sync::Arc;

use anyhow::{Result, anyhow};
use serde_json::{Value, json};

use crate::config::constants::tools;
use crate::config::mcp::McpAllowListConfig;
use crate::tool_policy::{ToolExecutionDecision, ToolPolicy, ToolPolicyManager};
use crate::tools::handlers::SessionToolsConfig;
use crate::tools::names::canonical_tool_name;
use crate::tools::tool_intent::file_operation_action_is;

#[cfg(test)]
#[derive(Clone, Default)]
pub(super) struct PolicyCatalogueTestPause {
    reached: Arc<tokio::sync::Notify>,
    resume: Arc<tokio::sync::Notify>,
}

#[cfg(test)]
impl PolicyCatalogueTestPause {
    pub(super) async fn pause(&self) {
        self.reached.notify_one();
        self.resume.notified().await;
    }

    pub(super) async fn wait_until_reached(&self) {
        self.reached.notified().await;
    }

    pub(super) fn resume(&self) {
        self.resume.notify_one();
    }
}

#[cfg(test)]
#[derive(Default)]
pub(super) struct PolicyCatalogueTestHooks {
    before_enable_lifecycle: parking_lot::Mutex<Option<PolicyCatalogueTestPause>>,
    before_disable_lifecycle: parking_lot::Mutex<Option<PolicyCatalogueTestPause>>,
    after_enable_snapshot: parking_lot::Mutex<Option<PolicyCatalogueTestPause>>,
    after_refresh_snapshot: parking_lot::Mutex<Option<PolicyCatalogueTestPause>>,
}

#[cfg(test)]
impl PolicyCatalogueTestHooks {
    pub(super) fn install_before_enable_lifecycle(&self, pause: PolicyCatalogueTestPause) {
        *self.before_enable_lifecycle.lock() = Some(pause);
    }

    pub(super) fn install_before_disable_lifecycle(&self, pause: PolicyCatalogueTestPause) {
        *self.before_disable_lifecycle.lock() = Some(pause);
    }

    pub(super) fn install_after_enable_snapshot(&self, pause: PolicyCatalogueTestPause) {
        *self.after_enable_snapshot.lock() = Some(pause);
    }

    pub(super) fn install_after_refresh_snapshot(&self, pause: PolicyCatalogueTestPause) {
        *self.after_refresh_snapshot.lock() = Some(pause);
    }

    pub(super) async fn pause_before_enable_lifecycle(&self) {
        let pause = self.before_enable_lifecycle.lock().take();
        if let Some(pause) = pause {
            pause.pause().await;
        }
    }

    pub(super) async fn pause_before_disable_lifecycle(&self) {
        let pause = self.before_disable_lifecycle.lock().take();
        if let Some(pause) = pause {
            pause.pause().await;
        }
    }

    pub(super) async fn pause_after_enable_snapshot(&self) {
        let pause = self.after_enable_snapshot.lock().take();
        if let Some(pause) = pause {
            pause.pause().await;
        }
    }

    pub(super) async fn pause_after_refresh_snapshot(&self) {
        let pause = self.after_refresh_snapshot.lock().take();
        if let Some(pause) = pause {
            pause.pause().await;
        }
    }
}

use super::ToolPermissionDecision;
use super::risk_scorer::{RiskLevel, ToolRiskContext, ToolRiskScorer, ToolSource, WorkspaceTrust};

#[derive(Clone, Default)]
pub(super) struct ToolPolicyGateway {
    tool_policy: Option<ToolPolicyManager>,
    preapproved_tools: FxHashSet<String>,
    full_auto_allowlist: Option<FxHashSet<String>>,
    full_auto_catalogue_config: Option<SessionToolsConfig>,
    /// Serialises full-auto lifecycle changes with catalogue snapshots.
    full_auto_catalogue_lifecycle: Arc<tokio::sync::Mutex<()>>,
    #[cfg(test)]
    full_auto_catalogue_test_hooks: Arc<PolicyCatalogueTestHooks>,
    enforce_safe_mode_prompts: bool,
}

impl ToolPolicyGateway {
    pub async fn new(workspace_root: &Path) -> Self {
        let tool_policy = match ToolPolicyManager::new_with_workspace(workspace_root).await {
            Ok(manager) => Some(manager),
            Err(err) => {
                tracing::warn!(%err, "Failed to initialize tool policy manager");
                None
            }
        };

        Self {
            tool_policy,
            preapproved_tools: FxHashSet::default(),
            full_auto_allowlist: None,
            full_auto_catalogue_config: None,
            full_auto_catalogue_lifecycle: Arc::new(tokio::sync::Mutex::new(())),
            #[cfg(test)]
            full_auto_catalogue_test_hooks: Arc::new(PolicyCatalogueTestHooks::default()),
            enforce_safe_mode_prompts: false,
        }
    }

    pub fn with_policy_manager(manager: ToolPolicyManager) -> Self {
        Self {
            tool_policy: Some(manager),
            preapproved_tools: FxHashSet::default(),
            full_auto_allowlist: None,
            full_auto_catalogue_config: None,
            full_auto_catalogue_lifecycle: Arc::new(tokio::sync::Mutex::new(())),
            #[cfg(test)]
            full_auto_catalogue_test_hooks: Arc::new(PolicyCatalogueTestHooks::default()),
            enforce_safe_mode_prompts: false,
        }
    }

    pub fn set_enforce_safe_mode_prompts(&mut self, enabled: bool) {
        self.enforce_safe_mode_prompts = enabled;
    }

    fn requires_safe_mode_prompt(&self, safe_mode_prompt: bool) -> bool {
        self.enforce_safe_mode_prompts && safe_mode_prompt
    }

    pub fn has_policy_manager(&self) -> bool {
        self.tool_policy.is_some()
    }

    pub async fn sync_available_tools(&mut self, mut available: Vec<String>, mcp_keys: &[String]) {
        available.extend(mcp_keys.iter().cloned());
        available.sort();
        available.dedup();

        if let Some(ref mut policy) = self.tool_policy
            && let Err(err) = policy.update_available_tools(available).await
        {
            tracing::warn!(%err, "Failed to update tool policies");
        }
    }

    pub fn apply_policy_constraints(&self, name: &str, args: &Value) -> Result<Value> {
        let mut args = args.clone();
        let canonical = canonical_tool_name(name);
        let normalized = canonical;
        let file_operation_read = normalized == tools::UNIFIED_FILE && file_operation_action_is(&args, "read");

        if let Some(constraints) = self.tool_policy.as_ref().and_then(|tp| tp.get_constraints(normalized)).cloned() {
            let obj = args
                .as_object_mut()
                .ok_or_else(|| anyhow!("Error: tool arguments must be an object"))?;

            if let Some(fmt) = constraints.default_response_format {
                obj.entry("response_format").or_insert(json!(fmt));
            }

            if let Some(allowed) = constraints.allowed_modes
                && let Some(mode) = obj.get("mode").and_then(|v| v.as_str())
                && !allowed.iter().any(|m| m == mode)
            {
                return Err(anyhow!(
                    "Mode '{}' not allowed by policy for '{}'. Allowed: {}",
                    mode,
                    normalized,
                    allowed.join(", ")
                ));
            }

            match normalized {
                n if n == tools::CODE_SEARCH => {
                    let valid_cap = constraints.max_results_per_call.filter(|cap| (1..=100).contains(cap));
                    match (obj.get("max_results"), valid_cap) {
                        (None, cap) => {
                            obj.insert("max_results".to_string(), json!(cap.map_or(20, |cap| 20.min(cap))));
                        }
                        (Some(value), Some(cap)) if value.as_u64().is_some_and(|value| value > cap as u64) => {
                            obj.insert("max_results".to_string(), json!(cap));
                        }
                        (Some(_), _) => {}
                    }
                }
                n if n == tools::READ_FILE || file_operation_read => {
                    if let Some(cap) = constraints.max_bytes_per_read {
                        let requested = obj.get("max_bytes").and_then(|v| v.as_u64()).unwrap_or(cap as u64) as usize;
                        if requested > cap {
                            obj.insert("max_bytes".to_string(), json!(cap));
                            obj.insert(
                                "_policy_note".to_string(),
                                json!(format!("Capped max_bytes to {} by policy", cap)),
                            );
                        }
                    }
                }

                _ => {}
            }
        }

        Ok(args)
    }

    pub fn policy_manager(&self) -> Option<ToolPolicyManager> {
        self.tool_policy.clone()
    }

    pub fn policy_manager_mut(&mut self) -> Result<&mut ToolPolicyManager> {
        self.tool_policy
            .as_mut()
            .ok_or_else(|| anyhow!("Tool policy manager not available"))
    }

    pub fn set_policy_manager(&mut self, manager: ToolPolicyManager) {
        self.tool_policy = Some(manager);
    }

    pub async fn set_tool_policy(&mut self, tool_name: &str, policy: ToolPolicy) -> Result<()> {
        let canonical = canonical_tool_name(tool_name);
        if let Some(ref mut manager) = self.tool_policy {
            manager.set_policy(canonical, policy).await
        } else {
            Err(anyhow::anyhow!("Tool policy manager not initialized"))
        }
    }

    pub async fn add_approval_cache_key(&mut self, approval_key: &str) -> Result<()> {
        if let Some(ref mut manager) = self.tool_policy {
            manager.add_approval_cache_key_with_segments(approval_key).await
        } else {
            Err(anyhow::anyhow!("Tool policy manager not initialized"))
        }
    }

    pub async fn add_approval_cache_prefix(&mut self, prefix_entry: &str) -> Result<()> {
        if let Some(ref mut manager) = self.tool_policy {
            manager.add_approval_cache_prefix(prefix_entry).await
        } else {
            Err(anyhow::anyhow!("Tool policy manager not initialized"))
        }
    }

    pub fn has_approval_cache_key(&self, approval_key: &str) -> bool {
        self.tool_policy
            .as_ref()
            .is_some_and(|manager| manager.has_approval_cache_key(approval_key))
    }

    pub fn matching_shell_approval_prefix(&self, command_words: &[String], scope_signature: &str) -> Option<String> {
        self.tool_policy
            .as_ref()
            .and_then(|manager| manager.matching_shell_approval_prefix(command_words, scope_signature))
    }

    pub fn get_tool_policy(&self, tool_name: &str) -> ToolPolicy {
        let canonical = canonical_tool_name(tool_name);
        self.tool_policy
            .as_ref()
            .map(|tp| tp.get_policy(canonical))
            .unwrap_or(ToolPolicy::Allow)
    }

    pub fn print_policy_status(&self) {
        if let Some(tp) = self.tool_policy.as_ref() {
            tp.print_status();
        } else {
            tracing::warn!("Tool policy manager not available");
        }
    }

    pub fn enable_full_auto_permission(
        &mut self,
        allowed_tools: &[String],
        available_tools: &[String],
        session_tools_config: SessionToolsConfig,
    ) {
        let mut normalized: FxHashSet<String> = FxHashSet::default();
        let wildcard = allowed_tools.iter().any(|tool| tool.trim() == tools::WILDCARD_ALL);
        if wildcard {
            for tool in available_tools {
                let canonical = canonical_tool_name(tool);
                normalized.insert(canonical.to_owned());
            }
        } else {
            for tool in allowed_tools {
                let trimmed = tool.trim();
                if !trimmed.is_empty() {
                    let canonical = canonical_tool_name(trimmed);
                    normalized.insert(canonical.to_owned());
                }
            }
        }

        self.full_auto_allowlist = Some(normalized);
        self.full_auto_catalogue_config = wildcard.then_some(session_tools_config);
    }

    pub fn disable_full_auto_permission(&mut self) {
        self.full_auto_allowlist = None;
        self.full_auto_catalogue_config = None;
    }

    pub fn full_auto_catalogue_config(&self) -> Option<SessionToolsConfig> {
        self.full_auto_catalogue_config.clone()
    }

    pub fn full_auto_catalogue_lifecycle(&self) -> Arc<tokio::sync::Mutex<()>> {
        Arc::clone(&self.full_auto_catalogue_lifecycle)
    }

    #[cfg(test)]
    pub(super) fn full_auto_catalogue_test_hooks(&self) -> Arc<PolicyCatalogueTestHooks> {
        Arc::clone(&self.full_auto_catalogue_test_hooks)
    }

    pub fn refresh_full_auto_catalogue(
        &mut self,
        session_tools_config: &SessionToolsConfig,
        available_tools: &[String],
    ) {
        if self.full_auto_catalogue_config.as_ref() != Some(session_tools_config) {
            return;
        }

        self.full_auto_allowlist = Some(
            available_tools
                .iter()
                .map(|tool| canonical_tool_name(tool).to_owned())
                .collect(),
        );
    }

    pub fn current_full_auto_allowlist(&self) -> Option<Vec<String>> {
        self.full_auto_allowlist.as_ref().map(|set| {
            let mut items: Vec<String> = set.iter().cloned().collect();
            items.sort();
            items
        })
    }

    pub fn is_allowed_in_full_auto(&self, name: &str) -> bool {
        let canonical = canonical_tool_name(name);
        self.full_auto_allowlist
            .as_ref()
            .map(|allowlist| allowlist.contains(canonical))
            .unwrap_or(true)
    }

    pub fn has_full_auto_allowlist(&self) -> bool {
        self.full_auto_allowlist.is_some()
    }

    pub async fn evaluate_tool_policy(
        &mut self,
        name: &str,
        safe_mode_prompt: bool,
        default_permission: ToolPolicy,
    ) -> Result<ToolPermissionDecision> {
        let canonical = canonical_tool_name(name);
        let normalized = canonical;

        // In safe mode (tools_policy), high-risk tools always require a prompt
        // regardless of persisted policy
        if self.requires_safe_mode_prompt(safe_mode_prompt) {
            tracing::debug!("Tool '{}' requires prompt in safe mode (tools_policy)", normalized);
            return Ok(ToolPermissionDecision::Prompt);
        }

        if self.full_auto_allowlist.is_some() {
            if !self.is_allowed_in_full_auto(normalized) {
                return Ok(ToolPermissionDecision::Deny);
            }

            if let Some(policy_manager) = self.tool_policy.as_mut() {
                match policy_manager.get_policy(normalized) {
                    ToolPolicy::Deny => return Ok(ToolPermissionDecision::Deny),
                    ToolPolicy::Allow => {
                        self.preapproved_tools.insert(normalized.to_string());
                        return Ok(ToolPermissionDecision::Allow);
                    }
                    ToolPolicy::Prompt => {
                        // Always prompt for explicit "prompt" policy, even in full-auto permission review
                        // This ensures human-in-the-loop approval for sensitive operations
                        return Ok(ToolPermissionDecision::Prompt);
                    }
                }
            }

            self.preapproved_tools.insert(normalized.to_string());
            return Ok(ToolPermissionDecision::Allow);
        }

        if let Some(policy_manager) = self.tool_policy.as_mut() {
            match policy_manager.get_policy(normalized) {
                ToolPolicy::Allow => {
                    self.preapproved_tools.insert(normalized.to_string());
                    Ok(ToolPermissionDecision::Allow)
                }
                ToolPolicy::Deny => Ok(ToolPermissionDecision::Deny),
                ToolPolicy::Prompt => {
                    // Check if low-risk by using risk scorer
                    if Self::should_auto_approve_by_risk(normalized)
                        || ToolPolicyManager::is_auto_allow_tool(normalized)
                    {
                        policy_manager.set_policy(normalized, ToolPolicy::Allow).await?;
                        self.preapproved_tools.insert(normalized.to_string());
                        Ok(ToolPermissionDecision::Allow)
                    } else {
                        Ok(ToolPermissionDecision::Prompt)
                    }
                }
            }
        } else {
            Ok(match default_permission {
                ToolPolicy::Allow => {
                    self.preapproved_tools.insert(normalized.to_string());
                    ToolPermissionDecision::Allow
                }
                ToolPolicy::Deny => ToolPermissionDecision::Deny,
                ToolPolicy::Prompt => ToolPermissionDecision::Prompt,
            })
        }
    }

    /// Determine if a tool should be auto-approved based on risk level
    /// Low-risk read-only tools are auto-approved to reduce approval friction
    fn should_auto_approve_by_risk(tool_name: &str) -> bool {
        let mut ctx = ToolRiskContext::new(tool_name.to_string(), ToolSource::Internal, WorkspaceTrust::Trusted);
        // Reflect outbound network access in the score so network tools are not
        // silently auto-approved. Without this, the trusted-workspace risk
        // reduction can drop a network tool below the low-risk threshold and
        // bypass human-in-the-loop approval.
        if ToolRiskScorer::is_network_tool(tool_name) {
            ctx = ctx.accesses_network();
        }
        let risk = ToolRiskScorer::calculate_risk(&ctx);
        // Auto-approve only low-risk tools
        matches!(risk, RiskLevel::Low)
    }

    pub fn take_preapproved(&mut self, name: &str) -> bool {
        let canonical = canonical_tool_name(name);
        let was_preapproved = self.preapproved_tools.remove(canonical);
        tracing::trace!(
            "take_preapproved: tool='{}', canonical='{}', was_preapproved={}, remaining={:?}",
            name,
            canonical,
            was_preapproved,
            self.preapproved_tools
        );
        was_preapproved
    }

    pub fn preapprove(&mut self, name: &str) {
        let canonical = canonical_tool_name(name);
        let canonical_owned = canonical.to_owned();
        self.preapproved_tools.insert(canonical_owned.clone());
        tracing::trace!(
            "preapprove: tool='{}', canonical='{}', preapproved_tools={:?}",
            name,
            canonical_owned,
            self.preapproved_tools
        );
    }

    pub async fn should_execute_tool(&mut self, name: &str) -> Result<ToolExecutionDecision> {
        let canonical = canonical_tool_name(name);
        if let Some(policy_manager) = self.tool_policy.as_mut() {
            policy_manager.should_execute_tool(canonical).await
        } else {
            Ok(ToolExecutionDecision::Allowed)
        }
    }

    pub async fn update_mcp_tools(
        &mut self,
        mcp_tool_index: &hashbrown::HashMap<String, Vec<String>>,
    ) -> Result<Option<McpAllowListConfig>> {
        if let Some(policy_manager) = self.tool_policy.as_mut() {
            policy_manager.update_mcp_tools(mcp_tool_index).await?;
            return Ok(Some(policy_manager.mcp_allowlist().clone()));
        }
        Ok(None)
    }

    pub async fn persist_mcp_tool_policy(&mut self, provider: &str, tool_name: &str, policy: ToolPolicy) -> Result<()> {
        if let Some(manager) = self.tool_policy.as_mut() {
            manager.set_mcp_tool_policy(provider, tool_name, policy).await?;
        }
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::tool_policy::{ToolConstraints, ToolPolicyConfig};
    use indexmap::IndexMap;
    use serde_json::json;

    async fn gateway_with_constraints(tool_name: &str, constraints: ToolConstraints) -> ToolPolicyGateway {
        let temp = tempfile::tempdir().expect("temp workspace");
        let config_path = temp.path().join("tool-policy.json");
        let config = ToolPolicyConfig {
            constraints: IndexMap::from([(tool_name.to_string(), constraints)]),
            ..ToolPolicyConfig::default()
        };
        std::fs::write(&config_path, serde_json::to_vec_pretty(&config).expect("policy config json"))
            .expect("policy config file");
        let manager = ToolPolicyManager::new_with_config_path(config_path)
            .await
            .expect("policy manager");
        ToolPolicyGateway::with_policy_manager(manager)
    }

    #[test]
    fn network_tools_are_not_auto_approved_by_risk() {
        // Web fetches must require HITL approval and never be auto-promoted to
        // Allow by the low-risk auto-approval heuristic.
        assert!(!ToolPolicyGateway::should_auto_approve_by_risk(tools::WEB_FETCH));
        // The read-only code search tool stays auto-approved for low friction.
        assert!(ToolPolicyGateway::should_auto_approve_by_risk(tools::CODE_SEARCH));
    }

    #[test]
    fn mcp_connect_and_disconnect_are_not_auto_approved_by_risk() {
        // `mcp` itself is a low-risk discovery tool (Allow by default), but its
        // connect/disconnect actions open/tear down a network connection and
        // must stay HITL-gated via the action-qualified policy keys, never
        // auto-promoted to Allow by the low-risk auto-approval heuristic.
        assert!(!ToolPolicyGateway::should_auto_approve_by_risk("mcp:connect"));
        assert!(!ToolPolicyGateway::should_auto_approve_by_risk("mcp:disconnect"));
        // The bare mcp tool (discovery actions) stays auto-approved for low
        // friction.
        assert!(ToolPolicyGateway::should_auto_approve_by_risk(tools::MCP));
    }

    #[tokio::test]
    async fn apply_policy_constraints_caps_code_search_results() {
        let gateway = gateway_with_constraints(
            tools::CODE_SEARCH,
            ToolConstraints {
                max_results_per_call: Some(15),
                ..ToolConstraints::default()
            },
        )
        .await;

        let constrained = gateway
            .apply_policy_constraints(
                tools::CODE_SEARCH,
                &json!({
                    "query": "ToolRegistry",
                    "path": ".",
                    "max_results": 50
                }),
            )
            .expect("constrained args");

        assert_eq!(constrained["max_results"], json!(15));
        assert!(constrained.get("_policy_note").is_none());
    }

    #[tokio::test]
    async fn omitted_code_search_limit_uses_public_default_bounded_by_valid_policy_cap() {
        for (configured_cap, expected_limit) in [(15, 15), (50, 20), (0, 20), (101, 20)] {
            let gateway = gateway_with_constraints(
                tools::CODE_SEARCH,
                ToolConstraints {
                    max_results_per_call: Some(configured_cap),
                    ..ToolConstraints::default()
                },
            )
            .await;

            let constrained = gateway
                .apply_policy_constraints(tools::CODE_SEARCH, &json!({"query": "ToolRegistry", "path": "."}))
                .expect("valid omitted max_results must remain valid under policy");

            assert_eq!(constrained["max_results"], json!(expected_limit), "configured cap {configured_cap}");
        }
    }

    #[tokio::test]
    async fn explicit_code_search_limit_retains_valid_cap_clamping() {
        let gateway = gateway_with_constraints(
            tools::CODE_SEARCH,
            ToolConstraints {
                max_results_per_call: Some(50),
                ..ToolConstraints::default()
            },
        )
        .await;
        let constrained = gateway
            .apply_policy_constraints(tools::CODE_SEARCH, &json!({"query": "ToolRegistry", "max_results": 80}))
            .expect("constrained args");
        assert_eq!(constrained["max_results"], json!(50));
    }
}