vtcode-acp 0.173.2

ACP bridge and client implementation for VT Code
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
use super::ZedAgent;
use crate::acp;
use std::path::Path;
use std::str::FromStr;
use std::sync::atomic::Ordering;
use std::sync::{Arc, Mutex};
use tracing::warn;
use vtcode_config::auth::AuthCredentialsStoreMode;
use vtcode_core::config::models::{ModelId, Provider};
use vtcode_core::config::types::ReasoningEffortLevel;
use vtcode_core::core::threads::{ThreadBootstrap, build_thread_archive_metadata};
use vtcode_core::llm::ModelResolver;
use vtcode_core::llm::factory::get_factory;
use vtcode_core::llm::provider::{FinishReason, Message};
use vtcode_core::utils::session_archive::find_session_by_identifier;

use super::super::constants::SESSION_PREFIX;
use super::super::helpers::session_config_options;
use super::super::types::{SessionData, SessionHandle};

impl ZedAgent {
    fn session_reasoning_effort_for_thread(
        &self,
        thread: &vtcode_core::core::threads::ThreadRuntimeHandle,
    ) -> ReasoningEffortLevel {
        thread
            .metadata()
            .and_then(|metadata| ReasoningEffortLevel::parse(&metadata.reasoning_effort))
            .unwrap_or(self.config.reasoning_effort)
    }

    fn sync_thread_reasoning_effort(
        &self,
        thread: &vtcode_core::core::threads::ThreadRuntimeHandle,
        reasoning_effort: ReasoningEffortLevel,
    ) {
        if let Some(mut metadata) = thread.metadata() {
            metadata.reasoning_effort = reasoning_effort.as_str().to_string();
            thread.replace_metadata(Some(metadata));
        }
    }

    fn session_provider_for_thread(&self, thread: &vtcode_core::core::threads::ThreadRuntimeHandle) -> String {
        thread
            .metadata()
            .map(|metadata| metadata.provider)
            .unwrap_or_else(|| self.config.provider.clone())
    }

    fn session_model_for_thread(&self, thread: &vtcode_core::core::threads::ThreadRuntimeHandle) -> String {
        thread
            .metadata()
            .map(|metadata| metadata.model)
            .unwrap_or_else(|| self.config.model.clone())
    }

    fn session_primary_agent_for_thread(&self, thread: &vtcode_core::core::threads::ThreadRuntimeHandle) -> String {
        thread
            .metadata()
            .and_then(|metadata| metadata.primary_agent)
            .and_then(|primary_agent| self.primary_agents.resolve_id(&primary_agent))
            .map(ToString::to_string)
            .unwrap_or_else(|| self.primary_agents.default_id().to_string())
    }

    fn sync_thread_primary_agent(&self, thread: &vtcode_core::core::threads::ThreadRuntimeHandle, primary_agent: &str) {
        if let Some(mut metadata) = thread.metadata() {
            metadata.primary_agent = Some(primary_agent.to_string());
            thread.replace_metadata(Some(metadata));
        }
    }

    fn sync_thread_provider_and_model(
        &self,
        thread: &vtcode_core::core::threads::ThreadRuntimeHandle,
        provider: &str,
        model: &str,
    ) {
        if let Some(mut metadata) = thread.metadata() {
            metadata.provider = provider.to_string();
            metadata.model = model.to_string();
            thread.replace_metadata(Some(metadata));
        }
    }

    fn model_supports_thought_level(&self, provider: &str, model: &str) -> bool {
        ModelResolver::resolve(Some(provider), model, &[], None)
            .map(|resolved| resolved.reasoning_supported())
            .unwrap_or(false)
    }

    pub(super) fn build_session_handle(
        &self,
        session_id: acp::SessionId,
        thread: vtcode_core::core::threads::ThreadRuntimeHandle,
    ) -> SessionHandle {
        let reasoning_effort = self.session_reasoning_effort_for_thread(&thread);
        let provider = self.session_provider_for_thread(&thread);
        let model = self.session_model_for_thread(&thread);
        let primary_agent = self.session_primary_agent_for_thread(&thread);
        SessionHandle {
            data: Arc::new(Mutex::new(SessionData {
                _session_id: session_id,
                thread,
                tool_notice_sent: std::sync::atomic::AtomicBool::new(false),
                primary_agent,
                reasoning_effort,
                provider,
                model,
                last_tool_call_at: None,
            })),
            cancel_flag: Arc::new(std::sync::atomic::AtomicBool::new(false)),
        }
    }

    pub(crate) fn register_session(&self) -> acp::SessionId {
        let raw_id = self.next_session_id.fetch_add(1, Ordering::Relaxed);
        let session_id = acp::SessionId::new(Arc::from(format!("{SESSION_PREFIX}-{raw_id}")));
        let metadata = build_thread_archive_metadata(
            self.config.workspace.as_path(),
            &self.config.model,
            &self.config.provider,
            &self.config.theme,
            self.config.reasoning_effort.as_str(),
        );
        let thread = self
            .thread_manager
            .start_thread_with_identifier(session_id.0.to_string(), ThreadBootstrap::new(Some(metadata)));
        let handle = self.build_session_handle(session_id.clone(), thread);
        if let Ok(mut guard) = self.sessions.lock() {
            drop(guard.insert(session_id.clone(), handle));
        }
        session_id
    }

    pub(crate) fn session_handle(&self, session_id: &acp::SessionId) -> Option<SessionHandle> {
        self.sessions.lock().unwrap_or_else(|e| e.into_inner()).get(session_id).cloned()
    }

    pub(super) fn push_message(&self, session: &SessionHandle, message: Message) {
        if let Ok(data) = session.data.lock() {
            data.thread.append_message(message);
        }
    }

    #[allow(dead_code, reason = "Intentional compatibility, platform, or test-only suppression.")]
    pub(super) fn should_send_tool_notice(&self, session: &SessionHandle) -> bool {
        session
            .data
            .lock()
            .map(|data| !data.tool_notice_sent.load(Ordering::Relaxed))
            .unwrap_or(false)
    }

    #[allow(dead_code, reason = "Intentional compatibility, platform, or test-only suppression.")]
    pub(super) fn mark_tool_notice_sent(&self, session: &SessionHandle) {
        if let Ok(data) = session.data.lock() {
            data.tool_notice_sent.store(true, Ordering::Relaxed);
        }
    }

    pub(super) fn update_session_primary_agent(&self, session: &SessionHandle, primary_agent: String) -> bool {
        let Some(primary_agent) = self.primary_agents.resolve_id(&primary_agent) else {
            return false;
        };
        let mut data = match session.data.lock() {
            Ok(guard) => guard,
            Err(_) => return false,
        };
        if data.primary_agent.eq_ignore_ascii_case(primary_agent) {
            return false;
        }
        data.primary_agent = primary_agent.to_string();
        self.sync_thread_primary_agent(&data.thread, &data.primary_agent);
        true
    }

    fn update_session_reasoning_effort(&self, session: &SessionHandle, reasoning_effort: ReasoningEffortLevel) -> bool {
        let mut data = match session.data.lock() {
            Ok(guard) => guard,
            Err(_) => return false,
        };
        if data.reasoning_effort == reasoning_effort {
            return false;
        }
        data.reasoning_effort = reasoning_effort;
        self.sync_thread_reasoning_effort(&data.thread, reasoning_effort);
        true
    }

    fn update_session_provider_and_model(&self, session: &SessionHandle, provider: String, model: String) -> bool {
        let mut data = match session.data.lock() {
            Ok(guard) => guard,
            Err(_) => return false,
        };
        if data.provider == provider && data.model == model {
            return false;
        }
        data.provider = provider;
        data.model = model;
        self.sync_thread_provider_and_model(&data.thread, &data.provider, &data.model);
        true
    }

    fn provider_default_model(&self, provider: &str) -> Option<String> {
        Provider::from_str(provider)
            .ok()
            .map(|value| ModelId::default_single_for_provider(value).as_str().to_string())
    }

    fn provider_supports_model(&self, provider: &str, model: &str) -> bool {
        let Ok(provider) = Provider::from_str(provider) else {
            return true;
        };
        ModelId::models_for_provider(provider)
            .iter()
            .any(|entry| entry.as_str() == model)
    }

    fn provider_select_options(&self, current_provider: &str) -> Vec<acp::SessionConfigSelectOption> {
        let mut providers = get_factory()
            .lock()
            .ok()
            .map(|factory| factory.list_providers())
            .unwrap_or_default();
        if providers.is_empty() {
            tracing::warn!("LLM factory has no registered providers, falling back to Provider::all_providers()");
            providers = Provider::all_providers()
                .into_iter()
                .map(|provider| provider.to_string())
                .collect();
        }

        if !providers.iter().any(|provider| provider.eq_ignore_ascii_case(current_provider)) {
            providers.push(current_provider.to_string());
        }

        providers.sort();
        providers.dedup_by(|left, right| left.eq_ignore_ascii_case(right));

        tracing::debug!(
            provider_count = providers.len(),
            providers = ?providers,
            current_provider = current_provider,
            "Building provider select options for ACP"
        );

        providers
            .into_iter()
            .map(|provider| {
                let name = Provider::from_str(&provider)
                    .ok()
                    .map(|parsed| parsed.label().to_string())
                    .unwrap_or_else(|| provider.clone());
                acp::SessionConfigSelectOption::new(provider, name)
            })
            .collect()
    }

    fn model_select_options(&self, provider: &str, current_model: &str) -> Vec<acp::SessionConfigSelectOption> {
        let mut options = Provider::from_str(provider)
            .ok()
            .map(|provider| {
                ModelId::models_for_provider(provider)
                    .into_iter()
                    .map(|model| {
                        acp::SessionConfigSelectOption::new(
                            model.as_str().into_owned(),
                            model.display_name().into_owned(),
                        )
                    })
                    .collect::<Vec<_>>()
            })
            .unwrap_or_default();

        if !options.iter().any(|option| option.value.0.as_ref() == current_model) {
            options.push(acp::SessionConfigSelectOption::new(current_model.to_string(), current_model.to_string()));
        }

        options.sort_by(|left, right| left.value.0.cmp(&right.value.0));
        options
    }

    fn supports_provider(&self, provider: &str, current_provider: &str) -> bool {
        self.provider_select_options(current_provider)
            .iter()
            .any(|option| option.value.0.as_ref() == provider)
    }

    fn current_session_config_options(&self, session: &SessionHandle) -> Vec<acp::SessionConfigOption> {
        let data = match session.data.lock() {
            Ok(guard) => guard,
            Err(_) => return Vec::new(),
        };
        let provider_options = self.provider_select_options(&data.provider);
        let model_options = self.model_select_options(&data.provider, &data.model);
        let config_options = session_config_options(
            &data.primary_agent,
            &self.primary_agents,
            data.reasoning_effort,
            self.model_supports_thought_level(&data.provider, &data.model),
            &data.provider,
            provider_options,
            &data.model,
            model_options,
        );

        tracing::debug!(
            config_option_count = config_options.len(),
            primary_agent = %data.primary_agent,
            current_provider = %data.provider,
            current_model = %data.model,
            "Built session config options for ACP"
        );

        config_options
    }

    pub(super) fn resolved_messages(&self, session: &SessionHandle) -> Vec<Message> {
        let mut messages = Vec::with_capacity(10);
        if !self.system_prompt.trim().is_empty() {
            messages.push(Message::system(self.system_prompt.clone()));
        }

        let Ok(history) = session.data.lock() else {
            return messages;
        };
        if let Some(prompt) = self.primary_agents.prompt(&history.primary_agent) {
            messages.push(Message::system(prompt.to_string()));
        }
        messages.extend(history.thread.messages());
        messages
    }

    async fn attach_thread_from_archive(
        &self,
        session_id: &acp::SessionId,
        identifier: &str,
    ) -> anyhow::Result<SessionHandle> {
        let listing = find_session_by_identifier(identifier)
            .await?
            .ok_or_else(|| anyhow::anyhow!("unknown archived session '{identifier}'"))?;
        let thread = self
            .thread_manager
            .start_thread_with_identifier(listing.identifier(), ThreadBootstrap::from_listing(listing));
        let handle = self.build_session_handle(session_id.clone(), thread);
        if let Ok(mut guard) = self.sessions.lock() {
            drop(guard.insert(session_id.clone(), handle.clone()));
        }
        Ok(handle)
    }

    pub(super) fn stop_reason_from_finish(finish: FinishReason) -> acp::StopReason {
        match finish {
            FinishReason::Stop | FinishReason::ToolCalls => acp::StopReason::EndTurn,
            FinishReason::Length => acp::StopReason::MaxTokens,
            FinishReason::ContentFilter | FinishReason::Refusal | FinishReason::Error(_) => acp::StopReason::Refusal,
            FinishReason::Pause => acp::StopReason::EndTurn,
        }
    }

    /// Programmatic equivalent of the SACP `session/new` handler — exposed
    /// for tests and for the SACP handler shim to call.
    ///
    /// Single-workspace bridge: sessions share `config.workspace`. A request
    /// `cwd` that is not absolute is rejected; a different absolute `cwd` is
    /// accepted with a warn log and the workspace is used (per-session workspaces
    /// would require per-session tool roots).
    pub(crate) async fn new_session(&self, req: acp::NewSessionRequest) -> Result<acp::NewSessionResponse, acp::Error> {
        ensure_absolute_cwd(&req.cwd)?;
        if req.cwd != self.config.workspace {
            warn!(
                requested = %req.cwd.display(),
                workspace = %self.config.workspace.display(),
                "session/new cwd differs from agent workspace; using workspace (single-workspace bridge)"
            );
        }
        if !req.additional_directories.is_empty() {
            warn!("session/new additionalDirectories ignored (single-workspace bridge)");
        }
        if !req.mcp_servers.is_empty() {
            warn!("session/new mcpServers ignored (client-managed MCP)");
        }
        let session_id = self.register_session();
        let config_options = self
            .session_handle(&session_id)
            .map(|session| self.current_session_config_options(&session))
            .unwrap_or_default();

        if let Err(error) = self.send_available_commands_update(&session_id).await {
            warn!(%error, "Failed to advertise initial slash commands");
        }

        Ok(acp::NewSessionResponse::new(session_id).config_options(config_options))
    }

    /// Programmatic equivalent of the SACP `session/load` handler.
    pub(crate) async fn load_session(
        &self,
        args: acp::LoadSessionRequest,
    ) -> Result<acp::LoadSessionResponse, acp::Error> {
        ensure_absolute_cwd(&args.cwd)?;
        let session = if let Some(session) = self.session_handle(&args.session_id) {
            session
        } else {
            let identifier = args.session_id.0.as_ref();
            self.attach_thread_from_archive(&args.session_id, identifier)
                .await
                .map_err(|err| {
                    acp::Error::invalid_params().data(serde_json::json!({
                        "reason": "unknown_session",
                        "detail": err.to_string(),
                    }))
                })?
        };

        if let Err(error) = self.send_available_commands_update(&args.session_id).await {
            warn!(%error, "Failed to advertise slash commands on session load");
        }

        let config_options = self.current_session_config_options(&session);
        Ok(acp::LoadSessionResponse::new().config_options(config_options))
    }

    /// Programmatic equivalent of the SACP `session/list` handler.
    ///
    /// Single-workspace bridge: every live session reports `config.workspace`
    /// as its `cwd` with no `title`/`updated_at`. `cursor` pagination is not
    /// implemented (full sorted list, no `next_cursor`); `cwd` filters by exact
    /// equality against the workspace.
    pub(crate) async fn list_sessions(
        &self,
        args: acp::ListSessionsRequest,
    ) -> Result<acp::ListSessionsResponse, acp::Error> {
        let cwd_filter = args.cwd.clone();
        let sessions = self.sessions.lock().unwrap_or_else(|e| e.into_inner());
        let mut infos: Vec<acp::SessionInfo> = sessions
            .keys()
            .map(|session_id| acp::SessionInfo::new(session_id.clone(), self.config.workspace.clone()))
            .collect();
        drop(sessions);
        infos.sort_by(|left, right| left.session_id.0.cmp(&right.session_id.0));
        if let Some(cwd) = cwd_filter
            && cwd != self.config.workspace
        {
            infos.clear();
        }
        Ok(acp::ListSessionsResponse::new(infos))
    }

    /// Programmatic equivalent of the SACP `session/resume` handler.
    ///
    /// Live-only reattach (v1 `resume` has no replay). Unknown sessions fail
    /// with `unknown_session`; use `session/load` to attach archived history.
    pub(crate) async fn resume_session(
        &self,
        args: acp::ResumeSessionRequest,
    ) -> Result<acp::ResumeSessionResponse, acp::Error> {
        ensure_absolute_cwd(&args.cwd)?;
        let Some(session) = self.session_handle(&args.session_id) else {
            return Err(acp::Error::invalid_params().data(serde_json::json!({
                "reason": "unknown_session",
            })));
        };

        if let Err(error) = self.send_available_commands_update(&args.session_id).await {
            warn!(%error, "Failed to advertise slash commands on session resume");
        }

        let config_options = self.current_session_config_options(&session);
        Ok(acp::ResumeSessionResponse::new().config_options(config_options))
    }

    /// Programmatic equivalent of the SACP `session/close` handler.
    ///
    /// Cancels in-flight work (like `session/cancel`) and drops the live handle.
    /// A later `resume` for the id fails; `load` may still attach archived
    /// history by identifier (disaster recovery, not a reopen).
    pub(crate) async fn close_session(
        &self,
        args: acp::CloseSessionRequest,
    ) -> Result<acp::CloseSessionResponse, acp::Error> {
        let Some(session) = self.session_handle(&args.session_id) else {
            return Err(acp::Error::invalid_params().data(serde_json::json!({
                "reason": "unknown_session",
            })));
        };
        session.cancel_flag.store(true, Ordering::Relaxed);
        drop(self.sessions.lock().unwrap_or_else(|e| e.into_inner()).remove(&args.session_id));
        Ok(acp::CloseSessionResponse::new())
    }

    /// Programmatic equivalent of the SACP `session/delete` handler.
    ///
    /// Matches `close`: cancel work and drop the live handle. Unknown ids fail
    /// with `unknown_session` (consistent with `close`/`resume`). Archive files
    /// are retained, so `load` by archived identifier can still attach history.
    pub(crate) async fn delete_session(
        &self,
        args: acp::DeleteSessionRequest,
    ) -> Result<acp::DeleteSessionResponse, acp::Error> {
        let Some(session) = self.session_handle(&args.session_id) else {
            return Err(acp::Error::invalid_params().data(serde_json::json!({
                "reason": "unknown_session",
            })));
        };
        session.cancel_flag.store(true, Ordering::Relaxed);
        drop(self.sessions.lock().unwrap_or_else(|e| e.into_inner()).remove(&args.session_id));
        Ok(acp::DeleteSessionResponse::new())
    }

    /// Programmatic equivalent of the SACP `session/set_config_option`
    /// handler. Used both by the SACP handler and by the test suite.
    pub(crate) async fn set_session_config_option(
        &self,
        args: acp::SetSessionConfigOptionRequest,
    ) -> Result<acp::SetSessionConfigOptionResponse, acp::Error> {
        use crate::zed::helpers::SESSION_CONFIG_MODEL_ID;
        use crate::zed::helpers::SESSION_CONFIG_PRIMARY_AGENT_ID;
        use crate::zed::helpers::SESSION_CONFIG_PROVIDER_ID;
        use crate::zed::helpers::SESSION_CONFIG_THOUGHT_LEVEL_ID;

        let Some(session) = self.session_handle(&args.session_id) else {
            return Err(acp::Error::invalid_params().data(serde_json::json!({
                "reason": "unknown_session"
            })));
        };

        let config_id = args.config_id.0.to_string();
        let value = match &args.value {
            acp::SessionConfigOptionValue::ValueId { value } => value.0.as_ref().to_string(),
            _ => {
                return Err(acp::Error::invalid_params().data(serde_json::json!({
                    "reason": "expected_string_config_option_value",
                    "config_id": config_id,
                })));
            }
        };
        let updated = match config_id.as_str() {
            SESSION_CONFIG_PRIMARY_AGENT_ID => {
                let Some(primary_agent) = self.primary_agents.resolve_id(&value) else {
                    return Err(acp::Error::invalid_params().data(serde_json::json!({
                        "reason": "unknown_primary_agent",
                        "value": value,
                    })));
                };
                self.update_session_primary_agent(&session, primary_agent.to_string())
            }
            SESSION_CONFIG_THOUGHT_LEVEL_ID => {
                let (session_provider, session_model) = {
                    let data = session.data.lock().map_err(|_err| acp::Error::internal_error())?;
                    (data.provider.clone(), data.model.clone())
                };
                if !self.model_supports_thought_level(&session_provider, &session_model) {
                    return Err(acp::Error::invalid_params().data(serde_json::json!({
                        "reason": "unsupported_config_option",
                        "config_id": config_id,
                    })));
                }
                let Some(reasoning_effort) = ReasoningEffortLevel::parse(&value) else {
                    return Err(acp::Error::invalid_params().data(serde_json::json!({
                        "reason": "unknown_thought_level",
                        "value": value,
                    })));
                };
                self.update_session_reasoning_effort(&session, reasoning_effort)
            }
            SESSION_CONFIG_PROVIDER_ID => {
                let provider = value.trim().to_lowercase();
                let current_provider = {
                    let data = session.data.lock().map_err(|_err| acp::Error::internal_error())?;
                    data.provider.clone()
                };
                if provider.is_empty() || !self.supports_provider(&provider, &current_provider) {
                    return Err(acp::Error::invalid_params().data(serde_json::json!({
                        "reason": "unknown_provider",
                        "value": value,
                    })));
                }
                let current_model = {
                    let data = session.data.lock().map_err(|_err| acp::Error::internal_error())?;
                    data.model.clone()
                };
                let resolved_model = if self.provider_supports_model(&provider, &current_model) {
                    current_model
                } else {
                    self.provider_default_model(&provider).ok_or_else(|| {
                        acp::Error::invalid_params().data(serde_json::json!({
                            "reason": "provider_has_no_default_model",
                            "provider": provider,
                        }))
                    })?
                };
                self.update_session_provider_and_model(&session, provider, resolved_model)
            }
            SESSION_CONFIG_MODEL_ID => {
                let model = value.trim();
                if model.is_empty() {
                    return Err(acp::Error::invalid_params().data(serde_json::json!({
                        "reason": "unknown_model",
                        "value": value,
                    })));
                }
                let provider = {
                    let data = session.data.lock().map_err(|_err| acp::Error::internal_error())?;
                    data.provider.clone()
                };
                if !self.provider_supports_model(&provider, model) {
                    return Err(acp::Error::invalid_params().data(serde_json::json!({
                        "reason": "model_not_supported_for_provider",
                        "provider": provider,
                        "model": model,
                    })));
                }
                self.update_session_provider_and_model(&session, provider, model.to_string())
            }
            _ => {
                return Err(acp::Error::invalid_params().data(serde_json::json!({
                    "reason": "unknown_config_option",
                    "config_id": config_id,
                })));
            }
        };

        if updated {
            let config_options = self.current_session_config_options(&session);
            let update = acp::ConfigOptionUpdate::new(config_options);
            drop(
                self.send_update(&args.session_id, acp::SessionUpdate::ConfigOptionUpdate(update))
                    .await,
            );
        }

        let config_options = self.current_session_config_options(&session);
        Ok(acp::SetSessionConfigOptionResponse::new(config_options))
    }
}

fn ensure_absolute_cwd(cwd: &Path) -> Result<(), acp::Error> {
    if cwd.is_absolute() {
        return Ok(());
    }
    Err(acp::Error::invalid_params().data(serde_json::json!({
        "reason": "invalid_cwd",
    })))
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::zed::helpers::PrimaryAgentCatalog;
    use assert_fs::TempDir;
    use chrono::Utc;
    use std::collections::BTreeMap;
    use std::fs;
    use std::path::Path;
    use vtcode_config::{SubagentDiscoveryInput, discover_subagents};
    use vtcode_core::core::agent::snapshots::{
        DEFAULT_CHECKPOINTS_ENABLED, DEFAULT_MAX_AGE_DAYS, DEFAULT_MAX_SNAPSHOTS,
    };
    use vtcode_core::utils::session_archive::{SessionArchiveMetadata, SessionListing, SessionSnapshot};

    use super::super::test_support::{build_agent, build_agent_with_default_primary_agent};

    fn primary_agent(session: &SessionHandle) -> String {
        session.data.lock().map(|data| data.primary_agent.clone()).unwrap_or_default()
    }

    fn reasoning_effort(session: &SessionHandle) -> ReasoningEffortLevel {
        session
            .data
            .lock()
            .map(|data| data.reasoning_effort)
            .unwrap_or(ReasoningEffortLevel::Low)
    }

    fn provider(session: &SessionHandle) -> String {
        session.data.lock().map(|data| data.provider.clone()).unwrap_or_default()
    }

    fn model(session: &SessionHandle) -> String {
        session.data.lock().map(|data| data.model.clone()).unwrap_or_default()
    }

    #[tokio::test]
    async fn build_session_handle_restores_session_config_from_thread_metadata() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let listing = SessionListing {
            path: temp.path().join("session-vtcode-acp-archive.json"),
            snapshot: SessionSnapshot {
                metadata: SessionArchiveMetadata::new(
                    "vtcode",
                    temp.path().to_string_lossy(),
                    "gpt-5.6-sol",
                    "openai",
                    "test",
                    "xhigh",
                )
                .with_primary_agent("build"),
                started_at: Utc::now(),
                ended_at: Utc::now(),
                total_messages: 0,
                distinct_tools: Vec::new(),
                transcript: Vec::new(),
                messages: Vec::new(),
                progress: None,
                error_logs: Vec::new(),
            },
        };
        let thread = agent
            .thread_manager
            .start_thread_with_identifier("session-vtcode-acp-archive", ThreadBootstrap::from_listing(listing));

        let handle = agent.build_session_handle(acp::SessionId::new("session-1"), thread);

        assert_eq!(primary_agent(&handle), "build");
        assert_eq!(reasoning_effort(&handle), ReasoningEffortLevel::XHigh);
        assert_eq!(provider(&handle), "openai");
        assert_eq!(model(&handle), "gpt-5.6-sol");
    }

    #[tokio::test]
    async fn build_session_handle_falls_back_for_unknown_metadata_primary_agent() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let listing = SessionListing {
            path: temp.path().join("session-vtcode-acp-archive.json"),
            snapshot: SessionSnapshot {
                metadata: SessionArchiveMetadata::new(
                    "vtcode",
                    temp.path().to_string_lossy(),
                    "gpt-5.6-sol",
                    "openai",
                    "test",
                    "low",
                )
                .with_primary_agent("missing"),
                started_at: Utc::now(),
                ended_at: Utc::now(),
                total_messages: 0,
                distinct_tools: Vec::new(),
                transcript: Vec::new(),
                messages: Vec::new(),
                progress: None,
                error_logs: Vec::new(),
            },
        };
        let thread = agent
            .thread_manager
            .start_thread_with_identifier("session-vtcode-acp-archive", ThreadBootstrap::from_listing(listing));

        let handle = agent.build_session_handle(acp::SessionId::new("session-1"), thread);

        assert_eq!(primary_agent(&handle), "build");
    }

    #[tokio::test]
    async fn register_session_falls_back_for_unknown_default_primary_agent() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent_with_default_primary_agent(temp.path(), "research").await;
        let session_id = agent.register_session();
        let session = agent.session_handle(&session_id).unwrap();

        // "research" is not in the discovered specs, so the resolver falls
        // back to the built-in "build" agent.
        assert_eq!(primary_agent(&session), "build");
    }

    #[tokio::test]
    async fn register_session_uses_known_default_primary_agent_ids() {
        for primary_agent in ["duck", "plan", "build", "auto"] {
            let temp = TempDir::new().unwrap();
            let agent = build_agent_with_default_primary_agent(temp.path(), primary_agent).await;
            let session_id = agent.register_session();
            let session = agent.session_handle(&session_id).unwrap();

            assert_eq!(self::primary_agent(&session), primary_agent);
        }
    }

    #[tokio::test]
    async fn register_session_uses_custom_default_primary_agent() {
        let temp = TempDir::new().unwrap();
        fs::create_dir_all(temp.path().join(".vtcode/agents")).unwrap();
        fs::write(
            temp.path().join(".vtcode/agents/research.md"),
            r#"---
name: research
description: Research primary
mode: primary
permissions:
  default: deny
---
Research primary prompt."#,
        )
        .unwrap();

        let agent = build_agent_with_default_primary_agent(temp.path(), "research").await;
        let session_id = agent.register_session();
        let session = agent.session_handle(&session_id).unwrap();

        assert_eq!(primary_agent(&session), "research");
    }

    #[tokio::test]
    async fn update_session_primary_agent_updates_session_data() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let session_id = agent.register_session();
        let session = agent.session_handle(&session_id).unwrap();

        // `build_agent` already defaults to "build", so switch to a different
        // known agent to exercise a real transition (an unchanged id is a no-op).
        assert!(agent.update_session_primary_agent(&session, "plan".to_string()));
        assert_eq!(primary_agent(&session), "plan");
        assert_eq!(
            session
                .data
                .lock()
                .ok()
                .and_then(|data| data.thread.metadata())
                .and_then(|metadata| metadata.primary_agent)
                .as_deref(),
            Some("plan")
        );

        // Re-applying the same id is a no-op.
        assert!(!agent.update_session_primary_agent(&session, "plan".to_string()));
    }

    #[tokio::test]
    async fn update_session_reasoning_effort_syncs_thread_metadata() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let session_id = agent.register_session();
        let session = agent.session_handle(&session_id).unwrap();

        assert!(agent.update_session_reasoning_effort(&session, ReasoningEffortLevel::High));
        assert_eq!(
            session
                .data
                .lock()
                .ok()
                .and_then(|data| data.thread.metadata())
                .map(|metadata| metadata.reasoning_effort)
                .as_deref(),
            Some("high")
        );
    }

    #[tokio::test]
    async fn current_session_config_options_omit_thought_level_when_model_lacks_support() {
        let temp = TempDir::new().unwrap();
        let mut agent = build_agent(temp.path()).await;
        agent.config.model = "claude-haiku-3".to_string();
        agent.config.provider = "anthropic".to_string();
        let session_id = agent.register_session();
        let session = agent.session_handle(&session_id).unwrap();

        let config_options = agent.current_session_config_options(&session);

        assert_eq!(config_options.len(), 3);
        assert_eq!(config_options[0].id, acp::SessionConfigId::new("primary_agent"));
    }

    #[tokio::test]
    async fn list_sessions_returns_registered_sessions_and_filters_cwd() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let first = agent.register_session();
        let second = agent.register_session();

        let all = agent.list_sessions(acp::ListSessionsRequest::new()).await.unwrap();
        assert_eq!(all.sessions.len(), 2);
        assert!(all.sessions.iter().any(|info| info.session_id == first));
        assert!(all.sessions.iter().any(|info| info.session_id == second));
        assert!(
            all.sessions.iter().all(|info| info.cwd == temp.path().to_path_buf()),
            "single-workspace bridge reports workspace cwd"
        );

        let matching = agent
            .list_sessions(acp::ListSessionsRequest::new().cwd(temp.path().to_path_buf()))
            .await
            .unwrap();
        assert_eq!(matching.sessions.len(), 2);

        let other_cwd = temp.path().join("other-workspace");
        assert_ne!(other_cwd, temp.path().to_path_buf());
        let other = agent
            .list_sessions(acp::ListSessionsRequest::new().cwd(other_cwd))
            .await
            .unwrap();
        assert!(other.sessions.is_empty());
    }

    #[tokio::test]
    async fn resume_existing_session_returns_config_options() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let session_id = agent.register_session();

        let response = agent
            .resume_session(acp::ResumeSessionRequest::new(session_id.clone(), temp.path()))
            .await
            .unwrap();
        assert!(!response.config_options.unwrap_or_default().is_empty());
        assert!(agent.session_handle(&session_id).is_some());
    }

    #[tokio::test]
    async fn resume_unknown_session_fails_closed() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;

        let result = agent
            .resume_session(acp::ResumeSessionRequest::new(
                acp::SessionId::new("vtcode-zed-session-missing"),
                temp.path(),
            ))
            .await;
        let error = format!("{:?}", result.expect_err("unknown session must fail"));
        assert!(error.contains("unknown_session"));
    }

    #[tokio::test]
    async fn close_session_removes_handle_and_second_close_fails() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let session_id = agent.register_session();

        drop(
            agent
                .close_session(acp::CloseSessionRequest::new(session_id.clone()))
                .await
                .unwrap(),
        );
        assert!(agent.session_handle(&session_id).is_none());

        let listed = agent.list_sessions(acp::ListSessionsRequest::new()).await.unwrap();
        assert!(!listed.sessions.iter().any(|info| info.session_id == session_id));

        let again = agent.close_session(acp::CloseSessionRequest::new(session_id)).await;
        let error = format!("{:?}", again.expect_err("second close must fail"));
        assert!(error.contains("unknown_session"));
    }

    #[tokio::test]
    async fn delete_session_clears_live_handle_but_list_stays_consistent() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let keep = agent.register_session();
        let remove = agent.register_session();

        drop(
            agent
                .delete_session(acp::DeleteSessionRequest::new(remove.clone()))
                .await
                .unwrap(),
        );
        assert!(agent.session_handle(&remove).is_none());
        assert!(agent.session_handle(&keep).is_some());

        let listed = agent.list_sessions(acp::ListSessionsRequest::new()).await.unwrap();
        assert!(listed.sessions.iter().any(|info| info.session_id == keep));
        assert!(!listed.sessions.iter().any(|info| info.session_id == remove));
    }

    #[tokio::test]
    async fn new_session_rejects_relative_cwd() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;

        let result = agent.new_session(acp::NewSessionRequest::new("relative/path")).await;
        let error = format!("{:?}", result.expect_err("relative cwd must fail"));
        assert!(error.contains("invalid_cwd"));
    }

    #[tokio::test]
    async fn resume_rejects_relative_cwd() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let session_id = agent.register_session();

        let result = agent
            .resume_session(acp::ResumeSessionRequest::new(session_id, "relative/path"))
            .await;
        let error = format!("{:?}", result.expect_err("relative cwd must fail"));
        assert!(error.contains("invalid_cwd"));
    }

    #[tokio::test]
    async fn resume_after_close_fails_closed() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let session_id = agent.register_session();

        drop(
            agent
                .close_session(acp::CloseSessionRequest::new(session_id.clone()))
                .await
                .unwrap(),
        );
        let result = agent
            .resume_session(acp::ResumeSessionRequest::new(session_id, temp.path()))
            .await;
        let error = format!("{:?}", result.expect_err("resume after close must fail"));
        assert!(error.contains("unknown_session"));
    }

    #[tokio::test]
    async fn delete_unknown_session_fails_closed() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;

        let result = agent
            .delete_session(acp::DeleteSessionRequest::new(acp::SessionId::new("vtcode-zed-session-missing")))
            .await;
        let error = format!("{:?}", result.expect_err("unknown delete must fail"));
        assert!(error.contains("unknown_session"));
    }

    #[tokio::test]
    async fn delete_after_delete_fails_closed() {
        let temp = TempDir::new().unwrap();
        let agent = build_agent(temp.path()).await;
        let session_id = agent.register_session();

        drop(
            agent
                .delete_session(acp::DeleteSessionRequest::new(session_id.clone()))
                .await
                .unwrap(),
        );
        let again = agent.delete_session(acp::DeleteSessionRequest::new(session_id)).await;
        let error = format!("{:?}", again.expect_err("second delete must fail"));
        assert!(error.contains("unknown_session"));
    }
}