vta-service 0.10.0

Service for Verifiable Trust Agents operating in Verifiable Trust Communities
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
//! Authorization + request-shape checks that run before the VTA
//! mutates any state. Failing here leaves the store untouched — a typo
//! in a template name or a missing context is surfaced with a concrete
//! operator remediation before we mint keys or write ACL rows.

use std::collections::BTreeMap;

use serde_json::Value;

use crate::auth::AuthClaims;
use crate::error::AppError;
use crate::store::KeyspaceHandle;
use vta_sdk::provision_integration::{BootstrapAsk, DidTemplateRef, VerifiedBootstrapRequest};

use super::ProvisionIntegrationDeps;

/// Returned when [`infer_target_context`] cannot pick a single target
/// context — caller has admin in multiple contexts, or is a super-admin
/// against a multi-context maintainer. Carries the plausible candidates
/// so the transport layer can surface them to the relayer and let them
/// retry with an explicit choice.
///
/// The caller renders this differently per transport: the DIDComm
/// handler emits a `provision/integration:context_required` problem
/// report with `args = candidates`; the REST handler returns a 400
/// with the message and candidates inlined.
#[derive(Debug)]
pub struct AmbiguousContext {
    pub candidates: Vec<String>,
    pub message: String,
}

/// Infer the target context the maintainer should provision into when
/// the caller omits `payload.context`. Implements the three rules
/// pinned in
/// `dtgwg-trust-tasks-tf/specs/provision/integration/0.1/spec.md`
/// §"Context inference":
///
/// 1. **Single-context grant.** If the relayer's ACL entry scopes to
///    exactly one context, use that context.
/// 2. **Single-context maintainer.** If the relayer is a super-admin
///    AND the maintainer has exactly one context registered, use it.
/// 3. **Ambiguous.** Anything else returns
///    [`Err(AmbiguousContext)`] so the caller can surface candidates
///    + retry with an explicit value.
///
/// `Result<Result<…>, …>` is intentional: the outer `Result` is the
/// usual `AppError` plumbing (store-level failures); the inner Result
/// distinguishes "inferred ok" from "ambiguous, here are the candidates"
/// without conflating the two with store errors.
pub async fn infer_target_context(
    auth: &AuthClaims,
    contexts_ks: &KeyspaceHandle,
) -> Result<Result<String, AmbiguousContext>, AppError> {
    // Rule 1: single-context grant — operator already named the bucket
    // on the wire when they granted the ephemeral. Respect it.
    if let Some(ctx) = auth.default_context() {
        return Ok(Ok(ctx.to_string()));
    }

    // Rule 2: super-admin + single-context maintainer. Covers the
    // typical wallet onboarding case where the operator ran
    // `pnm acl create --did <eph> --role admin` (no `--contexts`)
    // against a single-context VTA.
    if auth.is_super_admin() {
        let contexts = crate::contexts::list_contexts(contexts_ks).await?;
        let mut ids: Vec<String> = contexts.iter().map(|c| c.id.clone()).collect();
        ids.sort();
        match ids.len() {
            0 => {
                // No contexts at all — distinct from "ambiguous". The
                // operator needs to create a context first; surface as
                // NotFound with a remediation hint matching the rest of
                // provision-integration's error vocabulary.
                return Err(AppError::NotFound(
                    "no contexts registered on this VTA — create one with \
                     'vta contexts create --id <name>' (offline) or \
                     'pnm contexts create' (online), then retry"
                        .into(),
                ));
            }
            1 => return Ok(Ok(ids.into_iter().next().expect("len == 1"))),
            n => {
                return Ok(Err(AmbiguousContext {
                    candidates: ids,
                    message: format!(
                        "super-admin grant against {n} contexts — \
                         specify which to provision into via payload.context"
                    ),
                }));
            }
        }
    }

    // Rule 3a: multi-context relayer (not super-admin) — caller has
    // admin in N > 1 contexts but didn't say which. Return the list.
    if auth.allowed_contexts.len() > 1 {
        let mut ids = auth.allowed_contexts.clone();
        ids.sort();
        return Ok(Err(AmbiguousContext {
            message: format!(
                "caller holds admin in {} contexts — specify which to provision into via payload.context",
                ids.len()
            ),
            candidates: ids,
        }));
    }

    // Defensive fallthrough: caller is not super-admin (would have
    // matched above), has 0 or 1 allowed_contexts but default_context
    // returned None (so it's 0). A non-super-admin with zero context
    // grants shouldn't reach the inference step — `require_admin`
    // would have rejected. But surface clearly if it does.
    Err(AppError::Forbidden(
        "caller has admin role but no context grants — refusing to infer".into(),
    ))
}

/// Ensure the target `context` exists, optionally creating it
/// inline when `create_context` is set. Centralised here so REST,
/// DIDComm, and the offline CLI all enforce the same semantics:
///
/// - Context exists → returns `Ok(false)` (idempotent, no-op).
/// - Context missing + `create_context: false` → `AppError::NotFound`
///   with the existing precondition message.
/// - Context missing + `create_context: true` → calls
///   [`crate::operations::contexts::create_context`], which itself
///   checks `auth.require_super_admin()`. Context-admin callers
///   land here and surface as `AppError::Forbidden`. Returns
///   `Ok(true)` on success so callers can populate
///   `summary.context_created`.
///
/// Auth concentration: the super-admin gate lives inside
/// `operations::contexts::create_context` exclusively. We don't
/// re-check it here so the boundary stays in one place.
pub async fn ensure_target_context_or_create(
    contexts_ks: &KeyspaceHandle,
    auth: &AuthClaims,
    context: &str,
    create_context: bool,
) -> Result<bool, AppError> {
    if crate::contexts::get_context(contexts_ks, context)
        .await?
        .is_some()
    {
        return Ok(false);
    }
    if !create_context {
        return Err(AppError::NotFound(format!(
            "context '{context}' is not registered on this VTA — create it first via \
             'vta contexts create --id {context}' (offline) or 'pnm contexts create' (online), \
             or pass '--create-context' to provision it inline"
        )));
    }
    crate::operations::contexts::create_context(
        contexts_ks,
        auth,
        context,
        context.to_string(),
        None,
        None, // top-level context (provisioning never nests)
        "provision-integration",
    )
    .await?;
    Ok(true)
}

/// Failure modes of [`resolve_target_context`], kept distinct so each transport
/// renders the ambiguous case in its own idiom.
#[derive(Debug)]
pub enum ResolveContextError {
    /// Inference couldn't pick a single target — carries the candidates so the
    /// transport can surface them (REST: 400 with candidates inlined; DIDComm:
    /// `provision/integration:context_required` problem report, `args =
    /// candidates`).
    Ambiguous(AmbiguousContext),
    /// Any other failure — storage error, no-context-at-all `NotFound`, the
    /// missing-context-without-`--create-context` `NotFound`, or the super-admin
    /// gate inside `create_context`.
    Op(AppError),
}

impl From<AppError> for ResolveContextError {
    fn from(e: AppError) -> Self {
        Self::Op(e)
    }
}

/// Resolve the provision target context end-to-end: use the caller-supplied
/// `requested` context verbatim, else infer it ([`infer_target_context`]); then
/// ensure it exists, creating it inline when `create_context`
/// ([`ensure_target_context_or_create`]). Returns `(context, context_created)`.
///
/// This is the shared preamble for both provision handlers (REST
/// `routes::bootstrap`, DIDComm `messaging::handlers`) — the context policy
/// (inference rules + create-or-reject + the super-admin gate concentration)
/// lives here once. Both transports pass the **already VP-verified** request
/// separately; only this context step is hoisted (the VP-verify and
/// summary-mapping steps differ per transport by design).
pub async fn resolve_target_context(
    auth: &AuthClaims,
    contexts_ks: &KeyspaceHandle,
    requested: Option<String>,
    create_context: bool,
) -> Result<(String, bool), ResolveContextError> {
    let context = match requested {
        Some(c) => c,
        // `?` on the outer `Result` maps store-level `AppError` → `Op`; the
        // inner `map_err` lifts the ambiguous case.
        None => infer_target_context(auth, contexts_ks)
            .await?
            .map_err(ResolveContextError::Ambiguous)?,
    };
    let created =
        ensure_target_context_or_create(contexts_ks, auth, &context, create_context).await?;
    Ok((context, created))
}

pub(super) async fn preconditions(
    state: &ProvisionIntegrationDeps,
    auth: &AuthClaims,
    context: &str,
    request: &VerifiedBootstrapRequest,
) -> Result<(), AppError> {
    auth.require_admin()?;
    auth.require_context(context)?;

    // Context must exist.
    if crate::contexts::get_context(&state.contexts_ks, context)
        .await?
        .is_none()
    {
        return Err(AppError::NotFound(format!(
            "context '{context}' is not registered on this VTA — create it first via \
             'vta context create --id {context}' (offline) or 'pnm contexts create' (online), \
             or pass '--create-context' to provision it inline"
        )));
    }

    // If the request carries a context hint, it must agree with the
    // chosen context. Silently normalizing hides operator bugs.
    let hint = match request.ask() {
        BootstrapAsk::TemplateBootstrap(ask) => ask.context_hint.as_deref(),
        BootstrapAsk::AdminRotation(ask) => ask.context_hint.as_deref(),
    };
    if let Some(hint) = hint
        && hint != context
    {
        return Err(AppError::Validation(format!(
            "request contextHint '{hint}' does not match provisioning context '{context}'"
        )));
    }

    // Template must be registered. Resolve order matches template-render:
    // context scope → global → built-in. Built-ins always resolve via the
    // SDK's embedded loader; only operator-uploaded templates need a
    // stored record.
    //
    // For TemplateBootstrap: integration template is required, admin
    // template is optional.
    // For AdminRotation: there is no integration template; admin
    // template is required.
    let (integration_template_name, admin_template_name): (Option<String>, Option<String>) =
        match request.ask() {
            BootstrapAsk::TemplateBootstrap(ask) => (
                Some(ask.template.name.clone()),
                ask.admin_template.as_ref().map(|t| t.name.clone()),
            ),
            BootstrapAsk::AdminRotation(ask) => (None, Some(ask.admin_template.name.clone())),
        };

    if let Some(template_name) = integration_template_name.as_deref() {
        let template_registered = crate::did_templates::get_context_template(
            &state.did_templates_ks,
            context,
            template_name,
        )
        .await?
        .is_some()
            || crate::did_templates::get_global_template(&state.did_templates_ks, template_name)
                .await?
                .is_some()
            || vta_sdk::did_templates::load_embedded(template_name).is_ok();
        if !template_registered {
            return Err(AppError::Validation(format!(
                "template '{template_name}' is not registered on this VTA. Register it via \
                 'pnm did-templates create {template_name} --file <path>' then retry"
            )));
        }
    }

    // Admin-template registration check. For AdminRotation this is the
    // primary template; for TemplateBootstrap it's the optional rollover
    // template. Built-ins (`vta-admin`) always resolve via the SDK's
    // embedded loader; only operator-uploaded templates need a stored
    // record.
    if let Some(name) = admin_template_name {
        let registered =
            crate::did_templates::get_context_template(&state.did_templates_ks, context, &name)
                .await?
                .is_some()
                || crate::did_templates::get_global_template(&state.did_templates_ks, &name)
                    .await?
                    .is_some()
                || vta_sdk::did_templates::load_embedded(&name).is_ok();
        if !registered {
            return Err(AppError::Validation(format!(
                "admin template '{name}' is not registered on this VTA. Register it via \
                 'pnm did-templates create {name} --file <path>' then retry, or use the \
                 built-in 'vta-admin' template."
            )));
        }
    }

    Ok(())
}

/// Extract the integration template name + variables from a
/// `TemplateBootstrap` ask. Returns `None` for `AdminRotation` (which
/// has no integration template — caller must dispatch on the variant
/// before reaching the integration mint).
pub(super) fn extract_template(
    ask: &BootstrapAsk,
) -> Result<Option<(String, BTreeMap<String, Value>)>, AppError> {
    match ask {
        BootstrapAsk::TemplateBootstrap(ask) => {
            Ok(Some((ask.template.name.clone(), ask.template.vars.clone())))
        }
        BootstrapAsk::AdminRotation(_) => Ok(None),
    }
}

/// Extract the admin-template reference from an `ask`.
///
/// - `TemplateBootstrap` → `Some(_)` only when `admin_template` is set
///   (operator opted into rollover).
/// - `AdminRotation` → always `Some(_)` (admin template is required).
pub(super) fn extract_admin_template(ask: &BootstrapAsk) -> Option<DidTemplateRef> {
    match ask {
        BootstrapAsk::TemplateBootstrap(ask) => ask.admin_template.clone(),
        BootstrapAsk::AdminRotation(ask) => Some(ask.admin_template.clone()),
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::acl::Role;
    use crate::store::Store;
    use vti_common::config::StoreConfig;

    async fn fresh_contexts_ks() -> (tempfile::TempDir, Store, KeyspaceHandle) {
        let dir = tempfile::tempdir().expect("temp dir");
        let store = Store::open(&StoreConfig {
            data_dir: dir.path().to_path_buf(),
        })
        .expect("open store");
        let ks = store
            .keyspace(crate::keyspaces::CONTEXTS)
            .expect("open contexts ks");
        (dir, store, ks)
    }

    fn auth(role: Role, allowed_contexts: Vec<&str>) -> AuthClaims {
        AuthClaims {
            did: "did:key:zTestCaller".into(),
            role,
            allowed_contexts: allowed_contexts.iter().map(|s| (*s).to_string()).collect(),
            session_id: "test-session".into(),
            // Synthesized auth claim, not from a JWT — mirrors the
            // shape used by `AuthClaims::synthesize` for DIDComm-only
            // callers in the codebase.
            access_expires_at: 0,
            amr: vec!["synth".into()],
            acr: String::new(),
        }
    }

    async fn seed_context(ks: &KeyspaceHandle, id: &str) {
        crate::contexts::create_context(ks, id, id)
            .await
            .expect("seed context");
    }

    /// Rule 1: single allowed context → returns it. The relayer's grant
    /// already named the bucket; inference respects it without
    /// consulting the contexts keyspace.
    #[tokio::test]
    async fn infer_returns_single_allowed_context() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;
        // Seed multiple contexts to confirm the inference doesn't reach
        // for rule 2's fallback when rule 1 already resolves.
        seed_context(&ks, "ctx_a").await;
        seed_context(&ks, "ctx_b").await;

        let a = auth(Role::Admin, vec!["ctx_b"]);
        let result = infer_target_context(&a, &ks).await.expect("ok");
        assert_eq!(result.expect("not ambiguous"), "ctx_b");
    }

    /// Rule 2: super-admin grant + maintainer has exactly one context →
    /// use it. This is the typical wallet onboarding case where the
    /// operator ran `pnm acl create --did <eph> --role admin` (no
    /// `--contexts` flag = super-admin scoping).
    #[tokio::test]
    async fn infer_super_admin_with_single_context() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;
        seed_context(&ks, "only").await;

        let a = auth(Role::Admin, vec![]); // empty → super-admin
        assert!(a.is_super_admin());

        let result = infer_target_context(&a, &ks).await.expect("ok");
        assert_eq!(result.expect("not ambiguous"), "only");
    }

    /// Rule 3a: super-admin + multiple contexts → ambiguous; carry the
    /// candidates so the caller can surface them and retry.
    #[tokio::test]
    async fn infer_super_admin_with_multiple_contexts_is_ambiguous() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;
        seed_context(&ks, "ctx_a").await;
        seed_context(&ks, "ctx_b").await;
        seed_context(&ks, "ctx_c").await;

        let a = auth(Role::Admin, vec![]);

        let result = infer_target_context(&a, &ks).await.expect("ok");
        let ambiguous = result.expect_err("must be ambiguous with 3 contexts");
        assert_eq!(
            ambiguous.candidates,
            vec![
                "ctx_a".to_string(),
                "ctx_b".to_string(),
                "ctx_c".to_string()
            ]
        );
        assert!(ambiguous.message.contains("3 contexts"));
    }

    /// Rule 3b: multi-context grant (non-super-admin) → ambiguous,
    /// candidates come from the relayer's own `allowed_contexts`.
    #[tokio::test]
    async fn infer_multi_context_grant_is_ambiguous() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;

        let a = auth(Role::Admin, vec!["ctx_x", "ctx_y"]);

        let result = infer_target_context(&a, &ks).await.expect("ok");
        let ambiguous = result.expect_err("two contexts → ambiguous");
        assert_eq!(
            ambiguous.candidates,
            vec!["ctx_x".to_string(), "ctx_y".to_string()]
        );
    }

    /// Super-admin against an empty maintainer → NotFound, not
    /// AmbiguousContext. The remediation is "create a context first"
    /// rather than "pick from the list" (the list is empty).
    #[tokio::test]
    async fn infer_super_admin_with_no_contexts_returns_not_found() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;

        let a = auth(Role::Admin, vec![]);

        let err = infer_target_context(&a, &ks)
            .await
            .expect_err("must NotFound");
        assert!(
            matches!(err, AppError::NotFound(_)),
            "expected NotFound, got {err:?}"
        );
    }

    // ── resolve_target_context (shared REST + DIDComm preamble) ──────────

    /// Caller-supplied context that already exists → returned verbatim,
    /// `context_created = false`, inference not consulted.
    #[tokio::test]
    async fn resolve_uses_requested_existing_context() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;
        seed_context(&ks, "ctx_a").await;
        let a = auth(Role::Admin, vec!["ctx_a"]);

        let (context, created) = resolve_target_context(&a, &ks, Some("ctx_a".into()), false)
            .await
            .map_err(|_| ())
            .expect("resolves");
        assert_eq!(context, "ctx_a");
        assert!(!created);
    }

    /// Requested context that doesn't exist, `create_context = true` →
    /// created inline, `context_created = true`.
    #[tokio::test]
    async fn resolve_creates_requested_context_inline() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;
        let a = auth(Role::Admin, vec![]); // super-admin (create_context gate)

        let (context, created) = resolve_target_context(&a, &ks, Some("ctx-new".into()), true)
            .await
            .expect("resolves");
        assert_eq!(context, "ctx-new");
        assert!(created);
        assert!(
            crate::contexts::get_context(&ks, "ctx-new")
                .await
                .unwrap()
                .is_some(),
            "context must have been created"
        );
    }

    /// Omitted context + ambiguous inference → `ResolveContextError::Ambiguous`
    /// carrying the candidates (the transport renders them).
    #[tokio::test]
    async fn resolve_propagates_ambiguous_inference() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;
        let a = auth(Role::Admin, vec!["ctx_x", "ctx_y"]);

        let err = resolve_target_context(&a, &ks, None, false)
            .await
            .err()
            .expect("ambiguous");
        match err {
            ResolveContextError::Ambiguous(amb) => {
                assert_eq!(
                    amb.candidates,
                    vec!["ctx_x".to_string(), "ctx_y".to_string()]
                );
            }
            ResolveContextError::Op(e) => panic!("expected Ambiguous, got Op({e:?})"),
        }
    }

    /// Requested missing context without `--create-context` → `Op(NotFound)`.
    #[tokio::test]
    async fn resolve_missing_context_without_create_is_op_not_found() {
        let (_dir, _store, ks) = fresh_contexts_ks().await;
        let a = auth(Role::Admin, vec!["ctx_absent"]);

        let err = resolve_target_context(&a, &ks, Some("ctx_absent".into()), false)
            .await
            .err()
            .expect("not found");
        assert!(
            matches!(err, ResolveContextError::Op(AppError::NotFound(_))),
            "expected Op(NotFound)",
        );
    }
}