vstorage 0.6.0

Common API for various icalendar/vcard storages.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
// Copyright 2025 Hugo Osvaldo Barrera
//
// SPDX-License-Identifier: EUPL-1.2

#[cfg(feature = "jmap_test")]
mod jmap_tests {
    use std::sync::{Arc, OnceLock};
    use std::time::Duration;

    use calcard::icalendar::{ICalendar, ICalendarProperty, ICalendarValue};
    use hyper_util::client::legacy::Client;
    use hyper_util::rt::TokioExecutor;
    use libdav::CalDavClient;
    use libdav::dav::WebDavClient;
    use libjmap::calendar::Calendar;
    use rand::{Rng as _, distr::Alphanumeric, rng};
    use tokio::sync::{Mutex, MutexGuard};
    use tokio::time::sleep;
    use tower_http::auth::AddAuthorization;
    use vstorage::ItemKind;
    use vstorage::base::{CreateItemOptions, Storage};
    use vstorage::caldav::{CalDavStorage, CollectionIdSegment};
    use vstorage::jmap::JmapStorage;

    // Server configuration
    // `Use host.containers.internal` in podman.
    const BASE_URL: &str = "http://localhost:8080";
    const CARDDAV_URL: &str = "http://localhost:8080/dav/calendars/";
    const TEST_USERNAME: &str = "user1";
    const TEST_PASSWORD: &str = "";

    fn random_string(len: usize) -> String {
        rng()
            .sample_iter(Alphanumeric)
            .take(len)
            .map(char::from)
            .collect()
    }

    /// Create a minimal iCalendar event for testing
    fn minimal_calendar_event(summary: &str) -> String {
        let uid = random_string(12);
        format!(
            concat!(
                // "BEGIN:VCALENDAR\r\n",
                // "VERSION:2.0\r\n",
                // "PRODID:-//hacksw/handcal//NONSGML v1.0//EN\r\n",
                "BEGIN:VEVENT\r\n",
                "UID:{}\r\n",
                "DTSTAMP:19970610T172345Z\r\n",
                "DTSTART:19970714T170000Z\r\n",
                "SUMMARY:{}\r\n",
                "END:VEVENT\r\n",
                // "END:VCALENDAR\r\n",
            ),
            uid, summary
        )
    }

    /// Update an existing iCalendar event with a new summary while preserving the UID.
    fn update_calendar_event_summary(
        original_event: &str,
        new_summary: &str,
    ) -> Result<String, String> {
        let mut parsed = ICalendar::parse(original_event)
            .map_err(|e| format!("Failed to parse calendar: {:?}", e))?;

        // Find the VEVENT component and update its SUMMARY property
        for component in &mut parsed.components {
            if let Some(summary_entry) = component
                .entries
                .iter_mut()
                .find(|entry| matches!(entry.name, ICalendarProperty::Summary))
            {
                // Update the summary value
                if let Some(value) = summary_entry.values.first_mut() {
                    *value = ICalendarValue::Text(new_summary.to_string());
                }
            }
        }

        Ok(parsed.to_string())
    }

    /// Create a JMAP storage instance.
    async fn create_jmap_storage() -> Arc<dyn Storage> {
        let (storage, _) = create_jmap_storage_with_fresh_collection().await;
        storage
    }

    /// Create a JMAP storage instance with a new empty collection.
    ///
    /// Returns the storage and the href of the newly created collection.
    async fn create_jmap_storage_with_fresh_collection() -> (Arc<dyn Storage>, String) {
        let connector = hyper_rustls::HttpsConnectorBuilder::new()
            .with_native_roots()
            .unwrap()
            .https_or_http()
            .enable_http1()
            .build();
        let http_client = Client::builder(TokioExecutor::new()).build(connector);
        let mut auth_client = AddAuthorization::basic(http_client, TEST_USERNAME, TEST_PASSWORD);

        let base_url = BASE_URL.parse().unwrap();
        let (session_uri, session) =
            libjmap::discover_session_resource(&mut auth_client, &base_url)
                .await
                .unwrap();

        let api_url = session.api_url().unwrap().parse().unwrap();
        let jmap_client = libjmap::JmapClient::new(auth_client, session_uri, api_url);

        // Create a collection to be used during test.
        let collection_name = format!("test-{}", random_string(8));
        let created = jmap_client
            .create_collection::<Calendar>(&collection_name)
            .await
            .unwrap();

        let storage = JmapStorage::builder(jmap_client).build(ItemKind::Calendar);
        (Arc::new(storage), created.id)
    }

    /// Create a CalDAV storage instance for cross-protocol testing.
    async fn create_carddav_storage() -> Arc<dyn Storage> {
        // Create HTTP client
        let connector = hyper_rustls::HttpsConnectorBuilder::new()
            .with_native_roots()
            .unwrap()
            .https_or_http()
            .enable_http1()
            .build();
        let http_client = Client::builder(TokioExecutor::new()).build(connector);
        let auth_client = AddAuthorization::basic(http_client, TEST_USERNAME, TEST_PASSWORD);
        let webdav_client = WebDavClient::new(CARDDAV_URL.parse().unwrap(), auth_client);
        let carddav_client = CalDavClient::new(webdav_client);

        let storage = CalDavStorage::builder(carddav_client)
            .with_collection_id_segment(CollectionIdSegment::default())
            .build()
            .await
            .unwrap();
        Arc::new(storage)
    }

    /// Lock for tests which write onto the storage.
    ///
    /// Tests which write to the storage interfered with each other's expected state.
    /// They must be run sequentially.
    async fn lock_storage_write() -> MutexGuard<'static, ()> {
        static STORAGE: OnceLock<Mutex<()>> = OnceLock::new();
        STORAGE.get_or_init(|| Mutex::new(())).lock().await
    }

    #[tokio::test]
    async fn jmap_connectivity() {
        let storage = create_jmap_storage().await;
        storage.check().await.unwrap();
        assert_eq!(storage.item_kind(), ItemKind::Calendar);
    }

    #[tokio::test]
    async fn jmap_calendar_discovery() {
        let storage = create_jmap_storage().await;

        // Discover calendar collections
        let discovery = storage.discover_collections().await.unwrap();

        // Should have at least one calendar
        assert!(
            !discovery.collections().is_empty(),
            "No calendar collections discovered"
        );

        for collection in discovery.collections() {
            println!(
                "Found calendar: {} ({})",
                collection.href(),
                collection.id()
            );
        }
    }

    // PRECONDITION: storage must have at least one collection.
    #[tokio::test]
    async fn jmap_event_lifecycle() {
        let lock = lock_storage_write().await;

        let storage = create_jmap_storage().await;

        // Discover collections and use the first one.
        let discovery = storage.discover_collections().await.unwrap();
        let collection = &discovery.collections()[0];
        let collection_href = collection.href();

        // Create a test event.
        let raw_event = minimal_calendar_event("Test Event");
        let item = raw_event.clone().into();
        let item_version = storage
            .create_item(collection_href, &item, CreateItemOptions::default())
            .await
            .unwrap();
        assert!(item_version.href.starts_with(collection_href));

        // Fetch event.
        let (retrieved_item, etag) = storage.get_item(&item_version.href).await.unwrap();
        assert_eq!(etag, item_version.etag);

        // Parse both events to compare ignoring formatting differences.
        // TODO: can't we just compare hashes?
        let original_event = ICalendar::parse(&raw_event).unwrap();
        let retrieved_event = ICalendar::parse(retrieved_item.as_str()).unwrap();

        // Compare core properties (title and UID should be preserved)
        let original_summary = original_event
            .components
            .iter()
            .find_map(|c| c.property(&ICalendarProperty::Summary))
            .and_then(|e| e.values.first())
            .and_then(|v| v.as_text())
            .unwrap();
        let retrieved_summary = retrieved_event
            .components
            .iter()
            .find_map(|c| c.property(&ICalendarProperty::Summary))
            .and_then(|e| e.values.first())
            .and_then(|v| v.as_text())
            .unwrap();
        assert_eq!(original_summary, retrieved_summary);

        // Update item.
        let updated_event =
            update_calendar_event_summary(retrieved_item.as_str(), "Updated Test Event")
                .expect("Failed to update calendar event summary");
        let updated_item = updated_event.into();
        let new_etag = storage
            .update_item(&item_version.href, &item_version.etag, &updated_item)
            .await
            .unwrap();
        assert_ne!(new_etag, item_version.etag);

        // Fetch updated item.
        let (updated_retrieved_item, _) = storage.get_item(&item_version.href).await.unwrap();
        let updated_retrieved_event = ICalendar::parse(updated_retrieved_item.as_str()).unwrap();
        let updated_fn = updated_retrieved_event
            .components
            .iter()
            .find_map(|c| c.property(&ICalendarProperty::Summary))
            .and_then(|e| e.values.first())
            .and_then(|v| v.as_text())
            .unwrap();
        assert_eq!(updated_fn, "Updated Test Event");

        // Verify UID is preserved.
        let original_uid = retrieved_event
            .components
            .iter()
            .find_map(|c| c.property(&ICalendarProperty::Uid))
            .and_then(|e| e.values.first())
            .and_then(|v| v.as_text())
            .unwrap();
        let updated_uid = updated_retrieved_event
            .components
            .iter()
            .find_map(|c| c.property(&ICalendarProperty::Uid))
            .and_then(|e| e.values.first())
            .and_then(|v| v.as_text())
            .unwrap();
        assert_eq!(
            original_uid, updated_uid,
            "UID should be preserved during update"
        );

        // Delete item.
        storage
            .delete_item(&item_version.href, &new_etag)
            .await
            .unwrap();
        let result = storage.get_item(&item_version.href).await;
        assert!(result.is_err(), "Item should be deleted");

        drop(lock);
    }

    #[tokio::test]
    async fn cross_protocol_calendar_compatibility() {
        let lock = lock_storage_write().await;

        let jmap_storage = create_jmap_storage().await;
        let carddav_storage = create_carddav_storage().await;

        // Discover collections in both storages
        let jmap_discovery = jmap_storage.discover_collections().await.unwrap();
        let carddav_discovery = carddav_storage.discover_collections().await.unwrap();

        assert!(
            !jmap_discovery.collections().is_empty(),
            "No JMAP collections found"
        );
        assert!(
            !carddav_discovery.collections().is_empty(),
            "No CalDAV collections found"
        );

        // Find a collection that exists in both (assuming same collection IDs)
        let jmap_collection = &jmap_discovery.collections()[0];
        let carddav_collection = carddav_discovery
            .collections()
            .iter()
            .find(|c| c.id() == jmap_collection.id())
            .unwrap();

        // Create a test event via JMAP.
        let test_event_title = format!("Cross-Protocol Test {}", random_string(12));
        let test_event = minimal_calendar_event(&test_event_title);
        let item = test_event.clone().into();
        let jmap_item = jmap_storage
            .create_item(jmap_collection.href(), &item, CreateItemOptions::default())
            .await
            .unwrap();

        // Wait a moment for synchronisation (if needed)
        sleep(Duration::from_millis(500)).await;

        // Fetch the same event via CalDAV.
        let carddav_items = carddav_storage
            .list_items(carddav_collection.href())
            .await
            .unwrap();
        let mut found_via_carddav = false;
        for item_version in &carddav_items {
            let (carddav_item, _) = carddav_storage.get_item(&item_version.href).await.unwrap();

            if carddav_item.as_str().contains(&test_event_title) {
                found_via_carddav = true;
                println!("Found test event via CalDAV: {}", item_version.href);

                // Parse and compare events.
                let jmap_event = ICalendar::parse(&test_event).unwrap();
                let carddav_event = ICalendar::parse(carddav_item.as_str()).unwrap();

                // Core properties should match.
                let jmap_fn = jmap_event
                    .components
                    .iter()
                    .find_map(|c| c.property(&ICalendarProperty::Summary))
                    .and_then(|e| e.values.first())
                    .and_then(|v| v.as_text())
                    .unwrap();
                let carddav_fn = carddav_event
                    .components
                    .iter()
                    .find_map(|c| c.property(&ICalendarProperty::Summary))
                    .and_then(|e| e.values.first())
                    .and_then(|v| v.as_text())
                    .unwrap();
                assert_eq!(
                    jmap_fn, carddav_fn,
                    "Event title should match between JMAP and CalDAV"
                );

                break;
            }
        }

        assert!(
            found_via_carddav,
            "Event created via JMAP was not found via CalDAV"
        );

        // Clean up: delete the test event via JMAP
        jmap_storage
            .delete_item(&jmap_item.href, &jmap_item.etag)
            .await
            .unwrap();

        // Verify it's also deleted from CalDAV
        sleep(Duration::from_millis(500)).await;

        let updated_carddav_items = carddav_storage
            .list_items(carddav_collection.href())
            .await
            .unwrap();

        let still_exists_in_carddav = updated_carddav_items.iter().any(|item_version| {
            // This is a simplified check - in practice, you'd want to fetch and parse each item
            item_version.href.contains(&test_event_title)
        });

        assert!(
            !still_exists_in_carddav,
            "Event should be deleted from CalDAV as well"
        );

        drop(lock);
    }

    #[tokio::test]
    async fn calendar_event_conversion() {
        let lock = lock_storage_write().await;

        let storage = create_jmap_storage().await;

        // Test various event formats and features.
        let test_cases = vec![
            ("Simple Event", minimal_calendar_event("Simple Event")),
            (
                "Event with Description",
                minimal_calendar_event("Meeting Event"),
            ),
            (
                "Event with Location",
                minimal_calendar_event("Conference Event"),
            ),
        ];

        let discovery = storage.discover_collections().await.unwrap();
        let collection = &discovery.collections()[0];

        for (name, event_data) in test_cases {
            println!("Testing event conversion for: {}", name);

            let item = event_data.to_string().into();

            // Create item (this tests event data conversion)
            let item_version = storage
                .create_item(collection.href(), &item, CreateItemOptions::default())
                .await
                .unwrap();

            // Get item back (this tests round-trip conversion)
            let (retrieved_item, _) = storage.get_item(&item_version.href).await.unwrap();

            let original_event = ICalendar::parse(&event_data).unwrap();
            let retrieved_event = ICalendar::parse(retrieved_item.as_str()).unwrap();

            // Verify core properties are preserved
            let original_fn = original_event
                .components
                .iter()
                .find_map(|c| c.property(&ICalendarProperty::Summary))
                .and_then(|e| e.values.first())
                .and_then(|v| v.as_text())
                .unwrap();
            let retrieved_summary = retrieved_event
                .components
                .iter()
                .find_map(|c| c.property(&ICalendarProperty::Summary))
                .and_then(|e| e.values.first())
                .and_then(|v| v.as_text())
                .unwrap();
            assert_eq!(
                original_fn, retrieved_summary,
                "Event title should be preserved for {}",
                name
            );

            // Clean up
            storage
                .delete_item(&item_version.href, &item_version.etag)
                .await
                .unwrap();
        }

        drop(lock);
    }

    #[tokio::test]
    async fn error_handling() {
        let lock = lock_storage_write().await;

        let storage = create_jmap_storage().await;

        // Test getting non-existent item.
        let result = storage.get_item("nonexistent/item").await;
        assert!(
            result.is_err(),
            "Should fail when getting non-existent item"
        );

        // Test invalid event data.
        let discovery = storage.discover_collections().await.unwrap();
        let collection = &discovery.collections()[0];
        let invalid_event = "INVALID EVENT DATA".to_string().into();
        let result = storage
            .create_item(
                collection.href(),
                &invalid_event,
                CreateItemOptions::default(),
            )
            .await;
        assert!(
            result.is_err(),
            "Should fail when creating item with invalid event data"
        );

        // Test operations on non-existent collection
        let test_event = minimal_calendar_event("Test Event");
        let item = test_event.into();
        let result = storage
            .create_item(
                "nonexistent-collection",
                &item,
                CreateItemOptions::default(),
            )
            .await;
        assert!(
            result.is_err(),
            "Should fail when creating item in non-existent collection"
        );

        drop(lock);
    }

    #[tokio::test]
    async fn batch_operations() {
        let lock = lock_storage_write().await;

        let storage = create_jmap_storage().await;

        let discovery = storage.discover_collections().await.unwrap();
        let collection = &discovery.collections()[0];

        // Create multiple events
        let mut item_versions = Vec::new();
        for i in 0..5 {
            let event_title = format!("Batch Event {}", i);
            let event = minimal_calendar_event(&event_title);
            let item = event.into();

            let item_version = storage
                .create_item(collection.href(), &item, CreateItemOptions::default())
                .await
                .unwrap();

            item_versions.push(item_version);
        }

        // Test get_many_items
        let hrefs: Vec<&str> = item_versions.iter().map(|iv| iv.href.as_str()).collect();
        let fetched_items = storage.get_many_items(&hrefs).await.unwrap();

        assert_eq!(fetched_items.len(), 5, "Should fetch all 5 items");

        // Verify all items were fetched correctly
        for num in 0..5 {
            let mut found = false;
            let event_title = format!("Batch Event {}", num);
            for fetched_item in fetched_items.iter() {
                if fetched_item.item.as_str().contains(&event_title) {
                    found = true;
                    break;
                }
            }

            assert!(found, "Expected to find item with title '{}'.", event_title);
        }

        // Clean up all items
        for item_version in item_versions {
            storage
                .delete_item(&item_version.href, &item_version.etag)
                .await
                .unwrap();
        }

        drop(lock);
    }

    /// Assert our expectation on the JMAP state field.
    ///
    /// The `state` for a storage is global; modifying any item updates the state for the entire
    /// collection. This tests asserts that using an old state as Etag works if only an unrelated
    /// item has changed.
    #[tokio::test]
    async fn status_as_etag() {
        let lock = lock_storage_write().await;

        let storage = create_jmap_storage().await;

        // Discover collections and use the first one.
        let discovery = storage.discover_collections().await.unwrap();
        let collection_href = discovery.collections()[0].href();

        // Create item.
        let raw_event1 = minimal_calendar_event("Test Event");
        let item1 = raw_event1.clone().into();
        let version1 = storage
            .create_item(collection_href, &item1, CreateItemOptions::default())
            .await
            .unwrap();

        // Create unrelated item.
        let raw_event2 = minimal_calendar_event("Test Event");
        let item2 = raw_event2.clone().into();
        let version2 = storage
            .create_item(collection_href, &item2, CreateItemOptions::default())
            .await
            .unwrap();

        assert_ne!(version1.etag, version2.etag);

        // ASSERTION: should work with old Etag/state.
        let _new_version1 = storage
            .update_item(&version1.href, &version1.etag, &item1)
            .await
            .unwrap();

        drop(lock);
    }

    /// Test that delete_item handles state mismatches correctly.
    #[tokio::test]
    async fn delete_with_stale_etag() {
        let lock = lock_storage_write().await;

        let storage = create_jmap_storage().await;

        let discovery = storage.discover_collections().await.unwrap();
        let collection_href = discovery.collections()[0].href();

        // Create first item.
        let raw_event1 = minimal_calendar_event("Event to Delete");
        let item1 = raw_event1.clone().into();
        let version1 = storage
            .create_item(collection_href, &item1, CreateItemOptions::default())
            .await
            .unwrap();

        // Create unrelated item to change state.
        let raw_event2 = minimal_calendar_event("Unrelated Event");
        let item2 = raw_event2.clone().into();
        let _version2 = storage
            .create_item(collection_href, &item2, CreateItemOptions::default())
            .await
            .unwrap();

        // Delete with old etag should still work since item hasn't changed.
        storage
            .delete_item(&version1.href, &version1.etag)
            .await
            .unwrap();

        // Verify item is gone.
        let result = storage.get_item(&version1.href).await;
        assert!(result.is_err(), "Item should be deleted");

        drop(lock);
    }

    /// Test that delete_item fails when item has been modified.
    #[tokio::test]
    async fn delete_with_modified_item() {
        let lock = lock_storage_write().await;

        let storage = create_jmap_storage().await;

        let discovery = storage.discover_collections().await.unwrap();
        let collection_href = discovery.collections()[0].href();

        // Create item.
        let raw_event = minimal_calendar_event("Event to Modify");
        let item = raw_event.clone().into();
        let version = storage
            .create_item(collection_href, &item, CreateItemOptions::default())
            .await
            .unwrap();

        // Modify the item.
        let modified_event = update_calendar_event_summary(&raw_event, "Modified Event").unwrap();
        let modified_item = modified_event.into();
        let _new_version = storage
            .update_item(&version.href, &version.etag, &modified_item)
            .await
            .unwrap();

        // Try to delete with old etag - should fail.
        let result = storage.delete_item(&version.href, &version.etag).await;
        assert!(
            result.is_err(),
            "Delete with stale etag should fail when item was modified"
        );

        drop(lock);
    }

    /// Test bootstrap via changed_since on an empty collection.
    #[tokio::test]
    async fn changed_since_bootstrap_empty() {
        let lock = lock_storage_write().await;

        let (storage, collection_id) = create_jmap_storage_with_fresh_collection().await;

        let changes = storage.changed_since(&collection_id, None).await.unwrap();

        assert!(changes.changed.is_empty());
        assert!(changes.deleted.is_empty());

        drop(lock);
    }

    /// Test incremental sync via changed_since.
    #[tokio::test]
    async fn changed_since_incremental_sync() {
        let lock = lock_storage_write().await;

        let (storage, collection_id) = create_jmap_storage_with_fresh_collection().await;
        let collection_href = &collection_id;

        let initial_changes = storage.changed_since(collection_href, None).await.unwrap();
        let initial_state = initial_changes.new_state.clone();
        assert!(initial_changes.changed.is_empty());
        assert!(initial_changes.deleted.is_empty());

        let raw_event = minimal_calendar_event("Changed Since Test Event");
        let item = raw_event.clone().into();
        let version = storage
            .create_item(collection_href, &item, CreateItemOptions::default())
            .await
            .unwrap();

        let changes = storage
            .changed_since(collection_href, initial_state.as_deref())
            .await
            .unwrap();

        assert!(changes.changed.contains(&version.href));
        assert!(changes.deleted.is_empty());

        let state_after_create = changes.new_state.clone();

        let updated_event =
            update_calendar_event_summary(&raw_event, "Updated Changed Since Event").unwrap();
        let updated_item = updated_event.into();
        let new_version = storage
            .update_item(&version.href, &version.etag, &updated_item)
            .await
            .unwrap();

        let changes_after_update = storage
            .changed_since(collection_href, state_after_create.as_deref())
            .await
            .unwrap();

        assert!(changes_after_update.changed.contains(&version.href));
        assert!(changes.deleted.is_empty());

        let state_after_update = changes_after_update.new_state.clone();

        storage
            .delete_item(&version.href, &new_version)
            .await
            .unwrap();

        let changes_after_delete = storage
            .changed_since(collection_href, state_after_update.as_deref())
            .await
            .unwrap();

        assert!(changes_after_delete.deleted.contains(&version.href));

        drop(lock);
    }

    /// Test bootstrap via changed_since on a non-empty collection.
    #[tokio::test]
    async fn changed_since_bootstrap_non_empty() {
        let lock = lock_storage_write().await;

        let storage = create_jmap_storage().await;

        let discovery = storage.discover_collections().await.unwrap();
        let collection_href = discovery.collections()[0].href();

        let raw_event = minimal_calendar_event("Bootstrap Non-Empty Test Event");
        let item = raw_event.into();
        let version = storage
            .create_item(collection_href, &item, CreateItemOptions::default())
            .await
            .unwrap();

        let changes = storage.changed_since(collection_href, None).await.unwrap();

        assert!(changes.changed.contains(&version.href));
        assert!(changes.deleted.is_empty());

        // Clean up (?).
        storage
            .delete_item(&version.href, &version.etag)
            .await
            .unwrap();

        drop(lock);
    }
}