use crate::errors::{Diagnostic, Severity, ValidationResult};
use crate::index::NodeIndex;
use crate::ir::{ChildNode, VoceIr};
use crate::passes::ValidationPass;
pub struct SeoPass;
impl ValidationPass for SeoPass {
fn name(&self) -> &'static str {
"seo"
}
fn run(&self, ir: &VoceIr, _index: &NodeIndex, result: &mut ValidationResult) {
let root = match &ir.root {
Some(r) => r,
None => return,
};
match &root.metadata {
None => {
result.diagnostics.push(Diagnostic {
severity: Severity::Warning,
code: "SEO001".to_string(),
message: "ViewRoot has no PageMetadata — page will lack title, description, and OG tags".to_string(),
node_path: "/root".to_string(),
pass: self.name().to_string(),
hint: None,
});
}
Some(meta) => {
if meta.title.as_ref().is_none_or(|t| t.is_empty()) {
result.diagnostics.push(Diagnostic {
severity: Severity::Error,
code: "SEO001".to_string(),
message: "PageMetadata title is empty".to_string(),
node_path: "/root/metadata".to_string(),
pass: self.name().to_string(),
hint: None,
});
} else if let Some(ref title) = meta.title {
if title.len() > 60 {
result.diagnostics.push(Diagnostic {
severity: Severity::Warning,
code: "SEO002".to_string(),
message: format!(
"PageMetadata title is {} characters (recommended: ≤60)",
title.len()
),
node_path: "/root/metadata".to_string(),
pass: self.name().to_string(),
hint: None,
});
}
}
if let Some(ref desc) = meta.description {
if desc.len() > 160 {
result.diagnostics.push(Diagnostic {
severity: Severity::Warning,
code: "SEO002".to_string(),
message: format!(
"PageMetadata description is {} characters (recommended: ≤160)",
desc.len()
),
node_path: "/root/metadata".to_string(),
pass: self.name().to_string(),
hint: None,
});
}
}
if let Some(ref og) = meta.open_graph {
if og.image.as_ref().is_none_or(|i| i.is_empty()) {
result.diagnostics.push(Diagnostic {
severity: Severity::Warning,
code: "SEO007".to_string(),
message: "OpenGraph data is present but missing og:image".to_string(),
node_path: "/root/metadata/open_graph".to_string(),
pass: self.name().to_string(),
hint: None,
});
}
}
}
}
if let Some(ref children) = root.children {
let mut h1_count = 0;
self.count_h1s(children, &mut h1_count);
if h1_count == 0 {
result.diagnostics.push(Diagnostic {
severity: Severity::Warning,
code: "SEO003".to_string(),
message: "Page has no h1 heading".to_string(),
node_path: "/root".to_string(),
pass: self.name().to_string(),
hint: None,
});
} else if h1_count > 1 {
result.diagnostics.push(Diagnostic {
severity: Severity::Warning,
code: "SEO003".to_string(),
message: format!("Page has {h1_count} h1 headings (recommended: exactly 1)"),
node_path: "/root".to_string(),
pass: self.name().to_string(),
hint: None,
});
}
}
}
}
impl SeoPass {
fn count_h1s(&self, children: &[ChildNode], count: &mut usize) {
for child in children {
if child.type_name() == "TextNode" {
if let Some(text) = child.as_type::<crate::ir::TextNode>() {
if text.heading_level == Some(1) {
*count += 1;
}
}
}
if let Some(grandchildren) = child.children() {
self.count_h1s(&grandchildren, count);
}
}
}
}