1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
//! Expression walking for scope discovery.
//!
//! Recursively walks expression nodes to find nested function scopes,
//! callback arguments, reactivity losses, and client-only lifecycle hooks.
use oxc_ast::ast::{Argument, AssignmentTarget, CallExpression, ObjectPropertyKind, Statement};
use super::{
detect_provide_inject_call, extract_function_params, is_client_only_hook, walk_statement,
ClientOnlyScopeData, ClosureScopeData, CompactString, Expression, ScriptParseResult,
};
/// Walk an expression to find nested scopes (arrow functions, callbacks, etc.)
///
/// This is called recursively to build the scope chain for the script.
/// Performance: Only walks into expressions that might contain function scopes.
#[inline]
pub(in crate::script_parser) fn walk_expression(
result: &mut ScriptParseResult,
expr: &Expression<'_>,
source: &str,
) {
match expr {
// Arrow functions create closure scopes (no `arguments`, no `this` binding)
Expression::ArrowFunctionExpression(arrow) => {
let params = extract_function_params(&arrow.params);
result.scopes.enter_closure_scope(
ClosureScopeData {
name: None,
param_names: params,
is_arrow: true,
is_async: arrow.r#async,
is_generator: false, // Arrow functions cannot be generators
},
arrow.span.start,
arrow.span.end,
);
// Walk the body for nested scopes
// Arrow function body is always a FunctionBody (not a variant)
// but may have expression property set for concise arrows
if arrow.expression {
// Concise arrow: () => expr
// The expression is the first statement's expression
if let Some(Statement::ExpressionStatement(expr_stmt)) =
arrow.body.statements.first()
{
walk_expression(result, &expr_stmt.expression, source);
}
} else {
// Block arrow: () => { ... }
for stmt in arrow.body.statements.iter() {
walk_statement(result, stmt, source);
}
}
result.scopes.exit_scope();
}
// Function expressions create closure scopes
Expression::FunctionExpression(func) => {
let params = extract_function_params(&func.params);
let name = func
.id
.as_ref()
.map(|id| CompactString::new(id.name.as_str()));
result.scopes.enter_closure_scope(
ClosureScopeData {
name,
param_names: params,
is_arrow: false,
is_async: func.r#async,
is_generator: func.generator,
},
func.span.start,
func.span.end,
);
// Walk the body for nested scopes
if let Some(body) = &func.body {
for stmt in body.statements.iter() {
walk_statement(result, stmt, source);
}
}
result.scopes.exit_scope();
}
// Call expressions may contain callbacks as arguments
Expression::CallExpression(call) => {
walk_call_arguments(result, call, source);
}
// Member expressions - walk the object
Expression::StaticMemberExpression(member) => {
walk_expression(result, &member.object, source);
}
Expression::ComputedMemberExpression(member) => {
walk_expression(result, &member.object, source);
walk_expression(result, &member.expression, source);
}
// Chained expressions
Expression::ChainExpression(chain) => match &chain.expression {
oxc_ast::ast::ChainElement::CallExpression(call) => {
walk_call_arguments(result, call, source);
}
oxc_ast::ast::ChainElement::TSNonNullExpression(expr) => {
walk_expression(result, &expr.expression, source);
}
oxc_ast::ast::ChainElement::StaticMemberExpression(member) => {
walk_expression(result, &member.object, source);
}
oxc_ast::ast::ChainElement::ComputedMemberExpression(member) => {
walk_expression(result, &member.object, source);
walk_expression(result, &member.expression, source);
}
oxc_ast::ast::ChainElement::PrivateFieldExpression(field) => {
walk_expression(result, &field.object, source);
}
},
// Conditional expression
Expression::ConditionalExpression(cond) => {
walk_expression(result, &cond.test, source);
walk_expression(result, &cond.consequent, source);
walk_expression(result, &cond.alternate, source);
}
// Logical/Binary expressions
Expression::LogicalExpression(logical) => {
walk_expression(result, &logical.left, source);
walk_expression(result, &logical.right, source);
}
Expression::BinaryExpression(binary) => {
walk_expression(result, &binary.left, source);
walk_expression(result, &binary.right, source);
}
// Array/Object expressions
Expression::ArrayExpression(arr) => {
for elem in arr.elements.iter() {
match elem {
oxc_ast::ast::ArrayExpressionElement::SpreadElement(spread) => {
walk_expression(result, &spread.argument, source);
}
oxc_ast::ast::ArrayExpressionElement::Elision(_) => {}
_ => {
if let Some(expr) = elem.as_expression() {
walk_expression(result, expr, source);
}
}
}
}
}
Expression::ObjectExpression(obj) => {
for prop in obj.properties.iter() {
match prop {
ObjectPropertyKind::ObjectProperty(p) => {
walk_expression(result, &p.value, source);
}
ObjectPropertyKind::SpreadProperty(spread) => {
// Check for reactive spread: { ...state }
if let Expression::Identifier(id) = &spread.argument {
let var_name = CompactString::new(id.name.as_str());
if result.reactivity.is_reactive(var_name.as_str()) {
result.reactivity.record_spread(
var_name,
spread.span.start,
spread.span.end,
);
}
}
walk_expression(result, &spread.argument, source);
}
}
}
}
// Await/Unary
Expression::AwaitExpression(await_expr) => {
walk_expression(result, &await_expr.argument, source);
}
Expression::UnaryExpression(unary) => {
walk_expression(result, &unary.argument, source);
}
// Sequence expression
Expression::SequenceExpression(seq) => {
for expr in seq.expressions.iter() {
walk_expression(result, expr, source);
}
}
// Parenthesized
Expression::ParenthesizedExpression(paren) => {
walk_expression(result, &paren.expression, source);
}
// Assignment
Expression::AssignmentExpression(assign) => {
// Check for reactive variable reassignment: state = newValue
if let AssignmentTarget::AssignmentTargetIdentifier(id) = &assign.left {
let var_name = CompactString::new(id.name.as_str());
if result.reactivity.is_reactive(var_name.as_str()) {
// Use id.span for the variable name, assign.span for the full expression
result
.reactivity
.record_reassign(var_name, id.span.start, assign.span.end);
}
}
walk_expression(result, &assign.right, source);
}
// TypeScript type assertions (as, satisfies, !)
Expression::TSAsExpression(ts_as) => {
walk_expression(result, &ts_as.expression, source);
}
Expression::TSSatisfiesExpression(ts_satisfies) => {
walk_expression(result, &ts_satisfies.expression, source);
}
Expression::TSNonNullExpression(ts_non_null) => {
walk_expression(result, &ts_non_null.expression, source);
}
// Other expressions don't need walking for scopes
_ => {}
}
}
/// Walk call expression arguments to find callbacks
#[inline]
pub(in crate::script_parser) fn walk_call_arguments(
result: &mut ScriptParseResult,
call: &CallExpression<'_>,
source: &str,
) {
// First, walk the callee (might be a chained call like foo.bar().baz())
walk_expression(result, &call.callee, source);
// Check for provide/inject calls
detect_provide_inject_call(result, call, source);
// Check if this is a client-only lifecycle hook
let is_lifecycle_hook = if let Expression::Identifier(id) = &call.callee {
is_client_only_hook(id.name.as_str())
} else {
false
};
let hook_name = if is_lifecycle_hook {
if let Expression::Identifier(id) = &call.callee {
Some(id.name.as_str())
} else {
None
}
} else {
None
};
// Then walk each argument
for arg in call.arguments.iter() {
match arg {
Argument::SpreadElement(spread) => {
walk_expression(result, &spread.argument, source);
}
_ => {
if let Some(expr) = arg.as_expression() {
// If this is a lifecycle hook and the argument is a function,
// wrap it in a ClientOnly scope
if let Some(name) = hook_name {
match expr {
Expression::ArrowFunctionExpression(arrow) => {
// Enter client-only scope
result.scopes.enter_client_only_scope(
ClientOnlyScopeData {
hook_name: CompactString::new(name),
},
call.span.start,
call.span.end,
);
// Now create the closure scope inside the client-only scope
let params = extract_function_params(&arrow.params);
result.scopes.enter_closure_scope(
ClosureScopeData {
name: None,
param_names: params,
is_arrow: true,
is_async: arrow.r#async,
is_generator: false,
},
arrow.span.start,
arrow.span.end,
);
// Walk the body
if arrow.expression {
if let Some(Statement::ExpressionStatement(expr_stmt)) =
arrow.body.statements.first()
{
walk_expression(result, &expr_stmt.expression, source);
}
} else {
for stmt in arrow.body.statements.iter() {
walk_statement(result, stmt, source);
}
}
result.scopes.exit_scope(); // Exit closure scope
result.scopes.exit_scope(); // Exit client-only scope
continue;
}
Expression::FunctionExpression(func) => {
// Enter client-only scope
result.scopes.enter_client_only_scope(
ClientOnlyScopeData {
hook_name: CompactString::new(name),
},
call.span.start,
call.span.end,
);
// Create closure scope inside client-only scope
let params = extract_function_params(&func.params);
let fn_name = func
.id
.as_ref()
.map(|id| CompactString::new(id.name.as_str()));
result.scopes.enter_closure_scope(
ClosureScopeData {
name: fn_name,
param_names: params,
is_arrow: false,
is_async: func.r#async,
is_generator: func.generator,
},
func.span.start,
func.span.end,
);
if let Some(body) = &func.body {
for stmt in body.statements.iter() {
walk_statement(result, stmt, source);
}
}
result.scopes.exit_scope(); // Exit closure scope
result.scopes.exit_scope(); // Exit client-only scope
continue;
}
_ => {}
}
}
walk_expression(result, expr, source);
}
}
}
}
}