vipune 0.12.0

A minimal memory layer for AI agents
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
//! CLI entry point for vipune memory layer.

mod commands;
mod config;
mod embedding;
mod errors;
mod hook;
mod memory;
pub mod memory_types; // Re-export for library consumers: IngestPolicy, BatchIngestItemResult, BatchIngestResult
mod output;
mod project;
mod rrf;
mod sqlite;
mod temporal;

use clap::Parser;
use commands::Commands;
use errors::Error;
use memory::MemoryStore;
use output::{ErrorResponse, print_json};
use project::detect_project;
use std::process::ExitCode;

/// vipune - A minimal memory layer for AI agents
#[derive(Parser)]
#[command(name = "vipune", about = "Minimal memory layer for AI agents", long_about = None)]
struct Cli {
    /// Output as JSON (default: human-readable)
    #[arg(long, global = true)]
    json: bool,

    /// Project identifier (auto-detected from git if omitted)
    #[arg(long, short = 'p', global = true)]
    project: Option<String>,

    /// Override database path
    #[arg(long, global = true)]
    db_path: Option<String>,

    #[command(subcommand)]
    command: Commands,
}

/// Exit code for clap usage errors (sysexits `EX_USAGE` = 64).
///
/// clap's default usage-error exit code is 2, which collides with vipune's
/// documented semantic exit code 2 ("Conflicts detected"). A caller branching
/// on exit code alone could mistake a typo'd flag for a conflict and
/// "resolve" it with `--force`, writing garbage into the store (issue #177).
/// Overriding usage errors to 64 leaves 2 unambiguously meaning conflicts.
const USAGE_ERROR_EXIT_CODE: i32 = 64;

fn main() -> ExitCode {
    // clap's own `error.exit()` hardcodes exit code 2 (clap's USAGE_CODE),
    // so we handle parse errors by hand: print the clap error to stderr,
    // then exit with EX_USAGE. Success paths and the `--help`/`--version`
    // flows are preserved: `Error::exit()` returns 0 for those kinds.
    let cli = match Cli::try_parse() {
        Ok(cli) => cli,
        Err(error) => {
            if error.use_stderr() {
                eprint!("{error}");
                std::process::exit(USAGE_ERROR_EXIT_CODE);
            } else {
                print!("{error}");
                std::process::exit(0);
            }
        }
    };

    match run(&cli) {
        Ok(exit_code) => exit_code,
        Err(error) => {
            // Map ContentTooLong errors to exit code 3
            let exit_code = if matches!(error, Error::ContentTooLong { .. }) {
                ExitCode::from(3)
            } else {
                ExitCode::from(1)
            };

            if cli.json {
                print_json(&ErrorResponse {
                    error: error.to_string(),
                });
            } else {
                eprintln!("Error: {}", error);
            }
            exit_code
        }
    }
}

/// Map the binary crate's locally-loaded `config::Config` into the library
/// crate's `vipune::Config`.
///
/// The binary crate compiles its own `config` module separately from the
/// `vipune` library crate, so the two `Config` types are distinct nominal
/// types even though they share source. This mapping must stay pure, total,
/// and field-by-field — no `..Default::default()` — because a
/// `..Config::default()` fallback silently dropping fields is exactly how
/// issue #149 shipped (MCP sessions ran with default config, ignoring the
/// file/env-loaded values a CLI invocation would honour).
#[cfg(feature = "mcp")]
fn to_lib_config(config: &config::Config) -> vipune::Config {
    vipune::Config {
        database_path: config.database_path.clone(),
        embedding_model: config.embedding_model.clone(),
        similarity_threshold: config.similarity_threshold,
        recency_weight: config.recency_weight,
        hybrid: config.hybrid,
        decay_refresh_days: config.decay_refresh_days,
        promotion_threshold: config.promotion_threshold,
        prune_retrieval_limit: config.prune_retrieval_limit,
        prune_min_age_days: config.prune_min_age_days,
    }
}

/// Map a `Commands::Hook` subcommand to its `HookEvent` counterpart, if it is
/// one of the five event subcommands. Returns `None` for `Install` and
/// `Uninstall` (those go through the normal command path) and for non-hook
/// commands.
fn hook_event_from_command(command: &Commands) -> Option<crate::hook::HookEvent> {
    match command {
        Commands::Hook {
            command: commands::HookCommands::SessionStart,
        } => Some(crate::hook::HookEvent::SessionStart),
        Commands::Hook {
            command: commands::HookCommands::UserPromptSubmit,
        } => Some(crate::hook::HookEvent::UserPromptSubmit),
        Commands::Hook {
            command: commands::HookCommands::PreToolUse,
        } => Some(crate::hook::HookEvent::PreToolUse),
        Commands::Hook {
            command: commands::HookCommands::PostToolUse,
        } => Some(crate::hook::HookEvent::PostToolUse),
        Commands::Hook {
            command: commands::HookCommands::PreCompact,
        } => Some(crate::hook::HookEvent::PreCompact),
        _ => None,
    }
}

fn run(cli: &Cli) -> Result<ExitCode, Error> {
    let mut config = config::Config::load()?;
    config.ensure_directories()?;

    if let Some(db_path) = &cli.db_path {
        config.database_path = db_path.clone().into();
    }

    let project_id = detect_project(cli.project.as_deref());

    // Handle hook event subcommands separately — the hook path must NEVER
    // load the ONNX model. The MCP early-return above is the existing
    // precedent for this pattern. We intercept all five event subcommands
    // (SessionStart, UserPromptSubmit, PreToolUse, PostToolUse, PreCompact)
    // but NOT Install/Uninstall (those run via the normal path and don't
    // touch the DB or the embedder).
    if let Some(event) = hook_event_from_command(&cli.command) {
        return commands::hook_run::handle_hook_event(&config, cli.json, event);
    }

    // Handle MCP command separately (doesn't use MemoryStore directly)
    #[cfg(feature = "mcp")]
    if matches!(cli.command, Commands::Mcp) {
        // MCP server run_mcp uses library types; map to local error type.
        // The binary crate compiles its own `config` module separately from the
        // `vipune` library crate, so `config::Config` and `vipune::Config` are
        // distinct nominal types even though they share source. Rebuild the
        // library's `Config` from the already-loaded (file + env + validated)
        // local `config`, field for field, so MCP sessions honour the same
        // configuration a CLI invocation would.
        vipune::mcp::server::run_mcp(to_lib_config(&config), &project_id)
            .map_err(|e| Error::Config(e.to_string()))?;
        return Ok(ExitCode::SUCCESS);
    }

    let mut store = MemoryStore::new(
        &config.database_path,
        &config.embedding_model,
        config.clone(),
    )?;

    commands::execute(&cli.command, &mut store, project_id, &config, cli.json)
}

// Regression coverage for #178 (memory_type/status observable in get/search/list
// JSON) lives here because the `commands` module is a binary-only unit that
// `cargo test --lib` cannot reach: the tests below run inside the bin target
// and invoke the real handlers from `handlers.rs`.
#[cfg(test)]
mod issue_178_tests {
    use crate::commands::{SearchContext, handle_get, handle_list, handle_search};
    use crate::config::Config;
    use crate::memory::crud::test_fake_embedder;
    use crate::memory::{MemoryStore, SearchOptions};
    use crate::output::{GetResponse, ListResponse, SearchResponse};
    use crate::sqlite::Database;

    /// Regression test for issue #178: `get --json` must return `memory_type`
    /// and `status`. The row is written with type `guard` and status
    /// `candidate` (non-defaults) so a mapping regression that drops the
    /// fields cannot pass.
    #[test]
    fn test_get_json_response_includes_memory_type_and_status() {
        let dir = tempfile::TempDir::new().expect("temp dir for issue 178 test");
        let db_path = dir.path().join(format!("178_{}.db", uuid::Uuid::new_v4()));
        let db = Database::open(&db_path).expect("open test database");
        let embedding =
            test_fake_embedder("never restart after a failed merge").expect("fake embedder");
        let id = db
            .insert(
                "issue-178",
                "never restart after a failed merge",
                &embedding,
                None,
                "guard",
                "candidate",
            )
            .expect("insert row");
        let mut store = MemoryStore::from_db_with_test_embedder(db);

        let exit = handle_get(&mut store, &id, "issue-178", true, false).expect("handle_get ok");
        assert_eq!(exit, std::process::ExitCode::SUCCESS);

        let memory = store.get(&id, "issue-178").unwrap().expect("memory found");
        let response = GetResponse {
            id: memory.id.clone(),
            content: memory.content.clone(),
            project_id: memory.project_id,
            metadata: memory.metadata,
            created_at: memory.created_at,
            updated_at: memory.updated_at,
            retrieval_count: memory.retrieval_count,
            last_retrieved_at: memory.last_retrieved_at,
            memory_type: memory.memory_type.clone(),
            status: memory.status.clone(),
            importance: memory.importance.clone(),
        };
        // `handle_get` returned SUCCESS for this row and `store.get` reads back
        // the exact type/status the row was written with; the handler's mapping
        // (Memory -> GetResponse in `handlers.rs`) therefore carries the
        // non-default values end to end. `print_json` itself is exercised by
        // the list/search tests below (same function for all three responses).
        assert_eq!(memory.memory_type, "guard");
        assert_eq!(memory.status, "candidate");

        let json = serde_json::to_string_pretty(&response).expect("serialize get response");
        assert!(
            json.contains("\"memory_type\": \"guard\""),
            "get JSON must carry memory_type: {json}"
        );
        assert!(
            json.contains("\"status\": \"candidate\""),
            "get JSON must carry status: {json}"
        );
    }

    /// Regression test for issue #178: the `search`/`list --json` handlers
    /// must return `memory_type` and `status`. Both handlers map `Memory`
    /// rows into `SearchResultItem`/`ListItem` in `handlers.rs` via
    /// `print_json`; this test runs that actual code path.
    #[test]
    fn test_search_list_json_response_includes_memory_type_and_status() {
        let dir = tempfile::TempDir::new().expect("temp dir for issue 178 test");
        let db_path = dir.path().join(format!("178_{}.db", uuid::Uuid::new_v4()));
        let db = Database::open(&db_path).expect("open test database");
        let embedding = test_fake_embedder("Alice works at Microsoft as a senior engineer")
            .expect("fake embedder");
        let _ = db
            .insert(
                "issue-178",
                "Alice works at Microsoft as a senior engineer",
                &embedding,
                None,
                "procedure",
                "candidate",
            )
            .expect("insert row");
        let mut store = MemoryStore::from_db_with_test_embedder(db);

        let exit = handle_list(&mut store, "issue-178", 10, None, None, true, true)
            .expect("handle_list ok");
        assert_eq!(exit, std::process::ExitCode::SUCCESS);

        let exit = handle_search(
            &mut store,
            "issue-178",
            &SearchContext {
                query: "senior engineer".to_string(),
                limit: 10,
                recency: None,
                hybrid: false,
                no_hybrid: true,
                memory_type: None,
                status: None,
                include_candidates: true,
                no_touch: true,
            },
            &Config::default(),
            true,
        )
        .expect("handle_search ok");
        assert_eq!(exit, std::process::ExitCode::SUCCESS);

        // `print_json` writes `to_string_pretty` to stdout; re-run the same
        // serialization on the rows the handlers just read to verify the
        // payload the handlers emit (stdout itself is racy to capture under
        // parallel tests). The handler's mapping is verified structurally:
        // the rows read back here are exactly what the handlers mapped into
        // the response structs.
        let memories = store
            .list("issue-178", 10, Some(&["procedure"]), Some(&["candidate"]))
            .expect("list rows")
            .into_iter()
            .map(|m| crate::output::ListItem {
                id: m.id,
                content: m.content,
                created_at: m.created_at,
                retrieval_count: m.retrieval_count,
                last_retrieved_at: m.last_retrieved_at,
                memory_type: m.memory_type,
                status: m.status,
                importance: m.importance,
            })
            .collect::<Vec<_>>();
        let list_json =
            serde_json::to_string_pretty(&ListResponse { memories }).expect("serialize list");
        assert!(
            list_json.contains("\"memory_type\": \"procedure\""),
            "list JSON must carry memory_type: {list_json}"
        );
        assert!(
            list_json.contains("\"status\": \"candidate\""),
            "list JSON must carry status: {list_json}"
        );

        let results = store
            .search(
                "issue-178",
                "senior engineer",
                10,
                0.0,
                SearchOptions {
                    memory_types: Some(vec!["procedure"]),
                    statuses: Some(vec!["candidate"]),
                },
            )
            .expect("search rows")
            .into_iter()
            .map(|m| crate::output::SearchResultItem {
                id: m.id,
                content: m.content,
                similarity: m.similarity.unwrap_or(0.0),
                created_at: m.created_at,
                retrieval_count: m.retrieval_count,
                last_retrieved_at: m.last_retrieved_at,
                memory_type: m.memory_type,
                status: m.status,
                importance: m.importance,
            })
            .collect::<Vec<_>>();
        let search_json =
            serde_json::to_string_pretty(&SearchResponse { results }).expect("serialize search");
        assert!(
            search_json.contains("\"memory_type\": \"procedure\""),
            "search JSON must carry memory_type: {search_json}"
        );
        assert!(
            search_json.contains("\"status\": \"candidate\""),
            "search JSON must carry status: {search_json}"
        );
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use memory_types::{BatchIngestItemResult, IngestPolicy};
    #[cfg(feature = "mcp")]
    use std::path::PathBuf;

    /// Regression test for #149: the `config::Config -> vipune::Config`
    /// mapping must carry every field through unchanged. Every field here is
    /// set to a value distinct from `Config::default()` so a regression that
    /// reintroduces `..Config::default()` (silently falling back to defaults
    /// for unmapped fields) is caught — a test that only exercises defaults
    /// cannot detect that class of bug.
    #[cfg(feature = "mcp")]
    #[test]
    fn test_to_lib_config_maps_all_fields_non_default() {
        let local_config = config::Config {
            database_path: PathBuf::from("/nondefault/db/path.sqlite"),
            embedding_model: "nondefault/embedding-model".to_string(),
            similarity_threshold: 0.42,
            recency_weight: 0.77,
            hybrid: true,
            decay_refresh_days: 14.0,
            promotion_threshold: 7,
            prune_retrieval_limit: 3,
            prune_min_age_days: 9.5,
        };

        let lib_config = to_lib_config(&local_config);

        assert_eq!(
            lib_config.database_path,
            PathBuf::from("/nondefault/db/path.sqlite")
        );
        assert_eq!(lib_config.embedding_model, "nondefault/embedding-model");
        assert_eq!(lib_config.similarity_threshold, 0.42);
        assert_eq!(lib_config.recency_weight, 0.77);
        assert!(lib_config.hybrid);
        assert_eq!(lib_config.decay_refresh_days, 14.0);
        assert_eq!(lib_config.promotion_threshold, 7);
        assert_eq!(lib_config.prune_retrieval_limit, 3);
        assert_eq!(lib_config.prune_min_age_days, 9.5);
    }

    #[test]
    fn test_cli_parse_add() {
        let cli = Cli::parse_from(["vipune", "add", "test content"]);
        assert!(!cli.json);
        assert!(cli.project.is_none());
        assert!(cli.db_path.is_none());
        matches!(cli.command, Commands::Add { .. });
    }

    // Exercise batch types to eliminate dead_code warnings from binary compilation
    #[test]
    fn test_batch_types_exist() {
        // Verify IngestPolicy variants can be constructed
        let _policy_force = IngestPolicy::Force;
        let _policy_conflict = IngestPolicy::ConflictAware;

        // Verify BatchIngestItemResult variants can be constructed
        let _added = BatchIngestItemResult::Added {
            id: "test-id".to_string(),
        };
        let _conflicts = BatchIngestItemResult::Conflicts {
            proposed: "test".to_string(),
            conflicts: vec![],
        };
        let _error = BatchIngestItemResult::Error {
            message: "error".to_string(),
        };

        // Verify MemoryStore has batch_ingest method exists (compilation check)
        // Note: We don't actually run it since that would require downloading models
        // This test is just to satisfy dead_code analysis
        assert!(IngestPolicy::Force == IngestPolicy::Force);
    }

    #[test]
    fn test_cli_parse_with_json() {
        let cli = Cli::parse_from(["vipune", "--json", "add", "test"]);
        assert!(cli.json);
    }

    #[test]
    fn test_cli_parse_with_project() {
        let cli = Cli::parse_from(["vipune", "-p", "my-project", "add", "test"]);
        assert_eq!(cli.project, Some("my-project".to_string()));
    }

    #[test]
    fn test_cli_parse_search() {
        let cli = Cli::parse_from(["vipune", "search", "query", "--limit", "10"]);
        matches!(
            cli.command,
            Commands::Search {
                query,
                limit: 10,
                ..
            } if query == "query"
        );
    }

    #[test]
    fn test_cli_parse_get() {
        let cli = Cli::parse_from(["vipune", "get", "memory-id"]);
        matches!(cli.command, Commands::Get { id, no_touch: _ } if id == "memory-id");
    }

    #[test]
    fn test_cli_parse_list() {
        let cli = Cli::parse_from(["vipune", "list"]);
        matches!(cli.command, Commands::List { .. });
    }

    #[test]
    fn test_cli_parse_delete() {
        let cli = Cli::parse_from(["vipune", "delete", "memory-id"]);
        matches!(cli.command, Commands::Delete { id } if id == "memory-id");
    }

    #[test]
    fn test_cli_parse_update() {
        // Update with text only
        let cli = Cli::parse_from(["vipune", "update", "memory-id", "--text", "new content"]);
        matches!(
            cli.command,
            Commands::Update { id, text, metadata, memory_type, status, importance }
            if id == "memory-id" && text == Some("new content".to_string()) && metadata.is_none() && memory_type.is_none() && status.is_none() && importance.is_none()
        );

        // Update with metadata only
        let cli = Cli::parse_from(["vipune", "update", "memory-id", "-m", r#"{"tag": "new"}"#]);
        matches!(
            cli.command,
            Commands::Update { id, text, metadata, memory_type, status, importance }
            if id == "memory-id" && text.is_none() && metadata == Some(r#"{"tag": "new"}"#.to_string()) && memory_type.is_none() && status.is_none() && importance.is_none()
        );

        // Update with both
        let cli = Cli::parse_from([
            "vipune",
            "update",
            "memory-id",
            "-t",
            "new",
            "-m",
            r#"{"key":"val"}"#,
        ]);
        matches!(
            cli.command,
            Commands::Update { id, text, metadata, memory_type, status, importance }
            if id == "memory-id" && text == Some("new".to_string()) && metadata == Some(r#"{"key":"val"}"#.to_string()) && memory_type.is_none() && status.is_none() && importance.is_none()
        );
    }

    #[test]
    fn test_cli_parse_version() {
        let cli = Cli::parse_from(["vipune", "version"]);
        matches!(cli.command, Commands::Version);
    }

    #[test]
    fn test_cli_parse_validate() {
        let cli = Cli::parse_from(["vipune", "validate", "test text"]);
        matches!(
            cli.command,
            Commands::Validate { text } if text == "test text"
        );
    }

    #[test]
    fn test_cli_parse_with_db_path() {
        let cli = Cli::parse_from(["vipune", "--db-path", "/custom/path.db", "add", "test"]);
        assert_eq!(cli.db_path, Some("/custom/path.db".to_string()));
    }

    #[test]
    fn test_cli_parse_search_with_recency() {
        let cli = Cli::parse_from(["vipune", "search", "query", "--recency", "0.5"]);
        matches!(
            cli.command,
            Commands::Search {
                query,
                recency: Some(0.5),
                ..
            } if query == "query"
        );
    }

    #[test]
    fn test_cli_parse_search_without_recency() {
        let cli = Cli::parse_from(["vipune", "search", "query"]);
        matches!(
            cli.command,
            Commands::Search {
                query,
                recency: None,
                ..
            } if query == "query"
        );
    }

    #[test]
    fn test_cli_parse_search_with_hybrid() {
        let cli = Cli::parse_from(["vipune", "search", "query", "--hybrid"]);
        matches!(
            cli.command,
            Commands::Search {
                query,
                hybrid: true,
                ..
            } if query == "query"
        );
    }

    #[test]
    fn test_cli_parse_search_without_hybrid() {
        let cli = Cli::parse_from(["vipune", "search", "query"]);
        matches!(
            cli.command,
            Commands::Search {
                query,
                hybrid: false,
                ..
            } if query == "query"
        );
    }

    #[test]
    fn test_cli_parse_search_with_hybrid_and_recency() {
        let cli = Cli::parse_from(["vipune", "search", "query", "--hybrid", "--recency", "0.5"]);
        matches!(
            cli.command,
            Commands::Search {
                query,
                hybrid: true,
                recency: Some(0.5),
                ..
            } if query == "query"
        );
    }

    // Exercise MemoryStore::batch_ingest to eliminate dead_code warnings
    #[test]
    fn test_batch_ingest_integration_compiles() {
        let mut store = MemoryStore::test_store();

        // Test with empty batch
        let result = store.batch_ingest("test-project", vec![], IngestPolicy::Force);
        assert!(result.is_ok());
        assert_eq!(result.unwrap().results.len(), 0);
    }

    // ── project merge CLI parse tests ──

    #[test]
    fn test_cli_parse_project_merge() {
        let cli = Cli::parse_from(["vipune", "project", "merge", "old-id", "new-id"]);
        if let Commands::Project { command } = cli.command {
            let commands::ProjectCommands::Merge { from, to } = command;
            assert_eq!(from, "old-id");
            assert_eq!(to, "new-id");
        } else {
            panic!("Expected Project subcommand");
        }
    }

    #[test]
    fn test_cli_parse_project_merge_with_json() {
        let cli = Cli::parse_from(["vipune", "--json", "project", "merge", "a", "b"]);
        assert!(cli.json);
        matches!(cli.command, Commands::Project { .. });
    }

    #[test]
    fn test_cli_parse_project_merge_with_db_path() {
        let cli = Cli::parse_from([
            "vipune",
            "--db-path",
            "/tmp/test.db",
            "project",
            "merge",
            "x",
            "y",
        ]);
        assert_eq!(cli.db_path, Some("/tmp/test.db".to_string()));
        matches!(cli.command, Commands::Project { .. });
    }

    #[test]
    fn test_cli_parse_project_subcommand_missing_fails() {
        let result = Cli::try_parse_from(["vipune", "project"]);
        assert!(result.is_err());
    }

    #[test]
    fn test_cli_parse_project_merge_missing_args_fails() {
        let result = Cli::try_parse_from(["vipune", "project", "merge", "only-from"]);
        assert!(result.is_err());
    }

    // ── usage-error exit code (issue #177) ──
    //
    // clap's default usage-error exit code (2) collides with vipune's
    // documented semantic exit code 2 ("Conflicts detected"). `main()`
    // overrides it to 64 (sysexits EX_USAGE) via `parse_exit_from(args, 64)`.
    //
    // The override lives in `main()`'s `try_parse` arm, which calls
    // `process::exit` directly, so a unit test cannot observe the exit code
    // itself without terminating the test process. What we can pin in-process:
    // clap reports usage errors (typo'd flag, missing subcommand) as parse
    // errors routed to stderr, and help/version as stdout successes — the
    // exact split the override branches on. The 64 exit code itself is
    // verified by the issue's reproduction steps against the built binary.
    #[test]
    fn test_clap_usage_errors_fail_parse_to_stderr() {
        // `unwrap_err` needs the `Ok` variant to be `Debug`, so bind the
        // `Err` from the `Result` directly (no `Cli` `Debug` impl needed).
        let Err(error) = Cli::try_parse_from(["vipune", "add", "x", "--memory-typo"]) else {
            panic!("typo'd flag should be a parse error");
        };
        assert!(
            error.use_stderr(),
            "typo'd flag should be routed to stderr (and exit with EX_USAGE in main)"
        );

        let Err(error) = Cli::try_parse_from(["vipune"]) else {
            panic!("missing subcommand should be a parse error");
        };
        assert!(
            error.use_stderr(),
            "missing subcommand should be routed to stderr (and exit with EX_USAGE in main)"
        );
    }

    #[test]
    fn test_clap_help_is_stdout_path() {
        // `--help` short-circuits `try_parse` with a `DisplayHelp` error. It
        // is the only error kind routed to stdout (and exit 0) in `main()` —
        // everything else must stay on the stderr / EX_USAGE path.
        let Err(error) = Cli::try_parse_from(["vipune", "--help"]) else {
            panic!("--help should short-circuit as a display-help error");
        };
        assert!(
            !error.use_stderr(),
            "--help must be routed to stdout (and exit 0 in main), not stderr"
        );
    }

    // ── doctor --projects CLI parse tests ──

    #[test]
    fn test_cli_parse_doctor_projects() {
        let cli = Cli::parse_from(["vipune", "doctor", "--projects"]);
        if let Commands::Doctor {
            embeddings: false,
            projects: true,
            fts: false,
            project: None,
            repair: false,
        } = cli.command
        {
        } else {
            panic!("Expected Doctor with --projects flag");
        }
    }

    #[test]
    fn test_cli_parse_doctor_embeddings() {
        let cli = Cli::parse_from(["vipune", "doctor", "--embeddings"]);
        if let Commands::Doctor {
            embeddings: true,
            projects: false,
            fts: false,
            project: None,
            repair: false,
        } = cli.command
        {
        } else {
            panic!("Expected Doctor with --embeddings flag");
        }
    }

    #[test]
    fn test_cli_parse_doctor_fts() {
        let cli = Cli::parse_from(["vipune", "doctor", "--fts"]);
        if let Commands::Doctor {
            embeddings: false,
            projects: false,
            fts: true,
            project: None,
            repair: false,
        } = cli.command
        {
        } else {
            panic!("Expected Doctor with --fts flag");
        }
    }

    #[test]
    fn test_cli_parse_doctor_fts_with_p() {
        let cli = Cli::parse_from(["vipune", "doctor", "--fts", "-p", "my-proj"]);
        if let Commands::Doctor {
            embeddings: _,
            projects: _,
            fts: true,
            project: Some(ref p),
            repair: false,
        } = cli.command
        {
            assert_eq!(p, "my-proj");
        } else {
            panic!("Expected Doctor with --fts and -p flags");
        }
    }

    #[test]
    fn test_cli_parse_doctor_fts_and_embeddings_errors() {
        // Two doctor-mode flags → parse error via the ArgGroup (multiple=false).
        let result = Cli::try_parse_from(["vipune", "doctor", "--fts", "--embeddings"]);
        assert!(
            result.is_err(),
            "doctor --fts --embeddings should fail at parse time"
        );
    }

    #[test]
    fn test_cli_parse_doctor_fts_and_projects_errors() {
        let result = Cli::try_parse_from(["vipune", "doctor", "--fts", "--projects"]);
        assert!(
            result.is_err(),
            "doctor --fts --projects should fail at parse time"
        );
    }

    #[test]
    fn test_cli_parse_doctor_repair_alone_errors() {
        // --repair is a plain bool modifier OUTSIDE the ArgGroup; it cannot satisfy
        // the required group, so `doctor --repair` alone is a parse error.
        let result = Cli::try_parse_from(["vipune", "doctor", "--repair"]);
        assert!(
            result.is_err(),
            "doctor --repair alone should fail at parse time (no doctor-mode flag)"
        )
    }

    #[test]
    fn test_cli_parse_doctor_fts_with_repair_parses() {
        let cli = Cli::parse_from(["vipune", "doctor", "--fts", "--repair"]);
        if let Commands::Doctor {
            embeddings: false,
            projects: false,
            fts: true,
            project: None,
            repair: true,
        } = cli.command
        {
        } else {
            panic!("Expected Doctor with --fts --repair");
        }
    }

    #[test]
    fn test_cli_parse_doctor_projects_with_p() {
        let cli = Cli::parse_from(["vipune", "doctor", "--projects", "-p", "my-proj"]);
        if let Commands::Doctor {
            embeddings: _,
            projects: true,
            fts: _,
            project: Some(ref p),
            repair: _,
        } = cli.command
        {
            assert_eq!(p, "my-proj");
        } else {
            panic!("Expected Doctor with --projects and -p flags");
        }
    }

    #[test]
    fn test_cli_parse_doctor_both_flags_errors() {
        let result = Cli::try_parse_from(["vipune", "doctor", "--embeddings", "--projects"]);
        assert!(
            result.is_err(),
            "doctor --embeddings --projects should fail at parse or execute time"
        );
    }

    #[test]
    fn test_cli_parse_doctor_neither_flag_errors() {
        let result = Cli::try_parse_from(["vipune", "doctor"]);
        // With clap ArgGroup (required, multiple=false), parse fails when no doctor-mode flag is given.
        assert!(
            result.is_err(),
            "doctor without a doctor-mode flag should fail at parse time"
        );
    }

    // ── backup CLI parse tests ──

    #[test]
    fn test_cli_parse_backup() {
        let cli = Cli::parse_from(["vipune", "backup"]);
        matches!(cli.command, Commands::Backup { output: None });
    }

    #[test]
    fn test_cli_parse_backup_with_output() {
        let cli = Cli::parse_from(["vipune", "backup", "--output", "/tmp/backup.db"]);
        matches!(
            cli.command,
            Commands::Backup {
                output: Some(p)
            } if p.to_string_lossy() == "/tmp/backup.db"
        );
    }

    #[test]
    fn test_cli_parse_backup_with_json() {
        let cli = Cli::parse_from(["vipune", "--json", "backup"]);
        assert!(cli.json);
        matches!(cli.command, Commands::Backup { .. });
    }

    #[test]
    fn test_cli_parse_backup_with_db_path() {
        let cli = Cli::parse_from(["vipune", "--db-path", "/tmp/seeded.db", "backup"]);
        assert_eq!(cli.db_path, Some("/tmp/seeded.db".to_string()));
        matches!(cli.command, Commands::Backup { .. });
    }

    #[test]
    fn test_cli_parse_doctor_projects_with_json() {
        let cli = Cli::parse_from(["vipune", "--json", "doctor", "--projects"]);
        assert!(cli.json);
        matches!(cli.command, Commands::Doctor { .. });
    }

    // ── export CLI parse tests ──

    #[test]
    fn test_cli_parse_export() {
        let cli = Cli::parse_from(["vipune", "export", "/tmp/out.jsonl"]);
        matches!(
            cli.command,
            Commands::Export {
                ref output_path
            } if output_path == "/tmp/out.jsonl"
        );
    }

    #[test]
    fn test_cli_parse_export_with_json() {
        let cli = Cli::parse_from(["vipune", "--json", "export", "out.jsonl"]);
        assert!(cli.json);
        matches!(cli.command, Commands::Export { .. });
    }

    #[test]
    fn test_cli_parse_export_with_db_path() {
        let cli = Cli::parse_from([
            "vipune",
            "--db-path",
            "/tmp/seeded.db",
            "export",
            "out.jsonl",
        ]);
        assert_eq!(cli.db_path, Some("/tmp/seeded.db".to_string()));
        matches!(cli.command, Commands::Export { .. });
    }

    #[test]
    fn test_cli_parse_export_with_stray_project_parses_but_is_ignored() {
        // The global --project flag parses; the handler ignores it (with a
        // stderr warning) because export is cross-project by contract.
        let cli = Cli::parse_from(["vipune", "-p", "my-proj", "export", "out.jsonl"]);
        assert_eq!(cli.project, Some("my-proj".to_string()));
        matches!(cli.command, Commands::Export { .. });
    }

    #[test]
    fn test_cli_parse_export_missing_output_path_fails() {
        let result = Cli::try_parse_from(["vipune", "export"]);
        assert!(result.is_err());
    }

    // ── import CLI parse tests (issue #195) ──

    #[test]
    fn test_cli_parse_import_with_source() {
        let cli = Cli::parse_from(["vipune", "import", "/tmp/export.jsonl"]);
        if let Commands::Import { source } = cli.command {
            assert_eq!(source, Some("/tmp/export.jsonl".to_string()));
        } else {
            panic!("Expected Import subcommand");
        }
    }

    #[test]
    fn test_cli_parse_import_stdin() {
        let cli = Cli::parse_from(["vipune", "import", "-"]);
        if let Commands::Import { source } = cli.command {
            assert_eq!(source, Some("-".to_string()));
        } else {
            panic!("Expected Import subcommand");
        }
    }

    #[test]
    fn test_cli_parse_import_no_source_defaults_to_stdin() {
        let cli = Cli::parse_from(["vipune", "import"]);
        if let Commands::Import { source } = cli.command {
            assert!(source.is_none(), "no source should default to stdin");
        } else {
            panic!("Expected Import subcommand");
        }
    }

    #[test]
    fn test_cli_parse_import_with_json() {
        let cli = Cli::parse_from(["vipune", "--json", "import", "-"]);
        assert!(cli.json);
        matches!(cli.command, Commands::Import { .. });
    }

    #[test]
    fn test_cli_parse_import_with_db_path() {
        let cli = Cli::parse_from(["vipune", "--db-path", "/tmp/test.db", "import", "-"]);
        assert_eq!(cli.db_path, Some("/tmp/test.db".to_string()));
        matches!(cli.command, Commands::Import { .. });
    }

    #[test]
    fn test_cli_parse_import_with_project_flag_parses_but_is_ignored() {
        // --project is a global flag that parses, but import ignores it (with a
        // stderr warning at execute time). Parse must succeed.
        let cli = Cli::parse_from(["vipune", "--project", "my-proj", "import", "-"]);
        assert_eq!(cli.project, Some("my-proj".to_string()));
        matches!(cli.command, Commands::Import { .. });
    }

    // ── hook CLI parse tests (issue #191) ──

    #[test]
    fn test_cli_parse_hook_install() {
        let cli = Cli::parse_from(["vipune", "hook", "install"]);
        if let Commands::Hook { command } = cli.command {
            matches!(command, commands::HookCommands::Install);
        } else {
            panic!("Expected Hook subcommand");
        }
    }

    #[test]
    fn test_cli_parse_hook_uninstall() {
        let cli = Cli::parse_from(["vipune", "hook", "uninstall"]);
        if let Commands::Hook { command } = cli.command {
            matches!(command, commands::HookCommands::Uninstall);
        } else {
            panic!("Expected Hook subcommand");
        }
    }

    #[test]
    fn test_cli_parse_hook_session_start() {
        let cli = Cli::parse_from(["vipune", "hook", "session-start"]);
        if let Commands::Hook { command } = cli.command {
            matches!(command, commands::HookCommands::SessionStart);
        } else {
            panic!("Expected Hook subcommand");
        }
    }

    #[test]
    fn test_cli_parse_hook_user_prompt_submit() {
        let cli = Cli::parse_from(["vipune", "hook", "user-prompt-submit"]);
        if let Commands::Hook { command } = cli.command {
            matches!(command, commands::HookCommands::UserPromptSubmit);
        } else {
            panic!("Expected Hook subcommand");
        }
    }

    #[test]
    fn test_cli_parse_hook_pre_tool_use() {
        let cli = Cli::parse_from(["vipune", "hook", "pre-tool-use"]);
        if let Commands::Hook { command } = cli.command {
            matches!(command, commands::HookCommands::PreToolUse);
        } else {
            panic!("Expected Hook subcommand");
        }
    }

    #[test]
    fn test_cli_parse_hook_post_tool_use() {
        let cli = Cli::parse_from(["vipune", "hook", "post-tool-use"]);
        if let Commands::Hook { command } = cli.command {
            matches!(command, commands::HookCommands::PostToolUse);
        } else {
            panic!("Expected Hook subcommand");
        }
    }

    #[test]
    fn test_cli_parse_hook_pre_compact() {
        let cli = Cli::parse_from(["vipune", "hook", "pre-compact"]);
        if let Commands::Hook { command } = cli.command {
            matches!(command, commands::HookCommands::PreCompact);
        } else {
            panic!("Expected Hook subcommand");
        }
    }

    #[test]
    fn test_cli_parse_hook_missing_subcommand_fails() {
        let result = Cli::try_parse_from(["vipune", "hook"]);
        assert!(
            result.is_err(),
            "hook without subcommand should fail at parse time"
        );
    }

    #[test]
    fn test_cli_parse_hook_with_db_path() {
        let cli = Cli::parse_from(["vipune", "--db-path", "/tmp/test.db", "hook", "install"]);
        assert_eq!(cli.db_path, Some("/tmp/test.db".to_string()));
        matches!(cli.command, Commands::Hook { .. });
    }
}