vil_validate 0.2.0

VIL validation passes (stub — masa depan: layout/ownership/boundary legality)
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105

// =============================================================================
// vil_validate::layout — Layout Legality Pass
// =============================================================================

use vil_ir::core::WorkflowIR;
use vil_types::{LayoutProfile, TransferMode};

use crate::traits::{Diagnostic, ValidationPass, ValidationReport};

pub struct LayoutLegalityPass;

impl ValidationPass for LayoutLegalityPass {
    fn name(&self) -> &'static str {
        "LayoutLegalityPass"
    }

    fn run(&self, ir: &WorkflowIR) -> ValidationReport {
        let mut report = ValidationReport::new();

        // 1. Check existing routes for zero-copy legality (Original check)
        for route in &ir.routes {
            let iface_name = match ir.processes.get(&route.from_process) {
                Some(p) => &p.interface_name,
                None => {
                    report.push(Diagnostic::error(
                        "E-LAYOUT-01",
                        format!("Process not found: {}", route.from_process),
                        "Route Validation",
                    ));
                    continue;
                }
            };

            let port = match ir
                .interfaces
                .get(iface_name)
                .and_then(|i| i.ports.get(&route.from_port))
            {
                Some(p) => p,
                None => continue,
            };

            let msg = match ir.messages.get(&port.message_name) {
                Some(m) => m,
                None => continue,
            };

            let is_zero_copy_transfer = matches!(
                route.transfer_mode,
                TransferMode::LoanWrite
                    | TransferMode::LoanRead
                    | TransferMode::PublishOffset
                    | TransferMode::ShareRead
            );

            if msg.layout == LayoutProfile::External && is_zero_copy_transfer {
                report.push(Diagnostic::error(
                    "E-LAYOUT-02",
                    format!(
                        "Message '{}' has External layout, but route uses zero-copy transfer {:?}",
                        msg.name, route.transfer_mode
                    ),
                    format!("Route {} -> {}", route.from_process, route.to_process),
                ));
            }
        }

        // 2. Deep Field Validation (Phase 1 Goal)
        for msg in ir.messages.values() {
            if msg.layout == LayoutProfile::External {
                continue; // External layout allows anything
            }

            for field in &msg.fields {
                if !is_type_vasi_compliant(&field.ty) {
                    report.push(Diagnostic::error(
                        "E-LAYOUT-03",
                        format!(
                            "Message '{}' field '{}' has non-VASI type '{:?}'. Only POD or VRef/VSlice allowed in shared memory.",
                            msg.name, field.name, field.ty
                        ),
                        format!("Message Definition: {}", msg.name),
                    ));
                }
            }
        }

        report
    }
}

pub fn is_type_vasi_compliant(ty: &vil_ir::core::TypeRefIR) -> bool {
    use vil_ir::core::TypeRefIR;
    match ty {
        TypeRefIR::Primitive(_) => true,
        TypeRefIR::VRef(_) => true,
        TypeRefIR::VSlice(_) => true,
        TypeRefIR::Named(_) => true, // We assume other named VIL messages are also checked
        TypeRefIR::Unknown(name) => {
            // Dangerous types known to be non-VASI
            let forbidden = ["String", "Vec", "Box", "HashMap", "Arc", "Rc"];
            !forbidden.iter().any(|&f| name.contains(f))
        }
    }
}