vigil-firewall 0.1.4

Fail-closed effect firewall for Vigil — policy engine, approval queue, PII scanner, OAuth scope allowlist
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
//! EffectExtractor trait + 7 个内置实装。
//!
//! 每个 extractor 负责把 `ToolInvocation.args` 中属于自己领域的结构化字段解出,
//! 并合并到 `EffectVector`。多个 extractor 的结果以**合并**的方式叠加 —— 一次
//! tool call 可能同时触发 fs / net / secret / comm 等多种效应。

use std::path::{Path, PathBuf};

use once_cell::sync::Lazy;
use regex::Regex;
use serde_json::Value;
use url::Url;
use vigil_types::{EffectKind, EffectVector, ToolInvocation};

/// 抽取器统一接口。
pub trait EffectExtractor: Send + Sync {
    /// 人读名称,用于审计与日志。
    fn name(&self) -> &'static str;
    /// 从一次调用中抽取效应,叠加到 `out`。**不得**清空已有字段。
    fn extract(&self, call: &ToolInvocation, out: &mut EffectVector);
}

/// Path 抽取器 —— 处理文件读写。
///
/// 输入形态(按优先级查找):
/// - `args.path` 字符串
/// - `args.paths` 字符串数组
/// - `args.src` / `args.dst` / `args.file` / `args.target` 等常见别名
///
/// 写/读由 tool_name 启发或 `args.mode` 决定:
/// - tool_name 含 `write` / `create` / `edit` / `patch` / `delete` / `unlink` / `rm` → 写
/// - 默认(或含 `read` / `cat` / `show` / `list`)→ 读
///
/// 规范化:相对路径基于 `project_roots[0]`(若提供),绝对路径走 `dunce::canonicalize`
/// 尝试真实解析;解析失败(文件不存在时)至少做 `..` 展开与 POSIX 化。
#[derive(Debug)]
pub struct PathExtractor {
    /// 用作相对路径基准与跨平台 canonicalization 的参考根。
    pub project_roots: Vec<PathBuf>,
}

impl PathExtractor {
    /// 构造。`project_roots` 可空(此时所有相对路径被标为"无法定位",仍然会被
    /// 下游策略的 Outside 条件视为越界)。
    pub fn new(project_roots: Vec<PathBuf>) -> Self {
        Self { project_roots }
    }

    fn collect_paths(&self, args: &Value) -> Vec<String> {
        let mut out = Vec::new();
        const KEYS: &[&str] = &[
            "path",
            "paths",
            "file",
            "files",
            "src",
            "source",
            "dst",
            "destination",
            "target",
            "input",
            "output",
        ];
        for k in KEYS {
            match args.get(*k) {
                Some(Value::String(s)) => out.push(s.clone()),
                Some(Value::Array(a)) => {
                    for v in a {
                        if let Value::String(s) = v {
                            out.push(s.clone());
                        }
                    }
                }
                _ => {}
            }
        }
        out
    }

    fn canonicalize(&self, raw: &str) -> String {
        let p = Path::new(raw);
        let abs: PathBuf = if p.is_absolute() {
            p.to_path_buf()
        } else if let Some(root) = self.project_roots.first() {
            root.join(p)
        } else {
            p.to_path_buf()
        };
        // 先尝试真实解析 —— 若文件存在,解出符号链接 / `..`;不存在时退回手工 `..` 展开
        let normalized = dunce::canonicalize(&abs).unwrap_or_else(|_| manual_normalize(&abs));
        to_posix(&normalized)
    }
}

/// 判定一次调用是读还是写(启发式)。
fn is_write_call(tool_name: &str) -> bool {
    let lower = tool_name.to_ascii_lowercase();
    for kw in [
        "write", "create", "edit", "patch", "delete", "unlink", "rm", "move", "rename", "append",
        "chmod", "chown", "mkdir",
    ] {
        if lower.contains(kw) {
            return true;
        }
    }
    false
}

impl EffectExtractor for PathExtractor {
    fn name(&self) -> &'static str {
        "PathExtractor"
    }

    fn extract(&self, call: &ToolInvocation, out: &mut EffectVector) {
        let paths = self.collect_paths(&call.args);
        if paths.is_empty() {
            return;
        }
        let norm: Vec<String> = paths.iter().map(|p| self.canonicalize(p)).collect();
        if is_write_call(&call.tool_name) {
            out.effects.push(EffectKind::FsWrite);
            out.paths_write.extend(norm);
        } else {
            out.effects.push(EffectKind::FsRead);
            out.paths_read.extend(norm);
        }
    }
}

/// URL 抽取器 —— 网络出站。
#[derive(Debug)]
pub struct UrlExtractor;

impl EffectExtractor for UrlExtractor {
    fn name(&self) -> &'static str {
        "UrlExtractor"
    }

    fn extract(&self, call: &ToolInvocation, out: &mut EffectVector) {
        let mut hosts = Vec::new();
        for k in ["url", "endpoint", "uri"] {
            if let Some(Value::String(s)) = call.args.get(k) {
                if let Ok(u) = Url::parse(s) {
                    if let Some(h) = u.host_str() {
                        hosts.push(h.to_ascii_lowercase());
                    }
                }
            }
        }
        // 也看 urls/[]
        if let Some(Value::Array(a)) = call.args.get("urls") {
            for v in a {
                if let Value::String(s) = v {
                    if let Ok(u) = Url::parse(s) {
                        if let Some(h) = u.host_str() {
                            hosts.push(h.to_ascii_lowercase());
                        }
                    }
                }
            }
        }
        if !hosts.is_empty() {
            out.effects.push(EffectKind::NetOutbound);
            out.network_hosts.extend(hosts);
        }
    }
}

/// SQL 抽取器 —— 识别破坏性语句。
///
/// 不做完整 SQL 解析,只做**关键词**检测。`args.sql` / `args.query` / `args.statement`
/// 中若含 `DELETE`、`DROP`、`TRUNCATE`、`ALTER`、`UPDATE` 任一关键字(且不是 `SELECT`
/// 子句),置 `DbWrite + destructive`。
#[derive(Debug)]
pub struct SqlExtractor;

static DESTRUCTIVE_SQL: Lazy<Regex> = Lazy::new(|| {
    // 行首或 ';' 后的首词,排除在 SELECT ... FROM 子查询内
    Regex::new(r"(?i)\b(DELETE|DROP|TRUNCATE|ALTER|UPDATE|REPLACE)\b").expect("regex")
});

static READ_ONLY_SQL: Lazy<Regex> =
    Lazy::new(|| Regex::new(r"(?i)^\s*(SELECT|SHOW|DESCRIBE|EXPLAIN|WITH)\b").expect("regex"));

impl EffectExtractor for SqlExtractor {
    fn name(&self) -> &'static str {
        "SqlExtractor"
    }

    fn extract(&self, call: &ToolInvocation, out: &mut EffectVector) {
        for k in ["sql", "query", "statement"] {
            if let Some(Value::String(s)) = call.args.get(k) {
                if READ_ONLY_SQL.is_match(s) && !DESTRUCTIVE_SQL.is_match(s) {
                    out.effects.push(EffectKind::DbRead);
                } else if DESTRUCTIVE_SQL.is_match(s) {
                    out.effects.push(EffectKind::DbWrite);
                    out.destructive = true;
                } else {
                    // 非显式识别的 SQL:保守视为 DbWrite 不破坏
                    out.effects.push(EffectKind::DbWrite);
                }
            }
        }
    }
}

/// Shell 抽取器 —— `argv` 与命令行字符串,识别破坏性二进制与保护路径命中。
///
/// 输入:
/// - `args.argv`: `Vec<String>`(首选)
/// - `args.command`: `String`(POSIX 字符串,由 shlex 分词)
///
/// 行为:
/// - 识别到破坏性二进制 → `destructive=true` + push `ExecNative`
/// - 识别 shell metacharacter → `requires_shell=true`,也置 `destructive=true`
///   (ADR 0003 §D2:模糊路径 fail-closed)
/// - 否则 push `ExecNative`(但不 destructive)
#[derive(Debug)]
pub struct ShellExtractor;

/// 破坏性二进制(按 argv[0] basename 比较,去扩展名前的形式)。
const DESTRUCTIVE_BINARIES: &[&str] = &[
    "rm", "rmdir", "shred", "mkfs", "fdisk", "format", "del", "dd", "srm", "erase",
];

/// **包装 shell** 类二进制 —— 当它们作为 argv[0] 且携带 "-c" 类参数时,
/// 我们无法在不展开整条 shell 脚本的前提下安全判定,**一律 fail-closed destructive**。
/// 与 ADR 0003 §D2 "不做完整 shell 解析" 一致。
const SHELL_WRAPPERS: &[&str] = &[
    "sh",
    "bash",
    "zsh",
    "ksh",
    "dash",
    "fish",
    "cmd",
    "cmd.exe",
    "powershell",
    "powershell.exe",
    "pwsh",
    "pwsh.exe",
];

/// wrapper 常见的"后跟字符串即执行"选项。出现这些中的任何一个即 fail-closed。
const SHELL_EVAL_FLAGS: &[&str] = &["-c", "-lc", "-Command", "/c", "/C", "-Cmd", "--command"];

/// 高危路径前缀(命中即 destructive)。
const PROTECTED_PATHS: &[&str] = &[
    "/",
    "/etc",
    "/usr",
    "/var",
    "/bin",
    "/sbin",
    "/boot",
    "/sys",
    "/proc",
    "~",
    "~/.ssh",
    "~/.config",
    "~/.aws",
    "~/.docker",
    "C:\\",
    "C:\\Windows",
    "%SystemRoot%",
    "%USERPROFILE%\\.ssh",
];

const SHELL_METACHARS: &[&str] = &[
    "&&", "||", "|", "&", ";", ">", ">>", "<", "<<", "$(", "`", "\\\n",
];

impl EffectExtractor for ShellExtractor {
    fn name(&self) -> &'static str {
        "ShellExtractor"
    }

    fn extract(&self, call: &ToolInvocation, out: &mut EffectVector) {
        // 提取 argv
        let argv: Vec<String> = if let Some(Value::Array(a)) = call.args.get("argv") {
            a.iter()
                .filter_map(|v| v.as_str().map(String::from))
                .collect()
        } else if let Some(Value::String(s)) = call.args.get("command") {
            // shlex 分词;分词失败按含 metachar 处理
            match shlex::split(s) {
                Some(v) if !v.is_empty() => v,
                _ => {
                    // 分词失败 → fail-closed
                    out.effects.push(EffectKind::ExecNative);
                    out.destructive = true;
                    return;
                }
            }
        } else {
            return;
        };

        if argv.is_empty() {
            return;
        }

        out.effects.push(EffectKind::ExecNative);

        // 1) 检查是否含 shell metachar(任何一处命中即 destructive)
        let full = argv.join(" ");
        let has_meta = SHELL_METACHARS.iter().any(|m| full.contains(m));

        // 2) wrapper + -c/-Command 形式的"嵌套 shell":一律 fail-closed
        //    (ADR 0003 §D2:"模糊 shell 一律 destructive")
        let bin_lower = basename(&argv[0]).to_ascii_lowercase();
        let strip_ext = |s: &str| -> String { s.strip_suffix(".exe").unwrap_or(s).to_string() };
        let bin_noexe = strip_ext(&bin_lower);
        let is_wrapper = SHELL_WRAPPERS
            .iter()
            .any(|w| strip_ext(w) == bin_noexe || *w == bin_lower);
        let has_eval_flag = argv
            .iter()
            .skip(1)
            .any(|a| SHELL_EVAL_FLAGS.iter().any(|f| a == f));
        // wrapper 后任何含空格的字符串参数也视作"嵌套脚本"(如 cmd 的 /c)
        let wrapper_with_script = is_wrapper
            && (has_eval_flag
                || argv
                    .iter()
                    .skip(1)
                    .any(|a| a.contains(' ') || a.contains('\n')));

        // 3) 检查破坏性二进制
        let is_destructive_bin = DESTRUCTIVE_BINARIES
            .iter()
            .any(|d| bin_noexe == *d || bin_lower == *d);
        let rm_dangerous =
            is_destructive_bin && argv.iter().any(|a| a == "-rf" || a == "-fr" || a == "-r");

        // 4) 检查保护路径
        let hits_protected = argv
            .iter()
            .any(|a| PROTECTED_PATHS.iter().any(|p| path_hits_protected(a, p)));

        if has_meta || wrapper_with_script || is_destructive_bin || rm_dangerous || hits_protected {
            out.destructive = true;
        }
    }
}

/// Email / comm 抽取器。
#[derive(Debug)]
pub struct EmailExtractor;

impl EffectExtractor for EmailExtractor {
    fn name(&self) -> &'static str {
        "EmailExtractor"
    }

    fn extract(&self, call: &ToolInvocation, out: &mut EffectVector) {
        let mut recipients = Vec::new();
        for k in ["to", "cc", "bcc", "recipients"] {
            match call.args.get(k) {
                Some(Value::String(s)) => recipients.push(s.clone()),
                Some(Value::Array(a)) => {
                    for v in a {
                        if let Value::String(s) = v {
                            recipients.push(s.clone());
                        }
                    }
                }
                _ => {}
            }
        }
        if !recipients.is_empty() {
            out.effects.push(EffectKind::CommSend);
            out.recipients.extend(recipients);
        }
    }
}

/// Secret ref 抽取器 —— 识别 `secret://...` 引用。
#[derive(Debug)]
pub struct SecretRefExtractor;

static SECRET_REF_RE: Lazy<Regex> =
    Lazy::new(|| Regex::new(r"secret://[A-Za-z0-9._\-/]+").expect("regex"));

impl EffectExtractor for SecretRefExtractor {
    fn name(&self) -> &'static str {
        "SecretRefExtractor"
    }

    fn extract(&self, call: &ToolInvocation, out: &mut EffectVector) {
        let s = call.args.to_string(); // 对整个 args JSON 扫描
        let mut refs = Vec::new();
        for m in SECRET_REF_RE.find_iter(&s) {
            refs.push(m.as_str().to_string());
        }
        if !refs.is_empty() {
            out.effects.push(EffectKind::SecretUse);
            out.secret_refs.extend(refs);
        }
    }
}

/// 浏览器动作抽取器。
#[derive(Debug)]
pub struct BrowserActionExtractor;

impl EffectExtractor for BrowserActionExtractor {
    fn name(&self) -> &'static str {
        "BrowserActionExtractor"
    }

    fn extract(&self, call: &ToolInvocation, out: &mut EffectVector) {
        // 输入形态:args.action = "submit"|"click"|...; args.origin = "https://..."
        let is_browser_tool = call.tool_name.to_ascii_lowercase().contains("browser");
        let action = call.args.get("action").and_then(Value::as_str);
        if is_browser_tool {
            match action {
                Some("submit") | Some("fill_form") | Some("post") => {
                    out.effects.push(EffectKind::BrowserSubmit);
                    if let Some(Value::String(origin)) = call.args.get("origin") {
                        if let Ok(u) = Url::parse(origin) {
                            if let Some(h) = u.host_str() {
                                out.network_hosts.push(h.to_ascii_lowercase());
                            }
                        }
                    }
                }
                _ => {}
            }
        }
    }
}

// ---------------- 辅助 ----------------

fn basename(p: &str) -> &str {
    // 不用 std::path::Path —— 要把 Windows `\` 和 POSIX `/` 都当分隔符
    let idx_slash = p.rfind('/').map(|i| i + 1).unwrap_or(0);
    let idx_back = p.rfind('\\').map(|i| i + 1).unwrap_or(0);
    let start = idx_slash.max(idx_back);
    &p[start..]
}

fn path_hits_protected(arg: &str, protected: &str) -> bool {
    // 简化匹配:arg 去掉引号后,与 protected 相等或以 protected + "/" 开头
    let a = arg.trim_matches(|c| c == '\'' || c == '"');
    let p = protected;
    a == p || a.starts_with(&format!("{}/", p)) || a.starts_with(&format!("{}\\", p))
}

fn manual_normalize(p: &Path) -> PathBuf {
    use std::path::Component::*;
    let mut out: Vec<std::path::Component> = Vec::new();
    for comp in p.components() {
        match comp {
            CurDir => {}
            ParentDir => {
                // 不允许越过 Prefix(Windows 盘符) / RootDir。
                // 之上的 `..` 视为 no-op:`/../x` → `/x`,对应 POSIX `realpath` 语义。
                match out.last() {
                    None | Some(Prefix(_)) | Some(RootDir) => {}
                    Some(ParentDir) => out.push(ParentDir), // 一串未解析的 ..,保留
                    _ => {
                        out.pop();
                    }
                }
            }
            _ => out.push(comp),
        }
    }
    if out.is_empty() {
        return PathBuf::from(".");
    }
    out.iter().collect()
}

fn to_posix(p: &Path) -> String {
    let s = p.to_string_lossy();
    // 剥除 Windows 长路径前缀
    let s = s.strip_prefix(r"\\?\").unwrap_or(&s);
    s.replace('\\', "/")
}

#[cfg(test)]
mod tests {
    use super::*;
    use serde_json::json;

    fn mk_call(tool: &str, args: Value) -> ToolInvocation {
        ToolInvocation {
            invocation_id: "t".into(),
            session_id: "s".into(),
            server_id: "srv".into(),
            tool_name: tool.into(),
            args,
            descriptor_hash: "hash".into(),
            requested_at: 0,
        }
    }

    #[test]
    fn path_extractor_write_vs_read() {
        let e = PathExtractor::new(vec![PathBuf::from("/proj")]);
        let mut ev = EffectVector::default();
        e.extract(
            &mk_call("fs_read_file", json!({"path": "src/main.rs"})),
            &mut ev,
        );
        assert!(ev.effects.contains(&EffectKind::FsRead));
        assert!(ev
            .paths_read
            .iter()
            .any(|p| p.ends_with("/proj/src/main.rs")));

        let mut ev = EffectVector::default();
        e.extract(
            &mk_call("fs_write_file", json!({"path": "README.md"})),
            &mut ev,
        );
        assert!(ev.effects.contains(&EffectKind::FsWrite));
        assert!(ev
            .paths_write
            .iter()
            .any(|p| p.ends_with("/proj/README.md")));
    }

    #[test]
    fn path_extractor_resolves_dot_dot() {
        let e = PathExtractor::new(vec![PathBuf::from("/proj")]);
        let mut ev = EffectVector::default();
        e.extract(
            &mk_call("fs_read_file", json!({"path": "../../etc/passwd"})),
            &mut ev,
        );
        assert!(ev.paths_read.iter().any(|p| p == "/etc/passwd"));
    }

    #[test]
    fn url_extractor_detects_host() {
        let mut ev = EffectVector::default();
        UrlExtractor.extract(
            &mk_call(
                "http_get",
                json!({"url": "https://api.github.com/users/me"}),
            ),
            &mut ev,
        );
        assert!(ev.effects.contains(&EffectKind::NetOutbound));
        assert_eq!(ev.network_hosts, vec!["api.github.com"]);
    }

    #[test]
    fn sql_destructive_vs_read() {
        let mut ev = EffectVector::default();
        SqlExtractor.extract(
            &mk_call("db_query", json!({"sql": "DELETE FROM users WHERE id=1"})),
            &mut ev,
        );
        assert!(ev.destructive);
        assert!(ev.effects.contains(&EffectKind::DbWrite));

        let mut ev = EffectVector::default();
        SqlExtractor.extract(
            &mk_call("db_query", json!({"sql": "SELECT * FROM t"})),
            &mut ev,
        );
        assert!(!ev.destructive);
        assert!(ev.effects.contains(&EffectKind::DbRead));
    }

    #[test]
    fn shell_rm_rf_is_destructive() {
        let mut ev = EffectVector::default();
        ShellExtractor.extract(
            &mk_call(
                "shell_run",
                json!({"argv": ["rm", "-rf", "/home/user/Downloads"]}),
            ),
            &mut ev,
        );
        assert!(ev.destructive);
        assert!(ev.effects.contains(&EffectKind::ExecNative));
    }

    #[test]
    fn shell_metacharacter_fails_closed() {
        let mut ev = EffectVector::default();
        ShellExtractor.extract(
            &mk_call("shell_run", json!({"command": "ls && rm -rf /"})),
            &mut ev,
        );
        assert!(
            ev.destructive,
            "shell metachar 必须 fail-closed 标 destructive"
        );
    }

    #[test]
    fn shell_protected_path_triggers() {
        let mut ev = EffectVector::default();
        ShellExtractor.extract(
            &mk_call("shell_run", json!({"argv": ["cat", "/etc/shadow"]})),
            &mut ev,
        );
        assert!(ev.destructive, "保护路径命中应标 destructive");
    }

    #[test]
    fn shell_safe_ls_not_destructive() {
        let mut ev = EffectVector::default();
        ShellExtractor.extract(
            &mk_call("shell_run", json!({"argv": ["ls", "-la"]})),
            &mut ev,
        );
        assert!(!ev.destructive);
        assert!(ev.effects.contains(&EffectKind::ExecNative));
    }

    #[test]
    fn email_extractor_collects_recipients() {
        let mut ev = EffectVector::default();
        EmailExtractor.extract(
            &mk_call(
                "send_email",
                json!({"to": "bob@example.com", "cc": ["alice@example.com"]}),
            ),
            &mut ev,
        );
        assert!(ev.effects.contains(&EffectKind::CommSend));
        assert_eq!(ev.recipients.len(), 2);
    }

    #[test]
    fn secret_ref_extractor_finds_alias() {
        let mut ev = EffectVector::default();
        SecretRefExtractor.extract(
            &mk_call(
                "github_create_issue",
                json!({"auth": "secret://github/repo-write", "title": "x"}),
            ),
            &mut ev,
        );
        assert!(ev.effects.contains(&EffectKind::SecretUse));
        assert_eq!(ev.secret_refs, vec!["secret://github/repo-write"]);
    }

    #[test]
    fn browser_submit_detected() {
        let mut ev = EffectVector::default();
        BrowserActionExtractor.extract(
            &mk_call(
                "browser_action",
                json!({"action": "submit", "origin": "https://chatgpt.com"}),
            ),
            &mut ev,
        );
        assert!(ev.effects.contains(&EffectKind::BrowserSubmit));
        assert_eq!(ev.network_hosts, vec!["chatgpt.com"]);
    }
}