vibesql-storage 0.2.0

Storage engine for vibesql SQL database
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
use std::sync::Arc;

use vibesql_types::{DataType, SqlValue};

use super::*;
use crate::page::PageManager;

#[test]
fn test_leaf_node_insert() {
    let mut leaf = LeafNode::new(1);

    assert!(leaf.insert(vec![SqlValue::Integer(10)], 0));
    assert!(leaf.insert(vec![SqlValue::Integer(5)], 1));
    assert!(leaf.insert(vec![SqlValue::Integer(15)], 2));

    // Check sorted order
    assert_eq!(leaf.entries.len(), 3);
    assert_eq!(leaf.entries[0].0[0], SqlValue::Integer(5));
    assert_eq!(leaf.entries[1].0[0], SqlValue::Integer(10));
    assert_eq!(leaf.entries[2].0[0], SqlValue::Integer(15));
}

#[test]
fn test_leaf_node_duplicate_insert() {
    let mut leaf = LeafNode::new(1);

    assert!(leaf.insert(vec![SqlValue::Integer(10)], 0));
    assert!(leaf.insert(vec![SqlValue::Integer(10)], 1)); // Duplicate now allowed

    // Should have 1 key with 2 row_ids
    assert_eq!(leaf.entries.len(), 1);
    assert_eq!(leaf.entries[0].1, vec![0, 1]);
}

#[test]
fn test_leaf_node_search() {
    let mut leaf = LeafNode::new(1);

    leaf.insert(vec![SqlValue::Integer(10)], 100);
    leaf.insert(vec![SqlValue::Integer(20)], 200);

    assert_eq!(leaf.search(&vec![SqlValue::Integer(10)]), Some(&vec![100]));
    assert_eq!(leaf.search(&vec![SqlValue::Integer(20)]), Some(&vec![200]));
    assert_eq!(leaf.search(&vec![SqlValue::Integer(15)]), None);
}

#[test]
fn test_leaf_node_delete() {
    let mut leaf = LeafNode::new(1);

    leaf.insert(vec![SqlValue::Integer(10)], 0);
    leaf.insert(vec![SqlValue::Integer(20)], 1);

    assert!(leaf.delete_all(&vec![SqlValue::Integer(10)]));
    assert!(!leaf.delete_all(&vec![SqlValue::Integer(10)])); // Already deleted

    assert_eq!(leaf.entries.len(), 1);
    assert_eq!(leaf.entries[0].0[0], SqlValue::Integer(20));
}

#[test]
fn test_leaf_node_split() {
    let mut leaf = LeafNode::new(1);

    // Insert 6 entries
    for i in 0..6 {
        leaf.insert(vec![SqlValue::Integer(i * 10)], i as usize);
    }

    let (middle_key, right_node) = leaf.split(2);

    // Left node should have first 3 entries
    assert_eq!(leaf.entries.len(), 3);
    assert_eq!(leaf.next_leaf, 2);

    // Right node should have last 3 entries
    assert_eq!(right_node.entries.len(), 3);
    assert_eq!(right_node.page_id, 2);

    // Middle key should be first key of right node
    assert_eq!(middle_key, vec![SqlValue::Integer(30)]);
}

#[test]
fn test_internal_node_find_child() {
    let mut node = InternalNode::new(1);

    node.keys =
        vec![vec![SqlValue::Integer(10)], vec![SqlValue::Integer(20)], vec![SqlValue::Integer(30)]];
    node.children = vec![2, 3, 4, 5];

    assert_eq!(node.find_child_index(&vec![SqlValue::Integer(5)]), 0);
    assert_eq!(node.find_child_index(&vec![SqlValue::Integer(10)]), 1);
    assert_eq!(node.find_child_index(&vec![SqlValue::Integer(15)]), 1);
    assert_eq!(node.find_child_index(&vec![SqlValue::Integer(25)]), 2);
    assert_eq!(node.find_child_index(&vec![SqlValue::Integer(35)]), 3);
}

#[test]
fn test_internal_node_insert_child() {
    let mut node = InternalNode::new(1);

    node.children.push(2); // Initial child

    node.insert_child(vec![SqlValue::Integer(10)], 3);
    node.insert_child(vec![SqlValue::Integer(5)], 4);
    node.insert_child(vec![SqlValue::Integer(15)], 5);

    // Check sorted order
    assert_eq!(node.keys.len(), 3);
    assert_eq!(node.children.len(), 4);
    assert_eq!(node.keys[0][0], SqlValue::Integer(5));
    assert_eq!(node.keys[1][0], SqlValue::Integer(10));
    assert_eq!(node.keys[2][0], SqlValue::Integer(15));
}

#[test]
fn test_internal_node_split() {
    let mut node = InternalNode::new(1);

    // Setup node with 5 keys and 6 children
    node.keys = vec![
        vec![SqlValue::Integer(10)],
        vec![SqlValue::Integer(20)],
        vec![SqlValue::Integer(30)],
        vec![SqlValue::Integer(40)],
        vec![SqlValue::Integer(50)],
    ];
    node.children = vec![2, 3, 4, 5, 6, 7];

    let (middle_key, right_node) = node.split(8);

    // Middle key should be 30
    assert_eq!(middle_key, vec![SqlValue::Integer(30)]);

    // Left node should have 2 keys and 3 children
    assert_eq!(node.keys.len(), 2);
    assert_eq!(node.children.len(), 3);
    assert_eq!(node.keys[0][0], SqlValue::Integer(10));
    assert_eq!(node.keys[1][0], SqlValue::Integer(20));

    // Right node should have 2 keys and 3 children
    assert_eq!(right_node.keys.len(), 2);
    assert_eq!(right_node.children.len(), 3);
    assert_eq!(right_node.keys[0][0], SqlValue::Integer(40));
    assert_eq!(right_node.keys[1][0], SqlValue::Integer(50));
}

#[test]
fn test_bulk_load_empty() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries = vec![];

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Empty index should have height 1 (just root leaf)
    assert_eq!(index.height(), 1);
}

#[test]
fn test_bulk_load_small() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries = vec![
        (vec![SqlValue::Integer(10)], 0),
        (vec![SqlValue::Integer(20)], 1),
        (vec![SqlValue::Integer(30)], 2),
        (vec![SqlValue::Integer(40)], 3),
        (vec![SqlValue::Integer(50)], 4),
    ];

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Small index should have height 1 (just root leaf)
    assert_eq!(index.height(), 1);

    // Verify we can read the root leaf
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();
    assert_eq!(root_leaf.entries.len(), 5);
    assert_eq!(root_leaf.entries[0].0, vec![SqlValue::Integer(10)]);
    assert_eq!(root_leaf.entries[4].0, vec![SqlValue::Integer(50)]);
}

#[test]
fn test_bulk_load_multi_column() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer, DataType::Varchar { max_length: Some(50) }];
    let sorted_entries = vec![
        (vec![SqlValue::Integer(1), SqlValue::Varchar(arcstr::ArcStr::from("Alice"))], 0),
        (vec![SqlValue::Integer(2), SqlValue::Varchar(arcstr::ArcStr::from("Bob"))], 1),
        (vec![SqlValue::Integer(3), SqlValue::Varchar(arcstr::ArcStr::from("Charlie"))], 2),
    ];

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Verify we can read the root leaf
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();
    assert_eq!(root_leaf.entries.len(), 3);
    assert_eq!(
        root_leaf.entries[0].0,
        vec![SqlValue::Integer(1), SqlValue::Varchar(arcstr::ArcStr::from("Alice"))]
    );
}

#[test]
fn test_bulk_load_large() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create 1000 sorted entries
    let sorted_entries: Vec<(Key, RowId)> =
        (0..1000).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager.clone()).unwrap();

    // Large index should have height > 1
    assert!(index.height() > 1, "Index with 1000 entries should have height > 1");

    // Verify we can load the index back from disk
    let loaded_index = BTreeIndex::load(page_manager).unwrap();
    assert_eq!(loaded_index.height(), index.height());
    assert_eq!(loaded_index.degree(), index.degree());
}

#[test]
fn test_insert_single_key() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert a single key
    let key = vec![SqlValue::Integer(42)];
    let row_id = 10;
    index.insert(key.clone(), row_id).unwrap();

    // Verify height is still 1 (root is leaf)
    assert_eq!(index.height(), 1);

    // Verify we can read the key back
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();
    assert_eq!(root_leaf.entries.len(), 1);
    assert_eq!(root_leaf.entries[0].0, key);
    assert_eq!(root_leaf.entries[0].1, vec![row_id]);
}

#[test]
fn test_insert_duplicate_key() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert first key
    let key = vec![SqlValue::Integer(42)];
    index.insert(key.clone(), 10).unwrap();

    // Insert duplicate - now allowed for non-unique indexes
    let result = index.insert(key.clone(), 20);
    assert!(result.is_ok());

    // Verify both row_ids are stored
    let row_ids = index.lookup(&key).unwrap();
    assert_eq!(row_ids, vec![10, 20]);
}

#[test]
fn test_insert_causes_leaf_split() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    let degree = index.degree();
    assert!(degree >= 5, "Degree should be at least 5");

    // Insert keys until we almost fill the root leaf (degree - 1 keys)
    for i in 0..(degree - 1) {
        let key = vec![SqlValue::Integer(i as i64 * 10)];
        index.insert(key, i).unwrap();
    }

    // Root should still be a leaf (height = 1)
    assert_eq!(index.height(), 1);

    // Insert one more key to reach capacity
    let key = vec![SqlValue::Integer((degree - 1) as i64 * 10)];
    index.insert(key, degree - 1).unwrap();

    // Now at capacity, insert one more to trigger split
    let key = vec![SqlValue::Integer(degree as i64 * 10)];
    index.insert(key, degree).unwrap();

    // Height should now be 2 (root is internal, with 2 leaf children)
    assert_eq!(index.height(), 2);

    // Root should be an internal node with 2 children
    let root = index.read_internal_node(index.root_page_id()).unwrap();
    assert_eq!(root.children.len(), 2);
    assert_eq!(root.keys.len(), 1);
}

#[test]
fn test_insert_maintains_order() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert keys in random order
    let keys = vec![50, 20, 80, 10, 30, 70, 90, 40, 60];
    for (i, &k) in keys.iter().enumerate() {
        let key = vec![SqlValue::Integer(k)];
        index.insert(key, i).unwrap();
    }

    // Verify all keys are in the tree by checking the leaf nodes
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();

    // Verify entries are sorted
    for i in 1..root_leaf.entries.len() {
        assert!(root_leaf.entries[i - 1].0 < root_leaf.entries[i].0, "Entries should be sorted");
    }
}

#[test]
fn test_insert_increases_height() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    let degree = index.degree();
    let initial_height = index.height();
    assert_eq!(initial_height, 1);

    // Insert enough keys to cause height increase
    // We need slightly more than degree keys to get to height 2
    // (degree keys fill the root, degree+1 causes split to height 2)
    let num_keys = degree + 1;

    for i in 0..num_keys {
        let key = vec![SqlValue::Integer(i as i64)];
        index.insert(key, i).unwrap();
    }

    // Height should have increased to 2
    assert_eq!(index.height(), 2, "Height should increase to 2 after inserting {} keys", num_keys);
}

#[test]
fn test_large_sequential_inserts() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert 1000 keys sequentially
    let num_keys = 1000;
    for i in 0..num_keys {
        let key = vec![SqlValue::Integer(i * 10)];
        let result = index.insert(key, i as usize);
        assert!(result.is_ok(), "Insert {} failed: {:?}", i, result);
    }

    // Verify tree properties
    let degree = index.degree();
    let height = index.height();

    // Height should be logarithmic in number of keys
    // For 1000 keys with degree ~200, height should be 2-3
    assert!(height >= 2, "Height should be at least 2 for 1000 keys");
    assert!(height <= 4, "Height should not exceed 4 for 1000 keys with degree {}", degree);

    // Verify tree structure is valid
    if height > 1 {
        let root = index.read_internal_node(index.root_page_id()).unwrap();
        assert!(root.children.len() >= 2, "Root should have at least 2 children");
        assert_eq!(
            root.keys.len() + 1,
            root.children.len(),
            "Internal node invariant: keys.len() + 1 == children.len()"
        );
    }
}

#[test]
fn test_large_random_inserts() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert 1000 keys in shuffled order
    let mut keys: Vec<i64> = (0..1000).map(|i| i * 10).collect();

    // Simple shuffle using the key values themselves
    for i in (1..keys.len()).rev() {
        let j = (keys[i] as usize) % (i + 1);
        keys.swap(i, j);
    }

    for (i, &k) in keys.iter().enumerate() {
        let key = vec![SqlValue::Integer(k)];
        let result = index.insert(key, i);
        assert!(result.is_ok(), "Insert of key {} failed: {:?}", k, result);
    }

    // Verify tree properties
    let height = index.height();
    assert!(height >= 2, "Height should be at least 2 for 1000 random keys");
    assert!(height <= 4, "Height should not exceed 4 for 1000 keys");
}

#[test]
fn test_insert_multi_column_keys() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer, DataType::Varchar { max_length: Some(20) }];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert multi-column keys
    let keys = vec![
        (vec![SqlValue::Integer(1), SqlValue::Varchar(arcstr::ArcStr::from("Alice"))], 0),
        (vec![SqlValue::Integer(2), SqlValue::Varchar(arcstr::ArcStr::from("Bob"))], 1),
        (vec![SqlValue::Integer(1), SqlValue::Varchar(arcstr::ArcStr::from("Zoe"))], 2),
    ];

    for (key, row_id) in keys {
        index.insert(key, row_id).unwrap();
    }

    // Verify entries are in sorted order
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();
    assert_eq!(root_leaf.entries.len(), 3);

    // Verify sorted: (1, "Alice"), (1, "Zoe"), (2, "Bob")
    assert!(root_leaf.entries[0].0[0] == SqlValue::Integer(1));
    assert!(root_leaf.entries[1].0[0] == SqlValue::Integer(1));
    assert!(root_leaf.entries[2].0[0] == SqlValue::Integer(2));
}

#[test]
fn test_delete_single_level_tree() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries = vec![
        (vec![SqlValue::Integer(10)], 0),
        (vec![SqlValue::Integer(20)], 1),
        (vec![SqlValue::Integer(30)], 2),
    ];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Delete middle entry
    assert!(index.delete(&vec![SqlValue::Integer(20)]).unwrap());

    // Verify it was deleted
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();
    assert_eq!(root_leaf.entries.len(), 2);
    assert_eq!(root_leaf.entries[0].0, vec![SqlValue::Integer(10)]);
    assert_eq!(root_leaf.entries[1].0, vec![SqlValue::Integer(30)]);

    // Try to delete non-existent key
    assert!(!index.delete(&vec![SqlValue::Integer(20)]).unwrap());
}

#[test]
fn test_delete_nonexistent_key() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries = vec![
        (vec![SqlValue::Integer(10)], 0),
        (vec![SqlValue::Integer(20)], 1),
        (vec![SqlValue::Integer(30)], 2),
    ];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Try to delete key that doesn't exist
    assert!(!index.delete(&vec![SqlValue::Integer(99)]).unwrap());

    // Verify tree unchanged
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();
    assert_eq!(root_leaf.entries.len(), 3);
}

#[test]
fn test_delete_all_entries_single_level() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries = vec![(vec![SqlValue::Integer(10)], 0), (vec![SqlValue::Integer(20)], 1)];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Delete both entries
    assert!(index.delete(&vec![SqlValue::Integer(10)]).unwrap());
    assert!(index.delete(&vec![SqlValue::Integer(20)]).unwrap());

    // Verify tree is empty
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();
    assert_eq!(root_leaf.entries.len(), 0);
}

#[test]
fn test_delete_multi_level_tree() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create enough entries to force multi-level tree
    let sorted_entries: Vec<(Key, RowId)> =
        (0..100).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();
    let original_height = index.height();

    // Delete some entries
    assert!(index.delete(&vec![SqlValue::Integer(50)]).unwrap());
    assert!(index.delete(&vec![SqlValue::Integer(150)]).unwrap());
    assert!(index.delete(&vec![SqlValue::Integer(250)]).unwrap());

    // Tree should still be valid (height may or may not change)
    assert!(index.height() > 0);
    assert!(index.height() <= original_height);
}

#[test]
fn test_delete_causes_height_decrease() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create enough entries to force multi-level tree (need more for bulk_load)
    let sorted_entries: Vec<(Key, RowId)> =
        (0..1000).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();
    let original_height = index.height();

    // Ensure we start with a multi-level tree
    assert!(original_height > 1, "Test requires multi-level tree, got height {}", original_height);

    // Delete most entries to trigger height decrease
    for i in 0..990 {
        let result = index.delete(&vec![SqlValue::Integer(i * 10)]);
        assert!(result.is_ok());
    }

    // Height should have decreased
    assert!(
        index.height() < original_height,
        "Height should decrease from {} after deleting 990/1000 entries",
        original_height
    );
}

#[test]
fn test_delete_sequence() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create 500 entries
    let sorted_entries: Vec<(Key, RowId)> =
        (0..500).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Delete every other entry
    for i in (0..500).step_by(2) {
        assert!(index.delete(&vec![SqlValue::Integer(i * 10)]).unwrap());
    }

    // Verify deletions
    for i in 0..500 {
        let should_exist = i % 2 != 0;
        let exists = index.delete(&vec![SqlValue::Integer(i * 10)]).unwrap();
        assert_eq!(exists, should_exist);
    }
}

#[test]
fn test_delete_multi_column_keys() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer, DataType::Varchar { max_length: Some(50) }];
    let sorted_entries = vec![
        (vec![SqlValue::Integer(1), SqlValue::Varchar(arcstr::ArcStr::from("Alice"))], 0),
        (vec![SqlValue::Integer(2), SqlValue::Varchar(arcstr::ArcStr::from("Bob"))], 1),
        (vec![SqlValue::Integer(3), SqlValue::Varchar(arcstr::ArcStr::from("Charlie"))], 2),
    ];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Delete middle entry
    assert!(index
        .delete(&vec![SqlValue::Integer(2), SqlValue::Varchar(arcstr::ArcStr::from("Bob"))])
        .unwrap());

    // Verify deletion
    let root_leaf = index.read_leaf_node(index.root_page_id()).unwrap();
    assert_eq!(root_leaf.entries.len(), 2);
    assert_eq!(
        root_leaf.entries[0].0,
        vec![SqlValue::Integer(1), SqlValue::Varchar(arcstr::ArcStr::from("Alice"))]
    );
    assert_eq!(
        root_leaf.entries[1].0,
        vec![SqlValue::Integer(3), SqlValue::Varchar(arcstr::ArcStr::from("Charlie"))]
    );
}

// ========================================================================
// Tests for delete_specific() - removes individual row_ids
// ========================================================================

#[test]
fn test_delete_specific_one_of_many_row_ids() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    // Create entries with duplicate keys (multiple row_ids per key)
    let sorted_entries = vec![
        (vec![SqlValue::Integer(10)], 100),
        (vec![SqlValue::Integer(10)], 200),
        (vec![SqlValue::Integer(10)], 300),
    ];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Delete one specific row_id, others should remain
    assert!(index.delete_specific(&vec![SqlValue::Integer(10)], 200).unwrap());

    // Verify the key still exists with remaining row_ids
    let remaining_row_ids = index.lookup(&vec![SqlValue::Integer(10)]).unwrap();
    assert_eq!(remaining_row_ids.len(), 2);
    assert!(remaining_row_ids.contains(&100));
    assert!(remaining_row_ids.contains(&300));
    assert!(!remaining_row_ids.contains(&200)); // Deleted row_id should not exist
}

#[test]
fn test_delete_specific_last_row_id_removes_key() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries =
        vec![(vec![SqlValue::Integer(10)], 100), (vec![SqlValue::Integer(20)], 200)];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Delete the only row_id for key 10
    assert!(index.delete_specific(&vec![SqlValue::Integer(10)], 100).unwrap());

    // Verify key 10 is completely removed
    let row_ids = index.lookup(&vec![SqlValue::Integer(10)]).unwrap();
    assert!(row_ids.is_empty(), "Key should be removed when last row_id is deleted");

    // Verify key 20 still exists
    let row_ids_20 = index.lookup(&vec![SqlValue::Integer(20)]).unwrap();
    assert_eq!(row_ids_20, vec![200]);
}

#[test]
fn test_delete_specific_nonexistent_row_id() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries =
        vec![(vec![SqlValue::Integer(10)], 100), (vec![SqlValue::Integer(10)], 200)];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Try to delete row_id that doesn't exist for this key
    assert!(!index.delete_specific(&vec![SqlValue::Integer(10)], 999).unwrap());

    // Verify nothing was changed
    let row_ids = index.lookup(&vec![SqlValue::Integer(10)]).unwrap();
    assert_eq!(row_ids.len(), 2);
    assert!(row_ids.contains(&100));
    assert!(row_ids.contains(&200));
}

#[test]
fn test_delete_specific_nonexistent_key() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries = vec![(vec![SqlValue::Integer(10)], 100)];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Try to delete from key that doesn't exist
    assert!(!index.delete_specific(&vec![SqlValue::Integer(99)], 100).unwrap());

    // Verify existing key unchanged
    let row_ids = index.lookup(&vec![SqlValue::Integer(10)]).unwrap();
    assert_eq!(row_ids, vec![100]);
}

#[test]
fn test_delete_specific_multi_level_tree() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create enough entries to force multi-level tree, with some duplicates
    let mut sorted_entries: Vec<(Key, RowId)> = Vec::new();
    for i in 0..500 {
        sorted_entries.push((vec![SqlValue::Integer(i * 10)], (i * 2) as usize));
        // Add duplicate for every 10th key
        if i % 10 == 0 {
            sorted_entries.push((vec![SqlValue::Integer(i * 10)], (i * 2 + 1) as usize));
        }
    }

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();
    assert!(index.height() > 1, "Test requires multi-level tree");

    // Delete specific row_id from a key with duplicates
    // i=0: key=0, row_ids=[0, 1] (because 0 % 10 == 0)
    assert!(index.delete_specific(&vec![SqlValue::Integer(0)], 1).unwrap());

    // Verify the other row_id still exists for this key
    let row_ids = index.lookup(&vec![SqlValue::Integer(0)]).unwrap();
    assert_eq!(row_ids, vec![0]);

    // Delete from a key with only one row_id
    // i=5: key=50, row_ids=[10] (because 5 % 10 != 0, no duplicate)
    assert!(index.delete_specific(&vec![SqlValue::Integer(50)], 10).unwrap());

    // Verify key is removed
    let row_ids_50 = index.lookup(&vec![SqlValue::Integer(50)]).unwrap();
    assert!(row_ids_50.is_empty());
}

#[test]
fn test_delete_specific_vs_delete_all() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries = vec![
        (vec![SqlValue::Integer(10)], 100),
        (vec![SqlValue::Integer(10)], 200),
        (vec![SqlValue::Integer(10)], 300),
        (vec![SqlValue::Integer(20)], 400),
        (vec![SqlValue::Integer(20)], 500),
    ];

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Use delete_specific on key 10 - should only remove one row_id
    assert!(index.delete_specific(&vec![SqlValue::Integer(10)], 200).unwrap());
    let row_ids_10 = index.lookup(&vec![SqlValue::Integer(10)]).unwrap();
    assert_eq!(row_ids_10.len(), 2, "delete_specific should remove only one row_id");

    // Use delete on key 20 - should remove all row_ids
    assert!(index.delete(&vec![SqlValue::Integer(20)]).unwrap());
    let row_ids_20 = index.lookup(&vec![SqlValue::Integer(20)]).unwrap();
    assert!(row_ids_20.is_empty(), "delete should remove all row_ids");
}

#[test]
fn test_delete_specific_with_rebalancing() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create enough entries to trigger rebalancing
    let sorted_entries: Vec<(Key, RowId)> =
        (0..500).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();
    let original_height = index.height();

    // Delete specific row_ids sequentially (these are single row_id keys)
    for i in (0..450).step_by(3) {
        assert!(index.delete_specific(&vec![SqlValue::Integer(i * 10)], i as usize).unwrap());
    }

    // Tree should still be valid, height may have decreased
    assert!(index.height() > 0);
    assert!(index.height() <= original_height);

    // Verify remaining entries are accessible
    let row_ids = index.lookup(&vec![SqlValue::Integer(10)]).unwrap();
    assert_eq!(row_ids, vec![1], "Non-deleted entries should still be accessible");
}

// ========================================================================
// Tests for prev_leaf pointers and reverse iteration
// ========================================================================

#[test]
fn test_leaf_node_split_maintains_prev_leaf() {
    let mut leaf = LeafNode::new(1);

    // Set an existing next_leaf
    leaf.next_leaf = 10;

    // Insert 6 entries
    for i in 0..6 {
        leaf.insert(vec![SqlValue::Integer(i * 10)], i as usize);
    }

    let (_, right_node) = leaf.split(2);

    // Left node's prev_leaf should be unchanged (was NULL_PAGE_ID)
    assert_eq!(leaf.prev_leaf, super::super::NULL_PAGE_ID);

    // Right node's prev_leaf should point to left node
    assert_eq!(right_node.prev_leaf, 1);

    // Left's next_leaf now points to the new right node
    assert_eq!(leaf.next_leaf, 2);

    // Right node's next_leaf should be the original next_leaf
    assert_eq!(right_node.next_leaf, 10);
}

#[test]
fn test_bulk_load_maintains_prev_leaf() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create enough entries to force multiple leaf nodes
    let sorted_entries: Vec<(Key, RowId)> =
        (0..500).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Verify doubly-linked list by traversing forward and backward
    let leftmost = index.find_leftmost_leaf().unwrap();
    let rightmost = index.find_rightmost_leaf().unwrap();

    // Leftmost should have no prev_leaf
    assert_eq!(leftmost.prev_leaf, super::super::NULL_PAGE_ID);

    // Rightmost should have no next_leaf
    assert_eq!(rightmost.next_leaf, super::super::NULL_PAGE_ID);

    // Traverse forward and count leaves
    let mut forward_count = 0;
    let mut current = leftmost.clone();
    loop {
        forward_count += 1;
        if current.next_leaf == super::super::NULL_PAGE_ID {
            break;
        }
        current = index.read_leaf_node(current.next_leaf).unwrap();
    }

    // Traverse backward and count leaves
    let mut backward_count = 0;
    let mut current = rightmost;
    loop {
        backward_count += 1;
        if current.prev_leaf == super::super::NULL_PAGE_ID {
            break;
        }
        current = index.read_leaf_node(current.prev_leaf).unwrap();
    }

    // Both counts should be equal
    assert_eq!(
        forward_count, backward_count,
        "Forward and backward traversal should visit same number of leaves"
    );
}

#[test]
fn test_insert_maintains_prev_leaf() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    let degree = index.degree();

    // Insert enough keys to cause multiple splits
    for i in 0..(degree * 3) {
        let key = vec![SqlValue::Integer(i as i64 * 10)];
        index.insert(key, i).unwrap();
    }

    // Verify doubly-linked list
    let leftmost = index.find_leftmost_leaf().unwrap();
    let rightmost = index.find_rightmost_leaf().unwrap();

    // Leftmost should have no prev_leaf
    assert_eq!(leftmost.prev_leaf, super::super::NULL_PAGE_ID);

    // Rightmost should have no next_leaf
    assert_eq!(rightmost.next_leaf, super::super::NULL_PAGE_ID);

    // Traverse forward and count
    let mut forward_count = 0;
    let mut current = leftmost;
    loop {
        forward_count += 1;
        if current.next_leaf == super::super::NULL_PAGE_ID {
            break;
        }
        let prev_page_id = current.page_id;
        current = index.read_leaf_node(current.next_leaf).unwrap();
        // Verify prev_leaf points back
        assert_eq!(current.prev_leaf, prev_page_id, "prev_leaf should point to previous node");
    }

    assert!(forward_count > 1, "Test requires multiple leaf nodes");
}

#[test]
fn test_range_scan_reverse_basic() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries = vec![
        (vec![SqlValue::Integer(10)], 0),
        (vec![SqlValue::Integer(20)], 1),
        (vec![SqlValue::Integer(30)], 2),
        (vec![SqlValue::Integer(40)], 3),
        (vec![SqlValue::Integer(50)], 4),
    ];

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Full reverse scan
    let result = index.range_scan_reverse(None, None, true, true).unwrap();
    assert_eq!(
        result,
        vec![4, 3, 2, 1, 0],
        "Full reverse scan should return all rows in descending order"
    );

    // Compare with forward scan reversed
    let forward = index.range_scan(None, None, true, true).unwrap();
    let mut forward_reversed = forward.clone();
    forward_reversed.reverse();
    assert_eq!(result, forward_reversed, "Reverse scan should equal reversed forward scan");
}

#[test]
fn test_range_scan_reverse_with_bounds() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries: Vec<(Key, RowId)> =
        (0..10).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Range [20, 60] in reverse
    let start = vec![SqlValue::Integer(20)];
    let end = vec![SqlValue::Integer(60)];
    let result = index.range_scan_reverse(Some(&start), Some(&end), true, true).unwrap();
    assert_eq!(result, vec![6, 5, 4, 3, 2], "Bounded reverse scan");

    // Exclusive start
    let result = index.range_scan_reverse(Some(&start), Some(&end), false, true).unwrap();
    assert_eq!(result, vec![6, 5, 4, 3], "Reverse scan with exclusive start");

    // Exclusive end
    let result = index.range_scan_reverse(Some(&start), Some(&end), true, false).unwrap();
    assert_eq!(result, vec![5, 4, 3, 2], "Reverse scan with exclusive end");
}

#[test]
fn test_range_scan_reverse_multi_level() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create enough entries for multi-level tree
    let sorted_entries: Vec<(Key, RowId)> =
        (0..500).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();
    assert!(index.height() > 1, "Test requires multi-level tree");

    // Full reverse scan should return all 500 entries in descending order
    let result = index.range_scan_reverse(None, None, true, true).unwrap();
    assert_eq!(result.len(), 500);
    assert_eq!(result[0], 499, "First element should be highest row_id");
    assert_eq!(result[499], 0, "Last element should be lowest row_id");

    // Verify it's actually reversed
    for i in 0..499 {
        assert!(result[i] > result[i + 1], "Results should be in descending order");
    }
}

#[test]
fn test_range_scan_reverse_first() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let sorted_entries: Vec<(Key, RowId)> =
        (0..100).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Get first element in reverse (should be highest)
    let result = index.range_scan_reverse_first(None, None, true, true).unwrap();
    assert_eq!(result, Some(99), "Reverse first should return highest row_id");

    // Get first element in bounded range in reverse
    let start = vec![SqlValue::Integer(200)];
    let end = vec![SqlValue::Integer(500)];
    let result = index.range_scan_reverse_first(Some(&start), Some(&end), true, true).unwrap();
    assert_eq!(result, Some(50), "Bounded reverse first should return highest in range");

    // Empty range
    let start = vec![SqlValue::Integer(9999)];
    let end = vec![SqlValue::Integer(10000)];
    let result = index.range_scan_reverse_first(Some(&start), Some(&end), true, true).unwrap();
    assert_eq!(result, None, "Empty range should return None");
}

#[test]
fn test_find_rightmost_leaf() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create entries for multi-level tree
    let sorted_entries: Vec<(Key, RowId)> =
        (0..500).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    let rightmost = index.find_rightmost_leaf().unwrap();

    // Rightmost leaf should have no next_leaf
    assert_eq!(rightmost.next_leaf, super::super::NULL_PAGE_ID);

    // Rightmost leaf should contain the highest keys
    assert!(!rightmost.entries.is_empty());
    let highest_key = &rightmost.entries.last().unwrap().0;
    assert_eq!(
        *highest_key,
        vec![SqlValue::Integer(4990)],
        "Rightmost leaf should contain highest key"
    );
}

#[test]
fn test_range_scan_reverse_with_duplicates() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    // Create entries with duplicate keys
    let sorted_entries = vec![
        (vec![SqlValue::Integer(10)], 0),
        (vec![SqlValue::Integer(10)], 1),
        (vec![SqlValue::Integer(20)], 2),
        (vec![SqlValue::Integer(20)], 3),
        (vec![SqlValue::Integer(20)], 4),
        (vec![SqlValue::Integer(30)], 5),
    ];

    let index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();

    // Full reverse scan should return all row_ids in descending order
    let result = index.range_scan_reverse(None, None, true, true).unwrap();
    assert_eq!(result, vec![5, 4, 3, 2, 1, 0], "Reverse scan with duplicates");
}

#[test]
fn test_delete_batch_single_level() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert some entries
    for i in 0..10 {
        index.insert(vec![SqlValue::Integer(i * 10)], i as usize).unwrap();
    }

    // Batch delete several entries
    let entries_to_delete = vec![
        (vec![SqlValue::Integer(20)], 2),
        (vec![SqlValue::Integer(50)], 5),
        (vec![SqlValue::Integer(70)], 7),
    ];

    let deleted = index.delete_batch(&entries_to_delete).unwrap();
    assert_eq!(deleted, 3, "Should delete 3 entries");

    // Verify they are gone
    assert!(index.lookup(&vec![SqlValue::Integer(20)]).unwrap().is_empty());
    assert!(index.lookup(&vec![SqlValue::Integer(50)]).unwrap().is_empty());
    assert!(index.lookup(&vec![SqlValue::Integer(70)]).unwrap().is_empty());

    // Verify others still exist
    assert_eq!(index.lookup(&vec![SqlValue::Integer(0)]).unwrap(), vec![0]);
    assert_eq!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap(), vec![1]);
    assert_eq!(index.lookup(&vec![SqlValue::Integer(30)]).unwrap(), vec![3]);
}

#[test]
fn test_delete_batch_multi_level() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];

    // Create entries that will span multiple leaves (need more entries for multi-level)
    let sorted_entries: Vec<_> =
        (0..1000).map(|i| (vec![SqlValue::Integer(i * 10)], i as usize)).collect();

    let mut index = BTreeIndex::bulk_load(sorted_entries, key_schema, page_manager).unwrap();
    // Note: multi-level tree depends on degree/page size. If this fails, just skip the assertion.
    let is_multi_level = index.height() > 1;

    // Batch delete entries from different parts of the tree
    let entries_to_delete: Vec<_> =
        (0..50).map(|i| (vec![SqlValue::Integer(i * 200)], (i * 20) as usize)).collect();

    let deleted = index.delete_batch(&entries_to_delete).unwrap();
    assert_eq!(deleted, 50, "Should delete 50 entries");

    // Verify deleted entries are gone
    for i in 0..50 {
        let key = i * 200;
        let result = index.lookup(&vec![SqlValue::Integer(key)]).unwrap();
        assert!(result.is_empty(), "Entry {} should be deleted", key);
    }

    // Verify some remaining entries
    assert_eq!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap(), vec![1]);
    assert_eq!(index.lookup(&vec![SqlValue::Integer(30)]).unwrap(), vec![3]);

    // Log for debugging
    if is_multi_level {
        println!("Test ran with multi-level tree (height={})", index.height());
    }
}

#[test]
fn test_delete_batch_with_duplicates() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert duplicate keys
    for i in 0..5 {
        index.insert(vec![SqlValue::Integer(100)], i).unwrap();
    }
    for i in 5..10 {
        index.insert(vec![SqlValue::Integer(200)], i).unwrap();
    }

    // Delete specific row_ids from the duplicate key
    let entries_to_delete = vec![
        (vec![SqlValue::Integer(100)], 1),
        (vec![SqlValue::Integer(100)], 3),
        (vec![SqlValue::Integer(200)], 7),
    ];

    let deleted = index.delete_batch(&entries_to_delete).unwrap();
    assert_eq!(deleted, 3, "Should delete 3 entries");

    // Verify remaining row_ids
    let remaining_100 = index.lookup(&vec![SqlValue::Integer(100)]).unwrap();
    assert_eq!(remaining_100, vec![0, 2, 4], "Should have remaining row_ids for key 100");

    let remaining_200 = index.lookup(&vec![SqlValue::Integer(200)]).unwrap();
    assert_eq!(remaining_200, vec![5, 6, 8, 9], "Should have remaining row_ids for key 200");
}

#[test]
fn test_delete_batch_nonexistent_entries() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    // Insert some entries
    index.insert(vec![SqlValue::Integer(10)], 1).unwrap();
    index.insert(vec![SqlValue::Integer(20)], 2).unwrap();

    // Try to delete nonexistent entries
    let entries_to_delete = vec![
        (vec![SqlValue::Integer(10)], 1), // exists
        (vec![SqlValue::Integer(30)], 3), // doesn't exist
        (vec![SqlValue::Integer(20)], 9), // key exists but row_id doesn't
    ];

    let deleted = index.delete_batch(&entries_to_delete).unwrap();
    assert_eq!(deleted, 1, "Should only delete 1 entry");

    // Verify state
    assert!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap().is_empty());
    assert_eq!(index.lookup(&vec![SqlValue::Integer(20)]).unwrap(), vec![2]);
}

#[test]
fn test_delete_batch_empty() {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("test.db", storage).unwrap());

    let key_schema = vec![DataType::Integer];
    let mut index = BTreeIndex::new(page_manager, key_schema).unwrap();

    index.insert(vec![SqlValue::Integer(10)], 1).unwrap();

    // Empty batch should be a no-op
    let deleted = index.delete_batch(&[]).unwrap();
    assert_eq!(deleted, 0, "Empty batch should delete 0 entries");

    // Original entry should still exist
    assert_eq!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap(), vec![1]);
}

// ============================================================================
// Transaction undo-log (issue #5425)
//
// `IndexData::DiskBacked` clones as a shallow `Arc<Mutex<BTreeIndex>>` bump, so
// the copy-on-write `Operations` rollback snapshot does not undo spilled-index
// mutations. The undo-log records the inverse of each mutation so ROLLBACK can
// reverse it; COMMIT discards it. These tests pin the reversibility of every
// mutating B+ tree operation.
// ============================================================================

/// Build a fresh disk-backed B+ tree seeded with `(int_key, row_id)` entries.
fn undo_test_index(seed: &[(i64, RowId)]) -> (BTreeIndex, tempfile::TempDir) {
    use tempfile::TempDir;

    let temp_dir = TempDir::new().unwrap();
    let storage = Arc::new(crate::NativeStorage::new(temp_dir.path()).unwrap());
    let page_manager = Arc::new(PageManager::new("undo_test.db", storage).unwrap());

    let mut index = BTreeIndex::new(page_manager, vec![DataType::Integer]).unwrap();
    for (k, row_id) in seed {
        index.insert(vec![SqlValue::Integer(*k)], *row_id).unwrap();
    }
    (index, temp_dir)
}

/// Capture every key's row_ids so two B+ tree states can be compared.
fn snapshot_keys(index: &BTreeIndex, keys: &[i64]) -> Vec<(i64, Vec<RowId>)> {
    keys.iter()
        .map(|k| {
            let mut rows = index.lookup(&vec![SqlValue::Integer(*k)]).unwrap();
            rows.sort_unstable();
            (*k, rows)
        })
        .collect()
}

#[test]
fn undo_log_reverses_inserts_on_rollback() {
    let (mut index, _dir) = undo_test_index(&[(10, 1), (20, 2)]);
    let before = snapshot_keys(&index, &[10, 20, 30, 40]);

    index.begin_undo_logging();
    assert!(index.is_undo_logging());

    // Mutate: insert a brand-new key and a duplicate row on an existing key.
    index.insert(vec![SqlValue::Integer(30)], 3).unwrap();
    index.insert(vec![SqlValue::Integer(40)], 4).unwrap();
    index.insert(vec![SqlValue::Integer(10)], 5).unwrap();
    assert_eq!(index.lookup(&vec![SqlValue::Integer(30)]).unwrap(), vec![3]);
    assert_eq!(snapshot_keys(&index, &[10]), vec![(10, vec![1, 5])]);

    index.rollback_undo_log().unwrap();
    assert!(!index.is_undo_logging(), "rollback disables logging");

    assert_eq!(
        snapshot_keys(&index, &[10, 20, 30, 40]),
        before,
        "ROLLBACK must reverse all inserts, restoring the pre-transaction tree"
    );
}

#[test]
fn undo_log_reverses_delete_specific_on_rollback() {
    // Non-unique key 10 holds two rows; delete one specifically.
    let (mut index, _dir) = undo_test_index(&[(10, 1), (10, 2), (20, 3)]);
    let before = snapshot_keys(&index, &[10, 20]);

    index.begin_undo_logging();
    assert!(index.delete_specific(&vec![SqlValue::Integer(10)], 1).unwrap());
    assert_eq!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap(), vec![2]);

    index.rollback_undo_log().unwrap();
    assert_eq!(
        snapshot_keys(&index, &[10, 20]),
        before,
        "ROLLBACK must re-insert the specifically-deleted row"
    );
}

#[test]
fn undo_log_reverses_full_key_delete_on_rollback() {
    // Full-key delete removes ALL rows for the key; undo must restore them all.
    let (mut index, _dir) = undo_test_index(&[(10, 1), (10, 2), (10, 3), (20, 4)]);
    let before = snapshot_keys(&index, &[10, 20]);

    index.begin_undo_logging();
    assert!(index.delete(&vec![SqlValue::Integer(10)]).unwrap());
    assert!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap().is_empty());

    index.rollback_undo_log().unwrap();
    assert_eq!(
        snapshot_keys(&index, &[10, 20]),
        before,
        "ROLLBACK must re-insert every row removed by a full-key delete"
    );
}

#[test]
fn undo_log_reverses_delete_batch_on_rollback() {
    let (mut index, _dir) = undo_test_index(&[(10, 1), (20, 2), (30, 3), (40, 4)]);
    let before = snapshot_keys(&index, &[10, 20, 30, 40]);

    index.begin_undo_logging();
    let deleted = index
        .delete_batch(&[
            (vec![SqlValue::Integer(10)], 1),
            (vec![SqlValue::Integer(30)], 3),
        ])
        .unwrap();
    assert_eq!(deleted, 2);
    assert!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap().is_empty());

    index.rollback_undo_log().unwrap();
    assert_eq!(
        snapshot_keys(&index, &[10, 20, 30, 40]),
        before,
        "ROLLBACK must reverse a batch delete"
    );
}

#[test]
fn undo_log_reverses_mixed_mutations_lifo() {
    // Interleave inserts and deletes (including on the same key) and confirm
    // the LIFO reversal restores the exact starting state.
    let (mut index, _dir) = undo_test_index(&[(10, 1), (20, 2)]);
    let before = snapshot_keys(&index, &[10, 20, 30]);

    index.begin_undo_logging();
    index.insert(vec![SqlValue::Integer(30)], 3).unwrap(); // add new key
    index.delete(&vec![SqlValue::Integer(20)]).unwrap(); // remove existing key
    index.insert(vec![SqlValue::Integer(20)], 9).unwrap(); // re-add with new row
    index.delete_specific(&vec![SqlValue::Integer(10)], 1).unwrap();
    index.insert(vec![SqlValue::Integer(10)], 7).unwrap();

    index.rollback_undo_log().unwrap();
    assert_eq!(
        snapshot_keys(&index, &[10, 20, 30]),
        before,
        "interleaved mutations must unwind in LIFO order to the original tree"
    );
}

#[test]
fn clear_undo_log_keeps_committed_mutations() {
    // COMMIT path: clearing the log must NOT reverse anything.
    let (mut index, _dir) = undo_test_index(&[(10, 1)]);

    index.begin_undo_logging();
    index.insert(vec![SqlValue::Integer(20)], 2).unwrap();
    index.delete_specific(&vec![SqlValue::Integer(10)], 1).unwrap();
    index.clear_undo_log();
    assert!(!index.is_undo_logging());

    assert!(
        index.lookup(&vec![SqlValue::Integer(10)]).unwrap().is_empty(),
        "committed delete must persist"
    );
    assert_eq!(
        index.lookup(&vec![SqlValue::Integer(20)]).unwrap(),
        vec![2],
        "committed insert must persist"
    );

    // A subsequent rollback (no active log) is a harmless no-op.
    index.rollback_undo_log().unwrap();
    assert_eq!(index.lookup(&vec![SqlValue::Integer(20)]).unwrap(), vec![2]);
}

#[test]
fn no_undo_logging_has_no_overhead_and_no_reversal() {
    // Without begin_undo_logging, mutations are not recorded and a stray
    // rollback call does nothing.
    let (mut index, _dir) = undo_test_index(&[(10, 1)]);
    assert!(!index.is_undo_logging());
    index.insert(vec![SqlValue::Integer(20)], 2).unwrap();
    index.rollback_undo_log().unwrap(); // no log => no-op
    assert_eq!(index.lookup(&vec![SqlValue::Integer(20)]).unwrap(), vec![2]);
}

// ----------------------------------------------------------------------------
// Statement-scoped nested undo markers (issue #5434)
// ----------------------------------------------------------------------------

#[test]
fn undo_log_marker_reverses_only_suffix() {
    // A statement savepoint marks the log mid-transaction; rollback_to reverses
    // only entries recorded after the mark, leaving earlier mutations in place
    // and undo-logging still armed.
    let (mut index, _dir) = undo_test_index(&[(10, 1)]);

    index.begin_undo_logging();
    assert_eq!(index.undo_log_marker(), Some(0));

    // Pre-savepoint mutation.
    index.insert(vec![SqlValue::Integer(20)], 2).unwrap();

    // Statement savepoint marker.
    let marker = index.undo_log_marker().unwrap();
    assert_eq!(marker, 1, "one entry recorded before the marker");

    // Post-savepoint (statement) mutations.
    index.insert(vec![SqlValue::Integer(30)], 3).unwrap();
    index.delete(&vec![SqlValue::Integer(10)]).unwrap();
    assert_eq!(index.lookup(&vec![SqlValue::Integer(30)]).unwrap(), vec![3]);
    assert!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap().is_empty());

    // Roll back only the statement.
    index.rollback_undo_log_to(marker).unwrap();

    assert!(
        index.lookup(&vec![SqlValue::Integer(30)]).unwrap().is_empty(),
        "statement insert reversed"
    );
    assert_eq!(
        index.lookup(&vec![SqlValue::Integer(10)]).unwrap(),
        vec![1],
        "statement delete restored"
    );
    assert_eq!(
        index.lookup(&vec![SqlValue::Integer(20)]).unwrap(),
        vec![2],
        "pre-savepoint mutation preserved"
    );

    // Logging is still armed and the retained prefix is intact.
    assert!(index.is_undo_logging(), "logging stays armed after a partial rollback");
    assert_eq!(index.undo_log_marker(), Some(marker), "prefix retained");

    // A subsequent full rollback reverses the surviving prefix too.
    index.rollback_undo_log().unwrap();
    assert!(
        index.lookup(&vec![SqlValue::Integer(20)]).unwrap().is_empty(),
        "full ROLLBACK reverses the retained prefix"
    );
    assert_eq!(index.lookup(&vec![SqlValue::Integer(10)]).unwrap(), vec![1]);
}

#[test]
fn undo_log_marker_at_end_reverses_nothing() {
    // Marking at the current tail then rolling back to it is a no-op for the
    // tree, and keeps logging armed.
    let (mut index, _dir) = undo_test_index(&[(10, 1)]);

    index.begin_undo_logging();
    index.insert(vec![SqlValue::Integer(20)], 2).unwrap();

    let marker = index.undo_log_marker().unwrap();
    index.rollback_undo_log_to(marker).unwrap();

    assert_eq!(index.lookup(&vec![SqlValue::Integer(20)]).unwrap(), vec![2]);
    assert!(index.is_undo_logging());
    assert_eq!(index.undo_log_marker(), Some(marker));
}

#[test]
fn undo_log_marker_without_logging_is_noop() {
    // No log armed: marker is None and rollback_to does nothing.
    let (mut index, _dir) = undo_test_index(&[(10, 1)]);
    assert_eq!(index.undo_log_marker(), None);
    index.insert(vec![SqlValue::Integer(20)], 2).unwrap();
    index.rollback_undo_log_to(0).unwrap(); // no log => no-op
    assert_eq!(index.lookup(&vec![SqlValue::Integer(20)]).unwrap(), vec![2]);
}