vibesql-executor 0.2.0

Query execution engine for vibesql SQL database
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
//! `UPDATE ... SET rowid = <expr>` on base tables (issue #5517).
//!
//! SQLite lets a rowid table relocate a row by assigning its rowid:
//! `UPDATE t SET rowid=99 WHERE rowid=1` moves the row to rowid 99, fires the
//! table's BEFORE/AFTER UPDATE triggers with OLD.rowid=1 / NEW.rowid=99, and
//! raises `UNIQUE constraint failed: t.rowid` if the target rowid is already
//! taken. `_rowid_` / `oid` are aliases. For an INTEGER PRIMARY KEY table the
//! rowid IS the IPK column, so `SET rowid=` writes the IPK (and a collision is
//! reported against the IPK column name). These behaviors were verified against
//! sqlite3 3.51.0; see triggerC-7.x.

use vibesql_ast::Statement;
use vibesql_parser::Parser;
use vibesql_types::SqlValue;

use crate::*;

/// Execute a non-query statement (CREATE/INSERT/CREATE INDEX/CREATE TRIGGER).
fn ddl(db: &mut vibesql_storage::Database, sql: &str) {
    let stmt = Parser::parse_sql(sql).unwrap_or_else(|e| panic!("parse {:?}: {:?}", sql, e));
    match stmt {
        Statement::CreateTable(s) => {
            CreateTableExecutor::execute(&s, db).expect("CREATE TABLE");
        }
        Statement::CreateIndex(s) => {
            CreateIndexExecutor::execute(&s, db).expect("CREATE INDEX");
        }
        Statement::Insert(s) => {
            InsertExecutor::execute(db, &s).expect("INSERT");
        }
        Statement::CreateTrigger(s) => {
            crate::advanced_objects::execute_create_trigger(&s, db).expect("CREATE TRIGGER");
        }
        other => panic!("unsupported ddl: {:?}", other),
    }
}

/// Run an UPDATE, returning the executor result (so conflict errors are observable).
fn update(db: &mut vibesql_storage::Database, sql: &str) -> Result<usize, crate::ExecutorError> {
    match Parser::parse_sql(sql).expect("parse update") {
        Statement::Update(s) => UpdateExecutor::execute(&s, db),
        other => panic!("expected UPDATE, got {:?}", other),
    }
}

/// Run a DELETE (fires DELETE triggers).
fn delete(db: &mut vibesql_storage::Database, sql: &str) {
    match Parser::parse_sql(sql).expect("parse delete") {
        Statement::Delete(s) => {
            DeleteExecutor::execute(&s, db).expect("DELETE");
        }
        other => panic!("expected DELETE, got {:?}", other),
    }
}

/// Run a SELECT and return rows (each row carries its resolved row_id).
fn select(db: &mut vibesql_storage::Database, sql: &str) -> Vec<vibesql_storage::Row> {
    match Parser::parse_sql(sql).expect("parse select") {
        Statement::Select(s) => SelectExecutor::new(db).execute(&s).expect("SELECT"),
        other => panic!("expected SELECT, got {:?}", other),
    }
}

fn int(v: &SqlValue) -> i64 {
    match v {
        SqlValue::Integer(i) => *i,
        SqlValue::Bigint(i) => *i,
        other => panic!("expected integer, got {:?}", other),
    }
}

fn text(v: &SqlValue) -> String {
    match v {
        SqlValue::Varchar(s) => s.to_string(),
        other => panic!("expected text, got {:?}", other),
    }
}

/// `UPDATE t SET rowid=N` relocates the row on a virtual-rowid table.
#[test]
fn set_rowid_relocates_row() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(x)");
    ddl(&mut db, "INSERT INTO t VALUES(1)");
    ddl(&mut db, "INSERT INTO t VALUES(2)");
    ddl(&mut db, "INSERT INTO t VALUES(3)");

    assert_eq!(update(&mut db, "UPDATE t SET rowid=99 WHERE rowid=1").unwrap(), 1);

    // sqlite3: rows are (rowid=2,x=2), (rowid=3,x=3), (rowid=99,x=1).
    let rows = select(&mut db, "SELECT rowid, x FROM t ORDER BY rowid");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(2, 2), (3, 3), (99, 1)]);
}

/// `_rowid_` is an alias for `rowid`.
#[test]
fn set_underscore_rowid_alias() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(x)");
    ddl(&mut db, "INSERT INTO t VALUES(1)");

    assert_eq!(update(&mut db, "UPDATE t SET _rowid_=50 WHERE rowid=1").unwrap(), 1);

    let rows = select(&mut db, "SELECT rowid, x FROM t");
    assert_eq!(int(&rows[0].values[0]), 50);
    assert_eq!(int(&rows[0].values[1]), 1);
}

/// Relocating onto an occupied rowid is `UNIQUE constraint failed: t.rowid`.
#[test]
fn set_rowid_conflict_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(x)");
    ddl(&mut db, "INSERT INTO t VALUES(1)");
    ddl(&mut db, "INSERT INTO t VALUES(2)");
    ddl(&mut db, "INSERT INTO t VALUES(3)");

    let err = update(&mut db, "UPDATE t SET rowid=2 WHERE rowid=1").unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.rowid"),
        "expected rowid UNIQUE error, got: {}",
        err
    );

    // The table must be unchanged after the aborted UPDATE.
    let rows = select(&mut db, "SELECT rowid, x FROM t ORDER BY rowid");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 1), (2, 2), (3, 3)]);
}

/// Single-statement rowid SWAP must error with `UNIQUE constraint failed:
/// t.rowid` (issue #5559). sqlite3 3.51.0 processes the UPDATE row-by-row in
/// ascending rowid order: relocating rowid 1 -> 2 collides with rowid 2, which
/// is still live at that moment. The final state would be consistent, but
/// sqlite3 checks the intermediate state, so this must be rejected.
#[test]
fn set_rowid_swap_errors_intermediate_collision() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(a)");
    ddl(&mut db, "INSERT INTO t VALUES(10)"); // rowid 1
    ddl(&mut db, "INSERT INTO t VALUES(20)"); // rowid 2

    let err = update(
        &mut db,
        "UPDATE t SET rowid = CASE rowid WHEN 1 THEN 2 WHEN 2 THEN 1 END",
    )
    .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.rowid"),
        "expected rowid UNIQUE error for swap, got: {}",
        err
    );

    // Table unchanged after the aborted UPDATE.
    let rows = select(&mut db, "SELECT rowid, a FROM t ORDER BY rowid");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 10), (2, 20)]);
}

/// A 3-cycle rotation (1->2, 2->3, 3->1) also errors: processed ascending,
/// 1->2 collides with the still-live rowid 2. Matches sqlite3 3.51.0.
#[test]
fn set_rowid_three_cycle_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(a)");
    ddl(&mut db, "INSERT INTO t VALUES(10)");
    ddl(&mut db, "INSERT INTO t VALUES(20)");
    ddl(&mut db, "INSERT INTO t VALUES(30)");

    let err = update(
        &mut db,
        "UPDATE t SET rowid = CASE rowid WHEN 1 THEN 2 WHEN 2 THEN 3 WHEN 3 THEN 1 END",
    )
    .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.rowid"),
        "expected rowid UNIQUE error for 3-cycle, got: {}",
        err
    );
}

/// `SET rowid = rowid + 1` over ascending rows cascade-collides: processed
/// ascending, rowid 1 -> 2 collides with the still-live rowid 2. sqlite3 3.51.0
/// errors (processing order matters; see the `-1` counterpart below).
#[test]
fn set_rowid_plus_one_cascade_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(a)");
    ddl(&mut db, "INSERT INTO t VALUES(10)");
    ddl(&mut db, "INSERT INTO t VALUES(20)");
    ddl(&mut db, "INSERT INTO t VALUES(30)");

    let err = update(&mut db, "UPDATE t SET rowid = rowid + 1").unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.rowid"),
        "expected rowid UNIQUE error for +1 cascade, got: {}",
        err
    );
}

/// `SET rowid = rowid - 1` over ascending rows succeeds: processed ascending,
/// each row's old slot is vacated before the next row needs it (1->0, then
/// 2->1 onto the now-free slot 1, ...). sqlite3 3.51.0 accepts this — the
/// asymmetry with `+1` confirms the row-by-row ascending processing order.
#[test]
fn set_rowid_minus_one_cascade_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(a)");
    ddl(&mut db, "INSERT INTO t VALUES(10)");
    ddl(&mut db, "INSERT INTO t VALUES(20)");
    ddl(&mut db, "INSERT INTO t VALUES(30)");

    assert_eq!(update(&mut db, "UPDATE t SET rowid = rowid - 1").unwrap(), 3);

    let rows = select(&mut db, "SELECT rowid, a FROM t ORDER BY rowid");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(0, 10), (1, 20), (2, 30)]);
}

/// Relocating into a free gap (no collision at any intermediate step) succeeds.
/// Matches sqlite3 3.51.0.
#[test]
fn set_rowid_move_to_gap_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(a)");
    ddl(&mut db, "INSERT INTO t VALUES(10)");
    ddl(&mut db, "INSERT INTO t VALUES(20)");

    assert_eq!(update(&mut db, "UPDATE t SET rowid = rowid + 100 WHERE rowid = 1").unwrap(), 1);

    let rows = select(&mut db, "SELECT rowid, a FROM t ORDER BY rowid");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(2, 20), (101, 10)]);
}

/// `SET rowid = rowid` is a no-op for every row and must not error. Matches
/// sqlite3 3.51.0.
#[test]
fn set_rowid_self_noop_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(a)");
    ddl(&mut db, "INSERT INTO t VALUES(10)");
    ddl(&mut db, "INSERT INTO t VALUES(20)");
    ddl(&mut db, "INSERT INTO t VALUES(30)");

    assert_eq!(update(&mut db, "UPDATE t SET rowid = rowid").unwrap(), 3);

    let rows = select(&mut db, "SELECT rowid, a FROM t ORDER BY rowid");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 10), (2, 20), (3, 30)]);
}

/// On an INTEGER PRIMARY KEY table, `SET rowid=` writes the IPK column.
#[test]
fn set_rowid_aliases_ipk() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'a')");

    assert_eq!(update(&mut db, "UPDATE t SET rowid=7 WHERE k=1").unwrap(), 1);

    let rows = select(&mut db, "SELECT rowid, k, v FROM t");
    assert_eq!(int(&rows[0].values[0]), 7); // rowid
    assert_eq!(int(&rows[0].values[1]), 7); // k (IPK)
    assert_eq!(text(&rows[0].values[2]), "a");
}

/// IPK collision via `SET rowid=` reports against the IPK column, not `.rowid`.
#[test]
fn set_rowid_ipk_conflict_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'a')");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'b')");

    let err = update(&mut db, "UPDATE t SET rowid=2 WHERE k=1").unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.k"),
        "expected IPK UNIQUE error, got: {}",
        err
    );
}

// ---------------------------------------------------------------------------
// Issue #5575: single-statement IPK (rowid-alias) relocation is checked
// IMMEDIATELY row-by-row, exactly like the virtual-rowid path above. On an
// INTEGER PRIMARY KEY table the IPK column IS the rowid, so a `SET <ipk>=` /
// `SET rowid=` swap / N-cycle / ascending `+1` cascade must error on the
// intermediate collision (NOT be deferred to the final state), reported against
// `<table>.<ipk>`. The `-1` descending cascade, move-to-gap, and self no-op
// still succeed. All verified against sqlite3 3.51.0.
//
// This is the IPK counterpart of the virtual-rowid tests above. The deferred
// final-state PK/UNIQUE check for regular columns is unchanged; the additive
// immediate check for those columns is covered by the #5588 tests near the end
// of this file, and the legitimate deferred *shift* cases (#5137) still pass —
// see `regular_unique_column_shift_still_allowed_deferred` below.
// ---------------------------------------------------------------------------

/// IPK swap via the IPK column: `UPDATE t SET k=CASE...` errors on the
/// intermediate collision (sqlite3 3.51.0: `UNIQUE constraint failed: t.k`).
#[test]
fn set_ipk_swap_errors_intermediate_collision() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'a')");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'b')");

    let err = update(&mut db, "UPDATE t SET k = CASE k WHEN 1 THEN 2 WHEN 2 THEN 1 END")
        .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.k"),
        "expected IPK UNIQUE error for swap, got: {}",
        err
    );

    // Table unchanged after the aborted UPDATE.
    let rows = select(&mut db, "SELECT k, v FROM t ORDER BY k");
    let got: Vec<(i64, String)> =
        rows.iter().map(|r| (int(&r.values[0]), text(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, "a".to_string()), (2, "b".to_string())]);
}

/// IPK swap via the `rowid` alias on an IPK table — same immediate check, still
/// reported against the IPK column name (sqlite3 3.51.0).
#[test]
fn set_rowid_alias_ipk_swap_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'a')");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'b')");

    let err = update(
        &mut db,
        "UPDATE t SET rowid = CASE rowid WHEN 1 THEN 2 WHEN 2 THEN 1 END",
    )
    .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.k"),
        "expected IPK UNIQUE error for rowid-alias swap, got: {}",
        err
    );
}

/// IPK 3-cycle (1->2, 2->3, 3->1) errors: ascending processing, 1->2 collides
/// with the still-live IPK 2. Matches sqlite3 3.51.0.
#[test]
fn set_ipk_three_cycle_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'a')");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'b')");
    ddl(&mut db, "INSERT INTO t VALUES(3, 'c')");

    let err = update(
        &mut db,
        "UPDATE t SET k = CASE k WHEN 1 THEN 2 WHEN 2 THEN 3 WHEN 3 THEN 1 END",
    )
    .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.k"),
        "expected IPK UNIQUE error for 3-cycle, got: {}",
        err
    );
}

/// `UPDATE t SET k = k + 1` over ascending IPK rows cascade-collides: 1 -> 2
/// collides with the still-live IPK 2. sqlite3 3.51.0 errors (the IPK is the
/// rowid; checked immediately, not deferred).
#[test]
fn set_ipk_plus_one_cascade_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'a')");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'b')");
    ddl(&mut db, "INSERT INTO t VALUES(3, 'c')");

    let err = update(&mut db, "UPDATE t SET k = k + 1").unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: t.k"),
        "expected IPK UNIQUE error for +1 cascade, got: {}",
        err
    );
}

/// `UPDATE t SET k = k - 1` over ascending IPK rows succeeds: processed
/// ascending, each old IPK slot is vacated before the next row needs it. sqlite3
/// 3.51.0 accepts this — the asymmetry with `+1` confirms the immediate
/// row-by-row ascending order (same as virtual rowid).
#[test]
fn set_ipk_minus_one_cascade_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'a')");
    ddl(&mut db, "INSERT INTO t VALUES(3, 'b')");
    ddl(&mut db, "INSERT INTO t VALUES(4, 'c')");

    assert_eq!(update(&mut db, "UPDATE t SET k = k - 1").unwrap(), 3);

    let rows = select(&mut db, "SELECT k, v FROM t ORDER BY k");
    let got: Vec<(i64, String)> =
        rows.iter().map(|r| (int(&r.values[0]), text(&r.values[1]))).collect();
    assert_eq!(
        got,
        vec![(1, "a".to_string()), (2, "b".to_string()), (3, "c".to_string())]
    );
}

/// Relocating an IPK row into a free gap (no collision at any step) succeeds.
/// Matches sqlite3 3.51.0.
#[test]
fn set_ipk_move_to_gap_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'a')");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'b')");

    assert_eq!(update(&mut db, "UPDATE t SET k = k + 100 WHERE k = 1").unwrap(), 1);

    let rows = select(&mut db, "SELECT k, v FROM t ORDER BY k");
    let got: Vec<(i64, String)> =
        rows.iter().map(|r| (int(&r.values[0]), text(&r.values[1]))).collect();
    assert_eq!(got, vec![(2, "b".to_string()), (101, "a".to_string())]);
}

/// `UPDATE t SET k = k` is a no-op for every IPK row and must not error. Matches
/// sqlite3 3.51.0.
#[test]
fn set_ipk_self_noop_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(k INTEGER PRIMARY KEY, v)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'a')");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'b')");
    ddl(&mut db, "INSERT INTO t VALUES(3, 'c')");

    assert_eq!(update(&mut db, "UPDATE t SET k = k").unwrap(), 3);

    let rows = select(&mut db, "SELECT k, v FROM t ORDER BY k");
    let got: Vec<(i64, String)> =
        rows.iter().map(|r| (int(&r.values[0]), text(&r.values[1]))).collect();
    assert_eq!(
        got,
        vec![(1, "a".to_string()), (2, "b".to_string()), (3, "c".to_string())]
    );
}

/// Issue #5588: a single-statement swap on a regular (non-rowid) UNIQUE column
/// errors IMMEDIATELY in sqlite3 3.51.0, exactly like the IPK swap above. `k`
/// here is a plain UNIQUE column (the rowid is the separate `id` IPK). Processing
/// in ascending rowid order, `id=1`'s `k` 10 -> 20 collides with `id=2`'s
/// still-live `k=20`, so sqlite3 reports `UNIQUE constraint failed: u.k`.
///
/// NOTE: this test previously asserted that the swap was ACCEPTED (VibeSQL's old
/// deferred-only behavior). #5588 closes that parity gap by adding an immediate
/// intermediate-collision check (`validate_unique_relocation`) for regular UNIQUE
/// columns, mirroring the rowid/IPK path. The deferred final-state validator is
/// unchanged; the legitimate deferred *shift* cases (#5137) still pass — see
/// `regular_unique_column_shift_still_allowed_deferred` below.
#[test]
fn regular_unique_column_swap_errors_intermediate_collision() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");

    let err = update(&mut db, "UPDATE u SET k = CASE k WHEN 10 THEN 20 WHEN 20 THEN 10 END")
        .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: u.k"),
        "expected regular-UNIQUE swap to error immediately, got: {}",
        err
    );

    // Table unchanged after the aborted UPDATE.
    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 10), (2, 20)]);
}

/// REGRESSION GUARD: a regular UNIQUE-column *shift* (`k = k - 10`) on a table
/// whose IPK (`id`) is unchanged must still succeed via the deferred path
/// (issue #5137). The IPK column is untouched, so the immediate rowid check finds
/// no relocations and does not interfere.
#[test]
fn regular_unique_column_shift_still_allowed_deferred() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");
    ddl(&mut db, "INSERT INTO u VALUES(3, 30)");

    assert_eq!(update(&mut db, "UPDATE u SET k = k - 10").unwrap(), 3);

    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 0), (2, 10), (3, 20)]);
}

/// An index on another column still finds the row after a rowid relocation.
#[test]
fn index_consistent_after_relocate() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t(x, y)");
    ddl(&mut db, "CREATE INDEX iy ON t(y)");
    ddl(&mut db, "INSERT INTO t VALUES(1, 'aa')");
    ddl(&mut db, "INSERT INTO t VALUES(2, 'bb')");

    assert_eq!(update(&mut db, "UPDATE t SET rowid=99 WHERE rowid=1").unwrap(), 1);

    // Index scan on y must report the relocated rowid (99), not the slot (1).
    let rows = select(&mut db, "SELECT rowid, x, y FROM t WHERE y='aa'");
    assert_eq!(rows.len(), 1);
    assert_eq!(int(&rows[0].values[0]), 99);
    assert_eq!(int(&rows[0].values[1]), 1);
    assert_eq!(text(&rows[0].values[2]), "aa");
}

/// BEFORE/AFTER UPDATE triggers see OLD.rowid (old) and NEW.rowid (new).
#[test]
fn triggers_see_old_and_new_rowid() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t8(x)");
    ddl(&mut db, "CREATE TABLE t7(a, b)");
    ddl(&mut db, "INSERT INTO t7 VALUES(1, 2)");
    ddl(
        &mut db,
        "CREATE TRIGGER t7tb BEFORE UPDATE ON t7 BEGIN \
         INSERT INTO t8 VALUES('before ' || old.rowid || '->' || new.rowid); END",
    );
    ddl(
        &mut db,
        "CREATE TRIGGER t7ta AFTER UPDATE ON t7 BEGIN \
         INSERT INTO t8 VALUES('after ' || old.rowid || '->' || new.rowid); END",
    );

    assert_eq!(update(&mut db, "UPDATE t7 SET rowid=8 WHERE rowid=1").unwrap(), 1);

    let t7 = select(&mut db, "SELECT rowid, a, b FROM t7");
    assert_eq!(int(&t7[0].values[0]), 8);
    assert_eq!(int(&t7[0].values[1]), 1);
    assert_eq!(int(&t7[0].values[2]), 2);

    let t8 = select(&mut db, "SELECT x FROM t8 ORDER BY rowid");
    let log: Vec<String> = t8.iter().map(|r| text(&r.values[0])).collect();
    assert_eq!(log, vec!["before 1->8".to_string(), "after 1->8".to_string()]);
}

/// triggerC-7.5: a BEFORE UPDATE trigger relocates *another* row via
/// `SET rowid=`, then the AFTER UPDATE trigger logs old/new rowid. Verified
/// against sqlite3 3.51.0:
///   T7 = (2,3,4) (3,5,7) (8,1,2)
///   T8 = "after fired 1->8", "after fired 3->3"
///
/// The SET-rowid relocation (#5517) makes the *table* state (T7) match sqlite3
/// exactly: the nested `UPDATE t7 SET rowid=8` fired inside the BEFORE trigger
/// relocates rowid 1 -> 8.
///
/// The T8 AFTER-trigger log now ALSO matches sqlite3 exactly. The nested
/// `UPDATE t7 SET rowid=8` fired inside the BEFORE trigger body fires its own
/// AFTER trigger ("after fired 1->8") and logs FIRST (it completes before the
/// outer UPDATE's AFTER trigger runs), then the outer UPDATE's AFTER trigger
/// logs "after fired 3->3". This is the post-#5550 behavior: #5550 made nested
/// DML fired from a trigger body fire its own row triggers, which fully resolved
/// the gap previously tracked by #5557 for this scenario. (PR #5556 was written
/// against a base predating #5550 and pinned the THEN-missing "after fired 1->8"
/// as a documented follow-on; that delta no longer exists.)
#[test]
fn triggerc_7_5_relocate_in_before_trigger() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE t8(x)");
    ddl(&mut db, "CREATE TABLE t7(a, b)");
    ddl(&mut db, "INSERT INTO t7 VALUES(1, 2)");
    ddl(&mut db, "INSERT INTO t7 VALUES(3, 4)");
    ddl(&mut db, "INSERT INTO t7 VALUES(5, 6)");
    ddl(
        &mut db,
        "CREATE TRIGGER t7t BEFORE UPDATE ON t7 WHEN (old.rowid!=1 OR new.rowid!=8) \
         BEGIN UPDATE t7 SET rowid = 8 WHERE rowid=1; END",
    );
    ddl(
        &mut db,
        "CREATE TRIGGER t7ta AFTER UPDATE ON t7 BEGIN \
         INSERT INTO t8 VALUES('after fired ' || old.rowid || '->' || new.rowid); END",
    );

    update(&mut db, "UPDATE t7 SET b=7 WHERE a = 5").unwrap();

    // Table state matches sqlite3 exactly: the nested SET-rowid relocate applied.
    let t7 = select(&mut db, "SELECT rowid, a, b FROM t7 ORDER BY rowid");
    let got: Vec<(i64, i64, i64)> = t7
        .iter()
        .map(|r| (int(&r.values[0]), int(&r.values[1]), int(&r.values[2])))
        .collect();
    assert_eq!(got, vec![(2, 3, 4), (3, 5, 7), (8, 1, 2)]);

    // Both AFTER triggers fire, in sqlite3 3.51.0 order: the nested UPDATE's
    // AFTER trigger logs "after fired 1->8" first (it completes inside the BEFORE
    // trigger body), then the outer UPDATE's AFTER trigger logs "after fired 3->3".
    let t8 = select(&mut db, "SELECT x FROM t8 ORDER BY rowid");
    let log: Vec<String> = t8.iter().map(|r| text(&r.values[0])).collect();
    assert_eq!(
        log,
        vec![
            "after fired 1->8".to_string(),
            "after fired 3->3".to_string()
        ]
    );
}

/// triggerD-1.3/1.4 (issue #5599): an *ordinary* user column literally named
/// `rowid` (or `oid` / `_rowid_`) shadows the system rowid alias. `UPDATE t1 SET
/// rowid=rowid+1` must write that ordinary column, and the table's BEFORE/AFTER
/// UPDATE triggers (and a later DELETE trigger) must see the *updated* ordinary
/// value via `new.rowid` — not the row's internal system rowid.
///
/// Distinct from #5517 (which relocates the *system* rowid on a table that has
/// no such ordinary column); the `set_rowid_relocates_row` test above covers
/// that path and must keep passing alongside this one. Verified against
/// sqlite3 3.51.0.
#[test]
fn shadow_column_named_rowid_reflected_in_triggers() {
    let mut db = vibesql_storage::Database::new();
    // t1 has ordinary columns named rowid/oid/_rowid_ that shadow the aliases.
    ddl(&mut db, "CREATE TABLE t1(rowid, oid, _rowid_, x)");
    ddl(&mut db, "CREATE TABLE log(a, b, c, d, e)");
    ddl(
        &mut db,
        "CREATE TRIGGER r3 BEFORE UPDATE ON t1 BEGIN \
         INSERT INTO log VALUES('r3.old', old.rowid, old.oid, old._rowid_, old.x); \
         INSERT INTO log VALUES('r3.new', new.rowid, new.oid, new._rowid_, new.x); END",
    );
    ddl(
        &mut db,
        "CREATE TRIGGER r4 AFTER UPDATE ON t1 BEGIN \
         INSERT INTO log VALUES('r4.old', old.rowid, old.oid, old._rowid_, old.x); \
         INSERT INTO log VALUES('r4.new', new.rowid, new.oid, new._rowid_, new.x); END",
    );
    ddl(
        &mut db,
        "CREATE TRIGGER r6 AFTER DELETE ON t1 BEGIN \
         INSERT INTO log VALUES('r6', old.rowid, old.oid, old._rowid_, old.x); END",
    );
    ddl(&mut db, "INSERT INTO t1 VALUES(100, 200, 300, 400)");

    // SET rowid=rowid+1 updates the ORDINARY column rowid: 100 -> 101.
    assert_eq!(update(&mut db, "UPDATE t1 SET rowid=rowid+1").unwrap(), 1);

    // The stored ordinary column reflects the update.
    let t1 = select(&mut db, "SELECT rowid, oid, _rowid_, x FROM t1");
    assert_eq!(int(&t1[0].values[0]), 101);
    assert_eq!(int(&t1[0].values[1]), 200);
    assert_eq!(int(&t1[0].values[2]), 300);
    assert_eq!(int(&t1[0].values[3]), 400);

    // BEFORE sees old=100/new=101; AFTER sees old=100/new=101 (sqlite3 3.51.0).
    let rows = select(&mut db, "SELECT a, b, c, d, e FROM log ORDER BY _rowid_");
    let log: Vec<(String, i64, i64, i64, i64)> = rows
        .iter()
        .map(|r| {
            (
                text(&r.values[0]),
                int(&r.values[1]),
                int(&r.values[2]),
                int(&r.values[3]),
                int(&r.values[4]),
            )
        })
        .collect();
    assert_eq!(
        log,
        vec![
            ("r3.old".to_string(), 100, 200, 300, 400),
            ("r3.new".to_string(), 101, 200, 300, 400),
            ("r4.old".to_string(), 100, 200, 300, 400),
            ("r4.new".to_string(), 101, 200, 300, 400),
        ]
    );

    // A later DELETE trigger sees the updated ordinary value (triggerD-1.4).
    delete(&mut db, "DELETE FROM log");
    delete(&mut db, "DELETE FROM t1");
    let after_delete = select(&mut db, "SELECT a, b, c, d, e FROM log");
    assert_eq!(after_delete.len(), 1);
    assert_eq!(text(&after_delete[0].values[0]), "r6");
    assert_eq!(int(&after_delete[0].values[1]), 101);
    assert_eq!(int(&after_delete[0].values[2]), 200);
    assert_eq!(int(&after_delete[0].values[3]), 300);
    assert_eq!(int(&after_delete[0].values[4]), 400);
}

// ===========================================================================
// Issue #5588: regular (non-rowid) UNIQUE / PRIMARY KEY columns also get the
// IMMEDIATE row-by-row intermediate-collision check, mirroring the rowid/IPK
// path (#5559/#5575). sqlite3 3.51.0 processes the UPDATE in ascending rowid
// order with vacate-before-occupy. Every case below was verified against
// /usr/bin/sqlite3 3.51.0. The genuine deferred-shift cases that sqlite3 still
// accepts (issue #5137) are covered both here (the `*_ok` cases) and in
// tests/update_deferred_uniqueness_tests.rs — those must keep passing.
// ===========================================================================

/// `UPDATE u SET k = k + 10` (ascending shift) on a regular UNIQUE column errors:
/// processing `id=1` first, `k` 10 -> 20 collides with `id=2`'s still-live 20.
/// sqlite3 3.51.0: `UNIQUE constraint failed: u.k`.
#[test]
fn regular_unique_plus_ten_cascade_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");
    ddl(&mut db, "INSERT INTO u VALUES(3, 30)");

    let err = update(&mut db, "UPDATE u SET k = k + 10").unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: u.k"),
        "expected ascending-shift UNIQUE error, got: {}",
        err
    );

    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 10), (2, 20), (3, 30)]);
}

/// `UPDATE u SET k = k - 10` (descending shift) on a regular UNIQUE column
/// SUCCEEDS — each old slot is vacated before the next row reuses it (issue
/// #5137). sqlite3 3.51.0 accepts this; the immediate check must not regress it.
#[test]
fn regular_unique_minus_ten_cascade_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");
    ddl(&mut db, "INSERT INTO u VALUES(3, 30)");

    assert_eq!(update(&mut db, "UPDATE u SET k = k - 10").unwrap(), 3);

    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 0), (2, 10), (3, 20)]);
}

/// Regular UNIQUE 3-cycle (10->20->30->10) errors on the first intermediate
/// collision. sqlite3 3.51.0: `UNIQUE constraint failed: u.k`.
#[test]
fn regular_unique_three_cycle_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");
    ddl(&mut db, "INSERT INTO u VALUES(3, 30)");

    let err = update(
        &mut db,
        "UPDATE u SET k = CASE k WHEN 10 THEN 20 WHEN 20 THEN 30 WHEN 30 THEN 10 END",
    )
    .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: u.k"),
        "expected 3-cycle UNIQUE error, got: {}",
        err
    );
}

/// Shifting one regular-UNIQUE row onto an existing live value errors. sqlite3
/// 3.51.0: `UNIQUE constraint failed: u.k`.
#[test]
fn regular_unique_shift_into_occupied_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");

    let err = update(&mut db, "UPDATE u SET k = 20 WHERE k = 10").unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: u.k"),
        "expected shift-into-occupied UNIQUE error, got: {}",
        err
    );
}

/// Moving one regular-UNIQUE row to a free value SUCCEEDS (no collision).
#[test]
fn regular_unique_move_to_gap_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");

    assert_eq!(update(&mut db, "UPDATE u SET k = 99 WHERE k = 10").unwrap(), 1);

    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 99), (2, 20)]);
}

/// `UPDATE u SET k = -k` (negation, no key reuse) SUCCEEDS. New values (-10,-20)
/// collide with no live key. sqlite3 3.51.0 accepts.
#[test]
fn regular_unique_negation_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");

    assert_eq!(update(&mut db, "UPDATE u SET k = -k").unwrap(), 2);

    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, -10), (2, -20)]);
}

/// free-before-reuse SUCCEEDS: `id=1` (k=10) vacates 10 to a gap (99), then
/// `id=2` (k=20) takes the freed 10. Processed ascending, the slot is free in
/// time. sqlite3 3.51.0 accepts.
#[test]
fn regular_unique_free_before_reuse_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");

    assert_eq!(
        update(&mut db, "UPDATE u SET k = CASE k WHEN 10 THEN 99 WHEN 20 THEN 10 END").unwrap(),
        2
    );

    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 99), (2, 10)]);
}

/// reuse-before-free ERRORS: rowid order is decisive. `id=1` holds k=20 and wants
/// k=10, but `id=2` still holds k=10 when `id=1` is processed first. sqlite3
/// 3.51.0: `UNIQUE constraint failed: u.k` (contrast with free-before-reuse).
#[test]
fn regular_unique_reuse_before_free_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 20)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 10)");

    let err = update(&mut db, "UPDATE u SET k = CASE k WHEN 20 THEN 10 WHEN 10 THEN 99 END")
        .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: u.k"),
        "expected reuse-before-free UNIQUE error, got: {}",
        err
    );
}

/// Swapping a regular UNIQUE column to NULL for all rows SUCCEEDS — multiple
/// NULLs are allowed in a UNIQUE column. sqlite3 3.51.0 accepts.
#[test]
fn regular_unique_to_null_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");

    assert_eq!(update(&mut db, "UPDATE u SET k = NULL").unwrap(), 2);

    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    assert_eq!(rows.len(), 2);
    assert!(matches!(rows[0].values[1], SqlValue::Null));
    assert!(matches!(rows[1].values[1], SqlValue::Null));
}

/// Composite table-level `UNIQUE(a,b)` swap errors immediately, reported against
/// both columns. sqlite3 3.51.0: `UNIQUE constraint failed: c.a, c.b`.
#[test]
fn regular_composite_unique_swap_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE c(id INTEGER PRIMARY KEY, a INT, b INT, UNIQUE(a, b))");
    ddl(&mut db, "INSERT INTO c VALUES(1, 1, 1)");
    ddl(&mut db, "INSERT INTO c VALUES(2, 2, 2)");

    let err = update(
        &mut db,
        "UPDATE c SET a = CASE a WHEN 1 THEN 2 WHEN 2 THEN 1 END, \
         b = CASE b WHEN 1 THEN 2 WHEN 2 THEN 1 END",
    )
    .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: c.a, c.b"),
        "expected composite-UNIQUE swap error, got: {}",
        err
    );
}

/// Composite PRIMARY KEY swap on a virtual-rowid table errors immediately,
/// reported against the PK columns. sqlite3 3.51.0: `UNIQUE constraint failed: c.a, c.b`.
#[test]
fn composite_pk_swap_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE c(a INT, b INT, v TEXT, PRIMARY KEY(a, b))");
    ddl(&mut db, "INSERT INTO c VALUES(1, 1, 'r1')");
    ddl(&mut db, "INSERT INTO c VALUES(2, 2, 'r2')");

    let err = update(
        &mut db,
        "UPDATE c SET a = CASE a WHEN 1 THEN 2 WHEN 2 THEN 1 END, \
         b = CASE b WHEN 1 THEN 2 WHEN 2 THEN 1 END",
    )
    .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: c.a, c.b"),
        "expected composite-PK swap error, got: {}",
        err
    );
}

/// Composite PRIMARY KEY descending shift (`b = b - 1`) SUCCEEDS — the #5137
/// deferred case. Must keep passing alongside the swap-errors case above.
#[test]
fn composite_pk_descending_shift_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE c(a INT, b INT, v TEXT, PRIMARY KEY(a, b))");
    ddl(&mut db, "INSERT INTO c VALUES(1, 0, 'r1')");
    ddl(&mut db, "INSERT INTO c VALUES(1, 1, 'r2')");
    ddl(&mut db, "INSERT INTO c VALUES(1, 2, 'r3')");

    assert_eq!(update(&mut db, "UPDATE c SET b = b - 1").unwrap(), 3);

    let rows = select(&mut db, "SELECT a, b FROM c ORDER BY b");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, -1), (1, 0), (1, 1)]);
}

/// User-defined `CREATE UNIQUE INDEX` swap errors immediately, reported against
/// the indexed column. sqlite3 3.51.0: `UNIQUE constraint failed: u.k`.
#[test]
fn user_unique_index_swap_errors() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT)");
    ddl(&mut db, "CREATE UNIQUE INDEX u_k ON u(k)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");

    let err = update(&mut db, "UPDATE u SET k = CASE k WHEN 10 THEN 20 WHEN 20 THEN 10 END")
        .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: u.k"),
        "expected user-UNIQUE-index swap error, got: {}",
        err
    );
}

/// User-defined UNIQUE index descending shift (`k = k - 10`) SUCCEEDS — the
/// #5137 deferred case via the user-index path. Must keep passing.
#[test]
fn user_unique_index_descending_shift_ok() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(id INTEGER PRIMARY KEY, k INT)");
    ddl(&mut db, "CREATE UNIQUE INDEX u_k ON u(k)");
    ddl(&mut db, "INSERT INTO u VALUES(1, 10)");
    ddl(&mut db, "INSERT INTO u VALUES(2, 20)");
    ddl(&mut db, "INSERT INTO u VALUES(3, 30)");

    assert_eq!(update(&mut db, "UPDATE u SET k = k - 10").unwrap(), 3);

    let rows = select(&mut db, "SELECT id, k FROM u ORDER BY id");
    let got: Vec<(i64, i64)> =
        rows.iter().map(|r| (int(&r.values[0]), int(&r.values[1]))).collect();
    assert_eq!(got, vec![(1, 0), (2, 10), (3, 20)]);
}

/// Regular UNIQUE column on a VIRTUAL-rowid table (no IPK): swap still errors via
/// the storage rowid order. sqlite3 3.51.0: `UNIQUE constraint failed: u.k`.
#[test]
fn regular_unique_swap_errors_virtual_rowid_table() {
    let mut db = vibesql_storage::Database::new();
    ddl(&mut db, "CREATE TABLE u(x TEXT, k INT UNIQUE)");
    ddl(&mut db, "INSERT INTO u VALUES('a', 10)");
    ddl(&mut db, "INSERT INTO u VALUES('b', 20)");

    let err = update(&mut db, "UPDATE u SET k = CASE k WHEN 10 THEN 20 WHEN 20 THEN 10 END")
        .unwrap_err();
    assert!(
        err.to_string().contains("UNIQUE constraint failed: u.k"),
        "expected virtual-rowid table UNIQUE swap error, got: {}",
        err
    );
}