1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
//! REVOKE statement executor
use vibesql_ast::*;
use vibesql_storage::Database;
use crate::errors::ExecutorError;
/// Executor for REVOKE statements
pub struct RevokeExecutor;
impl RevokeExecutor {
/// Execute REVOKE statement
///
/// Phase 3: Supports CASCADE/RESTRICT and GRANT OPTION FOR
pub fn execute_revoke(
stmt: &RevokeStmt,
database: &mut Database,
) -> Result<String, ExecutorError> {
// Validate object exists based on object type
match stmt.object_type {
ObjectType::Table => {
if !database.catalog.table_exists(&stmt.object_name) {
return Err(ExecutorError::TableNotFound(stmt.object_name.clone()));
}
}
ObjectType::Schema => {
if !database.catalog.schema_exists(&stmt.object_name) {
return Err(ExecutorError::SchemaNotFound(stmt.object_name.clone()));
}
}
// SQL:1999 Feature F031: New object types
// Accept without validation - implementations are future work
ObjectType::Domain
| ObjectType::Collation
| ObjectType::CharacterSet
| ObjectType::Translation
| ObjectType::Type
| ObjectType::Sequence => {
// No validation - these objects are stubbed for conformance
}
// Functions (SQL:1999 Feature P001)
ObjectType::Function | ObjectType::SpecificFunction => {
// Allow REVOKE on non-existent functions (SQL:1999 compliance)
// No validation - silently succeed if function doesn't exist
}
// Procedures (SQL:1999 Feature P001)
ObjectType::Procedure | ObjectType::SpecificProcedure => {
// Allow REVOKE on non-existent procedures (SQL:1999 compliance)
// No validation - silently succeed if procedure doesn't exist
}
// Routine (generic term for function or procedure)
ObjectType::Routine | ObjectType::SpecificRoutine => {
// Allow REVOKE on non-existent routines (SQL:1999 compliance)
// No validation - silently succeed if routine doesn't exist
}
// Methods (SQL:1999 Feature S091) - OOP SQL
// For now, accept without validation - full UDT implementation is future work
ObjectType::Method
| ObjectType::ConstructorMethod
| ObjectType::StaticMethod
| ObjectType::InstanceMethod
| ObjectType::SpecificMethod
| ObjectType::SpecificConstructorMethod
| ObjectType::SpecificStaticMethod
| ObjectType::SpecificInstanceMethod => {
// No validation - methods belong to UDTs which aren't fully implemented yet
// Privilege tracking works by object name alone
}
}
// Validate all grantees (roles) exist
for grantee in &stmt.grantees {
if !database.catalog.role_exists(grantee) {
return Err(ExecutorError::RoleNotFound(grantee.clone()));
}
}
// Expand ALL PRIVILEGES based on object type
let expanded_privileges = if stmt.privileges.contains(&PrivilegeType::AllPrivileges) {
match stmt.object_type {
ObjectType::Table => vec![
PrivilegeType::Select(None),
PrivilegeType::Insert(None),
PrivilegeType::Update(None),
PrivilegeType::Delete,
PrivilegeType::References(None),
],
ObjectType::Schema => vec![PrivilegeType::Usage, PrivilegeType::Create],
// USAGE-only objects (domains, collations, character sets, translations, types,
// sequences) ALL PRIVILEGES on these objects means USAGE privilege
ObjectType::Domain
| ObjectType::Collation
| ObjectType::CharacterSet
| ObjectType::Translation
| ObjectType::Type
| ObjectType::Sequence => vec![PrivilegeType::Usage],
// Callable objects (functions, procedures, routines, methods)
// ALL PRIVILEGES on callable objects means EXECUTE privilege
ObjectType::Function
| ObjectType::Procedure
| ObjectType::Routine
| ObjectType::Method
| ObjectType::ConstructorMethod
| ObjectType::StaticMethod
| ObjectType::InstanceMethod
| ObjectType::SpecificFunction
| ObjectType::SpecificProcedure
| ObjectType::SpecificRoutine
| ObjectType::SpecificMethod
| ObjectType::SpecificConstructorMethod
| ObjectType::SpecificStaticMethod
| ObjectType::SpecificInstanceMethod => vec![PrivilegeType::Execute],
}
} else {
stmt.privileges.clone()
};
// For RESTRICT, check for dependent grants before making any changes
if matches!(stmt.cascade_option, CascadeOption::Restrict) {
for grantee in &stmt.grantees {
for privilege in &expanded_privileges {
if database.catalog.has_dependent_grants(&stmt.object_name, grantee, privilege)
{
return Err(ExecutorError::DependentPrivilegesExist(format!(
"Cannot revoke {:?} on {} from {} - dependent grants exist (use CASCADE to revoke dependent grants)",
privilege,
stmt.object_name,
grantee
)));
}
}
}
}
// Revoke privileges for each grantee and privilege
let mut total_removed = 0;
for grantee in &stmt.grantees {
for privilege in &expanded_privileges {
// Remove the grant
let removed = database.catalog.remove_grants(
&stmt.object_name,
grantee,
privilege,
stmt.grant_option_for,
);
total_removed += removed;
// If CASCADE, recursively revoke from dependent grantees
if matches!(stmt.cascade_option, CascadeOption::Cascade) {
Self::revoke_cascade(
database,
&stmt.object_name,
grantee,
privilege,
stmt.grant_option_for,
)?;
}
}
}
let grantees_str = stmt.grantees.join(", ");
let privileges_str =
stmt.privileges.iter().map(|p| format!("{:?}", p)).collect::<Vec<_>>().join(", ");
let action = if stmt.grant_option_for { "Revoked grant option for" } else { "Revoked" };
Ok(format!(
"{} {} on {} from {} ({} grants affected)",
action, privileges_str, stmt.object_name, grantees_str, total_removed
))
}
/// Recursively revoke privileges from dependent grantees (CASCADE behavior)
fn revoke_cascade(
database: &mut Database,
object: &str,
grantor: &str,
privilege: &PrivilegeType,
grant_option_only: bool,
) -> Result<(), ExecutorError> {
// Find all grants that were made by this grantor
let dependent_grants: Vec<String> = database
.catalog
.get_all_grants()
.iter()
.filter(|g| g.object == object && g.grantor == grantor && g.privilege == *privilege)
.map(|g| g.grantee.clone())
.collect();
// Recursively revoke from each dependent grantee
for dependent_grantee in dependent_grants {
database.catalog.remove_grants(
object,
&dependent_grantee,
privilege,
grant_option_only,
);
// Recursively cascade
Self::revoke_cascade(
database,
object,
&dependent_grantee,
privilege,
grant_option_only,
)?;
}
Ok(())
}
}