vibesql-executor 0.2.0

Query execution engine for vibesql SQL database
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
// CSE tests
mod cse_tests;

// Compiled CASE expression tests
mod compiled_case_tests;

// Evaluator tests
mod evaluator_tests {
    use vibesql_catalog::{ColumnSchema, TableSchema};
    use vibesql_types::{DataType, SqlValue};

    use super::super::ExpressionEvaluator;
    use crate::errors::ExecutorError;

    #[test]
    fn test_evaluator_with_outer_context_resolves_inner_column() {
        // Create inner schema with "inner_col"
        let inner_schema = TableSchema::new(
            "inner".to_string(),
            vec![ColumnSchema::new("inner_col".to_string(), DataType::Integer, false)],
        );

        // Create outer schema with "outer_col"
        let outer_schema = TableSchema::new(
            "outer".to_string(),
            vec![ColumnSchema::new("outer_col".to_string(), DataType::Integer, false)],
        );

        let outer_row = vibesql_storage::Row::new(vec![SqlValue::Integer(100)]);
        let inner_row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        let evaluator =
            ExpressionEvaluator::with_outer_context(&inner_schema, &outer_row, &outer_schema);

        // Should resolve inner_col from inner row
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::simple(
            "inner_col",
            false,
        ));

        let result = evaluator.eval(&expr, &inner_row).unwrap();
        assert_eq!(result, SqlValue::Integer(42));
    }

    #[test]
    fn test_evaluator_with_outer_context_resolves_outer_column() {
        // Create inner schema with "inner_col"
        let inner_schema = TableSchema::new(
            "inner".to_string(),
            vec![ColumnSchema::new("inner_col".to_string(), DataType::Integer, false)],
        );

        // Create outer schema with "outer_col"
        let outer_schema = TableSchema::new(
            "outer".to_string(),
            vec![ColumnSchema::new("outer_col".to_string(), DataType::Integer, false)],
        );

        let outer_row = vibesql_storage::Row::new(vec![SqlValue::Integer(100)]);
        let inner_row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        let evaluator =
            ExpressionEvaluator::with_outer_context(&inner_schema, &outer_row, &outer_schema);

        // Should resolve outer_col from outer row (not in inner schema)
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::simple(
            "outer_col",
            false,
        ));

        let result = evaluator.eval(&expr, &inner_row).unwrap();
        assert_eq!(result, SqlValue::Integer(100));
    }

    #[test]
    fn test_evaluator_with_outer_context_inner_shadows_outer() {
        // Both schemas have "col" - inner should win
        let inner_schema = TableSchema::new(
            "inner".to_string(),
            vec![ColumnSchema::new("col".to_string(), DataType::Integer, false)],
        );

        let outer_schema = TableSchema::new(
            "outer".to_string(),
            vec![ColumnSchema::new("col".to_string(), DataType::Integer, false)],
        );

        let outer_row = vibesql_storage::Row::new(vec![SqlValue::Integer(999)]);
        let inner_row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        let evaluator =
            ExpressionEvaluator::with_outer_context(&inner_schema, &outer_row, &outer_schema);

        let expr =
            vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::simple("col", false));

        let result = evaluator.eval(&expr, &inner_row).unwrap();
        // Should get inner value (42), not outer (999)
        assert_eq!(result, SqlValue::Integer(42));
    }

    #[test]
    fn test_evaluator_with_outer_context_column_not_found() {
        let inner_schema = TableSchema::new(
            "inner".to_string(),
            vec![ColumnSchema::new("inner_col".to_string(), DataType::Integer, false)],
        );

        let outer_schema = TableSchema::new(
            "outer".to_string(),
            vec![ColumnSchema::new("outer_col".to_string(), DataType::Integer, false)],
        );

        let outer_row = vibesql_storage::Row::new(vec![SqlValue::Integer(100)]);
        let inner_row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        let evaluator =
            ExpressionEvaluator::with_outer_context(&inner_schema, &outer_row, &outer_schema);

        // Try to resolve non-existent column
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::simple(
            "nonexistent",
            false,
        ));

        let result = evaluator.eval(&expr, &inner_row);
        assert!(matches!(result, Err(ExecutorError::ColumnNotFound { .. })));
    }

    #[test]
    fn test_evaluator_without_outer_context() {
        // Normal evaluator without outer context
        let schema = TableSchema::new(
            "table".to_string(),
            vec![ColumnSchema::new("col".to_string(), DataType::Integer, false)],
        );

        let evaluator = ExpressionEvaluator::new(&schema);
        let row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        let expr =
            vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::simple("col", false));

        let result = evaluator.eval(&expr, &row).unwrap();
        assert_eq!(result, SqlValue::Integer(42));
    }

    #[test]
    fn test_improved_error_message_includes_searched_tables() {
        // Test that error message includes searched tables
        let inner_schema = TableSchema::new(
            "users".to_string(),
            vec![
                ColumnSchema::new("id".to_string(), DataType::Integer, false),
                ColumnSchema::new(
                    "name".to_string(),
                    DataType::Varchar { max_length: Some(255) },
                    false,
                ),
            ],
        );

        let outer_schema = TableSchema::new(
            "orders".to_string(),
            vec![
                ColumnSchema::new("order_id".to_string(), DataType::Integer, false),
                ColumnSchema::new("amount".to_string(), DataType::Integer, false),
            ],
        );

        let outer_row =
            vibesql_storage::Row::new(vec![SqlValue::Integer(1), SqlValue::Integer(100)]);
        let inner_row = vibesql_storage::Row::new(vec![
            SqlValue::Integer(42),
            SqlValue::Varchar(arcstr::ArcStr::from("Alice")),
        ]);

        let evaluator =
            ExpressionEvaluator::with_outer_context(&inner_schema, &outer_row, &outer_schema);

        // Try to resolve non-existent column
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::simple(
            "email", false,
        ));

        let result = evaluator.eval(&expr, &inner_row);

        match result {
            Err(ExecutorError::ColumnNotFound {
                column_name,
                searched_tables,
                available_columns,
                ..
            }) => {
                assert_eq!(column_name, "email");
                assert!(
                    searched_tables.contains(&"users".to_string()),
                    "Should have searched 'users' table"
                );
                assert!(
                    searched_tables.contains(&"orders".to_string()),
                    "Should have searched 'orders' table"
                );
                assert!(
                    available_columns.contains(&"id".to_string()),
                    "Should list 'id' as available"
                );
                assert!(
                    available_columns.contains(&"name".to_string()),
                    "Should list 'name' as available"
                );
                assert!(
                    available_columns.contains(&"order_id".to_string()),
                    "Should list 'order_id' as available"
                );
                assert!(
                    available_columns.contains(&"amount".to_string()),
                    "Should list 'amount' as available"
                );
            }
            other => panic!("Expected ColumnNotFound with diagnostic info, got: {:?}", other),
        }
    }

    #[test]
    fn test_improved_error_message_with_table_qualifier() {
        // Test that table qualifier is captured in error message
        let schema = TableSchema::new(
            "products".to_string(),
            vec![
                ColumnSchema::new("product_id".to_string(), DataType::Integer, false),
                ColumnSchema::new("price".to_string(), DataType::Integer, false),
            ],
        );

        let evaluator = ExpressionEvaluator::new(&schema);
        let row = vibesql_storage::Row::new(vec![SqlValue::Integer(1), SqlValue::Integer(99)]);

        // Try to resolve with table qualifier
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::qualified(
            "products",
            false,
            "description",
            false,
        ));

        let result = evaluator.eval(&expr, &row);

        match result {
            Err(ExecutorError::ColumnNotFound {
                column_name,
                table_name,
                searched_tables,
                available_columns,
            }) => {
                assert_eq!(column_name, "description");
                assert_eq!(table_name, "products", "Should capture table qualifier");
                assert!(searched_tables.contains(&"products".to_string()));
                assert!(available_columns.contains(&"product_id".to_string()));
                assert!(available_columns.contains(&"price".to_string()));
            }
            other => panic!("Expected ColumnNotFound with table qualifier, got: {:?}", other),
        }
    }

    #[test]
    fn test_valid_table_qualifier_matches_inner_schema() {
        // Test that a valid table qualifier matching inner schema works correctly
        let schema = TableSchema::new(
            "users".to_string(),
            vec![
                ColumnSchema::new("id".to_string(), DataType::Integer, false),
                ColumnSchema::new(
                    "name".to_string(),
                    DataType::Varchar { max_length: Some(255) },
                    false,
                ),
            ],
        );

        let evaluator = ExpressionEvaluator::new(&schema);
        let row = vibesql_storage::Row::new(vec![
            SqlValue::Integer(42),
            SqlValue::Varchar(arcstr::ArcStr::from("Alice")),
        ]);

        // Column reference with correct table qualifier
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::qualified(
            "users", false, "name", false,
        ));

        let result = evaluator.eval(&expr, &row);
        assert_eq!(result, Ok(SqlValue::Varchar(arcstr::ArcStr::from("Alice"))));
    }

    #[test]
    fn test_valid_table_qualifier_case_insensitive() {
        // Test that table qualifier matching is case-insensitive
        let schema = TableSchema::new(
            "Products".to_string(),
            vec![ColumnSchema::new("id".to_string(), DataType::Integer, false)],
        );

        let evaluator = ExpressionEvaluator::new(&schema);
        let row = vibesql_storage::Row::new(vec![SqlValue::Integer(99)]);

        // Use different case for table qualifier
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::qualified(
            "PRODUCTS", false, "id", false,
        ));

        let result = evaluator.eval(&expr, &row);
        assert_eq!(result, Ok(SqlValue::Integer(99)));
    }

    #[test]
    fn test_invalid_table_qualifier_single_schema() {
        // Test that invalid table qualifier returns proper error
        let schema = TableSchema::new(
            "users".to_string(),
            vec![ColumnSchema::new("id".to_string(), DataType::Integer, false)],
        );

        let evaluator = ExpressionEvaluator::new(&schema);
        let row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        // Column reference with wrong table qualifier
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::qualified(
            "products", false, "id", false,
        ));

        let result = evaluator.eval(&expr, &row);

        match result {
            Err(ExecutorError::InvalidTableQualifier { qualifier, column, available_tables }) => {
                assert_eq!(qualifier, "products");
                assert_eq!(column, "id");
                assert!(available_tables.contains(&"users".to_string()));
                assert_eq!(available_tables.len(), 1);
            }
            other => panic!("Expected InvalidTableQualifier error, got: {:?}", other),
        }
    }

    #[test]
    fn test_invalid_table_qualifier_with_outer_context() {
        // Test that invalid qualifier with outer context shows both available tables
        let inner_schema = TableSchema::new(
            "orders".to_string(),
            vec![ColumnSchema::new("order_id".to_string(), DataType::Integer, false)],
        );

        let outer_schema = TableSchema::new(
            "users".to_string(),
            vec![ColumnSchema::new("user_id".to_string(), DataType::Integer, false)],
        );

        let outer_row = vibesql_storage::Row::new(vec![SqlValue::Integer(100)]);
        let inner_row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        let evaluator =
            ExpressionEvaluator::with_outer_context(&inner_schema, &outer_row, &outer_schema);

        // Column reference with invalid table qualifier
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::qualified(
            "products",
            false,
            "product_id",
            false,
        ));

        let result = evaluator.eval(&expr, &inner_row);

        match result {
            Err(ExecutorError::InvalidTableQualifier { qualifier, column, available_tables }) => {
                assert_eq!(qualifier, "products");
                assert_eq!(column, "product_id");
                assert!(available_tables.contains(&"orders".to_string()));
                assert!(available_tables.contains(&"users".to_string()));
                assert_eq!(available_tables.len(), 2);
            }
            other => panic!("Expected InvalidTableQualifier error, got: {:?}", other),
        }
    }

    #[test]
    fn test_valid_qualifier_for_outer_schema() {
        // Test that qualifier can correctly reference outer schema
        let inner_schema = TableSchema::new(
            "subquery".to_string(),
            vec![ColumnSchema::new("inner_col".to_string(), DataType::Integer, false)],
        );

        let outer_schema = TableSchema::new(
            "outer_table".to_string(),
            vec![ColumnSchema::new("outer_col".to_string(), DataType::Integer, false)],
        );

        let outer_row = vibesql_storage::Row::new(vec![SqlValue::Integer(999)]);
        let inner_row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        let evaluator =
            ExpressionEvaluator::with_outer_context(&inner_schema, &outer_row, &outer_schema);

        // Column reference with outer table qualifier
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::qualified(
            "outer_table",
            false,
            "outer_col",
            false,
        ));

        let result = evaluator.eval(&expr, &inner_row);
        assert_eq!(result, Ok(SqlValue::Integer(999)));
    }

    #[test]
    fn test_qualified_column_not_found_in_correct_table() {
        // Test that when qualifier is valid but column doesn't exist, we get proper error
        let schema = TableSchema::new(
            "users".to_string(),
            vec![
                ColumnSchema::new("id".to_string(), DataType::Integer, false),
                ColumnSchema::new(
                    "name".to_string(),
                    DataType::Varchar { max_length: Some(255) },
                    false,
                ),
            ],
        );

        let evaluator = ExpressionEvaluator::new(&schema);
        let row = vibesql_storage::Row::new(vec![
            SqlValue::Integer(42),
            SqlValue::Varchar(arcstr::ArcStr::from("Alice")),
        ]);

        // Column reference with correct table but non-existent column
        let expr = vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::qualified(
            "users", false, "email", false,
        ));

        let result = evaluator.eval(&expr, &row);

        match result {
            Err(ExecutorError::ColumnNotFound {
                column_name,
                table_name,
                searched_tables,
                available_columns,
            }) => {
                assert_eq!(column_name, "email");
                assert_eq!(table_name, "users");
                assert!(searched_tables.contains(&"users".to_string()));
                assert!(available_columns.contains(&"id".to_string()));
                assert!(available_columns.contains(&"name".to_string()));
            }
            other => panic!("Expected ColumnNotFound error, got: {:?}", other),
        }
    }

    #[test]
    fn test_qualifier_disambiguates_shadowed_column() {
        // Test that qualifier can disambiguate when inner and outer have same column name
        let inner_schema = TableSchema::new(
            "inner_table".to_string(),
            vec![ColumnSchema::new("id".to_string(), DataType::Integer, false)],
        );

        let outer_schema = TableSchema::new(
            "outer_table".to_string(),
            vec![ColumnSchema::new("id".to_string(), DataType::Integer, false)],
        );

        let outer_row = vibesql_storage::Row::new(vec![SqlValue::Integer(999)]);
        let inner_row = vibesql_storage::Row::new(vec![SqlValue::Integer(42)]);

        let evaluator =
            ExpressionEvaluator::with_outer_context(&inner_schema, &outer_row, &outer_schema);

        // Without qualifier - should get inner value (shadowing)
        let expr_unqualified =
            vibesql_ast::Expression::ColumnRef(vibesql_ast::ColumnIdentifier::simple("id", false));
        let result = evaluator.eval(&expr_unqualified, &inner_row);
        assert_eq!(result, Ok(SqlValue::Integer(42)));

        // With inner qualifier - should get inner value
        let expr_inner = vibesql_ast::Expression::ColumnRef(
            vibesql_ast::ColumnIdentifier::qualified("inner_table", false, "id", false),
        );
        let result = evaluator.eval(&expr_inner, &inner_row);
        assert_eq!(result, Ok(SqlValue::Integer(42)));

        // With outer qualifier - should get outer value
        let expr_outer = vibesql_ast::Expression::ColumnRef(
            vibesql_ast::ColumnIdentifier::qualified("outer_table", false, "id", false),
        );
        let result = evaluator.eval(&expr_outer, &inner_row);
        assert_eq!(result, Ok(SqlValue::Integer(999)));
    }
}

#[cfg(test)]
mod deep_expression_tests {
    use vibesql_catalog::TableSchema;
    use vibesql_storage::Row;
    use vibesql_types::SqlValue;

    use super::super::ExpressionEvaluator;

    /// Helper to generate a deeply nested arithmetic expression
    /// Generates: (((1 + 1) + 1) + 1) ... ) for the specified depth
    fn generate_nested_add(depth: usize) -> vibesql_ast::Expression {
        let mut expr = vibesql_ast::Expression::Literal(SqlValue::Integer(1));
        for _ in 0..depth {
            expr = vibesql_ast::Expression::BinaryOp {
                left: Box::new(expr),
                op: vibesql_ast::BinaryOperator::Plus,
                right: Box::new(vibesql_ast::Expression::Literal(SqlValue::Integer(1))),
            };
        }
        expr
    }

    /// Helper to generate deeply nested CASE expressions
    /// Generates: CASE WHEN 1 = 1 THEN (CASE WHEN 1 = 1 THEN ... ELSE 0 END) ELSE 0 END
    fn generate_nested_case(depth: usize) -> vibesql_ast::Expression {
        let mut expr = vibesql_ast::Expression::Literal(SqlValue::Integer(0));
        for _ in 0..depth {
            expr = vibesql_ast::Expression::Case {
                operand: None,
                when_clauses: vec![vibesql_ast::CaseWhen {
                    conditions: vec![vibesql_ast::Expression::BinaryOp {
                        left: Box::new(vibesql_ast::Expression::Literal(SqlValue::Integer(1))),
                        op: vibesql_ast::BinaryOperator::Equal,
                        right: Box::new(vibesql_ast::Expression::Literal(SqlValue::Integer(1))),
                    }],
                    result: expr,
                }],
                else_result: Some(Box::new(vibesql_ast::Expression::Literal(SqlValue::Integer(0)))),
            };
        }
        expr
    }

    /// Helper to generate deeply nested unary expressions
    /// Generates: -(-(-(-1))) for the specified depth
    fn generate_nested_unary(depth: usize) -> vibesql_ast::Expression {
        let mut expr = vibesql_ast::Expression::Literal(SqlValue::Integer(1));
        for _ in 0..depth {
            expr = vibesql_ast::Expression::UnaryOp {
                op: vibesql_ast::UnaryOperator::Minus,
                expr: Box::new(expr),
            };
        }
        expr
    }

    #[test]
    fn test_shallow_nested_expression() {
        // Depth 10 should work fine
        let schema = TableSchema::new("test".to_string(), vec![]);
        let evaluator = ExpressionEvaluator::new(&schema);
        let row = Row::new(vec![]);

        let expr = generate_nested_add(10);
        let result = evaluator.eval(&expr, &row);

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), SqlValue::Integer(11)); // 1 + 10 additions of 1
    }

    #[test]
    fn test_moderate_nested_expression() {
        // Depth 100 should work fine
        let schema = TableSchema::new("test".to_string(), vec![]);
        let evaluator = ExpressionEvaluator::new(&schema);
        let row = Row::new(vec![]);

        let expr = generate_nested_add(100);
        let result = evaluator.eval(&expr, &row);

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), SqlValue::Integer(101)); // 1 + 100 additions of 1
    }

    #[test]
    fn test_depth_limit_enforced() {
        // Test that depth limit is properly enforced
        // MAX_EXPRESSION_DEPTH is set to 200 to prevent stack overflow.
        // Building expressions deeper than ~200 causes stack overflow during evaluation
        // due to Rust's recursive call stack limitations (each eval call consumes stack space).
        let schema = TableSchema::new("test".to_string(), vec![]);
        let evaluator = ExpressionEvaluator::new(&schema);
        let row = Row::new(vec![]);

        // Test a deep but safe expression (100 levels - well within MAX_EXPRESSION_DEPTH of 200)
        let expr = generate_nested_add(100);
        let result = evaluator.eval(&expr, &row);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), SqlValue::Integer(101)); // 1 + 100 additions of 1
    }

    #[test]
    fn test_deep_case_expressions() {
        // Test CASE expression depth tracking
        let schema = TableSchema::new("test".to_string(), vec![]);
        let evaluator = ExpressionEvaluator::new(&schema);
        let row = Row::new(vec![]);

        // Depth 50 should work
        let expr = generate_nested_case(50);
        let result = evaluator.eval(&expr, &row);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), SqlValue::Integer(0));

        // Depth 150 should work (within MAX_EXPRESSION_DEPTH of 200)
        let expr = generate_nested_case(150);
        let result = evaluator.eval(&expr, &row);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), SqlValue::Integer(0));
    }

    #[test]
    fn test_deep_unary_expressions() {
        // Test unary operator depth tracking
        let schema = TableSchema::new("test".to_string(), vec![]);
        let evaluator = ExpressionEvaluator::new(&schema);
        let row = Row::new(vec![]);

        // Depth 100 should work
        let expr = generate_nested_unary(100);
        let result = evaluator.eval(&expr, &row);
        assert!(result.is_ok());
        // 100 negations of 1: even count = 1, odd count = -1
        assert_eq!(result.unwrap(), SqlValue::Integer(1));

        // Depth 150 should also work (within MAX_EXPRESSION_DEPTH of 200)
        let expr = generate_nested_unary(150);
        let result = evaluator.eval(&expr, &row);
        assert!(result.is_ok());
        // 150 negations of 1: even count = 1
        assert_eq!(result.unwrap(), SqlValue::Integer(1));
    }

    #[test]
    fn test_mixed_nested_expressions() {
        // Test combination of different expression types
        let schema = TableSchema::new("test".to_string(), vec![]);
        let evaluator = ExpressionEvaluator::new(&schema);
        let row = Row::new(vec![]);

        // Build: CASE WHEN 1=1 THEN (1 + (1 + (1 + 1))) ELSE -(-1) END
        let nested_add = generate_nested_add(3);
        let nested_unary = generate_nested_unary(2);

        let expr = vibesql_ast::Expression::Case {
            operand: None,
            when_clauses: vec![vibesql_ast::CaseWhen {
                conditions: vec![vibesql_ast::Expression::BinaryOp {
                    left: Box::new(vibesql_ast::Expression::Literal(SqlValue::Integer(1))),
                    op: vibesql_ast::BinaryOperator::Equal,
                    right: Box::new(vibesql_ast::Expression::Literal(SqlValue::Integer(1))),
                }],
                result: nested_add,
            }],
            else_result: Some(Box::new(nested_unary)),
        };

        let result = evaluator.eval(&expr, &row);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), SqlValue::Integer(4)); // 1 + 3
    }

    #[test]
    fn test_depth_tracking_is_consistent() {
        // Verify depth is properly tracked across evaluator instances
        let schema = TableSchema::new("test".to_string(), vec![]);
        let evaluator = ExpressionEvaluator::new(&schema);

        assert_eq!(evaluator.depth, 0);

        // Create evaluator with outer context - should still start at depth 0
        let outer_schema = TableSchema::new("outer".to_string(), vec![]);
        let outer_row = Row::new(vec![]);
        let evaluator_with_outer =
            ExpressionEvaluator::with_outer_context(&schema, &outer_row, &outer_schema);

        assert_eq!(evaluator_with_outer.depth, 0);
    }

    #[test]
    fn test_reasonable_depth_expressions() {
        // Test expressions at reasonable but deep nesting levels
        let schema = TableSchema::new("test".to_string(), vec![]);
        let evaluator = ExpressionEvaluator::new(&schema);
        let row = Row::new(vec![]);

        // Depth 100 should work fine (well within MAX_EXPRESSION_DEPTH of 200)
        let expr = generate_nested_add(100);
        let result = evaluator.eval(&expr, &row);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), SqlValue::Integer(101));

        // Depth 150 should also work
        let expr = generate_nested_add(150);
        let result = evaluator.eval(&expr, &row);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), SqlValue::Integer(151));
    }
}