vest_lib 0.0.5

VestLib: A library of formally verified parser and serializer combinators
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
use crate::properties::*;
use vstd::prelude::*;
use vstd::assert_seqs_equal;

verus! {

/// Unsigned LEB128
pub struct UnsignedLEB128;

/// Result of UnsignedLEB128
pub type UInt = u64;

impl View for UnsignedLEB128 {
    type V = Self;

    open spec fn view(&self) -> Self::V {
        Self
    }
}

/// Byte size of UInt
#[allow(unused_macros)]
macro_rules! uint_size { () => { 8 } }
pub(super) use uint_size;

/// Check if the highest bit is set in an u8
#[allow(unused_macros)]
macro_rules! is_high_8_bit_set {
    ($v:expr) => { $v as u8 >= 0x80 };
}
pub(crate) use is_high_8_bit_set;

/// Take the lowest 7 bits as an u8
#[allow(unused_macros)]
macro_rules! take_low_7_bits {
    ($v:expr) => { $v as u8 & 0x7f };
}
pub(crate) use take_low_7_bits;

/// Set the highest bit to 1 as an u8
#[allow(unused_macros)]
macro_rules! set_high_8_bit {
    ($v:expr) => {
        ($v | 0x80) as u8
    };
}
pub(super) use set_high_8_bit;

/// Max value for an n-bit unsigned integer
#[allow(unused_macros)]
macro_rules! n_bit_max_unsigned {
    ($n:expr) => { if $n == 0 { 0 } else { UInt::MAX >> (((8 * uint_size!()) - $n) as usize) } }
}
pub(super) use n_bit_max_unsigned;

impl SpecCombinator for UnsignedLEB128 {
    type Type = UInt;

    open spec fn spec_parse(&self, s: Seq<u8>) -> Result<(usize, Self::Type), ()>
        decreases s.len()
    {
        let v = take_low_7_bits!(s.first());

        if s.len() != 0 {
            if is_high_8_bit_set!(s.first()) {
                match self.spec_parse(s.drop_first()) {
                    Ok((n, v2)) =>
                        // Check for overflow and canonicity (v2 should not be 0)
                        if n < usize::MAX && 0 < v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                            Ok(((n + 1) as usize, v2 << 7 | v as Self::Type))
                        } else {
                            Err(())
                        }

                    Err(e) => Err(e),
                }
            } else {
                Ok((1, v as Self::Type))
            }
        } else {
            Err(())
        }
    }

    open spec fn spec_serialize(&self, v: Self::Type) -> Result<Seq<u8>, ()>
    {
        Self::spec_serialize_helper(v)
    }
}

impl UnsignedLEB128 {
    // /// Version of spec_parse that uses an accumulator pattern
    // open spec fn spec_parse_alt(&self, s: Seq<u8>, acc: UInt, i: usize) -> Result<(usize, Self::Type), ()>
    //     decreases s.len()
    // {
    //     if s.len() != 0 {
    //         let v = take_low_7_bits!(s.first());
    //         let new_acc = acc | ((v as Self::Type) << (i * 7));

    //         if is_high_8_bit_set!(s.first()) {
    //             if i < usize::MAX - 1 && new_acc <= n_bit_max_unsigned!(8 * uint_size!()) {
    //                 self.spec_parse_alt(s.drop_first(), new_acc, i + 1)
    //             } else {
    //                 Err(())
    //             }
    //         } else {
    //             Ok((i, new_acc))
    //         }
    //     } else {
    //         Err(())
    //     }
    // }

    // pub proof fn lemma_spec_parse_alt_partial(&self, s: Seq<u8>, acc: UInt, i: usize)
    //     ensures self.spec_parse(s) == self.spec_parse_alt(s, acc, i)
    // {
    //     admit();
    // }

    // pub proof fn lemma_spec_parse_alt_equiv(&self, s: Seq<u8>)
    //     ensures self.spec_parse(s) == self.spec_parse_alt(s, 0, 0)
    // {
    //     admit();
    // }

    /// Helper function for spec_serialize
    pub open spec fn spec_serialize_helper(v: UInt) -> Result<Seq<u8>, ()>
        decreases v via Self::spec_serialize_decreases
    {
        let lo = take_low_7_bits!(v);
        let hi = v >> 7;

        if hi == 0 {
            Ok(seq![lo])
        } else {
            match Self::spec_serialize_helper(hi) {
                Ok(s) => Ok(seq![set_high_8_bit!(lo)] + s),
                Err(e) => Err(e),
            }
        }
    }

    #[via_fn]
    proof fn spec_serialize_decreases(v: UInt)
    {
        assert(v >> 7 != 0 ==> v >> 7 < v) by (bit_vector);
    }

    proof fn lemma_spec_serialize_length(&self, v: UInt)
        ensures self.spec_serialize(v) matches Ok(s) ==> s.len() <= 10
    {
        reveal_with_fuel(UnsignedLEB128::spec_serialize_helper, 10);
        assert(
            v >> 7 >> 7 >> 7 >> 7 >> 7 >> 7 >> 7 >> 7 >> 7 >> 7 == 0
        ) by (bit_vector);
    }

    proof fn lemma_spec_parse_length(&self, s: Seq<u8>)
        ensures self.spec_parse(s) matches Ok((n, v)) ==> v <= 1 << (7 * n)
        decreases s.len()
    {
        admit();
        // if s.len() != 0 {
        //     let v = take_low_7_bits!(s.first());
        //     let s0 = s.first();
        //     assert(take_low_7_bits!(s0) as UInt <= 1 << 7) by (bit_vector);
        //     assert(v as UInt <= 1 << 7);
        //     if is_high_8_bit_set!(s.first()) {
        //         match self.spec_parse(s.drop_first()) {
        //             Ok((n, v2)) => {
        //                 if n < usize::MAX && 0 < v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
        //                     self.lemma_spec_parse_length(s.drop_first());
        //                     assert(v2 <= 1 << (7 * n));
        //                     assert(n <= 10) by (bit_vector)
        //                         requires v2 <= 1 << (7 * n), v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7);
        //                     assert(v2 << 7 as UInt <= ((1 << (7 * n)) as UInt) << 7) by (bit_vector)
        //                         requires v2 <= 1 << (7 * n);
        //                     assert(((1 << (7 * n)) as UInt) << 7 == (1 << (7 * (n + 1)) as UInt)) by (bit_vector);
        //                     assert(v2 << 7 as UInt <= 1 << (7 * (n+1)));
        //                     assert(v2 << 7 | v as UInt <= 1 << (7 * (n+1))) by (bit_vector)
        //                         requires v2 << 7 as UInt <= 1 << (7 * (n+1)), v2 <= 1 << (7 * n), v as UInt <= 1 << 7;
        //                     assert(v2 << 7 | v as UInt <= 1 << (7 * (n+1)));
        //                 }
        //             }
        //             Err(_) => { }
        //         }
        //     }
        // }
    }

    proof fn lemma_spec_parse_length_bound(&self, s: Seq<u8>)
        ensures self.spec_parse(s) matches Ok((n, v)) ==> n < 10
        decreases s.len()
    {
        admit();
    }

    proof fn lemma_serialize_last_byte_high_8_bit_not_set(&self, v: UInt)
        ensures self.spec_serialize(v) matches Ok(s) ==> !is_high_8_bit_set!(s.last())
        decreases v
    {
        let lo = take_low_7_bits!(v);
        let hi = v >> 7;

        if hi == 0 {
            assert(!is_high_8_bit_set!(take_low_7_bits!(v))) by (bit_vector);
            assert(self.spec_serialize(v) matches Ok(lo));
        } else {
            if let Ok(s) = Self::spec_serialize_helper(hi) {
                assert(Self::spec_serialize_helper(v) matches Ok(vv) && vv == seq![set_high_8_bit!(lo)] + s);
                assert(v >> 7 != 0 ==> v >> 7 < v) by (bit_vector);
                self.lemma_serialize_last_byte_high_8_bit_not_set(hi);
            } else {
                assert(self.spec_serialize(v) is Err);
            }
        }
    }

    proof fn lemma_parse_high_8_bits_set_until_last(&self, s: Seq<u8>) 
        ensures self.spec_parse(s) matches Ok((n, v)) ==> {
            &&& forall |i: int| 0 <= i < n - 1 ==> is_high_8_bit_set!(s.spec_index(i))
            &&& !(s[n-1] as u8 >= 0x80)  // is_high_8_bit_set!(s[n - 1])
        }
        decreases s.len()
    {
        if let Ok((n, v)) = self.spec_parse(s) {
            assert(n <= s.len()) by { self.lemma_parse_length(s) };
            let s0 = s[0];
            if n == 1 {
                // assert(!is_high_8_bit_set!(s0));
                if (is_high_8_bit_set!(s0)) {
                    assert(self.spec_parse(s.drop_first()) matches Ok((n1, _)) && n1 == 0);
                    self.lemma_parse_productive(s.drop_first());
                }
            } else {
                assert(is_high_8_bit_set!(s0));
                self.lemma_parse_high_8_bits_set_until_last(s.drop_first());
                assert_seqs_equal!(s == seq![s0] + s.drop_first());
            }
        }
    }

    fn exec_parse_rec_helper(&self, s: &[u8]) -> (res: PResult<UInt, ParseError>)
        ensures
            res matches Ok((n, v)) ==> self@.spec_parse(s@) == Ok::<_, ()>((n, v@)) && n
                <= s@.len(),
            self@.spec_parse(s@) matches Ok((m, w)) ==> res matches Ok((m, v)) && w == v@,
            res is Err ==> self@.spec_parse(s@) is Err,
            self@.spec_parse(s@) is Err ==> res is Err,
    {
        if s.len() != 0 {
            let v = take_low_7_bits!(s[0]);
            if is_high_8_bit_set!(s[0]) {
                let r = {
                    let s = s.subrange(1, s.len());
                    if s.len() != 0 {
                        let v = take_low_7_bits!(s[0]);
                        if is_high_8_bit_set!(s[0]) {
                            let r = {
                                let s = s.subrange(1, s.len());
                                if s.len() != 0 {
                                    let v = take_low_7_bits!(s[0]);
                                    if is_high_8_bit_set!(s[0]) {
                                        let r = {
                                            let s = s.subrange(1, s.len());
                                            if s.len() != 0 {
                                                let v = take_low_7_bits!(s[0]);
                                                if is_high_8_bit_set!(s[0]) {
                                                    let r = {
                                                        let s = s.subrange(1, s.len());
                                                        if s.len() != 0 {
                                                            let v = take_low_7_bits!(s[0]);
                                                            if is_high_8_bit_set!(s[0]) {
                                                                let r = {
                                                                    let s = s.subrange(1, s.len());
                                                                    if s.len() != 0 {
                                                                        let v = take_low_7_bits!(s[0]);
                                                                        if is_high_8_bit_set!(s[0]) {
                                                                            let r = {
                                                                                let s = s.subrange(1, s.len());
                                                                                if s.len() != 0 {
                                                                                    let v = take_low_7_bits!(s[0]);
                                                                                    if is_high_8_bit_set!(s[0]) {
                                                                                        let r = {
                                                                                            let s = s.subrange(1, s.len());
                                                                                            if s.len() != 0 {
                                                                                                let v = take_low_7_bits!(s[0]);
                                                                                                if is_high_8_bit_set!(s[0]) {
                                                                                                    let r = {
                                                                                                        let s = s.subrange(1, s.len());
                                                                                                        if s.len() != 0 {
                                                                                                            let v = take_low_7_bits!(s[0]);
                                                                                                            if is_high_8_bit_set!(s[0]) {
                                                                                                                let r = self.exec_parse_rec_helper(s.subrange(1, s.len()));
                                                                                                                match r {
                                                                                                                    Ok((n, v2)) => {
                                                                                                                        // Check for overflow and canonicity (v2 should not be 0)
                                                                                                                        if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                                                                                                                            Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                                                                                                                        } else {
                                                                                                                            Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                                                                                                                        }
                                                                                                                    }
                                                                                                                    Err(e) => Err(e),
                                                                                                                }
                                                                                                            } else {
                                                                                                                Ok((1, v as UInt))
                                                                                                            }
                                                                                                        } else {
                                                                                                            Err(ParseError::UnexpectedEndOfInput)
                                                                                                        }
                                                                                                    };
                                                                                                    match r {
                                                                                                        Ok((n, v2)) => {
                                                                                                            // Check for overflow and canonicity (v2 should not be 0)
                                                                                                            if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                                                                                                                Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                                                                                                            } else {
                                                                                                                Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                                                                                                            }
                                                                                                        }
                                                                                                        Err(e) => Err(e),
                                                                                                    }
                                                                                                } else {
                                                                                                    Ok((1, v as UInt))
                                                                                                }
                                                                                            } else {
                                                                                                Err(ParseError::UnexpectedEndOfInput)
                                                                                            }

                                                                                        };
                                                                                        match r {
                                                                                            Ok((n, v2)) => {
                                                                                                // Check for overflow and canonicity (v2 should not be 0)
                                                                                                if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                                                                                                    Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                                                                                                } else {
                                                                                                    Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                                                                                                }
                                                                                            }
                                                                                            Err(e) => Err(e),
                                                                                        }
                                                                                    } else {
                                                                                        Ok((1, v as UInt))
                                                                                    }
                                                                                } else {
                                                                                    Err(ParseError::UnexpectedEndOfInput)
                                                                                }
                                                                            };
                                                                            match r {
                                                                                Ok((n, v2)) => {
                                                                                    // Check for overflow and canonicity (v2 should not be 0)
                                                                                    if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                                                                                        Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                                                                                    } else {
                                                                                        Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                                                                                    }
                                                                                }
                                                                                Err(e) => Err(e),
                                                                            }
                                                                        } else {
                                                                            Ok((1, v as UInt))
                                                                        }
                                                                    } else {
                                                                        Err(ParseError::UnexpectedEndOfInput)
                                                                    }
                                                                };
                                                                match r {
                                                                    Ok((n, v2)) => {
                                                                        // Check for overflow and canonicity (v2 should not be 0)
                                                                        if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                                                                            Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                                                                        } else {
                                                                            Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                                                                        }
                                                                    }
                                                                    Err(e) => Err(e),
                                                                }
                                                            } else {
                                                                Ok((1, v as UInt))
                                                            }
                                                        } else {
                                                            Err(ParseError::UnexpectedEndOfInput)
                                                        }
                                                    };
                                                    match r {
                                                        Ok((n, v2)) => {
                                                            // Check for overflow and canonicity (v2 should not be 0)
                                                            if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                                                                Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                                                            } else {
                                                                Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                                                            }
                                                        }
                                                        Err(e) => Err(e),
                                                    }
                                                } else {
                                                    Ok((1, v as UInt))
                                                }
                                            } else {
                                                Err(ParseError::UnexpectedEndOfInput)
                                            }

                                        };
                                        match r {
                                            Ok((n, v2)) => {
                                                // Check for overflow and canonicity (v2 should not be 0)
                                                if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                                                    Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                                                } else {
                                                    Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                                                }
                                            }
                                            Err(e) => Err(e),
                                        }
                                    } else {
                                        Ok((1, v as UInt))
                                    }
                                } else {
                                    Err(ParseError::UnexpectedEndOfInput)
                                }

                            };
                            match r {
                                Ok((n, v2)) => {
                                    // Check for overflow and canonicity (v2 should not be 0)
                                    if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                                        Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                                    } else {
                                        Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                                    }
                                }
                                Err(e) => Err(e),
                            }
                        } else {
                            Ok((1, v as UInt))
                        }
                    } else {
                        Err(ParseError::UnexpectedEndOfInput)
                    }
                };
                match r {
                    Ok((n, v2)) => {
                        // Check for overflow and canonicity (v2 should not be 0)
                        if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
                            Ok(((n + 1) as usize, v2 << 7 | v as UInt))
                        } else {
                            Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
                        }
                    }
                    Err(e) => Err(e),
                }
            } else {
                Ok((1, v as UInt))
            }
        } else {
            Err(ParseError::UnexpectedEndOfInput)
        }
    }
//    fn exec_parse_rec_helper(&self, s: &[u8]) -> (res: PResult<UInt, ParseError>)
//        ensures
//            res matches Ok((n, v)) ==> self@.spec_parse(s@) == Ok::<_, ()>((n, v@)) && n
//                <= s@.len(),
//            self@.spec_parse(s@) matches Ok((m, w)) ==> res matches Ok((m, v)) && w == v@,
//            res is Err ==> self@.spec_parse(s@) is Err,
//            self@.spec_parse(s@) is Err ==> res is Err,
//    {
//        if s.len() != 0 {
//            let v = take_low_7_bits!(s[0]);
//            if is_high_8_bit_set!(s[0]) {
//                match self.exec_parse_rec_helper(s.subrange(1, s.len())) {
//                    Ok((n, v2)) => {
//                        // Check for overflow and canonicity (v2 should not be 0)
//                        if n < usize::MAX && 0 < v2 && v2 <= n_bit_max_unsigned!(8 * uint_size!() - 7) {
//                            Ok(((n + 1) as usize, v2 << 7 | v as UInt))
//                        } else {
//                            Err(ParseError::Other("Failed to parse LEB128: overflow or canonicity violation".to_string()))
//                        }
//                    }
//                    Err(e) => Err(e),
//                }
//            } else {
//                Ok((1, v as UInt))
//            }
//        } else {
//            Err(ParseError::UnexpectedEndOfInput)
//        }
//    }
}

impl SecureSpecCombinator for UnsignedLEB128 {
    open spec fn is_prefix_secure() -> bool {
        true
    }

    proof fn lemma_prefix_secure(&self, s1: Seq<u8>, s2: Seq<u8>) 
        decreases s1.len()
    {
        if Self::is_prefix_secure() {
            if let Ok((n1, v1)) = self.spec_parse(s1) {
                // assert(n1 <= s1.len()) by { self.lemma_parse_length(s1) };
                // let s1_0 = s1[0];
                // if n1 == 1 {
                //     // assert(!is_high_8_bit_set!(s0));
                //     if (is_high_8_bit_set!(s1_0)) {
                //         assert(self.spec_parse(s1.drop_first()) matches Ok((n1_1, _)) && n1_1 == 0);
                //         self.lemma_parse_productive(s1.drop_first());
                //         assume(false);
                //     }
                //     assume(false);
                // } else {
                //     // assert(is_high_8_bit_set!(s0));
                //     // self.lemma_parse_high_8_bits_set_until_last(s.drop_first());
                //     self.lemma_prefix_secure(s1.drop_first(), s2);
                //     assert_seqs_equal!(s1 == seq![s1_0] + s1.drop_first());
                // }

                // self.lemma_parse_high_8_bits_set_until_last(s1);
                // assert(!(s1[n1-1] as u8 >= 0x80));
                // if let Ok((n2, v2)) = self.spec_parse(s1.add(s2)) {
                //     assert(n1 <= n2);
                //     assume(false);
                // } else {
                //     assume(false);
                //     // should be unreachable
                //     assert(false);
                // }
                admit();
            }
        }
    }


    proof fn lemma_parse_length(&self, s: Seq<u8>)
        decreases s.len()
    {
        if s.len() != 0 {
            self.lemma_parse_length(s.drop_first());
        }
    }

    proof fn theorem_serialize_parse_roundtrip(&self, v: Self::Type)
        decreases v
    {
        if let Ok(s) = self.spec_serialize(v) {
            let lo = take_low_7_bits!(v);
            let hi = v >> 7;

            self.lemma_spec_serialize_length(v);

            assert({
                &&& !is_high_8_bit_set!(take_low_7_bits!(v))
                &&& v >> 7 == 0 ==> v == take_low_7_bits!(v)
                &&& v >> 7 != 0 ==> v >> 7 < v
                &&& is_high_8_bit_set!(set_high_8_bit!(lo))
                &&& (v >> 7) << 7 | take_low_7_bits!(v) as UInt == v
                &&& (v >> 7) <= n_bit_max_unsigned!(8 * uint_size!() - 7)
                &&& take_low_7_bits!(set_high_8_bit!(take_low_7_bits!(v))) == take_low_7_bits!(v)
            }) by (bit_vector);

            if hi != 0 {
                self.theorem_serialize_parse_roundtrip(hi);

                let hi_bytes = self.spec_serialize(hi).unwrap();
                assert(s.drop_first() == hi_bytes);
            }
        }
    }

    proof fn theorem_parse_serialize_roundtrip(&self, s: Seq<u8>) {
        assume(false);
    }

    open spec fn is_productive(&self) -> bool {
        true
    }

    proof fn lemma_parse_productive(&self, s: Seq<u8>) 
        decreases s.len()
    {
        if s.len() != 0 {
            self.lemma_parse_productive(s.drop_first());
        }
    }
}

impl<I,O> Combinator<I,O> for UnsignedLEB128 
    where I: VestPublicInput, O: VestPublicOutput<I>
{
    type Type = UInt;

    open spec fn spec_length(&self) -> Option<usize> {
        None // TODO
    }

    fn length(&self) -> Option<usize> {
        None // TODO
    }

    open spec fn parse_requires(&self) -> bool {
        true
    }


    fn parse(&self, ss: I) -> (res: PResult<Self::Type, ParseError>) {
        self.exec_parse_rec_helper(ss.as_byte_slice())
    }

/*
    fn parse(&self, ss: I) -> (res: PResult<Self::Type, ParseError>) {
        let s = ss.as_byte_slice();
        let mut result: Self::Type = 0;
        let mut shift = 0;
        let mut i = 0;

        if s.len() == 0 {
            return Err(ParseError::UnexpectedEndOfInput);
        }
        let ghost spec_res = self.spec_parse(s@);
        proof { admit() };

        while i < s.len()
            invariant 
                s.len() != 0,
                s@ == ss@,
                shift == i * 7,
                0 <= i < 10,
                spec_res == self.spec_parse(s@),
                // spec_res matches Ok((spec_res_n, spec_res_v)) ==> {
                //     &&& i <= spec_res_n
                //     &&& result == 
                    
                // }
                self.spec_parse(s@.take(i as int)) matches Ok((j, spec_res)) ==> {
                    &&& result == spec_res
                    &&& j == i
                }
            decreases s.len() - i
        {
            proof { 
                self.lemma_spec_parse_length(s@);
                self.lemma_spec_parse_length_bound(s@);
            }
            proof { admit() };

            let byte = s[i];
            result |= (take_low_7_bits!(byte) as Self::Type) << shift;
            shift += 7;
            i += 1;
            if !is_high_8_bit_set!(byte) {
                return Ok((i, result));
            }
        }
        Err(ParseError::UnexpectedEndOfInput)
    }

    open spec fn serialize_requires(&self) -> bool {
        true
    }
*/

    #[verifier::external_body]
    fn serialize(&self, v: Self::Type, buf: &mut O, pos: usize) -> (res: SResult<usize, SerializeError>) {
        let mut v = v;
        let mut i = 0;
        let mut pos = pos;

        let ghost orig_v = v;
        let ghost spec_res = self.spec_serialize(v);
        proof { self.lemma_spec_serialize_length(v) }

        assert(v == orig_v >> 0) by (bit_vector) requires v == orig_v;

        while v > 0 
            invariant 
                0 <= i <= 10,
                buf@.len() == old(buf)@.len(),
                v == orig_v >> (i * 7),
                self.spec_serialize(orig_v) matches Ok(s) ==> {
                    &&& s.len() <= 10
                    &&& s.subrange(0, i as int) == buf@.subrange(pos as int, pos + i as int)
                } 
            decreases v
        {
            // proof { admit() };
            let lo = take_low_7_bits!(v);
            let hi = v >> 7;
            let byte = if hi == 0 { lo } else { set_high_8_bit!(lo) };

            if pos >= buf.len() {
                return Err(SerializeError::InsufficientBuffer);
            }
            buf.set_byte(pos, byte);

            pos += 1;

            assert(v >> 7 != 0 ==> v >> 7 < v) by (bit_vector);
            assert(v >> 7 == orig_v >> ((i as u64 + 1) * 7)) by (bit_vector)
                requires v == orig_v >> (i as u64 * 7), 0 <= i <= 10; 
            v = hi;
            i += 1;
            if i > 10 {
                // should be unreachable for well-formed inputs
                proof { self.lemma_spec_serialize_length(orig_v) }
                // assert(self.spec_serialize(orig_v) is Err);
                return Err(SerializeError::Other("Failed to serialize LEB128: too long".to_string()));
            }
            assert(i <= 10);
        }
        Ok(pos)
    }
}


}


#[cfg(test)]
mod test {
use leb128::read;
use leb128::write;
use super::*;

fn test_vest_parser(v: u64) {
    let mut buf = vec![0u8; 20];
    let num_written = leb128::write::unsigned(&mut buf, v).expect("leb128 crate write failed");

    let pres = <_ as Combinator<&[u8], Vec<u8>>>::parse(&UnsignedLEB128, &buf[buf.len()-num_written..]);
    match pres {
        Ok((_n_parsed, v_parsed)) => {
            assert_eq!(v, v_parsed);
        }
        Err(e) => {
            panic!("Failed to parse: {:?}", e);
        }
    }
}

fn test_vest_serializer(v: u64) {
    let mut buf = vec![0u8; 20];
    let sres = <_ as Combinator<&[u8], Vec<u8>>>::serialize(&UnsignedLEB128, v, &mut buf, 0);
    if let Err(e) = sres {
        panic!("Failed to serialize: {:?}", e);
    }

    let v_parsed = leb128::read::unsigned(&mut buf.as_slice()).expect("leb128 crate read failed");

    assert_eq!(v, v_parsed);
}

#[test]
fn randomly_test_vest_leb128() {
    use rand::Rng;
    let mut rng = rand::thread_rng();
    for _ in 0..100000 {
        let v: u64 = rng.gen();
        test_vest_parser(v);
        test_vest_serializer(v);
    }
}


}