verctl 0.3.5

Stack-agnostic version PRs from Changesets-format fragments
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
//! What `prepare` is allowed to write: `prepare.after`, `pins`,
//! and unexpected dirty paths.
#![allow(missing_docs, clippy::unwrap_used)]

mod common;

use git2::{Repository, Signature};
use indoc::indoc;
use std::fs;
use std::path::Path;
use tempfile::TempDir;

fn init_repo(root: &Path) {
    let repo = Repository::init(root).unwrap();
    let sig = Signature::now("t", "t@example.com").unwrap();
    let mut index = repo.index().unwrap();
    index
        .add_all(["."].iter(), git2::IndexAddOption::DEFAULT, None)
        .unwrap();
    index.write().unwrap();
    let tid = index.write_tree().unwrap();
    let tree = repo.find_tree(tid).unwrap();
    repo.commit(Some("HEAD"), &sig, &sig, "init", &tree, &[])
        .unwrap();
}

fn write_min(root: &Path, extra: &str) {
    common::write_config(
        root,
        &format!(
            "{}\n{extra}",
            indoc! {"
                packages:
                  - name: demo
                    path: Cargo.toml
            "}
        ),
    );
    fs::write(
        root.join("Cargo.toml"),
        indoc! {r#"
            [package]
            name = "demo"
            version = "1.0.0"
        "#},
    )
    .unwrap();
    fs::create_dir_all(root.join(".changeset")).unwrap();
    fs::write(
        root.join(".changeset/one.md"),
        indoc! {"
            ---
            demo: patch
            ---

            Bump.
        "},
    )
    .unwrap();
}

fn prepare(root: &Path) -> std::process::Output {
    std::process::Command::new(env!("CARGO_BIN_EXE_verctl"))
        .current_dir(root)
        .args(["prepare", "--no-pr"])
        .output()
        .unwrap()
}

#[test]
fn after_may_write_declared_globs() {
    let root = TempDir::new().unwrap();
    write_min(
        root.path(),
        indoc! {"
            prepare:
              after: [touch, src/version.rs]
              stage: [src/version.rs]
        "},
    );
    fs::create_dir_all(root.path().join("src")).unwrap();
    init_repo(root.path());
    let output = prepare(root.path());
    assert!(
        output.status.success(),
        "{}",
        String::from_utf8_lossy(&output.stderr)
    );
    assert!(root.path().join("src/version.rs").exists());
}

#[test]
fn after_deleted_staged_file_is_collected() {
    let root = TempDir::new().unwrap();
    write_min(
        root.path(),
        indoc! {"
            prepare:
              after: [rm, src/gone.rs]
              stage: [src/gone.rs]
        "},
    );
    fs::create_dir_all(root.path().join("src")).unwrap();
    fs::write(root.path().join("src/gone.rs"), "old\n").unwrap();
    init_repo(root.path());
    let output = prepare(root.path());
    assert!(
        output.status.success(),
        "{}",
        String::from_utf8_lossy(&output.stderr)
    );
    assert!(!root.path().join("src/gone.rs").exists());
}

#[test]
fn after_unexpected_path_fails() {
    let root = TempDir::new().unwrap();
    write_min(
        root.path(),
        indoc! {"
            prepare:
              after: [touch, secret.env]
        "},
    );
    init_repo(root.path());
    let output = prepare(root.path());
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(!output.status.success(), "{stderr}");
    assert!(stderr.contains("secret.env"), "{stderr}");
    assert!(stderr.contains("prepare.stage"), "{stderr}");
}

#[test]
fn bunfig_is_passed_as_config() {
    let root = TempDir::new().unwrap();
    common::write_config(
        root.path(),
        indoc! {r#"
            packages:
              - name: "@org/pkg"
                path: package.json
                registry: github
        "#},
    );
    fs::write(
        root.path().join("package.json"),
        indoc! {r#"
            { "name": "@org/pkg", "version": "0.0.1" }
        "#},
    )
    .unwrap();
    fs::write(
        root.path().join("bunfig.toml"),
        indoc! {r#"
            [install.scopes]
            "@org" = { url = "https://npm.pkg.github.com", token = "$GITHUB_TOKEN" }
        "#},
    )
    .unwrap();
    let planned = verctl::publish::plan(
        &verctl::config::Config::load(&root.path().join(verctl::config::FILE)).unwrap(),
        root.path(),
    )
    .unwrap();
    let argv = &planned.packages[0].argv;
    assert!(argv.contains(&"--config".into()), "{argv:?}");
    assert!(
        argv.iter().any(|part| part.ends_with("bunfig.toml")),
        "{argv:?}"
    );
    assert!(!argv.contains(&"--registry".into()), "{argv:?}");
}

/// The tag names the Version PR commit, so a pin rewritten after publish
/// never reaches the tree a consumer fetches by ref. `prepare` writes it.
#[test]
fn pins_move_with_the_bump() {
    let root = TempDir::new().unwrap();
    write_min(
        root.path(),
        indoc! {r#"
            pins:
              - file: consumer/mise.toml
                tool: "github:acme/demo"
                package: demo
        "#},
    );
    fs::create_dir_all(root.path().join("consumer")).unwrap();
    fs::write(
        root.path().join("consumer/mise.toml"),
        indoc! {r#"
            [tools]
            "github:acme/demo" = "1.0.0"

            [task_config]
            includes = [
              "git::https://github.com/acme/demo.git//tasks/demo?ref=v1.0.0",
            ]
        "#},
    )
    .unwrap();
    init_repo(root.path());
    let output = prepare(root.path());
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(output.status.success(), "{stderr}");
    assert_eq!(
        fs::read_to_string(root.path().join("consumer/mise.toml")).unwrap(),
        indoc! {r#"
            [tools]
            "github:acme/demo" = "1.0.1"

            [task_config]
            includes = [
              "git::https://github.com/acme/demo.git//tasks/demo?ref=v1.0.1",
            ]
        "#},
        "the tool pin and the ?ref= both name the version being released"
    );
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(stdout.contains("consumer/mise.toml"), "{stdout}");
}

/// A rewritten pin is part of the release, not a surprise in the worktree.
/// Without that, the dirty check would reject the file `prepare` just wrote.
#[test]
fn a_rewritten_pin_is_not_unexpected_dirt() {
    let root = TempDir::new().unwrap();
    write_min(
        root.path(),
        indoc! {r#"
            pins:
              - file: pinned.toml
                tool: "github:acme/demo"
                package: demo
        "#},
    );
    fs::write(
        root.path().join("pinned.toml"),
        indoc! {r#"
            [tools]
            "github:acme/demo" = "1.0.0"
        "#},
    )
    .unwrap();
    init_repo(root.path());
    let output = prepare(root.path());
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(output.status.success(), "{stderr}");
    assert!(!stderr.contains("prepare.stage"), "{stderr}");
}

#[test]
fn a_pin_naming_no_configured_package_is_left_alone() {
    let root = TempDir::new().unwrap();
    write_min(
        root.path(),
        indoc! {r#"
            pins:
              - file: pinned.toml
                tool: "github:acme/ghost"
                package: ghost
        "#},
    );
    let body = indoc! {r#"
        [tools]
        "github:acme/ghost" = "1.0.0"
    "#};
    fs::write(root.path().join("pinned.toml"), body).unwrap();
    init_repo(root.path());
    let output = prepare(root.path());
    assert!(
        output.status.success(),
        "{}",
        String::from_utf8_lossy(&output.stderr)
    );
    assert_eq!(
        fs::read_to_string(root.path().join("pinned.toml")).unwrap(),
        body,
        "no package named it, so nothing claims the file"
    );
}

#[test]
fn a_dry_run_reports_the_pin_without_writing_it() {
    let root = TempDir::new().unwrap();
    write_min(
        root.path(),
        indoc! {r#"
            pins:
              - file: pinned.toml
                tool: "github:acme/demo"
                package: demo
        "#},
    );
    let body = indoc! {r#"
        [tools]
        "github:acme/demo" = "1.0.0"
    "#};
    fs::write(root.path().join("pinned.toml"), body).unwrap();
    init_repo(root.path());
    let output = std::process::Command::new(env!("CARGO_BIN_EXE_verctl"))
        .current_dir(root.path())
        .args(["prepare", "--no-pr", "--dry-run"])
        .output()
        .unwrap();
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(
        output.status.success(),
        "{}",
        String::from_utf8_lossy(&output.stderr)
    );
    assert!(stdout.contains("pinned.toml"), "{stdout}");
    assert_eq!(
        fs::read_to_string(root.path().join("pinned.toml")).unwrap(),
        body,
        "a dry run names the file it would rewrite and rewrites nothing"
    );
}

/// Pins move with the bump, not with whatever a manifest happens to say.
/// A pin left one release behind on purpose is not this release's business.
#[test]
fn a_pin_on_a_package_no_fragment_bumped_stays_where_it_is() {
    let root = TempDir::new().unwrap();
    common::write_config(
        root.path(),
        indoc! {r#"
            packages:
              - name: demo
                path: Cargo.toml
              - name: other
                path: other/Cargo.toml

            pins:
              - file: pinned.toml
                tool: "github:acme/other"
                package: other
        "#},
    );
    fs::write(
        root.path().join("Cargo.toml"),
        indoc! {r#"
            [package]
            name = "demo"
            version = "1.0.0"
        "#},
    )
    .unwrap();
    fs::create_dir_all(root.path().join("other")).unwrap();
    fs::write(
        root.path().join("other/Cargo.toml"),
        indoc! {r#"
            [package]
            name = "other"
            version = "3.0.0"
        "#},
    )
    .unwrap();
    let lagging = indoc! {r#"
        [tools]
        "github:acme/other" = "2.0.0"
    "#};
    fs::write(root.path().join("pinned.toml"), lagging).unwrap();
    fs::create_dir_all(root.path().join(".changeset")).unwrap();
    fs::write(
        root.path().join(".changeset/one.md"),
        indoc! {"
            ---
            demo: patch
            ---

            Bump.
        "},
    )
    .unwrap();
    init_repo(root.path());
    let output = prepare(root.path());
    assert!(
        output.status.success(),
        "{}",
        String::from_utf8_lossy(&output.stderr)
    );
    assert_eq!(
        fs::read_to_string(root.path().join("pinned.toml")).unwrap(),
        lagging,
        "no fragment named `other`, so its pin is not this release's business"
    );
}

/// A pin that cannot be rewritten is caught before anything is written.
/// Otherwise prepare stops with versions bumped, no changelog, and the
/// fragments still on disk.
#[test]
fn a_broken_pin_fails_before_any_manifest_moves() {
    let root = TempDir::new().unwrap();
    write_min(
        root.path(),
        indoc! {r#"
            pins:
              - file: pinned.toml
                tool: "github:acme/demo"
                package: demo
        "#},
    );
    fs::write(root.path().join("pinned.toml"), "# no [tools] table\n").unwrap();
    init_repo(root.path());
    let output = prepare(root.path());
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(!output.status.success(), "{stderr}");
    assert!(stderr.contains("pinned.toml"), "{stderr}");
    assert!(
        fs::read_to_string(root.path().join("Cargo.toml"))
            .unwrap()
            .contains("version = \"1.0.0\""),
        "the manifest must not move when a pin cannot be rewritten"
    );
    assert!(
        root.path().join(".changeset/one.md").exists(),
        "the fragment must survive a failed prepare"
    );
}