velesdb-core 1.7.2

High-performance vector database engine written in Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
#![allow(
    clippy::cast_precision_loss,
    clippy::cast_possible_truncation,
    clippy::cast_sign_loss,
    clippy::cast_possible_wrap,
    clippy::float_cmp,
    clippy::approx_constant,
    deprecated // SimdDistance deprecated in favor of CachedSimdDistance
)]
//! Tests for distance computation engines.
//!
//! Extracted from `distance.rs` for maintainability (04-05 module splitting).

use super::distance::*;
use crate::distance::DistanceMetric;

#[allow(clippy::cast_precision_loss)]
#[test]
fn test_cosine_identical_vectors() {
    let engine = CpuDistance::new(DistanceMetric::Cosine);
    let v = vec![1.0, 2.0, 3.0];
    let dist = engine.distance(&v, &v);
    assert!(
        dist.abs() < 1e-5,
        "Identical vectors should have distance ~0"
    );
}

#[test]
fn test_euclidean_known_distance() {
    let engine = CpuDistance::new(DistanceMetric::Euclidean);
    let a = vec![0.0, 0.0, 0.0];
    let b = vec![3.0, 4.0, 0.0];
    let dist = engine.distance(&a, &b);
    assert!((dist - 5.0).abs() < 1e-5, "3-4-5 triangle");
}

#[test]
fn test_simd_matches_scalar() {
    let cpu = CpuDistance::new(DistanceMetric::Cosine);
    let simd = SimdDistance::new(DistanceMetric::Cosine);

    #[allow(clippy::cast_precision_loss)]
    let a: Vec<f32> = (0..768).map(|i| (i as f32 * 0.01).sin()).collect();
    #[allow(clippy::cast_precision_loss)]
    let b: Vec<f32> = (0..768).map(|i| (i as f32 * 0.02).cos()).collect();

    let cpu_dist = cpu.distance(&a, &b);
    let simd_dist = simd.distance(&a, &b);

    assert!(
        (cpu_dist - simd_dist).abs() < 1e-4,
        "SIMD should match scalar: cpu={cpu_dist}, simd={simd_dist}"
    );
}

// =========================================================================
// TDD Tests for PERF-2: Hamming/Jaccard SIMD + batch_distance optimization
// =========================================================================

#[test]
fn test_simd_hamming_uses_simd_implementation() {
    let simd = SimdDistance::new(DistanceMetric::Hamming);

    // Binary-like vectors (0.0 or 1.0)
    let a: Vec<f32> = (0..64)
        .map(|i| if i % 2 == 0 { 1.0 } else { 0.0 })
        .collect();
    let b: Vec<f32> = (0..64)
        .map(|i| if i % 3 == 0 { 1.0 } else { 0.0 })
        .collect();

    let dist = simd.distance(&a, &b);

    // Verify result is reasonable (hamming distance between these patterns)
    assert!(dist >= 0.0, "Hamming distance must be non-negative");
    assert!(dist <= 64.0, "Hamming distance cannot exceed vector length");
}

#[test]
fn test_simd_jaccard_uses_simd_implementation() {
    let simd = SimdDistance::new(DistanceMetric::Jaccard);

    // Binary-like vectors for set similarity
    let a: Vec<f32> = (0..64).map(|i| if i < 32 { 1.0 } else { 0.0 }).collect();
    let b: Vec<f32> = (0..64).map(|i| if i < 48 { 1.0 } else { 0.0 }).collect();

    let dist = simd.distance(&a, &b);

    // Jaccard distance = 1 - similarity, should be in [0, 1]
    assert!(
        (0.0..=1.0).contains(&dist),
        "Jaccard distance must be in [0,1]"
    );

    // Intersection = 32, Union = 48, Similarity = 32/48 = 0.667, Distance = 0.333
    let expected = 1.0 - (32.0 / 48.0);
    assert!(
        (dist - expected).abs() < 1e-4,
        "Jaccard distance: expected {expected}, got {dist}"
    );
}

#[test]
fn test_simd_hamming_identical_vectors() {
    let simd = SimdDistance::new(DistanceMetric::Hamming);
    let v: Vec<f32> = (0..32)
        .map(|i| if i % 2 == 0 { 1.0 } else { 0.0 })
        .collect();

    let dist = simd.distance(&v, &v);
    assert!(
        dist.abs() < 1e-5,
        "Identical vectors should have distance 0"
    );
}

#[test]
fn test_simd_jaccard_identical_vectors() {
    let simd = SimdDistance::new(DistanceMetric::Jaccard);
    let v: Vec<f32> = (0..32)
        .map(|i| if i % 2 == 0 { 1.0 } else { 0.0 })
        .collect();

    let dist = simd.distance(&v, &v);
    assert!(
        dist.abs() < 1e-5,
        "Identical vectors should have distance 0"
    );
}

#[test]
#[allow(clippy::cast_precision_loss)]
fn test_batch_distance_with_prefetch() {
    let simd = SimdDistance::new(DistanceMetric::Cosine);

    let query: Vec<f32> = (0..768).map(|i| (i as f32 * 0.01).sin()).collect();
    let candidates: Vec<Vec<f32>> = (0..100)
        .map(|j| {
            (0..768)
                .map(|i| ((i + j * 10) as f32 * 0.01).cos())
                .collect()
        })
        .collect();

    let candidate_refs: Vec<&[f32]> = candidates.iter().map(Vec::as_slice).collect();

    let distances = simd.batch_distance(&query, &candidate_refs);

    assert_eq!(distances.len(), 100, "Should return 100 distances");

    // Verify all distances are valid (cosine distance in [0, 2])
    for (i, &d) in distances.iter().enumerate() {
        assert!((0.0..=2.0).contains(&d), "Distance {i} = {d} out of range");
    }
}

#[test]
#[allow(clippy::cast_precision_loss)]
fn test_batch_distance_consistency() {
    let simd = SimdDistance::new(DistanceMetric::Euclidean);

    let query: Vec<f32> = (0..128).map(|i| i as f32).collect();
    let candidates: Vec<Vec<f32>> = (0..20)
        .map(|j| (0..128).map(|i| (i + j) as f32).collect())
        .collect();

    let candidate_refs: Vec<&[f32]> = candidates.iter().map(Vec::as_slice).collect();

    // Batch distance
    let batch_distances = simd.batch_distance(&query, &candidate_refs);

    // Individual distances
    let individual_distances: Vec<f32> = candidate_refs
        .iter()
        .map(|c| simd.distance(&query, c))
        .collect();

    // Results should match exactly
    for (i, (batch, individual)) in batch_distances
        .iter()
        .zip(individual_distances.iter())
        .enumerate()
    {
        assert!(
            (batch - individual).abs() < 1e-6,
            "Mismatch at {i}: batch={batch}, individual={individual}"
        );
    }
}

#[test]
fn test_batch_distance_empty() {
    let simd = SimdDistance::new(DistanceMetric::Cosine);
    let query = vec![1.0, 2.0, 3.0];
    let candidates: Vec<&[f32]> = vec![];

    let distances = simd.batch_distance(&query, &candidates);
    assert!(distances.is_empty(), "Empty candidates should return empty");
}

// =========================================================================
// Tests for NativeSimdDistance (AVX-512/NEON intrinsics)
// =========================================================================

#[test]
fn test_native_simd_matches_simd() {
    let simd = SimdDistance::new(DistanceMetric::Cosine);
    let native = NativeSimdDistance::new(DistanceMetric::Cosine);

    #[allow(clippy::cast_precision_loss)]
    let a: Vec<f32> = (0..768).map(|i| (i as f32 * 0.01).sin()).collect();
    #[allow(clippy::cast_precision_loss)]
    let b: Vec<f32> = (0..768).map(|i| (i as f32 * 0.02).cos()).collect();

    let simd_dist = simd.distance(&a, &b);
    let native_dist = native.distance(&a, &b);

    assert!(
        (simd_dist - native_dist).abs() < 1e-3,
        "Native SIMD should match SIMD: simd={simd_dist}, native={native_dist}"
    );
}

#[test]
fn test_native_simd_euclidean() {
    let native = NativeSimdDistance::new(DistanceMetric::Euclidean);

    let a = vec![0.0, 0.0, 0.0, 0.0];
    let b = vec![3.0, 4.0, 0.0, 0.0];

    let dist = native.distance(&a, &b);
    assert!((dist - 5.0).abs() < 1e-5, "3-4-5 triangle: got {dist}");
}

#[test]
#[allow(clippy::cast_precision_loss)]
fn test_native_simd_dot_product() {
    let native = NativeSimdDistance::new(DistanceMetric::DotProduct);

    let a: Vec<f32> = (0..128).map(|i| i as f32 * 0.1).collect();
    let b: Vec<f32> = (0..128).map(|i| (128 - i) as f32 * 0.1).collect();

    let dist = native.distance(&a, &b);
    // DotProduct distance is negative dot product
    assert!(dist < 0.0, "DotProduct distance should be negative");
}

// =========================================================================
// Additional tests for 90% coverage
// =========================================================================

#[test]
fn test_cpu_distance_dot_product() {
    let cpu = CpuDistance::new(DistanceMetric::DotProduct);
    let a = vec![1.0, 2.0, 3.0];
    let b = vec![4.0, 5.0, 6.0];
    let dist = cpu.distance(&a, &b);
    // dot = 1*4 + 2*5 + 3*6 = 32, distance = -32
    assert!((dist + 32.0).abs() < 1e-5);
}

#[test]
fn test_cpu_distance_hamming() {
    let cpu = CpuDistance::new(DistanceMetric::Hamming);
    let a = vec![1.0, 0.0, 1.0, 0.0];
    let b = vec![1.0, 1.0, 0.0, 0.0];
    let dist = cpu.distance(&a, &b);
    // 2 bits differ (positions 1 and 2)
    assert!((dist - 2.0).abs() < 1e-5);
}

#[test]
fn test_cpu_distance_jaccard() {
    let cpu = CpuDistance::new(DistanceMetric::Jaccard);
    let a = vec![1.0, 1.0, 0.0, 0.0];
    let b = vec![1.0, 0.0, 1.0, 0.0];
    // intersection = min(1,1) + min(1,0) + min(0,1) + min(0,0) = 1
    // union = max(1,1) + max(1,0) + max(0,1) + max(0,0) = 3
    // similarity = 1/3, distance = 2/3
    let dist = cpu.distance(&a, &b);
    let expected = 1.0 - (1.0 / 3.0);
    assert!((dist - expected).abs() < 1e-5);
}

#[test]
fn test_cpu_distance_metric_accessor() {
    let cpu = CpuDistance::new(DistanceMetric::Euclidean);
    assert_eq!(cpu.metric(), DistanceMetric::Euclidean);
}

#[test]
fn test_simd_distance_metric_accessor() {
    let simd = SimdDistance::new(DistanceMetric::Cosine);
    assert_eq!(simd.metric(), DistanceMetric::Cosine);
}

#[test]
fn test_native_simd_metric_accessor() {
    let native = NativeSimdDistance::new(DistanceMetric::DotProduct);
    assert_eq!(native.metric(), DistanceMetric::DotProduct);
}

#[test]
fn test_simd_dot_product() {
    let simd = SimdDistance::new(DistanceMetric::DotProduct);
    let a = vec![1.0, 2.0, 3.0, 4.0];
    let b = vec![1.0, 1.0, 1.0, 1.0];
    let dist = simd.distance(&a, &b);
    // dot = 10, distance = -10
    assert!((dist + 10.0).abs() < 1e-4);
}

#[test]
fn test_simd_euclidean() {
    let simd = SimdDistance::new(DistanceMetric::Euclidean);
    let a = vec![0.0, 0.0, 0.0, 0.0];
    let b = vec![3.0, 4.0, 0.0, 0.0];
    let dist = simd.distance(&a, &b);
    assert!((dist - 5.0).abs() < 1e-4);
}

#[test]
fn test_native_simd_hamming() {
    let native = NativeSimdDistance::new(DistanceMetric::Hamming);
    let a: Vec<f32> = (0..32)
        .map(|i| if i % 2 == 0 { 1.0 } else { 0.0 })
        .collect();
    let b: Vec<f32> = (0..32)
        .map(|i| if i % 3 == 0 { 1.0 } else { 0.0 })
        .collect();
    let dist = native.distance(&a, &b);
    assert!(dist >= 0.0);
}

#[test]
fn test_native_simd_jaccard() {
    let native = NativeSimdDistance::new(DistanceMetric::Jaccard);
    let a = vec![1.0, 1.0, 0.0, 0.0];
    let b = vec![1.0, 1.0, 1.0, 0.0];
    let dist = native.distance(&a, &b);
    assert!((0.0..=1.0).contains(&dist));
}

// =========================================================================
// Tests for AdaptiveSimdDistance bug fix (returns distance, not similarity)
// =========================================================================

#[test]
fn test_adaptive_simd_cosine_returns_distance() {
    let adaptive = AdaptiveSimdDistance::new(DistanceMetric::Cosine);

    // Identical vectors should have distance ~0 (not similarity ~1)
    let v = vec![1.0, 2.0, 3.0, 4.0];
    let dist = adaptive.distance(&v, &v);
    assert!(
        dist.abs() < 1e-4,
        "AdaptiveSimdDistance should return distance ~0 for identical vectors, got {dist}"
    );

    // Opposite vectors should have distance ~2 (not similarity ~-1)
    let opposite: Vec<f32> = v.iter().map(|x| -x).collect();
    let dist_opposite = adaptive.distance(&v, &opposite);
    assert!(
        (dist_opposite - 2.0).abs() < 1e-4,
        "AdaptiveSimdDistance should return distance ~2 for opposite vectors, got {dist_opposite}"
    );
}

#[test]
fn test_adaptive_simd_dot_product_returns_distance() {
    let adaptive = AdaptiveSimdDistance::new(DistanceMetric::DotProduct);

    // Positive dot product should give negative distance (lower = better)
    let a = vec![1.0, 2.0, 3.0];
    let b = vec![1.0, 1.0, 1.0];
    let dist = adaptive.distance(&a, &b);
    // dot = 1*1 + 2*1 + 3*1 = 6, distance = -6
    assert!(
        dist < 0.0,
        "AdaptiveSimdDistance DotProduct should return negative distance, got {dist}"
    );
    assert!(
        (dist + 6.0).abs() < 1e-4,
        "Expected distance ~-6, got {dist}"
    );
}

#[test]
fn test_adaptive_simd_jaccard_returns_distance() {
    let adaptive = AdaptiveSimdDistance::new(DistanceMetric::Jaccard);

    // Identical vectors should have distance ~0
    let v: Vec<f32> = (0..32)
        .map(|i| if i % 2 == 0 { 1.0 } else { 0.0 })
        .collect();
    let dist = adaptive.distance(&v, &v);
    assert!(
        dist.abs() < 1e-4,
        "AdaptiveSimdDistance Jaccard should return distance ~0 for identical vectors, got {dist}"
    );

    // Jaccard distance should be in [0, 1]
    let b: Vec<f32> = (0..32)
        .map(|i| if i % 3 == 0 { 1.0 } else { 0.0 })
        .collect();
    let dist2 = adaptive.distance(&v, &b);
    assert!(
        (0.0..=1.0).contains(&dist2),
        "AdaptiveSimdDistance Jaccard distance should be in [0,1], got {dist2}"
    );
}

#[test]
fn test_adaptive_simd_matches_native_simd() {
    // Ensure AdaptiveSimdDistance returns same results as NativeSimdDistance
    let adaptive = AdaptiveSimdDistance::new(DistanceMetric::Cosine);
    let native = NativeSimdDistance::new(DistanceMetric::Cosine);

    #[allow(clippy::cast_precision_loss)]
    let a: Vec<f32> = (0..768).map(|i| (i as f32 * 0.01).sin()).collect();
    #[allow(clippy::cast_precision_loss)]
    let b: Vec<f32> = (0..768).map(|i| (i as f32 * 0.02).cos()).collect();

    let adaptive_dist = adaptive.distance(&a, &b);
    let native_dist = native.distance(&a, &b);

    assert!(
        (adaptive_dist - native_dist).abs() < 1e-3,
        "AdaptiveSimdDistance should match NativeSimdDistance: adaptive={adaptive_dist}, native={native_dist}"
    );
}

#[test]
fn test_adaptive_simd_euclidean_returns_distance() {
    let adaptive = AdaptiveSimdDistance::new(DistanceMetric::Euclidean);

    let a = vec![0.0, 0.0, 0.0, 0.0];
    let b = vec![3.0, 4.0, 0.0, 0.0];
    let dist = adaptive.distance(&a, &b);

    assert!(
        (dist - 5.0).abs() < 1e-4,
        "AdaptiveSimdDistance Euclidean should return 5.0 for 3-4-5 triangle, got {dist}"
    );
}

#[test]
fn test_adaptive_simd_hamming_returns_distance() {
    let adaptive = AdaptiveSimdDistance::new(DistanceMetric::Hamming);

    let a: Vec<f32> = (0..32)
        .map(|i| if i % 2 == 0 { 1.0 } else { 0.0 })
        .collect();
    let b: Vec<f32> = (0..32)
        .map(|i| if i % 3 == 0 { 1.0 } else { 0.0 })
        .collect();

    let dist = adaptive.distance(&a, &b);
    assert!(
        dist >= 0.0,
        "AdaptiveSimdDistance Hamming distance should be non-negative, got {dist}"
    );
}

#[test]
#[allow(clippy::cast_precision_loss)]
fn test_native_simd_batch_dot_product() {
    let native = NativeSimdDistance::new(DistanceMetric::DotProduct);
    let query: Vec<f32> = vec![1.0; 16];
    let candidates: Vec<Vec<f32>> = (0..5).map(|i| vec![(i + 1) as f32; 16]).collect();
    let candidate_refs: Vec<&[f32]> = candidates.iter().map(Vec::as_slice).collect();

    let distances = native.batch_distance(&query, &candidate_refs);
    assert_eq!(distances.len(), 5);
    // Each dot product = 16 * (i+1), distance = -dot
    for (i, &d) in distances.iter().enumerate() {
        let expected = -16.0 * ((i + 1) as f32);
        assert!(
            (d - expected).abs() < 1e-3,
            "i={i}: got {d}, expected {expected}"
        );
    }
}

#[test]
fn test_native_simd_batch_euclidean() {
    let native = NativeSimdDistance::new(DistanceMetric::Euclidean);
    let query = vec![0.0; 8];
    let candidates: Vec<Vec<f32>> = vec![vec![1.0; 8], vec![2.0; 8]];
    let candidate_refs: Vec<&[f32]> = candidates.iter().map(Vec::as_slice).collect();

    let distances = native.batch_distance(&query, &candidate_refs);
    assert_eq!(distances.len(), 2);
}

#[test]
fn test_cosine_scalar_zero_norm() {
    // Test division by zero case — scalar functions are pub(super) via module
    let engine = CpuDistance::new(DistanceMetric::Cosine);
    let a = vec![0.0, 0.0, 0.0];
    let b = vec![1.0, 2.0, 3.0];
    let dist = engine.distance(&a, &b);
    assert!(
        (dist - 1.0).abs() < 1e-5,
        "Zero norm should return distance 1.0"
    );
}

#[test]
fn test_jaccard_scalar_zero_union() {
    // Test division by zero case
    let engine = CpuDistance::new(DistanceMetric::Jaccard);
    let a = vec![0.0, 0.0, 0.0];
    let b = vec![0.0, 0.0, 0.0];
    let dist = engine.distance(&a, &b);
    assert!(
        (dist - 1.0).abs() < 1e-5,
        "Zero union should return distance 1.0"
    );
}

#[test]
fn test_cpu_batch_distance_default_impl() {
    let cpu = CpuDistance::new(DistanceMetric::Euclidean);
    let query = vec![0.0, 0.0, 0.0];
    let c1 = vec![1.0, 0.0, 0.0];
    let c2 = vec![0.0, 2.0, 0.0];
    let candidates: Vec<&[f32]> = vec![&c1, &c2];

    let distances = cpu.batch_distance(&query, &candidates);
    assert_eq!(distances.len(), 2);
    assert!((distances[0] - 1.0).abs() < 1e-5);
    assert!((distances[1] - 2.0).abs() < 1e-5);
}

#[test]
fn test_hamming_scalar_all_same() {
    let engine = CpuDistance::new(DistanceMetric::Hamming);
    let a = vec![1.0, 2.0, 3.0];
    let dist = engine.distance(&a, &a);
    assert!((dist - 0.0).abs() < 1e-5);
}

#[test]
fn test_hamming_scalar_all_different() {
    let engine = CpuDistance::new(DistanceMetric::Hamming);
    let a = vec![1.0, 2.0, 3.0];
    let b = vec![4.0, 5.0, 6.0];
    let dist = engine.distance(&a, &b);
    assert!((dist - 3.0).abs() < 1e-5);
}

// =========================================================================
// Tests for CachedSimdDistance — bit-for-bit parity with SimdDistance
// =========================================================================

#[allow(clippy::cast_precision_loss)]
fn gen_vec(dim: usize, seed: f32) -> Vec<f32> {
    (0..dim).map(|i| (seed + i as f32 * 0.01).sin()).collect()
}

#[test]
fn test_cached_vs_simd_cosine_768d() {
    let dim = 768;
    let simd = SimdDistance::new(DistanceMetric::Cosine);
    let cached = CachedSimdDistance::new(DistanceMetric::Cosine, dim);
    let a = gen_vec(dim, 0.0);
    let b = gen_vec(dim, 1.0);
    let s = simd.distance(&a, &b);
    let c = cached.distance(&a, &b);
    assert_eq!(s, c, "cosine 768d: simd={s}, cached={c}");
}

#[test]
fn test_cached_vs_simd_euclidean_128d() {
    let dim = 128;
    let simd = SimdDistance::new(DistanceMetric::Euclidean);
    let cached = CachedSimdDistance::new(DistanceMetric::Euclidean, dim);
    let a = gen_vec(dim, 0.0);
    let b = gen_vec(dim, 1.0);
    let s = simd.distance(&a, &b);
    let c = cached.distance(&a, &b);
    assert_eq!(s, c, "euclidean 128d: simd={s}, cached={c}");
}

#[test]
fn test_cached_vs_simd_dot_product_1536d() {
    let dim = 1536;
    let simd = SimdDistance::new(DistanceMetric::DotProduct);
    let cached = CachedSimdDistance::new(DistanceMetric::DotProduct, dim);
    let a = gen_vec(dim, 0.0);
    let b = gen_vec(dim, 1.0);
    let s = simd.distance(&a, &b);
    let c = cached.distance(&a, &b);
    assert_eq!(s, c, "dot_product 1536d: simd={s}, cached={c}");
}

#[test]
fn test_cached_vs_simd_hamming_64d() {
    let dim = 64;
    let simd = SimdDistance::new(DistanceMetric::Hamming);
    let cached = CachedSimdDistance::new(DistanceMetric::Hamming, dim);
    let a: Vec<f32> = (0..dim)
        .map(|i| if i % 3 == 0 { 1.0 } else { 0.0 })
        .collect();
    let b: Vec<f32> = (0..dim)
        .map(|i| if i % 2 == 0 { 1.0 } else { 0.0 })
        .collect();
    let s = simd.distance(&a, &b);
    let c = cached.distance(&a, &b);
    assert_eq!(s, c, "hamming 64d: simd={s}, cached={c}");
}

#[test]
fn test_cached_vs_simd_jaccard_256d() {
    let dim = 256;
    let simd = SimdDistance::new(DistanceMetric::Jaccard);
    let cached = CachedSimdDistance::new(DistanceMetric::Jaccard, dim);
    let a: Vec<f32> = (0..dim)
        .map(|i| if i < dim / 2 { 1.0 } else { 0.0 })
        .collect();
    let b: Vec<f32> = (0..dim)
        .map(|i| if i < dim * 3 / 4 { 1.0 } else { 0.0 })
        .collect();
    let s = simd.distance(&a, &b);
    let c = cached.distance(&a, &b);
    assert_eq!(s, c, "jaccard 256d: simd={s}, cached={c}");
}

#[test]
fn test_cached_batch_distance_matches_single() {
    let dim = 128;
    let cached = CachedSimdDistance::new(DistanceMetric::Cosine, dim);
    let query = gen_vec(dim, 0.0);
    let candidates: Vec<Vec<f32>> = (0..20).map(|j| gen_vec(dim, j as f32)).collect();
    let candidate_refs: Vec<&[f32]> = candidates.iter().map(Vec::as_slice).collect();

    let batch = cached.batch_distance(&query, &candidate_refs);
    let single: Vec<f32> = candidate_refs
        .iter()
        .map(|c| cached.distance(&query, c))
        .collect();

    for (i, (b, s)) in batch.iter().zip(single.iter()).enumerate() {
        assert_eq!(
            b, s,
            "batch vs single mismatch at {i}: batch={b}, single={s}"
        );
    }
}

// =========================================================================
// F-22: Pre-normalization tests
// =========================================================================

#[test]
fn test_prenormalized_cosine_uses_dot_product() {
    let dim = 128;
    let prenorm = CachedSimdDistance::new_prenormalized(DistanceMetric::Cosine, dim);
    assert!(prenorm.is_pre_normalized());

    // Pre-normalize two vectors manually
    let mut a = gen_vec(dim, 0.0);
    let mut b = gen_vec(dim, 1.0);
    crate::simd_native::normalize_inplace_native(&mut a);
    crate::simd_native::normalize_inplace_native(&mut b);

    // Prenormalized cosine distance should equal 1 - dot(a, b)
    let prenorm_dist = prenorm.distance(&a, &b);
    let dot = crate::simd_native::dot_product_native(&a, &b);
    let expected = 1.0 - dot;
    assert!(
        (prenorm_dist - expected).abs() < 1e-6,
        "prenorm cosine: got {prenorm_dist}, expected {expected}"
    );
}

#[test]
fn test_prenormalized_matches_standard_cosine_on_unit_vectors() {
    let dim = 768;
    let standard = CachedSimdDistance::new(DistanceMetric::Cosine, dim);
    let prenorm = CachedSimdDistance::new_prenormalized(DistanceMetric::Cosine, dim);

    let mut a = gen_vec(dim, 0.5);
    let mut b = gen_vec(dim, 2.0);
    crate::simd_native::normalize_inplace_native(&mut a);
    crate::simd_native::normalize_inplace_native(&mut b);

    let standard_dist = standard.distance(&a, &b);
    let prenorm_dist = prenorm.distance(&a, &b);

    // For unit vectors, both should give the same result
    assert!(
        (standard_dist - prenorm_dist).abs() < 1e-5,
        "standard={standard_dist}, prenorm={prenorm_dist} should match on unit vectors"
    );
}

#[test]
fn test_prenormalized_flag_only_affects_cosine() {
    let dim = 64;
    let prenorm = CachedSimdDistance::new_prenormalized(DistanceMetric::Euclidean, dim);
    let standard = CachedSimdDistance::new(DistanceMetric::Euclidean, dim);

    let a = gen_vec(dim, 0.0);
    let b = gen_vec(dim, 1.0);

    // Pre-normalization flag has no effect on non-Cosine metrics
    assert_eq!(
        prenorm.distance(&a, &b),
        standard.distance(&a, &b),
        "Pre-normalization must not affect Euclidean distance"
    );
}

#[test]
fn test_non_prenormalized_cosine_flag_is_false() {
    let standard = CachedSimdDistance::new(DistanceMetric::Cosine, 128);
    assert!(!standard.is_pre_normalized());
}

#[test]
fn test_default_distance_engine_is_not_prenormalized() {
    let cpu = CpuDistance::new(DistanceMetric::Cosine);
    assert!(!cpu.is_pre_normalized());
}