velesdb-core 1.14.1

High-performance vector database engine written in Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
//! Tests for auto-reindex module (TDD - US-004)

use super::*;
use std::time::Duration;

// ============================================================================
// CA-1: Parameter mismatch detection tests
// ============================================================================

#[test]
fn test_detect_params_mismatch_triggers_reindex() {
    let manager = AutoReindexManager::with_defaults();

    // Small dataset created with small params (M=16)
    let small_params = HnswParams::custom(16, 100, 10_000);

    // Dataset grew to 100K - optimal is M=128 for high-dim
    let current_size = 100_000;
    let dimension = 768;

    let check = manager.check_divergence(&small_params, current_size, dimension);

    // Optimal M for 100K@768D is 128, current is 16
    // Ratio = 128/16 = 8.0, threshold is 1.5
    assert!(
        check.should_reindex,
        "Should trigger reindex when params diverge significantly"
    );
    assert!(check.ratio >= 1.5, "Ratio should exceed threshold");
    assert!(check.reason.is_some(), "Should have a reason");

    if let Some(ReindexReason::ParamDivergence {
        current_m,
        optimal_m,
        ratio,
    }) = check.reason
    {
        assert_eq!(current_m, 16);
        assert!(optimal_m > current_m);
        assert!(ratio >= 1.5);
    } else {
        panic!("Expected ParamDivergence reason");
    }
}

#[test]
fn test_no_reindex_when_params_optimal() {
    let manager = AutoReindexManager::with_defaults();

    // Params already optimal for 100K dataset
    let dimension = 768;
    let current_size = 100_000;
    let optimal_params = HnswParams::for_dataset_size(dimension, current_size);

    let check = manager.check_divergence(&optimal_params, current_size, dimension);

    assert!(
        !check.should_reindex,
        "Should not reindex when params are already optimal"
    );
    assert!(
        (check.ratio - 1.0).abs() < 0.01,
        "Ratio should be ~1.0 for optimal params"
    );
}

#[test]
fn test_no_reindex_below_min_size() {
    let manager = AutoReindexManager::with_defaults(); // min_size = 10_000

    // Very suboptimal params but small dataset
    let small_params = HnswParams::custom(8, 50, 1_000);
    let current_size = 5_000; // Below min threshold
    let dimension = 768;

    let check = manager.check_divergence(&small_params, current_size, dimension);

    assert!(
        !check.should_reindex,
        "Should not reindex datasets below min_size_for_reindex"
    );
}

#[test]
fn test_threshold_configurable() {
    // Very high threshold - won't trigger easily
    let config = AutoReindexConfig {
        param_divergence_threshold: 10.0, // Only trigger if optimal is 10x current
        ..Default::default()
    };
    let manager = AutoReindexManager::new(config);

    let small_params = HnswParams::custom(16, 100, 10_000);
    let current_size = 100_000;
    let dimension = 768;

    let check = manager.check_divergence(&small_params, current_size, dimension);

    // Ratio ~8.0 is below threshold of 10.0
    assert!(!check.should_reindex, "Should respect custom threshold");

    // Now with lower threshold
    let sensitive_config = AutoReindexConfig::sensitive(); // threshold = 1.25
    let sensitive_manager = AutoReindexManager::new(sensitive_config);

    let check2 = sensitive_manager.check_divergence(&small_params, current_size, dimension);
    assert!(
        check2.should_reindex,
        "Sensitive config should trigger more easily"
    );
}

#[test]
fn test_disabled_config_never_triggers() {
    let config = AutoReindexConfig::disabled();
    let manager = AutoReindexManager::new(config);

    // Even with huge divergence
    let tiny_params = HnswParams::custom(4, 10, 100);
    let current_size = 1_000_000;
    let dimension = 768;

    let check = manager.check_divergence(&tiny_params, current_size, dimension);

    assert!(
        !check.should_reindex,
        "Disabled config should never trigger reindex"
    );
}

// ============================================================================
// CA-2: Background reindex (state machine) tests
// ============================================================================

#[test]
fn test_reindex_state_machine_idle_to_building() {
    let manager = AutoReindexManager::with_defaults();

    assert_eq!(manager.state(), ReindexState::Idle);

    let started = manager.trigger_manual_reindex();
    assert!(started, "Should be able to start from Idle");
    assert_eq!(manager.state(), ReindexState::Building);
}

#[test]
fn test_reindex_cannot_start_twice() {
    let manager = AutoReindexManager::with_defaults();

    let first = manager.trigger_manual_reindex();
    assert!(first);

    let second = manager.trigger_manual_reindex();
    assert!(!second, "Should not start reindex when already in progress");
}

#[test]
fn test_reindex_progress_updates() {
    let manager = AutoReindexManager::with_defaults();
    let progress_values = Arc::new(std::sync::Mutex::new(Vec::new()));
    let progress_clone = progress_values.clone();

    manager.on_event(move |event| {
        if let ReindexEvent::Progress { percent } = event {
            progress_clone.lock().unwrap().push(percent);
        }
    });

    manager.trigger_manual_reindex();
    manager.report_progress(25);
    manager.report_progress(50);
    manager.report_progress(75);
    manager.report_progress(100);

    let values = progress_values.lock().unwrap();
    assert_eq!(*values, vec![25, 50, 75, 100]);
}

#[test]
fn test_reindex_validation_phase() {
    let manager = AutoReindexManager::with_defaults();

    manager.trigger_manual_reindex();
    assert_eq!(manager.state(), ReindexState::Building);

    let transitioned = manager.start_validation(1000, 950);
    assert!(transitioned);
    assert_eq!(manager.state(), ReindexState::Validating);
}

#[test]
fn test_queries_continue_during_reindex() {
    // This test verifies that the state doesn't block query operations
    // In a real implementation, the index would have Arc<RwLock<>> for concurrent access
    let manager = AutoReindexManager::with_defaults();

    manager.trigger_manual_reindex();
    assert_eq!(manager.state(), ReindexState::Building);

    // State is readable during reindex (non-blocking)
    assert!(manager.is_enabled());
    let config = manager.config();
    assert!(config.enabled);

    // Can check divergence during reindex
    let params = HnswParams::default();
    let check = manager.check_divergence(&params, 10_000, 768);
    assert!(!check.should_reindex); // Already reindexing, so new check returns false
}

// ============================================================================
// CA-3: Rollback tests
// ============================================================================

#[test]
fn test_rollback_on_latency_regression() {
    let manager = AutoReindexManager::with_defaults();

    let old_bench = BenchmarkResult {
        latency_p99_us: 1000,
        recall_estimate: 0.95,
        query_count: 100,
    };

    // New index is 20% slower (regression > 10% threshold)
    let new_bench = BenchmarkResult {
        latency_p99_us: 1200,
        recall_estimate: 0.96,
        query_count: 100,
    };

    let result = manager.validate_benchmark(&old_bench, &new_bench);
    assert!(result.is_err(), "Should reject due to latency regression");
    assert!(result.unwrap_err().contains("Latency regression"));
}

#[test]
fn test_rollback_on_recall_regression() {
    let manager = AutoReindexManager::with_defaults();

    let old_bench = BenchmarkResult {
        latency_p99_us: 1000,
        recall_estimate: 0.95,
        query_count: 100,
    };

    // New index has 5% recall drop (regression > 2% threshold)
    let new_bench = BenchmarkResult {
        latency_p99_us: 900,
        recall_estimate: 0.90,
        query_count: 100,
    };

    let result = manager.validate_benchmark(&old_bench, &new_bench);
    assert!(result.is_err(), "Should reject due to recall regression");
    assert!(result.unwrap_err().contains("Recall regression"));
}

#[test]
fn test_validation_passes_when_improved() {
    let manager = AutoReindexManager::with_defaults();

    let old_bench = BenchmarkResult {
        latency_p99_us: 1000,
        recall_estimate: 0.93,
        query_count: 100,
    };

    // New index is better in both metrics
    let new_bench = BenchmarkResult {
        latency_p99_us: 800,
        recall_estimate: 0.96,
        query_count: 100,
    };

    let result = manager.validate_benchmark(&old_bench, &new_bench);
    assert!(result.is_ok(), "Should pass when new index is better");
}

#[test]
fn test_rollback_preserves_idle_state() {
    let manager = AutoReindexManager::with_defaults();

    manager.trigger_manual_reindex();
    manager.start_validation(1000, 1200);

    let rolled_back = manager.rollback("Latency regression".to_string());
    assert!(rolled_back);
    assert_eq!(
        manager.state(),
        ReindexState::Idle,
        "Should return to Idle after rollback"
    );
}

#[test]
fn test_rollback_event_emitted() {
    let manager = AutoReindexManager::with_defaults();
    let rollback_reason = Arc::new(std::sync::Mutex::new(String::new()));
    let reason_clone = rollback_reason.clone();

    manager.on_event(move |event| {
        if let ReindexEvent::RolledBack { reason } = event {
            *reason_clone.lock().unwrap() = reason;
        }
    });

    manager.trigger_manual_reindex();
    manager.rollback("Test rollback".to_string());

    assert_eq!(*rollback_reason.lock().unwrap(), "Test rollback");
}

// ============================================================================
// CA-4: API and events tests
// ============================================================================

#[test]
fn test_manual_trigger_reindex() {
    let manager = AutoReindexManager::with_defaults();

    let triggered = manager.trigger_manual_reindex();
    assert!(triggered);
    assert_eq!(manager.state(), ReindexState::Building);
}

#[test]
fn test_set_auto_reindex_toggle() {
    let manager = AutoReindexManager::with_defaults();

    assert!(manager.is_enabled());

    manager.set_enabled(false);
    assert!(!manager.is_enabled());

    manager.set_enabled(true);
    assert!(manager.is_enabled());
}

#[test]
fn test_events_emitted_correctly() {
    let manager = AutoReindexManager::with_defaults();
    let events = Arc::new(std::sync::Mutex::new(Vec::new()));
    let events_clone = events.clone();

    manager.on_event(move |event| {
        let event_type = match &event {
            ReindexEvent::Started { .. } => "Started",
            ReindexEvent::Progress { .. } => "Progress",
            ReindexEvent::Validating { .. } => "Validating",
            ReindexEvent::Completed { .. } => "Completed",
            ReindexEvent::RolledBack { .. } => "RolledBack",
        };
        events_clone.lock().unwrap().push(event_type.to_string());
    });

    // Full successful reindex cycle
    manager.trigger_manual_reindex();
    manager.report_progress(50);
    manager.start_validation(1000, 900);
    manager.complete_reindex(Duration::from_secs(10));

    let recorded = events.lock().unwrap();
    assert_eq!(
        *recorded,
        vec!["Started", "Progress", "Validating", "Completed"]
    );
}

#[test]
fn test_start_reindex_with_params() {
    let manager = AutoReindexManager::with_defaults();
    let captured_params = Arc::new(std::sync::Mutex::new(None));
    let params_clone = captured_params.clone();

    manager.on_event(move |event| {
        if let ReindexEvent::Started {
            reason,
            old_params,
            new_params,
        } = event
        {
            *params_clone.lock().unwrap() = Some((reason, old_params, new_params));
        }
    });

    let old = HnswParams::custom(16, 100, 10_000);
    let new = HnswParams::custom(64, 400, 100_000);
    let reason = ReindexReason::ParamDivergence {
        current_m: 16,
        optimal_m: 64,
        ratio: 4.0,
    };

    manager.start_reindex(reason.clone(), old, new);

    let captured = captured_params.lock().unwrap();
    assert!(captured.is_some());
    let (r, o, n) = captured.as_ref().unwrap();
    assert_eq!(o.max_connections, 16);
    assert_eq!(n.max_connections, 64);
    assert!(matches!(r, ReindexReason::ParamDivergence { .. }));
}

// ============================================================================
// Cooldown tests
// ============================================================================

#[test]
fn test_cooldown_prevents_immediate_reindex() {
    let config = AutoReindexConfig {
        cooldown: Duration::from_secs(3600), // 1 hour
        ..Default::default()
    };
    let manager = AutoReindexManager::new(config);

    // Complete a reindex
    manager.trigger_manual_reindex();
    manager.start_validation(1000, 900);
    manager.complete_reindex(Duration::from_secs(5));

    // Now should_reindex should return false due to cooldown
    let small_params = HnswParams::custom(16, 100, 10_000);
    let should = manager.should_reindex(&small_params, 100_000, 768);

    assert!(!should, "Should not trigger reindex during cooldown period");
}

// ============================================================================
// Edge cases
// ============================================================================

#[test]
fn test_zero_current_m_handled() {
    let manager = AutoReindexManager::with_defaults();

    // Edge case: M=0 (invalid but should not panic)
    let zero_params = HnswParams::custom(0, 100, 10_000);

    let check = manager.check_divergence(&zero_params, 100_000, 768);

    // Should handle gracefully (infinite ratio)
    assert!(check.ratio.is_infinite() || check.ratio > 100.0);
}

#[test]
fn test_reset_clears_state() {
    let manager = AutoReindexManager::with_defaults();

    manager.trigger_manual_reindex();
    assert_eq!(manager.state(), ReindexState::Building);

    manager.reset();
    assert_eq!(manager.state(), ReindexState::Idle);
}

#[test]
fn test_config_presets() {
    let default = AutoReindexConfig::default();
    assert!(default.enabled);
    assert!((default.param_divergence_threshold - 1.5).abs() < 0.01);

    let disabled = AutoReindexConfig::disabled();
    assert!(!disabled.enabled);

    let sensitive = AutoReindexConfig::sensitive();
    assert!((sensitive.param_divergence_threshold - 1.25).abs() < 0.01);
    assert_eq!(sensitive.min_size_for_reindex, 5_000);

    let conservative = AutoReindexConfig::conservative();
    assert!((conservative.param_divergence_threshold - 2.0).abs() < 0.01);
    assert_eq!(conservative.min_size_for_reindex, 50_000);
}