vecboost 0.3.0-rc.1

High-performance embedding vector service written in Rust
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
// Copyright (c) 2025-2026 Kirky.X🌠
// SPDX-License-Identifier: Apache-2.0

use crate::config::model::{EngineType, ModelConfig};
use crate::error::VecboostError;
use crate::model::loader::{LoadedModel, LocalModelLoader, ModelLoader};
use log::info;
use log::warn;
use std::collections::HashMap;
use std::path::PathBuf;
use std::sync::Arc;
use std::sync::atomic::{AtomicU64, Ordering};
use std::time::Duration;
use tokio::sync::RwLock;
use tokio::time::timeout;

const DEFAULT_MODEL_LOAD_TIMEOUT_SECS: u64 = 300;

/// LFRU 决策计数衰减周期:每 1024 次 load 决策全局 heat 减半。
const HEAT_DECAY_PERIOD: u64 = 1024;
/// recency 分桶数(新近度权重 ≤ 1/256)。
const RECENCY_BUCKETS: u64 = 8;
/// 每桶覆盖的序列步长。
const RECENCY_BUCKET_SPAN: u64 = 128;

/// 驻留管理配置(port 自 colibri tier.h/LFRU)。
#[derive(Clone, Copy, Debug)]
pub struct ResidencyConfig {
    /// 最大驻留模型数。
    pub max_models: usize,
    /// 驻留内存预算(MB),None 表示不限制。
    pub memory_budget_mb: Option<u64>,
}

#[derive(Clone)]
pub struct ModelManager {
    models: Arc<RwLock<HashMap<String, Arc<dyn LoadedModel>>>>,
    loader: Arc<dyn ModelLoader>,
    default_config: ModelConfig,
    timeout_duration: Duration,
    residency: Option<ResidencyConfig>,
    /// heat 表:u32 饱和计数,粘滞不回绕;key 为模型名,unload 后保留、
    /// 经 heat.rs 持久化(warmstart 种子)。
    heat: Arc<RwLock<HashMap<String, u32>>>,
    /// recency 表:模型名 → 最后命中序列号。
    recency: Arc<RwLock<HashMap<String, u64>>>,
    seq: Arc<AtomicU64>,
    decisions: Arc<AtomicU64>,
}

impl ModelManager {
    pub fn new() -> Self {
        Self::with_loader(
            Arc::new(LocalModelLoader::new(PathBuf::from("models"))) as Arc<dyn ModelLoader>
        )
    }

    pub fn with_loader(loader: Arc<dyn ModelLoader>) -> Self {
        Self {
            models: Arc::new(RwLock::new(HashMap::new())),
            loader,
            default_config: ModelConfig::default(),
            timeout_duration: Duration::from_secs(DEFAULT_MODEL_LOAD_TIMEOUT_SECS),
            residency: None,
            heat: Arc::new(RwLock::new(HashMap::new())),
            recency: Arc::new(RwLock::new(HashMap::new())),
            seq: Arc::new(AtomicU64::new(0)),
            decisions: Arc::new(AtomicU64::new(0)),
        }
    }

    /// 启用 LFRU 驻留管理。默认不限制(现状行为)。
    /// `max_models = 0` 视为不限制。
    pub fn with_residency(mut self, max_models: usize, memory_budget_mb: Option<u64>) -> Self {
        if max_models == 0 {
            self.residency = None;
        } else {
            self.residency = Some(ResidencyConfig {
                max_models,
                memory_budget_mb,
            });
        }
        self
    }

    /// 查询模型当前 heat(测试与 heat.rs 落盘用)。
    pub async fn heat_of(&self, name: &str) -> u32 {
        self.heat.read().await.get(name).copied().unwrap_or(0)
    }

    /// 测试专用:预置 heat(模拟 warmstart 种子)。
    #[cfg(test)]
    pub async fn seed_heat(&self, name: &str, heat: u32) {
        self.heat.write().await.insert(name.to_string(), heat);
    }

    /// 记录一次命中:heat 饱和 +1,recency 推进。
    async fn record_hit(&self, name: &str) {
        {
            let mut heat = self.heat.write().await;
            let e = heat.entry(name.to_string()).or_insert(0);
            *e = e.saturating_add(1);
        }
        let s = self.seq.fetch_add(1, Ordering::Relaxed);
        self.recency.write().await.insert(name.to_string(), s);
    }

    /// LFRU 评分:`score = (heat << 8) | recency_bucket`。
    fn score_of(heat: u32, bucket: u64) -> u64 {
        ((heat as u64) << 8) | (bucket & 0xFF)
    }

    /// 由序列号折算 8 桶新近度(越新越大,最大 7)。
    fn bucket_for(entry_seq: u64, cur_seq: u64) -> u64 {
        let age = cur_seq.saturating_sub(entry_seq);
        (RECENCY_BUCKETS - 1).saturating_sub((age / RECENCY_BUCKET_SPAN).min(RECENCY_BUCKETS - 1))
    }

    /// 迟滞判定:候选 heat 低于现任 heat 的 25%+4 点时不驱逐(防乒乓)。
    /// 即仅当 `candidate + victim/4 + 4 >= victim` 时允许驱逐(整数运算)。
    fn hysteresis_passes(candidate_heat: u32, victim_heat: u32) -> bool {
        let margin = victim_heat / 4 + 4;
        candidate_heat.saturating_add(margin) >= victim_heat
    }

    /// 从 heat.rs 文件加载 warmstart 初始 heat(损坏/指纹不匹配即弃,见 heat.rs)。
    /// 与内存热度取 max 合并,不丢失更热的运行态。
    pub async fn load_heat_file(&self, path: &std::path::Path) {
        let loaded = super::heat::load_heat(path);
        if loaded.is_empty() {
            return;
        }
        let mut heat = self.heat.write().await;
        for (name, h) in loaded {
            let e = heat.entry(name).or_insert(0);
            *e = (*e).max(h);
        }
        info!("Model heat warmstart loaded: {} entries", heat.len());
    }

    /// 热度落盘(原子写,见 heat.rs)。
    pub async fn save_heat_file(&self, path: &std::path::Path) -> std::io::Result<()> {
        let heat = self.heat.read().await;
        super::heat::save_heat(path, &heat)
    }

    pub fn with_timeout(mut self, timeout_secs: u64) -> Self {
        self.timeout_duration = Duration::from_secs(timeout_secs);
        self
    }

    pub async fn load(&self, config: &ModelConfig) -> Result<Arc<dyn LoadedModel>, VecboostError> {
        let model_name = config.name.clone();

        if let Some(existing) = self.get(&model_name).await {
            info!(
                "Model {} already loaded, reusing existing instance",
                model_name
            );
            self.record_hit(&model_name).await;
            return Ok(existing);
        }

        info!(
            "Loading model: {} from {:?} (timeout: {:?})",
            model_name, config.model_path, self.timeout_duration
        );

        let load_future = self.loader.load(config);
        match timeout(self.timeout_duration, load_future).await {
            Ok(Ok(model)) => {
                let mut models = self.models.write().await;
                models.insert(model_name.clone(), Arc::clone(&model));
                drop(models);

                // 新条目:保留历史 heat(重载恢复),无历史则从 1 起步。
                {
                    let mut heat = self.heat.write().await;
                    heat.entry(model_name.clone()).or_insert(1);
                }
                let s = self.seq.fetch_add(1, Ordering::Relaxed);
                self.recency.write().await.insert(model_name.clone(), s);
                // 衰减:每 1024 次 load 决策全局减半(防旧工作负载永久冻结)。
                let d = self.decisions.fetch_add(1, Ordering::Relaxed) + 1;
                if d.is_multiple_of(HEAT_DECAY_PERIOD) {
                    let mut heat = self.heat.write().await;
                    for v in heat.values_mut() {
                        *v /= 2;
                    }
                    info!("Model heat decayed (decision #{})", d);
                }

                info!("Model {} loaded successfully", model_name);
                self.enforce_residency(&model_name).await;
                Ok(model)
            }
            Ok(Err(e)) => {
                warn!("Model {} loading failed: {}", model_name, e);
                Err(VecboostError::ModelLoadError(format!(
                    "Failed to load model {}: {}",
                    model_name, e
                )))
            }
            Err(_) => {
                warn!(
                    "Model {} loading timed out after {:?}",
                    model_name, self.timeout_duration
                );
                Err(VecboostError::ModelLoadError(format!(
                    "Model loading timed out after {} seconds: {}",
                    self.timeout_duration.as_secs(),
                    model_name
                )))
            }
        }
    }

    pub async fn get(&self, name: &str) -> Option<Arc<dyn LoadedModel>> {
        let models = self.models.read().await;
        models.get(name).map(Arc::clone)
    }

    pub async fn unload(&self, name: &str) -> Result<(), VecboostError> {
        let mut models = self.models.write().await;

        if let Some(model) = models.remove(name) {
            info!("Model {} unloaded successfully", name);
            drop(model);
            drop(models);
            // heat 保留(重载恢复/warmstart 种子),recency 清除。
            self.recency.write().await.remove(name);
            Ok(())
        } else {
            warn!("Model {} not found for unloading", name);
            Err(VecboostError::NotFound(format!(
                "Model not found: {}",
                name
            )))
        }
    }

    /// 驻留 enforcement:超驻留上限时按 LFRU 驱逐。
    ///
    /// - 受害者 = `score=(heat<<8)|recency_bucket` 最低的驻留模型;
    /// - 迟滞:新条目 heat 低于受害者 heat 的 25%+4 点时不驱逐(防乒乓,
    ///   此时允许暂时超驻留——新模型需经命中证明自己);
    /// - 有 in-flight 引用(`Arc::strong_count > 2`)的模型跳过本轮;
    /// - 内存预算为硬约束:超预算时忽略迟滞继续驱逐(防 OOM)。
    ///
    /// 驱逐走既有 `unload` 路径,决策记日志。
    async fn enforce_residency(&self, newcomer: &str) {
        let residency = match self.residency {
            Some(r) => r,
            None => return,
        };
        // 数量上限。
        loop {
            let victim = self.pick_victim(Some(newcomer)).await;
            let Some((name, victim_heat, victim_score)) = victim else {
                break;
            };
            {
                let models = self.models.read().await;
                if models.len() <= residency.max_models {
                    break;
                }
            }
            let newcomer_heat = self.heat_of(newcomer).await;
            if !Self::hysteresis_passes(newcomer_heat, victim_heat) {
                info!(
                    "Residency: keep {} (heat {}) over {} (heat {}): hysteresis blocks eviction",
                    newcomer, newcomer_heat, name, victim_heat
                );
                break;
            }
            info!(
                "Residency: evicting {} (heat {}, score {}) for {} (heat {})",
                name, victim_heat, victim_score, newcomer, newcomer_heat
            );
            if self.unload(&name).await.is_err() {
                break;
            }
        }
        // 内存预算(硬约束,忽略迟滞;新来者同样受预算约束)。
        if let Some(budget_mb) = residency.memory_budget_mb {
            let budget_bytes = budget_mb.saturating_mul(1024 * 1024);
            loop {
                if self.resident_bytes().await <= budget_bytes {
                    break;
                }
                let victim = self.pick_victim(None).await;
                let Some((name, victim_heat, victim_score)) = victim else {
                    break;
                };
                info!(
                    "Residency: over memory budget, evicting {} (heat {}, score {})",
                    name, victim_heat, victim_score
                );
                if self.unload(&name).await.is_err() {
                    break;
                }
            }
        }
    }

    /// 选择驱逐受害者:分数最低的非 in-flight 驻留模型。
    /// (迟滞由调用方在 newcomer 与受害者之间判定,此处只负责排序与跳过。
    /// `exclude` 排除刚载入的新来者——数量上限场景不立即反杀新人;
    /// 预算场景传 None,新来者同样可被驱逐。)
    async fn pick_victim(&self, exclude: Option<&str>) -> Option<(String, u32, u64)> {
        let models = self.models.read().await;
        let heat = self.heat.read().await;
        let recency = self.recency.read().await;
        let cur = self.seq.load(Ordering::Relaxed);
        let mut best: Option<(String, u32, u64)> = None;
        for (name, model) in models.iter() {
            if Some(name.as_str()) == exclude {
                continue;
            }
            // in-flight 引用跳过本轮(map 持 1 + 调用方至多 1 = 2 为空闲)。
            if Arc::strong_count(model) > 2 {
                continue;
            }
            let h = heat.get(name).copied().unwrap_or(0);
            let bucket = recency
                .get(name)
                .map(|s| Self::bucket_for(*s, cur))
                .unwrap_or(0);
            let score = Self::score_of(h, bucket);
            if best.as_ref().map(|(_, _, bs)| score < *bs).unwrap_or(true) {
                best = Some((name.clone(), h, score));
            }
        }
        best
    }

    /// 当前驻留模型总字节数(文件缺失按 0 计)。
    async fn resident_bytes(&self) -> u64 {
        let models = self.models.read().await;
        let mut total = 0u64;
        for model in models.values() {
            if let Ok(meta) = std::fs::metadata(model.path()) {
                // GGUF 量化引擎是加载期反量化桥,运行期内存
                // ≈ 文件体积的数倍(Q8_0 ~4×、Q4_K ~7×),统一按保守 4× 估算,
                // 否则 memory_budget 对量化模型形同虚设。
                let is_quantized = model
                    .path()
                    .extension()
                    .and_then(|e| e.to_str())
                    .map(|e| e.eq_ignore_ascii_case("gguf"))
                    .unwrap_or(false);
                let bytes = if is_quantized {
                    meta.len().saturating_mul(4)
                } else {
                    meta.len()
                };
                total = total.saturating_add(bytes);
            }
        }
        total
    }

    pub async fn unload_all(&self) {
        let mut models = self.models.write().await;
        let model_names: Vec<String> = models.keys().cloned().collect();

        for name in model_names {
            if let Some(model) = models.remove(&name) {
                info!("Unloaded model: {}", name);
                drop(model);
            }
        }
        drop(models);
        // heat 保留(warmstart 种子),recency 清除。
        self.recency.write().await.clear();

        info!("All models unloaded");
    }

    pub async fn reload(&self, name: &str) -> Result<Arc<dyn LoadedModel>, VecboostError> {
        let config = {
            let models = self.models.read().await;
            let model = models
                .get(name)
                .ok_or_else(|| VecboostError::NotFound(format!("Model not found: {}", name)))?;

            ModelConfig {
                name: name.to_string(),
                engine_type: model.engine_type(),
                model_path: model.path().to_path_buf(),
                tokenizer_path: None,
                device: crate::config::model::DeviceType::Cpu,
                max_batch_size: 32,
                pooling_mode: None,
                expected_dimension: None,
                memory_limit_bytes: None,
                oom_fallback_enabled: false,
                model_sha256: None,
                quantized: false,
            }
        };

        self.unload(name).await?;
        self.load(&config).await
    }

    pub async fn count(&self) -> usize {
        self.models.read().await.len()
    }

    pub async fn is_loaded(&self, name: &str) -> bool {
        self.models.read().await.contains_key(name)
    }

    pub async fn list_loaded(&self) -> Vec<String> {
        let models = self.models.read().await;
        models.keys().cloned().collect()
    }

    pub async fn stats(&self) -> ModelStats {
        let models = self.models.read().await;

        let candle_count = models
            .values()
            .filter(|m| m.engine_type() == EngineType::Candle)
            .count();

        let onnx_count = models
            .values()
            .filter(|_m| {
                #[cfg(feature = "onnx")]
                {
                    _m.engine_type() == EngineType::Onnx
                }
                #[cfg(not(feature = "onnx"))]
                {
                    false
                }
            })
            .count();

        let mut total_model_size = 0;
        for model in models.values() {
            if let Ok(metadata) = std::fs::metadata(model.path()) {
                total_model_size += metadata.len();
            }
        }

        ModelStats {
            total_models: models.len(),
            candle_models: candle_count,
            onnx_models: onnx_count,
            total_size_bytes: total_model_size,
        }
    }

    pub fn set_default_config(&mut self, config: ModelConfig) {
        self.default_config = config;
    }

    pub async fn load_default(&self) -> Result<Arc<dyn LoadedModel>, VecboostError> {
        self.load(&self.default_config).await
    }
}

impl Default for ModelManager {
    fn default() -> Self {
        Self::new()
    }
}

#[derive(Debug, Clone)]
pub struct ModelStats {
    pub total_models: usize,
    pub candle_models: usize,
    pub onnx_models: usize,
    pub total_size_bytes: u64,
}

impl ModelStats {
    pub fn total_size_mb(&self) -> f64 {
        self.total_size_bytes as f64 / (1024.0 * 1024.0)
    }

    pub fn format_size(&self) -> String {
        if self.total_size_bytes < 1024 {
            format!("{} B", self.total_size_bytes)
        } else if self.total_size_bytes < 1024 * 1024 {
            format!("{} KB", self.total_size_bytes / 1024)
        } else if self.total_size_bytes < 1024 * 1024 * 1024 {
            format!("{:.2} MB", self.total_size_bytes as f64 / (1024.0 * 1024.0))
        } else {
            format!(
                "{:.2} GB",
                self.total_size_bytes as f64 / (1024.0 * 1024.0 * 1024.0)
            )
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use async_trait::async_trait;
    use std::fs;
    use std::path::Path;
    use tempfile::tempdir;

    struct SlowModelLoader {
        delay_ms: u64,
    }

    impl SlowModelLoader {
        fn new(delay_ms: u64) -> Self {
            Self { delay_ms }
        }
    }

    #[async_trait]
    impl ModelLoader for SlowModelLoader {
        async fn load(&self, config: &ModelConfig) -> Result<Arc<dyn LoadedModel>, VecboostError> {
            tokio::time::sleep(std::time::Duration::from_millis(self.delay_ms)).await;

            let model: Arc<dyn LoadedModel> = Arc::new(CandleModel {
                path: config.model_path.clone(),
                name: config.name.clone(),
            });

            Ok(model)
        }

        async fn get_model_path(&self, config: &ModelConfig) -> Result<PathBuf, VecboostError> {
            Ok(config.model_path.clone())
        }

        async fn is_model_cached(&self, _config: &ModelConfig) -> bool {
            true
        }
    }

    struct CandleModel {
        path: PathBuf,
        name: String,
    }

    impl LoadedModel for CandleModel {
        fn name(&self) -> &str {
            &self.name
        }

        fn path(&self) -> &Path {
            &self.path
        }

        fn engine_type(&self) -> EngineType {
            EngineType::Candle
        }

        fn reload(&self) -> Result<(), VecboostError> {
            Ok(())
        }
    }

    fn create_test_model_file(path: &PathBuf) {
        fs::create_dir_all(path.parent().unwrap()).unwrap();
        fs::write(path, "test model content").unwrap();
    }

    #[tokio::test]
    async fn test_model_manager_creation() {
        let manager = ModelManager::new();
        assert_eq!(manager.count().await, 0);
    }

    #[tokio::test]
    async fn test_model_manager_with_loader() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);
        assert_eq!(manager.count().await, 0);
    }

    #[tokio::test]
    async fn test_model_manager_load_unload() {
        let cache_dir = tempdir().unwrap();
        let model_path = cache_dir.path().join("test-model");
        create_test_model_file(&model_path);

        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let config = ModelConfig {
            name: "test-model".to_string(),
            engine_type: EngineType::Candle,
            model_path,
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        let _model = manager.load(&config).await.unwrap();
        assert_eq!(manager.count().await, 1);
        assert!(manager.is_loaded("test-model").await);

        manager.unload("test-model").await.unwrap();
        assert_eq!(manager.count().await, 0);
        assert!(!manager.is_loaded("test-model").await);
    }

    #[tokio::test]
    async fn test_model_manager_list_loaded() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let config1 = ModelConfig {
            name: "model-1".to_string(),
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("model-1"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        let config2 = ModelConfig {
            name: "model-2".to_string(),
            #[cfg(feature = "onnx")]
            engine_type: EngineType::Onnx,
            #[cfg(not(feature = "onnx"))]
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("model-2"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        fs::create_dir_all(&config1.model_path).unwrap();
        fs::create_dir_all(&config2.model_path).unwrap();

        manager.load(&config1).await.unwrap();
        #[cfg(feature = "onnx")]
        manager.load(&config2).await.unwrap();

        let loaded = manager.list_loaded().await;
        #[cfg(feature = "onnx")]
        {
            assert_eq!(loaded.len(), 2);
            assert!(loaded.contains(&"model-1".to_string()));
            assert!(loaded.contains(&"model-2".to_string()));
        }
        #[cfg(not(feature = "onnx"))]
        {
            assert_eq!(loaded.len(), 1);
            assert!(loaded.contains(&"model-1".to_string()));
        }
    }

    #[tokio::test]
    async fn test_model_manager_stats() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let stats = manager.stats().await;
        assert_eq!(stats.total_models, 0);
        assert_eq!(stats.candle_models, 0);
        assert_eq!(stats.onnx_models, 0);
    }

    #[tokio::test]
    async fn test_model_manager_unload_all() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let config = ModelConfig {
            name: "test-model".to_string(),
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("test-model"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        fs::create_dir_all(&config.model_path).unwrap();
        manager.load(&config).await.unwrap();
        assert_eq!(manager.count().await, 1);

        manager.unload_all().await;
        assert_eq!(manager.count().await, 0);
    }

    #[tokio::test]
    async fn test_model_manager_unload_nonexistent() {
        let manager = ModelManager::new();
        let result = manager.unload("nonexistent").await;
        assert!(result.is_err());
        if let Err(e) = result {
            assert!(e.to_string().contains("not found"));
        }
    }

    #[tokio::test]
    async fn test_model_stats_format_size() {
        let stats = ModelStats {
            total_models: 1,
            candle_models: 1,
            onnx_models: 0,
            total_size_bytes: 1024,
        };

        assert_eq!(stats.format_size(), "1 KB");
    }

    #[tokio::test]
    async fn test_model_manager_with_timeout() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader).with_timeout(1);

        assert_eq!(manager.timeout_duration.as_secs(), 1);
    }

    #[tokio::test]
    async fn test_model_manager_load_timeout_success() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader).with_timeout(30);

        let config = ModelConfig {
            name: "timeout-test-model".to_string(),
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("timeout-test-model"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        fs::create_dir_all(&config.model_path).unwrap();

        let result = manager.load(&config).await;
        assert!(result.is_ok());
        assert_eq!(manager.count().await, 1);
    }

    #[tokio::test]
    async fn test_model_manager_load_reuses_existing() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader).with_timeout(30);

        let config = ModelConfig {
            name: "reuse-test-model".to_string(),
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("reuse-test-model"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        fs::create_dir_all(&config.model_path).unwrap();

        let first = manager.load(&config).await.unwrap();
        let second = manager.load(&config).await.unwrap();

        assert!(Arc::ptr_eq(&first, &second));
        assert_eq!(manager.count().await, 1);
    }

    #[tokio::test]
    async fn test_model_manager_load_timeout_failure() {
        let cache_dir = tempdir().unwrap();
        let slow_loader = Arc::new(SlowModelLoader::new(2000));
        let manager = ModelManager::with_loader(slow_loader).with_timeout(1);

        let config = ModelConfig {
            name: "slow-timeout-test-model".to_string(),
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("slow-timeout-test-model"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        fs::create_dir_all(&config.model_path).unwrap();

        let result = manager.load(&config).await;

        assert!(result.is_err());
        match result {
            Err(e) => {
                let error_msg = e.to_string();
                assert!(
                    error_msg.contains("timed out"),
                    "Expected 'timed out' in error message, got: {}",
                    error_msg
                );
            }
            Ok(_) => panic!("Expected error, but got success"),
        }
        assert_eq!(manager.count().await, 0);
    }

    #[tokio::test]
    async fn test_model_manager_load_success_after_timeout() {
        let cache_dir = tempdir().unwrap();
        let slow_loader = Arc::new(SlowModelLoader::new(100));
        let manager = ModelManager::with_loader(slow_loader).with_timeout(5);

        let config = ModelConfig {
            name: "success-after-timeout-test-model".to_string(),
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("success-after-timeout-test-model"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        fs::create_dir_all(&config.model_path).unwrap();

        let result = manager.load(&config).await;

        assert!(result.is_ok());
        assert_eq!(manager.count().await, 1);
    }

    #[tokio::test]
    async fn test_get_returns_none_for_unknown_model() {
        let manager = ModelManager::new();
        assert!(manager.get("does-not-exist").await.is_none());
    }

    #[tokio::test]
    async fn test_get_returns_loaded_model() {
        let cache_dir = tempdir().unwrap();
        let model_path = cache_dir.path().join("get-model");
        create_test_model_file(&model_path);

        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let config = ModelConfig {
            name: "get-model".to_string(),
            engine_type: EngineType::Candle,
            model_path,
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        let loaded = manager.load(&config).await.unwrap();
        let fetched = manager.get("get-model").await;
        assert!(fetched.is_some());
        assert_eq!(fetched.unwrap().name(), loaded.name());
    }

    #[tokio::test]
    async fn test_is_loaded_returns_false_for_unknown() {
        let manager = ModelManager::new();
        assert!(!manager.is_loaded("unknown").await);
    }

    #[tokio::test]
    async fn test_default_creates_empty_manager() {
        let manager = ModelManager::default();
        assert_eq!(manager.count().await, 0);
        assert!(manager.list_loaded().await.is_empty());
    }

    #[tokio::test]
    async fn test_unload_all_on_empty_manager_is_noop() {
        let manager = ModelManager::new();
        manager.unload_all().await;
        assert_eq!(manager.count().await, 0);
    }

    #[tokio::test]
    async fn test_unload_all_removes_multiple_models() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        for name in ["multi-1", "multi-2", "multi-3"] {
            let model_path = cache_dir.path().join(name);
            create_test_model_file(&model_path);
            let config = ModelConfig {
                name: name.to_string(),
                engine_type: EngineType::Candle,
                model_path,
                tokenizer_path: None,
                device: crate::config::model::DeviceType::Cpu,
                max_batch_size: 32,
                pooling_mode: None,
                expected_dimension: None,
                memory_limit_bytes: None,
                oom_fallback_enabled: false,
                model_sha256: None,
                quantized: false,
            };
            manager.load(&config).await.unwrap();
        }

        assert_eq!(manager.count().await, 3);
        manager.unload_all().await;
        assert_eq!(manager.count().await, 0);
        assert!(manager.list_loaded().await.is_empty());
    }

    #[tokio::test]
    async fn test_reload_existing_model_succeeds() {
        let cache_dir = tempdir().unwrap();
        let model_path = cache_dir.path().join("reload-model");
        create_test_model_file(&model_path);

        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let config = ModelConfig {
            name: "reload-model".to_string(),
            engine_type: EngineType::Candle,
            model_path,
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        let _ = manager.load(&config).await.unwrap();
        assert_eq!(manager.count().await, 1);

        let reloaded = manager.reload("reload-model").await;
        assert!(reloaded.is_ok());
        assert_eq!(manager.count().await, 1);
        assert!(manager.is_loaded("reload-model").await);
    }

    #[tokio::test]
    async fn test_reload_unknown_model_returns_not_found() {
        let manager = ModelManager::new();
        let result = manager.reload("no-such-model").await;
        assert!(result.is_err());
        match result.err().unwrap() {
            VecboostError::NotFound(msg) => {
                assert!(msg.contains("no-such-model"));
            }
            other => panic!("expected NotFound, got {:?}", other),
        }
    }

    struct FailingLoader;

    #[async_trait]
    impl ModelLoader for FailingLoader {
        async fn load(&self, _config: &ModelConfig) -> Result<Arc<dyn LoadedModel>, VecboostError> {
            Err(VecboostError::ModelLoadError(
                "intentional failure".to_string(),
            ))
        }

        async fn get_model_path(&self, config: &ModelConfig) -> Result<PathBuf, VecboostError> {
            Ok(config.model_path.clone())
        }

        async fn is_model_cached(&self, _config: &ModelConfig) -> bool {
            false
        }
    }

    #[tokio::test]
    async fn test_load_with_loader_failure_returns_model_load_error() {
        let loader = Arc::new(FailingLoader);
        let manager = ModelManager::with_loader(loader);

        let cache_dir = tempdir().unwrap();
        let config = ModelConfig {
            name: "fail-model".to_string(),
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("fail-model"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        let result = manager.load(&config).await;
        assert!(result.is_err());
        match result.err().unwrap() {
            VecboostError::ModelLoadError(msg) => {
                assert!(msg.contains("fail-model"));
                assert!(msg.contains("intentional failure"));
            }
            other => panic!("expected ModelLoadError, got {:?}", other),
        }
        assert_eq!(manager.count().await, 0);
    }

    #[tokio::test]
    async fn test_load_default_uses_default_config() {
        let cache_dir = tempdir().unwrap();
        let model_path = cache_dir.path().join("default-test-model");
        create_test_model_file(&model_path);

        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let mut manager = ModelManager::with_loader(loader);

        let config = ModelConfig {
            name: "default-test-model".to_string(),
            engine_type: EngineType::Candle,
            model_path,
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };
        manager.set_default_config(config);

        let result = manager.load_default().await;
        assert!(result.is_ok());
        assert_eq!(manager.count().await, 1);
        assert!(manager.is_loaded("default-test-model").await);
    }

    #[tokio::test]
    async fn test_stats_counts_candle_models() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        for name in ["stat-1", "stat-2"] {
            let model_path = cache_dir.path().join(name);
            create_test_model_file(&model_path);
            let config = ModelConfig {
                name: name.to_string(),
                engine_type: EngineType::Candle,
                model_path,
                tokenizer_path: None,
                device: crate::config::model::DeviceType::Cpu,
                max_batch_size: 32,
                pooling_mode: None,
                expected_dimension: None,
                memory_limit_bytes: None,
                oom_fallback_enabled: false,
                model_sha256: None,
                quantized: false,
            };
            manager.load(&config).await.unwrap();
        }

        let stats = manager.stats().await;
        assert_eq!(stats.total_models, 2);
        assert_eq!(stats.candle_models, 2);
        assert_eq!(stats.onnx_models, 0);
        assert!(stats.total_size_bytes > 0);
    }

    #[tokio::test]
    async fn test_concurrent_loads_distinct_models() {
        let cache_dir = tempdir().unwrap();
        let cache_root = cache_dir.path().to_path_buf();

        let mut handles = Vec::new();
        let loader = Arc::new(LocalModelLoader::new(cache_root.clone()));
        let manager = std::sync::Arc::new(ModelManager::with_loader(loader));

        for i in 0..5 {
            let mgr = std::sync::Arc::clone(&manager);
            let root = cache_root.clone();
            handles.push(tokio::spawn(async move {
                let name = format!("conc-{}", i);
                let model_path = root.join(&name);
                fs::create_dir_all(model_path.parent().unwrap()).unwrap();
                fs::write(&model_path, "content").unwrap();

                let config = ModelConfig {
                    name: name.clone(),
                    engine_type: EngineType::Candle,
                    model_path,
                    tokenizer_path: None,
                    device: crate::config::model::DeviceType::Cpu,
                    max_batch_size: 32,
                    pooling_mode: None,
                    expected_dimension: None,
                    memory_limit_bytes: None,
                    oom_fallback_enabled: false,
                    model_sha256: None,
                    quantized: false,
                };
                mgr.load(&config).await.unwrap();
            }));
        }

        for handle in handles {
            handle.await.unwrap();
        }

        assert_eq!(manager.count().await, 5);
        let loaded = manager.list_loaded().await;
        for i in 0..5 {
            assert!(loaded.contains(&format!("conc-{}", i)));
        }
    }

    #[test]
    fn test_model_stats_total_size_mb() {
        let stats = ModelStats {
            total_models: 1,
            candle_models: 1,
            onnx_models: 0,
            total_size_bytes: 2 * 1024 * 1024,
        };
        assert_eq!(stats.total_size_mb(), 2.0);
    }

    #[test]
    fn test_model_stats_format_size_bytes() {
        let stats = ModelStats {
            total_models: 0,
            candle_models: 0,
            onnx_models: 0,
            total_size_bytes: 512,
        };
        assert_eq!(stats.format_size(), "512 B");
    }

    #[test]
    fn test_model_stats_format_size_kb() {
        let stats = ModelStats {
            total_models: 0,
            candle_models: 0,
            onnx_models: 0,
            total_size_bytes: 2048,
        };
        assert_eq!(stats.format_size(), "2 KB");
    }

    #[test]
    fn test_model_stats_format_size_mb() {
        let stats = ModelStats {
            total_models: 0,
            candle_models: 0,
            onnx_models: 0,
            total_size_bytes: 1024 * 1024,
        };
        assert!(stats.format_size().ends_with("MB"));
    }

    #[test]
    fn test_model_stats_format_size_gb() {
        let stats = ModelStats {
            total_models: 0,
            candle_models: 0,
            onnx_models: 0,
            total_size_bytes: 1024 * 1024 * 1024,
        };
        assert!(stats.format_size().ends_with("GB"));
    }

    #[tokio::test]
    async fn test_load_already_loaded_returns_same_instance() {
        let cache_dir = tempdir().unwrap();
        let model_path = cache_dir.path().join("reuse-model");
        create_test_model_file(&model_path);

        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let config = ModelConfig {
            name: "reuse-model".to_string(),
            engine_type: EngineType::Candle,
            model_path,
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        let first = manager.load(&config).await.unwrap();
        let second = manager.load(&config).await.unwrap();
        assert!(Arc::ptr_eq(&first, &second));
        assert_eq!(manager.count().await, 1);
    }

    #[tokio::test]
    async fn test_unload_then_load_recreates_model() {
        let cache_dir = tempdir().unwrap();
        let model_path = cache_dir.path().join("recreate-model");
        create_test_model_file(&model_path);

        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let config = ModelConfig {
            name: "recreate-model".to_string(),
            engine_type: EngineType::Candle,
            model_path,
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };

        let _first = manager.load(&config).await.unwrap();
        manager.unload("recreate-model").await.unwrap();
        assert_eq!(manager.count().await, 0);

        let second = manager.load(&config).await;
        assert!(second.is_ok());
        assert_eq!(manager.count().await, 1);
        assert!(manager.is_loaded("recreate-model").await);
    }

    #[tokio::test]
    async fn test_slow_model_loader_get_model_path_and_cached() {
        let loader = SlowModelLoader::new(10);
        let config = ModelConfig {
            name: "slow-model".to_string(),
            engine_type: EngineType::Candle,
            model_path: PathBuf::from("/slow/path"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };
        let path = loader.get_model_path(&config).await.unwrap();
        assert_eq!(path, PathBuf::from("/slow/path"));
        assert!(loader.is_model_cached(&config).await);
    }

    #[tokio::test]
    async fn test_slow_model_loader_load_succeeds() {
        let cache_dir = tempdir().unwrap();
        let loader = SlowModelLoader::new(10);
        let config = ModelConfig {
            name: "slow-load".to_string(),
            engine_type: EngineType::Candle,
            model_path: cache_dir.path().join("slow-load"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };
        let model = loader.load(&config).await.unwrap();
        assert_eq!(model.name(), "slow-load");
        assert_eq!(model.engine_type(), EngineType::Candle);
        assert!(model.reload().is_ok());
    }

    #[tokio::test]
    async fn test_failing_loader_get_model_path_and_cached() {
        let loader = FailingLoader;
        let config = ModelConfig {
            name: "fail-model".to_string(),
            engine_type: EngineType::Candle,
            model_path: PathBuf::from("/fail/path"),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };
        let path = loader.get_model_path(&config).await.unwrap();
        assert_eq!(path, PathBuf::from("/fail/path"));
        assert!(!loader.is_model_cached(&config).await);
    }

    #[tokio::test]
    async fn test_unload_all_on_manager_with_single_model_logs() {
        let cache_dir = tempdir().unwrap();
        let loader = Arc::new(LocalModelLoader::new(cache_dir.path().to_path_buf()));
        let manager = ModelManager::with_loader(loader);

        let model_path = cache_dir.path().join("unload-single");
        create_test_model_file(&model_path);
        let config = ModelConfig {
            name: "unload-single".to_string(),
            engine_type: EngineType::Candle,
            model_path,
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        };
        manager.load(&config).await.unwrap();
        assert_eq!(manager.count().await, 1);
        manager.unload_all().await;
        assert_eq!(manager.count().await, 0);
    }

    // ===== LFRU 驻留管理测试 =====

    fn residency_config_for(name: &str, dir: &std::path::Path) -> ModelConfig {
        ModelConfig {
            name: name.to_string(),
            engine_type: EngineType::Candle,
            model_path: dir.join(name),
            tokenizer_path: None,
            device: crate::config::model::DeviceType::Cpu,
            max_batch_size: 32,
            pooling_mode: None,
            expected_dimension: None,
            memory_limit_bytes: None,
            oom_fallback_enabled: false,
            model_sha256: None,
            quantized: false,
        }
    }

    #[tokio::test]
    async fn test_residency_evicts_lowest_score() {
        let dir = tempdir().unwrap();
        let loader = Arc::new(SlowModelLoader::new(0));
        let manager = ModelManager::with_loader(loader).with_residency(2, None);
        // A 冷(heat 10)、B 热(heat 50);C 以 warmstart heat 100 进入。
        for name in ["model-a", "model-b"] {
            create_test_model_file(&dir.path().join(name));
        }
        manager
            .load(&residency_config_for("model-a", dir.path()))
            .await
            .unwrap();
        manager
            .load(&residency_config_for("model-b", dir.path()))
            .await
            .unwrap();
        manager.seed_heat("model-a", 10).await;
        manager.seed_heat("model-b", 50).await;
        manager.seed_heat("model-c", 100).await;
        create_test_model_file(&dir.path().join("model-c"));
        manager
            .load(&residency_config_for("model-c", dir.path()))
            .await
            .unwrap();
        // 恰好一次驱逐:最低分 A 出局,B/C 驻留。
        assert_eq!(manager.count().await, 2);
        assert!(
            !manager.is_loaded("model-a").await,
            "应驱逐 score 最低者 model-a"
        );
        assert!(manager.is_loaded("model-b").await);
        assert!(manager.is_loaded("model-c").await);
    }

    #[tokio::test]
    async fn test_residency_hysteresis_blocks_eviction() {
        // margin = victim/4 + 4(整数运算)。victim heat=100 时 margin=29,
        // 候选 heat=71 恰好放行(71+29>=100),70 则阻断(70+29<100)。
        for (cand_heat, expect_evict) in [(71u32, true), (70u32, false)] {
            let dir = tempdir().unwrap();
            let loader = Arc::new(SlowModelLoader::new(0));
            let manager = ModelManager::with_loader(loader).with_residency(1, None);
            create_test_model_file(&dir.path().join("hot"));
            manager
                .load(&residency_config_for("hot", dir.path()))
                .await
                .unwrap();
            manager.seed_heat("hot", 100).await;
            manager.seed_heat("cand", cand_heat).await;
            create_test_model_file(&dir.path().join("cand"));
            manager
                .load(&residency_config_for("cand", dir.path()))
                .await
                .unwrap();
            assert!(
                manager.is_loaded("cand").await,
                "候选 heat={} 应载入",
                cand_heat
            );
            assert_eq!(
                manager.is_loaded("hot").await,
                !expect_evict,
                "候选 heat={} 时 hot 应{}被驱逐",
                cand_heat,
                if expect_evict { "" } else { "" }
            );
        }
    }

    #[tokio::test]
    async fn test_heat_saturates_no_wrap() {
        let dir = tempdir().unwrap();
        let loader = Arc::new(SlowModelLoader::new(0));
        let manager = ModelManager::with_loader(loader).with_residency(8, None);
        create_test_model_file(&dir.path().join("sat"));
        manager
            .load(&residency_config_for("sat", dir.path()))
            .await
            .unwrap();
        // u32 饱和不回绕。
        manager.seed_heat("sat", u32::MAX).await;
        manager
            .load(&residency_config_for("sat", dir.path()))
            .await
            .unwrap();
        assert_eq!(
            manager.heat_of("sat").await,
            u32::MAX,
            "heat 到顶不回绕不 panic"
        );
    }

    #[tokio::test]
    async fn test_inflight_model_skipped_for_eviction() {
        let dir = tempdir().unwrap();
        let loader = Arc::new(SlowModelLoader::new(0));
        let manager = ModelManager::with_loader(loader).with_residency(1, None);
        create_test_model_file(&dir.path().join("sat"));
        manager
            .load(&residency_config_for("sat", dir.path()))
            .await
            .unwrap();
        manager.seed_heat("sat", u32::MAX).await;
        // 持有两份外部引用 → strong_count = 3 > 2(in-flight)。
        let held1 = manager.get("sat").await.unwrap();
        let held2 = manager.get("sat").await.unwrap();
        assert!(Arc::strong_count(&held1) > 2);
        // 新人 heat 同样 MAX:迟滞放行,唯一阻断只能是 in-flight 跳过。
        manager.seed_heat("newbie", u32::MAX).await;
        create_test_model_file(&dir.path().join("newbie"));
        manager
            .load(&residency_config_for("newbie", dir.path()))
            .await
            .unwrap();
        assert!(
            manager.is_loaded("sat").await,
            "in-flight 模型本轮不得被驱逐"
        );
        assert!(manager.is_loaded("newbie").await);
        drop(held1);
        drop(held2);
        // 引用释放后再次触发:enforcement 恢复并收敛到上限(仅 c3 存活)。
        manager.seed_heat("c3", u32::MAX).await;
        create_test_model_file(&dir.path().join("c3"));
        manager
            .load(&residency_config_for("c3", dir.path()))
            .await
            .unwrap();
        assert_eq!(manager.count().await, 1, "引用释放后应收敛到 max_models=1");
        assert!(manager.is_loaded("c3").await);
    }

    #[tokio::test]
    async fn test_no_residency_means_no_eviction() {
        let dir = tempdir().unwrap();
        let loader = Arc::new(SlowModelLoader::new(0));
        let manager = ModelManager::with_loader(loader);
        for name in ["m1", "m2", "m3"] {
            create_test_model_file(&dir.path().join(name));
            manager
                .load(&residency_config_for(name, dir.path()))
                .await
                .unwrap();
        }
        assert_eq!(manager.count().await, 3, "默认不限制,无驱逐");
    }

    #[tokio::test]
    async fn test_heat_persist_roundtrip_via_manager() {
        let dir = tempdir().unwrap();
        let loader = Arc::new(SlowModelLoader::new(0));
        let manager = ModelManager::with_loader(loader);
        create_test_model_file(&dir.path().join("hm"));
        manager
            .load(&residency_config_for("hm", dir.path()))
            .await
            .unwrap();
        manager.seed_heat("hm", 33).await;
        let path = dir.path().join("model_heat.json");
        manager.save_heat_file(&path).await.unwrap();
        // 新 manager 经文件 warmstart 恢复。
        let loader2 = Arc::new(SlowModelLoader::new(0));
        let manager2 = ModelManager::with_loader(loader2);
        manager2.load_heat_file(&path).await;
        assert_eq!(manager2.heat_of("hm").await, 33);
    }
}