vck-common 0.0.1

Shared types, JVCK metadata format, and crypto primitives for VolumeCrypt-Kit
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
// SPDX-FileCopyrightText: 2026 JC-Lab <joseph@jc-lab.net>
//
// SPDX-License-Identifier: Apache-2.0

//! Volume-backed JVCK metadata store implementing `EncryptedOffsetStore`.
//!
//! Works for both OS and data volumes by reading/writing the header/footer
//! replica regions through a `SectorIo`.
//!
//! Replica layout (all sizes are sector-aligned; `metadata_size` must be a
//! multiple of `sector_size`):
//! - Header replica `i`: region starts at `i * replica_sectors`; the 512-byte
//!   Metadata block occupies the **first** sector of the region (`[Metadata][vendor]`).
//! - Footer replica `j`: occupies the last `use_footer` regions of the volume;
//!   the Metadata block occupies the **last** sector of the region
//!   (`[vendor][Metadata]`), so the final footer replica's Metadata is the very
//!   last sector of the volume and can be found by a single read.

use alloc::boxed::Box;
use alloc::vec::Vec;
use core::sync::atomic::{AtomicU16, AtomicU64, Ordering};

use zeroize::Zeroizing;

use crate::{
    jvck::{
        codec::{JvckCbcCodec, MetadataCodec, ReplicaCtx, Unsealed},
        metadata::{self, JvckHeader, JvckSecrets, METADATA_BLOCK_SIZE},
        options::JvckMetadataOptions,
    },
    store::{EncryptedOffsetStore, SectorIo},
    types::{EncryptedOffset, VolumeState},
    VckError, VckResult,
};

/// Computed geometry of the encryption target region.
#[derive(Debug, Clone, Copy)]
pub struct Geometry {
    /// First absolute LBA of the data (encryptable) region.
    pub offset_sector: u64,
    /// Number of sectors to encrypt (metadata regions excluded).
    pub data_sectors: u64,
    pub sector_size: u32,
}

pub struct JvckMetadataStore<S: SectorIo> {
    io: S,
    options: JvckMetadataOptions,
    vmk: Zeroizing<Vec<u8>>,
    geometry: Geometry,
    volume_sectors: u64,
    /// Immutable plaintext template (counts, sizes, volume id). Re-encoded with
    /// `secrets` + the live `encrypted_offset` on every metadata write.
    header: JvckHeader,
    /// FVEK material, kept (zeroize-on-drop) so `store()` can re-encode the
    /// EncryptedMetadata blob when `encrypted_offset` advances.
    secrets: JvckSecrets,
    /// Current on-disk encrypted_offset (data-region relative). Written together
    /// with `state` on every metadata re-encode.
    offset: AtomicU64,
    /// Current on-disk sweep direction (`VolumeState` as u16).
    state: AtomicU16,
    /// EncryptedMetadata seal/unseal policy. Supplied by the caller (the sample
    /// chooses it, the default being `JvckCbcCodec`), so the store hardcodes no
    /// metadata cipher.
    codec: Box<dyn MetadataCodec>,
}

/// Sectors-per-replica for the given layout.
///
/// The 512-byte Metadata block always occupies exactly one sector, and the
/// vendor-specific area is `floor((metadata_size - sector_size) / sector_size)`
/// sectors. The total is therefore `floor(metadata_size / sector_size)`: when
/// `metadata_size` is not a multiple of `sector_size` the remainder is dropped
/// so a replica region never exceeds `metadata_size`.
fn replica_sectors(metadata_size: u32, sector_size: u32) -> u64 {
    (metadata_size / sector_size) as u64
}

/// Absolute LBAs of every replica's Metadata block (header first, then footer).
fn metadata_sector_lbas(
    volume_sectors: u64,
    replica_sectors: u64,
    use_header: u32,
    use_footer: u32,
) -> Vec<u64> {
    let mut lbas = Vec::with_capacity((use_header + use_footer) as usize);
    // Header: Metadata in the first sector of each region.
    for i in 0..use_header as u64 {
        lbas.push(i * replica_sectors);
    }
    // Footer: Metadata in the last sector of each region.
    let footer_start = volume_sectors - use_footer as u64 * replica_sectors;
    for j in 0..use_footer as u64 {
        let region_start = footer_start + j * replica_sectors;
        lbas.push(region_start + replica_sectors - 1);
    }
    lbas
}

/// Base LBA of `replica_index`'s vendor-specific data region (header replicas
/// first, then footer). `None` if the index is out of range.
fn vendor_data_base_lba_at(
    volume_sectors: u64,
    rs: u64,
    use_header: u32,
    use_footer: u32,
    replica_index: usize,
) -> Option<u64> {
    let uh = use_header as usize;
    let uf = use_footer as usize;
    if replica_index < uh {
        // Header replica: Metadata is the first sector; vendor data follows.
        Some(replica_index as u64 * rs + 1)
    } else if replica_index < uh + uf {
        let j = (replica_index - uh) as u64;
        let footer_start = volume_sectors - uf as u64 * rs;
        // Footer replica: Metadata is the last sector; vendor data precedes it.
        Some(footer_start + j * rs)
    } else {
        None
    }
}

fn compute_geometry(
    sector_size: u32,
    volume_sectors: u64,
    options: &JvckMetadataOptions,
) -> VckResult<Geometry> {
    if (sector_size as usize) < METADATA_BLOCK_SIZE {
        return Err(VckError::Unsupported("sector size smaller than 512"));
    }
    // `metadata_size` need not be a multiple of `sector_size`: the replica region
    // is floored to whole sectors (`floor(metadata_size / sector_size)`), so it
    // never exceeds `metadata_size`. It must still hold at least the one Metadata
    // sector.
    let rs = replica_sectors(options.metadata_size, sector_size);
    if rs == 0 {
        return Err(VckError::ValidationFailed(
            "metadata_size smaller than one sector",
        ));
    }
    let consumed = (options.use_header + options.use_footer) as u64 * rs;
    if consumed >= volume_sectors {
        return Err(VckError::ValidationFailed(
            "volume too small to hold metadata replicas",
        ));
    }
    Ok(Geometry {
        offset_sector: options.use_header as u64 * rs,
        data_sectors: volume_sectors - consumed,
        sector_size,
    })
}

fn read_block<S: SectorIo>(
    io: &S,
    sector_size: u32,
    lba: u64,
) -> VckResult<[u8; METADATA_BLOCK_SIZE]> {
    let mut sector = alloc::vec![0u8; sector_size as usize];
    io.read_sectors(lba, &mut sector)?;
    let mut block = [0u8; METADATA_BLOCK_SIZE];
    block.copy_from_slice(&sector[..METADATA_BLOCK_SIZE]);
    Ok(block)
}

fn write_block<S: SectorIo>(
    io: &S,
    sector_size: u32,
    lba: u64,
    block: &[u8; METADATA_BLOCK_SIZE],
) -> VckResult<()> {
    // The Metadata block sits alone in its sector (layout is sector-aligned),
    // so zeroing the remainder of the sector cannot clobber vendor data.
    let mut sector = alloc::vec![0u8; sector_size as usize];
    sector[..METADATA_BLOCK_SIZE].copy_from_slice(block);
    io.write_sectors(lba, &sector)
}

impl<S: SectorIo> JvckMetadataStore<S> {
    /// Open an existing JVCK volume with the **default JVCK suite** codec
    /// ([`JvckCbcCodec`]) in one shot: `JvckMetadataReader::open` then
    /// `into_store`. Convenience for the common case; a caller that selects a
    /// vendor codec (from the header / vendor data) uses [`JvckMetadataReader`] +
    /// [`into_store`](JvckMetadataReader::into_store) directly.
    pub fn open(io: S, vmk: &[u8]) -> VckResult<Self> {
        JvckMetadataReader::open(io)?.into_store(vmk, |ctx| {
            let codec: Box<dyn MetadataCodec> = Box::new(JvckCbcCodec);
            let unsealed = codec.unseal(ctx, vmk)?;
            Ok((codec, unsealed))
        })
    }

    /// Initialize a brand new JVCK volume (first-time encryption): lay out the
    /// replicas per `options` and write seed metadata (`encrypted_offset = 0`).
    ///
    /// The kernel driver no longer creates metadata (the user-space SDK does
    /// that over an extended-DASD volume handle); this remains the in-tree
    /// reference encoder used by host tests and tooling.
    pub fn create(
        io: S,
        vmk: &[u8],
        options: JvckMetadataOptions,
        fvek_key1: [u8; 32],
        fvek_key2: [u8; 32],
        volume_id: [u8; 16],
        codec: Box<dyn MetadataCodec>,
    ) -> VckResult<Self> {
        options.validate()?;
        let sector_size = io.sector_size();
        let volume_sectors = io.total_sectors();
        let geometry = compute_geometry(sector_size, volume_sectors, &options)?;

        let header = JvckHeader {
            vendor_id: 0,
            metadata_version: 1,
            vendor_version: 0,
            metadata_size: options.metadata_size,
            sector_size,
            header_replica_count: options.use_header as u8,
            footer_replica_count: options.use_footer as u8,
            volume_id,
            vendor_reserved: [0u8; metadata::VENDOR_RESERVED_SIZE],
        };
        let secrets = JvckSecrets {
            fvek_key1,
            fvek_key2,
        };

        let store = Self {
            io,
            options,
            vmk: Zeroizing::new(vmk.to_vec()),
            geometry,
            volume_sectors,
            header,
            secrets,
            offset: AtomicU64::new(0),
            state: AtomicU16::new(VolumeState::Encrypt.as_u16()),
            codec,
        };
        store.write_all_replicas()?;
        Ok(store)
    }

    /// Read every replica and return the most up-to-date `encrypted_offset`.
    ///
    /// Uses the cached layout (the on-disk layout is immutable once written, so
    /// re-bootstrapping per call is unnecessary). Recovery policy: among valid
    /// replicas, pick the largest `encrypted_offset`. Only the offset is
    /// recovered; the FVEK decrypted along the way is zeroized immediately.
    pub fn load_offset(&self) -> VckResult<u64> {
        let sector_size = self.geometry.sector_size;
        let rs = replica_sectors(self.options.metadata_size, sector_size);
        let lbas = metadata_sector_lbas(
            self.volume_sectors,
            rs,
            self.options.use_header,
            self.options.use_footer,
        );

        let mut best: Option<u64> = None;
        for (idx, lba) in lbas.iter().enumerate() {
            let block = match read_block(&self.io, sector_size, *lba) {
                Ok(block) => block,
                Err(_) => continue,
            };
            // Only hand CRC-valid replicas to the codec.
            if metadata::verify_crc(&block).is_err() {
                continue;
            }
            let vendor_base = vendor_data_base_lba_at(
                self.volume_sectors,
                rs,
                self.options.use_header,
                self.options.use_footer,
                idx,
            )
            .unwrap_or(0);
            let ctx = ReplicaCtx::new(
                &self.header,
                block,
                &self.io as &dyn SectorIo,
                vendor_base,
                rs.saturating_sub(1),
                sector_size,
                idx,
            );
            if let Ok(offset) = self.codec.read_offset(&ctx, &self.vmk) {
                best = Some(best.map_or(offset, |b| b.max(offset)));
            }
        }
        best.ok_or(VckError::NotFound("no valid JVCK metadata replica"))
    }

    /// FVEK key halves recovered at open/create. Kept zeroize-on-drop in the
    /// store; copied out here only to build the volume cipher.
    pub fn fvek_keys(&self) -> (&[u8; 32], &[u8; 32]) {
        (&self.secrets.fvek_key1, &self.secrets.fvek_key2)
    }

    /// The plaintext Volume ID (HKDF salt) from the metadata header.
    pub fn volume_id(&self) -> [u8; 16] {
        self.header.volume_id
    }

    fn write_all_replicas(&self) -> VckResult<()> {
        // Fresh per-write salt so the AES-CBC key/IV are never reused across
        // re-encodes (the EncryptedMetadata plaintext is mostly constant).
        let mut salt = [0u8; metadata::SALT_SIZE];
        crate::rng::fill_random(&mut salt)?;
        let encrypted_offset = self.offset.load(Ordering::Relaxed);
        let state = VolumeState::from_u16(self.state.load(Ordering::Relaxed));
        let mut block = [0u8; METADATA_BLOCK_SIZE];
        self.codec.seal(
            &self.header,
            &self.secrets,
            encrypted_offset,
            state,
            &salt,
            &self.vmk,
            &mut block,
        )?;
        let rs = replica_sectors(self.options.metadata_size, self.geometry.sector_size);
        for lba in metadata_sector_lbas(
            self.volume_sectors,
            rs,
            self.options.use_header,
            self.options.use_footer,
        ) {
            write_block(&self.io, self.geometry.sector_size, lba, &block)?;
        }
        Ok(())
    }

    pub fn offset_sector(&self) -> u64 {
        self.geometry.offset_sector
    }

    pub fn data_sector_count(&self) -> u64 {
        self.geometry.data_sectors
    }

    pub fn sector_size(&self) -> u32 {
        self.geometry.sector_size
    }

    pub fn footer_replica_count(&self) -> u32 {
        self.options.use_footer
    }

    pub fn metadata_size(&self) -> u32 {
        self.options.metadata_size
    }

    /// The parsed plaintext header (vendor_id, vendor_version, vendor_reserved,
    /// volume_id, sizes). A vendor suite selects its crypto from this *whole*
    /// metadata, not just `vendor_id`.
    pub fn header(&self) -> &JvckHeader {
        &self.header
    }

    // --- Vendor specific DATA region (outside the 512-byte Metadata block) ---
    //
    // Each replica region is `replica_sectors` long and holds the Metadata block
    // in exactly one sector (first for header replicas, last for footer
    // replicas). The remaining `replica_sectors - 1` sectors are free for vendor
    // use; the API below reads/writes them at sector granularity.

    /// Number of replica regions (header replicas first, then footer replicas).
    pub fn replica_count(&self) -> usize {
        (self.options.use_header + self.options.use_footer) as usize
    }

    /// Vendor-data sectors available per replica (replica region minus the one
    /// Metadata sector).
    pub fn vendor_data_sector_count(&self) -> u64 {
        replica_sectors(self.options.metadata_size, self.geometry.sector_size).saturating_sub(1)
    }

    /// Absolute base LBA of `replica_index`'s vendor-data region.
    fn vendor_data_base_lba(&self, replica_index: usize) -> Option<u64> {
        let rs = replica_sectors(self.options.metadata_size, self.geometry.sector_size);
        vendor_data_base_lba_at(
            self.volume_sectors,
            rs,
            self.options.use_header,
            self.options.use_footer,
            replica_index,
        )
    }

    fn vendor_data_lba_checked(
        &self,
        replica_index: usize,
        rel_sector: u64,
        len: usize,
    ) -> VckResult<u64> {
        let ss = self.geometry.sector_size as usize;
        if ss == 0 || len == 0 || !len.is_multiple_of(ss) {
            return Err(VckError::InvalidData(
                "vendor data buffer must be a non-zero multiple of the sector size",
            ));
        }
        let nsec = (len / ss) as u64;
        let base = self
            .vendor_data_base_lba(replica_index)
            .ok_or(VckError::NotFound("vendor data replica index out of range"))?;
        let count = self.vendor_data_sector_count();
        if rel_sector.checked_add(nsec).is_none_or(|end| end > count) {
            return Err(VckError::ValidationFailed(
                "vendor data range exceeds the replica region",
            ));
        }
        Ok(base + rel_sector)
    }

    /// Read `buf` (a whole number of sectors) from replica `replica_index`'s
    /// vendor-data region, starting at vendor-relative sector `rel_sector`.
    pub fn read_vendor_data(
        &self,
        replica_index: usize,
        rel_sector: u64,
        buf: &mut [u8],
    ) -> VckResult<()> {
        let lba = self.vendor_data_lba_checked(replica_index, rel_sector, buf.len())?;
        self.io.read_sectors(lba, buf)
    }

    /// Write `buf` (a whole number of sectors) into replica `replica_index`'s
    /// vendor-data region, starting at vendor-relative sector `rel_sector`.
    pub fn write_vendor_data(
        &self,
        replica_index: usize,
        rel_sector: u64,
        buf: &[u8],
    ) -> VckResult<()> {
        let lba = self.vendor_data_lba_checked(replica_index, rel_sector, buf.len())?;
        self.io.write_sectors(lba, buf)
    }

    /// Write `buf` into the vendor-data region of **every** replica (same
    /// `rel_sector` in each), so the vendor data stays consistent across replicas
    /// — mirroring how the Metadata block is mirrored to all replicas.
    ///
    /// Sequential and best-effort: a mid-loop failure leaves earlier replicas
    /// updated and returns the error (the caller may retry; the layout is fixed
    /// so a retry targets the same LBAs). Validates the buffer against the first
    /// replica before writing any.
    pub fn write_vendor_data_all(&self, rel_sector: u64, buf: &[u8]) -> VckResult<()> {
        // Validate once up front (range/alignment is identical for every replica).
        self.vendor_data_lba_checked(0, rel_sector, buf.len())?;
        for replica_index in 0..self.replica_count() {
            self.write_vendor_data(replica_index, rel_sector, buf)?;
        }
        Ok(())
    }

    /// The 192-byte Vendor Specific Reserved area from the parsed header.
    pub fn vendor_reserved(&self) -> &[u8; metadata::VENDOR_RESERVED_SIZE] {
        &self.header.vendor_reserved
    }

    /// Set the Vendor Specific Reserved area and re-seal **all** replicas, so
    /// every replica's Metadata block carries the new value (the reserved area is
    /// inside the sealed 512-byte block, mirrored to all replicas on each write).
    ///
    /// Takes `&mut self`: call while the store is uniquely owned (e.g. in
    /// `on_attach` before wrapping it in `Arc<dyn EncryptedOffsetStore>`), since
    /// the trait-object form used at runtime cannot reach this concrete method.
    pub fn set_vendor_reserved(
        &mut self,
        vendor_reserved: &[u8; metadata::VENDOR_RESERVED_SIZE],
    ) -> VckResult<()> {
        self.header.vendor_reserved = *vendor_reserved;
        self.write_all_replicas()
    }
}

impl<S: SectorIo> EncryptedOffsetStore for JvckMetadataStore<S>
where
    S: Send + Sync + 'static,
{
    fn load(&self) -> VckResult<EncryptedOffset> {
        Ok(EncryptedOffset {
            sector: self.load_offset()?,
            total_sectors: self.geometry.data_sectors,
        })
    }

    fn store(&self, offset: &EncryptedOffset) -> VckResult<()> {
        self.offset.store(offset.sector, Ordering::Relaxed);
        self.write_all_replicas()
    }

    fn flush(&self) -> VckResult<()> {
        // Writes go straight through the synchronous SectorIo; nothing to flush.
        Ok(())
    }

    fn load_state(&self) -> VckResult<VolumeState> {
        Ok(VolumeState::from_u16(self.state.load(Ordering::Relaxed)))
    }

    fn store_state(&self, state: VolumeState) -> VckResult<()> {
        // Persist the direction immediately (re-encode all replicas with the
        // current offset + new state) so a reboot resumes the right direction.
        self.state.store(state.as_u16(), Ordering::Relaxed);
        self.write_all_replicas()
    }
}

/// Phase-A opener for a JVCK volume.
///
/// `open` reads only the **plaintext** header (signature, layout, vendor fields)
/// — no metadata cipher, no VMK — so the caller can inspect it (and the
/// vendor-specific data via [`read_vendor_data`](Self::read_vendor_data)) and
/// pick a [`MetadataCodec`]. [`into_store`](Self::into_store) then iterates the
/// CRC-valid replicas, building a [`ReplicaCtx`] for each and calling
/// `codec.unseal` until one succeeds — the sample decrypts with its own
/// algorithm there. This is the two-phase form of [`JvckMetadataStore::open`].
pub struct JvckMetadataReader<S: SectorIo> {
    io: S,
    options: JvckMetadataOptions,
    geometry: Geometry,
    volume_sectors: u64,
    header: JvckHeader,
}

impl<S: SectorIo> JvckMetadataReader<S> {
    /// Phase A: locate a CRC-valid replica (last sector first — always a footer
    /// Metadata block — then sector 0 for header layouts) and parse its plaintext
    /// header + layout. No decryption; the VMK is not needed here. Returns
    /// `NotFound` if no JVCK signature is present anywhere.
    pub fn open(io: S) -> VckResult<Self> {
        let sector_size = io.sector_size();
        if (sector_size as usize) < METADATA_BLOCK_SIZE {
            return Err(VckError::Unsupported("sector size smaller than 512"));
        }
        let volume_sectors = io.total_sectors();
        if volume_sectors == 0 {
            return Err(VckError::NotFound("empty volume"));
        }
        for lba in [volume_sectors - 1, 0] {
            let block = read_block(&io, sector_size, lba)?;
            if metadata::verify_crc(&block).is_err() {
                continue;
            }
            let header = JvckHeader::parse(&block)?;
            let options = JvckMetadataOptions {
                use_header: header.header_replica_count as u32,
                use_footer: header.footer_replica_count as u32,
                metadata_size: header.metadata_size,
            };
            let geometry = compute_geometry(sector_size, volume_sectors, &options)?;
            return Ok(Self {
                io,
                options,
                geometry,
                volume_sectors,
                header,
            });
        }
        Err(VckError::NotFound("no JVCK metadata present"))
    }

    /// The parsed plaintext header (vendor_id, vendor_version, vendor_reserved,
    /// volume_id, sizes). Use it to select the [`MetadataCodec`].
    pub fn header(&self) -> &JvckHeader {
        &self.header
    }

    /// Computed encryption-target geometry (offset/data sectors).
    pub fn geometry(&self) -> Geometry {
        self.geometry
    }

    /// Number of replica regions (header replicas first, then footer replicas).
    pub fn replica_count(&self) -> usize {
        (self.options.use_header + self.options.use_footer) as usize
    }

    /// Build a [`ReplicaCtx`] for `replica_index` (header replicas first, then
    /// footer). Reads that replica's Metadata block and verifies its CRC; the
    /// returned ctx exposes the header, the raw block / encrypted blob, and that
    /// replica's vendor-specific data (via [`ReplicaCtx::read_vendor_data`]). A
    /// vendor uses this to inspect / unseal a specific replica directly, instead
    /// of relying on the `into_store` iteration order. Errors if the index is out
    /// of range or the replica's CRC is invalid.
    pub fn replica_ctx(&self, replica_index: usize) -> VckResult<ReplicaCtx<'_>> {
        let sector_size = self.geometry.sector_size;
        let rs = replica_sectors(self.options.metadata_size, sector_size);
        let lbas = metadata_sector_lbas(
            self.volume_sectors,
            rs,
            self.options.use_header,
            self.options.use_footer,
        );
        let lba = *lbas
            .get(replica_index)
            .ok_or(VckError::NotFound("replica index out of range"))?;
        let block = read_block(&self.io, sector_size, lba)?;
        metadata::verify_crc(&block)?;
        let vendor_base = vendor_data_base_lba_at(
            self.volume_sectors,
            rs,
            self.options.use_header,
            self.options.use_footer,
            replica_index,
        )
        .unwrap_or(0);
        Ok(ReplicaCtx::new(
            &self.header,
            block,
            &self.io as &dyn SectorIo,
            vendor_base,
            rs.saturating_sub(1),
            sector_size,
            replica_index,
        ))
    }

    /// Read `buf` (a whole number of sectors) from replica `replica_index`'s
    /// vendor-specific data region, before decryption — to inform codec
    /// selection. `rel_sector` is vendor-region relative.
    pub fn read_vendor_data(
        &self,
        replica_index: usize,
        rel_sector: u64,
        buf: &mut [u8],
    ) -> VckResult<()> {
        let sector_size = self.geometry.sector_size;
        let ss = sector_size as usize;
        if ss == 0 || buf.is_empty() || !buf.len().is_multiple_of(ss) {
            return Err(VckError::InvalidData(
                "vendor data buffer must be a non-zero multiple of the sector size",
            ));
        }
        let rs = replica_sectors(self.options.metadata_size, sector_size);
        let base = vendor_data_base_lba_at(
            self.volume_sectors,
            rs,
            self.options.use_header,
            self.options.use_footer,
            replica_index,
        )
        .ok_or(VckError::NotFound("vendor data replica index out of range"))?;
        let nsec = (buf.len() / ss) as u64;
        if rel_sector
            .checked_add(nsec)
            .is_none_or(|end| end > rs.saturating_sub(1))
        {
            return Err(VckError::ValidationFailed(
                "vendor data range exceeds the replica region",
            ));
        }
        self.io.read_sectors(base + rel_sector, buf)
    }

    /// Phase B: iterate the CRC-valid replicas, calling `select` on each (with a
    /// [`ReplicaCtx`]) until it returns `Ok` — that replica is adopted. `select`
    /// chooses the metadata codec AND unseals, returning **both** as
    /// `(codec, unsealed)`: a CRC-valid replica may still carry bad encrypted data
    /// (e.g. a stale `encrypted_offset`) or bad vendor-specific data, so the
    /// caller returns `Err` to skip it and try the next replica. The default
    /// selector is `|ctx| { let c = Box::new(JvckCbcCodec); let u = c.unseal(ctx,
    /// vmk)?; Ok((c, u)) }`.
    ///
    /// The store retains the returned codec for re-seal (`store`/`store_state`)
    /// and recovery (`load_offset`). Returns the last `select` error if none
    /// succeed.
    pub fn into_store<F>(self, vmk: &[u8], mut select: F) -> VckResult<JvckMetadataStore<S>>
    where
        F: FnMut(&ReplicaCtx<'_>) -> VckResult<(Box<dyn MetadataCodec>, Unsealed)>,
    {
        let sector_size = self.geometry.sector_size;
        let rs = replica_sectors(self.options.metadata_size, sector_size);
        let lbas = metadata_sector_lbas(
            self.volume_sectors,
            rs,
            self.options.use_header,
            self.options.use_footer,
        );

        let mut chosen: Option<(Box<dyn MetadataCodec>, Unsealed)> = None;
        let mut last_err: Option<VckError> = None;
        for (idx, lba) in lbas.iter().enumerate() {
            let block = match read_block(&self.io, sector_size, *lba) {
                Ok(b) => b,
                Err(e) => {
                    last_err = Some(e);
                    continue;
                }
            };
            // Only hand CRC-valid replicas to the selector; it does the rest
            // (choose codec + unseal + any per-replica / vendor-data validation).
            if metadata::verify_crc(&block).is_err() {
                continue;
            }
            let vendor_base = vendor_data_base_lba_at(
                self.volume_sectors,
                rs,
                self.options.use_header,
                self.options.use_footer,
                idx,
            )
            .unwrap_or(0);
            let ctx = ReplicaCtx::new(
                &self.header,
                block,
                &self.io as &dyn SectorIo,
                vendor_base,
                rs.saturating_sub(1),
                sector_size,
                idx,
            );
            match select(&ctx) {
                Ok(pair) => {
                    chosen = Some(pair);
                    break;
                }
                Err(e) => {
                    last_err = Some(e);
                    continue;
                }
            }
        }
        let (codec, unsealed) = chosen.ok_or_else(|| {
            last_err.unwrap_or(VckError::NotFound(
                "no JVCK metadata replica could be unsealed",
            ))
        })?;

        let store = JvckMetadataStore {
            io: self.io,
            options: self.options,
            vmk: Zeroizing::new(vmk.to_vec()),
            geometry: self.geometry,
            volume_sectors: self.volume_sectors,
            header: self.header,
            secrets: unsealed.secrets,
            offset: AtomicU64::new(0),
            state: AtomicU16::new(unsealed.state.as_u16()),
            codec,
        };
        // Track the recovered (max) offset so a later store_state() re-encodes
        // with the correct progress, not 0.
        let recovered = store.load_offset().unwrap_or(unsealed.encrypted_offset);
        store.offset.store(recovered, Ordering::Relaxed);
        Ok(store)
    }
}

// --- UEFI Block IO backed SectorIo + convenience constructor ---
//
// Provided here (under the `uefi` feature) because the loader only needs plain
// sector reads of the target volume to recover FVEK/encrypted_offset; the
// Block IO *hooking* engine lives in `lib/loader`.
#[cfg(feature = "uefi")]
pub use uefi_io::{locate_block_io_volume, open_volume_footer_uefi, UefiBlockIoVolume};

#[cfg(feature = "uefi")]
mod uefi_io {
    use super::*;
    use crate::types::{guid_from_windows_bytes, Guid};
    use alloc::format;
    use uefi::boot::{self, open_protocol_exclusive, SearchType};
    use uefi::proto::media::block::BlockIO;
    use uefi::proto::media::partition::PartitionInfo;

    /// `SectorIo` backed by `EFI_BLOCK_IO_PROTOCOL` for a located volume.
    ///
    /// Read-only: the loader only needs to read footer metadata replicas to
    /// recover the FVEK / encrypted_offset (the transparent decryption hook
    /// lives in `lib/loader`).
    pub struct UefiBlockIoVolume {
        block_io: uefi::boot::ScopedProtocol<BlockIO>,
        media_id: u32,
        sector_size: u32,
        total_sectors: u64,
    }

    // The loader is single-threaded; `ScopedProtocol` holds raw firmware
    // pointers that are only ever touched from the boot thread. `SectorIo`
    // requires `Send + Sync`, so assert it here.
    unsafe impl Send for UefiBlockIoVolume {}
    unsafe impl Sync for UefiBlockIoVolume {}

    impl SectorIo for UefiBlockIoVolume {
        fn sector_size(&self) -> u32 {
            self.sector_size
        }
        fn total_sectors(&self) -> u64 {
            self.total_sectors
        }
        fn read_sectors(&self, lba: u64, buf: &mut [u8]) -> VckResult<()> {
            self.block_io
                .read_blocks(self.media_id, lba, buf)
                .map_err(|e| VckError::Io(format!("BlockIO.ReadBlocks(lba={lba}) failed: {e:?}")))
        }
        fn write_sectors(&self, _lba: u64, _buf: &[u8]) -> VckResult<()> {
            Err(VckError::Unsupported("loader Block IO volume is read-only"))
        }
    }

    /// Locate the volume by GPT unique `partition_guid` and open its Block IO as
    /// a read-only [`SectorIo`]. Does NOT decrypt anything — the caller (a sample
    /// loader) reads/decrypts the metadata itself (e.g. via
    /// [`JvckMetadataStore::open`]), choosing its own metadata cipher.
    pub fn locate_block_io_volume(partition_guid: Guid) -> VckResult<UefiBlockIoVolume> {
        let handles = boot::locate_handle_buffer(SearchType::from_proto::<BlockIO>())
            .map_err(|e| VckError::Io(format!("locate BlockIO handles failed: {e:?}")))?;

        for &handle in handles.iter() {
            // Match by GPT unique partition GUID via the PartitionInfo protocol.
            // PartitionInfo is produced on the partition (logical) handles only.
            let matched = match open_protocol_exclusive::<PartitionInfo>(handle) {
                Ok(pinfo) => match pinfo.gpt_partition_entry() {
                    Some(gpt) => {
                        guid_from_windows_bytes(gpt.unique_partition_guid.to_bytes())
                            == partition_guid
                    }
                    None => false,
                },
                Err(_) => false,
            };
            if !matched {
                continue;
            }

            let block_io = open_protocol_exclusive::<BlockIO>(handle)
                .map_err(|e| VckError::Io(format!("open BlockIO failed: {e:?}")))?;
            let media = block_io.media();
            if !media.is_media_present() {
                return Err(VckError::Io(
                    "matched partition has no media present".into(),
                ));
            }
            let sector_size = media.block_size();
            let media_id = media.media_id();
            let total_sectors = media.last_block().saturating_add(1);
            return Ok(UefiBlockIoVolume {
                block_io,
                media_id,
                sector_size,
                total_sectors,
            });
        }

        Err(VckError::NotFound(
            "no Block IO partition matched the target GUID",
        ))
    }

    /// Locate the volume by GPT unique `partition_guid`, open its Block IO, and
    /// build a store from the footer metadata using `vmk` and the **default JVCK
    /// codec**. Convenience wrapper over [`locate_block_io_volume`] +
    /// [`JvckMetadataStore::open`]. A loader selecting a vendor codec uses
    /// `locate_block_io_volume` + `JvckMetadataReader` directly.
    pub fn open_volume_footer_uefi(
        partition_guid: Guid,
        vmk: &[u8],
    ) -> VckResult<JvckMetadataStore<UefiBlockIoVolume>> {
        let io = locate_block_io_volume(partition_guid)?;
        JvckMetadataStore::open(io, vmk)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::jvck::codec::default_codec;
    use std::sync::Mutex;

    /// Deterministic randomness source for tests (no real entropy needed).
    struct TestRng;
    impl crate::rng::RandomSource for TestRng {
        fn fill(&self, buf: &mut [u8]) -> VckResult<()> {
            for (i, b) in buf.iter_mut().enumerate() {
                *b = (i as u8).wrapping_mul(7).wrapping_add(1);
            }
            Ok(())
        }
    }
    static TEST_RNG: TestRng = TestRng;
    /// Install the test RNG (idempotent — `set_random_source` is call-once).
    fn ensure_rng() {
        crate::rng::set_random_source(&TEST_RNG);
    }

    /// In-memory `SectorIo` for tests.
    struct MemVolume {
        sector_size: u32,
        data: Mutex<Vec<u8>>,
    }

    impl MemVolume {
        fn new(sector_size: u32, sectors: u64) -> Self {
            Self {
                sector_size,
                data: Mutex::new(alloc::vec![0u8; (sectors * sector_size as u64) as usize]),
            }
        }
    }

    impl SectorIo for MemVolume {
        fn sector_size(&self) -> u32 {
            self.sector_size
        }
        fn total_sectors(&self) -> u64 {
            self.data.lock().unwrap().len() as u64 / self.sector_size as u64
        }
        fn read_sectors(&self, lba: u64, buf: &mut [u8]) -> VckResult<()> {
            let data = self.data.lock().unwrap();
            let start = (lba * self.sector_size as u64) as usize;
            buf.copy_from_slice(&data[start..start + buf.len()]);
            Ok(())
        }
        fn write_sectors(&self, lba: u64, buf: &[u8]) -> VckResult<()> {
            let mut data = self.data.lock().unwrap();
            let start = (lba * self.sector_size as u64) as usize;
            data[start..start + buf.len()].copy_from_slice(buf);
            Ok(())
        }
    }

    const VMK: &[u8] = b"unit-test-volume-master-key";
    const MD_SIZE: u32 = 128 * 1024; // 256 sectors @ 512

    fn footer_only_options() -> JvckMetadataOptions {
        JvckMetadataOptions {
            use_header: 0,
            use_footer: 2,
            metadata_size: MD_SIZE,
        }
    }

    #[test]
    fn create_then_load_geometry() {
        ensure_rng();
        // 1024 sectors: 2 footer replicas (512) + 512 data sectors.
        let io = MemVolume::new(512, 1024);
        let store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [1; 32],
            [2; 32],
            [9; 16],
            default_codec(),
        )
        .unwrap();
        assert_eq!(store.offset_sector(), 0);
        assert_eq!(store.data_sector_count(), 512);
        assert_eq!(store.footer_replica_count(), 2);

        assert_eq!(store.load_offset().unwrap(), 0);
        assert_eq!(store.fvek_keys().0, &[1u8; 32]);
        assert_eq!(store.volume_id(), [9; 16]);
    }

    #[test]
    fn header_plus_footer_geometry() {
        ensure_rng();
        // use_header=1, use_footer=2 -> 3*256 = 768 reserved, 1280 volume.
        let io = MemVolume::new(512, 1280);
        let opts = JvckMetadataOptions {
            use_header: 1,
            use_footer: 2,
            metadata_size: MD_SIZE,
        };
        let store =
            JvckMetadataStore::create(io, VMK, opts, [3; 32], [4; 32], [7; 16], default_codec())
                .unwrap();
        assert_eq!(store.offset_sector(), 256);
        assert_eq!(store.data_sector_count(), 512);
    }

    #[test]
    fn store_then_load_offset_roundtrip() {
        ensure_rng();
        let io = MemVolume::new(512, 1024);
        let store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [1; 32],
            [2; 32],
            [9; 16],
            default_codec(),
        )
        .unwrap();

        store
            .store(&EncryptedOffset {
                sector: 1234,
                total_sectors: 512,
            })
            .unwrap();
        let loaded = store.load().unwrap();
        assert_eq!(loaded.sector, 1234);
        assert_eq!(loaded.total_sectors, 512);
    }

    #[test]
    fn reopen_finds_existing_metadata() {
        ensure_rng();
        let io = MemVolume::new(512, 1024);
        let store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [5; 32],
            [6; 32],
            [8; 16],
            default_codec(),
        )
        .unwrap();
        store
            .store(&EncryptedOffset {
                sector: 777,
                total_sectors: 512,
            })
            .unwrap();
        // Move the backing volume out and reopen via JvckMetadataStore::open.
        let io = store.io;
        let reopened = JvckMetadataStore::open(io, VMK).unwrap();
        assert_eq!(reopened.offset_sector(), 0);
        assert_eq!(reopened.data_sector_count(), 512);
        assert_eq!(reopened.load_offset().unwrap(), 777);
    }

    #[test]
    fn recovery_picks_largest_offset() {
        ensure_rng();
        let io = MemVolume::new(512, 1024);
        let store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [1; 32],
            [2; 32],
            [9; 16],
            default_codec(),
        )
        .unwrap();
        // All replicas at 500.
        store
            .store(&EncryptedOffset {
                sector: 500,
                total_sectors: 512,
            })
            .unwrap();

        // Corrupt the last footer replica (very last sector) to a stale 300.
        let mut block = [0u8; METADATA_BLOCK_SIZE];
        store
            .header
            .encode(
                &store.secrets,
                300,
                VolumeState::Encrypt,
                &[0u8; metadata::SALT_SIZE],
                VMK,
                &mut block,
            )
            .unwrap();
        write_block(&store.io, 512, store.volume_sectors - 1, &block).unwrap();

        // load_offset must still report 500 (the other valid replica).
        assert_eq!(store.load_offset().unwrap(), 500);
    }

    #[test]
    fn state_persists_across_reopen() {
        ensure_rng();
        let io = MemVolume::new(512, 1024);
        let store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [1; 32],
            [2; 32],
            [9; 16],
            default_codec(),
        )
        .unwrap();
        // Fresh volumes default to Encrypt.
        assert_eq!(store.load_state().unwrap(), VolumeState::Encrypt);

        store
            .store(&EncryptedOffset {
                sector: 100,
                total_sectors: 512,
            })
            .unwrap();
        store.store_state(VolumeState::Decrypt).unwrap();

        // Reopen: both the offset and the persisted direction survive.
        let io = store.io;
        let reopened = JvckMetadataStore::open(io, VMK).unwrap();
        assert_eq!(reopened.load_state().unwrap(), VolumeState::Decrypt);
        assert_eq!(reopened.load_offset().unwrap(), 100);
    }

    #[test]
    fn vendor_data_read_write_roundtrip() {
        ensure_rng();
        // footer-only: 2 replicas of 256 sectors -> 255 vendor-data sectors each.
        let io = MemVolume::new(512, 1024);
        let store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [1; 32],
            [2; 32],
            [9; 16],
            default_codec(),
        )
        .unwrap();
        assert_eq!(store.replica_count(), 2);
        assert_eq!(store.vendor_data_sector_count(), 255);

        let data = alloc::vec![0xCDu8; 512];
        store.write_vendor_data(0, 3, &data).unwrap();
        let mut back = alloc::vec![0u8; 512];
        store.read_vendor_data(0, 3, &mut back).unwrap();
        assert_eq!(back, data);

        // Out-of-range sector / replica index are rejected.
        assert!(store.write_vendor_data(0, 255, &data).is_err());
        assert!(store.write_vendor_data(2, 0, &data).is_err());
        // Non-sector-aligned length is rejected.
        assert!(store.read_vendor_data(0, 0, &mut [0u8; 100]).is_err());

        // Vendor-data writes must not clobber the Metadata sector.
        assert_eq!(store.load_offset().unwrap(), 0);
    }

    #[test]
    fn write_vendor_data_all_mirrors_every_replica() {
        ensure_rng();
        let io = MemVolume::new(512, 1024);
        let store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [1; 32],
            [2; 32],
            [9; 16],
            default_codec(),
        )
        .unwrap();
        assert_eq!(store.replica_count(), 2);

        let data = alloc::vec![0x5Au8; 1024]; // 2 sectors
        store.write_vendor_data_all(7, &data).unwrap();

        // Every replica's vendor region carries the same bytes.
        for replica in 0..store.replica_count() {
            let mut back = alloc::vec![0u8; 1024];
            store.read_vendor_data(replica, 7, &mut back).unwrap();
            assert_eq!(back, data, "replica {replica} vendor data mismatch");
        }
        // Validation still applies (out-of-range rejected before any write).
        assert!(store.write_vendor_data_all(255, &data).is_err());
        // Metadata is intact.
        assert_eq!(store.load_offset().unwrap(), 0);
    }

    #[test]
    fn set_vendor_reserved_persists_to_all_replicas() {
        ensure_rng();
        let io = MemVolume::new(512, 1024);
        let mut store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [1; 32],
            [2; 32],
            [9; 16],
            default_codec(),
        )
        .unwrap();
        assert_eq!(
            store.vendor_reserved(),
            &[0u8; metadata::VENDOR_RESERVED_SIZE]
        );

        let vr = [0xABu8; metadata::VENDOR_RESERVED_SIZE];
        store.set_vendor_reserved(&vr).unwrap();
        assert_eq!(store.vendor_reserved(), &vr);

        // Reopen and confirm every replica's header carries the new reserved area.
        let io = store.io;
        let reader = JvckMetadataReader::open(io).unwrap();
        assert_eq!(reader.header().vendor_reserved, vr);
        for replica in 0..reader.replica_count() {
            let ctx = reader.replica_ctx(replica).unwrap();
            assert_eq!(ctx.header().vendor_reserved, vr, "replica {replica}");
        }
    }

    #[test]
    fn reader_replica_ctx_exposes_block_and_vendor_data() {
        ensure_rng();
        let io = MemVolume::new(512, 1024);
        let store = JvckMetadataStore::create(
            io,
            VMK,
            footer_only_options(),
            [1; 32],
            [2; 32],
            [9; 16],
            default_codec(),
        )
        .unwrap();
        let marker = alloc::vec![0xE7u8; 512];
        store.write_vendor_data_all(0, &marker).unwrap();

        let io = store.io;
        let reader = JvckMetadataReader::open(io).unwrap();
        assert_eq!(reader.replica_count(), 2);

        // A specific replica's ctx: CRC-valid block + JVCK signature + its vendor data.
        let ctx = reader.replica_ctx(1).unwrap();
        assert_eq!(ctx.replica_index(), 1);
        assert_eq!(&ctx.block()[..4], b"JVCK");
        assert_eq!(
            ctx.encrypted_metadata().len(),
            metadata::ENCRYPTED_METADATA_SIZE
        );
        let mut vd = alloc::vec![0u8; 512];
        ctx.read_vendor_data(0, &mut vd).unwrap();
        assert_eq!(vd, marker);

        // Out-of-range index is rejected.
        assert!(reader.replica_ctx(2).is_err());
    }

    #[test]
    fn open_empty_volume_fails() {
        let io = MemVolume::new(512, 1024);
        assert!(matches!(
            JvckMetadataStore::open(io, VMK),
            Err(VckError::NotFound(_))
        ));
    }

    #[test]
    fn metadata_size_not_multiple_of_sector_is_floored() {
        ensure_rng();
        // 4096-byte sectors with a metadata_size that is NOT a multiple of the
        // sector size: 128 KiB + 100 bytes. The replica region floors to
        // floor(131172 / 4096) = 32 sectors (the trailing 100 bytes are dropped).
        let sector_size = 4096u32;
        let md_size = 128 * 1024 + 100;
        let opts = JvckMetadataOptions {
            use_header: 0,
            use_footer: 2,
            metadata_size: md_size,
        };
        let expected_rs = (md_size / sector_size) as u64; // 32
        assert_eq!(expected_rs, 32);

        // 2 footer replicas (64 sectors) + 64 data sectors.
        let io = MemVolume::new(sector_size, 128);
        let store =
            JvckMetadataStore::create(io, VMK, opts, [1; 32], [2; 32], [9; 16], default_codec())
                .unwrap();
        assert_eq!(store.data_sector_count(), 128 - 2 * expected_rs);
        assert_eq!(store.sector_size(), sector_size);

        // The footer Metadata is the last sector and round-trips through reopen.
        store
            .store(&EncryptedOffset {
                sector: 7,
                total_sectors: store.data_sector_count(),
            })
            .unwrap();
        let reopened = JvckMetadataStore::open(store.io, VMK).unwrap();
        assert_eq!(reopened.metadata_size(), md_size);
        assert_eq!(reopened.load_offset().unwrap(), 7);
    }
}