variable-core 0.1.4

Parser, lexer, AST, and validation for the Variable feature flag DSL
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
use std::collections::BTreeMap;

use crate::ast::{Feature, StructDef, StructField, Value, VarFile, VarType, Variable};
use crate::lexer::{Span, SpannedToken, Token};

#[derive(Debug, Clone, PartialEq)]
pub struct ParseError {
    pub message: String,
    pub span: Span,
}

struct Parser {
    tokens: Vec<SpannedToken>,
    pos: usize,
}

impl Parser {
    fn new(tokens: Vec<SpannedToken>) -> Self {
        Self { tokens, pos: 0 }
    }

    fn peek(&self) -> Option<&SpannedToken> {
        self.tokens.get(self.pos)
    }

    fn advance(&mut self) -> Option<&SpannedToken> {
        let token = self.tokens.get(self.pos);
        if token.is_some() {
            self.pos += 1;
        }
        token
    }

    fn expect(&mut self, expected: &Token) -> Result<&SpannedToken, ParseError> {
        match self.peek() {
            Some(t) if &t.token == expected => {
                self.pos += 1;
                Ok(&self.tokens[self.pos - 1])
            }
            Some(t) => Err(ParseError {
                message: format!("expected {:?}, found {:?}", expected, t.token),
                span: t.span.clone(),
            }),
            None => Err(ParseError {
                message: format!("expected {:?}, found end of input", expected),
                span: self.eof_span(),
            }),
        }
    }

    fn eof_span(&self) -> Span {
        if let Some(last) = self.tokens.last() {
            Span {
                offset: last.span.offset + 1,
                line: last.span.line,
                column: last.span.column + 1,
            }
        } else {
            Span {
                offset: 0,
                line: 1,
                column: 1,
            }
        }
    }

    fn current_span(&self) -> Span {
        match self.peek() {
            Some(t) => t.span.clone(),
            None => self.eof_span(),
        }
    }

    fn parse_file(&mut self) -> Result<VarFile, ParseError> {
        let mut structs = Vec::new();
        let mut features = Vec::new();
        while self.peek().is_some() {
            // Peek past the ID and colon to determine if this is a Struct or Feature
            let keyword = self.peek_declaration_keyword()?;
            match keyword {
                Token::Struct => structs.push(self.parse_struct_def()?),
                Token::Feature => features.push(self.parse_feature()?),
                _ => {
                    return Err(ParseError {
                        message: format!("expected Feature or Struct keyword, found {:?}", keyword),
                        span: self.current_span(),
                    });
                }
            }
        }
        Ok(VarFile { structs, features })
    }

    /// Peek ahead past the `ID :` prefix to see whether the next declaration
    /// is a Feature or Struct, without consuming any tokens.
    fn peek_declaration_keyword(&self) -> Result<Token, ParseError> {
        // tokens[pos] should be the numeric ID
        // tokens[pos+1] should be ':'
        // tokens[pos+2] should be Feature or Struct
        let keyword_pos = self.pos + 2;
        match self.tokens.get(keyword_pos) {
            Some(t) => Ok(t.token.clone()),
            None => Err(ParseError {
                message: "expected Feature or Struct declaration, found end of input".to_string(),
                span: self.eof_span(),
            }),
        }
    }

    fn parse_scoped_id(&mut self, scope: &str) -> Result<u32, ParseError> {
        let (raw_id, span) = match self.advance() {
            Some(SpannedToken {
                token: Token::NumberLit(n),
                span,
            }) => (*n, span.clone()),
            Some(t) => {
                return Err(ParseError {
                    message: format!("expected {} id, found {:?}", scope, t.token),
                    span: t.span.clone(),
                });
            }
            None => {
                return Err(ParseError {
                    message: format!("expected {} id, found end of input", scope),
                    span: self.eof_span(),
                });
            }
        };

        if raw_id.fract() != 0.0 || raw_id < 0.0 || raw_id > u32::MAX as f64 {
            return Err(ParseError {
                message: format!("expected {} id to be a u32, found {}", scope, raw_id),
                span,
            });
        }

        self.expect(&Token::Colon)?;

        Ok(raw_id as u32)
    }

    fn parse_struct_def(&mut self) -> Result<StructDef, ParseError> {
        let span = self.current_span();
        let id = self.parse_scoped_id("struct")?;
        self.expect(&Token::Struct)?;

        let name = match self.advance() {
            Some(SpannedToken {
                token: Token::Ident(name),
                ..
            }) => name.clone(),
            Some(t) => {
                return Err(ParseError {
                    message: format!("expected struct name, found {:?}", t.token),
                    span: t.span.clone(),
                });
            }
            None => {
                return Err(ParseError {
                    message: "expected struct name, found end of input".to_string(),
                    span: self.eof_span(),
                });
            }
        };

        self.expect(&Token::Equals)?;
        self.expect(&Token::LBrace)?;

        let mut fields = Vec::new();
        while self.peek().is_some_and(|t| t.token != Token::RBrace) {
            fields.push(self.parse_struct_field()?);
        }

        self.expect(&Token::RBrace)?;

        Ok(StructDef {
            id,
            name,
            fields,
            span,
        })
    }

    fn parse_struct_field(&mut self) -> Result<StructField, ParseError> {
        let span = self.current_span();
        let id = self.parse_scoped_id("field")?;
        let name = match self.advance() {
            Some(SpannedToken {
                token: Token::Ident(name),
                ..
            }) => name.clone(),
            Some(t) => {
                return Err(ParseError {
                    message: format!("expected field name, found {:?}", t.token),
                    span: t.span.clone(),
                });
            }
            None => {
                return Err(ParseError {
                    message: "expected field name, found end of input".to_string(),
                    span: self.eof_span(),
                });
            }
        };

        // Struct fields can only be primitive types
        let field_type = match self.advance() {
            Some(SpannedToken {
                token: Token::BooleanType,
                ..
            }) => VarType::Boolean,
            Some(SpannedToken {
                token: Token::IntegerType,
                ..
            }) => VarType::Integer,
            Some(SpannedToken {
                token: Token::FloatType,
                ..
            }) => VarType::Float,
            Some(SpannedToken {
                token: Token::StringType,
                ..
            }) => VarType::String,
            Some(t) => {
                return Err(ParseError {
                    message: format!(
                        "expected field type (Boolean, Integer, Float, or String), found {:?}",
                        t.token
                    ),
                    span: t.span.clone(),
                });
            }
            None => {
                return Err(ParseError {
                    message: "expected field type, found end of input".to_string(),
                    span: self.eof_span(),
                });
            }
        };

        self.expect(&Token::Equals)?;

        let default = self.parse_primitive_value(&field_type)?;

        Ok(StructField {
            id,
            name,
            field_type,
            default,
            span,
        })
    }

    /// Parse a primitive value (boolean, number, or string literal).
    fn parse_primitive_value(&mut self, var_type: &VarType) -> Result<Value, ParseError> {
        match self.advance() {
            Some(SpannedToken {
                token: Token::BoolLit(b),
                ..
            }) => Ok(Value::Boolean(*b)),
            Some(SpannedToken {
                token: Token::NumberLit(n),
                span,
            }) => {
                let n = *n;
                let span = span.clone();
                match var_type {
                    VarType::Integer => {
                        if n.fract() != 0.0 {
                            return Err(ParseError {
                                message: format!(
                                    "Integer field cannot have fractional default value `{}`",
                                    n
                                ),
                                span,
                            });
                        }
                        Ok(Value::Integer(n as i64))
                    }
                    _ => Ok(Value::Float(n)),
                }
            }
            Some(SpannedToken {
                token: Token::StringLit(s),
                ..
            }) => Ok(Value::String(s.clone())),
            Some(t) => Err(ParseError {
                message: format!("expected default value, found {:?}", t.token),
                span: t.span.clone(),
            }),
            None => Err(ParseError {
                message: "expected default value, found end of input".to_string(),
                span: self.eof_span(),
            }),
        }
    }

    /// Parse a struct literal: `StructName { field = value, ... }` or `StructName {}`
    fn parse_struct_literal(&mut self, struct_name: &str) -> Result<Value, ParseError> {
        // Expect the struct name as an identifier token
        match self.advance() {
            Some(SpannedToken {
                token: Token::Ident(name),
                span,
            }) => {
                if name != struct_name {
                    return Err(ParseError {
                        message: format!(
                            "expected struct literal `{}`, found `{}`",
                            struct_name, name
                        ),
                        span: span.clone(),
                    });
                }
            }
            Some(t) => {
                return Err(ParseError {
                    message: format!(
                        "expected struct literal `{}`, found {:?}",
                        struct_name, t.token
                    ),
                    span: t.span.clone(),
                });
            }
            None => {
                return Err(ParseError {
                    message: format!(
                        "expected struct literal `{}`, found end of input",
                        struct_name
                    ),
                    span: self.eof_span(),
                });
            }
        }

        self.expect(&Token::LBrace)?;

        let mut fields = BTreeMap::new();
        while self.peek().is_some_and(|t| t.token != Token::RBrace) {
            // Parse: field_name = value
            let field_name = match self.advance() {
                Some(SpannedToken {
                    token: Token::Ident(name),
                    ..
                }) => name.clone(),
                Some(t) => {
                    return Err(ParseError {
                        message: format!("expected field name, found {:?}", t.token),
                        span: t.span.clone(),
                    });
                }
                None => {
                    return Err(ParseError {
                        message: "expected field name, found end of input".to_string(),
                        span: self.eof_span(),
                    });
                }
            };

            self.expect(&Token::Equals)?;

            // Parse the value — we don't know the field type here at parse time,
            // so accept any primitive literal. Validation resolves types later.
            let value = match self.advance() {
                Some(SpannedToken {
                    token: Token::BoolLit(b),
                    ..
                }) => Value::Boolean(*b),
                Some(SpannedToken {
                    token: Token::NumberLit(n),
                    ..
                }) => {
                    let n = *n;
                    // Store as integer if it's a whole number, float otherwise
                    if n.fract() == 0.0 && n >= i64::MIN as f64 && n <= i64::MAX as f64 {
                        Value::Integer(n as i64)
                    } else {
                        Value::Float(n)
                    }
                }
                Some(SpannedToken {
                    token: Token::StringLit(s),
                    ..
                }) => Value::String(s.clone()),
                Some(t) => {
                    return Err(ParseError {
                        message: format!(
                            "expected field value in struct literal, found {:?}",
                            t.token
                        ),
                        span: t.span.clone(),
                    });
                }
                None => {
                    return Err(ParseError {
                        message: "expected field value, found end of input".to_string(),
                        span: self.eof_span(),
                    });
                }
            };

            fields.insert(field_name, value);
        }

        self.expect(&Token::RBrace)?;

        Ok(Value::Struct {
            struct_name: struct_name.to_string(),
            fields,
        })
    }

    fn parse_feature(&mut self) -> Result<Feature, ParseError> {
        let span = self.current_span();
        let id = self.parse_scoped_id("feature")?;
        self.expect(&Token::Feature)?;

        let name = match self.advance() {
            Some(SpannedToken {
                token: Token::Ident(name),
                ..
            }) => name.clone(),
            Some(t) => {
                return Err(ParseError {
                    message: format!("expected feature name, found {:?}", t.token),
                    span: t.span.clone(),
                });
            }
            None => {
                return Err(ParseError {
                    message: "expected feature name, found end of input".to_string(),
                    span: self.eof_span(),
                });
            }
        };

        self.expect(&Token::Equals)?;
        self.expect(&Token::LBrace)?;

        let mut variables = Vec::new();
        while self.peek().is_some_and(|t| t.token != Token::RBrace) {
            variables.push(self.parse_variable()?);
        }

        self.expect(&Token::RBrace)?;

        Ok(Feature {
            id,
            name,
            variables,
            span,
        })
    }

    fn parse_variable(&mut self) -> Result<Variable, ParseError> {
        let span = self.current_span();
        let id = self.parse_scoped_id("variable")?;
        let name = match self.advance() {
            Some(SpannedToken {
                token: Token::Ident(name),
                ..
            }) => name.clone(),
            Some(t) => {
                return Err(ParseError {
                    message: format!("expected variable name, found {:?}", t.token),
                    span: t.span.clone(),
                });
            }
            None => {
                return Err(ParseError {
                    message: "expected variable name, found end of input".to_string(),
                    span: self.eof_span(),
                });
            }
        };

        let var_type = match self.advance() {
            Some(SpannedToken {
                token: Token::BooleanType,
                ..
            }) => VarType::Boolean,
            Some(SpannedToken {
                token: Token::IntegerType,
                ..
            }) => VarType::Integer,
            Some(SpannedToken {
                token: Token::FloatType,
                ..
            }) => VarType::Float,
            Some(SpannedToken {
                token: Token::StringType,
                ..
            }) => VarType::String,
            Some(SpannedToken {
                token: Token::Ident(name),
                ..
            }) => VarType::Struct(name.clone()),
            Some(t) => {
                return Err(ParseError {
                    message: format!(
                        "expected type (Boolean, Integer, Float, String, or struct name), found {:?}",
                        t.token
                    ),
                    span: t.span.clone(),
                });
            }
            None => {
                return Err(ParseError {
                    message: "expected type, found end of input".to_string(),
                    span: self.eof_span(),
                });
            }
        };

        self.expect(&Token::Equals)?;

        let default = if let VarType::Struct(ref struct_name) = var_type {
            self.parse_struct_literal(struct_name)?
        } else {
            self.parse_primitive_value(&var_type)?
        };

        Ok(Variable {
            id,
            name,
            var_type,
            default,
            span,
        })
    }
}

pub fn parse(tokens: Vec<SpannedToken>) -> Result<VarFile, ParseError> {
    let mut parser = Parser::new(tokens);
    parser.parse_file()
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::lexer::lex;

    fn parse_source(input: &str) -> Result<VarFile, ParseError> {
        let tokens = lex(input).map_err(|e| ParseError {
            message: e.message,
            span: e.span,
        })?;
        parse(tokens)
    }

    #[test]
    fn parse_single_boolean_variable() {
        let input = r#"1: Feature Flags = {
    1: enabled Boolean = true
}"#;
        let file = parse_source(input).unwrap();
        assert_eq!(file.features.len(), 1);
        assert_eq!(file.features[0].id, 1);
        assert_eq!(file.features[0].name, "Flags");
        assert_eq!(file.features[0].variables.len(), 1);
        assert_eq!(file.features[0].variables[0].id, 1);
        assert_eq!(file.features[0].variables[0].name, "enabled");
        assert_eq!(file.features[0].variables[0].var_type, VarType::Boolean);
        assert_eq!(file.features[0].variables[0].default, Value::Boolean(true));
    }

    #[test]
    fn parse_single_integer_variable() {
        let input = r#"1: Feature Config = {
    1: max_items Integer = 50
}"#;
        let file = parse_source(input).unwrap();
        assert_eq!(file.features[0].variables[0].var_type, VarType::Integer);
        assert_eq!(file.features[0].variables[0].default, Value::Integer(50));
    }

    #[test]
    fn parse_single_float_variable() {
        let input = r#"1: Feature Config = {
    1: ratio Float = 3.14
}"#;
        let file = parse_source(input).unwrap();
        assert_eq!(file.features[0].variables[0].var_type, VarType::Float);
        assert_eq!(file.features[0].variables[0].default, Value::Float(3.14));
    }

    #[test]
    fn parse_float_variable_with_integer_literal() {
        let input = r#"1: Feature Config = {
    1: max_items Float = 50
}"#;
        let file = parse_source(input).unwrap();
        assert_eq!(file.features[0].variables[0].var_type, VarType::Float);
        assert_eq!(file.features[0].variables[0].default, Value::Float(50.0));
    }

    #[test]
    fn parse_single_string_variable() {
        let input = r#"1: Feature Config = {
    1: title String = "Hello"
}"#;
        let file = parse_source(input).unwrap();
        assert_eq!(file.features[0].variables[0].var_type, VarType::String);
        assert_eq!(
            file.features[0].variables[0].default,
            Value::String("Hello".to_string())
        );
    }

    #[test]
    fn parse_multiple_features() {
        let input = r#"1: Feature A = {
    1: x Boolean = true
}

2: Feature B = {
    1: y Integer = 42
}"#;
        let file = parse_source(input).unwrap();
        assert_eq!(file.features.len(), 2);
        assert_eq!(file.features[0].id, 1);
        assert_eq!(file.features[0].name, "A");
        assert_eq!(file.features[1].id, 2);
        assert_eq!(file.features[1].name, "B");
    }

    #[test]
    fn parse_example_var_file() {
        let input = r#"1: Feature Checkout = {
    1: enabled Boolean = true
    2: max_items Integer = 50
    3: header_text String = "Complete your purchase"
}"#;
        let file = parse_source(input).unwrap();
        assert_eq!(file.features.len(), 1);
        let feature = &file.features[0];
        assert_eq!(feature.id, 1);
        assert_eq!(feature.name, "Checkout");
        assert_eq!(feature.variables.len(), 3);
        assert_eq!(feature.variables[0].id, 1);
        assert_eq!(feature.variables[0].name, "enabled");
        assert_eq!(feature.variables[1].id, 2);
        assert_eq!(feature.variables[1].name, "max_items");
        assert_eq!(feature.variables[2].id, 3);
        assert_eq!(feature.variables[2].name, "header_text");
    }

    #[test]
    fn error_missing_lbrace() {
        let input = "1: Feature Checkout = 1: x Boolean = true }";
        let err = parse_source(input).unwrap_err();
        assert!(err.message.contains("expected LBrace"));
    }

    #[test]
    fn error_missing_rbrace() {
        let input = r#"1: Feature Checkout = {
    1: x Boolean = true"#;
        let err = parse_source(input).unwrap_err();
        assert!(err.message.contains("expected RBrace"));
    }

    #[test]
    fn error_missing_default_value() {
        let input = r#"1: Feature Checkout = {
    1: x Boolean =
}"#;
        let err = parse_source(input).unwrap_err();
        assert!(err.message.contains("expected default value"));
    }

    #[test]
    fn error_missing_type() {
        let input = r#"1: Feature Checkout = {
    1: x = true
}"#;
        let err = parse_source(input).unwrap_err();
        assert!(err.message.contains("expected type"));
    }

    #[test]
    fn error_unknown_type_keyword() {
        // "Map" is now parsed as a struct type reference (Ident), so it parses
        // successfully but would fail in validation as an unknown struct type.
        // Here it fails at the default because "5" is not a struct literal.
        let input = r#"1: Feature Checkout = {
    1: x Map = 5
}"#;
        let err = parse_source(input).unwrap_err();
        assert!(err.message.contains("expected struct literal"));
    }

    #[test]
    fn error_integer_with_fractional_value() {
        let input = r#"1: Feature Config = {
    1: ratio Integer = 3.14
}"#;
        let err = parse_source(input).unwrap_err();
        assert!(
            err.message
                .contains("Integer field cannot have fractional default value")
        );
    }

    #[test]
    fn error_spans_point_to_correct_location() {
        let input = "1: Feature Checkout = {\n    1: x = true\n}";
        let err = parse_source(input).unwrap_err();
        // The "=" is the token where we expected a type
        assert_eq!(err.span.line, 2);
    }

    #[test]
    fn parse_struct_definition() {
        let input = r##"1: Struct Theme = {
    1: dark_mode Boolean = false
    2: font_size Integer = 14
    3: primary_color String = "#000000"
}"##;
        let file = parse_source(input).unwrap();
        assert_eq!(file.structs.len(), 1);
        assert_eq!(file.features.len(), 0);
        let s = &file.structs[0];
        assert_eq!(s.id, 1);
        assert_eq!(s.name, "Theme");
        assert_eq!(s.fields.len(), 3);
        assert_eq!(s.fields[0].name, "dark_mode");
        assert_eq!(s.fields[0].field_type, VarType::Boolean);
        assert_eq!(s.fields[0].default, Value::Boolean(false));
        assert_eq!(s.fields[1].name, "font_size");
        assert_eq!(s.fields[1].field_type, VarType::Integer);
        assert_eq!(s.fields[1].default, Value::Integer(14));
        assert_eq!(s.fields[2].name, "primary_color");
        assert_eq!(s.fields[2].field_type, VarType::String);
        assert_eq!(s.fields[2].default, Value::String("#000000".to_string()));
    }

    #[test]
    fn parse_struct_and_feature_together() {
        let input = r#"1: Struct Theme = {
    1: dark_mode Boolean = false
}

1: Feature Dashboard = {
    1: enabled Boolean = true
    2: theme Theme = Theme {}
}"#;
        let file = parse_source(input).unwrap();
        assert_eq!(file.structs.len(), 1);
        assert_eq!(file.features.len(), 1);
        let var = &file.features[0].variables[1];
        assert_eq!(var.name, "theme");
        assert_eq!(var.var_type, VarType::Struct("Theme".to_string()));
        match &var.default {
            Value::Struct {
                struct_name,
                fields,
            } => {
                assert_eq!(struct_name, "Theme");
                assert!(fields.is_empty());
            }
            other => panic!("expected Struct value, got {:?}", other),
        }
    }

    #[test]
    fn parse_struct_literal_with_field_overrides() {
        let input = r#"1: Struct Config = {
    1: retries Integer = 3
    2: verbose Boolean = false
}

1: Feature App = {
    1: config Config = Config { retries = 5 verbose = true }
}"#;
        let file = parse_source(input).unwrap();
        let var = &file.features[0].variables[0];
        match &var.default {
            Value::Struct {
                struct_name,
                fields,
            } => {
                assert_eq!(struct_name, "Config");
                assert_eq!(fields.len(), 2);
                assert_eq!(fields["retries"], Value::Integer(5));
                assert_eq!(fields["verbose"], Value::Boolean(true));
            }
            other => panic!("expected Struct value, got {:?}", other),
        }
    }

    #[test]
    fn error_missing_feature_id() {
        let input = r#"Feature Checkout = {
    1: enabled Boolean = true
}"#;
        let err = parse_source(input).unwrap_err();
        // Without a numeric ID prefix, the parser hits a different error path
        assert!(
            err.message.contains("expected feature id")
                || err.message.contains("expected Feature or Struct")
        );
    }

    #[test]
    fn error_missing_variable_id() {
        let input = r#"1: Feature Checkout = {
    enabled Boolean = true
}"#;
        let err = parse_source(input).unwrap_err();
        assert!(err.message.contains("expected variable id"));
    }

    #[test]
    fn error_non_integer_feature_id() {
        let input = r#"1.5: Feature Checkout = {
    1: enabled Boolean = true
}"#;
        let err = parse_source(input).unwrap_err();
        assert!(err.message.contains("expected feature id to be a u32"));
    }
}