uv 0.11.32

A Python package and project manager
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
use std::collections::{BTreeMap, BTreeSet};
use std::fmt::Write;
use std::path::Path;
use std::str::FromStr;
use std::sync::Arc;

use anyhow::{Context, Result, anyhow, bail};
use uv_cache::{Cache, Refresh};
use uv_client::BaseClientBuilder;
use uv_configuration::{Concurrency, DependencyGroupsWithDefaults, DryRun};
use uv_distribution::{ArchiveMetadata, Metadata};
use uv_distribution_types::Identifier;
use uv_normalize::PackageName;
use uv_pep440::{Operator, Version, VersionSpecifier, VersionSpecifiers};
use uv_pep508::{MarkerTree, Requirement, VerbatimUrl, VersionOrUrl};
use uv_preview::Preview;
use uv_pypi_types::{PyProjectToml, ResolutionMetadata, SupportedEnvironments, VerbatimParsedUrl};
use uv_python::{ConfigDiscovery, PythonDownloads, PythonPreference};
use uv_redacted::DisplaySafeUrl;
use uv_resolver::{MetadataResponse, implicit_constraints_marker};
use uv_settings::PythonInstallMirrors;
use uv_workspace::pyproject::{DependencyType, Source};
use uv_workspace::pyproject_mut::{DependencyTarget, PyProjectTomlMut};
use uv_workspace::{
    DiscoveryOptions, ProjectWorkspace, VirtualProject, WorkspaceCache, WorkspaceErrorKind,
};

use crate::commands::pip::loggers::DefaultResolveLogger;
use crate::commands::project::lock::{LockEvent, LockMode, LockOperation, LockResult};
use crate::commands::project::lock_target::LockTarget;
use crate::commands::project::{ProjectError, ProjectInterpreter, UniversalState, WorkspacePython};
use crate::commands::{ExitStatus, diagnostics};
use crate::printer::Printer;
use crate::settings::ResolverSettings;

/// A dependency requirement selected for upgrading.
struct UpgradableRequirement {
    package: PackageName,
    dependency_type: DependencyType,
    original_text: String,
    requirement: Requirement<VerbatimParsedUrl>,
    effective_marker: MarkerTree,
    resolved_versions: BTreeSet<Version>,
}

/// A selected requirement that cannot apply to the project.
struct SkippedRequirement {
    package: PackageName,
    dependency_type: DependencyType,
    original_text: String,
    display_text: String,
    reason: SkippedReason,
}

enum SkippedReason {
    EnvironmentOrPythonRequirement,
    UndefinedExtra,
}

/// The requirements selected for upgrade and those that cannot apply.
struct RequirementSelection {
    to_upgrade: Vec<UpgradableRequirement>,
    skipped: Vec<SkippedRequirement>,
}

/// An existing requirement and its proposed replacement.
struct RequirementUpdate {
    package: PackageName,
    dependency_type: DependencyType,
    original_text: String,
    existing: Requirement<VerbatimUrl>,
    replacement: Requirement<VerbatimUrl>,
}

pub(crate) async fn upgrade(
    project_dir: &Path,
    package: PackageName,
    install_mirrors: PythonInstallMirrors,
    settings: ResolverSettings,
    client_builder: BaseClientBuilder<'_>,
    python_preference: PythonPreference,
    python_downloads: PythonDownloads,
    concurrency: Concurrency,
    config_discovery: ConfigDiscovery,
    cache: &Cache,
    workspace_cache: &WorkspaceCache,
    printer: Printer,
    preview: Preview,
) -> Result<ExitStatus> {
    let project = match VirtualProject::discover(
        project_dir,
        &DiscoveryOptions::default(),
        cache,
        workspace_cache,
    )
    .await
    {
        Ok(VirtualProject::Project(project)) => project,
        Ok(VirtualProject::NonProject(_)) => {
            bail!("`uv upgrade` requires a project with a `[project]` table")
        }
        Err(err)
            if matches!(
                err.as_ref(),
                WorkspaceErrorKind::MissingPyprojectToml | WorkspaceErrorKind::MissingProject(_)
            ) =>
        {
            bail!("`uv upgrade` requires a project with a `[project]` table");
        }
        Err(err) => return Err(err.into()),
    };
    let RequirementSelection {
        to_upgrade: mut requirements,
        skipped,
    } = select_requirements(&project, &package)?;
    render_skipped_requirements(&skipped, printer)?;
    if requirements.is_empty() {
        return Ok(ExitStatus::Success);
    }
    validate_requirements(&project, &package, &requirements)?;

    // Relax the selected requirements in a temporary manifest so the resolver can select newer
    // versions without changing the user's manifest.
    let relaxed_requirements = requirements
        .iter()
        .map(|selected| {
            Ok(RequirementUpdate {
                package: selected.package.clone(),
                dependency_type: selected.dependency_type.clone(),
                original_text: selected.original_text.clone(),
                existing: into_verbatim_requirement(
                    selected.requirement.clone(),
                    &selected.package,
                )?,
                replacement: into_verbatim_requirement(
                    relax_requirement(selected.requirement.clone()),
                    &selected.package,
                )?,
            })
        })
        .collect::<Result<Vec<_>>>()?;

    let mut pyproject = PyProjectTomlMut::from_toml(
        &project.current_project().pyproject_toml().raw,
        DependencyTarget::PyProjectToml,
    )?;
    // Remove unreachable requirements from the temporary manifest, since URL requirements can be
    // fetched during metadata preparation even when their markers cannot apply.
    for (index, requirement) in skipped.iter().enumerate() {
        if skipped[..index].iter().any(|removed| {
            removed.dependency_type == requirement.dependency_type
                && removed.original_text == requirement.original_text
        }) {
            continue;
        }
        if pyproject
            .remove_dependency_declaration_text(
                &requirement.dependency_type,
                &requirement.original_text,
            )?
            .is_empty()
        {
            bail!(
                "Dependency `{}` was not found in {}",
                requirement.package,
                requirement.dependency_type.toml_table_name()
            );
        }
    }
    apply_requirement_replacements(&mut pyproject, relaxed_requirements.iter())?;
    let pyproject = pyproject.to_string();
    let pyproject = PyProjectToml::from_toml(
        &pyproject,
        project.project_root().join("pyproject.toml").display(),
    )?;
    if pyproject
        .project
        .as_ref()
        .is_some_and(|project| project.version.is_none())
    {
        // TODO: Support dynamic project metadata by building the project before resolution.
        bail!("`uv upgrade` does not support projects with dynamic versions yet");
    }
    let metadata = ResolutionMetadata::parse_pyproject_toml(pyproject, None)?;
    let metadata = Metadata::from_workspace(
        metadata,
        project.project_root(),
        None,
        &settings.index_locations,
        settings.sources.clone(),
        true,
        cache,
        workspace_cache,
        client_builder.credentials_cache(),
    )
    .await?;

    let groups = DependencyGroupsWithDefaults::none();
    let workspace_python = WorkspacePython::from_request(
        None,
        Some(project.workspace()),
        &groups,
        project_dir,
        config_discovery,
    )
    .await?;
    let interpreter = ProjectInterpreter::discover(
        project.workspace(),
        &groups,
        workspace_python,
        &client_builder,
        python_preference,
        python_downloads,
        &install_mirrors,
        false,
        Some(false),
        cache,
        printer,
    )
    .await?
    .into_interpreter();

    let state = UniversalState::default();
    let distribution_id = DisplaySafeUrl::from_file_path(project.project_root())
        .map_err(|()| anyhow!("Project root is not a valid file URL"))?
        .distribution_id();
    state.index().distributions().done(
        distribution_id,
        Arc::new(MetadataResponse::Found(ArchiveMetadata::from(metadata))),
    );

    let refresh = Refresh::from(settings.upgrade.clone());
    let result = match Box::pin(
        LockOperation::new(
            LockMode::DryRun(&interpreter),
            &settings,
            &client_builder,
            &state,
            Box::new(DefaultResolveLogger),
            &concurrency,
            cache,
            workspace_cache,
            printer,
            preview,
        )
        .with_refresh(&refresh)
        .execute(LockTarget::Workspace(project.workspace())),
    )
    .await
    {
        Ok(result) => result,
        Err(ProjectError::Operation(err)) => {
            return diagnostics::OperationDiagnostic::default()
                .report(err)
                .map_or(Ok(ExitStatus::Failure), |err| Err(err.into()));
        }
        Err(err) => return Err(err.into()),
    };

    let lock = result.lock();
    for selected in &requirements {
        if let Some(extra) = selected.requirement.marker.top_level_extra_name()
            && lock
                .conflicts()
                .contains(project.project_name(), extra.as_ref())
        {
            let package = &selected.package;
            bail!(
                "Dependency `{package}` is declared under conflicting extra `{extra}` and cannot be upgraded yet"
            );
        }
    }

    for resolved_package in lock.packages() {
        if !requirements
            .iter()
            .any(|selected| resolved_package.name() == &selected.package)
        {
            continue;
        }
        if resolved_package
            .index(project.workspace().install_path())?
            .is_some()
            && let Some(version) = resolved_package.version()
        {
            // A universal lock can contain versions from disjoint forks, so collect each version
            // only for the declarations that apply to its fork.
            for selected in &mut requirements {
                if resolved_package.name() != &selected.package {
                    continue;
                }
                if resolved_package.is_included_by_marker(selected.effective_marker) {
                    selected.resolved_versions.insert(version.clone());
                }
            }
        }
    }

    let mut updated_requirements = BTreeMap::new();
    for selected in &requirements {
        let Some(specifiers) =
            propose_specifiers(&selected.requirement, &selected.resolved_versions)?
        else {
            continue;
        };

        let existing = into_verbatim_requirement(selected.requirement.clone(), &selected.package)?;
        let mut proposed_requirement = selected.requirement.clone();
        proposed_requirement.version_or_url = Some(VersionOrUrl::VersionSpecifier(specifiers));
        let replacement = into_verbatim_requirement(proposed_requirement, &selected.package)?;
        updated_requirements
            .entry((
                selected.dependency_type.toml_table_name().into_owned(),
                existing.clone(),
                replacement.clone(),
            ))
            .or_insert_with(|| RequirementUpdate {
                package: selected.package.clone(),
                dependency_type: selected.dependency_type.clone(),
                original_text: selected.original_text.clone(),
                existing,
                replacement,
            });
    }

    if !updated_requirements.is_empty() {
        let mut pyproject = PyProjectTomlMut::from_toml(
            &project.current_project().pyproject_toml().raw,
            DependencyTarget::PyProjectToml,
        )?;
        apply_requirement_replacements(&mut pyproject, updated_requirements.values())?;
        let pyproject_path = project.project_root().join("pyproject.toml");
        fs_err::write(pyproject_path, pyproject.to_string())?;
    }

    let event = match &result {
        LockResult::Changed(previous, lock) => {
            LockEvent::detect_changes(previous.as_ref(), lock, DryRun::Enabled)
                .find(|event| event.package() == &package)
        }
        LockResult::Unchanged(_) => None,
    };
    if let Some(event) = event {
        writeln!(printer.stderr(), "{event}")?;
    } else {
        writeln!(printer.stderr(), "No version change for {package}")?;
    }
    for update in updated_requirements.into_values() {
        writeln!(
            printer.stderr(),
            "Updated requirement: `{}` -> `{}`",
            update.original_text,
            update.replacement
        )?;
    }

    Ok(ExitStatus::Success)
}

/// Select the dependency requirements targeted by `uv upgrade`.
fn select_requirements(
    project: &ProjectWorkspace,
    package: &PackageName,
) -> Result<RequirementSelection> {
    if project.workspace().packages().len() != 1 {
        bail!("`uv upgrade` does not support workspaces with multiple members yet");
    }

    let resolution_marker = project_resolution_marker(project)?;
    let dependencies = project
        .current_project()
        .project()
        .dependencies
        .as_deref()
        .unwrap_or_default();
    let pyproject_path = project.project_root().join("pyproject.toml");
    let optional_dependencies = project
        .current_project()
        .project()
        .optional_dependencies
        .as_ref();
    let mut to_upgrade = Vec::new();
    let mut skipped = Vec::new();
    let mut found_matching_name = false;
    for dependency in dependencies {
        let requirement =
            Requirement::<VerbatimParsedUrl>::from_str(dependency).with_context(|| {
                format!(
                    "Failed to parse dependency `{dependency}` from `project.dependencies` in `{}`",
                    pyproject_path.display()
                )
            })?;
        if requirement.name == *package {
            found_matching_name = true;
            let mut effective_marker = requirement.marker;
            effective_marker.and(resolution_marker);
            if effective_marker.is_false() {
                skipped.push(SkippedRequirement {
                    package: package.clone(),
                    dependency_type: DependencyType::Production,
                    original_text: dependency.clone(),
                    display_text: display_requirement(&requirement),
                    reason: SkippedReason::EnvironmentOrPythonRequirement,
                });
                continue;
            }

            effective_marker = effective_marker.simplify_not_extras_with(|extra| {
                optional_dependencies
                    .is_none_or(|optional_dependencies| !optional_dependencies.contains_key(extra))
            });
            if effective_marker.is_false() {
                skipped.push(SkippedRequirement {
                    package: package.clone(),
                    dependency_type: DependencyType::Production,
                    original_text: dependency.clone(),
                    display_text: display_requirement(&requirement),
                    reason: SkippedReason::UndefinedExtra,
                });
                continue;
            }

            to_upgrade.push(UpgradableRequirement {
                package: package.clone(),
                dependency_type: DependencyType::Production,
                original_text: dependency.clone(),
                requirement,
                effective_marker,
                resolved_versions: BTreeSet::new(),
            });
        }
    }

    if !found_matching_name {
        bail!("Dependency `{package}` was not found in `project.dependencies`");
    }

    Ok(RequirementSelection {
        to_upgrade,
        skipped,
    })
}

fn validate_requirements(
    project: &ProjectWorkspace,
    package: &PackageName,
    requirements: &[UpgradableRequirement],
) -> Result<()> {
    if requirements.iter().any(|selected| {
        matches!(
            selected.requirement.version_or_url,
            Some(VersionOrUrl::Url(_))
        )
    }) {
        bail!("Dependency `{package}` is a direct URL requirement and cannot be upgraded");
    }

    if package == project.project_name() {
        bail!("Dependency `{package}` refers to the current project and cannot be upgraded");
    }

    let sources = project
        .current_project()
        .pyproject_toml()
        .tool
        .as_ref()
        .and_then(|tool| tool.uv.as_ref())
        .and_then(|uv| uv.sources.as_ref())
        .and_then(|sources| sources.inner().get(package))
        .or_else(|| project.workspace().sources().get(package));
    let applies_to_selected_requirement = |source| {
        requirements.iter().any(|selected| {
            source_is_applicable(source, &selected.dependency_type, selected.effective_marker)
        })
    };
    if sources.is_some_and(|sources| {
        sources.iter().any(|source| {
            applies_to_selected_requirement(source)
                && matches!(source, Source::Git { rev: Some(_), .. })
        })
    }) {
        bail!(
            "Dependency `{package}` is pinned to a Git revision and cannot be upgraded commit-to-commit"
        );
    }
    if sources.is_some_and(|sources| {
        sources.iter().any(|source| {
            applies_to_selected_requirement(source) && !matches!(source, Source::Registry { .. })
        })
    }) {
        bail!(
            "Dependency `{package}` uses a non-registry source in `tool.uv.sources` and cannot be upgraded"
        );
    }

    Ok(())
}

/// Return a requirement suitable for diagnostics without exposing URL query parameters.
fn display_requirement(requirement: &Requirement<VerbatimParsedUrl>) -> String {
    let mut requirement = requirement.clone();
    if let Some(VersionOrUrl::Url(url)) = &mut requirement.version_or_url {
        let mut display_url = url.verbatim.to_url();
        display_url.set_query(None);
        url.verbatim = VerbatimUrl::from_url(display_url);
    }
    requirement.to_string()
}

fn render_skipped_requirements(skipped: &[SkippedRequirement], printer: Printer) -> Result<()> {
    for requirement in skipped {
        let reason = match requirement.reason {
            SkippedReason::EnvironmentOrPythonRequirement => {
                "excluded by the project's environments or Python requirement"
            }
            SkippedReason::UndefinedExtra => {
                "references an extra that the project does not provide"
            }
        };
        writeln!(
            printer.stderr(),
            "warning: Skipping dependency `{}` in {}: `{}` ({reason})",
            requirement.package,
            requirement.dependency_type.toml_table_name(),
            requirement.display_text
        )?;
    }
    Ok(())
}

/// Return the marker domain that the project will resolve for dependency declarations.
fn project_resolution_marker(project: &ProjectWorkspace) -> Result<MarkerTree> {
    let target = LockTarget::from(project.workspace());
    let requires_python = target
        .requires_python()?
        .map_or(MarkerTree::TRUE, |requires_python| {
            requires_python.to_marker_tree()
        });
    let environments = target
        .environments()
        .map(SupportedEnvironments::as_markers)
        .unwrap_or_default();
    Ok(implicit_constraints_marker(requires_python, environments))
}

/// Apply exact requirement replacements, coalescing repeated identical declarations.
fn apply_requirement_replacements<'a>(
    pyproject: &mut PyProjectTomlMut,
    replacements: impl IntoIterator<Item = &'a RequirementUpdate>,
) -> Result<()> {
    let mut applied = Vec::new();
    for RequirementUpdate {
        package,
        dependency_type,
        existing,
        replacement,
        ..
    } in replacements
    {
        if let Some((_, _, applied_replacement)) =
            applied
                .iter()
                .find(|(applied_dependency_type, applied_existing, _)| {
                    *applied_dependency_type == dependency_type && *applied_existing == existing
                })
        {
            if *applied_replacement != replacement {
                bail!("Dependency `{package}` has conflicting requirement updates");
            }
            continue;
        }

        if pyproject
            .replace_dependency_declaration(dependency_type, existing, replacement)?
            .is_empty()
        {
            bail!(
                "Dependency `{package}` was not found in {}",
                dependency_type.toml_table_name()
            );
        }
        applied.push((dependency_type, existing, replacement));
    }
    Ok(())
}

/// Return whether a source applies to the selected requirement declaration.
fn source_is_applicable(
    source: &Source,
    dependency_type: &DependencyType,
    requirement_marker: MarkerTree,
) -> bool {
    let source_origin_applies = match dependency_type {
        DependencyType::Production => {
            let extra = requirement_marker.top_level_extra_name();
            source
                .extra()
                .is_none_or(|target| extra.as_deref() == Some(target))
                && source.group().is_none()
        }
        DependencyType::Dev => source.extra().is_none() && source.group().is_none(),
        DependencyType::Optional(extra) => {
            source.extra() == Some(extra) && source.group().is_none()
        }
        DependencyType::Group(group) => source.extra().is_none() && source.group() == Some(group),
    };
    source_origin_applies && !source.marker().is_disjoint(requirement_marker)
}

/// Convert a parsed requirement into the representation used by the mutable manifest.
fn into_verbatim_requirement(
    requirement: Requirement<VerbatimParsedUrl>,
    package: &PackageName,
) -> Result<Requirement<VerbatimUrl>> {
    let Requirement {
        name,
        extras,
        version_or_url,
        marker,
        origin,
    } = requirement;
    let version_or_url = match version_or_url {
        Some(VersionOrUrl::VersionSpecifier(specifiers)) => {
            Some(VersionOrUrl::VersionSpecifier(specifiers))
        }
        Some(VersionOrUrl::Url(_)) => {
            bail!("Dependency `{package}` is a direct URL requirement and cannot be upgraded");
        }
        None => None,
    };
    Ok(Requirement::<VerbatimUrl> {
        name,
        extras,
        version_or_url,
        marker,
        origin,
    })
}

/// Propose version specifiers that admit every resolved version.
///
/// Return `None` if no update is needed. Otherwise, rewrite only blocking specifiers and return
/// them in `Some`. When multiple versions are resolved, choose bounds that admit all of them, or
/// return an error if that is impossible.
///
/// For example, resolving `foo>=1,<2` to `2.4` produces `>=1, <3`.
fn propose_specifiers(
    requirement: &Requirement<VerbatimParsedUrl>,
    resolved_versions: &BTreeSet<Version>,
) -> Result<Option<VersionSpecifiers>> {
    if resolved_versions.is_empty() {
        return Ok(None);
    }

    let Some(VersionOrUrl::VersionSpecifier(specifiers)) = &requirement.version_or_url else {
        return Ok(None);
    };
    if resolved_versions
        .iter()
        .all(|version| specifiers.contains(version))
    {
        return Ok(None);
    }
    let Some(highest_resolved_version) = resolved_versions.last() else {
        return Ok(None);
    };

    let specifiers = specifiers
        .iter()
        .cloned()
        .map(|specifier| rewrite_specifier(specifier, resolved_versions))
        .collect::<Result<VersionSpecifiers>>()?;
    if !resolved_versions
        .iter()
        .all(|version| specifiers.contains(version))
    {
        tracing::debug!(
            dependency = %requirement.name,
            resolved_versions = ?resolved_versions,
            rewritten_specifiers = %specifiers,
            "Rewritten dependency constraint does not admit every resolved version"
        );
        if resolved_versions.len() == 1 {
            bail!(
                "Dependency `{}` resolved to version `{highest_resolved_version}` which cannot be represented by the upgraded requirement; this is not supported yet",
                requirement.name
            );
        }
        let resolved_versions = resolved_versions
            .iter()
            .map(ToString::to_string)
            .collect::<Vec<_>>()
            .join("`, `");
        bail!(
            "Dependency `{}` resolved to versions `{resolved_versions}` which cannot be represented by the upgraded requirement; this is not supported yet",
            requirement.name
        );
    }
    Ok(Some(specifiers))
}

/// Attempt to rewrite a [`VersionSpecifier`] to admit all resolved versions while preserving its
/// operator.
fn rewrite_specifier(
    specifier: VersionSpecifier,
    resolved_versions: &BTreeSet<Version>,
) -> Result<VersionSpecifier> {
    if resolved_versions
        .iter()
        .all(|version| specifier.contains(version))
    {
        return Ok(specifier);
    }
    let (Some(lowest_resolved_version), Some(highest_resolved_version)) =
        (resolved_versions.first(), resolved_versions.last())
    else {
        return Ok(specifier);
    };

    Ok(match specifier.operator() {
        Operator::GreaterThan
        | Operator::GreaterThanEqual
        | Operator::NotEqual
        | Operator::NotEqualStar => specifier,
        Operator::TildeEqual => VersionSpecifier::from_version(
            Operator::TildeEqual,
            compatible_version_at_precision(
                lowest_resolved_version,
                specifier.version().release().len(),
            )?,
        )?,
        Operator::Equal => VersionSpecifier::equals_version(lowest_resolved_version.clone()),
        Operator::EqualStar => VersionSpecifier::equals_star_version(
            lowest_resolved_version
                .only_release_at_precision(specifier.version().release().len())
                .context("Cannot rewrite a version constraint without a release segment")?,
        ),
        Operator::ExactEqual => {
            VersionSpecifier::from_version(Operator::ExactEqual, lowest_resolved_version.clone())?
        }
        Operator::LessThan => VersionSpecifier::less_than_version(increment_version_at_precision(
            highest_resolved_version,
            specifier.version().release().len(),
        )?),
        Operator::LessThanEqual => VersionSpecifier::from_version(
            Operator::LessThanEqual,
            highest_resolved_version.clone().without_local(),
        )?,
    })
}

/// Project a version to the given precision while preserving its compatible-release suffixes.
fn compatible_version_at_precision(version: &Version, precision: usize) -> Result<Version> {
    let release = version
        .release()
        .iter()
        .copied()
        .chain(std::iter::repeat(0))
        .take(precision)
        .collect::<Vec<_>>();
    if release.is_empty() {
        bail!("Cannot rewrite a version constraint without a release segment");
    }
    Ok(version.clone().with_release(release).without_local())
}

/// Increment the last release segment after projecting a version to the given precision.
fn increment_version_at_precision(version: &Version, precision: usize) -> Result<Version> {
    let projected = version
        .only_release_at_precision(precision)
        .context("Cannot rewrite a version constraint without a release segment")?;
    let mut release = projected.release().to_vec();
    let segment_index = release.len();
    let Some(last) = release.last_mut() else {
        bail!("Cannot rewrite a version constraint without a release segment");
    };
    let segment = *last;
    *last = segment.checked_add(1).with_context(|| {
        format!(
            "Cannot expand version `{version}` at release segment {segment_index} (`{segment}`) beyond its maximum value"
        )
    })?;
    Ok(projected.with_release(release))
}

/// Remove upper and exact constraints while retaining lower bounds and exclusions.
fn relax_requirement(
    mut requirement: Requirement<VerbatimParsedUrl>,
) -> Requirement<VerbatimParsedUrl> {
    let Some(VersionOrUrl::VersionSpecifier(specifiers)) = &requirement.version_or_url else {
        return requirement;
    };

    let specifiers = specifiers
        .iter()
        .filter_map(|specifier| match specifier.operator() {
            Operator::GreaterThan
            | Operator::GreaterThanEqual
            | Operator::NotEqual
            | Operator::NotEqualStar => Some(specifier.clone()),
            Operator::TildeEqual => Some(VersionSpecifier::greater_than_equal_version(
                specifier.version().clone(),
            )),
            Operator::Equal
            | Operator::EqualStar
            | Operator::ExactEqual
            | Operator::LessThan
            | Operator::LessThanEqual => None,
        })
        .collect::<VersionSpecifiers>();

    requirement.version_or_url = if specifiers.is_empty() {
        None
    } else {
        Some(VersionOrUrl::VersionSpecifier(specifiers))
    };
    requirement
}

#[cfg(test)]
mod tests {
    use std::collections::BTreeSet;
    use std::str::FromStr;

    use uv_pep440::Version;
    use uv_pep508::Requirement;
    use uv_pypi_types::VerbatimParsedUrl;

    use super::{increment_version_at_precision, propose_specifiers, relax_requirement};

    fn resolved_versions(versions: &[&str]) -> BTreeSet<Version> {
        versions
            .iter()
            .map(|version| Version::from_str(version).expect("valid version"))
            .collect()
    }

    #[test]
    fn propose_specifiers_preserves_satisfied_constraints() {
        for requirement in ["requests", "requests>=1.2", "requests!=2.3"] {
            let requirement =
                Requirement::<VerbatimParsedUrl>::from_str(requirement).expect("valid requirement");

            let proposed = propose_specifiers(&requirement, &resolved_versions(&["2.4.0"]))
                .expect("specifiers can be proposed");

            assert!(proposed.is_none());
        }
    }

    #[test]
    fn propose_specifiers_returns_none_without_resolved_versions() {
        let requirement =
            Requirement::<VerbatimParsedUrl>::from_str("requests<2").expect("valid requirement");

        let proposed =
            propose_specifiers(&requirement, &BTreeSet::new()).expect("specifiers can be proposed");

        assert!(proposed.is_none());
    }

    #[test]
    fn propose_specifiers_expands_exclusive_upper_bounds_at_existing_precision() {
        for (requirement, version, expected) in [
            ("requests>=1.2,<2", "2.4.0", ">=1.2, <3"),
            ("requests>=1.2,<1.3", "1.4.2", ">=1.2, <1.5"),
        ] {
            let requirement =
                Requirement::<VerbatimParsedUrl>::from_str(requirement).expect("valid requirement");

            let proposed = propose_specifiers(&requirement, &resolved_versions(&[version]))
                .expect("specifiers can be proposed")
                .expect("specifiers need an update");

            assert_eq!(proposed.to_string(), expected);
        }
    }

    #[test]
    fn propose_specifiers_only_rewrites_blocking_specifiers() {
        let requirement = Requirement::<VerbatimParsedUrl>::from_str("requests>=1,<2,<4")
            .expect("valid requirement");

        let proposed = propose_specifiers(&requirement, &resolved_versions(&["2.4.0"]))
            .expect("specifiers can be proposed")
            .expect("specifiers need an update");

        assert_eq!(proposed.to_string(), ">=1, <3, <4");
    }

    #[test]
    fn propose_specifiers_preserves_operator_style() {
        for (requirement, version, expected) in [
            ("requests==1.2.3", "2.4.5", "==2.4.5"),
            ("requests===1.2.3", "2.4.5", "===2.4.5"),
            ("requests==1.2.*", "2.4.5", "==2.4.*"),
            ("requests~=1.2", "2.4.5", "~=2.4"),
            ("requests~=1.2.3", "2.4.5", "~=2.4.5"),
            ("requests<=1.2.3", "2.4.5", "<=2.4.5"),
        ] {
            let requirement =
                Requirement::<VerbatimParsedUrl>::from_str(requirement).expect("valid requirement");

            let proposed = propose_specifiers(&requirement, &resolved_versions(&[version]))
                .expect("specifiers can be proposed")
                .expect("specifiers need an update");

            assert_eq!(proposed.to_string(), expected);
        }
    }

    #[test]
    fn propose_specifiers_preserves_compatible_release_suffixes() {
        let requirement =
            Requirement::<VerbatimParsedUrl>::from_str("requests~=1.2").expect("valid requirement");

        let proposed = propose_specifiers(
            &requirement,
            &resolved_versions(&["1!2.4rc1.post2.dev3+local"]),
        )
        .expect("specifiers can be proposed")
        .expect("specifiers need an update");

        assert_eq!(proposed.to_string(), "~=1!2.4rc1.post2.dev3");
    }

    #[test]
    fn propose_specifiers_strips_local_version_from_inclusive_upper_bound() {
        let requirement = Requirement::<VerbatimParsedUrl>::from_str("requests<=1.2.3")
            .expect("valid requirement");

        let proposed = propose_specifiers(&requirement, &resolved_versions(&["2.4.5+local"]))
            .expect("specifiers can be proposed")
            .expect("specifiers need an update");

        assert_eq!(proposed.to_string(), "<=2.4.5");
    }

    #[test]
    fn propose_specifiers_rejects_constraint_that_still_excludes_resolved_version() {
        let requirement = Requirement::<VerbatimParsedUrl>::from_str("requests!=2.4,<2")
            .expect("valid requirement");

        let error = propose_specifiers(&requirement, &resolved_versions(&["2.4"]))
            .expect_err("rewritten requirement must admit the resolved version");

        assert_eq!(
            error.to_string(),
            "Dependency `requests` resolved to version `2.4` which cannot be represented by the upgraded requirement; this is not supported yet"
        );
    }

    #[test]
    fn propose_specifiers_preserves_lower_bounds_and_exclusions() {
        let requirement = Requirement::<VerbatimParsedUrl>::from_str(
            "Requests_Plus[security,tests]>=1.2,!=2.3,<2 ; python_version >= '3.12'",
        )
        .expect("valid requirement");

        let proposed = propose_specifiers(&requirement, &resolved_versions(&["2.4.0"]))
            .expect("specifiers can be proposed")
            .expect("specifiers need an update");

        assert_eq!(proposed.to_string(), ">=1.2, !=2.3, <3");
    }

    #[test]
    fn propose_specifiers_expands_upper_bound_for_multiple_versions() {
        let requirement =
            Requirement::<VerbatimParsedUrl>::from_str("requests<2").expect("valid requirement");

        let proposed = propose_specifiers(&requirement, &resolved_versions(&["1.5.0", "2.4.0"]))
            .expect("upper bound can admit both versions")
            .expect("specifiers need an update");

        assert_eq!(proposed.to_string(), "<3");
    }

    #[test]
    fn propose_specifiers_uses_lowest_compatible_version_for_multiple_versions() {
        let requirement =
            Requirement::<VerbatimParsedUrl>::from_str("requests~=1.2").expect("valid requirement");

        let proposed = propose_specifiers(&requirement, &resolved_versions(&["2.4", "2.5"]))
            .expect("compatible release can admit both versions")
            .expect("specifiers need an update");

        assert_eq!(proposed.to_string(), "~=2.4");
    }

    #[test]
    fn propose_specifiers_rejects_unrepresentable_multiple_versions() {
        let requirement =
            Requirement::<VerbatimParsedUrl>::from_str("requests==1.*").expect("valid requirement");

        let error = propose_specifiers(&requirement, &resolved_versions(&["1.5.0", "2.4.0"]))
            .expect_err("wildcard cannot admit versions from different major lines");

        assert_eq!(
            error.to_string(),
            "Dependency `requests` resolved to versions `1.5.0`, `2.4.0` which cannot be represented by the upgraded requirement; this is not supported yet"
        );
    }

    #[test]
    fn increment_version_at_precision_reports_upper_bound_overflow() {
        let version = Version::new([1, 2, u64::MAX]);

        let error = increment_version_at_precision(&version, 3)
            .expect_err("maximum release segment cannot be incremented");

        assert_eq!(
            error.to_string(),
            "Cannot expand version `1.2.18446744073709551615` at release segment 3 (`18446744073709551615`) beyond its maximum value"
        );
    }

    #[test]
    fn relax_requirement_preserves_lower_bounds_and_exclusions() {
        let requirement = Requirement::<VerbatimParsedUrl>::from_str(
            "Requests>=1,>1.5,!=2,!=2.1.*,==2.5,===2.6,<=3,<4",
        )
        .expect("valid requirement");

        let relaxed = relax_requirement(requirement);

        assert_eq!(relaxed.to_string(), "requests>=1,>1.5,!=2,!=2.1.*");
    }

    #[test]
    fn relax_requirement_converts_compatible_release_to_lower_bound() {
        let requirement = Requirement::<VerbatimParsedUrl>::from_str("requests~=2.32.1")
            .expect("valid requirement");

        let relaxed = relax_requirement(requirement);

        assert_eq!(relaxed.to_string(), "requests>=2.32.1");
    }

    #[test]
    fn relax_requirement_removes_blocking_only_constraints() {
        for requirement in [
            "requests==2.32.1",
            "requests===2.32.1",
            "requests==2.32.*",
            "requests<3",
            "requests<=3",
        ] {
            let requirement =
                Requirement::<VerbatimParsedUrl>::from_str(requirement).expect("valid requirement");

            let relaxed = relax_requirement(requirement);

            assert_eq!(relaxed.to_string(), "requests");
        }
    }

    #[test]
    fn relax_requirement_preserves_requirement_metadata() {
        let requirement = Requirement::<VerbatimParsedUrl>::from_str(
            "Requests_Plus[security,tests]~=2.32 ; python_version >= '3.12'",
        )
        .expect("valid requirement");

        let relaxed = relax_requirement(requirement);

        assert_eq!(
            relaxed.to_string(),
            "requests-plus[security,tests]>=2.32 ; python_full_version >= '3.12'"
        );
    }
}