1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
use std::borrow::Cow;
use std::iter;
use either::Either;
use pubgrub::Ranges;
use uv_distribution_types::{IndexMetadata, Requirement, RequirementSource};
use uv_normalize::{ExtraName, GroupName, PackageName};
use uv_pep440::{Version, VersionSpecifiers};
use uv_pep508::RequirementOrigin;
use uv_pypi_types::{
ConflictItemRef, Conflicts, ParsedArchiveUrl, ParsedDirectoryUrl, ParsedGitUrl, ParsedPathUrl,
ParsedUrl, VerbatimParsedUrl,
};
use crate::pubgrub::{PubGrubPackage, PubGrubPackageInner};
/// The source constraint carried by a single dependency edge.
///
/// Most dependency edges are source-agnostic and use [`DependencySource::Unspecified`]. Direct
/// URLs and group-scoped explicit indexes use a concrete source so fork construction can keep
/// that source information attached to the edge that introduced it.
#[derive(Clone, Debug, Default, Eq, PartialEq)]
pub(crate) enum DependencySource {
/// The dependency does not carry an edge-local source constraint.
#[default]
Unspecified,
/// The dependency was introduced by a direct URL-like requirement.
Url(Box<VerbatimParsedUrl>),
/// The dependency was introduced by a requirement pinned to an explicit index.
ExplicitIndex(IndexMetadata),
}
impl DependencySource {
/// Derive the edge-local source constraint from a requirement.
///
/// Registry requirements only carry a source here when they are tied to a group-scoped
/// explicit index. Direct URL-like requirements always preserve their verbatim URL.
pub(crate) fn from_requirement(requirement: &Requirement) -> Self {
match &requirement.source {
RequirementSource::Registry { index, .. }
if matches!(
requirement.origin.as_ref(),
Some(RequirementOrigin::Group(_, Some(_), _))
) =>
{
index
.clone()
.map(Self::ExplicitIndex)
.unwrap_or(Self::Unspecified)
}
RequirementSource::Registry { .. } => Self::Unspecified,
RequirementSource::Url { .. }
| RequirementSource::Git { .. }
| RequirementSource::Path { .. }
| RequirementSource::Directory { .. } => requirement
.source
.to_verbatim_parsed_url()
.map(Box::new)
.map(Self::Url)
.unwrap_or(Self::Unspecified),
}
}
/// Return the direct URL attached to this source, if any.
pub(crate) fn verbatim_url(&self) -> Option<&VerbatimParsedUrl> {
match self {
Self::Url(url) => Some(url.as_ref()),
Self::Unspecified | Self::ExplicitIndex(_) => None,
}
}
/// Return the explicit index attached to this source, if any.
pub(crate) fn explicit_index(&self) -> Option<&IndexMetadata> {
match self {
Self::ExplicitIndex(index) => Some(index),
Self::Unspecified | Self::Url(_) => None,
}
}
}
#[derive(Clone, Debug, Eq, PartialEq)]
pub(crate) struct PubGrubDependency {
pub(crate) package: PubGrubPackage,
pub(crate) version: Ranges<Version>,
/// When the parent that created this dependency is a "normal" package
/// (non-extra non-group), this corresponds to its name.
///
/// This is used to create project-level `ConflictItemRef` for a specific
/// package. In effect, this lets us "delay" filtering of project
/// dependencies when a conflict is declared between the project and a
/// group.
///
/// The main problem with dealing with project level conflicts is that if you
/// declare a conflict between a package and a group, we represent that
/// group as a dependency of that package. So if you filter out the package
/// in a fork due to a conflict, you also filter out the group. Therefore,
/// we introduce this parent field to enable "delayed" filtering.
pub(crate) parent: Option<PackageName>,
/// The direct source constraint attached to this dependency edge.
///
/// This is only populated when the edge itself needs source identity, e.g. for direct URLs
/// or group-scoped explicit indexes. Manifest-wide URL and index constraints are still applied
/// separately via `Urls` and `Indexes`.
pub(crate) source: DependencySource,
}
impl PubGrubDependency {
pub(crate) fn from_requirement<'a>(
conflicts: &Conflicts,
requirement: Cow<'a, Requirement>,
group_name: Option<&'a GroupName>,
parent_package: Option<&'a PubGrubPackage>,
) -> impl Iterator<Item = Self> + 'a {
let parent_name = parent_package.and_then(|package| package.name_no_root());
let is_normal_parent = parent_package
.map(|pp| pp.extra().is_none() && pp.group().is_none())
.unwrap_or(false);
let iter = if !requirement.extras.is_empty() {
// This is crazy subtle, but if any of the extras in the
// requirement are part of a declared conflict, then we
// specifically need (at time of writing) to include the
// base package as a dependency. This results in both
// the base package and the extra package being sibling
// dependencies at the point in which forks are created
// base on conflicting extras. If the base package isn't
// present at that point, then it's impossible for the
// fork that excludes all conflicting extras to reach
// the non-extra dependency, which may be necessary for
// correctness.
//
// But why do we not include the base package in the first
// place? Well, that's part of an optimization[1].
//
// [1]: https://github.com/astral-sh/uv/pull/9540
let base = if requirement
.extras
.iter()
.any(|extra| conflicts.contains(&requirement.name, extra))
{
Either::Left(iter::once((None, None)))
} else {
Either::Right(iter::empty())
};
Either::Left(Either::Left(base.chain(
Box::into_iter(requirement.extras.clone()).map(|extra| (Some(extra), None)),
)))
} else if !requirement.groups.is_empty() {
let base = if requirement
.groups
.iter()
.any(|group| conflicts.contains(&requirement.name, group))
{
Either::Left(iter::once((None, None)))
} else {
Either::Right(iter::empty())
};
Either::Left(Either::Right(base.chain(
Box::into_iter(requirement.groups.clone()).map(|group| (None, Some(group))),
)))
} else {
Either::Right(iter::once((None, None)))
};
// Add the package, plus any extra variants.
iter.map(move |(extra, group)| {
let pubgrub_requirement =
PubGrubRequirement::from_requirement(&requirement, extra, group);
let PubGrubRequirement {
package,
version,
source,
} = pubgrub_requirement;
match &*package {
PubGrubPackageInner::Package { .. } => Self {
package,
version,
parent: if is_normal_parent {
parent_name.cloned()
} else {
None
},
source,
},
PubGrubPackageInner::Marker { .. } => Self {
package,
version,
parent: if is_normal_parent {
parent_name.cloned()
} else {
None
},
source,
},
PubGrubPackageInner::Extra { name, .. } => {
if group_name.is_none() {
debug_assert!(
parent_name.is_none_or(|parent_name| parent_name != name),
"extras not flattened for {name}"
);
}
Self {
package,
version,
parent: None,
source,
}
}
PubGrubPackageInner::Group { name, .. } => {
if group_name.is_none() {
debug_assert!(
parent_name.is_none_or(|parent_name| parent_name != name),
"group not flattened for {name}"
);
}
Self {
package,
version,
parent: None,
source,
}
}
PubGrubPackageInner::Root(_) => unreachable!("Root package in dependencies"),
PubGrubPackageInner::Python(_) => {
unreachable!("Python package in dependencies")
}
PubGrubPackageInner::System(_) => unreachable!("System package in dependencies"),
}
})
}
/// Extracts a possible conflicting item from this dependency.
///
/// If this package can't possibly be classified as conflicting, then this
/// returns `None`.
pub(crate) fn conflicting_item(&self) -> Option<ConflictItemRef<'_>> {
self.package.conflicting_item()
}
}
/// A PubGrub-compatible package and version range.
#[derive(Debug, Clone)]
pub(crate) struct PubGrubRequirement {
pub(crate) package: PubGrubPackage,
pub(crate) version: Ranges<Version>,
pub(crate) source: DependencySource,
}
impl PubGrubRequirement {
fn package_for_requirement(
requirement: &Requirement,
extra: Option<ExtraName>,
group: Option<GroupName>,
) -> PubGrubPackage {
PubGrubPackage::from_package(requirement.name.clone(), extra, group, requirement.marker)
}
/// Convert a [`Requirement`] to a PubGrub-compatible package and range, while returning the URL
/// on the [`Requirement`], if any.
pub(crate) fn from_requirement(
requirement: &Requirement,
extra: Option<ExtraName>,
group: Option<GroupName>,
) -> Self {
let (verbatim_url, parsed_url) = match &requirement.source {
RequirementSource::Registry { specifier, .. } => {
return Self::from_registry_requirement(specifier, extra, group, requirement);
}
RequirementSource::Url {
subdirectory,
location,
ext,
url,
} => {
let parsed_url = ParsedUrl::Archive(ParsedArchiveUrl::from_source(
location.clone(),
subdirectory.clone(),
*ext,
));
(url, parsed_url)
}
RequirementSource::Git {
git,
url,
subdirectory,
} => {
let parsed_url =
ParsedUrl::Git(ParsedGitUrl::from_source(git.clone(), subdirectory.clone()));
(url, parsed_url)
}
RequirementSource::Path {
ext,
url,
install_path,
} => {
let parsed_url = ParsedUrl::Path(ParsedPathUrl::from_source(
install_path.clone(),
*ext,
url.to_url(),
));
(url, parsed_url)
}
RequirementSource::Directory {
editable,
r#virtual,
url,
install_path,
} => {
let parsed_url = ParsedUrl::Directory(ParsedDirectoryUrl::from_source(
install_path.clone(),
*editable,
*r#virtual,
url.to_url(),
));
(url, parsed_url)
}
};
Self {
package: Self::package_for_requirement(requirement, extra, group),
version: Ranges::full(),
source: DependencySource::Url(Box::new(VerbatimParsedUrl {
parsed_url,
verbatim: verbatim_url.clone(),
})),
}
}
fn from_registry_requirement(
specifier: &VersionSpecifiers,
extra: Option<ExtraName>,
group: Option<GroupName>,
requirement: &Requirement,
) -> Self {
Self {
package: Self::package_for_requirement(requirement, extra, group),
source: DependencySource::from_requirement(requirement),
version: Ranges::from(specifier.clone()),
}
}
}