upstream-rs 1.19.0

Fetch package updates directly from the source.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
#[cfg(target_os = "linux")]
use crate::services::integration::AppImageExtractor;
use crate::{
    models::common::{DesktopEntry, enums::Filetype, enums::TrustMode},
    models::upstream::Package,
    providers::provider_manager::ProviderManager,
    services::{
        integration::{DesktopManager, IconManager},
        packaging::PackageRemover,
        storage::package_storage::PackageStorage,
        trust::TrustedSignatureKeys,
    },
    utils::static_paths::UpstreamPaths,
};

use crate::{
    services::packaging::disk_impact::{
        DiskImpact, asset_size_estimate, install_impact_from_download,
    },
    services::packaging::{PackageInstaller, PackagePhase, PackageProgressEvent},
};

use anyhow::{Context, Result, anyhow};
use console::style;
use std::time::{Duration, Instant};

const INSTALL_PROGRESS_UPDATE_INTERVAL: Duration = Duration::from_millis(100);

macro_rules! message {
    ($cb:expr, $($arg:tt)*) => {{
        if let Some(cb) = $cb.as_mut() {
            cb(&format!($($arg)*));
        }
    }};
}

macro_rules! progress {
    ($cb:expr, $event:expr) => {{
        if let Some(cb) = $cb.as_mut() {
            cb($event);
        }
    }};
}

pub struct InstallOperation<'a> {
    installer: PackageInstaller<'a>,
    package_storage: &'a mut PackageStorage,
    provider_manager: &'a ProviderManager,
    paths: &'a UpstreamPaths,
    trusted_keys: TrustedSignatureKeys,
}

pub struct InstallPreview {
    pub release_name: String,
    pub release_tag: String,
    pub asset_name: String,
    pub resolved_filetype: Filetype,
    pub disk_impact: DiskImpact,
}

impl<'a> InstallOperation<'a> {
    pub fn new(
        provider_manager: &'a ProviderManager,
        package_storage: &'a mut PackageStorage,
        paths: &'a UpstreamPaths,
        trusted_keys: TrustedSignatureKeys,
    ) -> Result<Self> {
        let installer = PackageInstaller::new(provider_manager, paths)?;
        Ok(Self {
            installer,
            package_storage,
            provider_manager,
            paths,
            trusted_keys,
        })
    }

    pub async fn install_bulk<F, G, H>(
        &mut self,
        packages: Vec<Package>,
        trust_mode: TrustMode,
        download_progress_callback: &mut Option<F>,
        overall_progress_callback: &mut Option<G>,
        message_callback: &mut Option<H>,
    ) -> Result<()>
    where
        F: FnMut(u64, u64),
        G: FnMut(u32, u32),
        H: FnMut(&str),
    {
        let total = packages.len() as u32;
        let mut completed = 0;
        let mut failures = 0;

        for package in packages {
            let package_name = package.name.clone();
            message!(message_callback, "Installing '{}' ...", package_name);

            let use_icon = &package.icon_path.is_some();
            let mut last_progress: Option<(u64, u64)> = None;
            let mut last_emit: Option<Instant> = None;
            let mut throttled_download_progress = download_progress_callback.as_mut().map(|cb| {
                |downloaded: u64, total: u64| {
                    last_progress = Some((downloaded, total));
                    let should_emit = last_emit
                        .map(|t| t.elapsed() >= INSTALL_PROGRESS_UPDATE_INTERVAL)
                        .unwrap_or(true);
                    if should_emit {
                        cb(downloaded, total);
                        last_emit = Some(Instant::now());
                    }
                }
            });

            match self
                .install_single(
                    package,
                    &None,
                    use_icon,
                    trust_mode,
                    &mut throttled_download_progress,
                    message_callback,
                )
                .await
                .context(format!("Failed to install package '{}'", package_name))
            {
                Ok(_) => {
                    message!(message_callback, "{}", style("Package installed").green());
                }
                Err(e) => {
                    message!(message_callback, "{} {}", style("Install failed:").red(), e);
                    failures += 1;
                }
            }

            if let (Some((downloaded, total)), Some(cb)) =
                (last_progress, download_progress_callback.as_mut())
            {
                cb(downloaded, total);
            }

            completed += 1;
            if let Some(cb) = overall_progress_callback.as_mut() {
                cb(completed, total);
            }
        }

        if failures > 0 {
            message!(
                message_callback,
                "{} package(s) failed to install",
                failures
            );
        }

        Ok(())
    }

    pub async fn install_single<F, H>(
        &mut self,
        package: Package,
        version: &Option<String>,
        add_entry: &bool,
        trust_mode: TrustMode,
        download_progress_callback: &mut Option<F>,
        message_callback: &mut Option<H>,
    ) -> Result<()>
    where
        F: FnMut(u64, u64),
        H: FnMut(&str),
    {
        let mut no_progress: Option<fn(PackageProgressEvent)> = None;
        self.install_single_with_progress(
            package,
            version,
            add_entry,
            trust_mode,
            download_progress_callback,
            message_callback,
            &mut no_progress,
        )
        .await
    }

    #[allow(clippy::too_many_arguments)]
    pub async fn install_single_with_progress<F, H, P>(
        &mut self,
        package: Package,
        version: &Option<String>,
        add_entry: &bool,
        trust_mode: TrustMode,
        download_progress_callback: &mut Option<F>,
        message_callback: &mut Option<H>,
        progress_callback: &mut Option<P>,
    ) -> Result<()>
    where
        F: FnMut(u64, u64),
        H: FnMut(&str),
        P: FnMut(PackageProgressEvent),
    {
        let package_name = package.name.clone();

        let mut installed_package = self
            .perform_install_with_progress(
                package,
                version,
                trust_mode,
                download_progress_callback,
                message_callback,
                progress_callback,
            )
            .await
            .context(format!(
                "Failed to perform installation for '{}'",
                package_name
            ))?;

        if *add_entry {
            progress!(
                progress_callback,
                PackageProgressEvent::Phase(PackagePhase::CreatingDesktopEntry)
            );

            if let Err(err) = self
                .add_desktop_entry(&mut installed_package, message_callback)
                .await
            {
                return self
                    .fail_after_partial_install(
                        installed_package,
                        err.context("Failed to create desktop integration"),
                        message_callback,
                    )
                    .map(|_| ());
            }
        }

        progress!(
            progress_callback,
            PackageProgressEvent::Phase(PackagePhase::SavingMetadata)
        );
        if let Err(err) = self
            .package_storage
            .add_or_update_package(installed_package.clone())
            .context(format!(
                "Failed to save package '{}' to storage",
                installed_package.name
            ))
        {
            return self
                .fail_after_partial_install(installed_package, err, message_callback)
                .map(|_| ());
        }

        Ok(())
    }

    pub async fn install_local_artifact<H>(
        &mut self,
        package: Package,
        artifact_path: &std::path::Path,
        version: crate::models::common::version::Version,
        add_entry: &bool,
        message_callback: &mut Option<H>,
    ) -> Result<Package>
    where
        H: FnMut(&str),
    {
        let mut installed_package = self
            .installer
            .install_local_artifact(package, artifact_path, version, message_callback)
            .context("Failed to install local artifact")?;

        if *add_entry
            && let Err(err) = self
                .add_desktop_entry(&mut installed_package, message_callback)
                .await
        {
            return self.fail_after_partial_install(
                installed_package,
                err.context("Failed to create desktop integration"),
                message_callback,
            );
        }

        if let Err(err) = self
            .package_storage
            .add_or_update_package(installed_package.clone())
            .context(format!(
                "Failed to save package '{}' to storage",
                installed_package.name
            ))
        {
            return self.fail_after_partial_install(installed_package, err, message_callback);
        }

        Ok(installed_package)
    }

    async fn add_desktop_entry<H>(
        &self,
        installed_package: &mut Package,
        message_callback: &mut Option<H>,
    ) -> Result<()>
    where
        H: FnMut(&str),
    {
        #[cfg(target_os = "linux")]
        let appimage_extractor =
            AppImageExtractor::new().context("Failed to initialize appimage extractor")?;

        #[cfg(target_os = "linux")]
        let icon_manager = IconManager::new(self.paths, &appimage_extractor);
        #[cfg(not(target_os = "linux"))]
        let icon_manager = IconManager::new(self.paths);

        #[cfg(target_os = "linux")]
        let desktop_manager = DesktopManager::new(self.paths, &appimage_extractor);
        #[cfg(not(target_os = "linux"))]
        let desktop_manager = DesktopManager::new(self.paths);

        let install_path = installed_package.install_path.clone().ok_or_else(|| {
            anyhow!(
                "Package '{}' has no install path after installation",
                installed_package.name
            )
        })?;

        let icon_path = icon_manager
            .add_icon(
                &installed_package.name,
                &install_path,
                &installed_package.filetype,
                message_callback,
            )
            .await
            .context(format!(
                "Failed to add icon for '{}'",
                installed_package.name
            ))?;

        installed_package.icon_path = icon_path;

        let desktop_entry = DesktopEntry::from_package(installed_package);

        desktop_manager
            .create_entry(
                &install_path,
                &installed_package.filetype,
                desktop_entry,
                message_callback,
            )
            .await
            .context(format!(
                "Failed to create desktop entry for '{}'",
                installed_package.name
            ))?;

        Ok(())
    }

    fn fail_after_partial_install<H>(
        &self,
        installed_package: Package,
        err: anyhow::Error,
        message_callback: &mut Option<H>,
    ) -> Result<Package>
    where
        H: FnMut(&str),
    {
        match self.cleanup_partial_install(&installed_package, message_callback) {
            Ok(()) => Err(err.context(format!(
                "Rolled back partial install for '{}'",
                installed_package.name
            ))),
            Err(cleanup_err) => Err(anyhow!(
                "{}. Additionally failed to roll back partial install for '{}': {}",
                err,
                installed_package.name,
                cleanup_err
            )),
        }
    }

    fn cleanup_partial_install<H>(
        &self,
        installed_package: &Package,
        message_callback: &mut Option<H>,
    ) -> Result<()>
    where
        H: FnMut(&str),
    {
        if installed_package.install_path.is_none() {
            return Ok(());
        }

        PackageRemover::new(self.paths)
            .remove_package_files(installed_package, message_callback)
            .context(format!(
                "Failed to clean up partial install for '{}'",
                installed_package.name
            ))
    }

    pub async fn preview_single_install(
        &self,
        package: &Package,
        version: &Option<String>,
    ) -> Result<InstallPreview> {
        if package.install_path.is_some() {
            return Err(anyhow!("Package '{}' is already installed", package.name));
        }

        let release = if let Some(version_tag) = version {
            self.provider_manager
                .get_release_by_tag(
                    &package.repo_slug,
                    version_tag,
                    &package.provider,
                    package.base_url.as_deref(),
                )
                .await
                .context(format!(
                    "Failed to fetch release '{}' for '{}'. Verify the version tag exists",
                    version_tag, package.repo_slug
                ))?
        } else {
            self.provider_manager
                .get_latest_release(
                    &package.repo_slug,
                    &package.provider,
                    &package.channel,
                    package.base_url.as_deref(),
                )
                .await
                .context(format!(
                    "Failed to fetch latest {} release for '{}'",
                    package.channel, package.repo_slug
                ))?
        };

        let best_asset = self
            .provider_manager
            .find_recommended_asset(&release, package)
            .context(format!(
                "Could not find a compatible asset for '{}' (filetype: {:?}, arch: detected automatically)",
                package.name, package.filetype
            ))?;

        let resolved_filetype = if package.filetype == Filetype::Auto {
            best_asset.filetype
        } else {
            package.filetype
        };

        Ok(InstallPreview {
            release_name: release.name,
            release_tag: release.tag,
            asset_name: best_asset.name.clone(),
            resolved_filetype,
            disk_impact: install_impact_from_download(asset_size_estimate(best_asset.size)),
        })
    }

    async fn perform_install_with_progress<F, H, P>(
        &self,
        package: Package,
        version: &Option<String>,
        trust_mode: TrustMode,
        download_progress_callback: &mut Option<F>,
        message_callback: &mut Option<H>,
        progress_callback: &mut Option<P>,
    ) -> Result<Package>
    where
        F: FnMut(u64, u64),
        H: FnMut(&str),
        P: FnMut(PackageProgressEvent),
    {
        if package.install_path.is_some() {
            return Err(anyhow!("Package '{}' is already installed", package.name));
        }

        progress!(
            progress_callback,
            PackageProgressEvent::Phase(PackagePhase::ResolvingRelease)
        );

        let release = if let Some(version_tag) = version {
            // SPECIFIC VERSION
            message!(
                message_callback,
                "Fetching release for version '{}' ...",
                version_tag
            );
            self.provider_manager
                .get_release_by_tag(
                    &package.repo_slug,
                    version_tag,
                    &package.provider,
                    package.base_url.as_deref(),
                )
                .await
                .context(format!(
                    "Failed to fetch release '{}' for '{}'. Verify the version tag exists",
                    version_tag, package.repo_slug
                ))?
        } else {
            // LATEST VERSION
            message!(message_callback, "Fetching latest release ...");
            self.provider_manager
                .get_latest_release(
                    &package.repo_slug,
                    &package.provider,
                    &package.channel,
                    package.base_url.as_deref(),
                )
                .await
                .context(format!(
                    "Failed to fetch latest {} release for '{}'",
                    package.channel, package.repo_slug
                ))?
        };

        let progress_callback = std::cell::RefCell::new(progress_callback.as_mut());
        let mut bridged_progress = Some(|event: PackageProgressEvent| {
            if let Some(cb) = progress_callback.borrow_mut().as_deref_mut() {
                cb(event);
            }
        });
        let mut bridged_download_progress = Some(|downloaded: u64, total: u64| {
            if let Some(cb) = download_progress_callback.as_mut() {
                cb(downloaded, total);
            }
            if let Some(cb) = progress_callback.borrow_mut().as_deref_mut() {
                cb(PackageProgressEvent::Download { downloaded, total });
            }
        });

        self.installer
            .install_package_files(
                package,
                &release,
                trust_mode,
                &self.trusted_keys,
                &mut bridged_download_progress,
                message_callback,
                &mut bridged_progress,
            )
            .await
    }
}

#[cfg(test)]
mod tests {
    use super::InstallOperation;
    use crate::models::common::enums::{Channel, Filetype, Provider, TrustMode};
    use crate::models::upstream::Package;
    use crate::providers::provider_manager::ProviderManager;
    use crate::services::packaging::PackageProgressEvent;
    use crate::services::storage::package_storage::PackageStorage;
    use crate::utils::test_support;
    use std::path::Path;
    use std::{fs, io};

    fn temp_root(name: &str) -> std::path::PathBuf {
        test_support::temp_root("upstream-install-op-test", name)
    }

    fn test_paths(root: &Path) -> crate::utils::static_paths::UpstreamPaths {
        test_support::upstream_paths(root)
    }

    fn cleanup(path: &Path) -> io::Result<()> {
        fs::remove_dir_all(path)
    }

    #[tokio::test]
    async fn perform_install_rejects_already_installed_package_before_network_calls() {
        let root = temp_root("already-installed");
        let paths = test_paths(&root);
        fs::create_dir_all(paths.config.packages_file.parent().expect("parent"))
            .expect("create metadata dir");
        let mut storage = PackageStorage::new(&paths.config.packages_file).expect("storage");
        let provider_manager = ProviderManager::new(None, None, None).expect("provider manager");
        let op = InstallOperation::new(
            &provider_manager,
            &mut storage,
            &paths,
            crate::services::trust::TrustedSignatureKeys::default(),
        )
        .expect("operation");

        let mut package = Package::with_defaults(
            "tool".to_string(),
            "owner/tool".to_string(),
            Filetype::Binary,
            None,
            None,
            Channel::Stable,
            Provider::Github,
            None,
        );
        package.install_path = Some(paths.install.binaries_dir.join("tool"));
        let mut dl: Option<fn(u64, u64)> = None;
        let mut msg = Some(|_: &str| {});
        let mut progress: Option<fn(PackageProgressEvent)> = None;

        let err = op
            .perform_install_with_progress(
                package,
                &None,
                TrustMode::BestEffort,
                &mut dl,
                &mut msg,
                &mut progress,
            )
            .await
            .expect_err("already-installed guard");
        assert!(err.to_string().contains("already installed"));

        cleanup(&root).expect("cleanup");
    }

    #[test]
    fn cleanup_partial_install_removes_installed_binary() {
        let root = temp_root("cleanup-partial-install");
        let paths = test_paths(&root);
        fs::create_dir_all(&paths.install.binaries_dir).expect("create binaries dir");
        fs::create_dir_all(&paths.integration.symlinks_dir).expect("create symlinks dir");
        fs::create_dir_all(paths.config.packages_file.parent().expect("parent"))
            .expect("create metadata dir");
        let mut storage = PackageStorage::new(&paths.config.packages_file).expect("storage");
        let provider_manager = ProviderManager::new(None, None, None).expect("provider manager");
        let op = InstallOperation::new(
            &provider_manager,
            &mut storage,
            &paths,
            crate::services::trust::TrustedSignatureKeys::default(),
        )
        .expect("operation");

        let install_path = paths.install.binaries_dir.join("tool");
        fs::write(&install_path, b"new").expect("write installed binary");
        let mut package = Package::with_defaults(
            "tool".to_string(),
            "owner/tool".to_string(),
            Filetype::Binary,
            None,
            None,
            Channel::Stable,
            Provider::Github,
            None,
        );
        package.install_path = Some(install_path.clone());
        package.exec_path = Some(install_path.clone());
        let mut msg = Some(|_: &str| {});

        op.cleanup_partial_install(&package, &mut msg)
            .expect("cleanup partial install");

        assert!(!install_path.exists());
        cleanup(&root).expect("cleanup");
    }
}