upskill 0.3.1

Author and distribute AI-assistance content across coding agents
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156

//! ATDD tests for `upskill new <kind> <name>`.
//!
//! Scaffolds a starter SSOT item under `<cwd>/<kind>s/<name>/<KIND>.md`
//! with the minimum frontmatter the format spec requires, plus
//! kind-specific defaults (e.g. `mode: subagent` / `model: sonnet` for
//! agents). Author command — refuses to run inside a consumer project
//! (`.upskill-lock.json`) per ADR-0004.

use assert_cmd::Command;
use std::fs;

#[test]
fn new_skill_creates_skill_md_with_minimum_frontmatter() {
    let tmp = tempfile::tempdir().unwrap();
    Command::cargo_bin("upskill")
        .unwrap()
        .current_dir(tmp.path())
        .args(["new", "skill", "code-review"])
        .assert()
        .success();

    let path = tmp.path().join("skills/code-review/SKILL.md");
    assert!(path.is_file(), "{path:?} should exist");
    let body = fs::read_to_string(&path).unwrap();
    assert!(body.starts_with("---\n"), "{body}");
    assert!(body.contains("\nschema: 1\n"), "{body}");
    assert!(body.contains("\nname: code-review\n"), "{body}");
    assert!(body.contains("description:"), "{body}");
}

#[test]
fn new_rule_creates_rule_md() {
    let tmp = tempfile::tempdir().unwrap();
    Command::cargo_bin("upskill")
        .unwrap()
        .current_dir(tmp.path())
        .args(["new", "rule", "license-awareness"])
        .assert()
        .success();
    let path = tmp.path().join("rules/license-awareness/RULE.md");
    assert!(path.is_file());
    let body = fs::read_to_string(&path).unwrap();
    assert!(body.contains("\nname: license-awareness\n"), "{body}");
}

#[test]
fn new_agent_emits_default_mode_and_model() {
    let tmp = tempfile::tempdir().unwrap();
    Command::cargo_bin("upskill")
        .unwrap()
        .current_dir(tmp.path())
        .args(["new", "agent", "security-reviewer"])
        .assert()
        .success();
    let body = fs::read_to_string(tmp.path().join("agents/security-reviewer/AGENT.md")).unwrap();
    assert!(body.contains("\nmode: subagent\n"), "{body}");
    assert!(body.contains("\nmodel: sonnet\n"), "{body}");
}

#[test]
fn new_refuses_existing_item_directory() {
    let tmp = tempfile::tempdir().unwrap();
    fs::create_dir_all(tmp.path().join("skills/dup")).unwrap();
    fs::write(tmp.path().join("skills/dup/SKILL.md"), "old").unwrap();

    let assert = Command::cargo_bin("upskill")
        .unwrap()
        .current_dir(tmp.path())
        .args(["new", "skill", "dup"])
        .assert()
        .failure()
        .code(1);
    let stderr = String::from_utf8(assert.get_output().stderr.clone()).unwrap();
    assert!(stderr.contains("already exists"), "{stderr}");
    // Existing file untouched.
    assert_eq!(
        fs::read_to_string(tmp.path().join("skills/dup/SKILL.md")).unwrap(),
        "old"
    );
}

#[test]
fn new_rejects_invalid_name() {
    let tmp = tempfile::tempdir().unwrap();
    let assert = Command::cargo_bin("upskill")
        .unwrap()
        .current_dir(tmp.path())
        .args(["new", "skill", "Invalid_Name"])
        .assert()
        .failure();
    let stderr = String::from_utf8(assert.get_output().stderr.clone()).unwrap();
    assert!(
        stderr.contains("name") || stderr.contains("invalid"),
        "{stderr}"
    );
}

#[test]
fn new_refuses_to_run_inside_consumer_project() {
    let tmp = tempfile::tempdir().unwrap();
    fs::write(
        tmp.path().join(".upskill-lock.json"),
        r#"{"schema":2,"items":[]}"#,
    )
    .unwrap();
    let assert = Command::cargo_bin("upskill")
        .unwrap()
        .current_dir(tmp.path())
        .args(["new", "skill", "anything"])
        .assert()
        .failure()
        .code(2);
    let stderr = String::from_utf8(assert.get_output().stderr.clone()).unwrap();
    assert!(
        stderr.contains("consumer project") || stderr.contains(".upskill-lock.json"),
        "{stderr}"
    );
}

#[test]
fn new_output_passes_lint_and_fmt() {
    let tmp = tempfile::tempdir().unwrap();
    for (kind, name) in [
        ("skill", "starter-skill"),
        ("rule", "starter-rule"),
        ("agent", "starter-agent"),
    ] {
        Command::cargo_bin("upskill")
            .unwrap()
            .current_dir(tmp.path())
            .args(["new", kind, name])
            .assert()
            .success();
    }

    // Lint must accept its own scaffolding.
    Command::cargo_bin("upskill")
        .unwrap()
        .current_dir(tmp.path())
        .args(["lint", "--strict"])
        .assert()
        .success();

    // Fmt must report nothing changed (the scaffold is already canonical).
    let assert = Command::cargo_bin("upskill")
        .unwrap()
        .current_dir(tmp.path())
        .args(["fmt"])
        .assert()
        .success();
    let out = String::from_utf8(assert.get_output().stdout.clone()).unwrap();
    assert!(
        out.contains("all formatted"),
        "scaffold not canonical: {out}"
    );
}