unleash-edge 19.8.2

Unleash edge is a proxy for Unleash. It can return both evaluated feature toggles as well as the raw data from Unleash's client API
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
use crate::delta_cache::{DeltaCache, DeltaHydrationEvent};
use crate::error::{EdgeError, FeatureError};
use crate::http::headers::{
    UNLEASH_APPNAME_HEADER, UNLEASH_CLIENT_SPEC_HEADER, UNLEASH_CONNECTION_ID_HEADER,
    UNLEASH_INSTANCE_ID_HEADER,
};
use crate::http::refresher::feature_refresher::FeatureRefresher;
use crate::http::unleash_client::ClientMetaInformation;
use crate::tokens::cache_key;
use crate::types::{ClientFeaturesDeltaResponse, ClientFeaturesRequest, EdgeToken, TokenRefresh};
use actix_web::http::header::EntityTag;
use eventsource_client::Client;
use futures::TryStreamExt;
use reqwest::StatusCode;
use std::time::Duration;
use tracing::{debug, info, warn};
use unleash_types::client_features::{ClientFeaturesDelta, DeltaEvent};
use unleash_yggdrasil::EngineState;

pub type Environment = String;

const DELTA_CACHE_LIMIT: usize = 100;

impl FeatureRefresher {
    async fn handle_client_features_delta_updated(
        &self,
        refresh_token: &EdgeToken,
        delta: ClientFeaturesDelta,
        etag: Option<EntityTag>,
    ) {
        let updated_len = delta.events.len();

        debug!(
            "Got updated client features delta. Updating features with etag {etag:?}, events count {updated_len}"
        );

        let key: String = cache_key(refresh_token);
        self.features_cache.apply_delta(key.clone(), &delta);

        if let Some(mut _entry) = self.delta_cache_manager.get(&key) {
            self.delta_cache_manager.update_cache(&key, &delta.events);
        } else if let Some(DeltaEvent::Hydration {
            event_id,
            features,
            segments,
        }) = delta.events.clone().into_iter().next()
        {
            self.delta_cache_manager.insert_cache(
                &key,
                DeltaCache::new(
                    DeltaHydrationEvent {
                        event_id,
                        features,
                        segments,
                    },
                    DELTA_CACHE_LIMIT,
                ),
            );
        } else {
            warn!(
                "Warning: No hydrationEvent found in delta.events, but cache empty for environment"
            );
        }

        self.update_last_refresh(
            refresh_token,
            etag,
            self.features_cache.get(&key).unwrap().features.len(),
        );
        self.engine_cache
            .entry(key.clone())
            .and_modify(|engine| {
                engine.apply_delta(&delta);
            })
            .or_insert_with(|| {
                let mut new_state = EngineState::default();

                let warnings = new_state.apply_delta(&delta);
                if let Some(warnings) = warnings {
                    warn!("The following toggle failed to compile and will be defaulted to off: {warnings:?}");
                };
                new_state
            });
    }

    pub async fn refresh_single_delta(&self, refresh: TokenRefresh) {
        let delta_result = self
            .unleash_client
            .get_client_features_delta(ClientFeaturesRequest {
                api_key: refresh.token.token.clone(),
                etag: refresh.etag,
                interval: Some(self.refresh_interval.num_milliseconds()),
            })
            .await;
        match delta_result {
            Ok(delta_response) => match delta_response {
                ClientFeaturesDeltaResponse::NoUpdate(tag) => {
                    debug!("No update needed. Will update last check time with {tag}");
                    self.update_last_check(&refresh.token.clone());
                }
                ClientFeaturesDeltaResponse::Updated(features, etag) => {
                    self.handle_client_features_delta_updated(&refresh.token, features, etag)
                        .await
                }
            },
            Err(e) => {
                match e {
                    EdgeError::ClientFeaturesFetchError(fe) => {
                        match fe {
                            FeatureError::Retriable(status_code) => match status_code {
                                StatusCode::INTERNAL_SERVER_ERROR
                                | StatusCode::BAD_GATEWAY
                                | StatusCode::SERVICE_UNAVAILABLE
                                | StatusCode::GATEWAY_TIMEOUT => {
                                    info!(
                                        "Upstream is having some problems, increasing my waiting period"
                                    );
                                    self.backoff(&refresh.token);
                                }
                                StatusCode::TOO_MANY_REQUESTS => {
                                    info!("Got told that upstream is receiving too many requests");
                                    self.backoff(&refresh.token);
                                }
                                _ => {
                                    info!("Couldn't refresh features, but will retry next go")
                                }
                            },
                            FeatureError::AccessDenied => {
                                info!(
                                    "Token used to fetch features was Forbidden, will remove from list of refresh tasks"
                                );
                                self.tokens_to_refresh.remove(&refresh.token.token);
                                if !self.tokens_to_refresh.iter().any(|e| {
                                    e.value().token.environment == refresh.token.environment
                                }) {
                                    let cache_key = cache_key(&refresh.token);
                                    // No tokens left that access the environment of our current refresh. Deleting client features and engine cache
                                    self.features_cache.remove(&cache_key);
                                    self.engine_cache.remove(&cache_key);
                                }
                            }
                            FeatureError::NotFound => {
                                info!(
                                    "Had a bad URL when trying to fetch features. Increasing waiting period for the token before trying again"
                                );
                                self.backoff(&refresh.token);
                            }
                        }
                    }
                    EdgeError::ClientCacheError => {
                        info!("Couldn't refresh features, but will retry next go")
                    }
                    _ => info!("Couldn't refresh features: {e:?}. Will retry next pass"),
                }
            }
        }
    }

    pub async fn start_streaming_delta_background_task(
        &self,
        client_meta_information: ClientMetaInformation,
        custom_headers: Vec<(String, String)>,
    ) -> anyhow::Result<()> {
        use anyhow::Context;

        let refreshes = self.get_tokens_due_for_refresh();
        for refresh in refreshes {
            let token = refresh.token.clone();
            let streaming_url = self.unleash_client.urls.client_features_stream_url.as_str();

            let mut es_client_builder = eventsource_client::ClientBuilder::for_url(streaming_url)
                .context("Failed to create EventSource client for streaming")?
                .header("Authorization", &token.token)?
                .header(UNLEASH_APPNAME_HEADER, &client_meta_information.app_name)?
                .header(
                    UNLEASH_INSTANCE_ID_HEADER,
                    &client_meta_information.instance_id,
                )?
                .header(
                    UNLEASH_CONNECTION_ID_HEADER,
                    &client_meta_information.connection_id,
                )?
                .header(
                    UNLEASH_CLIENT_SPEC_HEADER,
                    unleash_yggdrasil::SUPPORTED_SPEC_VERSION,
                )?;

            for (key, value) in custom_headers.clone() {
                es_client_builder = es_client_builder.header(&key, &value)?;
            }

            let es_client = es_client_builder
                .reconnect(
                    eventsource_client::ReconnectOptions::reconnect(true)
                        .retry_initial(true)
                        .delay(Duration::from_secs(5))
                        .delay_max(Duration::from_secs(30))
                        .backoff_factor(2)
                        .build(),
                )
                .build();

            let refresher = self.clone();

            tokio::spawn(async move {
                let mut stream = es_client
                    .stream()
                    .map_ok(move |sse| {
                        let token = token.clone();
                        let refresher = refresher.clone();
                        async move {
                            match sse {
                                // The first time we're connecting to Unleash.
                                eventsource_client::SSE::Event(event)
                                if event.event_type == "unleash-connected" =>
                                    {
                                        debug!(
                                        "Connected to unleash! Populating my flag cache now.",
                                    );

                                        match serde_json::from_str(&event.data) {
                                            Ok(delta) => { refresher.handle_client_features_delta_updated(&token, delta, None).await; }
                                            Err(e) => { warn!("Could not parse features response to internal representation: {e:?}");
                                            }
                                        }
                                    }
                                // Unleash has updated features for us.
                                eventsource_client::SSE::Event(event)
                                if event.event_type == "unleash-updated" =>
                                    {
                                        debug!(
                                        "Got an unleash updated event. Updating cache.",
                                    );

                                        match serde_json::from_str(&event.data) {
                                            Ok(delta) => { refresher.handle_client_features_delta_updated(&token, delta, None).await; }
                                            Err(e) => { warn!("Could not parse features response to internal representation: {e:?}");
                                            }
                                        }
                                    }
                                eventsource_client::SSE::Event(event) => {
                                    info!(
                                        "Got an SSE event that I wasn't expecting: {:#?}",
                                        event
                                    );
                                }
                                eventsource_client::SSE::Connected(_) => {
                                    debug!("SSE Connection established");
                                }
                                eventsource_client::SSE::Comment(_) => {
                                    // purposefully left blank.
                                },
                            }
                        }
                    })
                    .map_err(|e| warn!("Error in SSE stream: {:?}", e));

                loop {
                    match stream.try_next().await {
                        Ok(Some(handler)) => handler.await,
                        Ok(None) => {
                            info!("SSE stream ended? Handler was None, anyway. Reconnecting.");
                        }
                        Err(e) => {
                            info!("SSE stream error: {e:?}. Reconnecting");
                        }
                    }
                }
            });
        }
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use crate::delta_cache_manager::DeltaCacheManager;
    use crate::feature_cache::FeatureCache;
    use crate::http::refresher::feature_refresher::FeatureRefresher;
    use crate::http::unleash_client::{ClientMetaInformation, UnleashClient};
    use crate::types::EdgeToken;
    use actix_http::HttpService;
    use actix_http::header::IF_NONE_MATCH;
    use actix_http_test::{TestServer, test_server};
    use actix_service::map_config;
    use actix_web::dev::AppConfig;
    use actix_web::http::header::{ETag, EntityTag};
    use actix_web::{App, HttpRequest, HttpResponse, web};
    use chrono::Duration;
    use dashmap::DashMap;
    use std::sync::Arc;
    use unleash_types::client_features::{
        ClientFeature, ClientFeatures, ClientFeaturesDelta, Constraint, DeltaEvent, Operator,
        Segment,
    };
    use unleash_yggdrasil::EngineState;

    #[actix_web::test]
    #[tracing_test::traced_test]
    async fn test_delta() {
        let srv = test_features_server().await;
        let unleash_client = Arc::new(UnleashClient::new(srv.url("/").as_str(), None).unwrap());
        let features_cache: Arc<FeatureCache> = Arc::new(FeatureCache::default());
        let delta_cache_manager: Arc<DeltaCacheManager> = Arc::new(DeltaCacheManager::new());
        let engine_cache: Arc<DashMap<String, EngineState>> = Arc::new(DashMap::default());

        let feature_refresher = Arc::new(FeatureRefresher {
            unleash_client: unleash_client.clone(),
            tokens_to_refresh: Arc::new(Default::default()),
            delta_cache_manager,
            features_cache: features_cache.clone(),
            engine_cache: engine_cache.clone(),
            refresh_interval: Duration::seconds(6000),
            persistence: None,
            strict: false,
            streaming: false,
            delta: true,
            delta_diff: false,
            client_meta_information: ClientMetaInformation::test_config(),
        });
        let mut delta_features = ClientFeatures::create_from_delta(&revision(1));
        let token =
            EdgeToken::try_from("*:development.abcdefghijklmnopqrstuvwxyz".to_string()).unwrap();
        feature_refresher
            .register_token_for_refresh(token.clone(), None)
            .await;
        feature_refresher.refresh_features().await;
        let refreshed_features = features_cache
            .get(&cache_key(&token))
            .unwrap()
            .value()
            .clone();
        assert_eq!(refreshed_features, delta_features);

        let token_refresh = feature_refresher
            .tokens_to_refresh
            .get(&token.token)
            .unwrap()
            .clone();
        feature_refresher.refresh_single_delta(token_refresh).await;
        let refreshed_features = features_cache
            .get(&cache_key(&token))
            .unwrap()
            .value()
            .clone();
        delta_features.apply_delta(&revision(2));
        assert_eq!(refreshed_features, delta_features);
    }

    fn cache_key(token: &EdgeToken) -> String {
        token
            .environment
            .clone()
            .unwrap_or_else(|| token.token.clone())
    }

    fn revision(revision_id: u32) -> ClientFeaturesDelta {
        match revision_id {
            1 => ClientFeaturesDelta {
                events: vec![
                    DeltaEvent::FeatureUpdated {
                        event_id: 1,
                        feature: ClientFeature {
                            name: "test1".into(),
                            feature_type: Some("release".into()),
                            ..Default::default()
                        },
                    },
                    DeltaEvent::FeatureUpdated {
                        event_id: 1,
                        feature: ClientFeature {
                            name: "test2".into(),
                            feature_type: Some("release".into()),
                            ..Default::default()
                        },
                    },
                    DeltaEvent::SegmentUpdated {
                        event_id: 1,
                        segment: Segment {
                            id: 1,
                            constraints: vec![Constraint {
                                context_name: "userId".into(),
                                operator: Operator::In,
                                case_insensitive: false,
                                inverted: false,
                                values: Some(vec!["7".into()]),
                                value: None,
                            }],
                        },
                    },
                ],
            },
            _ => ClientFeaturesDelta {
                events: vec![
                    DeltaEvent::FeatureUpdated {
                        event_id: 2,
                        feature: ClientFeature {
                            name: "test1".into(),
                            feature_type: Some("release".into()),
                            ..Default::default()
                        },
                    },
                    DeltaEvent::FeatureRemoved {
                        event_id: 2,
                        feature_name: "test2".to_string(),
                        project: "default".to_string(),
                    },
                ],
            },
        }
    }

    async fn return_client_features_delta(etag_header: Option<String>) -> HttpResponse {
        match etag_header {
            Some(value) => match value.as_str() {
                "\"1\"" => HttpResponse::Ok()
                    .insert_header(ETag(EntityTag::new_strong("2".to_string())))
                    .json(revision(2)),
                "\"2\"" => HttpResponse::NotModified().finish(),
                _ => HttpResponse::NotModified().finish(),
            },
            None => HttpResponse::Ok()
                .insert_header(ETag(EntityTag::new_strong("1".to_string())))
                .json(revision(1)),
        }
    }

    async fn test_features_server() -> TestServer {
        test_server(move || {
            HttpService::new(map_config(
                App::new().service(web::resource("/api/client/delta").route(web::get().to(
                    |req: HttpRequest| {
                        let etag_header = req
                            .headers()
                            .get(IF_NONE_MATCH)
                            .and_then(|h| h.to_str().ok());
                        return_client_features_delta(etag_header.map(|s| s.to_string()))
                    },
                ))),
                |_| AppConfig::default(),
            ))
            .tcp()
        })
        .await
    }
}