undoc 0.1.20

High-performance Microsoft Office document extraction to Markdown
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
//! PPTX parser implementation.

use crate::charts;
use crate::container::OoxmlContainer;
use crate::error::{Error, Result};
use crate::model::{
    Block, Cell, Document, HeadingLevel, Metadata, Paragraph, Resource, ResourceType, RevisionType,
    Row, Section, Table, TextRun, TextStyle,
};
use std::collections::HashMap;
use std::path::Path;

/// Slide info from presentation.xml.
#[derive(Debug, Clone)]
struct SlideInfo {
    #[allow(dead_code)]
    id: String,
    rel_id: String,
}

/// Parser for PPTX (PowerPoint) presentations.
pub struct PptxParser {
    container: OoxmlContainer,
    slides: Vec<SlideInfo>,
    relationships: HashMap<String, String>,
}

impl PptxParser {
    /// Open a PPTX file for parsing.
    pub fn open(path: impl AsRef<Path>) -> Result<Self> {
        let container = OoxmlContainer::open(path)?;
        Self::from_container(container)
    }

    /// Create a parser from bytes.
    pub fn from_bytes(data: Vec<u8>) -> Result<Self> {
        let container = OoxmlContainer::from_bytes(data)?;
        Self::from_container(container)
    }

    /// Create a parser from a container.
    fn from_container(container: OoxmlContainer) -> Result<Self> {
        // Parse presentation relationships
        let relationships = Self::parse_presentation_rels(&container)?;

        // Parse presentation for slide info
        let slides = Self::parse_presentation(&container)?;

        Ok(Self {
            container,
            slides,
            relationships,
        })
    }

    /// Parse presentation relationships.
    fn parse_presentation_rels(container: &OoxmlContainer) -> Result<HashMap<String, String>> {
        Ok(container
            .read_required_relationships_for_part("ppt/presentation.xml")?
            .into_targets_by_id())
    }

    /// Parse presentation.xml for slide info.
    fn parse_presentation(container: &OoxmlContainer) -> Result<Vec<SlideInfo>> {
        let mut slides = Vec::new();

        if let Ok(xml) = container.read_xml("ppt/presentation.xml") {
            let mut reader = quick_xml::Reader::from_str(&xml);
            reader.config_mut().trim_text(true);

            let mut buf = Vec::new();

            loop {
                match reader.read_event_into(&mut buf) {
                    Ok(quick_xml::events::Event::Empty(e))
                    | Ok(quick_xml::events::Event::Start(e)) => {
                        // Look for p:sldId elements (slide references)
                        let name = e.name();
                        let local_name = name.local_name();
                        if local_name.as_ref() == b"sldId" {
                            let mut id = String::new();
                            let mut rel_id = String::new();

                            for attr in e.attributes().flatten() {
                                match attr.key.as_ref() {
                                    b"id" => {
                                        id = String::from_utf8_lossy(&attr.value).to_string();
                                    }
                                    // r:id attribute
                                    key if key.ends_with(b"id")
                                        && key != b"id"
                                        && key.len() > 2 =>
                                    {
                                        rel_id = String::from_utf8_lossy(&attr.value).to_string();
                                    }
                                    _ => {}
                                }
                            }

                            if !rel_id.is_empty() {
                                slides.push(SlideInfo { id, rel_id });
                            }
                        }
                    }
                    Ok(quick_xml::events::Event::Eof) => break,
                    Err(e) => return Err(Error::XmlParse(e.to_string())),
                    _ => {}
                }
                buf.clear();
            }
        }

        Ok(slides)
    }

    /// Parse the presentation and return a Document model.
    pub fn parse(&mut self) -> Result<Document> {
        let mut doc = Document::new();

        // Parse metadata
        doc.metadata = self.parse_metadata()?;

        // Extract resources (images, media) and add to document
        let resources = self.extract_resources()?;
        for resource in resources {
            if let Some(ref filename) = resource.filename {
                doc.add_resource(filename.clone(), resource);
            }
        }

        // Parse each slide as a section
        for (idx, slide) in self.slides.clone().iter().enumerate() {
            let mut section = Section::new(idx);
            section.name = Some(format!("Slide {}", idx + 1));

            // Get the slide path from relationships
            if let Some(target) = self.relationships.get(&slide.rel_id) {
                let slide_path = if let Some(stripped) = target.strip_prefix('/') {
                    stripped.to_string()
                } else {
                    format!("ppt/{}", target)
                };

                // Parse slide-specific relationships for hyperlinks and images
                let slide_rels = self.parse_slide_relationships(&slide_path)?;

                if let Ok(xml) = self.container.read_xml(&slide_path) {
                    let blocks =
                        self.parse_slide_content_with_rels(&xml, &slide_rels, &slide_path)?;
                    for block in blocks {
                        section.add_block(block);
                    }
                }

                // Try to parse notes for this slide
                let notes_path = slide_path
                    .replace("slides/slide", "notesSlides/notesSlide")
                    .replace("slides\\slide", "notesSlides\\notesSlide");
                if let Ok(xml) = self.container.read_xml(&notes_path) {
                    // Parse notes relationships too
                    let notes_rels = self.parse_slide_relationships(&notes_path)?;
                    let notes = self.parse_notes_with_rels(&xml, &notes_rels)?;
                    if !notes.is_empty() {
                        section.notes = Some(notes);
                    }
                }
            }

            doc.add_section(section);
        }

        Ok(doc)
    }

    /// Parse relationships for a specific slide/notes file.
    fn parse_slide_relationships(&self, slide_path: &str) -> Result<HashMap<String, String>> {
        match self
            .container
            .read_optional_relationships_for_part(slide_path)
        {
            Ok(rels) => Ok(rels.into_targets_by_id()),
            Err(Error::XmlParseWithContext { .. }) => Ok(HashMap::new()),
            Err(err) => Err(err),
        }
    }

    /// Parse metadata from docProps/core.xml.
    fn parse_metadata(&self) -> Result<Metadata> {
        // Use shared metadata parsing from container
        let mut meta = self.container.parse_core_metadata()?;
        // Set slide count
        meta.page_count = Some(self.slides.len() as u32);
        Ok(meta)
    }

    /// Parse a slide XML into paragraphs (legacy, kept for compatibility).
    #[allow(dead_code)]
    fn parse_slide(&self, xml: &str) -> Result<Vec<Paragraph>> {
        self.parse_text_content(xml)
    }

    /// Parse slide XML into content blocks (paragraphs and tables).
    #[allow(dead_code)]
    fn parse_slide_content(&self, xml: &str) -> Result<Vec<Block>> {
        self.parse_slide_content_with_rels(xml, &HashMap::new(), "")
    }

    /// Parse slide XML into content blocks with relationship map for hyperlinks, images, and charts.
    fn parse_slide_content_with_rels(
        &self,
        xml: &str,
        rels: &HashMap<String, String>,
        slide_path: &str,
    ) -> Result<Vec<Block>> {
        let mut blocks = Vec::new();

        // Parse text content first (title, headings usually come before tables)
        let paragraphs = self.parse_text_content_excluding_tables_with_rels(xml, rels)?;
        for para in paragraphs {
            blocks.push(Block::Paragraph(para));
        }

        // Parse tables after text content
        let tables = self.parse_tables_with_rels(xml, rels)?;
        for table in tables {
            blocks.push(Block::Table(table));
        }

        // Parse charts and convert to tables for RAG-ready output
        let chart_tables = self.parse_charts(rels, slide_path)?;
        for table in chart_tables {
            blocks.push(Block::Table(table));
        }

        // Parse images (p:pic elements)
        let images = self.parse_images(xml, rels)?;
        for image in images {
            blocks.push(image);
        }

        Ok(blocks)
    }

    /// Parse images from slide XML.
    /// Images are in <p:pic> elements with <a:blip r:embed="rIdN"> referencing relationships.
    fn parse_images(&self, xml: &str, rels: &HashMap<String, String>) -> Result<Vec<Block>> {
        let mut images = Vec::new();
        let mut reader = quick_xml::Reader::from_str(xml);
        reader.config_mut().trim_text(true);

        let mut buf = Vec::new();
        let mut in_pic = false;
        let mut in_nvpicpr = false;
        let mut in_blipfill = false;
        let mut in_sppr = false;
        let mut current_name: Option<String> = None;
        let mut current_rel_id: Option<String> = None;
        let mut current_width: Option<u32> = None;
        let mut current_height: Option<u32> = None;

        loop {
            match reader.read_event_into(&mut buf) {
                Ok(quick_xml::events::Event::Start(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        // p:pic - picture element
                        b"pic" => {
                            in_pic = true;
                            current_name = None;
                            current_rel_id = None;
                            current_width = None;
                            current_height = None;
                        }
                        // p:nvPicPr - non-visual picture properties (contains name)
                        b"nvPicPr" if in_pic => {
                            in_nvpicpr = true;
                        }
                        // p:cNvPr - common non-visual properties (has name attribute)
                        b"cNvPr" if in_nvpicpr => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"name" {
                                    current_name =
                                        Some(String::from_utf8_lossy(&attr.value).to_string());
                                }
                            }
                        }
                        // p:blipFill - blip fill (contains the image reference)
                        b"blipFill" if in_pic => {
                            in_blipfill = true;
                        }
                        // a:blip - the actual image reference
                        b"blip" if in_blipfill => {
                            for attr in e.attributes().flatten() {
                                // r:embed attribute contains the relationship ID
                                if attr.key.local_name().as_ref() == b"embed" {
                                    current_rel_id =
                                        Some(String::from_utf8_lossy(&attr.value).to_string());
                                }
                            }
                        }
                        // p:spPr - shape properties (contains size)
                        b"spPr" if in_pic => {
                            in_sppr = true;
                        }
                        // a:ext - extent (size)
                        b"ext" if in_sppr => {
                            for attr in e.attributes().flatten() {
                                match attr.key.local_name().as_ref() {
                                    b"cx" => {
                                        if let Ok(cx) =
                                            String::from_utf8_lossy(&attr.value).parse::<u32>()
                                        {
                                            current_width = Some(cx);
                                        }
                                    }
                                    b"cy" => {
                                        if let Ok(cy) =
                                            String::from_utf8_lossy(&attr.value).parse::<u32>()
                                        {
                                            current_height = Some(cy);
                                        }
                                    }
                                    _ => {}
                                }
                            }
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Empty(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        // Handle self-closing cNvPr
                        b"cNvPr" if in_nvpicpr => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"name" {
                                    current_name =
                                        Some(String::from_utf8_lossy(&attr.value).to_string());
                                }
                            }
                        }
                        // Handle self-closing blip
                        b"blip" if in_blipfill => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"embed" {
                                    current_rel_id =
                                        Some(String::from_utf8_lossy(&attr.value).to_string());
                                }
                            }
                        }
                        // Handle self-closing ext
                        b"ext" if in_sppr => {
                            for attr in e.attributes().flatten() {
                                match attr.key.local_name().as_ref() {
                                    b"cx" => {
                                        if let Ok(cx) =
                                            String::from_utf8_lossy(&attr.value).parse::<u32>()
                                        {
                                            current_width = Some(cx);
                                        }
                                    }
                                    b"cy" => {
                                        if let Ok(cy) =
                                            String::from_utf8_lossy(&attr.value).parse::<u32>()
                                        {
                                            current_height = Some(cy);
                                        }
                                    }
                                    _ => {}
                                }
                            }
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::End(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        b"pic" => {
                            // Create image block if we have a valid relationship
                            if let Some(rel_id) = current_rel_id.take() {
                                if let Some(target) = rels.get(&rel_id) {
                                    // Extract filename from target path (e.g., "../media/image1.png" -> "image1.png")
                                    let filename =
                                        target.rsplit('/').next().unwrap_or(target).to_string();

                                    images.push(Block::Image {
                                        resource_id: filename,
                                        alt_text: current_name.take(),
                                        width: current_width.take(),
                                        height: current_height.take(),
                                    });
                                }
                            }
                            in_pic = false;
                        }
                        b"nvPicPr" => {
                            in_nvpicpr = false;
                        }
                        b"blipFill" => {
                            in_blipfill = false;
                        }
                        b"spPr" => {
                            in_sppr = false;
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Eof) => break,
                Err(e) => return Err(Error::XmlParse(e.to_string())),
                _ => {}
            }
            buf.clear();
        }

        Ok(images)
    }

    /// Parse charts referenced in slide relationships and convert to tables for RAG-ready output.
    /// Chart data is extracted from ppt/charts/chartN.xml files.
    fn parse_charts(&self, rels: &HashMap<String, String>, slide_path: &str) -> Result<Vec<Table>> {
        let mut tables = Vec::new();

        // Find chart relationships (target contains "chart")
        for (_rel_id, target) in rels.iter() {
            if !target.contains("chart") {
                continue;
            }

            // Resolve chart path relative to slide
            // Relationship target is like "../charts/chart1.xml"
            let chart_path = if let Some(stripped) = target.strip_prefix("../") {
                // Relative path from slide directory
                if let Some(last_slash) = slide_path.rfind('/') {
                    let slide_dir = &slide_path[..last_slash];
                    if let Some(parent_slash) = slide_dir.rfind('/') {
                        let parent_dir = &slide_dir[..parent_slash];
                        format!("{}/{}", parent_dir, stripped)
                    } else {
                        stripped.to_string()
                    }
                } else {
                    stripped.to_string()
                }
            } else if let Some(stripped) = target.strip_prefix('/') {
                stripped.to_string()
            } else {
                format!("ppt/{}", target)
            };

            // Read and parse chart XML
            if let Ok(chart_xml) = self.container.read_xml(&chart_path) {
                match charts::parse_chart_xml(&chart_xml) {
                    Ok(chart_data) => {
                        if !chart_data.is_empty() {
                            let mut table = chart_data.to_table();
                            // Add chart title as caption if available
                            if let Some(ref title) = chart_data.title {
                                if !title.is_empty() {
                                    // Update first header cell to include chart title
                                    if let Some(first_row) = table.rows.first_mut() {
                                        if let Some(first_cell) = first_row.cells.first_mut() {
                                            let original = first_cell.plain_text();
                                            first_cell.content.clear();
                                            first_cell.content.push(Paragraph::with_text(format!(
                                                "{} ({})",
                                                original, title
                                            )));
                                        }
                                    }
                                }
                            }
                            tables.push(table);
                        }
                    }
                    Err(_) => {
                        // Chart parsing failed, skip this chart
                        // In Phase 2, we would add a warning here
                    }
                }
            }
        }

        Ok(tables)
    }

    /// Parse notes slide XML into paragraphs.
    #[allow(dead_code)]
    fn parse_notes(&self, xml: &str) -> Result<Vec<Paragraph>> {
        self.parse_notes_with_rels(xml, &HashMap::new())
    }

    /// Parse notes slide XML into paragraphs with relationship map.
    fn parse_notes_with_rels(
        &self,
        xml: &str,
        rels: &HashMap<String, String>,
    ) -> Result<Vec<Paragraph>> {
        self.parse_text_content_with_rels(xml, rels)
    }

    /// Parse all tables from slide XML.
    #[allow(dead_code)]
    fn parse_tables(&self, xml: &str) -> Result<Vec<Table>> {
        self.parse_tables_with_rels(xml, &HashMap::new())
    }

    /// Parse all tables from slide XML with relationship map for hyperlinks.
    fn parse_tables_with_rels(
        &self,
        xml: &str,
        rels: &HashMap<String, String>,
    ) -> Result<Vec<Table>> {
        let mut tables = Vec::new();
        let mut reader = quick_xml::Reader::from_str(xml);
        // Don't trim text - preserve whitespace from xml:space="preserve" elements
        reader.config_mut().trim_text(false);

        let mut buf = Vec::new();
        let mut in_table = false;
        let mut in_row = false;
        let mut in_cell = false;
        let mut in_txbody = false;
        let mut in_paragraph = false;
        let mut in_run = false;
        let mut in_text = false;
        let mut in_rpr = false;

        let mut current_table = Table::new();
        let mut current_row = Row::new();
        let mut current_cell = Cell::new();
        let mut current_paragraphs: Vec<Paragraph> = Vec::new();
        let mut current_runs: Vec<TextRun> = Vec::new();
        let mut current_text = String::new();
        let mut current_style = TextStyle::default();
        let mut current_hyperlink: Option<String> = None;

        loop {
            match reader.read_event_into(&mut buf) {
                Ok(quick_xml::events::Event::Start(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        // a:tbl - table
                        b"tbl" => {
                            in_table = true;
                            current_table = Table::new();
                        }
                        // a:tr - table row
                        b"tr" if in_table => {
                            in_row = true;
                            current_row = Row::new();
                        }
                        // a:tc - table cell
                        b"tc" if in_row => {
                            in_cell = true;
                            current_cell = Cell::new();
                            current_paragraphs.clear();
                        }
                        // a:txBody - text body in cell
                        b"txBody" if in_cell => {
                            in_txbody = true;
                        }
                        // a:p - paragraph
                        b"p" if in_txbody => {
                            in_paragraph = true;
                            current_runs.clear();
                        }
                        // a:r - text run
                        b"r" if in_paragraph => {
                            in_run = true;
                            current_text.clear();
                            current_style = TextStyle::default();
                            current_hyperlink = None;
                        }
                        // a:t - text element
                        b"t" if in_run => {
                            in_text = true;
                        }
                        // a:rPr - run properties
                        b"rPr" if in_run => {
                            in_rpr = true;
                            for attr in e.attributes().flatten() {
                                match attr.key.local_name().as_ref() {
                                    b"b" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.bold = val != "0" && val != "false";
                                    }
                                    b"i" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.italic = val != "0" && val != "false";
                                    }
                                    _ => {}
                                }
                            }
                        }
                        // a:hlinkClick - hyperlink (nested in a:rPr)
                        b"hlinkClick" if in_rpr => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"id" {
                                    let rel_id = String::from_utf8_lossy(&attr.value);
                                    if let Some(url) = rels.get(rel_id.as_ref()) {
                                        current_hyperlink = Some(url.clone());
                                    }
                                }
                            }
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Empty(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        // Handle self-closing run properties
                        b"rPr" if in_run => {
                            for attr in e.attributes().flatten() {
                                match attr.key.local_name().as_ref() {
                                    b"b" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.bold = val != "0" && val != "false";
                                    }
                                    b"i" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.italic = val != "0" && val != "false";
                                    }
                                    _ => {}
                                }
                            }
                        }
                        // a:hlinkClick - hyperlink (self-closing)
                        b"hlinkClick" if in_run => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"id" {
                                    let rel_id = String::from_utf8_lossy(&attr.value);
                                    if let Some(url) = rels.get(rel_id.as_ref()) {
                                        current_hyperlink = Some(url.clone());
                                    }
                                }
                            }
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Text(ref e)) => {
                    if in_text {
                        let text = e.unescape().unwrap_or_default();
                        current_text.push_str(&text);
                    }
                }
                Ok(quick_xml::events::Event::End(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        b"t" => {
                            in_text = false;
                        }
                        b"rPr" => {
                            in_rpr = false;
                        }
                        b"r" => {
                            if !current_text.is_empty() {
                                current_runs.push(TextRun {
                                    text: current_text.clone(),
                                    style: current_style.clone(),
                                    hyperlink: current_hyperlink.clone(),
                                    line_break: false,
                                    page_break: false,
                                    revision: RevisionType::None,
                                });
                            }
                            in_run = false;
                            current_hyperlink = None;
                        }
                        b"p" if in_txbody => {
                            if !current_runs.is_empty() {
                                current_paragraphs.push(Paragraph {
                                    runs: current_runs.clone(),
                                    ..Default::default()
                                });
                            }
                            in_paragraph = false;
                        }
                        b"txBody" => {
                            in_txbody = false;
                        }
                        b"tc" => {
                            current_cell.content = current_paragraphs.clone();
                            current_row.add_cell(current_cell.clone());
                            in_cell = false;
                        }
                        b"tr" => {
                            if !current_row.is_empty() {
                                // Mark first row as header
                                if current_table.is_empty() {
                                    current_row.is_header = true;
                                }
                                current_table.add_row(current_row.clone());
                            }
                            in_row = false;
                        }
                        b"tbl" => {
                            if !current_table.is_empty() {
                                tables.push(current_table.clone());
                            }
                            in_table = false;
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Eof) => break,
                Err(e) => return Err(Error::XmlParse(e.to_string())),
                _ => {}
            }
            buf.clear();
        }

        Ok(tables)
    }

    /// Parse text content excluding tables (paragraphs from shapes, not table cells).
    #[allow(dead_code)]
    fn parse_text_content_excluding_tables(&self, xml: &str) -> Result<Vec<Paragraph>> {
        self.parse_text_content_excluding_tables_with_rels(xml, &HashMap::new())
    }

    /// Parse text content excluding tables with relationship map for hyperlinks.
    fn parse_text_content_excluding_tables_with_rels(
        &self,
        xml: &str,
        rels: &HashMap<String, String>,
    ) -> Result<Vec<Paragraph>> {
        let mut paragraphs = Vec::new();
        let mut reader = quick_xml::Reader::from_str(xml);
        // Don't trim text - preserve whitespace from xml:space="preserve" elements
        reader.config_mut().trim_text(false);

        let mut buf = Vec::new();
        let mut in_table = false;
        let mut table_depth = 0;
        let mut in_shape = false;
        let mut in_txbody = false;
        let mut in_paragraph = false;
        let mut in_run = false;
        let mut in_text = false;
        let mut in_rpr = false;
        let mut current_runs: Vec<TextRun> = Vec::new();
        let mut current_text = String::new();
        let mut current_style = TextStyle::default();
        let mut current_hyperlink: Option<String> = None;
        let mut current_heading: HeadingLevel = HeadingLevel::None;

        loop {
            match reader.read_event_into(&mut buf) {
                Ok(quick_xml::events::Event::Start(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        // Track table depth to skip table content
                        b"tbl" => {
                            in_table = true;
                            table_depth += 1;
                        }
                        // p:sp - shape (also matches inner shapes inside p:grpSp groups,
                        // because quick_xml's flat event stream processes nested elements
                        // the same as top-level ones by local name)
                        b"sp" if !in_table => {
                            in_shape = true;
                            current_heading = HeadingLevel::None;
                        }
                        // p:txBody - text body in shape
                        b"txBody" if in_shape && !in_table => {
                            in_txbody = true;
                        }
                        // a:p - paragraph (only if not in table, but in shape's txBody)
                        b"p" if !in_table && in_txbody => {
                            in_paragraph = true;
                            current_runs.clear();
                        }
                        // a:r - text run
                        b"r" if in_paragraph && !in_table => {
                            in_run = true;
                            current_text.clear();
                            current_style = TextStyle::default();
                            current_hyperlink = None;
                        }
                        // a:t - text element
                        b"t" if in_run && !in_table => {
                            in_text = true;
                        }
                        // a:rPr - run properties
                        b"rPr" if in_run && !in_table => {
                            in_rpr = true;
                            for attr in e.attributes().flatten() {
                                match attr.key.local_name().as_ref() {
                                    b"b" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.bold = val != "0" && val != "false";
                                    }
                                    b"i" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.italic = val != "0" && val != "false";
                                    }
                                    b"u" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.underline = val != "none";
                                    }
                                    b"strike" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.strikethrough =
                                            val != "noStrike" && val != "0" && val != "false";
                                    }
                                    _ => {}
                                }
                            }
                        }
                        // a:hlinkClick - hyperlink (nested in a:rPr)
                        b"hlinkClick" if in_rpr && !in_table => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"id" {
                                    let rel_id = String::from_utf8_lossy(&attr.value);
                                    if let Some(url) = rels.get(rel_id.as_ref()) {
                                        current_hyperlink = Some(url.clone());
                                    }
                                }
                            }
                        }
                        // p:ph - placeholder type (for heading detection)
                        b"ph" if in_shape && !in_table => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"type" {
                                    let ph_type = String::from_utf8_lossy(&attr.value);
                                    current_heading = match ph_type.as_ref() {
                                        "title" | "ctrTitle" => HeadingLevel::H1,
                                        "subTitle" => HeadingLevel::H2,
                                        "body" => HeadingLevel::None,
                                        _ => HeadingLevel::None,
                                    };
                                }
                            }
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Empty(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        // p:ph - placeholder type (self-closing)
                        b"ph" if in_shape && !in_table => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"type" {
                                    let ph_type = String::from_utf8_lossy(&attr.value);
                                    current_heading = match ph_type.as_ref() {
                                        "title" | "ctrTitle" => HeadingLevel::H1,
                                        "subTitle" => HeadingLevel::H2,
                                        "body" => HeadingLevel::None,
                                        _ => HeadingLevel::None,
                                    };
                                }
                            }
                        }
                        b"rPr" if in_run && !in_table => {
                            for attr in e.attributes().flatten() {
                                match attr.key.local_name().as_ref() {
                                    b"b" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.bold = val != "0" && val != "false";
                                    }
                                    b"i" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.italic = val != "0" && val != "false";
                                    }
                                    b"u" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.underline = val != "none";
                                    }
                                    b"strike" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.strikethrough =
                                            val != "noStrike" && val != "0" && val != "false";
                                    }
                                    _ => {}
                                }
                            }
                        }
                        // a:hlinkClick - hyperlink (self-closing)
                        b"hlinkClick" if in_run && !in_table => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"id" {
                                    let rel_id = String::from_utf8_lossy(&attr.value);
                                    if let Some(url) = rels.get(rel_id.as_ref()) {
                                        current_hyperlink = Some(url.clone());
                                    }
                                }
                            }
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Text(ref e)) => {
                    if in_text && !in_table {
                        let text = e.unescape().unwrap_or_default();
                        current_text.push_str(&text);
                    }
                }
                Ok(quick_xml::events::Event::End(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        b"tbl" => {
                            table_depth -= 1;
                            if table_depth == 0 {
                                in_table = false;
                            }
                        }
                        b"t" if !in_table => {
                            in_text = false;
                        }
                        b"rPr" if !in_table => {
                            in_rpr = false;
                        }
                        b"r" if !in_table => {
                            if !current_text.is_empty() {
                                current_runs.push(TextRun {
                                    text: current_text.clone(),
                                    style: current_style.clone(),
                                    hyperlink: current_hyperlink.clone(),
                                    line_break: false,
                                    page_break: false,
                                    revision: RevisionType::None,
                                });
                            }
                            in_run = false;
                            current_hyperlink = None;
                        }
                        b"p" if !in_table => {
                            if !current_runs.is_empty() {
                                paragraphs.push(Paragraph {
                                    runs: current_runs.clone(),
                                    heading: current_heading,
                                    ..Default::default()
                                });
                            }
                            in_paragraph = false;
                        }
                        b"txBody" if !in_table => {
                            in_txbody = false;
                        }
                        b"sp" if !in_table => {
                            in_shape = false;
                            current_heading = HeadingLevel::None;
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Eof) => break,
                Err(e) => return Err(Error::XmlParse(e.to_string())),
                _ => {}
            }
            buf.clear();
        }

        Ok(paragraphs)
    }

    /// Parse text content from slide or notes XML.
    /// Text is found in: p:sp/p:txBody/a:p/a:r/a:t
    #[allow(dead_code)]
    fn parse_text_content(&self, xml: &str) -> Result<Vec<Paragraph>> {
        self.parse_text_content_with_rels(xml, &HashMap::new())
    }

    /// Parse text content from slide or notes XML with relationship map for hyperlinks.
    fn parse_text_content_with_rels(
        &self,
        xml: &str,
        rels: &HashMap<String, String>,
    ) -> Result<Vec<Paragraph>> {
        let mut paragraphs = Vec::new();
        let mut reader = quick_xml::Reader::from_str(xml);
        // Don't trim text - preserve whitespace from xml:space="preserve" elements
        reader.config_mut().trim_text(false);

        let mut buf = Vec::new();
        let mut in_paragraph = false;
        let mut in_run = false;
        let mut in_text = false;
        let mut in_rpr = false;
        let mut current_runs: Vec<TextRun> = Vec::new();
        let mut current_text = String::new();
        let mut current_style = TextStyle::default();
        let mut current_hyperlink: Option<String> = None;

        loop {
            match reader.read_event_into(&mut buf) {
                Ok(quick_xml::events::Event::Start(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        // a:p - paragraph
                        b"p" => {
                            in_paragraph = true;
                            current_runs.clear();
                        }
                        // a:r - text run
                        b"r" if in_paragraph => {
                            in_run = true;
                            current_text.clear();
                            current_style = TextStyle::default();
                            current_hyperlink = None;
                        }
                        // a:t - text element
                        b"t" if in_run => {
                            in_text = true;
                        }
                        // a:rPr - run properties
                        b"rPr" if in_run => {
                            in_rpr = true;
                            // Parse run properties for styling
                            for attr in e.attributes().flatten() {
                                match attr.key.local_name().as_ref() {
                                    b"b" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.bold = val != "0" && val != "false";
                                    }
                                    b"i" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.italic = val != "0" && val != "false";
                                    }
                                    b"u" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.underline = val != "none";
                                    }
                                    b"strike" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.strikethrough =
                                            val != "noStrike" && val != "0" && val != "false";
                                    }
                                    _ => {}
                                }
                            }
                        }
                        // a:hlinkClick - hyperlink (nested in a:rPr)
                        b"hlinkClick" if in_rpr => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"id" {
                                    let rel_id = String::from_utf8_lossy(&attr.value);
                                    if let Some(url) = rels.get(rel_id.as_ref()) {
                                        current_hyperlink = Some(url.clone());
                                    }
                                }
                            }
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Empty(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        // Handle self-closing run properties
                        b"rPr" if in_run => {
                            for attr in e.attributes().flatten() {
                                match attr.key.local_name().as_ref() {
                                    b"b" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.bold = val != "0" && val != "false";
                                    }
                                    b"i" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.italic = val != "0" && val != "false";
                                    }
                                    b"u" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.underline = val != "none";
                                    }
                                    b"strike" => {
                                        let val = String::from_utf8_lossy(&attr.value);
                                        current_style.strikethrough =
                                            val != "noStrike" && val != "0" && val != "false";
                                    }
                                    _ => {}
                                }
                            }
                        }
                        // a:hlinkClick - hyperlink (self-closing)
                        b"hlinkClick" if in_run => {
                            for attr in e.attributes().flatten() {
                                if attr.key.local_name().as_ref() == b"id" {
                                    let rel_id = String::from_utf8_lossy(&attr.value);
                                    if let Some(url) = rels.get(rel_id.as_ref()) {
                                        current_hyperlink = Some(url.clone());
                                    }
                                }
                            }
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Text(ref e)) => {
                    if in_text {
                        let text = e.unescape().unwrap_or_default();
                        current_text.push_str(&text);
                    }
                }
                Ok(quick_xml::events::Event::End(ref e)) => {
                    let local_name = e.name().local_name();
                    match local_name.as_ref() {
                        b"t" => {
                            in_text = false;
                        }
                        b"rPr" => {
                            in_rpr = false;
                        }
                        b"r" => {
                            if !current_text.is_empty() {
                                current_runs.push(TextRun {
                                    text: current_text.clone(),
                                    style: current_style.clone(),
                                    hyperlink: current_hyperlink.clone(),
                                    line_break: false,
                                    page_break: false,
                                    revision: RevisionType::None,
                                });
                            }
                            in_run = false;
                            current_hyperlink = None;
                        }
                        b"p" => {
                            // Only add non-empty paragraphs
                            if !current_runs.is_empty() {
                                paragraphs.push(Paragraph {
                                    runs: current_runs.clone(),
                                    ..Default::default()
                                });
                            }
                            in_paragraph = false;
                        }
                        _ => {}
                    }
                }
                Ok(quick_xml::events::Event::Eof) => break,
                Err(e) => return Err(Error::XmlParse(e.to_string())),
                _ => {}
            }
            buf.clear();
        }

        Ok(paragraphs)
    }

    /// Extract resources (images, media) from the presentation.
    pub fn extract_resources(&self) -> Result<Vec<Resource>> {
        let mut resources = Vec::new();

        // Look for media files in ppt/media/
        for file in self.container.list_files() {
            if file.starts_with("ppt/media/") {
                if let Ok(data) = self.container.read_binary(&file) {
                    let filename = file.rsplit('/').next().unwrap_or(&file).to_string();
                    let ext = std::path::Path::new(&file)
                        .extension()
                        .and_then(|e| e.to_str())
                        .unwrap_or("");
                    let size = data.len();

                    resources.push(Resource {
                        resource_type: ResourceType::from_extension(ext),
                        filename: Some(filename),
                        mime_type: guess_mime_type(&file),
                        data,
                        size,
                        width: None,
                        height: None,
                        alt_text: None,
                    });
                }
            }
        }

        Ok(resources)
    }

    /// Get a reference to the container.
    pub fn container(&self) -> &OoxmlContainer {
        &self.container
    }

    /// Get the number of slides.
    pub fn slide_count(&self) -> usize {
        self.slides.len()
    }
}

/// Guess MIME type from file extension.
fn guess_mime_type(path: &str) -> Option<String> {
    let ext = path.rsplit('.').next()?.to_lowercase();
    match ext.as_str() {
        "png" => Some("image/png".to_string()),
        "jpg" | "jpeg" => Some("image/jpeg".to_string()),
        "gif" => Some("image/gif".to_string()),
        "bmp" => Some("image/bmp".to_string()),
        "tiff" | "tif" => Some("image/tiff".to_string()),
        "webp" => Some("image/webp".to_string()),
        "svg" => Some("image/svg+xml".to_string()),
        "emf" => Some("image/x-emf".to_string()),
        "wmf" => Some("image/x-wmf".to_string()),
        "mp3" => Some("audio/mpeg".to_string()),
        "wav" => Some("audio/wav".to_string()),
        "mp4" => Some("video/mp4".to_string()),
        "avi" => Some("video/x-msvideo".to_string()),
        "wmv" => Some("video/x-ms-wmv".to_string()),
        _ => None,
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_open_pptx() {
        let path = "test-files/file_example_PPT_1MB.pptx";
        if std::path::Path::new(path).exists() {
            let parser = PptxParser::open(path);
            assert!(parser.is_ok());
        }
    }

    #[test]
    fn test_parse_pptx() {
        let path = "test-files/file_example_PPT_1MB.pptx";
        if std::path::Path::new(path).exists() {
            let mut parser = PptxParser::open(path).unwrap();
            let doc = parser.parse().unwrap();

            // Should have at least one section (slide)
            assert!(!doc.sections.is_empty());
            println!("Parsed {} slides", doc.sections.len());

            // Check metadata has slide count
            assert!(doc.metadata.page_count.is_some());
        }
    }

    #[test]
    fn test_slide_count() {
        let path = "test-files/file_example_PPT_1MB.pptx";
        if std::path::Path::new(path).exists() {
            let parser = PptxParser::open(path).unwrap();
            let count = parser.slide_count();
            assert!(count > 0);
            println!("Slide count: {}", count);
        }
    }

    #[test]
    fn test_extract_text() {
        let path = "test-files/file_example_PPT_1MB.pptx";
        if std::path::Path::new(path).exists() {
            let mut parser = PptxParser::open(path).unwrap();
            let doc = parser.parse().unwrap();
            let text = doc.plain_text();

            // Should have some text content
            assert!(!text.trim().is_empty());
            println!("Extracted text length: {} chars", text.len());
            println!("First 500 chars:\n{}", &text[..text.len().min(500)]);
        }
    }

    #[test]
    fn test_extract_resources() {
        let path = "test-files/file_example_PPT_1MB.pptx";
        if std::path::Path::new(path).exists() {
            let parser = PptxParser::open(path).unwrap();
            let resources = parser.extract_resources().unwrap();

            println!("Found {} resources", resources.len());
            for res in &resources {
                println!(
                    "  - {:?}: {} ({} bytes)",
                    res.resource_type,
                    res.filename.as_deref().unwrap_or("unnamed"),
                    res.size
                );
            }
        }
    }

    #[test]
    fn test_parse_text_content() {
        // Test XML parsing directly
        let _xml = r#"<?xml version="1.0"?>
<p:sld xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main"
       xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main">
  <p:cSld>
    <p:spTree>
      <p:sp>
        <p:txBody>
          <a:p>
            <a:r>
              <a:t>Hello World</a:t>
            </a:r>
          </a:p>
          <a:p>
            <a:r>
              <a:rPr b="1"/>
              <a:t>Bold Text</a:t>
            </a:r>
          </a:p>
        </p:txBody>
      </p:sp>
    </p:spTree>
  </p:cSld>
</p:sld>"#;

        let container = OoxmlContainer::from_bytes(Vec::new());
        // Can't test fully without a real container, but we can test the parse logic
        // by creating a minimal parser
        if container.is_ok() {
            // Just verify XML parsing logic compiles
        }
    }

    #[test]
    fn test_metadata() {
        let path = "test-files/file_example_PPT_1MB.pptx";
        if std::path::Path::new(path).exists() {
            let mut parser = PptxParser::open(path).unwrap();
            let doc = parser.parse().unwrap();

            println!("Title: {:?}", doc.metadata.title);
            println!("Author: {:?}", doc.metadata.author);
            println!("Page count: {:?}", doc.metadata.page_count);
        }
    }

    #[test]
    fn test_parse_tables() {
        let path = "test-files/file_example_PPT_1MB.pptx";
        if std::path::Path::new(path).exists() {
            let mut parser = PptxParser::open(path).unwrap();
            let doc = parser.parse().unwrap();

            // Find tables in the document
            let mut table_count = 0;
            for section in &doc.sections {
                for block in &section.content {
                    if let Block::Table(table) = block {
                        table_count += 1;
                        println!(
                            "Found table in {}: {} rows, {} cols",
                            section.name.as_deref().unwrap_or("unnamed"),
                            table.row_count(),
                            table.column_count()
                        );
                        // Print table content
                        for (i, row) in table.rows.iter().enumerate() {
                            let cells: Vec<String> =
                                row.cells.iter().map(|c| c.plain_text()).collect();
                            println!("  Row {}: {:?}", i, cells);
                        }
                    }
                }
            }
            println!("Total tables found: {}", table_count);
            // The test file should have at least one table (Slide 3)
            assert!(table_count > 0, "Expected at least one table in the PPTX");
        }
    }

    #[test]
    fn test_parse_hyperlinks() {
        let path = "test-files/officedissector/test/govdocs/036279.pptx";
        if std::path::Path::new(path).exists() {
            let mut parser = PptxParser::open(path).unwrap();
            let doc = parser.parse().unwrap();

            // Find hyperlinks in the document
            let mut hyperlink_count = 0;
            let mut found_email = false;
            for section in &doc.sections {
                for block in &section.content {
                    if let Block::Paragraph(para) = block {
                        for run in &para.runs {
                            if let Some(ref link) = run.hyperlink {
                                hyperlink_count += 1;
                                println!("Found hyperlink: {} -> {}", run.text, link);
                                if link.contains("ncicb@pop.nci.nih.gov") {
                                    found_email = true;
                                }
                            }
                        }
                    }
                }
            }
            println!("Total hyperlinks found: {}", hyperlink_count);
            assert!(hyperlink_count > 0, "Expected at least one hyperlink");
            assert!(
                found_email,
                "Expected to find email link ncicb@pop.nci.nih.gov"
            );
        }
    }

    /// Helper to create a minimal PPTX in memory with given slide XML content.
    fn create_minimal_pptx(slide_xml: &str) -> Vec<u8> {
        create_minimal_pptx_with_relationships(
            slide_xml,
            Some(
                r#"<?xml version="1.0" encoding="UTF-8"?>
<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships">
  <Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/slide" Target="slides/slide1.xml"/>
</Relationships>"#,
            ),
            Some(
                r#"<?xml version="1.0" encoding="UTF-8"?>
<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships">
</Relationships>"#,
            ),
        )
    }

    fn create_minimal_pptx_with_relationships(
        slide_xml: &str,
        presentation_rels_xml: Option<&str>,
        slide_rels_xml: Option<&str>,
    ) -> Vec<u8> {
        use std::io::{Cursor, Write};
        let buf = Cursor::new(Vec::new());
        let mut zip = zip::ZipWriter::new(buf);
        let options = zip::write::SimpleFileOptions::default()
            .compression_method(zip::CompressionMethod::Stored);

        // [Content_Types].xml
        zip.start_file("[Content_Types].xml", options).unwrap();
        zip.write_all(br#"<?xml version="1.0" encoding="UTF-8"?>
<Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types">
  <Default Extension="rels" ContentType="application/vnd.openxmlformats-package.relationships+xml"/>
  <Default Extension="xml" ContentType="application/xml"/>
  <Override PartName="/ppt/presentation.xml" ContentType="application/vnd.openxmlformats-officedocument.presentationml.presentation.main+xml"/>
  <Override PartName="/ppt/slides/slide1.xml" ContentType="application/vnd.openxmlformats-officedocument.presentationml.slide+xml"/>
</Types>"#).unwrap();

        // _rels/.rels
        zip.start_file("_rels/.rels", options).unwrap();
        zip.write_all(br#"<?xml version="1.0" encoding="UTF-8"?>
<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships">
  <Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument" Target="ppt/presentation.xml"/>
</Relationships>"#).unwrap();

        if let Some(presentation_rels_xml) = presentation_rels_xml {
            // ppt/_rels/presentation.xml.rels
            zip.start_file("ppt/_rels/presentation.xml.rels", options)
                .unwrap();
            zip.write_all(presentation_rels_xml.as_bytes()).unwrap();
        }

        // ppt/presentation.xml
        zip.start_file("ppt/presentation.xml", options).unwrap();
        zip.write_all(
            br#"<?xml version="1.0" encoding="UTF-8"?>
<p:presentation xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main"
                xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships">
  <p:sldIdLst>
    <p:sldId id="256" r:id="rId1"/>
  </p:sldIdLst>
</p:presentation>"#,
        )
        .unwrap();

        if let Some(slide_rels_xml) = slide_rels_xml {
            // ppt/slides/_rels/slide1.xml.rels
            zip.start_file("ppt/slides/_rels/slide1.xml.rels", options)
                .unwrap();
            zip.write_all(slide_rels_xml.as_bytes()).unwrap();
        }

        // ppt/slides/slide1.xml
        zip.start_file("ppt/slides/slide1.xml", options).unwrap();
        zip.write_all(slide_xml.as_bytes()).unwrap();

        zip.finish().unwrap().into_inner()
    }

    #[test]
    fn test_pptx_requires_presentation_relationships() {
        let slide_xml = r#"<?xml version="1.0" encoding="UTF-8"?>
<p:sld xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main"
       xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main"/>"#;

        let data = create_minimal_pptx_with_relationships(slide_xml, None, None);
        let err = PptxParser::from_bytes(data)
            .err()
            .expect("missing presentation relationships should fail");

        match err {
            Error::MissingComponent(path) => assert_eq!(path, "ppt/_rels/presentation.xml.rels"),
            other => panic!("expected missing presentation rels error, got {other:?}"),
        }
    }

    #[test]
    fn test_pptx_rejects_malformed_presentation_relationships() {
        let slide_xml = r#"<?xml version="1.0" encoding="UTF-8"?>
<p:sld xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main"
       xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main"/>"#;

        let data = create_minimal_pptx_with_relationships(slide_xml, Some("<Relationships"), None);
        let err = PptxParser::from_bytes(data)
            .err()
            .expect("malformed presentation relationships should fail");

        match err {
            Error::XmlParseWithContext { location, .. } => {
                assert_eq!(location, "ppt/_rels/presentation.xml.rels")
            }
            other => panic!("expected malformed presentation rels error, got {other:?}"),
        }
    }

    #[test]
    fn test_pptx_allows_missing_optional_slide_relationships() {
        let slide_xml = r#"<?xml version="1.0" encoding="UTF-8"?>
<p:sld xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main"
       xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main">
  <p:cSld><p:spTree/></p:cSld>
</p:sld>"#;

        let data = create_minimal_pptx_with_relationships(
            slide_xml,
            Some(
                r#"<?xml version="1.0" encoding="UTF-8"?>
<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships">
  <Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/slide" Target="slides/slide1.xml"></Relationship>
</Relationships>"#,
            ),
            None,
        );
        let mut parser = PptxParser::from_bytes(data).unwrap();
        let doc = parser.parse().unwrap();

        assert_eq!(doc.sections.len(), 1);
    }

    #[test]
    fn test_pptx_best_effort_on_malformed_optional_slide_relationships() {
        let slide_xml = r#"<?xml version="1.0" encoding="UTF-8"?>
<p:sld xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main"
       xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main">
  <p:cSld>
    <p:spTree>
      <p:sp>
        <p:txBody>
          <a:p><a:r><a:t>Hello from slide</a:t></a:r></a:p>
        </p:txBody>
      </p:sp>
    </p:spTree>
  </p:cSld>
</p:sld>"#;

        let data = create_minimal_pptx_with_relationships(
            slide_xml,
            Some(
                r#"<?xml version="1.0" encoding="UTF-8"?>
<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships">
  <Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/slide" Target="slides/slide1.xml"/>
</Relationships>"#,
            ),
            Some("<Relationships"),
        );
        let mut parser = PptxParser::from_bytes(data).unwrap();
        let doc = parser.parse().unwrap();

        assert_eq!(doc.sections.len(), 1);
        assert_eq!(doc.plain_text(), "Hello from slide");
    }

    #[test]
    fn test_parse_grouped_shapes() {
        let slide_xml = r#"<?xml version="1.0" encoding="UTF-8"?>
<p:sld xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main"
       xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main"
       xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships">
  <p:cSld>
    <p:spTree>
      <p:sp>
        <p:txBody>
          <a:p><a:r><a:t>Top level shape</a:t></a:r></a:p>
        </p:txBody>
      </p:sp>
      <p:grpSp>
        <p:nvGrpSpPr>
          <p:cNvPr id="10" name="Group 1"/>
          <p:cNvGrpSpPr/>
          <p:nvPr/>
        </p:nvGrpSpPr>
        <p:grpSpPr/>
        <p:sp>
          <p:txBody>
            <a:p><a:r><a:t>Grouped shape 1</a:t></a:r></a:p>
          </p:txBody>
        </p:sp>
        <p:sp>
          <p:txBody>
            <a:p><a:r><a:t>Grouped shape 2</a:t></a:r></a:p>
          </p:txBody>
        </p:sp>
      </p:grpSp>
    </p:spTree>
  </p:cSld>
</p:sld>"#;

        let data = create_minimal_pptx(slide_xml);
        let mut parser = PptxParser::from_bytes(data).unwrap();
        let doc = parser.parse().unwrap();
        let text = doc.plain_text();

        assert!(
            text.contains("Top level shape"),
            "Should contain top-level shape text, got: {}",
            text
        );
        assert!(
            text.contains("Grouped shape 1"),
            "Should contain first grouped shape text, got: {}",
            text
        );
        assert!(
            text.contains("Grouped shape 2"),
            "Should contain second grouped shape text, got: {}",
            text
        );
    }

    #[test]
    fn test_parse_nested_grouped_shapes() {
        let slide_xml = r#"<?xml version="1.0" encoding="UTF-8"?>
<p:sld xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main"
       xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main"
       xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships">
  <p:cSld>
    <p:spTree>
      <p:grpSp>
        <p:nvGrpSpPr><p:cNvPr id="10" name="Outer Group"/><p:cNvGrpSpPr/><p:nvPr/></p:nvGrpSpPr>
        <p:grpSpPr/>
        <p:sp>
          <p:txBody>
            <a:p><a:r><a:t>Outer group text</a:t></a:r></a:p>
          </p:txBody>
        </p:sp>
        <p:grpSp>
          <p:nvGrpSpPr><p:cNvPr id="20" name="Inner Group"/><p:cNvGrpSpPr/><p:nvPr/></p:nvGrpSpPr>
          <p:grpSpPr/>
          <p:sp>
            <p:txBody>
              <a:p><a:r><a:t>Inner group text</a:t></a:r></a:p>
            </p:txBody>
          </p:sp>
        </p:grpSp>
      </p:grpSp>
    </p:spTree>
  </p:cSld>
</p:sld>"#;

        let data = create_minimal_pptx(slide_xml);
        let mut parser = PptxParser::from_bytes(data).unwrap();
        let doc = parser.parse().unwrap();
        let text = doc.plain_text();

        assert!(
            text.contains("Outer group text"),
            "Should contain outer group shape text, got: {}",
            text
        );
        assert!(
            text.contains("Inner group text"),
            "Should contain inner (nested) group shape text, got: {}",
            text
        );
    }

    #[test]
    fn test_parse_headings() {
        use crate::model::HeadingLevel;

        let path = "test-files/file_example_PPT_1MB.pptx";
        if std::path::Path::new(path).exists() {
            let mut parser = PptxParser::open(path).unwrap();
            let doc = parser.parse().unwrap();

            // Find headings in the document
            let mut h1_count = 0;
            let mut h2_count = 0;
            let mut found_lorem = false;
            for section in &doc.sections {
                for block in &section.content {
                    if let Block::Paragraph(para) = block {
                        let text = para.plain_text();
                        match para.heading {
                            HeadingLevel::H1 => {
                                h1_count += 1;
                                println!("Found H1: {}", text);
                                if text.contains("Lorem ipsum") {
                                    found_lorem = true;
                                }
                            }
                            HeadingLevel::H2 => {
                                h2_count += 1;
                                println!("Found H2: {}", text);
                            }
                            _ => {}
                        }
                    }
                }
            }
            println!("Total H1: {}, H2: {}", h1_count, h2_count);
            assert!(h1_count > 0, "Expected at least one H1 heading (title)");
            assert!(found_lorem, "Expected to find 'Lorem ipsum' as H1 title");
        }
    }
}