1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299
use borsh::{BorshDeserialize, BorshSerialize};
use unc_crypto::{Signature, Signer};
use unc_primitives_core::hash::hash;
use unc_primitives_core::types::AccountId;
// These numbers are picked to be compatible with the current protocol and how
// transactions are defined in it. Introducing this is no protocol change. This
// is just a forward-looking implementation detail of meta transactions.
//
// We plan to establish a standard with NEP-461 that makes this an official
// specification in the wider ecosystem. Note that NEP-461 should not change the
// protocol in any way, unless we have to change meta transaction implementation
// details to adhere to the future standard.
// [NEP-461](https://github.com/Utility/UEPs/pull/461)
//
// TODO: consider making these public once there is an approved standard.
const MIN_ON_CHAIN_DISCRIMINANT: u32 = 1 << 30;
const MAX_ON_CHAIN_DISCRIMINANT: u32 = (1 << 31) - 1;
const MIN_OFF_CHAIN_DISCRIMINANT: u32 = 1 << 31;
const MAX_OFF_CHAIN_DISCRIMINANT: u32 = u32::MAX;
// UEPs currently included in the scheme
const NEP_366_META_TRANSACTIONS: u32 = 366;
/// Used to distinguish message types that are sign by account keys, to avoid an
/// abuse of signed messages as something else.
///
/// This prefix must be be at the first four bytes of a message body that is
/// signed under this signature scheme.
///
/// The scheme is a draft introduced to avoid security issues with the
/// implementation of meta transactions (NEP-366) but will eventually be
/// standardized with NEP-461 that solves the problem more generally.
#[derive(
Debug,
Clone,
Copy,
PartialEq,
Eq,
PartialOrd,
Ord,
Hash,
BorshSerialize,
BorshDeserialize,
serde::Serialize,
serde::Deserialize,
)]
pub struct MessageDiscriminant {
/// The unique prefix, serialized in little-endian by borsh.
discriminant: u32,
}
/// A wrapper around a message that should be signed using this scheme.
///
/// Only used for constructing a signature, not used to transmit messages. The
/// discriminant prefix is implicit and should be known by the receiver based on
/// the context in which the message is received.
#[derive(BorshSerialize)]
pub struct SignableMessage<'a, T> {
pub discriminant: MessageDiscriminant,
pub msg: &'a T,
}
#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]
#[non_exhaustive]
pub enum SignableMessageType {
/// A delegate action, intended for a relayer to included it in an action list of a transaction.
DelegateAction,
}
#[derive(thiserror::Error, Debug)]
#[non_exhaustive]
pub enum ReadDiscriminantError {
#[error("does not fit any known categories")]
UnknownMessageType,
#[error("NEP {0} does not have a known on-chain use")]
UnknownOnChainNep(u32),
#[error("NEP {0} does not have a known off-chain use")]
UnknownOffChainNep(u32),
#[error("discriminant is in the range for transactions")]
TransactionFound,
}
#[derive(thiserror::Error, Debug)]
#[non_exhaustive]
pub enum CreateDiscriminantError {
#[error("nep number {0} is too big")]
NepTooLarge(u32),
}
impl<'a, T: BorshSerialize> SignableMessage<'a, T> {
pub fn new(msg: &'a T, ty: SignableMessageType) -> Self {
let discriminant = ty.into();
Self { discriminant, msg }
}
pub fn sign(&self, signer: &dyn Signer) -> Signature {
let bytes = borsh::to_vec(&self).expect("Failed to deserialize");
let hash = hash(&bytes);
signer.sign(hash.as_bytes())
}
}
impl MessageDiscriminant {
/// Create a discriminant for an on-chain actionable message that was introduced in the specified NEP.
///
/// Allows creating discriminants currently unknown in this crate, which can
/// be useful to prototype new standards. For example, when the client
/// project still relies on an older version of this crate while nightly
/// framework already supports a new NEP.
pub fn new_on_chain(nep: u32) -> Result<Self, CreateDiscriminantError> {
// unchecked arithmetic: these are constants
if nep > MAX_ON_CHAIN_DISCRIMINANT - MIN_ON_CHAIN_DISCRIMINANT {
Err(CreateDiscriminantError::NepTooLarge(nep))
} else {
Ok(Self {
// unchecked arithmetic: just checked range
discriminant: MIN_ON_CHAIN_DISCRIMINANT + nep,
})
}
}
/// Create a discriminant for an off-chain message that was introduced in the specified NEP.
///
/// Allows creating discriminants currently unknown in this crate, which can
/// be useful to prototype new standards. For example, when the client
/// project still relies on an older version of this crate while nightly
/// framework already supports a new NEP.
pub fn new_off_chain(nep: u32) -> Result<Self, CreateDiscriminantError> {
// unchecked arithmetic: these are constants
if nep > MAX_OFF_CHAIN_DISCRIMINANT - MIN_OFF_CHAIN_DISCRIMINANT {
Err(CreateDiscriminantError::NepTooLarge(nep))
} else {
Ok(Self {
// unchecked arithmetic: just checked range
discriminant: MIN_OFF_CHAIN_DISCRIMINANT + nep,
})
}
}
/// Returns the raw integer value of the discriminant as an integer value.
pub fn raw_discriminant(&self) -> u32 {
self.discriminant
}
/// Whether this discriminant marks a traditional `SignedTransaction`.
pub fn is_transaction(&self) -> bool {
// Backwards compatibility with transaction that were defined before this standard:
// Transaction begins with `AccountId`, which is just a `String` in
// borsh serialization, which starts with the length of the underlying
// byte vector in little endian u32.
// Currently allowed AccountIds are between 2 and 64 bytes.
self.discriminant >= AccountId::MIN_LEN as u32
&& self.discriminant <= AccountId::MAX_LEN as u32
}
/// If this discriminant marks a message intended for on-chain use, return
/// the NEP in which the message type was introduced.
pub fn on_chain_nep(&self) -> Option<u32> {
if self.discriminant < MIN_ON_CHAIN_DISCRIMINANT
|| self.discriminant > MAX_ON_CHAIN_DISCRIMINANT
{
None
} else {
// unchecked arithmetic: just checked it is in range
let nep = self.discriminant - MIN_ON_CHAIN_DISCRIMINANT;
Some(nep)
}
}
/// If this discriminant marks a message intended for off-chain use, return
/// the NEP in which the message type was introduced.
///
/// clippy: MAX_OFF_CHAIN_DISCRIMINANT currently is u32::MAX which makes the
/// comparison pointless, however I think it helps code readability to have
/// it spelled out anyway
#[allow(clippy::absurd_extreme_comparisons)]
pub fn off_chain_nep(&self) -> Option<u32> {
if self.discriminant < MIN_OFF_CHAIN_DISCRIMINANT
|| self.discriminant > MAX_OFF_CHAIN_DISCRIMINANT
{
None
} else {
// unchecked arithmetic: just checked it is in range
let nep = self.discriminant - MIN_OFF_CHAIN_DISCRIMINANT;
Some(nep)
}
}
}
impl TryFrom<MessageDiscriminant> for SignableMessageType {
type Error = ReadDiscriminantError;
fn try_from(discriminant: MessageDiscriminant) -> Result<Self, Self::Error> {
if discriminant.is_transaction() {
Err(Self::Error::TransactionFound)
} else if let Some(nep) = discriminant.on_chain_nep() {
match nep {
NEP_366_META_TRANSACTIONS => Ok(Self::DelegateAction),
_ => Err(Self::Error::UnknownOnChainNep(nep)),
}
} else if let Some(nep) = discriminant.off_chain_nep() {
Err(Self::Error::UnknownOffChainNep(nep))
} else {
Err(Self::Error::UnknownMessageType)
}
}
}
impl From<SignableMessageType> for MessageDiscriminant {
fn from(ty: SignableMessageType) -> Self {
// unwrapping here is ok, we know the constant NEP numbers used are in range
match ty {
SignableMessageType::DelegateAction => {
MessageDiscriminant::new_on_chain(NEP_366_META_TRANSACTIONS).unwrap()
}
}
}
}
#[cfg(test)]
mod tests {
use unc_crypto::{InMemorySigner, KeyType, PublicKey};
use unc_primitives_core::account::id::AccountIdRef;
use super::*;
use crate::action::delegate::{DelegateAction, SignedDelegateAction};
// Note: this is currently a simplified copy of unc-primitives::test_utils::create_user_test_signer
// TODO: consider whether it’s worth re-unifying them? it’s test-only code anyway.
fn create_user_test_signer(account_id: &AccountIdRef) -> InMemorySigner {
InMemorySigner::from_seed(account_id.to_owned(), KeyType::ED25519, account_id.as_str())
}
// happy path for NEP-366 signature
#[test]
fn nep_366_ok() {
let sender_id: AccountId = "alice.unc".parse().unwrap();
let receiver_id: AccountId = "bob.unc".parse().unwrap();
let signer = create_user_test_signer(&sender_id);
let delegate_action = delegate_action(sender_id, receiver_id, signer.public_key());
let signable = SignableMessage::new(&delegate_action, SignableMessageType::DelegateAction);
let signed = SignedDelegateAction { signature: signable.sign(&signer), delegate_action };
assert!(signed.verify());
}
// Try to use a wrong nep number in NEP-366 signature verification.
#[test]
fn nep_366_wrong_nep() {
let sender_id: AccountId = "alice.unc".parse().unwrap();
let receiver_id: AccountId = "bob.unc".parse().unwrap();
let signer = create_user_test_signer(&sender_id);
let delegate_action = delegate_action(sender_id, receiver_id, signer.public_key());
let wrong_nep = 777;
let signable = SignableMessage {
discriminant: MessageDiscriminant::new_on_chain(wrong_nep).unwrap(),
msg: &delegate_action,
};
let signed = SignedDelegateAction { signature: signable.sign(&signer), delegate_action };
assert!(!signed.verify());
}
// Try to use a wrong message type in NEP-366 signature verification.
#[test]
fn nep_366_wrong_msg_type() {
let sender_id: AccountId = "alice.unc".parse().unwrap();
let receiver_id: AccountId = "bob.unc".parse().unwrap();
let signer = create_user_test_signer(&sender_id);
let delegate_action = delegate_action(sender_id, receiver_id, signer.public_key());
let correct_nep = 366;
// here we use it as an off-chain only signature
let wrong_discriminant = MessageDiscriminant::new_off_chain(correct_nep).unwrap();
let signable = SignableMessage { discriminant: wrong_discriminant, msg: &delegate_action };
let signed = SignedDelegateAction { signature: signable.sign(&signer), delegate_action };
assert!(!signed.verify());
}
fn delegate_action(
sender_id: AccountId,
receiver_id: AccountId,
public_key: PublicKey,
) -> DelegateAction {
let delegate_action = DelegateAction {
sender_id,
receiver_id,
actions: vec![],
nonce: 0,
max_block_height: 1000,
public_key,
};
delegate_action
}
}