uds_protocol 0.0.2

A library for encoding and decoding UDS (ISO 14229) messages
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
use crate::{
    Error, Identifier, IterableWireFormat, NegativeResponseCode, SingleValueWireFormat, WireFormat,
};

const READ_DID_NEGATIVE_RESPONSE_CODES: [NegativeResponseCode; 5] = [
    NegativeResponseCode::IncorrectMessageLengthOrInvalidFormat,
    NegativeResponseCode::ResponseTooLong,
    NegativeResponseCode::ConditionsNotCorrect,
    NegativeResponseCode::RequestOutOfRange,
    NegativeResponseCode::SecurityAccessDenied,
];

/// See ISO-14229-1:2020, Table 11.2.1 for format information
#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
#[cfg_attr(feature = "utoipa", derive(utoipa::ToSchema))]
#[derive(Clone, Debug, Eq, PartialEq)]
#[non_exhaustive]
pub struct ReadDataByIdentifierRequest<DataIdentifier> {
    pub dids: Vec<DataIdentifier>,
}

impl<DataIdentifier: Identifier> ReadDataByIdentifierRequest<DataIdentifier> {
    /// Create a new request from a sequence of data identifiers
    pub(crate) fn new<I>(dids: I) -> Self
    where
        I: IntoIterator<Item = DataIdentifier>,
    {
        let dids = dids.into_iter().collect();
        Self { dids }
    }

    /// Get the allowed Nack codes for this request
    #[must_use]
    pub fn allowed_nack_codes() -> &'static [NegativeResponseCode] {
        &READ_DID_NEGATIVE_RESPONSE_CODES
    }
}

impl<DataIdentifier: Identifier> WireFormat for ReadDataByIdentifierRequest<DataIdentifier> {
    /// Create a request from a sequence of bytes
    fn decode<R: std::io::Read>(reader: &mut R) -> Result<Option<Self>, Error> {
        let dids = DataIdentifier::parse_from_list(reader)?;
        if dids.is_empty() {
            Err(Error::NoDataAvailable)
        } else {
            Ok(Some(ReadDataByIdentifierRequest::new(dids)))
        }
    }

    fn required_size(&self) -> usize {
        self.dids.len() * 2
    }

    /// Write the response as a sequence of bytes to a buffer
    fn encode<W: std::io::Write>(&self, writer: &mut W) -> Result<usize, Error> {
        let mut count = 0;
        for did in &self.dids {
            did.encode(writer)?;
            count += 2;
        }
        Ok(count)
    }
}

impl<DataIdentifier: Identifier> SingleValueWireFormat
    for ReadDataByIdentifierRequest<DataIdentifier>
{
}

/// See ISO-14229-1:2020, Table 11.2.3 for format information
#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
#[cfg_attr(feature = "utoipa", derive(utoipa::ToSchema))]
#[derive(Clone, Eq, PartialEq)]
pub struct ReadDataByIdentifierResponse<UserPayload> {
    pub data: Vec<UserPayload>,
}

impl<UserPayload> ReadDataByIdentifierResponse<UserPayload> {
    pub(crate) fn new<I>(data: I) -> Self
    where
        I: IntoIterator<Item = UserPayload>,
    {
        let data = data.into_iter().collect();
        Self { data }
    }
}

impl<UserPayload: IterableWireFormat> WireFormat for ReadDataByIdentifierResponse<UserPayload> {
    /// Create a response from a sequence of bytes
    fn decode<R: std::io::Read>(reader: &mut R) -> Result<Option<Self>, Error> {
        let mut data = Vec::new();
        for payload in UserPayload::decode_iterable(reader) {
            match payload {
                Ok(p) => {
                    data.push(p);
                }
                Err(e) => {
                    return Err(e);
                }
            }
        }
        if data.is_empty() {
            Err(Error::NoDataAvailable)
        } else {
            Ok(Some(ReadDataByIdentifierResponse::new(data)))
        }
    }

    fn required_size(&self) -> usize {
        self.data.iter().map(WireFormat::required_size).sum()
    }

    /// Write the response as a sequence of bytes to a buffer
    fn encode<W: std::io::Write>(&self, writer: &mut W) -> Result<usize, Error> {
        let mut total_written = 0;
        for payload in &self.data {
            total_written += payload.encode(writer)?;
        }
        Ok(total_written)
    }
}

impl<UserPayload: IterableWireFormat> SingleValueWireFormat
    for ReadDataByIdentifierResponse<UserPayload>
{
}

impl<UserPayload: std::fmt::Debug> std::fmt::Debug for ReadDataByIdentifierResponse<UserPayload> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "ReadDataByIdentifierResponse\n{:?}", self.data)
    }
}

#[cfg(test)]
mod test {
    use super::*;
    use crate::{ProtocolIdentifier, UDSIdentifier};

    mod request {
        use super::*;

        struct ReadRequestTestData {
            pub test_name: String,
            pub dids_bytes: Vec<u8>,
        }

        impl ReadRequestTestData {
            // Creates a Test Read Request from a list of data identifiers
            fn from_ids(test_name: &str, dids: &[ProtocolIdentifier]) -> Self {
                let dids_bytes = to_bytes(dids);
                Self {
                    test_name: test_name.to_string(),
                    dids_bytes,
                }
            }

            // Create a Test Read Request from a list of bytes.
            // Note: These bytes may not properly translate to a list of data identifiers
            fn from_bytes(test_name: &str, dids_bytes: Vec<u8>) -> Self {
                Self {
                    test_name: test_name.to_string(),
                    dids_bytes,
                }
            }
        }

        // Holds a list of dids that will be transformed into a byte sequence
        struct WriteRequestTestData {
            pub test_name: String,
            pub dids: Vec<ProtocolIdentifier>,
        }

        impl WriteRequestTestData {
            fn from_ids(test_name: &str, dids: &[ProtocolIdentifier]) -> Self {
                Self {
                    test_name: test_name.to_string(),
                    dids: dids.to_vec(),
                }
            }
        }

        fn to_bytes(ids: &[ProtocolIdentifier]) -> Vec<u8> {
            ids.iter()
                .flat_map(|id: &ProtocolIdentifier| {
                    let mut buffer = Vec::new();
                    id.encode(&mut buffer).unwrap();
                    buffer
                })
                .collect()
        }

        fn get_test_ids() -> Vec<ProtocolIdentifier> {
            vec![
                ProtocolIdentifier::new(UDSIdentifier::BootSoftwareIdentification),
                ProtocolIdentifier::new(UDSIdentifier::ApplicationSoftwareIdentification),
                ProtocolIdentifier::new(UDSIdentifier::ApplicationDataIdentification),
                ProtocolIdentifier::new(UDSIdentifier::BootSoftwareFingerprint),
                ProtocolIdentifier::new(UDSIdentifier::ApplicationSoftwareFingerprint),
                ProtocolIdentifier::new(UDSIdentifier::ApplicationDataFingerprint),
                ProtocolIdentifier::new(UDSIdentifier::ActiveDiagnosticSession),
                ProtocolIdentifier::new(UDSIdentifier::VehicleManufacturerSparePartNumber),
                ProtocolIdentifier::new(UDSIdentifier::VehicleManufacturerECUSoftwareNumber),
                ProtocolIdentifier::new(UDSIdentifier::VehicleManufacturerECUSoftwareVersionNumber),
            ]
        }

        #[test]
        fn read_did_request_bytes() {
            let test_ids = get_test_ids();

            let test_data_sets: Vec<ReadRequestTestData> = vec![
                ReadRequestTestData::from_bytes("No ids", vec![]),
                ReadRequestTestData::from_bytes("Invalid byte length", vec![0x00]),
                ReadRequestTestData::from_bytes("Invalid id", vec![0x00, 0x01]),
                ReadRequestTestData::from_ids("1 id", &test_ids[0..1]),
                ReadRequestTestData::from_ids("2 ids", &test_ids[0..2]),
                ReadRequestTestData::from_ids("3 ids", &test_ids[0..3]),
                ReadRequestTestData::from_ids("4 ids", &test_ids[0..4]),
                ReadRequestTestData::from_ids("All ids", &test_ids),
                ReadRequestTestData::from_ids(
                    "Repeated ids",
                    &test_ids
                        .clone()
                        .iter()
                        .cycle()
                        .take(100)
                        .copied()
                        .collect::<Vec<_>>(),
                ),
            ];

            for test_data in &test_data_sets {
                let read_result = ReadDataByIdentifierRequest::<ProtocolIdentifier>::decode(
                    &mut test_data.dids_bytes.as_slice(),
                );

                match read_result {
                    Ok(Some(response)) => {
                        let mut translated_bytes = Vec::new();
                        response.encode(&mut translated_bytes).unwrap();
                        assert_eq!(
                            translated_bytes, *test_data.dids_bytes,
                            "Some: Failed: {}",
                            test_data.test_name
                        );
                    }
                    Ok(None) => {
                        // No data read
                        assert!(
                            test_data.dids_bytes.is_empty(),
                            "None: Failed {}",
                            test_data.test_name
                        );
                    }
                    Err(e) => {
                        if test_data.dids_bytes.is_empty() {
                            assert!(
                                matches!(e, Error::NoDataAvailable),
                                "NoDataAvailable: Failed {}",
                                test_data.test_name
                            );
                        } else {
                            assert!(
                                matches!(e, Error::IncorrectMessageLengthOrInvalidFormat),
                                "IncorrectMessageLengthOrInvalidFormat: Failed {}",
                                test_data.test_name
                            );
                        }
                    }
                }
            }
        }

        #[test]
        fn write_did_request_bytes() {
            let test_ids = get_test_ids();

            let test_data_sets: Vec<WriteRequestTestData> = vec![
                WriteRequestTestData::from_ids("No ids", &Vec::new()),
                WriteRequestTestData::from_ids("1 id", &test_ids[0..1]),
                WriteRequestTestData::from_ids("2 ids", &test_ids[0..2]),
                WriteRequestTestData::from_ids("3 ids", &test_ids[0..3]),
                WriteRequestTestData::from_ids("4 ids", &test_ids[0..4]),
                WriteRequestTestData::from_ids("All ids", &test_ids),
                WriteRequestTestData::from_ids(
                    "Repeated ids",
                    &test_ids
                        .clone()
                        .iter()
                        .cycle()
                        .take(100)
                        .copied()
                        .collect::<Vec<_>>(),
                ),
            ];

            for test_data in &test_data_sets {
                let request = ReadDataByIdentifierRequest::new(test_data.dids.clone());
                let mut buffer = Vec::new();
                let write_result = request.encode(&mut buffer);

                match write_result {
                    Ok(bytes_read) => {
                        // 1 did is 2 bytes
                        let expected_byte_count = request.dids.len() * 2;
                        assert_eq!(bytes_read, expected_byte_count);
                    }
                    Err(e) => {
                        assert!(
                            matches!(e, Error::InsufficientData(_)),
                            "InsufficientData: Failed {}",
                            test_data.test_name
                        );
                    }
                }
            }
        }
    }

    mod response {
        use super::*;

        #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
        #[derive(Clone, Copy, Debug, Eq, PartialEq)]
        pub struct BazData {
            pub data: [u8; 16],
            pub data2: u64,
            pub data3: u16,
        }

        // The UDSIdentifiers are vender defined and don't have interesting payloads, so we define our own types for
        #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
        #[derive(Clone, Debug, Eq, PartialEq)]
        pub enum TestPayload {
            #[cfg_attr(feature = "serde", serde(with = "serde_bytes"))]
            MeaningOfLife([u8; 42]),
            Foo(u32),
            Bar,
            Baz(BazData),
            UDSIdentifier(UDSIdentifier),
        }

        impl TestPayload {
            fn new<R: std::io::Read>(did: u16, reader: &mut R) -> Result<Self, Error> {
                match did {
                    0xFF00 => {
                        let mut data = [0u8; 42];
                        reader.read_exact(&mut data)?;
                        Ok(TestPayload::MeaningOfLife(data))
                    }
                    0xFF01 => {
                        let mut data = [0u8; 4];
                        reader.read_exact(&mut data)?;
                        let value = u32::from_be_bytes(data);
                        Ok(TestPayload::Foo(value))
                    }
                    0xFF02 => Ok(TestPayload::Bar),
                    0xFF03 => {
                        let data = BazData::decode(reader)?.unwrap();
                        Ok(TestPayload::Baz(data))
                    }
                    _ => {
                        let identifier = UDSIdentifier::try_from(did)?;
                        Ok(TestPayload::UDSIdentifier(identifier))
                    }
                }
            }
        }

        impl From<TestPayload> for u16 {
            fn from(value: TestPayload) -> Self {
                match value {
                    TestPayload::MeaningOfLife(_) => 0xFF00,
                    TestPayload::Foo(_) => 0xFF01,
                    TestPayload::Bar => 0xFF02,
                    TestPayload::Baz(_) => 0xFF03,
                    TestPayload::UDSIdentifier(uds_id) => u16::from(uds_id),
                }
            }
        }

        impl IterableWireFormat for TestPayload {}

        impl WireFormat for TestPayload {
            fn decode<R: std::io::Read>(reader: &mut R) -> Result<Option<Self>, Error> {
                let mut identifier_data: [u8; 2] = [0; 2];
                match reader.read(&mut identifier_data)? {
                    0 => return Ok(None),
                    1 => return Err(Error::IncorrectMessageLengthOrInvalidFormat),
                    2 => (),
                    _ => unreachable!("Impossible to read more than 2 bytes into 2 byte array"),
                }
                let did = u16::from_be_bytes(identifier_data);
                Ok(Some(TestPayload::new(did, reader)?))
            }

            #[allow(clippy::match_same_arms)]
            fn required_size(&self) -> usize {
                match self {
                    TestPayload::MeaningOfLife(_) => 42,
                    TestPayload::Foo(_) => 4,
                    TestPayload::Bar => 0,
                    TestPayload::Baz(_) => 26,
                    TestPayload::UDSIdentifier(_) => 0,
                }
            }

            #[allow(clippy::match_same_arms)]
            fn encode<W: std::io::Write>(&self, writer: &mut W) -> Result<usize, Error> {
                let id_bytes = u16::from(self.clone()).to_be_bytes();
                let did_len = writer.write(&id_bytes)?;
                match self {
                    TestPayload::MeaningOfLife(data) => {
                        writer.write_all(data)?;
                        Ok(did_len + data.len())
                    }
                    TestPayload::Foo(value) => {
                        let bytes = value.to_be_bytes();
                        writer.write_all(&bytes)?;
                        Ok(did_len + bytes.len())
                    }
                    TestPayload::Bar => Ok(did_len),
                    TestPayload::Baz(data) => data.encode(writer),
                    TestPayload::UDSIdentifier(_) => Ok(did_len),
                }
            }
        }

        impl WireFormat for BazData {
            fn decode<R: std::io::Read>(reader: &mut R) -> Result<Option<Self>, Error> {
                let mut data = [0u8; 16];
                reader.read_exact(&mut data)?;

                let mut data2_bytes = [0u8; 8];
                reader.read_exact(&mut data2_bytes)?;
                let data2 = u64::from_be_bytes(data2_bytes);

                let mut data3_bytes = [0u8; 2];
                reader.read_exact(&mut data3_bytes)?;
                let data3 = u16::from_be_bytes(data3_bytes);

                Ok(Some(BazData { data, data2, data3 }))
            }

            fn required_size(&self) -> usize {
                26
            }

            fn encode<W: std::io::Write>(&self, writer: &mut W) -> Result<usize, Error> {
                writer.write_all(&self.data)?;
                let mut count = 16;
                count += writer.write(&self.data2.to_be_bytes())?;
                count += writer.write(&self.data3.to_be_bytes())?;
                // 2 for the initial did bytes
                Ok(2 + count)
            }
        }

        fn get_test_response_data() -> Vec<TestPayload> {
            vec![
                TestPayload::MeaningOfLife([0; 42]),
                TestPayload::Foo(42),
                TestPayload::Bar,
                TestPayload::Baz(BazData {
                    data: [5; 16],
                    data2: 1_234_567_890,
                    data3: 54_321,
                }),
                TestPayload::UDSIdentifier(UDSIdentifier::BootSoftwareIdentification),
            ]
        }

        #[test]
        fn read_did_response_bytes() {
            let test_data = get_test_response_data();

            let response = ReadDataByIdentifierResponse::new(test_data);
            let mut buffer = Vec::new();
            response.encode(&mut buffer).unwrap();

            let read_response: ReadDataByIdentifierResponse<TestPayload> =
                ReadDataByIdentifierResponse::<TestPayload>::decode(&mut buffer.as_slice())
                    .unwrap()
                    .unwrap();

            assert_eq!(response, read_response);
        }

        #[test]
        fn write_did_response_bytes() {
            let test_data = get_test_response_data();

            let response = ReadDataByIdentifierResponse::new(test_data.clone());
            let mut buffer = Vec::new();
            let bytes_written = response.encode(&mut buffer).unwrap();

            let expected_bytes: Vec<u8> = test_data
                .iter()
                .flat_map(|payload| {
                    let mut buf = Vec::new();
                    payload.encode(&mut buf).unwrap();
                    buf
                })
                .collect();

            assert_eq!(buffer, expected_bytes);
            assert_eq!(bytes_written, expected_bytes.len());
        }
    }
}