typst-pack 0.5.0

Portable single-file packs of Typst projects: sources, resources, packages, and fonts
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
//! Package reading for a Pack Assembler that supplies its own transport.
//!
//! Creation reports the exact specifications its representative request needs
//! and was not given. These helpers cover the two transformations between that
//! report and a resolved tree — constructing the registry URL of a
//! specification, and expanding the archive bytes fetched from it into a
//! Package Tree — so a caller reimplements neither the registry layout
//! nor the archive encoding. Fetching those bytes is the adapter's own
//! obligation and stays outside: nothing here needs an HTTP client, so the
//! helpers are usable on a host whose only network access is asynchronous.

use std::cell::RefCell;
use std::io::Read;
use std::rc::Rc;

use typst::foundations::Bytes;
use typst::syntax::package::PackageSpec;

use crate::Pack;
use crate::limits::{LimitError, Limits, ResourceKind};
use crate::package_catalog::{PackageTree, PackageTreeError};
use crate::read_layout;

/// A failure while reading exact Package Archive bytes from a stream.
#[derive(Debug, thiserror::Error)]
#[non_exhaustive]
pub enum PackageArchiveReadError {
    #[error(transparent)]
    Limit(#[from] PackageExpansionLimitError),
    #[error("failed to read Package Archive bytes: {0}")]
    Read(#[source] std::io::Error),
}

/// The URL of the package registry these helpers describe the layout of, the
/// official Typst Universe registry. There is no standardized registry
/// protocol, so the layout is this registry's own.
pub const PACKAGE_REGISTRY_URL: &str = read_layout::PACKAGE_REGISTRY_URL;

/// The one package namespace the registry serves. A specification in any other
/// namespace is resolved from wherever its namespace lives, which the registry
/// layout says nothing about.
pub const PACKAGE_REGISTRY_NAMESPACE: &str = read_layout::PACKAGE_REGISTRY_NAMESPACE;

/// A resource bounded during Package Archive Expansion.
pub type PackageExpansionResource = ResourceKind<6>;

#[allow(non_upper_case_globals)]
impl ResourceKind<6> {
    pub const CompressedArchiveBytes: Self = Self::new(0);
    pub const Members: Self = Self::new(1);
    pub const MemberNameBytes: Self = Self::new(2);
    pub const MemberBytes: Self = Self::new(3);
    pub const TotalExpandedBytes: Self = Self::new(4);
}

/// A package archive exceeded a mandatory expansion ceiling.
pub type PackageExpansionLimitError = LimitError<PackageExpansionResource>;

/// Mandatory finite resource ceilings for Package Archive Expansion.
pub type PackageExpansionLimits = Limits<PackageExpansionResource>;

impl Limits<PackageExpansionResource> {
    /// Constructs a validated set of mandatory finite expansion ceilings.
    #[track_caller]
    pub fn new(
        compressed_archive_bytes: u64,
        members: u64,
        member_name_bytes: u64,
        member_bytes: u64,
        total_expanded_bytes: u64,
    ) -> Self {
        Self::from_ceilings([
            compressed_archive_bytes,
            members,
            member_name_bytes,
            member_bytes,
            total_expanded_bytes,
            0,
            0,
        ])
        .assert_probe_resources([
            PackageExpansionResource::CompressedArchiveBytes,
            PackageExpansionResource::Members,
            PackageExpansionResource::MemberNameBytes,
            PackageExpansionResource::MemberBytes,
            PackageExpansionResource::TotalExpandedBytes,
        ])
    }

    /// The first-party limits for registry package archives.
    pub const fn reference_v1() -> Self {
        Self::from_ceilings([
            128 * 1024 * 1024,
            50_000,
            8 * 1024 * 1024,
            64 * 1024 * 1024,
            512 * 1024 * 1024,
            0,
            0,
        ])
    }

    pub const fn compressed_archive_bytes(&self) -> u64 {
        self.ceilings[0]
    }

    pub const fn members(&self) -> u64 {
        self.ceilings[1]
    }

    pub const fn member_name_bytes(&self) -> u64 {
        self.ceilings[2]
    }

    pub const fn member_bytes(&self) -> u64 {
        self.ceilings[3]
    }

    pub const fn total_expanded_bytes(&self) -> u64 {
        self.ceilings[4]
    }
}

/// Reads exact Package Archive bytes under the expansion profile's
/// compressed-byte ceiling.
///
/// A known size is checked before the reader is touched. The stream is still
/// incrementally metered with a plus-one probe because a size declaration is
/// only a hint.
pub fn read_package_archive(
    mut reader: impl Read,
    known_size: Option<u64>,
    limits: PackageExpansionLimits,
) -> Result<Vec<u8>, PackageArchiveReadError> {
    let resource = PackageExpansionResource::CompressedArchiveBytes;
    if let Some(size) = known_size {
        check_expansion_limit(resource, limits.compressed_archive_bytes(), size)?;
    }

    let mut bytes = Vec::new();
    reader
        .by_ref()
        .take(limits.compressed_archive_bytes() + 1)
        .read_to_end(&mut bytes)
        .map_err(PackageArchiveReadError::Read)?;
    let observed = u64::try_from(bytes.len())
        .map_err(|_| PackageExpansionLimitError::AccountingOverflow { resource })?;
    check_expansion_limit(resource, limits.compressed_archive_bytes(), observed)?;
    Ok(bytes)
}

/// The URL of the archive holding one exact package specification's Package
/// Tree.
///
/// No index lookup is involved: creation only ever reports fully versioned
/// specifications, because a Typst import specification always carries an exact
/// version.
pub fn package_archive_url(spec: &PackageSpec) -> Result<String, PackageReadError> {
    read_layout::official_registry_archive_url(spec)
        .ok_or_else(|| PackageReadError::UnservedNamespace { spec: spec.clone() })
}

/// Expands the archive bytes served for one exact package specification into
/// the Package Tree creation accepts as a resolved tree for it.
///
/// The bytes are the gzip-compressed tar a registry serves, which the caller
/// fetched with whatever primitive its host provides; expansion itself needs no
/// transport. Only addressable regular files become tree entries: directories,
/// links, and other archive members are not package files. An entry whose path
/// cannot name one is rejected here rather than carried into a tree, because
/// expansion is where a hostile archive is met.
///
/// Expansion stops at `limits` and fails with
/// [`PackageReadError::ExpansionLimit`] rather than materializing what
/// lies past it. Every raw member and its payload is charged before semantic
/// interpretation, whether or not that member becomes a package file.
///
pub fn expand_package_archive(
    spec: PackageSpec,
    archive: &[u8],
    limits: PackageExpansionLimits,
) -> Result<PackageTree, PackageReadError> {
    let malformed = |message: String| PackageReadError::MalformedArchive {
        spec: spec.clone(),
        message,
    };
    let limited = |source| PackageReadError::ExpansionLimit {
        spec: spec.clone(),
        source,
    };

    let compressed_archive_bytes = u64::try_from(archive.len()).map_err(|_| {
        limited(PackageExpansionLimitError::AccountingOverflow {
            resource: PackageExpansionResource::CompressedArchiveBytes,
        })
    })?;
    check_expansion_limit(
        PackageExpansionResource::CompressedArchiveBytes,
        limits.compressed_archive_bytes(),
        compressed_archive_bytes,
    )
    .map_err(limited)?;

    let tar_state = Rc::new(RefCell::new(TarReadState::default()));
    let reader = ObservedTarReader {
        inner: flate2::read::GzDecoder::new(archive),
        state: Rc::clone(&tar_state),
    };
    let mut archive = tar::Archive::new(reader);
    let mut files: Vec<(String, Bytes)> = Vec::new();
    let mut members = 0u64;
    let mut member_name_bytes = 0u64;
    let mut total_expanded_bytes = 0u64;
    let mut gnu_long_name: Option<Vec<u8>> = None;
    let mut gnu_long_link = false;
    let mut pax_local = false;
    let mut pax_path: Option<Vec<u8>> = None;
    let mut pax_size: Option<u64> = None;

    for entry in archive
        .entries()
        .map_err(|error| malformed(error.to_string()))?
        .raw(true)
    {
        let mut entry = entry.map_err(|error| malformed(error.to_string()))?;
        check_tar_padding(&tar_state).map_err(&malformed)?;

        members = checked_add(members, 1, PackageExpansionResource::Members).map_err(limited)?;
        check_expansion_limit(PackageExpansionResource::Members, limits.members(), members)
            .map_err(limited)?;

        let raw_name = entry.header().path_bytes().into_owned();
        member_name_bytes = checked_add_usize(
            member_name_bytes,
            raw_name.len(),
            PackageExpansionResource::MemberNameBytes,
        )
        .map_err(limited)?;
        check_expansion_limit(
            PackageExpansionResource::MemberNameBytes,
            limits.member_name_bytes(),
            member_name_bytes,
        )
        .map_err(limited)?;

        let entry_type = entry.header().entry_type();
        let extension = entry_type.is_gnu_longname()
            || entry_type.is_gnu_longlink()
            || entry_type.is_pax_local_extensions()
            || entry_type.is_pax_global_extensions();
        if !extension
            && let Some(pax_size) = pax_size.take()
            && pax_size != entry.size()
        {
            return Err(malformed(format!(
                "PAX size {pax_size} conflicts with member size {}",
                entry.size()
            )));
        }
        if entry_type.is_gnu_longname() {
            let observed = checked_add(
                member_name_bytes,
                entry.size(),
                PackageExpansionResource::MemberNameBytes,
            )
            .map_err(limited)?;
            check_expansion_limit(
                PackageExpansionResource::MemberNameBytes,
                limits.member_name_bytes(),
                observed,
            )
            .map_err(limited)?;
        }

        check_expansion_limit(
            PackageExpansionResource::MemberBytes,
            limits.member_bytes(),
            entry.size(),
        )
        .map_err(limited)?;
        let observed_total = checked_add(
            total_expanded_bytes,
            entry.size(),
            PackageExpansionResource::TotalExpandedBytes,
        )
        .map_err(limited)?;
        check_expansion_limit(
            PackageExpansionResource::TotalExpandedBytes,
            limits.total_expanded_bytes(),
            observed_total,
        )
        .map_err(limited)?;

        let declared_size = entry.size();
        if entry_type.is_pax_global_extensions() {
            return Err(malformed(
                "global PAX extensions make package member names ambiguous".to_owned(),
            ));
        }
        if entry_type.is_pax_local_extensions() {
            if pax_local {
                return Err(malformed(
                    "multiple local PAX extensions describe one archive member".to_owned(),
                ));
            }
            let name_remaining = limits.member_name_bytes() - member_name_bytes;
            let parsed = match read_pax(&mut entry, declared_size, name_remaining) {
                Ok(parsed) => parsed,
                Err(PaxReadError::Io(error) | PaxReadError::Malformed(error)) => {
                    return Err(malformed(error));
                }
                Err(PaxReadError::NameLimit { observed }) => {
                    checked_add(
                        member_name_bytes,
                        observed,
                        PackageExpansionResource::MemberNameBytes,
                    )
                    .map_err(limited)?;
                    return Err(limited(PackageExpansionLimitError::exceeded(
                        PackageExpansionResource::MemberNameBytes,
                        limits.member_name_bytes(),
                    )));
                }
            };
            register_tar_padding(&tar_state, entry.raw_file_position(), declared_size)
                .map_err(&malformed)?;
            total_expanded_bytes = checked_add(
                total_expanded_bytes,
                declared_size,
                PackageExpansionResource::TotalExpandedBytes,
            )
            .map_err(limited)?;
            if let Some(path) = &parsed.path {
                member_name_bytes = checked_add_usize(
                    member_name_bytes,
                    path.len(),
                    PackageExpansionResource::MemberNameBytes,
                )
                .map_err(limited)?;
            }
            if let Some(size) = parsed.size {
                check_expansion_limit(
                    PackageExpansionResource::MemberBytes,
                    limits.member_bytes(),
                    size,
                )
                .map_err(limited)?;
                let observed_total = checked_add(
                    total_expanded_bytes,
                    size,
                    PackageExpansionResource::TotalExpandedBytes,
                )
                .map_err(limited)?;
                check_expansion_limit(
                    PackageExpansionResource::TotalExpandedBytes,
                    limits.total_expanded_bytes(),
                    observed_total,
                )
                .map_err(limited)?;
            }
            pax_path = parsed.path;
            pax_size = parsed.size;
            pax_local = true;
            continue;
        }

        let probe_ceiling = limits
            .member_bytes()
            .min(limits.total_expanded_bytes() - total_expanded_bytes);
        let mut reader = entry.by_ref().take(probe_ceiling + 1);
        let retain = entry_type.is_file() || entry_type.is_gnu_longname();
        let capacity = usize::try_from(declared_size.min(64 * 1024)).unwrap();
        let mut data = Vec::with_capacity(if retain { capacity } else { 0 });
        let mut observed_size = 0u64;
        let mut buffer = [0; 16 * 1024];
        loop {
            let read = reader
                .read(&mut buffer)
                .map_err(|error| malformed(error.to_string()))?;
            if read == 0 {
                break;
            }
            observed_size =
                checked_add_usize(observed_size, read, PackageExpansionResource::MemberBytes)
                    .map_err(limited)?;
            check_expansion_limit(
                PackageExpansionResource::MemberBytes,
                limits.member_bytes(),
                observed_size,
            )
            .map_err(limited)?;
            let observed_total = checked_add(
                total_expanded_bytes,
                observed_size,
                PackageExpansionResource::TotalExpandedBytes,
            )
            .map_err(limited)?;
            check_expansion_limit(
                PackageExpansionResource::TotalExpandedBytes,
                limits.total_expanded_bytes(),
                observed_total,
            )
            .map_err(limited)?;
            if retain {
                data.extend_from_slice(&buffer[..read]);
            }
        }
        if observed_size != declared_size {
            return Err(malformed(format!(
                "archive member declared {declared_size} byte(s) but yielded {observed_size}"
            )));
        }
        register_tar_padding(&tar_state, entry.raw_file_position(), declared_size)
            .map_err(&malformed)?;
        total_expanded_bytes = checked_add(
            total_expanded_bytes,
            observed_size,
            PackageExpansionResource::TotalExpandedBytes,
        )
        .map_err(limited)?;

        if entry_type.is_gnu_longname() {
            if gnu_long_name.is_some() {
                return Err(malformed(
                    "multiple GNU long names describe one archive member".to_owned(),
                ));
            }
            member_name_bytes = checked_add(
                member_name_bytes,
                observed_size,
                PackageExpansionResource::MemberNameBytes,
            )
            .map_err(limited)?;
            gnu_long_name = Some(strip_gnu_terminator(data));
            continue;
        }
        if entry_type.is_gnu_longlink() {
            if gnu_long_link {
                return Err(malformed(
                    "multiple GNU long links describe one archive member".to_owned(),
                ));
            }
            gnu_long_link = true;
            continue;
        }
        let effective_name = match (gnu_long_name.take(), pax_path.take()) {
            (Some(_), Some(_)) => {
                return Err(malformed(
                    "GNU and PAX extensions provide ambiguous member names".to_owned(),
                ));
            }
            (Some(name), None) | (None, Some(name)) => name,
            (None, None) => raw_name,
        };
        gnu_long_link = false;
        pax_local = false;
        let path = std::str::from_utf8(&effective_name)
            .map_err(|_| malformed(format!("member name {effective_name:?} is not valid UTF-8")))?
            .to_owned();

        if entry_type.is_file() {
            files.push((path, Bytes::new(data)));
        } else {
            Pack::canonical_package_path(&path).map_err(|message| {
                malformed(format!(
                    "archive member {path:?} does not name a package file: {message}"
                ))
            })?;
        }
    }

    check_tar_padding(&tar_state).map_err(&malformed)?;

    if gnu_long_name.is_some() || gnu_long_link || pax_local {
        return Err(malformed(
            "archive metadata describes a future member that is missing".to_owned(),
        ));
    }

    PackageTree::from_typst_entries(files)
        .map_err(|source| PackageReadError::InvalidPackageTree { spec, source })
}

#[derive(Default)]
struct TarReadState {
    position: u64,
    padding: Option<(u64, u64)>,
    nonzero_padding: bool,
}

struct ObservedTarReader<R> {
    inner: R,
    state: Rc<RefCell<TarReadState>>,
}

impl<R: Read> Read for ObservedTarReader<R> {
    fn read(&mut self, buffer: &mut [u8]) -> std::io::Result<usize> {
        let read = self.inner.read(buffer)?;
        let mut state = self.state.borrow_mut();
        let start = state.position;
        state.position = state
            .position
            .checked_add(read as u64)
            .ok_or_else(|| std::io::Error::other("tar stream position overflowed"))?;
        if let Some((padding_start, padding_end)) = state.padding {
            let overlap_start = start.max(padding_start);
            let overlap_end = state.position.min(padding_end);
            if overlap_start < overlap_end {
                let buffer_start = usize::try_from(overlap_start - start).unwrap();
                let buffer_end = usize::try_from(overlap_end - start).unwrap();
                state.nonzero_padding |= buffer[buffer_start..buffer_end]
                    .iter()
                    .any(|byte| *byte != 0);
            }
            if state.position >= padding_end {
                state.padding = None;
            }
        }
        Ok(read)
    }
}

fn register_tar_padding(
    state: &Rc<RefCell<TarReadState>>,
    file_position: u64,
    declared_size: u64,
) -> Result<(), String> {
    let padding_start = file_position
        .checked_add(declared_size)
        .ok_or_else(|| "tar member position overflowed".to_owned())?;
    let padding_end = padding_start
        .checked_add(511)
        .map(|end| end & !511)
        .ok_or_else(|| "tar member padding position overflowed".to_owned())?;
    state.borrow_mut().padding =
        (padding_start < padding_end).then_some((padding_start, padding_end));
    Ok(())
}

fn check_tar_padding(state: &Rc<RefCell<TarReadState>>) -> Result<(), String> {
    if state.borrow().nonzero_padding {
        return Err("archive member contains non-zero bytes past its declared size".to_owned());
    }
    Ok(())
}

fn strip_gnu_terminator(mut name: Vec<u8>) -> Vec<u8> {
    if name.last() == Some(&0) {
        name.pop();
    }
    name
}

struct PaxMetadata {
    path: Option<Vec<u8>>,
    size: Option<u64>,
}

enum PaxReadError {
    Io(String),
    Malformed(String),
    NameLimit { observed: u64 },
}

fn read_pax(
    reader: &mut impl Read,
    declared_size: u64,
    name_remaining: u64,
) -> Result<PaxMetadata, PaxReadError> {
    let mut remaining = declared_size;
    let mut path = None;
    let mut size = None;
    while remaining > 0 {
        let mut prefix = Vec::with_capacity(21);
        loop {
            let byte = read_pax_byte(reader)?;
            prefix.push(byte);
            if byte == b' ' {
                break;
            }
            if !byte.is_ascii_digit() || prefix.len() > 20 {
                return Err(PaxReadError::Malformed(
                    "malformed PAX record length".to_owned(),
                ));
            }
        }
        let prefix_length = u64::try_from(prefix.len()).unwrap();
        let record_length = std::str::from_utf8(&prefix[..prefix.len() - 1])
            .ok()
            .and_then(|length| length.parse::<u64>().ok())
            .filter(|length| *length > prefix_length + 2 && *length <= remaining)
            .ok_or_else(|| PaxReadError::Malformed("invalid PAX record length".to_owned()))?;

        let mut key = Vec::with_capacity(16);
        let mut key_length = 0u64;
        loop {
            let byte = read_pax_byte(reader)?;
            key_length += 1;
            if byte == b'=' {
                break;
            }
            if key.len() < 16 {
                key.push(byte);
            }
            if prefix_length + key_length + 1 >= record_length {
                return Err(PaxReadError::Malformed(
                    "malformed PAX key-value record".to_owned(),
                ));
            }
        }
        let value_length = record_length - prefix_length - key_length - 1;
        match key.as_slice() {
            b"path" if path.is_some() => {
                return Err(PaxReadError::Malformed(
                    "multiple PAX paths describe one archive member".to_owned(),
                ));
            }
            b"path" => {
                if value_length > name_remaining {
                    return Err(PaxReadError::NameLimit {
                        observed: value_length,
                    });
                }
                let length = usize::try_from(value_length).map_err(|_| {
                    PaxReadError::Malformed("PAX path length is not addressable".to_owned())
                })?;
                let mut value = vec![0; length];
                read_pax_exact(reader, &mut value)?;
                path = Some(value);
            }
            b"size" if size.is_some() => {
                return Err(PaxReadError::Malformed(
                    "multiple PAX sizes describe one archive member".to_owned(),
                ));
            }
            b"size" => {
                if value_length > 20 {
                    return Err(PaxReadError::Malformed(
                        "PAX size is not an unsigned integer".to_owned(),
                    ));
                }
                let mut value = vec![0; value_length as usize];
                read_pax_exact(reader, &mut value)?;
                size = Some(
                    std::str::from_utf8(&value)
                        .ok()
                        .and_then(|value| value.parse().ok())
                        .ok_or_else(|| {
                            PaxReadError::Malformed(
                                "PAX size is not an unsigned integer".to_owned(),
                            )
                        })?,
                );
            }
            _ => discard_pax_bytes(reader, value_length)?,
        }
        if read_pax_byte(reader)? != b'\n' {
            return Err(PaxReadError::Malformed(
                "PAX record does not end with a newline".to_owned(),
            ));
        }
        remaining -= record_length;
    }
    Ok(PaxMetadata { path, size })
}

fn read_pax_byte(reader: &mut impl Read) -> Result<u8, PaxReadError> {
    let mut byte = [0];
    read_pax_exact(reader, &mut byte)?;
    Ok(byte[0])
}

fn read_pax_exact(reader: &mut impl Read, buffer: &mut [u8]) -> Result<(), PaxReadError> {
    reader
        .read_exact(buffer)
        .map_err(|error| PaxReadError::Io(error.to_string()))
}

fn discard_pax_bytes(reader: &mut impl Read, mut remaining: u64) -> Result<(), PaxReadError> {
    let mut buffer = [0; 8 * 1024];
    while remaining > 0 {
        let length = usize::try_from(remaining.min(buffer.len() as u64)).unwrap();
        read_pax_exact(reader, &mut buffer[..length])?;
        remaining -= length as u64;
    }
    Ok(())
}

fn checked_add(
    total: u64,
    value: u64,
    resource: PackageExpansionResource,
) -> Result<u64, PackageExpansionLimitError> {
    total
        .checked_add(value)
        .ok_or(PackageExpansionLimitError::AccountingOverflow { resource })
}

fn checked_add_usize(
    total: u64,
    value: usize,
    resource: PackageExpansionResource,
) -> Result<u64, PackageExpansionLimitError> {
    let value = u64::try_from(value)
        .map_err(|_| PackageExpansionLimitError::AccountingOverflow { resource })?;
    checked_add(total, value, resource)
}

fn check_expansion_limit(
    resource: PackageExpansionResource,
    ceiling: u64,
    observed: u64,
) -> Result<(), PackageExpansionLimitError> {
    if observed > ceiling {
        return Err(PackageExpansionLimitError::exceeded(resource, ceiling));
    }
    Ok(())
}

/// A failure while reading one Package Tree.
#[derive(Debug, Clone, PartialEq, Eq, thiserror::Error)]
#[non_exhaustive]
pub enum PackageReadError {
    /// The registry does not serve the specification's namespace, so it has no
    /// URL there.
    #[error(
        "the registry serves only the `{PACKAGE_REGISTRY_NAMESPACE}` namespace, and {spec} is not in it"
    )]
    UnservedNamespace { spec: PackageSpec },
    /// The archive exceeds one expansion resource ceiling.
    #[error("the archive for {spec} exceeded an expansion limit: {source}")]
    ExpansionLimit {
        spec: PackageSpec,
        source: PackageExpansionLimitError,
    },
    /// The bytes are not the archive a registry serves for the specification.
    #[error("the archive for {spec} is malformed: {message:?}")]
    MalformedArchive { spec: PackageSpec, message: String },
    /// The archive does not expand into a valid Package Tree.
    #[error("the archive for {spec} does not contain a valid package tree: {source}")]
    InvalidPackageTree {
        spec: PackageSpec,
        source: PackageTreeError,
    },
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn package_expansion_accounting_overflow_is_typed() {
        assert_eq!(
            checked_add(u64::MAX, 1, PackageExpansionResource::TotalExpandedBytes),
            Err(PackageExpansionLimitError::AccountingOverflow {
                resource: PackageExpansionResource::TotalExpandedBytes,
            })
        );
    }
}