typed-geojson 0.2.1

Strongly-typed GeoJSON: Feature<G, P> and FeatureCollection<G, P> with typed geometry and properties, layered over the georust geojson crate.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
//! Strongly-typed [GeoJSON](https://datatracker.ietf.org/doc/html/rfc7946) for Rust.
//!
//! The [`geojson`] crate models a Feature's `properties` as an untyped
//! `Option<serde_json::Map<String, Value>>`. This crate adds generics,
//! [`Feature<G, P>`] and [`FeatureCollection<G, P>`], typed over both the
//! `G`eometry and the `P`roperties, in the same parameter order as
//! `@types/geojson`'s `Feature<G, P>` so the two interoperate.
//!
//! `G` defaults to the typed [`Geometry`] union (which mirrors
//! `@types/geojson`'s `Geometry` and exports to TypeScript via the `specta`
//! feature) and `P` to [`Properties`] (an untyped JSON object, like native
//! `GeoJsonProperties`); pick your own `P` for typed properties:
//!
//! Per RFC 7946 a Feature's geometry is mandatory but may be `null`; like
//! native, that nullability lives in `G`: `Feature<Geometry>` is non-null,
//! `Feature<Option<Geometry>>` (→ TS `Geometry | null`) is the nullable form.
//! [`geojson::Geometry`] interop is available through the [`Feature`] /
//! [`Geometry`] `TryFrom` bridges.
//!
//! ```
//! use serde::{Deserialize, Serialize};
//! use typed_geojson::{Feature, Geometry};
//!
//! #[derive(Serialize, Deserialize, Debug, PartialEq)]
//! struct Station {
//!     id: u32,
//!     name: String,
//!     temp_c: f64,
//! }
//!
//! let raw = r#"{
//!     "type": "Feature",
//!     "geometry": { "type": "Point", "coordinates": [-96.8, 32.8] },
//!     "properties": { "id": 7, "name": "DFW", "temp_c": 31.5 }
//! }"#;
//!
//! let feature: Feature<Geometry, Station> = serde_json::from_str(raw).unwrap();
//! assert_eq!(feature.properties.name, "DFW");
//!
//! // round-trips back to standard GeoJSON
//! let back: Feature<Geometry, Station> =
//!     serde_json::from_str(&serde_json::to_string(&feature).unwrap()).unwrap();
//! assert_eq!(back, feature);
//! ```
//!
//! It also bridges to the untyped [`geojson`] crate (whose geometry is nullable,
//! so use `Option<Geometry>`):
//!
//! ```
//! use typed_geojson::{Feature, Geometry, Point};
//!
//! // geojson stores properties as a JSON object, so `P` must serialize to one.
//! let f: Feature<Option<Geometry>, serde_json::Value> = Feature::new(
//!     Some(Geometry::Point(Point::new(vec![-96.8, 32.8]))),
//!     serde_json::json!({ "name": "DFW" }),
//! );
//! let untyped: geojson::Feature = f.try_into().unwrap();
//! assert!(untyped.geometry.is_some());
//! ```
//!
//! Unknown top-level members (RFC 7946 §6.1 *foreign members* — an extension's
//! `"title"`, a vendor field) are preserved rather than dropped; see
//! [`ForeignMembers`]. With the `geo-types` feature, the geometry types convert
//! to and from [`geo_types`] so a typed geometry flows into georust's `geo`
//! algorithms:
//!
//! ```
//! # #[cfg(feature = "geo-types")]
//! # {
//! use typed_geojson::Point;
//!
//! let p: geo_types::Point<f64> = Point::new(vec![-96.8, 32.8]).try_into().unwrap();
//! assert_eq!(p, geo_types::Point::new(-96.8, 32.8));
//! # }
//! ```

use std::fmt;
use std::marker::PhantomData;

use serde::de::{self, Deserializer, MapAccess, Visitor};
use serde::ser::{SerializeMap, Serializer};
use serde::{Deserialize, Serialize};

mod geometry;
pub use geometry::*;

// `From`/`TryFrom` between our geometry types and `geo_types` (impls only, so a
// private module suffices — trait impls apply crate-wide regardless).
#[cfg(feature = "geo-types")]
mod geo_types_bridge;

/// `specta` export-only marker: a JSON number that maps to the native TS
/// `number`.
///
/// specta-typescript renders Rust `f64` as `number | null` (to model `NaN` /
/// `Infinity`, which serde_json writes as `null`). GeoJSON coordinates and
/// bboxes are finite reals, so for the TS bindings we override those numeric
/// fields to this marker (which renders as a plain `number`) via
/// `#[specta(type = …)]`. serde and the Rust API keep the real `f64`.
#[cfg(feature = "specta")]
pub(crate) struct TsNumber;

#[cfg(feature = "specta")]
impl specta::Type for TsNumber {
    fn definition(_: &mut specta::Types) -> specta::datatype::DataType {
        specta::datatype::DataType::Primitive(specta::datatype::Primitive::i32)
    }
}

/// The default, untyped `properties` of a [`Feature`]: a JSON object or `null`
/// (RFC 7946 §3.2). Mirrors `@types/geojson`'s
/// `GeoJsonProperties = { [name: string]: any } | null`.
pub type Properties = Option<serde_json::Map<String, serde_json::Value>>;

/// A GeoJSON object's *foreign members* (RFC 7946 §6.1): members that the
/// specification does not define — an extension's `"title"`, a vendor field, a
/// legacy `"crs"`, and so on. The standard [`geojson`] crate documents that its
/// typed path **drops these on the floor**; this crate keeps them, so a
/// parse → serialize round-trip is byte-faithful and nothing a producer wrote
/// is silently lost.
///
/// They are stored as a JSON object and serialized **flattened** at the top
/// level of the enclosing object — never nested — exactly as they arrive on the
/// wire. An empty map serializes to nothing (no key is emitted), so a Feature
/// with no foreign members is byte-identical to one built without this field.
///
/// Foreign members are runtime fidelity only: they are deliberately **left out
/// of the `specta` / TypeScript export**. `@types/geojson` does not model them
/// either — they are excess properties there — so keeping them out of the
/// static contract is exactly what preserves the assignability guarantee.
///
/// ```
/// use typed_geojson::{Feature, Geometry};
///
/// // A Feature carrying an extension member alongside the spec fields.
/// let raw = r#"{"type":"Feature","geometry":null,"properties":null,"title":"Sensor 7"}"#;
/// let f: Feature<Option<Geometry>> = serde_json::from_str(raw).unwrap();
/// assert_eq!(f.foreign_members["title"], serde_json::json!("Sensor 7"));
///
/// // …and it survives serialization untouched (here, byte-for-byte).
/// assert_eq!(serde_json::to_string(&f).unwrap(), raw);
/// ```
pub type ForeignMembers = serde_json::Map<String, serde_json::Value>;

/// A GeoJSON bounding box (RFC 7946 §5): a flat array of `2*n` numbers, either
/// 4 (2D, `[west, south, east, north]`) or 6 (3D, with min/max elevation).
///
/// Modeled as a tuple union to match `@types/geojson`'s
/// `BBox = [number, number, number, number] | [number, …×6]`, so it is
/// assignable **to and from** the native type (a plain `number[]` is not).
///
/// Deserializes from a flat array of 4 or 6 numbers; any other length errors.
#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[cfg_attr(feature = "specta", derive(specta::Type))]
#[serde(untagged)]
pub enum Bbox {
    /// 2D bounding box: `[west, south, east, north]`.
    // specta `type =` can't parse an array type (`[T; N]`), but a tuple renders
    // as the same TS tuple, and matches native `BBox`'s `[number, number, …]`.
    D2(
        #[cfg_attr(feature = "specta", specta(type = (TsNumber, TsNumber, TsNumber, TsNumber)))]
        [f64; 4],
    ),
    /// 3D bounding box: `[west, south, min-elev, east, north, max-elev]`.
    D3(
        #[cfg_attr(feature = "specta", specta(type = (TsNumber, TsNumber, TsNumber, TsNumber, TsNumber, TsNumber)))]
         [f64; 6],
    ),
}

impl From<Bbox> for Vec<f64> {
    fn from(bbox: Bbox) -> Self {
        match bbox {
            Bbox::D2(a) => a.to_vec(),
            Bbox::D3(a) => a.to_vec(),
        }
    }
}

/// Build a [`Bbox`] from a flat `Vec<f64>` (as the untyped [`geojson`] crate
/// stores it), accepting only the RFC 7946 lengths of 4 or 6.
pub(crate) fn bbox_from_vec(v: Vec<f64>) -> Result<Bbox, serde_json::Error> {
    match v.len() {
        4 => Ok(Bbox::D2([v[0], v[1], v[2], v[3]])),
        6 => Ok(Bbox::D3([v[0], v[1], v[2], v[3], v[4], v[5]])),
        n => Err(<serde_json::Error as de::Error>::custom(format!(
            "bbox must have 4 or 6 numbers, found {n}"
        ))),
    }
}

/// A GeoJSON Feature `id` — a string or a number (RFC 7946 §3.2).
#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[cfg_attr(feature = "specta", derive(specta::Type))]
#[serde(untagged)]
pub enum Id {
    String(String),
    // serde keeps full numeric fidelity; specta exports it as the native TS
    // `number` (via [`TsNumber`] — `f64` would render as `number | null`).
    Number(#[cfg_attr(feature = "specta", specta(type = TsNumber))] serde_json::Number),
}

/// A GeoJSON `Feature` with typed `G`eometry and `P`roperties.
///
/// `G` defaults to the [`Geometry`] union and `P` to [`Properties`], matching
/// `@types/geojson`'s `Feature<G = Geometry, P = GeoJsonProperties>`. Pin `G` to
/// a single geometry (e.g. [`Point`]) and/or set `P` to your own type.
///
/// Geometry is required but may be `null` (RFC 7946 §3.2); that nullability
/// lives in `G` — `Feature<Option<Geometry>, P>` is the nullable form.
///
/// ```
/// use typed_geojson::{Feature, Point};
///
/// let f: Feature<Point, &str> = Feature::new(Point::new(vec![-96.8, 32.8]), "DFW");
///
/// assert_eq!(
///     serde_json::to_string(&f).unwrap(),
///     r#"{"type":"Feature","geometry":{"type":"Point","coordinates":[-96.8,32.8]},"properties":"DFW"}"#,
/// );
/// ```
#[derive(Clone, Debug, PartialEq)]
pub struct Feature<G = Geometry, P = Properties> {
    pub geometry: G,
    pub properties: P,
    pub id: Option<Id>,
    pub bbox: Option<Bbox>,
    /// Foreign members (RFC 7946 §6.1) preserved verbatim through serde and the
    /// [`geojson`] bridge; empty when there are none. See [`ForeignMembers`].
    pub foreign_members: ForeignMembers,
}

impl<G, P> Feature<G, P> {
    /// A `Feature` with just a geometry and properties (no `id`/`bbox`, no
    /// foreign members).
    ///
    /// Nullability lives in `G`: use `Feature::<Geometry, _>::new(geom, …)` for
    /// a required geometry, or `Feature::<Option<Geometry>, _>::new(None, …)`
    /// for the RFC 7946 "unlocated" (null-geometry) case.
    pub fn new(geometry: G, properties: P) -> Self {
        Self {
            geometry,
            properties,
            id: None,
            bbox: None,
            foreign_members: ForeignMembers::new(),
        }
    }
}

impl<G: Serialize, P: Serialize> Serialize for Feature<G, P> {
    fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
        let mut len = 3; // type, geometry, properties are always present
        if self.id.is_some() {
            len += 1;
        }
        if self.bbox.is_some() {
            len += 1;
        }
        len += self.foreign_members.len();
        let mut map = serializer.serialize_map(Some(len))?;
        map.serialize_entry("type", "Feature")?;
        // RFC 7946: `geometry` is mandatory but may be null.
        map.serialize_entry("geometry", &self.geometry)?;
        map.serialize_entry("properties", &self.properties)?;
        if let Some(id) = &self.id {
            map.serialize_entry("id", id)?;
        }
        if let Some(bbox) = &self.bbox {
            map.serialize_entry("bbox", bbox)?;
        }
        // RFC 7946 §6.1: foreign members sit at the top level of the object.
        for (name, value) in &self.foreign_members {
            map.serialize_entry(name, value)?;
        }
        map.end()
    }
}

// A Feature's member names. Known members map to their variant; anything else
// is an RFC 7946 §6.1 foreign member and keeps its name (owned only for those
// unknown keys — known keys never allocate).
enum FeatureKey {
    Type,
    Geometry,
    Properties,
    Id,
    Bbox,
    Foreign(String),
}

impl<'de> Deserialize<'de> for FeatureKey {
    fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
        struct KeyVisitor;
        impl<'de> Visitor<'de> for KeyVisitor {
            type Value = FeatureKey;

            fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result {
                f.write_str("a GeoJSON Feature member name")
            }

            fn visit_str<E: de::Error>(self, v: &str) -> Result<FeatureKey, E> {
                Ok(match v {
                    "type" => FeatureKey::Type,
                    "geometry" => FeatureKey::Geometry,
                    "properties" => FeatureKey::Properties,
                    "id" => FeatureKey::Id,
                    "bbox" => FeatureKey::Bbox,
                    _ => FeatureKey::Foreign(v.to_owned()),
                })
            }
        }
        deserializer.deserialize_str(KeyVisitor)
    }
}

impl<'de, G: Deserialize<'de>, P: Deserialize<'de>> Deserialize<'de> for Feature<G, P> {
    fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
        struct FeatureVisitor<G, P>(PhantomData<(G, P)>);

        impl<'de, G: Deserialize<'de>, P: Deserialize<'de>> Visitor<'de> for FeatureVisitor<G, P> {
            type Value = Feature<G, P>;

            fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result {
                f.write_str("a GeoJSON Feature object")
            }

            fn visit_map<M: MapAccess<'de>>(self, mut map: M) -> Result<Feature<G, P>, M::Error> {
                let mut had_type = false;
                let mut geometry: Option<G> = None;
                let mut properties: Option<P> = None;
                let mut id: Option<Id> = None;
                let mut bbox: Option<Bbox> = None;
                let mut foreign_members = ForeignMembers::new();

                while let Some(key) = map.next_key()? {
                    match key {
                        FeatureKey::Type => {
                            let ty: String = map.next_value()?;
                            if ty != "Feature" {
                                return Err(de::Error::custom(format!(
                                    "expected `type` to be \"Feature\", found {ty:?}"
                                )));
                            }
                            had_type = true;
                        }
                        FeatureKey::Geometry => geometry = Some(map.next_value()?),
                        FeatureKey::Properties => properties = Some(map.next_value()?),
                        FeatureKey::Id => id = map.next_value()?,
                        FeatureKey::Bbox => bbox = map.next_value()?,
                        // Preserve unknown keys as RFC 7946 §6.1 foreign members.
                        FeatureKey::Foreign(name) => {
                            foreign_members.insert(name, map.next_value()?);
                        }
                    }
                }

                if !had_type {
                    return Err(de::Error::missing_field("type"));
                }
                // RFC 7946: the `geometry` member is mandatory (its value may
                // be null, which a nullable `G` such as `Option<_>` accepts).
                Ok(Feature {
                    geometry: geometry.ok_or_else(|| de::Error::missing_field("geometry"))?,
                    properties: properties.ok_or_else(|| de::Error::missing_field("properties"))?,
                    id,
                    bbox,
                    foreign_members,
                })
            }
        }

        deserializer.deserialize_map(FeatureVisitor(PhantomData))
    }
}

/// A GeoJSON `FeatureCollection` of typed features.
///
/// `collect` from any iterator of [`Feature`]s:
///
/// ```
/// use typed_geojson::{Feature, FeatureCollection, Point};
///
/// let fc: FeatureCollection<Point, &str> = [
///     Feature::new(Point::new(vec![0.0, 0.0]), "origin"),
///     Feature::new(Point::new(vec![1.0, 1.0]), "ne"),
/// ]
/// .into_iter()
/// .collect();
///
/// assert_eq!(fc.features.len(), 2);
/// assert!(serde_json::to_string(&fc).unwrap().starts_with(r#"{"type":"FeatureCollection""#));
/// ```
#[derive(Clone, Debug, PartialEq)]
pub struct FeatureCollection<G = Geometry, P = Properties> {
    pub features: Vec<Feature<G, P>>,
    pub bbox: Option<Bbox>,
    /// Foreign members (RFC 7946 §6.1) preserved verbatim; empty when there are
    /// none. See [`ForeignMembers`].
    pub foreign_members: ForeignMembers,
}

impl<G, P> FromIterator<Feature<G, P>> for FeatureCollection<G, P> {
    fn from_iter<I: IntoIterator<Item = Feature<G, P>>>(iter: I) -> Self {
        Self {
            features: iter.into_iter().collect(),
            bbox: None,
            foreign_members: ForeignMembers::new(),
        }
    }
}

impl<G: Serialize, P: Serialize> Serialize for FeatureCollection<G, P> {
    fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
        let mut len = 2; // type, features
        if self.bbox.is_some() {
            len += 1;
        }
        len += self.foreign_members.len();
        let mut map = serializer.serialize_map(Some(len))?;
        map.serialize_entry("type", "FeatureCollection")?;
        map.serialize_entry("features", &self.features)?;
        if let Some(bbox) = &self.bbox {
            map.serialize_entry("bbox", bbox)?;
        }
        // RFC 7946 §6.1: foreign members sit at the top level of the object.
        for (name, value) in &self.foreign_members {
            map.serialize_entry(name, value)?;
        }
        map.end()
    }
}

// A FeatureCollection's member names; see [`FeatureKey`].
enum CollectionKey {
    Type,
    Features,
    Bbox,
    Foreign(String),
}

impl<'de> Deserialize<'de> for CollectionKey {
    fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
        struct KeyVisitor;
        impl<'de> Visitor<'de> for KeyVisitor {
            type Value = CollectionKey;

            fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result {
                f.write_str("a GeoJSON FeatureCollection member name")
            }

            fn visit_str<E: de::Error>(self, v: &str) -> Result<CollectionKey, E> {
                Ok(match v {
                    "type" => CollectionKey::Type,
                    "features" => CollectionKey::Features,
                    "bbox" => CollectionKey::Bbox,
                    _ => CollectionKey::Foreign(v.to_owned()),
                })
            }
        }
        deserializer.deserialize_str(KeyVisitor)
    }
}

impl<'de, G: Deserialize<'de>, P: Deserialize<'de>> Deserialize<'de> for FeatureCollection<G, P> {
    fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
        struct CollectionVisitor<G, P>(PhantomData<(G, P)>);

        impl<'de, G: Deserialize<'de>, P: Deserialize<'de>> Visitor<'de> for CollectionVisitor<G, P> {
            type Value = FeatureCollection<G, P>;

            fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result {
                f.write_str("a GeoJSON FeatureCollection object")
            }

            fn visit_map<M: MapAccess<'de>>(
                self,
                mut map: M,
            ) -> Result<FeatureCollection<G, P>, M::Error> {
                let mut had_type = false;
                let mut features: Option<Vec<Feature<G, P>>> = None;
                let mut bbox: Option<Bbox> = None;
                let mut foreign_members = ForeignMembers::new();

                while let Some(key) = map.next_key()? {
                    match key {
                        CollectionKey::Type => {
                            let ty: String = map.next_value()?;
                            if ty != "FeatureCollection" {
                                return Err(de::Error::custom(format!(
                                    "expected `type` to be \"FeatureCollection\", found {ty:?}"
                                )));
                            }
                            had_type = true;
                        }
                        CollectionKey::Features => features = Some(map.next_value()?),
                        CollectionKey::Bbox => bbox = map.next_value()?,
                        // Preserve unknown keys as RFC 7946 §6.1 foreign members.
                        CollectionKey::Foreign(name) => {
                            foreign_members.insert(name, map.next_value()?);
                        }
                    }
                }

                if !had_type {
                    return Err(de::Error::missing_field("type"));
                }
                Ok(FeatureCollection {
                    features: features.ok_or_else(|| de::Error::missing_field("features"))?,
                    bbox,
                    foreign_members,
                })
            }
        }

        deserializer.deserialize_map(CollectionVisitor(PhantomData))
    }
}

// --- bridges to/from the untyped `geojson` crate (default geometry only) ------

impl From<Id> for geojson::feature::Id {
    fn from(id: Id) -> Self {
        match id {
            Id::String(s) => geojson::feature::Id::String(s),
            Id::Number(n) => geojson::feature::Id::Number(n),
        }
    }
}

impl From<geojson::feature::Id> for Id {
    fn from(id: geojson::feature::Id) -> Self {
        match id {
            geojson::feature::Id::String(s) => Id::String(s),
            geojson::feature::Id::Number(n) => Id::Number(n),
        }
    }
}

// Bridges to/from the untyped `geojson::Feature`, whose geometry is nullable,
// so the typed side is `Feature<Option<Geometry>, P>`. Geometry crosses via the
// `Geometry` <-> `geojson::Geometry` `TryFrom`s (see `geometry.rs`).
impl<P: Serialize> TryFrom<Feature<Option<Geometry>, P>> for geojson::Feature {
    type Error = serde_json::Error;

    fn try_from(f: Feature<Option<Geometry>, P>) -> Result<Self, Self::Error> {
        let properties = match serde_json::to_value(&f.properties)? {
            serde_json::Value::Object(map) => Some(map),
            serde_json::Value::Null => None,
            _ => {
                return Err(<serde_json::Error as serde::ser::Error>::custom(
                    "Feature properties must serialize to a JSON object or null",
                ));
            }
        };
        Ok(geojson::Feature {
            bbox: f.bbox.map(Into::into),
            geometry: f.geometry.map(geojson::Geometry::try_from).transpose()?,
            id: f.id.map(Into::into),
            properties,
            // Carry foreign members across (RFC 7946 §6.1); `geojson` normalizes
            // an empty map to `None`, so match that rather than emit `Some({})`.
            foreign_members: (!f.foreign_members.is_empty()).then_some(f.foreign_members),
        })
    }
}

impl<P: serde::de::DeserializeOwned> TryFrom<geojson::Feature> for Feature<Option<Geometry>, P> {
    type Error = serde_json::Error;

    fn try_from(f: geojson::Feature) -> Result<Self, Self::Error> {
        let value = match f.properties {
            Some(map) => serde_json::Value::Object(map),
            None => serde_json::Value::Null,
        };
        Ok(Feature {
            geometry: f.geometry.map(Geometry::try_from).transpose()?,
            properties: serde_json::from_value(value)?,
            id: f.id.map(Into::into),
            bbox: f.bbox.map(bbox_from_vec).transpose()?,
            // Preserve any foreign members the untyped Feature carried.
            foreign_members: f.foreign_members.unwrap_or_default(),
        })
    }
}

/// Register every public typed-geojson type into a [`specta::Types`] collection,
/// ready to hand to a language exporter (e.g. `specta_typescript`).
///
/// The collection contains the generic `Feature<G, P>` / `FeatureCollection<G, P>`
/// plus `Geometry` (and each named geometry), `Id`, and `Bbox` — shaped to be
/// mutually assignable with `@types/geojson`. Requires the `specta` feature.
///
/// ```
/// # #[cfg(feature = "specta")]
/// # {
/// let types = typed_geojson::specta_types();
/// // let ts = specta_typescript::Typescript::default()
/// //     .export(&types, specta_serde::Format)?;
/// # }
/// ```
#[cfg(feature = "specta")]
pub fn specta_types() -> specta::Types {
    // `Feature`/`FeatureCollection` are generic; the concrete `Geometry` args
    // here only satisfy registration — specta emits the generic `<G, P>` form.
    specta::Types::default()
        .register::<__ts::Feature<Geometry, Geometry>>()
        .register::<__ts::FeatureCollection<Geometry, Geometry>>()
        .register::<Geometry>()
        .register::<Id>()
        .register::<Bbox>()
}

// --- specta export shadows ----------------------------------------------------
//
// `Feature` / `FeatureCollection` use *manual* serde and so have no `type`
// field for `#[derive(specta::Type)]` to see. These shadows mirror the exact
// wire shape — including the literal `"type"` tag — and exist only to drive
// TypeScript generation. They are not part of the public API.
//
// The runtime `foreign_members` map (RFC 7946 §6.1) is deliberately absent
// here: `@types/geojson` does not type foreign members either, so surfacing
// one would break the assignability promise. They stay runtime-only fidelity.
#[cfg(feature = "specta")]
#[doc(hidden)]
#[allow(dead_code)]
pub mod __ts {
    use serde::{Deserialize, Serialize};

    use super::{Bbox, Id};

    // These derive serde only so `#[serde(rename)]` (which specta reads for the
    // `type`/container names) is valid — the serde impls are never used.

    /// The `"Feature"` value of a Feature's `type` member.
    #[derive(Serialize, Deserialize, specta::Type)]
    pub enum FeatureType {
        Feature,
    }

    /// The `"FeatureCollection"` value of a collection's `type` member.
    #[derive(Serialize, Deserialize, specta::Type)]
    pub enum FeatureCollectionType {
        FeatureCollection,
    }

    /// A GeoJSON Feature: a geometry `G` and its associated `properties` `P`
    /// (RFC 7946 §3.2).
    #[derive(Serialize, Deserialize, specta::Type)]
    #[serde(rename = "Feature")]
    pub struct Feature<G, P> {
        #[serde(rename = "type")]
        r#type: FeatureType,
        geometry: G,
        properties: P,
        #[specta(type = Id, optional)]
        id: Option<Id>,
        #[specta(type = Bbox, optional)]
        bbox: Option<Bbox>,
    }

    /// A GeoJSON FeatureCollection: a list of `Feature`s (RFC 7946 §3.3).
    #[derive(Serialize, Deserialize, specta::Type)]
    #[serde(rename = "FeatureCollection")]
    pub struct FeatureCollection<G, P> {
        #[serde(rename = "type")]
        r#type: FeatureCollectionType,
        features: Vec<Feature<G, P>>,
        #[specta(type = Bbox, optional)]
        bbox: Option<Bbox>,
    }
}