1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
//! Delivery coordination trait and types.
//!
//! [`A2aPushDeliveryStore`] is the contract every backend must
//! implement so a multi-instance deployment can share the "who is
//! delivering which event to which config" state without double-posting.
//!
//! # Claim model
//!
//! Deliveries are coordinated by an atomic **claim** on the tuple
//! `(tenant, task_id, event_sequence, config_id)`. The first writer
//! wins; later writers observe
//! [`A2aStorageError::ClaimAlreadyHeld`]. A claim carries a
//! `claimant` identifier (typically the server instance id), a
//! monotonic `generation` fencing token, a `claimed_at` timestamp, a
//! `delivery_attempt_count` (cluster-wide HTTP POST attempts —
//! advanced only by [`A2aPushDeliveryStore::record_attempt_started`],
//! never by `claim_delivery`), and a [`ClaimStatus`].
//!
//! Claims are **expirable**: a claim whose `claimed_at +
//! claim_expiry` has passed and whose status is still `Pending` or
//! `Attempting` is eligible for re-claim by any other instance. On
//! re-claim, `generation` increments and `claimant` is replaced;
//! `delivery_attempt_count` is **not** changed by re-claim (a worker
//! that crashed before POSTing must not be billed against the budget).
//! This bounds total POST attempts to `push_max_attempts` even across
//! worker crashes: the new claimant picks up at whatever count the
//! prior claimant left on the row, then advances it only when it
//! actually starts a POST.
//!
//! Claims with terminal status (`Succeeded`, `GaveUp`, `Abandoned`)
//! are **not** re-claimable. `claim_delivery` MUST return
//! `ClaimAlreadyHeld` against such rows regardless of how long ago
//! they were written. This is load-bearing for at-least-once
//! semantics: once a receiver has confirmed the POST, the framework
//! does not re-POST.
//!
//! # Fencing — outcome recording is pinned to the claim identity
//!
//! [`A2aPushDeliveryStore::record_delivery_outcome`] takes the
//! `claimant` and `claim_generation` that were returned by the
//! original `claim_delivery`. The store compares them against the
//! currently-stored claim identity and returns
//! [`A2aStorageError::StaleDeliveryClaim`] if they do not match.
//!
//! This closes the stalled-worker race: if worker A claims, GC-pauses
//! past expiry, worker B re-claims with `generation = g+1`, and A
//! then wakes and attempts to record an outcome against `generation =
//! g`, the store rejects A's write. A terminal state committed by
//! B cannot be overwritten by a stale A, and A's retry loop aborts on
//! the `StaleDeliveryClaim` error.
//!
//! # Outcome model
//!
//! A worker reports progress via
//! [`A2aPushDeliveryStore::record_delivery_outcome`] with one of the
//! four variants of [`DeliveryOutcome`]. There is no separate
//! `release_claim` method — reporting the outcome IS the release,
//! and the outcome variant determines whether the claim freezes
//! (`Succeeded`, `GaveUp`, `Abandoned`) or stays open for the next
//! retry (`Retry`).
//!
//! # Secret redaction (ADR-011 §4a)
//!
//! Neither this trait surface nor its persisted row shape carries
//! credentials, tokens, request bodies, or receiver response bodies.
//! Failure diagnostics flow through [`DeliveryErrorClass`] — an enum
//! of classifications, not free-text strings. Terminal reason fields
//! on `GaveUp` and `Abandoned` are enum-typed
//! ([`GaveUpReason`], [`AbandonedReason`]), not free-text; the trait
//! surface offers no slot into which a worker could accidentally
//! thread variable user data. `config_id` is the stable handle
//! operators use to cross-reference a failure back to the push
//! config CRUD row.
//!
//! # Observability
//!
//! `claim_delivery` is called once per (event, config) pair. Callers
//! are expected to emit `framework.push_claim_attempts` /
//! `_conflicts` tracing events around the call (see ADR-011 §9). The
//! store does not emit telemetry itself — it only provides the
//! race-free primitive.
//!
//! # Expiry sweep
//!
//! [`A2aPushDeliveryStore::sweep_expired_claims`] runs on a
//! deployment-configured cadence. It reopens `Pending` / `Attempting`
//! claims whose expiry has passed — not `Succeeded` / `GaveUp` /
//! `Abandoned` — and returns the count for operator visibility.
//! DynamoDB implementations may defer reopening to the next
//! `claim_delivery` call's ConditionExpression; such a lazy sweep
//! returns 0.
use ;
use async_trait;
use crateA2aStorageError;
/// Delivery-coordination storage. Separate from
/// [`crate::storage::A2aPushNotificationStorage`] (config CRUD).
/// Implemented alongside the other storage traits by the same
/// backend struct; same-backend enforcement in the server builder
/// includes this trait when a `PushDeliveryWorker` is configured.
/// Snapshot of a claim row as returned by
/// [`A2aPushDeliveryStore::claim_delivery`].
///
/// `#[non_exhaustive]` so additional observability fields can land
/// in patch releases without breaking callers. Workers read
/// `claimant` and `generation` from this struct and pass them back
/// verbatim to [`A2aPushDeliveryStore::record_delivery_outcome`]
/// as the fencing token.
/// Lifecycle states of a delivery claim.
///
/// Five states, by design:
/// - `Pending` — claim acquired; no POST attempted yet.
/// - `Attempting` — POST in flight OR a retry is scheduled. The
/// store does not distinguish "POST in flight" from "retry
/// scheduled" — those are worker-local states.
/// - `Succeeded` — delivery confirmed (2xx / 3xx).
/// - `GaveUp` — final failure after `push_max_attempts` OR a
/// pre-POST rejection that operators should see
/// (`SsrfBlocked`, `PayloadTooLarge`, `TlsRejected`). Row
/// retained for operator inspection per
/// `push_failed_delivery_retention`.
/// - `Abandoned` — terminal but not failed (config deleted, task
/// deleted, non-HTTPS URL in production). Row retained briefly
/// for audit; not surfaced by `list_failed_deliveries`.
/// Outcome reported via [`A2aPushDeliveryStore::record_delivery_outcome`].
///
/// Secret-safety invariant (ADR-011 §4a): no variant carries
/// free-text derived from user input, receiver responses, or
/// credential material. Retry diagnostics use
/// [`DeliveryErrorClass`]; terminal reasons use framework-owned
/// enums ([`GaveUpReason`], [`AbandonedReason`]).
/// Framework-controlled reasons a delivery was given up.
///
/// Enum-only (no free-text variant) so a worker cannot thread
/// variable data — credentials, URLs, response bodies — into a
/// persisted claim row. `#[non_exhaustive]` so additional reasons
/// can be added in patch releases.
///
/// All variants here correspond to cases that SHOULD be visible
/// via [`A2aPushDeliveryStore::list_failed_deliveries`] — operators
/// see these and investigate.
/// Framework-controlled reasons a delivery was abandoned.
///
/// Enum-only for the same reason as [`GaveUpReason`]. `Abandoned`
/// outcomes are NOT surfaced by `list_failed_deliveries` — they
/// represent "the delivery no longer needs to happen", not "a
/// delivery failed".
/// Classified failure reasons. Enum-only so credential / PII
/// leakage through error strings is structurally impossible. Add
/// new variants when a new class of failure is introduced.
/// Public shape of a failed-delivery record returned by
/// [`A2aPushDeliveryStore::list_failed_deliveries`].
///
/// Carries classified diagnostics only — no credentials, no tokens,
/// no request bodies, no receiver response bodies. `config_id`
/// cross-references to the push-config CRUD store if operators
/// need receiver URL / scheme details.
/// Row returned by
/// [`A2aPushDeliveryStore::list_reclaimable_claims`]. Carries just
/// enough identity for the sweeper to reassemble the target:
/// `(tenant, owner, task_id, event_sequence, config_id)`. Owner is
/// persisted on the claim row by `claim_delivery` so the reclaim
/// path can call the owner-scoped
/// [`crate::storage::A2aTaskStorage::get_task`] without a separate
/// unscoped read method.
/// Row returned by
/// [`A2aPushDeliveryStore::list_stale_pending_dispatches`]. Enough
/// identity for the reclaim loop to call
/// [`crate::storage::A2aTaskStorage::get_task`] and re-run the
/// fan-out logic a fresh dispatch would perform.