1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
// Expression compilation for incremental operators
// This module provides utilities to compile SQL expressions into VDBE subprograms
// that can be executed efficiently in the incremental computation context.
use crate::numeric::Numeric;
use crate::schema::Schema;
use crate::storage::pager::Pager;
use crate::sync::Arc;
use crate::translate::emitter::{DoubleQuotedDml, Resolver};
use crate::translate::expr::translate_expr;
use crate::types::Text;
use crate::vdbe::builder::{ProgramBuilder, ProgramBuilderOpts};
use crate::vdbe::insn::Insn;
use crate::vdbe::{Program, ProgramState, Register};
use crate::{Connection, QueryMode, Result, Value};
use crate::{DatabaseCatalog, RwLock, SymbolTable};
use rustc_hash::FxHashMap as HashMap;
use turso_parser::ast::{Expr, Literal, Operator};
// Transform an expression to replace column references with Register expressions Why do we want to
// do this?
//
// Imagine you have a view like:
//
// create materialized view hex(count(*) + 2). translate_expr will usually try to find match names
// to either literals or columns. But "count(*)" is not a column in any sqlite table.
//
// We *could* theoretically have a table-representation of every DBSP-step, but it is a lot simpler
// to just pass registers as parameters to the VDBE expression, and teach translate_expr to
// recognize those.
//
// But because the expression compiler will not generate those register inputs, we have to
// transform the expression.
fn transform_expr_for_dbsp(expr: &Expr, input_column_names: &[String]) -> Expr {
match expr {
// Transform column references (represented as Id) to Register expressions
Expr::Id(name) => {
// Check if this is a column name from our input
if let Some(idx) = input_column_names
.iter()
.position(|col| col == name.as_str())
{
// Replace with a Register expression
Expr::Register(idx)
} else {
// Not a column reference, keep as is
expr.clone()
}
}
// Recursively transform nested expressions
Expr::Binary(lhs, op, rhs) => Expr::Binary(
Box::new(transform_expr_for_dbsp(lhs, input_column_names)),
*op,
Box::new(transform_expr_for_dbsp(rhs, input_column_names)),
),
Expr::Unary(op, operand) => Expr::Unary(
*op,
Box::new(transform_expr_for_dbsp(operand, input_column_names)),
),
Expr::FunctionCall {
name,
distinctness,
args,
order_by,
filter_over,
} => Expr::FunctionCall {
name: name.clone(),
distinctness: *distinctness,
args: args
.iter()
.map(|arg| Box::new(transform_expr_for_dbsp(arg, input_column_names)))
.collect(),
order_by: order_by.clone(),
filter_over: filter_over.clone(),
},
Expr::Parenthesized(exprs) => Expr::Parenthesized(
exprs
.iter()
.map(|e| Box::new(transform_expr_for_dbsp(e, input_column_names)))
.collect(),
),
// For other expression types, keep as is
_ => expr.clone(),
}
}
/// Enum to represent either a trivial or compiled expression
#[derive(Clone)]
pub enum ExpressionExecutor {
/// Trivial expression that can be evaluated inline
Trivial(TrivialExpression),
/// Compiled VDBE program for complex expressions
Compiled(Arc<Program>),
}
/// Trivial expression that can be evaluated inline without VDBE
/// Supports arithmetic operations with automatic type promotion (integer to float)
#[derive(Clone, Debug)]
pub enum TrivialExpression {
/// Direct column reference
Column(usize),
/// Immediate value
Immediate(Value),
/// Binary operation on trivial expressions (supports type promotion)
Binary {
left: Box<TrivialExpression>,
op: Operator,
right: Box<TrivialExpression>,
},
}
impl TrivialExpression {
/// Evaluate the trivial expression with the given input values
/// Automatically promotes integers to floats when mixing types in arithmetic
pub fn evaluate(&self, values: &[Value]) -> Value {
match self {
TrivialExpression::Column(idx) => values.get(*idx).cloned().unwrap_or(Value::Null),
TrivialExpression::Immediate(val) => val.clone(),
TrivialExpression::Binary { left, op, right } => {
let left_val = left.evaluate(values);
let right_val = right.evaluate(values);
// Use Value's exec_* methods which handle all type coercion
// (including Text → Numeric) consistently with SQLite semantics
match op {
Operator::Add => left_val.exec_add(&right_val),
Operator::Subtract => left_val.exec_subtract(&right_val),
Operator::Multiply => left_val.exec_multiply(&right_val),
Operator::Divide => left_val.exec_divide(&right_val),
_ => panic!("Unsupported operator in trivial expression: {op:?}"),
}
}
}
}
}
/// Compiled expression that can be executed on row values
#[derive(Clone)]
pub struct CompiledExpression {
/// The expression executor (trivial or compiled)
pub executor: ExpressionExecutor,
/// Number of input values expected (columns from the row)
pub input_count: usize,
}
impl std::fmt::Debug for CompiledExpression {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
let mut s = f.debug_struct("CompiledExpression");
s.field("input_count", &self.input_count);
match &self.executor {
ExpressionExecutor::Trivial(t) => s.field("executor", &format!("Trivial({t:?})")),
ExpressionExecutor::Compiled(p) => {
s.field("executor", &format!("Compiled({} insns)", p.insns.len()))
}
};
s.finish()
}
}
#[derive(PartialEq)]
enum TrivialType {
Integer,
Float,
Text,
Null,
}
impl CompiledExpression {
/// Get the "type" of a trivial expression for type checking
/// Returns None if type can't be determined statically
fn get_trivial_type(expr: &TrivialExpression) -> Option<TrivialType> {
match expr {
TrivialExpression::Column(_) => None, // Can't know column type statically
TrivialExpression::Immediate(val) => match val {
Value::Numeric(Numeric::Integer(_)) => Some(TrivialType::Integer),
Value::Numeric(Numeric::Float(_)) => Some(TrivialType::Float),
Value::Text(_) => Some(TrivialType::Text),
Value::Null => Some(TrivialType::Null),
_ => None,
},
TrivialExpression::Binary { left, right, .. } => {
// For binary ops, both sides must have the same type
let left_type = Self::get_trivial_type(left)?;
let right_type = Self::get_trivial_type(right)?;
if left_type == right_type {
Some(left_type)
} else {
None // Type mismatch
}
}
}
}
// Validates if an expression is trivial (columns, immediates, and simple arithmetic)
// Only considers expressions trivial if they don't require type coercion
fn try_get_trivial_expr(
expr: &Expr,
input_column_names: &[String],
) -> Option<TrivialExpression> {
match expr {
// Column reference or register
Expr::Id(name) => input_column_names
.iter()
.position(|col| col == name.as_str())
.map(TrivialExpression::Column),
Expr::Register(idx) => Some(TrivialExpression::Column(*idx)),
// Immediate values
Expr::Literal(lit) => {
let value = match lit {
Literal::Numeric(n) => {
if let Ok(i) = n.parse::<i64>() {
Value::from_i64(i)
} else if let Ok(f) = n.parse::<f64>() {
Value::from_f64(f)
} else {
return None;
}
}
Literal::String(s) => {
let cleaned = s.trim_matches('\'').trim_matches('"').to_string();
Value::Text(Text::new(cleaned))
}
Literal::Null => Value::Null,
_ => return None,
};
Some(TrivialExpression::Immediate(value))
}
// Binary operations with simple operators
Expr::Binary(left, op, right) => {
// Only support simple arithmetic operators
match op {
Operator::Add | Operator::Subtract | Operator::Multiply | Operator::Divide => {
// Both operands must be trivial
let left_trivial = Self::try_get_trivial_expr(left, input_column_names)?;
let right_trivial = Self::try_get_trivial_expr(right, input_column_names)?;
// Check if we can determine types statically
// For arithmetic operations, we allow mixing integers and floats
// since we promote integers to floats as needed
if let (Some(left_type), Some(right_type)) = (
Self::get_trivial_type(&left_trivial),
Self::get_trivial_type(&right_trivial),
) {
// Both types are known - check if they're numeric or null
let numeric_types = matches!(
left_type,
TrivialType::Integer | TrivialType::Float | TrivialType::Null
) && matches!(
right_type,
TrivialType::Integer | TrivialType::Float | TrivialType::Null
);
if !numeric_types {
return None; // Non-numeric types - not trivial
}
}
// If we can't determine types (columns involved), we optimistically
// assume they'll be compatible at runtime
Some(TrivialExpression::Binary {
left: Box::new(left_trivial),
op: *op,
right: Box::new(right_trivial),
})
}
_ => None,
}
}
// Parenthesized expressions with single element
Expr::Parenthesized(exprs) if exprs.len() == 1 => {
Self::try_get_trivial_expr(&exprs[0], input_column_names)
}
_ => None,
}
}
/// Compile a SQL expression into either a trivial executor or VDBE program
///
/// For trivial expressions (columns, immediates, simple same-type arithmetic), uses inline evaluation.
/// For complex expressions or those requiring type coercion, compiles to VDBE bytecode.
pub fn compile(
expr: &Expr,
input_column_names: &[String],
schema: &Schema,
syms: &SymbolTable,
connection: Arc<Connection>,
) -> Result<Self> {
let input_count = input_column_names.len();
// First, check if this is a trivial expression
if let Some(trivial) = Self::try_get_trivial_expr(expr, input_column_names) {
return Ok(CompiledExpression {
executor: ExpressionExecutor::Trivial(trivial),
input_count,
});
}
// Fall back to VDBE compilation for complex expressions
// Create a minimal program builder for expression compilation
let mut builder =
ProgramBuilder::new(QueryMode::Normal, None, ProgramBuilderOpts::new(0, 5, 0));
// Allocate registers for input values
let input_count = input_column_names.len();
// Allocate input registers
for _ in 0..input_count {
builder.alloc_register();
}
// Allocate a temp register for computation
let temp_result_register = builder.alloc_register();
// Transform the expression to replace column references with Register expressions
let transformed_expr = transform_expr_for_dbsp(expr, input_column_names);
// Create a resolver for translate_expr
let database_schemas = RwLock::new(HashMap::default());
let temp_database = RwLock::new(None);
let attached_databases = RwLock::new(DatabaseCatalog::new());
let resolver = Resolver::new(
schema,
&database_schemas,
&temp_database,
&attached_databases,
syms,
true,
DoubleQuotedDml::Enabled,
);
// Translate the transformed expression to bytecode
translate_expr(
&mut builder,
None, // No table references needed for pure expressions
&transformed_expr,
temp_result_register,
&resolver,
)?;
// Copy the result to register 0 for return
builder.emit_insn(Insn::Copy {
src_reg: temp_result_register,
dst_reg: 0,
extra_amount: 0,
});
// Add a Halt instruction to complete the subprogram
builder.emit_insn(Insn::Halt {
err_code: 0,
description: String::new(),
on_error: None,
description_reg: None,
});
// Build the program from the compiled expression bytecode
let program = Arc::new(builder.build(connection, false, "")?);
Ok(CompiledExpression {
executor: ExpressionExecutor::Compiled(program),
input_count,
})
}
/// Execute the compiled expression with the given input values
pub fn execute(&self, values: &[Value], pager: Arc<Pager>) -> Result<Value> {
match &self.executor {
ExpressionExecutor::Trivial(trivial) => {
// Fast path: evaluate trivial expression inline
Ok(trivial.evaluate(values))
}
ExpressionExecutor::Compiled(program) => {
// Slow path: execute VDBE program
// Create a state with the input values loaded into registers
let mut state = ProgramState::new(program.max_registers, 0);
// Load input values into registers
assert_eq!(
values.len(),
self.input_count,
"Mismatch in number of registers! Got {}, expected {}",
values.len(),
self.input_count
);
for (idx, value) in values.iter().enumerate() {
state.set_register(idx, Register::Value(value.clone()));
}
// Execute the program
let mut pc = 0usize;
while pc < program.insns.len() {
let (insn, _) = &program.insns[pc];
let insn_fn = insn.to_function();
state.pc = pc as u32;
// Execute the instruction
match insn_fn(program, &mut state, insn, &pager)? {
crate::vdbe::execute::InsnFunctionStepResult::IO(_) => {
return Err(crate::LimboError::InternalError(
"Expression evaluation encountered unexpected I/O".to_string(),
));
}
crate::vdbe::execute::InsnFunctionStepResult::Done => {
break;
}
crate::vdbe::execute::InsnFunctionStepResult::Row => {
return Err(crate::LimboError::InternalError(
"Expression evaluation produced unexpected row".to_string(),
));
}
crate::vdbe::execute::InsnFunctionStepResult::Step => {
pc = state.pc as usize;
}
}
}
// The compiled expression puts the result in register 0
match state.get_register(0) {
Register::Value(v) => Ok(v.clone()),
_ => Ok(Value::Null),
}
}
}
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_mixed_type_arithmetic() {
// Test integer - float
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Immediate(Value::from_i64(1))),
op: Operator::Subtract,
right: Box::new(TrivialExpression::Immediate(Value::from_f64(0.5))),
};
let result = expr.evaluate(&[]);
assert_eq!(result, Value::from_f64(0.5));
// Test float - integer
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Immediate(Value::from_f64(2.5))),
op: Operator::Subtract,
right: Box::new(TrivialExpression::Immediate(Value::from_i64(1))),
};
let result = expr.evaluate(&[]);
assert_eq!(result, Value::from_f64(1.5));
// Test integer * float
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Immediate(Value::from_i64(10))),
op: Operator::Multiply,
right: Box::new(TrivialExpression::Immediate(Value::from_f64(0.1))),
};
let result = expr.evaluate(&[]);
assert_eq!(result, Value::from_f64(1.0));
// Test integer / float
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Immediate(Value::from_i64(1))),
op: Operator::Divide,
right: Box::new(TrivialExpression::Immediate(Value::from_f64(2.0))),
};
let result = expr.evaluate(&[]);
assert_eq!(result, Value::from_f64(0.5));
// Test integer + float
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Immediate(Value::from_i64(1))),
op: Operator::Add,
right: Box::new(TrivialExpression::Immediate(Value::from_f64(0.5))),
};
let result = expr.evaluate(&[]);
assert_eq!(result, Value::from_f64(1.5));
}
#[test]
fn test_nested_mixed_type_expressions() {
// Test nested expressions with mixed types: (1 - 0.04)
let one_minus_float = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Immediate(Value::from_i64(1))),
op: Operator::Subtract,
right: Box::new(TrivialExpression::Immediate(Value::from_f64(0.04))),
};
let result = one_minus_float.evaluate(&[]);
assert_eq!(result, Value::from_f64(0.96));
// Test multiplication with nested mixed-type expression: 100.0 * (1 - 0.04)
let nested_expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Immediate(Value::from_f64(100.0))),
op: Operator::Multiply,
right: Box::new(one_minus_float),
};
let result = nested_expr.evaluate(&[]);
assert_eq!(result, Value::from_f64(96.0));
}
#[test]
fn test_text_to_numeric_coercion_in_arithmetic() {
// Non-numeric text should coerce to 0 (SQLite behavior)
let values = vec![Value::Text(Text::new("hello".to_string()))];
// text - 1 => 0 - 1 = -1
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Column(0)),
op: Operator::Subtract,
right: Box::new(TrivialExpression::Immediate(Value::from_i64(1))),
};
assert_eq!(expr.evaluate(&values), Value::from_i64(-1));
// text + 1 => 0 + 1 = 1
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Column(0)),
op: Operator::Add,
right: Box::new(TrivialExpression::Immediate(Value::from_i64(1))),
};
assert_eq!(expr.evaluate(&values), Value::from_i64(1));
// text * 2 => 0 * 2 = 0
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Column(0)),
op: Operator::Multiply,
right: Box::new(TrivialExpression::Immediate(Value::from_i64(2))),
};
assert_eq!(expr.evaluate(&values), Value::from_i64(0));
// text / 2 => 0 / 2 = 0
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Column(0)),
op: Operator::Divide,
right: Box::new(TrivialExpression::Immediate(Value::from_i64(2))),
};
assert_eq!(expr.evaluate(&values), Value::from_i64(0));
// Numeric text "42" - 1 => 41
let numeric_text_values = vec![Value::Text(Text::new("42".to_string()))];
let expr = TrivialExpression::Binary {
left: Box::new(TrivialExpression::Column(0)),
op: Operator::Subtract,
right: Box::new(TrivialExpression::Immediate(Value::from_i64(1))),
};
assert_eq!(expr.evaluate(&numeric_text_values), Value::from_i64(41));
}
}