turbospark-runtime 0.3.0

The raw-completion prefill+decode loop: wires a LogitProducer, the tokenizer, and the selection sampler into one token generation loop.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
//! Generic dynamic Metal kernel dispatchers for GEMV, Embedding lookups,
//! and MoE phased execution across affine and GGUF block types.

use model_io::ResidentIndex;

use crate::real_forward_layout::{
    DTYPE_GGUF_IQ1_M, DTYPE_GGUF_IQ1_S, DTYPE_GGUF_IQ2_S, DTYPE_GGUF_IQ2_XS, DTYPE_GGUF_IQ2_XXS,
    DTYPE_GGUF_IQ3_S, DTYPE_GGUF_IQ3_XXS, DTYPE_GGUF_IQ4_NL, DTYPE_GGUF_IQ4_XS, DTYPE_GGUF_Q2_K,
    DTYPE_GGUF_Q3_K, DTYPE_GGUF_Q4_K, DTYPE_GGUF_Q5_K, DTYPE_GGUF_Q6_K, DTYPE_GGUF_Q8_0,
    DTYPE_INT1_AFFINE, DTYPE_INT2_AFFINE, DTYPE_RAW_BF16,
};
use crate::real_forward_types::RealForwardError;
use crate::real_forward_utils::{affine_group_size, entry, resident_matrix};

pub(crate) use crate::real_forward_dispatch_moe::{encode_moe_phase1_any, encode_moe_phase2_any};

/// Shape/size bounds for a block-quantized embedding table: the table must be
/// `[vocab, hidden]`, `hidden` must tile whole superblocks, the byte run must
/// be exactly `rows * row_bytes`, and the selected row must land inside it. A
/// wrong stride or a hand-edited manifest fails here rather than reading a
/// neighbouring token's row.
fn validate_block_quant_embedding(
    e: &model_io::ResidentIndexEntry,
    name: &str,
    token: u32,
    hidden: u32,
    block_elems: usize,
    block_bytes: usize,
    type_name: &str,
) -> Result<(), RealForwardError> {
    let (rows, cols, depth, planes) = e.shape;
    if cols != hidden || depth != 0 || planes != 0 {
        return Err(RealForwardError::Unsupported(format!(
            "embedding table {name}: {type_name} shape {:?} does not match [vocab, {hidden}]",
            e.shape
        )));
    }
    if token >= rows {
        return Err(RealForwardError::Unsupported(format!(
            "embedding table {name}: token {token} is outside {rows} rows"
        )));
    }
    let hidden = u64::from(hidden);
    let block_elems = block_elems as u64;
    if hidden == 0 || hidden % block_elems != 0 {
        return Err(RealForwardError::Unsupported(format!(
            "embedding table {name}: {type_name} width {hidden} is not a whole number of {block_elems}-element blocks"
        )));
    }
    let row_bytes = (hidden / block_elems)
        .checked_mul(block_bytes as u64)
        .ok_or_else(|| {
            RealForwardError::Unsupported(format!(
                "embedding table {name}: {type_name} row size overflows"
            ))
        })?;
    let expected = u64::from(rows).checked_mul(row_bytes).ok_or_else(|| {
        RealForwardError::Unsupported(format!(
            "embedding table {name}: {type_name} table size overflows"
        ))
    })?;
    let selected_end = u64::from(token)
        .checked_add(1)
        .and_then(|row| row.checked_mul(row_bytes))
        .ok_or_else(|| {
            RealForwardError::Unsupported(format!(
                "embedding table {name}: {type_name} selected row overflows"
            ))
        })?;
    if e.size_bytes != expected || selected_end > e.size_bytes {
        return Err(RealForwardError::Unsupported(format!(
            "embedding table {name}: {type_name} packed size {} does not contain {rows}x{hidden} bytes ({expected}) or selected row {token}",
            e.size_bytes
        )));
    }
    Ok(())
}

fn validate_q4_k_embedding(
    e: &model_io::ResidentIndexEntry,
    name: &str,
    token: u32,
    hidden: u32,
) -> Result<(), RealForwardError> {
    validate_block_quant_embedding(
        e,
        name,
        token,
        hidden,
        gpu::Q4_K_BLOCK_ELEMS,
        gpu::Q4_K_BLOCK_BYTES,
        "Q4_K",
    )
}

fn validate_iq4_xs_embedding(
    e: &model_io::ResidentIndexEntry,
    name: &str,
    token: u32,
    hidden: u32,
) -> Result<(), RealForwardError> {
    validate_block_quant_embedding(
        e,
        name,
        token,
        hidden,
        gpu::IQ4_XS_BLOCK_ELEMS,
        gpu::IQ4_XS_BLOCK_BYTES,
        "IQ4_XS",
    )
}

/// Dispatches the embedding lookup matching the table's dtype tag: 4 =
/// INT4-affine, 15 = 1-bit affine, plus the GGUF block types a real file puts
/// an embedding table in.
///
/// Shared by both real flows rather than written at each one, because it is a
/// property of the tensor and not of the family: Qwen's Q4_K_M keeps
/// `token_embd.weight` at Q4_K, Gemma's published GGUF is Q8_0 throughout,
/// and Swift Qwen3.8 keeps it at IQ4_XS.
#[allow(clippy::too_many_arguments)]
pub(crate) fn encode_embed_any(
    context: &mut gpu::MetalContext,
    pass: &gpu::PassEncoder,
    weights: &gpu::ResidentGpuWeights,
    index: &ResidentIndex,
    name: &str,
    out: (&gpu::MetalBuffer, u64),
    token: u32,
    hidden: u32,
    expected_rows: usize,
    embed_scale: f32,
) -> Result<(), RealForwardError> {
    if token as usize >= expected_rows {
        return Err(RealForwardError::Unsupported(format!(
            "token id {token} outside embedding table with {expected_rows} rows"
        )));
    }
    let e = entry(index, name)?;
    let shape = e.shape;
    if shape.0 == 0 || shape.1 != hidden || shape.2 != 0 || shape.3 != 0 {
        return Err(RealForwardError::Unsupported(format!(
            "embedding table {name}: expected [rows, {hidden}], got {shape:?}"
        )));
    }
    if token >= shape.0 {
        return Err(RealForwardError::Unsupported(format!(
            "embedding table {name}: token {token} is outside {} rows",
            shape.0
        )));
    }
    let row_block = match e.dtype {
        DTYPE_GGUF_Q8_0 => Some(gpu::Q8_0_BLOCK_ELEMS),
        DTYPE_GGUF_Q4_K => Some(gpu::Q4_K_BLOCK_ELEMS),
        DTYPE_GGUF_Q6_K => Some(gpu::Q6_K_BLOCK_ELEMS),
        DTYPE_GGUF_Q3_K => Some(gpu::Q3_K_BLOCK_ELEMS),
        DTYPE_GGUF_IQ4_XS => Some(gpu::IQ4_XS_BLOCK_ELEMS),
        DTYPE_GGUF_IQ1_M => Some(gpu::IQ1_M_BLOCK_ELEMS),
        _ => None,
    };
    if let Some(block) = row_block {
        if hidden as usize % block != 0 {
            return Err(RealForwardError::Unsupported(format!(
                "embedding table {name}: row width {hidden} is not divisible by its \
                 {block}-element block"
            )));
        }
    }
    let base = index.header.index_size;
    let table = (weights.buffer(), weights.gpu_offset(e.file_offset - base));
    // A GGUF embedding table is one contiguous byte run per row with its
    // scales inline, so it takes a different kernel rather than the same one
    // with the companion offsets zeroed (ROADMAP Phase G Stage 2).
    match e.dtype {
        DTYPE_GGUF_Q8_0 => {
            gpu::encode_embed_lookup_q8_0(context, pass, table, out, token, hidden, embed_scale)
                .map_err(RealForwardError::Gpu)
        }
        DTYPE_GGUF_Q4_K => {
            validate_q4_k_embedding(e, name, token, hidden)?;
            gpu::encode_embed_lookup_q4_k(context, pass, table, out, token, hidden, embed_scale)
                .map_err(RealForwardError::Gpu)
        }
        DTYPE_GGUF_IQ4_XS => {
            validate_iq4_xs_embedding(e, name, token, hidden)?;
            gpu::encode_embed_lookup_iq4_xs(context, pass, table, out, token, hidden, embed_scale)
                .map_err(RealForwardError::Gpu)
        }
        // Same bounds check the Q4_K arm makes, for the same reason: the
        // stride arithmetic differs from every sibling (110-byte blocks),
        // and a hand-edited manifest fails here rather than reading a
        // neighbouring token's row. No real file keeps `token_embd` at Q3_K
        // today; this is the Q6_K embed lookup's story again.
        DTYPE_GGUF_Q3_K => {
            validate_block_quant_embedding(
                e,
                name,
                token,
                hidden,
                gpu::Q3_K_BLOCK_ELEMS,
                gpu::Q3_K_BLOCK_BYTES,
                "Q3_K",
            )?;
            gpu::encode_embed_lookup_q3_k(context, pass, table, out, token, hidden, embed_scale)
                .map_err(RealForwardError::Gpu)
        }
        // ROADMAP Phase S's candidate puts `token_embd` in Q6_K and ties the
        // head to it, which is what made this kernel worth writing.
        DTYPE_GGUF_Q6_K => {
            gpu::encode_embed_lookup_q6_k(context, pass, table, out, token, hidden, embed_scale)
                .map_err(RealForwardError::Gpu)
        }
        DTYPE_GGUF_IQ1_M => {
            gpu::encode_embed_lookup_iq1_m(context, pass, table, out, token, hidden, embed_scale)
                .map_err(RealForwardError::Gpu)
        }
        // The 1-bit table (ROADMAP's 1-bit entry). It exists because the real
        // checkpoint quantizes `embed_tokens` at one bit like everything else,
        // which was read off its safetensors header rather than assumed.
        //
        DTYPE_INT1_AFFINE | DTYPE_INT2_AFFINE => {
            let bits = if e.dtype == DTYPE_INT1_AFFINE { 1 } else { 2 };
            let d = hidden as usize;
            let group_size = affine_group_size(e, name, expected_rows, d, bits)?;
            let scales = (weights.buffer(), weights.gpu_offset(e.scale_offset - base));
            let biases = (weights.buffer(), weights.gpu_offset(e.bias_offset - base));
            let encode = if bits == 1 {
                gpu::encode_embed_lookup_int1
            } else {
                gpu::encode_embed_lookup_int2
            };
            encode(
                context,
                pass,
                table,
                scales,
                biases,
                out,
                token,
                hidden,
                group_size as u32,
                embed_scale,
            )
            .map_err(RealForwardError::Gpu)
        }
        5 => {
            // The INT8-affine table: one byte per element, so the resident
            // byte run IS `rows * hidden` exactly, and the row count falls
            // straight out of the size. First carrier: the dense humanizer
            // Gemma 4 12B, whose embedding is INT8 at group 64 like every
            // other quantized tensor in the checkpoint.
            let d = hidden as usize;
            if d == 0 || e.size_bytes as usize % d != 0 {
                return Err(RealForwardError::Unsupported(format!(
                    "embedding table {name}: {} INT8 bytes is not a whole number of \
                     {d}-element rows",
                    e.size_bytes
                )));
            }
            let rows = e.size_bytes as usize / d;
            let group_size = affine_group_size(e, name, rows, d, 8)?;
            if group_size != 64 {
                return Err(RealForwardError::Unsupported(format!(
                    "embedding table {name}: INT8 group size {group_size} does not match kernel \
                     group size 64"
                )));
            }
            let scales = (weights.buffer(), weights.gpu_offset(e.scale_offset - base));
            let biases = (weights.buffer(), weights.gpu_offset(e.bias_offset - base));
            gpu::encode_embed_lookup_int8(
                context,
                pass,
                table,
                scales,
                biases,
                out,
                token,
                hidden,
                embed_scale,
            )
            .map_err(RealForwardError::Gpu)
        }
        4 => {
            // Resolved inside this arm on purpose: a GGUF entry carries no
            // companions, so its `scale_offset` is 0 and subtracting the
            // index size underflows.
            let scales = (weights.buffer(), weights.gpu_offset(e.scale_offset - base));
            let biases = (weights.buffer(), weights.gpu_offset(e.bias_offset - base));
            let d = hidden as usize;
            if d == 0 || (e.size_bytes as usize * 2) % d != 0 {
                return Err(RealForwardError::Unsupported(format!(
                    "embedding table {name}: {} INT4 bytes is not a whole number of \
                     {d}-element rows",
                    e.size_bytes
                )));
            }
            let rows = e.size_bytes as usize * 2 / d;
            let group_size = affine_group_size(e, name, rows, d, 4)?;
            if group_size != 64 {
                return Err(RealForwardError::Unsupported(format!(
                    "embedding table {name}: INT4 group size {group_size} does not match kernel \
                     group size 64"
                )));
            }
            if token as usize >= rows {
                return Err(RealForwardError::Unsupported(format!(
                    "embedding table {name}: token id {token} outside {rows} rows"
                )));
            }
            gpu::encode_embed_lookup_int4(
                context,
                pass,
                table,
                scales,
                biases,
                out,
                token,
                hidden,
                embed_scale,
            )
            .map_err(RealForwardError::Gpu)
        }
        other => Err(RealForwardError::Unsupported(format!(
            "embedding table {name}: dtype {other} has no dispatched lookup kernel"
        ))),
    }
}

/// Resolves a packed projection by its dtype tag: 4 = INT4-affine,
/// 5 = INT8-affine, 15 = 1-bit affine, 16 = 2-bit affine (the resident
/// writer's tags), and encodes the matching offset-bound GEMV.
#[allow(clippy::too_many_arguments)]
pub(crate) fn encode_gemv_any(
    context: &mut gpu::MetalContext,
    pass: &gpu::PassEncoder,
    weights: &gpu::ResidentGpuWeights,
    index: &ResidentIndex,
    name: &str,
    rows: usize,
    cols: usize,
    x: (&gpu::MetalBuffer, u64),
    y: (&gpu::MetalBuffer, u64),
) -> Result<(), RealForwardError> {
    let e = entry(index, name)?;
    let base = index.header.index_size;
    match e.dtype {
        5 => {
            let group_size = affine_group_size(e, name, rows, cols, 8)?;
            if group_size != 64 {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: INT8 group size {group_size} does not match kernel group size 64"
                )));
            }
            let w = gpu::Int8ResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                scales_offset: weights.gpu_offset(e.scale_offset - base),
                biases_offset: weights.gpu_offset(e.bias_offset - base),
                rows,
                cols,
            };
            gpu::encode_dequant_int8_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        4 => {
            let w = resident_matrix(weights, index, name, rows, cols)?;
            gpu::encode_dequant_int4_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        // 1-BIT AFFINE (ROADMAP's 1-bit entry, step 4). The same three planar
        // regions as the two arms above and NOT a narrower version of them:
        // the companions are FP16 rather than BF16 (same width, so no length
        // check can tell), and the group size is the checkpoint's rather than
        // the siblings' compile-time 64 -- so it is DERIVED from the entry
        // here rather than named, and the derivation doubles as the shape
        // check the other arms spell out.
        //
        // The SYMMETRIC kernel is deliberately not reachable from here. It is
        // a different summation order (`crates/gpu`'s module header), so
        // choosing it per tensor at dispatch time would make the bytes a
        // function of which tensors happened to quantize symmetrically. If it
        // is ever wired, that decision belongs at repack time and needs its
        // own dtype tag.
        DTYPE_INT1_AFFINE => {
            let group_size = affine_group_size(e, name, rows, cols, 1)?;
            let w = gpu::Int1ResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                scales_offset: weights.gpu_offset(e.scale_offset - base),
                biases_offset: weights.gpu_offset(e.bias_offset - base),
                rows,
                cols,
                group_size,
            };
            gpu::encode_dequant_int1_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        // 2-BIT AFFINE (ROADMAP's ternary entry). The 1-bit arm above with one
        // constant moved, and the constant is the ONLY thing that separates
        // them at this level: the three planar regions, the FP16 companions
        // and the derived group size are identical, so the dtype TAG is what
        // says how wide a row is. There is no symmetric fast path to choose
        // between here for the 1-bit arm's reason, restated in
        // `crates/compute`'s `quant_2bit` header.
        DTYPE_INT2_AFFINE => {
            let group_size = affine_group_size(e, name, rows, cols, 2)?;
            let w = gpu::Int2ResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                scales_offset: weights.gpu_offset(e.scale_offset - base),
                biases_offset: weights.gpu_offset(e.bias_offset - base),
                rows,
                cols,
                group_size,
            };
            gpu::encode_dequant_int2_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        // GGUF Q8_0 (ROADMAP Phase G Stage 2). One byte run, no companions:
        // the entry's scale/bias offsets are zero and are not read.
        DTYPE_GGUF_Q8_0 => {
            let expected = gpu::q8_0_row_bytes(cols) * rows;
            if e.size_bytes as usize != expected {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: Q8_0 packed size {} does not match {rows}x{cols} ({expected})",
                    e.size_bytes
                )));
            }
            let w = gpu::Q8_0ResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                rows,
                cols,
            };
            gpu::encode_dequant_q8_0_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        DTYPE_GGUF_Q2_K => {
            let expected = gpu::q2_k_row_bytes(cols) * rows;
            if e.size_bytes as usize != expected {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: Q2_K packed size {} does not match {rows}x{cols} ({expected})",
                    e.size_bytes
                )));
            }
            let w = gpu::Q2KResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                rows,
                cols,
            };
            gpu::encode_dequant_q2_k_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        // The other two GGUF block types a real file uses for a matrix.
        // Same shape as the Q8_0 arm; only the row-bytes function and the
        // kernel differ, and the size check is what catches a tensor whose
        // dtype tag and byte count disagree.
        DTYPE_GGUF_Q4_K => {
            let expected = gpu::q4_k_row_bytes(cols) * rows;
            if e.size_bytes as usize != expected {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: Q4_K packed size {} does not match {rows}x{cols} ({expected})",
                    e.size_bytes
                )));
            }
            let w = gpu::Q4KResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                rows,
                cols,
            };
            gpu::encode_dequant_q4_k_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        DTYPE_GGUF_Q5_K => {
            let expected = gpu::q5_k_row_bytes(cols) * rows;
            if e.size_bytes as usize != expected {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: Q5_K packed size {} does not match {rows}x{cols} ({expected})",
                    e.size_bytes
                )));
            }
            let w = gpu::Q5KResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                rows,
                cols,
            };
            gpu::encode_dequant_q5_k_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        DTYPE_GGUF_Q6_K => {
            let expected = gpu::q6_k_row_bytes(cols) * rows;
            if e.size_bytes as usize != expected {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: Q6_K packed size {} does not match {rows}x{cols} ({expected})",
                    e.size_bytes
                )));
            }
            let w = gpu::Q6KResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                rows,
                cols,
            };
            gpu::encode_dequant_q6_k_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        // The Dense Qwen2 roadmap item's block type: the pinned Qwen2.5
        // Q3_K_M keeps every attention and FFN projection here, so this arm
        // is the one a real Q3_K install runs on every token. Same shape as
        // the Q8_0 arm; only the row-bytes function (110/256, against the
        // 110/144 confusion with Q4_K) and the kernel differ, and the size
        // check is what catches a tensor whose dtype tag and byte count
        // disagree.
        DTYPE_GGUF_Q3_K => {
            let expected = gpu::q3_k_row_bytes(cols) * rows;
            if e.size_bytes as usize != expected {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: Q3_K packed size {} does not match {rows}x{cols} ({expected})",
                    e.size_bytes
                )));
            }
            let w = gpu::Q3KResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                rows,
                cols,
            };
            gpu::encode_dequant_q3_k_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        dtype @ (DTYPE_GGUF_IQ3_XXS | DTYPE_GGUF_IQ4_NL | DTYPE_GGUF_IQ4_XS
        | DTYPE_GGUF_IQ2_XXS | DTYPE_GGUF_IQ2_XS | DTYPE_GGUF_IQ1_S | DTYPE_GGUF_IQ3_S
        | DTYPE_GGUF_IQ2_S | DTYPE_GGUF_IQ1_M) => {
            let kind = match dtype {
                DTYPE_GGUF_IQ3_XXS => gpu::IqBlockType::Iq3Xxs,
                DTYPE_GGUF_IQ4_NL => gpu::IqBlockType::Iq4Nl,
                DTYPE_GGUF_IQ4_XS => gpu::IqBlockType::Iq4Xs,
                DTYPE_GGUF_IQ2_XXS => gpu::IqBlockType::Iq2Xxs,
                DTYPE_GGUF_IQ2_XS => gpu::IqBlockType::Iq2Xs,
                DTYPE_GGUF_IQ1_S => gpu::IqBlockType::Iq1S,
                DTYPE_GGUF_IQ3_S => gpu::IqBlockType::Iq3S,
                DTYPE_GGUF_IQ2_S => gpu::IqBlockType::Iq2S,
                DTYPE_GGUF_IQ1_M => gpu::IqBlockType::Iq1M,
                _ => unreachable!(),
            };
            let expected = kind.row_bytes(cols) * rows;
            if e.size_bytes as usize != expected {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: {kind:?} packed size {} does not match {rows}x{cols} ({expected})",
                    e.size_bytes
                )));
            }
            let w = gpu::IqResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                rows,
                cols,
                kind,
            };
            gpu::encode_dequant_iq_gemv_resident(context, pass, &w, x, y)
                .map_err(RealForwardError::Gpu)
        }
        // UNQUANTIZED BF16 matrix (tag 1 narrowed at repack, AGENTS.md
        // Gotcha 45). The reader the Bonsai-2 line needed for its F32-shipped
        // `linear_attn.in_proj_a`/`in_proj_b`: every earlier install
        // quantized them, so this arm never had a live caller until now. No
        // companion planes; the size check is the whole shape assertion.
        DTYPE_RAW_BF16 => {
            let expected = rows * cols * 2;
            if e.size_bytes as usize != expected {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: BF16 size {} does not match {rows}x{cols} ({expected})",
                    e.size_bytes
                )));
            }
            let w = gpu::Bf16ResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                rows,
                cols,
            };
            gpu::encode_bf16_gemv_resident(context, pass, &w, x, y).map_err(RealForwardError::Gpu)
        }
        // Named rather than defaulted. This arm used to be `_ => int4`,
        // which meant any future dtype tag was read as INT4-affine: no
        // error, just wrong numbers, since the three planar regions an
        // INT4 tensor expects do not exist in a block-quantized one. The
        // GGUF tags (ROADMAP Phase G) are the first tags able to reach it.
        other => Err(RealForwardError::Unsupported(format!(
            "tensor {name}: dtype {other} has no dispatched GEMV kernel"
        ))),
    }
}

/// [`encode_gemv_any`] at `batch` rows: `y[b, m] = sum_n W[m, n] * x[b, n]`.
///
/// `x` holds `batch * cols` halfs and `y` `batch * rows`, both TOKEN-MAJOR,
/// so one token's slice of either stays contiguous and can be handed to a
/// per-token kernel unchanged. That is what lets the batched verify pass
/// batch its GEMVs while leaving norms, RoPE, attention and the recurrent
/// step looping per token, which is exactly the split
/// `docs/MTP_SPECULATIVE.md`'s composite assumes.
///
/// **EVERY DTYPE WITHOUT A BATCHED KERNEL IS REFUSED BY NAME, NEVER
/// LOOPED.** A fallback of `batch` sequential GEMVs is numerically
/// identical, so it would pass every parity and losslessness test there is
/// -- while making a "batched" verify measure the SEQUENTIAL engine and
/// report its cost as the batched one. That is AGENTS.md Gotcha 35's
/// failure (a measurement tool must not inherit a silent default) one
/// layer down, and it would corrupt the only number step 4 exists to
/// produce. The affine sub-byte pair joined INT4 (ROADMAP P3.3): both
/// kernels are bit-exact against their GEMVs at every batch width, which is
/// the gate that admits them. Every GGUF block type still has none.
///
/// The batch bound is an `Err` here and an `assert!` inside
/// `encode_dequant_int4_gemm_resident`. Exceeding `MAX_BATCH_ROWS` is a
/// call-site bug and the kernel is right to abort on it, but a runtime path
/// that can be reached with a caller-chosen block size should say so
/// without killing the process.
#[allow(clippy::too_many_arguments)]
pub(crate) fn encode_gemm_any(
    context: &mut gpu::MetalContext,
    pass: &gpu::PassEncoder,
    weights: &gpu::ResidentGpuWeights,
    index: &ResidentIndex,
    name: &str,
    rows: usize,
    cols: usize,
    x: (&gpu::MetalBuffer, u64),
    y: (&gpu::MetalBuffer, u64),
    batch: usize,
) -> Result<(), RealForwardError> {
    let base = index.header.index_size;
    if !(1..=gpu::MAX_BATCH_ROWS).contains(&batch) {
        return Err(RealForwardError::Unsupported(format!(
            "tensor {name}: batch {batch} outside 1..={} (the batched INT4 kernel's \
             accumulators are a per-thread register array, so the cap is the register \
             file rather than a tuning choice)",
            gpu::MAX_BATCH_ROWS
        )));
    }
    let e = entry(index, name)?;
    match e.dtype {
        // A LITERAL, matching `encode_gemv_any`'s arm above, because INT4
        // and INT8 have no named constants the way the GGUF and sub-4-bit
        // tags do. Spelling it `DTYPE_INT4_AFFINE` here does not fail to
        // compile -- it becomes a catch-all BINDING that matches every
        // dtype and routes a Q4_K tensor into the INT4 kernel. The compiler
        // warns; nothing else would.
        4 => {
            let w = resident_matrix(weights, index, name, rows, cols)?;
            gpu::encode_dequant_int4_gemm_resident(context, pass, &w, x, y, batch)
                .map_err(RealForwardError::Gpu)
        }
        // The INT8-affine batched kernel, the dense humanizer's width. The
        // same refusal logic `encode_gemv_any`'s 5-arm carries, applied to
        // the batched pair: group 64 only, because that is what the kernel
        // is compiled against.
        5 => {
            let group_size = affine_group_size(e, name, rows, cols, 8)?;
            if group_size != 64 {
                return Err(RealForwardError::Unsupported(format!(
                    "tensor {name}: INT8 group size {group_size} does not match kernel \
                     group size 64"
                )));
            }
            let w = gpu::Int8ResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                scales_offset: weights.gpu_offset(e.scale_offset - base),
                biases_offset: weights.gpu_offset(e.bias_offset - base),
                rows,
                cols,
            };
            gpu::encode_dequant_int8_gemm_resident(context, pass, &w, x, y, batch)
                .map_err(RealForwardError::Gpu)
        }
        // The sub-byte affine pair (ROADMAP P3.3), mirroring
        // `encode_gemv_any`'s arms beside them: the companions are FP16 and
        // the group size is the checkpoint's, so it is DERIVED from the
        // entry rather than named, and both batched kernels are held
        // bit-exact against their GEMVs by the parity tests rather than
        // asserted here.
        DTYPE_INT1_AFFINE => {
            let group_size = affine_group_size(e, name, rows, cols, 1)?;
            let w = gpu::Int1ResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                scales_offset: weights.gpu_offset(e.scale_offset - base),
                biases_offset: weights.gpu_offset(e.bias_offset - base),
                rows,
                cols,
                group_size,
            };
            gpu::encode_dequant_int1_gemm_resident(context, pass, &w, x, y, batch)
                .map_err(RealForwardError::Gpu)
        }
        DTYPE_INT2_AFFINE => {
            let group_size = affine_group_size(e, name, rows, cols, 2)?;
            let w = gpu::Int2ResidentMatrix {
                buffer: weights.buffer(),
                weights_offset: weights.gpu_offset(e.file_offset - base),
                scales_offset: weights.gpu_offset(e.scale_offset - base),
                biases_offset: weights.gpu_offset(e.bias_offset - base),
                rows,
                cols,
                group_size,
            };
            gpu::encode_dequant_int2_gemm_resident(context, pass, &w, x, y, batch)
                .map_err(RealForwardError::Gpu)
        }
        other => Err(RealForwardError::Unsupported(format!(
            "tensor {name}: dtype {other} has no BATCHED kernel; INT4-affine (4), \
             INT8-affine (5), 1-bit affine (15) and 2-bit affine (16) do. Refused \
             rather than looped: a sequential fallback here is numerically \
             identical and would silently measure the unbatched engine"
        ))),
    }
}

/// The fewest rows the Steel INT4 GEMM is used for. Its 32-row tile wastes
/// half its work at 16 rows, where it measured only 1.2-1.4x the scalar
/// kernel on Qwen3.8's large projections and 0.61x on the 1024-row K/V ones;
/// from 32 rows it wins on every projection
/// (`crates/gpu/tests/qwen38_int4_prefill_gemm_probe.rs`).
const STEEL_MIN_ROWS: usize = 32;

/// [`encode_gemm_any`] for any positive `batch`, row-major `x` (`cols` halfs
/// per row) and `y` (`rows` halfs per row). With `steel` set, an INT4 tensor
/// the vendored kernel can serve runs as ONE Steel dispatch from
/// [`STEEL_MIN_ROWS`] rows up; everything else runs the scalar kernel in
/// slices of `gpu::MAX_BATCH_ROWS` rows. Only a caller that has accepted
/// Steel's rounding passes `steel` (the chunked-prefill scratch,
/// `BatchedScratch::steel_gemm`); without it the result is the scalar
/// kernel's, bit for bit, whatever `batch` is.
#[allow(clippy::too_many_arguments)]
pub(crate) fn encode_gemm_rows(
    context: &mut gpu::MetalContext,
    pass: &gpu::PassEncoder,
    weights: &gpu::ResidentGpuWeights,
    index: &ResidentIndex,
    name: &str,
    rows: usize,
    cols: usize,
    x: (&gpu::MetalBuffer, u64),
    y: (&gpu::MetalBuffer, u64),
    batch: usize,
    steel: bool,
) -> Result<(), RealForwardError> {
    if steel && batch >= STEEL_MIN_ROWS && entry(index, name)?.dtype == 4 {
        let w = resident_matrix(weights, index, name, rows, cols)?;
        let tile = gpu::SteelTile::M32K32N32;
        if gpu::steel_supports(&w, tile) {
            return gpu::encode_dequant_int4_gemm_steel(context, pass, &w, x, y, batch, tile)
                .map_err(RealForwardError::Gpu);
        }
    }
    let mut done = 0usize;
    while done < batch {
        let take = (batch - done).min(gpu::MAX_BATCH_ROWS);
        encode_gemm_any(
            context,
            pass,
            weights,
            index,
            name,
            rows,
            cols,
            (x.0, x.1 + (done * cols * 2) as u64),
            (y.0, y.1 + (done * rows * 2) as u64),
            take,
        )?;
        done += take;
    }
    Ok(())
}

/// The `router_topk_select_k8` kernel's semantics on the host: top-`k` by
/// score with ties preferring the lower expert index, softmax over the
/// selected scores only, each weight multiplied by that expert's
/// `per_expert_scale`. (Distinct from the synthetic path's
/// softmax-over-all-then-renormalize `topk_softmax`.)
pub(crate) fn router_topk_gemma4(
    logits: &[f32],
    k: usize,
    per_expert_scale: &[f32],
) -> (Vec<usize>, Vec<f32>) {
    if logits.is_empty() || k == 0 {
        return (Vec::new(), Vec::new());
    }
    let mut order: Vec<usize> = (0..logits.len()).collect();
    order.sort_by(|&a, &b| logits[b].total_cmp(&logits[a]).then(a.cmp(&b)));
    let selected: Vec<usize> = order.into_iter().take(k).collect();
    let max = logits[selected[0]];
    let exps: Vec<f32> = selected.iter().map(|&i| (logits[i] - max).exp()).collect();
    let sum: f32 = exps.iter().sum();
    let weights = selected
        .iter()
        .zip(exps.iter())
        .map(|(&i, e)| {
            let scale = per_expert_scale.get(i).copied().unwrap_or(1.0);
            e / sum * scale
        })
        .collect();
    (selected, weights)
}

#[cfg(test)]
mod tests {
    use super::*;

    fn q4_k_embedding(rows: u32, cols: u32) -> model_io::ResidentIndexEntry {
        model_io::ResidentIndexEntry {
            name: "token_embd.weight".to_string(),
            dtype: DTYPE_GGUF_Q4_K,
            file_offset: 4096,
            size_bytes: u64::from(rows)
                * (u64::from(cols) / gpu::Q4_K_BLOCK_ELEMS as u64)
                * gpu::Q4_K_BLOCK_BYTES as u64,
            shape: (rows, cols, 0, 0),
            scale_offset: 0,
            scale_size: 0,
            bias_offset: 0,
            bias_size: 0,
        }
    }

    #[test]
    fn q4_k_embedding_validation_bounds_shape_size_and_selected_row() {
        let valid = q4_k_embedding(256, 256);
        validate_q4_k_embedding(&valid, &valid.name, 255, 256).unwrap();

        let mut wrong_shape = valid.clone();
        wrong_shape.shape.1 = 512;
        assert!(validate_q4_k_embedding(&wrong_shape, &wrong_shape.name, 0, 256).is_err());

        let mut short = valid.clone();
        short.size_bytes -= gpu::Q4_K_BLOCK_BYTES as u64;
        assert!(validate_q4_k_embedding(&short, &short.name, 255, 256).is_err());

        assert!(validate_q4_k_embedding(&valid, &valid.name, 256, 256).is_err());
    }

    fn iq4_xs_embedding(rows: u32, cols: u32) -> model_io::ResidentIndexEntry {
        model_io::ResidentIndexEntry {
            name: "token_embd.weight".to_string(),
            dtype: DTYPE_GGUF_IQ4_XS,
            file_offset: 4096,
            size_bytes: u64::from(rows)
                * (u64::from(cols) / gpu::IQ4_XS_BLOCK_ELEMS as u64)
                * gpu::IQ4_XS_BLOCK_BYTES as u64,
            shape: (rows, cols, 0, 0),
            scale_offset: 0,
            scale_size: 0,
            bias_offset: 0,
            bias_size: 0,
        }
    }

    #[test]
    fn iq4_xs_embedding_validation_bounds_shape_size_and_selected_row() {
        let valid = iq4_xs_embedding(7, 512);
        validate_iq4_xs_embedding(&valid, &valid.name, 6, 512).unwrap();

        let mut wrong_shape = valid.clone();
        wrong_shape.shape.1 = 256;
        assert!(validate_iq4_xs_embedding(&wrong_shape, &wrong_shape.name, 0, 512).is_err());

        let mut short = valid.clone();
        short.size_bytes -= gpu::IQ4_XS_BLOCK_BYTES as u64;
        assert!(validate_iq4_xs_embedding(&short, &short.name, 6, 512).is_err());

        assert!(validate_iq4_xs_embedding(&valid, &valid.name, 7, 512).is_err());
    }

    #[test]
    fn router_topk_gemma4_handles_empty_or_zero_k() {
        let (sel, w) = router_topk_gemma4(&[], 4, &[]);
        assert!(sel.is_empty() && w.is_empty());

        let (sel, w) = router_topk_gemma4(&[1.0, 2.0, 3.0], 0, &[1.0, 1.0, 1.0]);
        assert!(sel.is_empty() && w.is_empty());
    }
}