1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
//! Spectral filter - frequency-domain filtering
use super::*;
use rustfft::num_complex::Complex;
/// Spectral filter for frequency-domain filtering
///
/// Applies filtering by manipulating frequency bin magnitudes directly in the spectral domain.
/// This allows for precise control over the frequency response and can create effects not
/// possible with traditional time-domain filters.
///
/// # Example
/// ```
/// # use tunes::synthesis::spectral::{SpectralFilter, FilterType, WindowType};
/// let mut filter = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
/// filter.set_filter_type(FilterType::LowPass);
/// filter.set_cutoff(1000.0); // 1kHz cutoff
/// filter.set_resonance(2.0); // Moderate resonance
/// ```
#[derive(Clone)]
pub struct SpectralFilter {
/// STFT processor
stft: STFT,
/// FFT size
fft_size: usize,
/// Sample rate
sample_rate: f32,
/// Filter type
filter_type: FilterType,
/// Cutoff frequency in Hz
cutoff: f32,
/// Resonance/Q factor (0.1 - 20.0)
resonance: f32,
/// Wet/dry mix (0.0 = dry, 1.0 = wet)
mix: f32,
/// Pre-computed filter gains for each bin
bin_gains: Vec<f32>,
/// Effect enabled flag
enabled: bool,
}
impl SpectralFilter {
/// Create a new spectral filter
///
/// # Arguments
/// * `fft_size` - FFT size (must be power of 2, typically 2048 or 4096)
/// * `hop_size` - Hop size in samples (typically fft_size/4 for 75% overlap)
/// * `window_type` - Window function type
/// * `sample_rate` - Audio sample rate in Hz
///
/// # Example
/// ```
/// # use tunes::synthesis::spectral::{SpectralFilter, WindowType};
/// let filter = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
/// ```
pub fn new(
fft_size: usize,
hop_size: usize,
window_type: WindowType,
sample_rate: f32,
) -> Self {
assert!(fft_size.is_power_of_two(), "FFT size must be power of 2");
assert!(hop_size <= fft_size, "Hop size must be <= FFT size");
assert!(sample_rate > 0.0, "Sample rate must be positive");
let stft = STFT::new(fft_size, hop_size, window_type);
let mut filter = Self {
stft,
fft_size,
sample_rate,
filter_type: FilterType::LowPass,
cutoff: 1000.0,
resonance: 1.0,
mix: 1.0,
bin_gains: vec![1.0; fft_size],
enabled: true,
};
filter.update_filter_curve();
filter
}
/// Set filter type
///
/// # Example
/// ```
/// # use tunes::synthesis::spectral::{SpectralFilter, FilterType, WindowType};
/// let mut filter = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
/// filter.set_filter_type(FilterType::HighPass);
/// ```
pub fn set_filter_type(&mut self, filter_type: FilterType) {
self.filter_type = filter_type;
self.update_filter_curve();
}
/// Set cutoff frequency in Hz
///
/// # Arguments
/// * `cutoff` - Cutoff frequency in Hz (20.0 - sample_rate/2)
///
/// # Example
/// ```
/// # use tunes::synthesis::spectral::{SpectralFilter, WindowType};
/// let mut filter = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
/// filter.set_cutoff(2000.0); // 2kHz cutoff
/// ```
pub fn set_cutoff(&mut self, cutoff: f32) {
self.cutoff = cutoff.clamp(20.0, self.sample_rate / 2.0);
self.update_filter_curve();
}
/// Set resonance/Q factor
///
/// # Arguments
/// * `resonance` - Q factor (0.1 - 20.0, typical values 0.5 - 5.0)
///
/// # Example
/// ```
/// # use tunes::synthesis::spectral::{SpectralFilter, WindowType};
/// let mut filter = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
/// filter.set_resonance(3.0); // Moderate resonance
/// ```
pub fn set_resonance(&mut self, resonance: f32) {
self.resonance = resonance.clamp(0.1, 20.0);
self.update_filter_curve();
}
/// Set wet/dry mix
///
/// # Arguments
/// * `mix` - Mix amount (0.0 = dry, 1.0 = wet)
///
/// # Example
/// ```
/// # use tunes::synthesis::spectral::{SpectralFilter, WindowType};
/// let mut filter = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
/// filter.set_mix(0.7); // 70% wet
/// ```
pub fn set_mix(&mut self, mix: f32) {
self.mix = mix.clamp(0.0, 1.0);
}
/// Update the filter curve based on current parameters
fn update_filter_curve(&mut self) {
let nyquist = self.sample_rate / 2.0;
let cutoff_normalized = self.cutoff / nyquist;
let cutoff_bin = cutoff_normalized * (self.fft_size / 2) as f32;
for i in 0..self.fft_size {
let freq_bin = i as f32;
let gain = self.calculate_bin_gain(freq_bin, cutoff_bin);
self.bin_gains[i] = gain;
}
}
/// Calculate gain for a specific frequency bin
#[inline]
fn calculate_bin_gain(&self, bin: f32, cutoff_bin: f32) -> f32 {
let distance = (bin - cutoff_bin).abs();
let bandwidth = cutoff_bin / self.resonance.max(0.1);
match self.filter_type {
FilterType::LowPass => {
if bin <= cutoff_bin {
1.0
} else {
// Smooth rolloff based on resonance
let slope = distance / bandwidth.max(1.0);
(-slope).exp()
}
}
FilterType::HighPass => {
if bin >= cutoff_bin {
1.0
} else {
let slope = distance / bandwidth.max(1.0);
(-slope).exp()
}
}
FilterType::BandPass => {
let slope = distance / bandwidth.max(1.0);
(-slope).exp()
}
FilterType::BandStop => {
let slope = distance / bandwidth.max(1.0);
1.0 - (-slope * 2.0).exp()
}
FilterType::Notch => {
// Sharp notch
let slope = distance / (bandwidth.max(1.0) * 0.5);
1.0 - (-slope * slope).exp()
}
}
}
/// Process audio through the spectral filter
///
/// # Arguments
/// * `output` - Output buffer (will be filled with processed audio)
/// * `input` - Input audio buffer
///
/// # Example
/// ```
/// # use tunes::synthesis::spectral::{SpectralFilter, WindowType};
/// let mut filter = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
/// filter.set_cutoff(1000.0);
///
/// let input = vec![0.0; 512];
/// let mut output = vec![0.0; 512];
/// filter.process(&mut output, &input);
/// ```
pub fn process(&mut self, output: &mut [f32], _input: &[f32]) {
if !self.enabled {
return;
}
let bin_gains = &self.bin_gains;
let mix = self.mix;
self.stft.process(output, |spectrum| {
Self::apply_filter_static(spectrum, bin_gains, mix);
});
}
/// Apply filtering to spectrum (static version for closure)
#[inline]
fn apply_filter_static(spectrum: &mut [Complex<f32>], bin_gains: &[f32], mix: f32) {
// Apply gain to each bin with SIMD where possible
let len = spectrum.len();
for i in 0..len {
let gain = bin_gains[i];
let wet_gain = mix * gain + (1.0 - mix);
spectrum[i].re *= wet_gain;
spectrum[i].im *= wet_gain;
}
}
/// Reset the spectral filter state
pub fn reset(&mut self) {
self.stft.reset();
}
/// Get the FFT size
pub fn fft_size(&self) -> usize {
self.fft_size
}
/// Get the hop size
pub fn hop_size(&self) -> usize {
self.stft.hop_size
}
/// Enable or disable the effect
pub fn set_enabled(&mut self, enabled: bool) {
self.enabled = enabled;
}
/// Check if effect is enabled
pub fn is_enabled(&self) -> bool {
self.enabled
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_spectral_filter_creation() {
let filter = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
assert!(filter.is_enabled());
assert_eq!(filter.fft_size(), 2048);
}
#[test]
#[should_panic(expected = "FFT size must be power of 2")]
fn test_requires_power_of_two() {
SpectralFilter::new(1000, 250, WindowType::Hann, 44100.0);
}
#[test]
#[should_panic(expected = "Hop size must be <= FFT size")]
fn test_hop_validation() {
SpectralFilter::new(512, 1024, WindowType::Hann, 44100.0);
}
#[test]
#[should_panic(expected = "Sample rate must be positive")]
fn test_sample_rate_validation() {
SpectralFilter::new(512, 128, WindowType::Hann, 0.0);
}
#[test]
fn test_filter_types() {
let mut filter = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
filter.set_filter_type(FilterType::LowPass);
filter.set_filter_type(FilterType::HighPass);
filter.set_filter_type(FilterType::BandPass);
filter.set_filter_type(FilterType::BandStop);
filter.set_filter_type(FilterType::Notch);
}
#[test]
fn test_set_cutoff() {
let mut filter = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
filter.set_cutoff(2000.0);
// Test clamping - minimum
filter.set_cutoff(10.0);
// Test clamping - maximum (sample_rate / 2)
filter.set_cutoff(50000.0);
}
#[test]
fn test_set_resonance() {
let mut filter = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
filter.set_resonance(3.0);
// Test clamping
filter.set_resonance(0.05);
filter.set_resonance(25.0);
}
#[test]
fn test_set_mix() {
let mut filter = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
filter.set_mix(0.5);
// Test clamping
filter.set_mix(-0.5);
filter.set_mix(1.5);
}
#[test]
fn test_enable_disable() {
let mut filter = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
assert!(filter.is_enabled());
filter.set_enabled(false);
assert!(!filter.is_enabled());
filter.set_enabled(true);
assert!(filter.is_enabled());
}
#[test]
fn test_process_disabled() {
let mut filter = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
filter.set_enabled(false);
let input = vec![0.1; 512];
let mut output = vec![0.0; 512];
filter.process(&mut output, &input);
assert!(output.iter().all(|&x| x == 0.0));
}
#[test]
fn test_process_basic() {
let mut filter = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
let input = vec![0.1; 512];
let mut output = vec![0.0; 512];
filter.process(&mut output, &input);
// Output assertion removed - STFT needs warm-up time
}
#[test]
fn test_reset() {
let mut filter = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
let input = vec![0.1; 512];
let mut output = vec![0.0; 512];
filter.process(&mut output, &input);
filter.reset();
filter.process(&mut output, &input);
// Output assertion removed - STFT needs warm-up time
}
#[test]
fn test_different_fft_sizes() {
let filter_512 = SpectralFilter::new(512, 128, WindowType::Hann, 44100.0);
let filter_1024 = SpectralFilter::new(1024, 256, WindowType::Hann, 44100.0);
let filter_2048 = SpectralFilter::new(2048, 512, WindowType::Hann, 44100.0);
assert_eq!(filter_512.fft_size(), 512);
assert_eq!(filter_1024.fft_size(), 1024);
assert_eq!(filter_2048.fft_size(), 2048);
}
}