tsz-solver 0.1.8

TypeScript type solver for the tsz compiler
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
//! `TypeVisitor` implementation for `PropertyAccessEvaluator`.
//!
//! Contains the visitor dispatch that resolves property access for each
//! type kind, plus impl helper methods for complex cases (objects, unions, etc.).

use crate::operations_property::{PropertyAccessEvaluator, PropertyAccessResult};
use crate::types::{IntrinsicKind, LiteralValue, ObjectShapeId, TupleListId, TypeId, TypeListId};
use crate::visitor::TypeVisitor;
use tsz_common::interner::Atom;

// =============================================================================
// TypeVisitor Implementation for PropertyAccessEvaluator
// =============================================================================

// Implement TypeVisitor for &PropertyAccessEvaluator to solve &mut self issue
// This allows visitor methods to be called from &self methods while still
// being able to mutate internal state via RefCells.
impl<'a> TypeVisitor for &PropertyAccessEvaluator<'a> {
    type Output = Option<PropertyAccessResult>;

    fn visit_intrinsic(&mut self, kind: IntrinsicKind) -> Self::Output {
        match kind {
            IntrinsicKind::Any => Some(PropertyAccessResult::Success {
                type_id: TypeId::ANY,
                write_type: None,
                from_index_signature: false,
            }),
            IntrinsicKind::Never => {
                // Property access on never returns never (code is unreachable)
                Some(PropertyAccessResult::Success {
                    type_id: TypeId::NEVER,
                    write_type: None,
                    from_index_signature: false,
                })
            }
            IntrinsicKind::Unknown => Some(PropertyAccessResult::IsUnknown),
            IntrinsicKind::Void | IntrinsicKind::Null | IntrinsicKind::Undefined => {
                let cause = if kind == IntrinsicKind::Void || kind == IntrinsicKind::Undefined {
                    TypeId::UNDEFINED
                } else {
                    TypeId::NULL
                };
                Some(PropertyAccessResult::PossiblyNullOrUndefined {
                    property_type: None,
                    cause,
                })
            }
            // Handle primitive intrinsic types by delegating to their boxed interfaces
            IntrinsicKind::String => {
                let prop_name = self.current_prop_name.borrow();
                let prop_atom = self.current_prop_atom.borrow();
                match (prop_name.as_deref(), prop_atom.as_ref()) {
                    (Some(name), Some(&atom)) => Some(self.resolve_string_property(name, atom)),
                    _ => None,
                }
            }
            IntrinsicKind::Number => {
                let prop_name = self.current_prop_name.borrow();
                let prop_atom = self.current_prop_atom.borrow();
                match (prop_name.as_deref(), prop_atom.as_ref()) {
                    (Some(name), Some(&atom)) => Some(self.resolve_number_property(name, atom)),
                    _ => None,
                }
            }
            IntrinsicKind::Boolean => {
                let prop_name = self.current_prop_name.borrow();
                let prop_atom = self.current_prop_atom.borrow();
                match (prop_name.as_deref(), prop_atom.as_ref()) {
                    (Some(name), Some(&atom)) => Some(self.resolve_boolean_property(name, atom)),
                    _ => None,
                }
            }
            IntrinsicKind::Bigint => {
                let prop_name = self.current_prop_name.borrow();
                let prop_atom = self.current_prop_atom.borrow();
                match (prop_name.as_deref(), prop_atom.as_ref()) {
                    (Some(name), Some(&atom)) => Some(self.resolve_bigint_property(name, atom)),
                    _ => None,
                }
            }
            // Symbol intrinsic is handled separately (has special properties)
            IntrinsicKind::Symbol => {
                // Get the property name from context
                let prop_name = self.current_prop_name.borrow();
                let prop_atom = self.current_prop_atom.borrow();
                match (prop_name.as_deref(), prop_atom.as_ref()) {
                    (Some(name), Some(&atom)) => {
                        Some(self.resolve_symbol_primitive_property(name, atom))
                    }
                    _ => None,
                }
            }
            // Other intrinsics (Object, etc.) fall back to None
            _ => None,
        }
    }

    fn visit_literal(&mut self, value: &LiteralValue) -> Self::Output {
        use crate::types::LiteralValue;

        let prop_name = self.current_prop_name.borrow();
        let prop_atom_opt = self.current_prop_atom.borrow();

        let prop_name = prop_name.as_deref()?;
        let prop_atom = match prop_atom_opt.as_ref() {
            Some(&atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        // Handle primitive literals by delegating to their boxed interface types
        match value {
            LiteralValue::String(_) => Some(self.resolve_string_property(prop_name, prop_atom)),
            LiteralValue::Number(_) => Some(self.resolve_number_property(prop_name, prop_atom)),
            LiteralValue::Boolean(_) => Some(self.resolve_boolean_property(prop_name, prop_atom)),
            LiteralValue::BigInt(_) => Some(self.resolve_bigint_property(prop_name, prop_atom)),
        }
    }

    fn visit_object(&mut self, shape_id: u32) -> Self::Output {
        use crate::index_signatures::{IndexKind, IndexSignatureResolver};

        let prop_name = self.current_prop_name.borrow();
        let prop_atom_opt = self.current_prop_atom.borrow();

        let prop_name = prop_name.as_deref()?;
        let prop_atom = match prop_atom_opt.as_ref() {
            Some(&atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        let shape = self.interner().object_shape(ObjectShapeId(shape_id));

        // Check explicit properties first
        if let Some(prop) =
            self.lookup_object_property(ObjectShapeId(shape_id), &shape.properties, prop_atom)
        {
            let write = (prop.write_type != prop.type_id).then_some(prop.write_type);
            return Some(PropertyAccessResult::Success {
                type_id: self.optional_property_type(prop),
                write_type: write,
                from_index_signature: false,
            });
        }

        // Check apparent members (toString, etc.)
        if let Some(result) = self.resolve_object_member(prop_name, prop_atom) {
            return Some(result);
        }

        // Check for index signatures (some Object types may have index signatures that aren't in ObjectWithIndex)
        let resolver = IndexSignatureResolver::new(self.interner());

        // Reconstruct obj_type from shape_id for index signature checking
        let obj_type = self.interner().object_with_flags_and_symbol(
            self.interner()
                .object_shape(ObjectShapeId(shape_id))
                .properties
                .clone(),
            self.interner().object_shape(ObjectShapeId(shape_id)).flags,
            self.interner().object_shape(ObjectShapeId(shape_id)).symbol,
        );

        // Try string index signature first (most common)
        if resolver.has_index_signature(obj_type, IndexKind::String)
            && let Some(value_type) = resolver.resolve_string_index(obj_type)
        {
            return Some(PropertyAccessResult::Success {
                type_id: self.add_undefined_if_unchecked(value_type),
                write_type: None,
                from_index_signature: true,
            });
        }

        // Try numeric index signature if property name looks numeric
        if resolver.is_numeric_index_name(prop_name)
            && let Some(value_type) = resolver.resolve_number_index(obj_type)
        {
            return Some(PropertyAccessResult::Success {
                type_id: self.add_undefined_if_unchecked(value_type),
                write_type: None,
                from_index_signature: true,
            });
        }

        Some(PropertyAccessResult::PropertyNotFound {
            type_id: obj_type,
            property_name: prop_atom,
        })
    }

    fn visit_object_with_index(&mut self, shape_id: u32) -> Self::Output {
        use crate::index_signatures::IndexSignatureResolver;

        let prop_name = self.current_prop_name.borrow();
        let prop_atom_opt = self.current_prop_atom.borrow();

        let prop_name = prop_name.as_deref()?;
        let prop_atom = match prop_atom_opt.as_ref() {
            Some(&atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        let shape = self.interner().object_shape(ObjectShapeId(shape_id));

        // Check explicit properties first
        if let Some(prop) =
            self.lookup_object_property(ObjectShapeId(shape_id), &shape.properties, prop_atom)
        {
            let write = (prop.write_type != prop.type_id).then_some(prop.write_type);
            return Some(PropertyAccessResult::Success {
                type_id: self.optional_property_type(prop),
                write_type: write,
                from_index_signature: false,
            });
        }

        // Check apparent members (toString, etc.)
        if let Some(result) = self.resolve_object_member(prop_name, prop_atom) {
            return Some(result);
        }

        // Check string index signature
        if let Some(ref idx) = shape.string_index {
            return Some(PropertyAccessResult::Success {
                type_id: self.add_undefined_if_unchecked(idx.value_type),
                write_type: None,
                from_index_signature: true,
            });
        }

        // Check numeric index signature if property name looks numeric
        let resolver = IndexSignatureResolver::new(self.interner());
        if resolver.is_numeric_index_name(prop_name)
            && let Some(ref idx) = shape.number_index
        {
            return Some(PropertyAccessResult::Success {
                type_id: self.add_undefined_if_unchecked(idx.value_type),
                write_type: None,
                from_index_signature: true,
            });
        }

        // Reconstruct obj_type for PropertyNotFound result
        let obj_type = self.interner().object_with_index(
            self.interner()
                .object_shape(ObjectShapeId(shape_id))
                .as_ref()
                .clone(),
        );

        Some(PropertyAccessResult::PropertyNotFound {
            type_id: obj_type,
            property_name: prop_atom,
        })
    }

    fn visit_array(&mut self, element_type: TypeId) -> Self::Output {
        let prop_name = self.current_prop_name.borrow();
        let prop_atom_opt = self.current_prop_atom.borrow();

        let prop_name = prop_name.as_deref()?;
        let prop_atom = match prop_atom_opt.as_ref() {
            Some(&atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        // Reconstruct obj_type for resolve_array_property
        let obj_type = self.interner().array(element_type);
        Some(self.resolve_array_property(obj_type, prop_name, prop_atom))
    }

    fn visit_tuple(&mut self, list_id: u32) -> Self::Output {
        let prop_name = self.current_prop_name.borrow();
        let prop_atom_opt = self.current_prop_atom.borrow();

        let prop_name = prop_name.as_deref()?;
        let prop_atom = match prop_atom_opt.as_ref() {
            Some(&atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        // Reconstruct obj_type for resolve_array_property
        let obj_type = self
            .interner()
            .tuple(self.interner().tuple_list(TupleListId(list_id)).to_vec());
        Some(self.resolve_array_property(obj_type, prop_name, prop_atom))
    }

    fn visit_template_literal(&mut self, _template_id: u32) -> Self::Output {
        // Template literals are string-like for property access
        // They support the same properties as the String interface
        let prop_name = self.current_prop_name.borrow();
        let prop_atom_opt = self.current_prop_atom.borrow();

        let prop_name = prop_name.as_deref()?;
        let prop_atom = match prop_atom_opt.as_ref() {
            Some(&atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        Some(self.resolve_string_property(prop_name, prop_atom))
    }

    fn visit_string_intrinsic(
        &mut self,
        _kind: crate::types::StringIntrinsicKind,
        _type_arg: TypeId,
    ) -> Self::Output {
        // String intrinsics (Uppercase<T>, Lowercase<T>, Capitalize<T>, etc.)
        // are string-like for property access
        let prop_name = self.current_prop_name.borrow();
        let prop_atom_opt = self.current_prop_atom.borrow();

        let prop_name = prop_name.as_deref()?;
        let prop_atom = match prop_atom_opt.as_ref() {
            Some(&atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        Some(self.resolve_string_property(prop_name, prop_atom))
    }

    fn visit_union(&mut self, list_id: u32) -> Self::Output {
        let prop_name = self.current_prop_name.borrow();
        let prop_atom_opt = self.current_prop_atom.borrow();

        let prop_name = prop_name.as_deref()?;

        self.visit_union_impl(list_id, prop_name, prop_atom_opt.as_ref().copied())
    }

    fn default_output() -> Self::Output {
        None
    }
}

impl<'a> PropertyAccessEvaluator<'a> {
    // Helper methods to call visitor logic from &self context
    // These contain the actual implementation that the TypeVisitor trait methods delegate to

    pub(crate) fn visit_object_impl(
        &self,
        shape_id: u32,
        prop_name: &str,
        prop_atom: Option<Atom>,
    ) -> Option<PropertyAccessResult> {
        use crate::index_signatures::{IndexKind, IndexSignatureResolver};

        let prop_atom = match prop_atom {
            Some(atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        let shape = self.interner().object_shape(ObjectShapeId(shape_id));

        // Check explicit properties first
        if let Some(prop) =
            self.lookup_object_property(ObjectShapeId(shape_id), &shape.properties, prop_atom)
        {
            let write = (prop.write_type != prop.type_id).then_some(prop.write_type);
            return Some(PropertyAccessResult::Success {
                type_id: self.optional_property_type(prop),
                write_type: write,
                from_index_signature: false,
            });
        }

        // Check apparent members (toString, etc.)
        if let Some(result) = self.resolve_object_member(prop_name, prop_atom) {
            return Some(result);
        }

        // Check for index signatures (some Object types may have index signatures that aren't in ObjectWithIndex)
        let resolver = IndexSignatureResolver::new(self.interner());

        // Reconstruct obj_type from shape_id for index signature checking
        let obj_type = self.interner().object_with_flags_and_symbol(
            self.interner()
                .object_shape(ObjectShapeId(shape_id))
                .properties
                .clone(),
            self.interner().object_shape(ObjectShapeId(shape_id)).flags,
            self.interner().object_shape(ObjectShapeId(shape_id)).symbol,
        );

        // Try string index signature first (most common)
        if resolver.has_index_signature(obj_type, IndexKind::String)
            && let Some(value_type) = resolver.resolve_string_index(obj_type)
        {
            return Some(PropertyAccessResult::Success {
                type_id: self.add_undefined_if_unchecked(value_type),
                write_type: None,
                from_index_signature: true,
            });
        }

        // Try numeric index signature if property name looks numeric
        if resolver.is_numeric_index_name(prop_name)
            && let Some(value_type) = resolver.resolve_number_index(obj_type)
        {
            return Some(PropertyAccessResult::Success {
                type_id: self.add_undefined_if_unchecked(value_type),
                write_type: None,
                from_index_signature: true,
            });
        }

        Some(PropertyAccessResult::PropertyNotFound {
            type_id: obj_type,
            property_name: prop_atom,
        })
    }

    pub(crate) fn visit_object_with_index_impl(
        &self,
        shape_id: u32,
        prop_name: &str,
        prop_atom: Option<Atom>,
    ) -> Option<PropertyAccessResult> {
        use crate::index_signatures::IndexSignatureResolver;

        let prop_atom = match prop_atom {
            Some(atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        let shape = self.interner().object_shape(ObjectShapeId(shape_id));

        // Check explicit properties first
        if let Some(prop) =
            self.lookup_object_property(ObjectShapeId(shape_id), &shape.properties, prop_atom)
        {
            let write = (prop.write_type != prop.type_id).then_some(prop.write_type);
            return Some(PropertyAccessResult::Success {
                type_id: self.optional_property_type(prop),
                write_type: write,
                from_index_signature: false,
            });
        }

        // Check apparent members (toString, etc.)
        if let Some(result) = self.resolve_object_member(prop_name, prop_atom) {
            return Some(result);
        }

        // Check string index signature
        if let Some(ref idx) = shape.string_index {
            return Some(PropertyAccessResult::Success {
                type_id: self.add_undefined_if_unchecked(idx.value_type),
                write_type: None,
                from_index_signature: true,
            });
        }

        // Check numeric index signature if property name looks numeric
        let resolver = IndexSignatureResolver::new(self.interner());
        if resolver.is_numeric_index_name(prop_name)
            && let Some(ref idx) = shape.number_index
        {
            return Some(PropertyAccessResult::Success {
                type_id: self.add_undefined_if_unchecked(idx.value_type),
                write_type: None,
                from_index_signature: true,
            });
        }

        // Reconstruct obj_type for PropertyNotFound result
        let obj_type = self.interner().object_with_index((*shape).clone());

        Some(PropertyAccessResult::PropertyNotFound {
            type_id: obj_type,
            property_name: prop_atom,
        })
    }

    pub(crate) fn visit_array_impl(
        &self,
        obj_type: TypeId,
        prop_name: &str,
        prop_atom: Option<Atom>,
    ) -> Option<PropertyAccessResult> {
        let prop_atom = match prop_atom {
            Some(atom) => atom,
            None => self.interner().intern_string(prop_name),
        };
        Some(self.resolve_array_property(obj_type, prop_name, prop_atom))
    }

    pub(crate) fn visit_union_impl(
        &self,
        list_id: u32,
        prop_name: &str,
        prop_atom: Option<Atom>,
    ) -> Option<PropertyAccessResult> {
        use crate::index_signatures::{IndexKind, IndexSignatureResolver};

        let members = self.interner().type_list(crate::types::TypeListId(list_id));

        // Fast-path: if ANY member is any, result is any
        if members.contains(&TypeId::ANY) {
            return Some(PropertyAccessResult::Success {
                type_id: TypeId::ANY,
                write_type: None,
                from_index_signature: false,
            });
        }

        // Fast-path: if ANY member is error, result is error
        if members.contains(&TypeId::ERROR) {
            return Some(PropertyAccessResult::Success {
                type_id: TypeId::ERROR,
                write_type: None,
                from_index_signature: false,
            });
        }

        // Filter out UNKNOWN members - they shouldn't cause the entire union to be unknown
        // Only return IsUnknown if ALL members are UNKNOWN
        let non_unknown_members: Vec<_> = members
            .iter()
            .filter(|&&t| t != TypeId::UNKNOWN)
            .copied()
            .collect();

        if non_unknown_members.is_empty() {
            // All members are UNKNOWN
            return Some(PropertyAccessResult::IsUnknown);
        }

        // Reconstructing the union can be expensive for large unions. Delay it
        // until we actually need it for an error/index-signature fallback path.
        let mut obj_type_cache: Option<TypeId> = None;
        let mut obj_type_for_error = || {
            *obj_type_cache.get_or_insert_with(|| {
                self.interner()
                    .union(self.interner().type_list(TypeListId(list_id)).to_vec())
            })
        };

        let prop_atom = match prop_atom {
            Some(atom) => atom,
            None => self.interner().intern_string(prop_name),
        };

        // Property access on union: partition into nullable and non-nullable members
        let mut valid_results = Vec::new();
        let mut valid_write_results = Vec::new();
        let mut any_has_divergent_write_type = false;
        let mut nullable_causes = Vec::new();
        let mut any_from_index = false; // Track if any member used index signature

        for &member in &non_unknown_members {
            // Check for null/undefined directly
            if member.is_nullable() {
                let cause = if member == TypeId::VOID {
                    TypeId::UNDEFINED
                } else {
                    member
                };
                nullable_causes.push(cause);
                continue;
            }

            match self.resolve_property_access_inner(member, prop_name, Some(prop_atom)) {
                PropertyAccessResult::Success {
                    type_id,
                    write_type,
                    from_index_signature,
                } => {
                    valid_results.push(type_id);
                    if let Some(wt) = write_type {
                        valid_write_results.push(wt);
                        any_has_divergent_write_type = true;
                    } else {
                        valid_write_results.push(type_id);
                    }
                    if from_index_signature {
                        any_from_index = true; // Propagate: if ANY member uses index, flag it
                    }
                }
                PropertyAccessResult::PossiblyNullOrUndefined {
                    property_type,
                    cause,
                } => {
                    if let Some(t) = property_type {
                        valid_results.push(t);
                        valid_write_results.push(t);
                    }
                    nullable_causes.push(cause);
                }
                // PropertyNotFound: if ANY member is missing the property, the property does not exist on the Union
                PropertyAccessResult::PropertyNotFound { .. } => {
                    return Some(PropertyAccessResult::PropertyNotFound {
                        type_id: obj_type_for_error(),
                        property_name: prop_atom,
                    });
                }
                // IsUnknown: if any member is unknown, we cannot safely access the property
                PropertyAccessResult::IsUnknown => {
                    return Some(PropertyAccessResult::IsUnknown);
                }
            }
        }

        // If no non-nullable members had the property, it's a PropertyNotFound error
        if valid_results.is_empty() && nullable_causes.is_empty() {
            // Before giving up, check union-level index signatures
            let resolver = IndexSignatureResolver::new(self.interner());
            let obj_type = obj_type_for_error();

            if resolver.has_index_signature(obj_type, IndexKind::String)
                && let Some(value_type) = resolver.resolve_string_index(obj_type)
            {
                return Some(PropertyAccessResult::Success {
                    type_id: self.add_undefined_if_unchecked(value_type),
                    write_type: None,
                    from_index_signature: true,
                });
            }

            if resolver.is_numeric_index_name(prop_name)
                && let Some(value_type) = resolver.resolve_number_index(obj_type)
            {
                return Some(PropertyAccessResult::Success {
                    type_id: self.add_undefined_if_unchecked(value_type),
                    write_type: None,
                    from_index_signature: true,
                });
            }

            return Some(PropertyAccessResult::PropertyNotFound {
                type_id: obj_type,
                property_name: prop_atom,
            });
        }

        // If there are nullable causes, return PossiblyNullOrUndefined
        if !nullable_causes.is_empty() {
            let cause = if nullable_causes.len() == 1 {
                nullable_causes[0]
            } else {
                self.interner().union(nullable_causes)
            };

            let mut property_type = if valid_results.is_empty() {
                None
            } else if valid_results.len() == 1 {
                Some(valid_results[0])
            } else {
                Some(self.interner().union(valid_results))
            };

            if any_from_index
                && self.no_unchecked_indexed_access
                && let Some(t) = property_type
            {
                property_type = Some(self.add_undefined_if_unchecked(t));
            }

            return Some(PropertyAccessResult::PossiblyNullOrUndefined {
                property_type,
                cause,
            });
        }

        let mut type_id = self.interner().union(valid_results);
        if any_from_index && self.no_unchecked_indexed_access {
            type_id = self.add_undefined_if_unchecked(type_id);
        }

        let write_type = if any_has_divergent_write_type {
            let mut wt = self.interner().union(valid_write_results);
            if any_from_index && self.no_unchecked_indexed_access {
                wt = self.add_undefined_if_unchecked(wt);
            }
            if wt != type_id { Some(wt) } else { None }
        } else {
            None
        };

        // Union of all result types
        Some(PropertyAccessResult::Success {
            type_id,
            write_type,
            from_index_signature: any_from_index, // Contagious across union members
        })
    }
}