tsk-ai 0.10.7

tsk-tsk: keeping your agents out of trouble with sandboxed coding agent automation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
use async_trait::async_trait;
use serde::Deserialize;

use crate::agent::log_line::{Level, LogLine};
use crate::agent::{LogProcessor, TaskResult};

/// Represents an event from Codex's JSON output
#[derive(Debug, Deserialize)]
struct CodexEvent {
    #[serde(rename = "type")]
    event_type: String,
    item: Option<ItemData>,
    usage: Option<UsageData>,
    error: Option<ErrorData>,
}

/// Item data structure from Codex events
#[derive(Debug, Deserialize)]
struct ItemData {
    #[serde(rename = "type")]
    item_type: String,
    command: Option<String>,
    text: Option<String>,
    aggregated_output: Option<String>,
    exit_code: Option<i32>,
    changes: Option<Vec<FileChange>>,
}

/// File change information
#[derive(Debug, Deserialize)]
struct FileChange {
    path: String,
}

/// Usage information from Codex turn.completed events
#[derive(Debug, Deserialize)]
struct UsageData {
    input_tokens: Option<u64>,
    output_tokens: Option<u64>,
    cached_input_tokens: Option<u64>,
}

/// Error information from Codex error events
#[derive(Debug, Deserialize)]
struct ErrorData {
    message: String,
}

/// Codex-specific log processor that parses and formats JSON output
///
/// This processor produces structured `LogLine` values including:
/// - Command execution with output previews
/// - Agent messages and reasoning
/// - File changes and tool invocations
/// - TODO list updates
/// - Turn completion with token usage and cost
///
/// The processor handles non-JSON output gracefully:
/// - Initially prints non-JSON lines as-is (for misconfiguration messages)
/// - Switches to JSON-only mode after the first valid JSON line
pub struct CodexLogProcessor {
    final_result: Option<TaskResult>,
    json_mode_active: bool,
    /// Track whether the previous line was a parsing error to avoid duplicate error messages
    last_line_was_parse_error: bool,
}

impl CodexLogProcessor {
    /// Creates a new CodexLogProcessor
    pub fn new() -> Self {
        Self {
            final_result: None,
            json_mode_active: false,
            last_line_was_parse_error: false,
        }
    }

    /// Returns the standard codex tags
    fn tags() -> Vec<String> {
        vec!["codex".into()]
    }

    /// Simplifies a command by removing bash -lc wrapper boilerplate
    fn simplify_command(&self, command: &str) -> String {
        // Handle: bash -lc 'actual command'
        if let Some(inner) = command.strip_prefix("bash -lc '")
            && let Some(cmd) = inner.strip_suffix('\'')
        {
            return cmd.to_string();
        }

        // Handle: bash -lc "actual command"
        if let Some(inner) = command.strip_prefix("bash -lc \"")
            && let Some(cmd) = inner.strip_suffix('"')
        {
            return cmd.to_string();
        }

        // Handle: bash -lc command (no quotes)
        if let Some(inner) = command.strip_prefix("bash -lc ") {
            return inner.to_string();
        }

        // No match, return original
        command.to_string()
    }

    /// Formats a Codex event based on its type
    fn format_event(&mut self, event: CodexEvent) -> Option<LogLine> {
        match event.event_type.as_str() {
            "thread.started" => None, // Filter out noise
            "turn.started" => None,   // Filter out noise
            "turn.completed" => self.format_turn_completed(event),
            "turn.failed" => self.format_turn_failed(event),
            "item.started" => self.format_item_started(event),
            "item.updated" => None, // Redundant with completed
            "item.completed" => self.format_item_completed(event),
            "error" => self.format_error(event),
            _ => {
                // Unknown event type - log for debugging but don't show
                None
            }
        }
    }

    /// Formats a turn.completed event with usage statistics
    fn format_turn_completed(&mut self, event: CodexEvent) -> Option<LogLine> {
        if let Some(usage) = event.usage {
            self.final_result = Some(TaskResult {
                success: true,
                message: "Task completed successfully".to_string(),
                cost_usd: None,
                duration_ms: None,
            });

            let input = usage.input_tokens.unwrap_or(0);
            let output = usage.output_tokens.unwrap_or(0);
            let cached = usage.cached_input_tokens.unwrap_or(0);

            Some(LogLine::summary(
                true,
                format!(
                    "Task completed - {} input tokens, {} output tokens, {} cached tokens",
                    input, output, cached
                ),
                None,
                None,
                None,
            ))
        } else {
            Some(LogLine::summary(
                true,
                "Task completed".into(),
                None,
                None,
                None,
            ))
        }
    }

    /// Formats a turn.failed event with error details
    fn format_turn_failed(&mut self, event: CodexEvent) -> Option<LogLine> {
        let error_msg = event
            .error
            .as_ref()
            .map(|e| e.message.as_str())
            .unwrap_or("Unknown error");

        self.final_result = Some(TaskResult {
            success: false,
            message: format!("Turn failed: {}", error_msg),
            cost_usd: None,
            duration_ms: None,
        });

        Some(LogLine::summary(
            false,
            format!("Turn failed: {}", error_msg),
            None,
            None,
            None,
        ))
    }

    /// Formats an item.started event with context based on item type
    fn format_item_started(&mut self, event: CodexEvent) -> Option<LogLine> {
        if let Some(item) = event.item {
            let tags = Self::tags();
            match item.item_type.as_str() {
                "command_execution" => {
                    let cmd = item.command.as_deref().unwrap_or("unknown");
                    let simplified_cmd = self.simplify_command(cmd);
                    Some(LogLine::message(
                        tags,
                        Some("command_execution".into()),
                        format!("Running: {}", simplified_cmd),
                    ))
                }
                "agent_message" => None, // Wait for completion
                "reasoning" => Some(LogLine::message(
                    tags,
                    Some("reasoning".into()),
                    "Reasoning...".into(),
                )),
                "file_change" => Some(LogLine::message(
                    tags,
                    Some("file_change".into()),
                    "Modifying file...".into(),
                )),
                "mcp_tool_call" => Some(LogLine::message(
                    tags,
                    Some("mcp_tool_call".into()),
                    "Calling tool...".into(),
                )),
                "web_search" => Some(LogLine::message(
                    tags,
                    Some("web_search".into()),
                    "Searching web...".into(),
                )),
                "todo_list" => None, // Wait for completion
                _ => {
                    // Unknown item type - show generic message
                    Some(LogLine::message(
                        tags,
                        Some(item.item_type.clone()),
                        format!("{}: started", item.item_type),
                    ))
                }
            }
        } else {
            None
        }
    }

    /// Formats an item.completed event with result summary
    fn format_item_completed(&mut self, event: CodexEvent) -> Option<LogLine> {
        if let Some(item) = event.item {
            let tags = Self::tags();
            match item.item_type.as_str() {
                "command_execution" => {
                    let exit_code = item.exit_code.unwrap_or(-1);
                    let mut result_msg = String::new();

                    // Check if this is a test command with results
                    if let Some(stdout) = &item.aggregated_output {
                        if stdout.contains("test result: ok") {
                            result_msg = " - Tests passed".to_string();
                        } else if stdout.contains("test result: FAILED") {
                            result_msg = " - Tests failed".to_string();
                        }
                    }

                    // Determine level based on test results and exit code
                    let level = if result_msg.contains("Tests passed") {
                        Level::Success
                    } else if result_msg.contains("Tests failed") || exit_code != 0 {
                        Level::Error
                    } else {
                        Level::Info
                    };

                    // Only show output preview for errors (non-zero exit) or if we didn't find test results
                    if exit_code != 0
                        && result_msg.is_empty()
                        && let Some(stdout) = &item.aggregated_output
                    {
                        let preview = stdout.lines().next().unwrap_or("").trim();
                        if !preview.is_empty() {
                            if preview.len() > 60 {
                                result_msg = format!(" - {}...", &preview[..60]);
                            } else {
                                result_msg = format!(" - {}", preview);
                            }
                        }
                    }

                    Some(LogLine::Message {
                        level,
                        tags,
                        tool: Some("command_execution".into()),
                        message: format!("Command completed (exit: {}){}", exit_code, result_msg),
                    })
                }
                "agent_message" => {
                    if let Some(text) = item.text {
                        if !text.trim().is_empty() {
                            Some(LogLine::message(tags, None, text.trim().to_string()))
                        } else {
                            None
                        }
                    } else {
                        None
                    }
                }
                "reasoning" => {
                    if let Some(text) = item.text {
                        // Show snippet of reasoning (first line, max 80 chars)
                        let snippet = text.lines().next().unwrap_or("").trim();
                        if snippet.len() > 80 {
                            Some(LogLine::message(
                                tags,
                                Some("reasoning".into()),
                                format!("{}...", &snippet[..77]),
                            ))
                        } else if !snippet.is_empty() {
                            Some(LogLine::message(
                                tags,
                                Some("reasoning".into()),
                                snippet.to_string(),
                            ))
                        } else {
                            None
                        }
                    } else {
                        None
                    }
                }
                "file_change" => {
                    if let Some(changes) = &item.changes {
                        // Extract filenames from paths (remove /workspace/{project}/ prefix if present)
                        let filenames: Vec<String> = changes
                            .iter()
                            .map(|c| {
                                c.path
                                    .strip_prefix("/workspace/")
                                    .and_then(|rest| rest.split_once('/').map(|(_, after)| after))
                                    .unwrap_or(&c.path)
                                    .to_string()
                            })
                            .collect();

                        if filenames.is_empty() {
                            Some(LogLine::success(
                                tags,
                                Some("file_change".into()),
                                "File modified".into(),
                            ))
                        } else if filenames.len() == 1 {
                            Some(LogLine::success(
                                tags,
                                Some("file_change".into()),
                                format!("Modified: {}", filenames[0]),
                            ))
                        } else {
                            Some(LogLine::success(
                                tags,
                                Some("file_change".into()),
                                format!(
                                    "Modified {} files: {}, ...",
                                    filenames.len(),
                                    filenames[0]
                                ),
                            ))
                        }
                    } else {
                        Some(LogLine::success(
                            tags,
                            Some("file_change".into()),
                            "File modified".into(),
                        ))
                    }
                }
                "mcp_tool_call" => Some(LogLine::message(
                    tags,
                    Some("mcp_tool_call".into()),
                    "Tool completed".into(),
                )),
                "web_search" => Some(LogLine::message(
                    tags,
                    Some("web_search".into()),
                    "Search completed".into(),
                )),
                "todo_list" => {
                    if let Some(text) = item.text {
                        // Extract first TODO item as summary
                        let summary = text
                            .lines()
                            .find(|line| !line.trim().is_empty())
                            .unwrap_or("TODO updated");
                        Some(LogLine::message(
                            tags,
                            Some("todo_list".into()),
                            format!("TODO: {}", summary.trim()),
                        ))
                    } else {
                        Some(LogLine::message(
                            tags,
                            Some("todo_list".into()),
                            "TODO updated".into(),
                        ))
                    }
                }
                _ => {
                    // Unknown item type - show generic completion
                    Some(LogLine::message(
                        tags,
                        Some(item.item_type.clone()),
                        format!("{}: completed", item.item_type),
                    ))
                }
            }
        } else {
            None
        }
    }

    /// Formats an error event
    fn format_error(&mut self, event: CodexEvent) -> Option<LogLine> {
        if let Some(error) = event.error {
            Some(LogLine::error(
                Self::tags(),
                None,
                format!("Error: {}", error.message),
            ))
        } else {
            Some(LogLine::error(Self::tags(), None, "Error occurred".into()))
        }
    }
}

#[async_trait]
impl LogProcessor for CodexLogProcessor {
    fn process_line(&mut self, line: &str) -> Option<LogLine> {
        // Skip empty lines - don't reset error tracking
        if line.trim().is_empty() {
            return None;
        }

        // Try to parse as JSON
        match serde_json::from_str::<CodexEvent>(line) {
            Ok(event) => {
                // Successfully parsed JSON - activate JSON mode if not already active
                if !self.json_mode_active {
                    self.json_mode_active = true;
                }
                // Reset the error flag on successful parse
                self.last_line_was_parse_error = false;
                self.format_event(event)
            }
            Err(_) => {
                if self.json_mode_active {
                    // Check if we should suppress this error
                    if self.last_line_was_parse_error {
                        // Suppress duplicate parsing error
                        None
                    } else {
                        // Show first parsing error in sequence
                        self.last_line_was_parse_error = true;
                        Some(LogLine::warning(Self::tags(), None, "parsing error".into()))
                    }
                } else {
                    // Before JSON mode is active, pass through non-JSON lines as-is
                    Some(LogLine::message(vec![], None, line.to_string()))
                }
            }
        }
    }

    fn get_final_result(&self) -> Option<&TaskResult> {
        self.final_result.as_ref()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn get_message_text(line: &LogLine) -> &str {
        match line {
            LogLine::Message { message, .. } => message,
            _ => panic!("Expected Message variant, got {:?}", line),
        }
    }

    fn has_tag(line: &LogLine, tag: &str) {
        let tags = match line {
            LogLine::Message { tags, .. } => tags,
            LogLine::Todo { tags, .. } => tags,
            LogLine::Summary { .. } => panic!("Summary has no tags"),
        };
        assert!(
            tags.iter().any(|t| t == tag),
            "Expected tag '{}' in {:?}",
            tag,
            tags
        );
    }

    #[test]
    fn test_thread_and_turn_events() {
        let mut processor = CodexLogProcessor::new();

        let thread_started = r#"{"type":"thread.started","thread_id":"test-123"}"#;
        assert_eq!(processor.process_line(thread_started), None);

        let turn_started = r#"{"type":"turn.started"}"#;
        assert_eq!(processor.process_line(turn_started), None);
    }

    #[test]
    fn test_command_execution_events() {
        let mut processor = CodexLogProcessor::new();

        let started = r#"{"type":"item.started","item":{"id":"item_0","type":"command_execution","command":"ls -la","status":"in_progress"}}"#;
        let output = processor.process_line(started).unwrap();
        has_tag(&output, "codex");
        assert!(get_message_text(&output).contains("Running: ls -la"));

        let completed = r#"{"type":"item.completed","item":{"id":"item_0","type":"command_execution","command":"ls -la","aggregated_output":"file1.txt\nfile2.txt","exit_code":0,"status":"completed"}}"#;
        let output = processor.process_line(completed).unwrap();
        has_tag(&output, "codex");
        assert!(get_message_text(&output).contains("Command completed (exit: 0)"));
        assert!(!get_message_text(&output).contains("file1.txt")); // Should not show output for successful commands
    }

    #[test]
    fn test_agent_message_events() {
        let mut processor = CodexLogProcessor::new();

        let completed = r#"{"type":"item.completed","item":{"id":"item_1","type":"agent_message","text":"This is my response"}}"#;
        let output = processor.process_line(completed).unwrap();
        has_tag(&output, "codex");
        assert_eq!(get_message_text(&output), "This is my response");
    }

    #[test]
    fn test_turn_completed_with_usage() {
        let mut processor = CodexLogProcessor::new();

        let completed = r#"{"type":"turn.completed","usage":{"input_tokens":1000,"output_tokens":500,"cached_input_tokens":200}}"#;
        let output = processor.process_line(completed).unwrap();
        if let LogLine::Summary {
            success, message, ..
        } = &output
        {
            assert!(success);
            assert!(message.contains("1000 input tokens"));
            assert!(message.contains("500 output tokens"));
            assert!(message.contains("200 cached tokens"));
        } else {
            panic!("Expected Summary variant");
        }

        // Check final result was extracted
        let result = processor.get_final_result().unwrap();
        assert!(result.success);
        assert!(result.cost_usd.is_none());
    }

    #[test]
    fn test_turn_failed() {
        let mut processor = CodexLogProcessor::new();

        let failed = r#"{"type":"turn.failed","error":{"message":"API request failed"}}"#;
        let output = processor.process_line(failed).unwrap();
        if let LogLine::Summary {
            success, message, ..
        } = &output
        {
            assert!(!success);
            assert!(message.contains("Turn failed: API request failed"));
        } else {
            panic!("Expected Summary variant");
        }

        let result = processor.get_final_result().unwrap();
        assert!(!result.success);
    }

    #[test]
    fn test_json_mode_behavior() {
        let mut processor = CodexLogProcessor::new();

        // Before JSON mode, non-JSON passes through
        let result = processor.process_line("Configuration error");
        assert_eq!(get_message_text(&result.unwrap()), "Configuration error");
        assert!(!processor.json_mode_active);

        // First valid JSON activates JSON mode
        let json = r#"{"type":"turn.started"}"#;
        processor.process_line(json);
        assert!(processor.json_mode_active);

        // After JSON mode, non-JSON shows parsing error
        let result = processor.process_line("Not JSON").unwrap();
        if let LogLine::Message { level, message, .. } = &result {
            assert_eq!(*level, Level::Warning);
            assert_eq!(message, "parsing error");
        }
    }

    #[test]
    fn test_parse_error_deduplication() {
        let mut processor = CodexLogProcessor::new();

        // Activate JSON mode
        processor.process_line(r#"{"type":"turn.started"}"#);

        // First error shown
        let result = processor.process_line("Bad line 1").unwrap();
        if let LogLine::Message { level, .. } = &result {
            assert_eq!(*level, Level::Warning);
        }

        // Subsequent errors suppressed
        assert_eq!(processor.process_line("Bad line 2"), None);
        assert_eq!(processor.process_line("Bad line 3"), None);

        // Valid JSON resets
        processor.process_line(r#"{"type":"turn.started"}"#);

        // Next error shown again
        let result = processor.process_line("Bad line 4").unwrap();
        if let LogLine::Message { level, .. } = &result {
            assert_eq!(*level, Level::Warning);
        }
    }

    #[test]
    fn test_reasoning_and_file_change() {
        let mut processor = CodexLogProcessor::new();

        // Reasoning started
        let started = r#"{"type":"item.started","item":{"id":"item_1","type":"reasoning"}}"#;
        let output = processor.process_line(started).unwrap();
        has_tag(&output, "codex");
        assert!(get_message_text(&output).contains("Reasoning..."));

        // Reasoning completed with text
        let completed = r#"{"type":"item.completed","item":{"id":"item_1","type":"reasoning","text":"I need to analyze the code structure"}}"#;
        let output = processor.process_line(completed).unwrap();
        has_tag(&output, "codex");
        assert!(get_message_text(&output).contains("I need to analyze"));

        // File change with path
        let file_completed = r#"{"type":"item.completed","item":{"id":"item_2","type":"file_change","changes":[{"path":"/workspace/test-project/src/main.rs","kind":"update"}]}}"#;
        let output = processor.process_line(file_completed).unwrap();
        has_tag(&output, "codex");
        if let LogLine::Message { level, message, .. } = &output {
            assert_eq!(*level, Level::Success);
            assert!(message.contains("Modified: src/main.rs"));
        }

        // File change without changes array (fallback)
        let file_completed_no_changes =
            r#"{"type":"item.completed","item":{"id":"item_3","type":"file_change"}}"#;
        let output = processor.process_line(file_completed_no_changes).unwrap();
        if let LogLine::Message { level, message, .. } = &output {
            assert_eq!(*level, Level::Success);
            assert!(message.contains("File modified"));
        }
    }

    #[test]
    fn test_multiple_file_changes() {
        let mut processor = CodexLogProcessor::new();

        // Multiple file changes
        let file_completed = r#"{"type":"item.completed","item":{"id":"item_1","type":"file_change","changes":[{"path":"/workspace/test-project/src/main.rs","kind":"update"},{"path":"/workspace/test-project/src/lib.rs","kind":"update"},{"path":"/workspace/test-project/Cargo.toml","kind":"update"}]}}"#;
        let output = processor.process_line(file_completed).unwrap();
        if let LogLine::Message { level, message, .. } = &output {
            assert_eq!(*level, Level::Success);
            assert!(message.contains("Modified 3 files: src/main.rs, ..."));
        }
    }

    #[test]
    fn test_empty_lines_dont_reset_error_tracking() {
        let mut processor = CodexLogProcessor::new();

        // Activate JSON mode
        let json = r#"{"type":"turn.started"}"#;
        processor.process_line(json);

        // First parsing error shown
        let result = processor.process_line("Bad line 1").unwrap();
        if let LogLine::Message { level, .. } = &result {
            assert_eq!(*level, Level::Warning);
        }

        // Empty line should not reset error tracking
        let result = processor.process_line("");
        assert_eq!(result, None);

        // Next parsing error should still be suppressed
        let result = processor.process_line("Bad line 2");
        assert_eq!(result, None);
    }

    #[test]
    fn test_unknown_item_types() {
        let mut processor = CodexLogProcessor::new();

        let started = r#"{"type":"item.started","item":{"id":"item_1","type":"unknown_type"}}"#;
        let output = processor.process_line(started).unwrap();
        has_tag(&output, "codex");
        assert!(get_message_text(&output).contains("unknown_type: started"));

        let completed = r#"{"type":"item.completed","item":{"id":"item_1","type":"unknown_type"}}"#;
        let output = processor.process_line(completed).unwrap();
        has_tag(&output, "codex");
        assert!(get_message_text(&output).contains("unknown_type: completed"));
    }

    #[test]
    fn test_todo_list() {
        let mut processor = CodexLogProcessor::new();

        let completed = r#"{"type":"item.completed","item":{"id":"item_1","type":"todo_list","text":"- Implement feature A\n- Test feature A\n- Document feature A"}}"#;
        let output = processor.process_line(completed).unwrap();
        has_tag(&output, "codex");
        assert!(get_message_text(&output).contains("TODO:"));
        assert!(get_message_text(&output).contains("Implement feature A"));
    }

    #[test]
    fn test_long_output_truncation() {
        let mut processor = CodexLogProcessor::new();

        // Test command with long output - should not show output for exit 0
        let long_output = "a".repeat(100);
        let completed = format!(
            r#"{{"type":"item.completed","item":{{"id":"item_0","type":"command_execution","aggregated_output":"{}","exit_code":0}}}}"#,
            long_output
        );
        let output = processor.process_line(&completed).unwrap();
        let text = get_message_text(&output);
        assert!(text.contains("Command completed (exit: 0)"));
        assert!(!text.contains("aaa")); // Should not show output for successful commands

        // Test reasoning with long text
        let long_reasoning = "b".repeat(100);
        let completed = format!(
            r#"{{"type":"item.completed","item":{{"id":"item_1","type":"reasoning","text":"{}"}}}}"#,
            long_reasoning
        );
        let output = processor.process_line(&completed).unwrap();
        let text = get_message_text(&output);
        assert!(text.contains("..."));
        assert!(text.len() < long_reasoning.len() + 50); // Should be truncated
    }

    #[test]
    fn test_empty_agent_message() {
        let mut processor = CodexLogProcessor::new();

        let completed = r#"{"type":"item.completed","item":{"id":"item_1","type":"agent_message","text":"   "}}"#;
        let output = processor.process_line(completed);
        assert_eq!(output, None); // Empty messages should be filtered
    }

    #[test]
    fn test_command_simplification() {
        let mut processor = CodexLogProcessor::new();

        // Test single-quoted command
        let event = r#"{"type":"item.started","item":{"id":"item_0","type":"command_execution","command":"bash -lc 'ls -la'","status":"in_progress"}}"#;
        let output = processor.process_line(event).unwrap();
        let text = get_message_text(&output);
        assert!(text.contains("Running: ls -la"));
        assert!(!text.contains("bash -lc"));

        // Test double-quoted command
        let event = r#"{"type":"item.started","item":{"id":"item_1","type":"command_execution","command":"bash -lc \"echo hello\"","status":"in_progress"}}"#;
        let output = processor.process_line(event).unwrap();
        assert!(get_message_text(&output).contains("Running: echo hello"));

        // Test nested quotes
        let event = r#"{"type":"item.started","item":{"id":"item_2","type":"command_execution","command":"bash -lc 'rg \"fn main\" src'","status":"in_progress"}}"#;
        let output = processor.process_line(event).unwrap();
        assert!(get_message_text(&output).contains("Running: rg \"fn main\" src"));

        // Test command without quotes
        let event = r#"{"type":"item.started","item":{"id":"item_3","type":"command_execution","command":"bash -lc ls","status":"in_progress"}}"#;
        let output = processor.process_line(event).unwrap();
        let text = get_message_text(&output);
        assert!(text.contains("Running: ls"));
        assert!(!text.contains("bash -lc"));

        // Test multi-word command without quotes
        let event = r#"{"type":"item.started","item":{"id":"item_4","type":"command_execution","command":"bash -lc cat file.txt","status":"in_progress"}}"#;
        let output = processor.process_line(event).unwrap();
        let text = get_message_text(&output);
        assert!(text.contains("Running: cat file.txt"));
        assert!(!text.contains("bash -lc"));
    }

    #[test]
    fn test_verbose_output_filtering() {
        let mut processor = CodexLogProcessor::new();

        // Success with routine output - should hide output
        let event = r#"{"type":"item.completed","item":{"type":"command_execution","aggregated_output":"file1.txt\nfile2.txt","exit_code":0}}"#;
        let output = processor.process_line(event).unwrap();
        let text = get_message_text(&output);
        assert!(text.contains("Command completed (exit: 0)"));
        assert!(!text.contains("file1.txt"));

        // Test results - should show test status
        let event = r#"{"type":"item.completed","item":{"type":"command_execution","aggregated_output":"test result: ok. 13 passed","exit_code":0}}"#;
        let output = processor.process_line(event).unwrap();
        let text = get_message_text(&output);
        assert!(text.contains("Tests passed"));

        // Error - should show output
        let event = r#"{"type":"item.completed","item":{"type":"command_execution","aggregated_output":"error: file not found","exit_code":1}}"#;
        let output = processor.process_line(event).unwrap();
        let text = get_message_text(&output);
        assert!(text.contains("error: file not found"));
    }
}