tsafe-cli 1.0.22

tsafe CLI — local secret and credential manager (replaces .env files)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
//! AWS SSM Parameter Store HTTP client.
// `ureq::Error` is large; propagating it through `Result` triggers `clippy::result_large_err`.
#![allow(clippy::result_large_err)]

use super::config::{AwsConfig, AwsCredentials};
use super::error::AwsError;
use super::sigv4::sign_for_service;

fn endpoint_host(endpoint: &str) -> &str {
    endpoint
        .split_once("://")
        .map(|(_, rest)| rest)
        .unwrap_or(endpoint)
        .split('/')
        .next()
        .unwrap_or(endpoint)
}

const MAX_RETRIES_429: u32 = 3;
const MAX_RETRIES_TRANSIENT: u32 = 5;
const DEFAULT_RETRY_SECS: u64 = 2;

fn http_agent() -> ureq::Agent {
    ureq::AgentBuilder::new()
        .timeout_connect(std::time::Duration::from_secs(10))
        .timeout(std::time::Duration::from_secs(30))
        .build()
}

fn call_with_retry(
    make_request: impl Fn() -> Result<ureq::Response, ureq::Error>,
) -> Result<ureq::Response, ureq::Error> {
    let mut throttled_attempt = 0u32;
    let mut transient_attempt = 0u32;
    loop {
        match make_request() {
            Ok(resp) => return Ok(resp),
            Err(ureq::Error::Status(429, resp)) if throttled_attempt < MAX_RETRIES_429 => {
                let retry_after = resp
                    .header("Retry-After")
                    .and_then(|v| v.parse::<u64>().ok())
                    .unwrap_or(DEFAULT_RETRY_SECS * 2u64.pow(throttled_attempt));
                let wait = std::cmp::min(jittered_delay_secs(retry_after), 30);
                std::thread::sleep(std::time::Duration::from_secs(wait));
                throttled_attempt += 1;
            }
            Err(ureq::Error::Transport(t))
                if transient_attempt < MAX_RETRIES_TRANSIENT
                    && is_retryable_transport_error(t.to_string().as_str()) =>
            {
                let backoff = DEFAULT_RETRY_SECS * 2u64.pow(transient_attempt);
                let wait = std::cmp::min(jittered_delay_secs(backoff), 30);
                std::thread::sleep(std::time::Duration::from_secs(wait));
                transient_attempt += 1;
            }
            Err(e) => return Err(e),
        }
    }
}

fn is_retryable_transport_error(message: &str) -> bool {
    let msg = message.to_ascii_lowercase();
    msg.contains("timed out")
        || msg.contains("timeout")
        || msg.contains("connection reset")
        || msg.contains("connection refused")
        || msg.contains("econnreset")
        || msg.contains("econnrefused")
        || msg.contains("temporar")
}

fn jittered_delay_secs(base_secs: u64) -> u64 {
    if base_secs == 0 {
        return 0;
    }
    let jitter_cap = std::cmp::max(1, base_secs / 4);
    let nanos = std::time::SystemTime::now()
        .duration_since(std::time::UNIX_EPOCH)
        .map(|d| d.subsec_nanos() as u64)
        .unwrap_or(0);
    base_secs + (nanos % (jitter_cap + 1))
}

fn map_ureq_error(e: ureq::Error) -> AwsError {
    match e {
        ureq::Error::Status(400, resp) => {
            let body = resp.into_string().unwrap_or_default();
            if body.contains("ParameterNotFound") {
                AwsError::NotFound(body)
            } else {
                AwsError::Http {
                    status: 400,
                    message: body,
                }
            }
        }
        ureq::Error::Status(s, resp) => AwsError::Http {
            status: s,
            message: resp
                .into_string()
                .unwrap_or_else(|_| "<unreadable response>".into()),
        },
        other => AwsError::Transport(other.to_string()),
    }
}

/// Normalise an SSM parameter path to an environment variable key.
/// Strips any leading path separator, then replaces `/` and `-` with `_`
/// and uppercases the result.
///
/// Examples:
///   `/myapp/db-password`  → `MYAPP_DB_PASSWORD`
///   `myapp/api-key`       → `MYAPP_API_KEY`
///   `/DB_URL`             → `DB_URL`
pub fn normalize_ssm_name(name: &str) -> String {
    name.trim_start_matches('/')
        .replace(['/', '-'], "_")
        .to_uppercase()
}

fn normalize_ssm_path(path: Option<&str>) -> String {
    match path {
        Some("") | None => "/".to_string(),
        Some(p) if p.starts_with('/') => p.to_string(),
        Some(p) => format!("/{p}"),
    }
}

/// Pull parameters from AWS SSM Parameter Store under the given `path`.
///
/// Relative paths are normalized to absolute path prefixes, e.g. `myapp/prod/`
/// becomes `/myapp/prod/`. Parameters are fetched recursively (`Recursive=true`),
/// so all nested parameters under the path are returned. If `path` is `None`
/// the root `/` is used, which returns all parameters the caller has access to
/// -- use with caution on large accounts.
///
/// `get_creds` is called once per page to keep credentials fresh.
///
/// Returns `(normalized_key, value)` pairs. `SecureString` parameters are
/// decrypted automatically (`WithDecryption=true`).
pub fn pull_ssm_parameters(
    cfg: &AwsConfig,
    get_creds: &impl Fn() -> Result<AwsCredentials, AwsError>,
    path: Option<&str>,
) -> Result<Vec<(String, String)>, AwsError> {
    const TARGET: &str = "AmazonSSM.GetParametersByPath";
    let root = normalize_ssm_path(path);
    let agent = http_agent();
    let mut results = Vec::new();
    let mut next_token: Option<String> = None;

    loop {
        let creds = get_creds()?;

        let body = match &next_token {
            Some(tok) => serde_json::json!({
                "Path": root,
                "Recursive": true,
                "WithDecryption": true,
                "MaxResults": 10,
                "NextToken": tok,
            }),
            None => serde_json::json!({
                "Path": root,
                "Recursive": true,
                "WithDecryption": true,
                "MaxResults": 10,
            }),
        };
        let body_str = body.to_string();

        let sig = sign_for_service(
            "ssm",
            &cfg.region,
            endpoint_host(&cfg.endpoint),
            TARGET,
            &body_str,
            &creds.access_key_id,
            &creds.secret_access_key,
            creds.session_token.as_deref(),
        );

        let body_clone = body_str.clone();
        let endpoint = cfg.endpoint.clone();
        let resp: serde_json::Value = call_with_retry(|| {
            let mut req = agent
                .post(&endpoint)
                .set("Content-Type", "application/x-amz-json-1.1")
                .set("X-Amz-Target", TARGET)
                .set("X-Amz-Date", &sig.x_amz_date)
                .set("Authorization", &sig.authorization);
            if let Some(ref tok) = sig.x_amz_security_token {
                req = req.set("X-Amz-Security-Token", tok);
            }
            req.send_string(&body_clone)
        })
        .map_err(map_ureq_error)?
        .into_json()
        .map_err(|e| AwsError::Transport(e.to_string()))?;

        let params = resp["Parameters"]
            .as_array()
            .ok_or_else(|| AwsError::Transport("SSM response missing 'Parameters' array".into()))?;
        for param in params {
            if let (Some(name), Some(value)) = (param["Name"].as_str(), param["Value"].as_str()) {
                let key = normalize_ssm_name(name);
                results.push((key, value.to_string()));
            }
        }

        next_token = resp["NextToken"].as_str().map(|s| s.to_string());
        if next_token.is_none() {
            break;
        }
    }

    Ok(results)
}

/// Outcome of a `push_ssm_parameter` call.
#[derive(Debug, PartialEq, Eq)]
pub enum PushOutcome {
    /// The parameter did not exist and was created.
    Created,
    /// The parameter existed and was updated with a new value.
    Updated,
    /// The parameter existed with an identical value — no write performed.
    Unchanged,
    /// The parameter was deleted (returned by delete operations, not push).
    Deleted,
}

/// Push a value to AWS SSM Parameter Store (upsert semantics).
///
/// - First fetches the current value via `GetParameter` to detect create vs. update
///   and skip identical values.
/// - If `overwrite` is `false` and the parameter already exists with a different value,
///   the call returns `PushOutcome::Unchanged` without writing (no-clobber mode).
/// - The parameter type is always `SecureString`.
#[tracing::instrument(skip(cfg, get_creds, value), fields(name = %name))]
pub fn push_ssm_parameter(
    cfg: &AwsConfig,
    get_creds: &impl Fn() -> Result<AwsCredentials, AwsError>,
    name: &str,
    value: &str,
    overwrite: bool,
) -> Result<PushOutcome, AwsError> {
    let creds = get_creds()?;

    // Read the current value so we can skip identical writes.
    match get_ssm_parameter(cfg, &creds, name) {
        Ok(existing_value) => {
            if existing_value == value {
                return Ok(PushOutcome::Unchanged);
            }
            if !overwrite {
                return Ok(PushOutcome::Unchanged);
            }
            // Value differs and overwrite is allowed — update.
            put_ssm_parameter(cfg, &creds, name, value, true)?;
            Ok(PushOutcome::Updated)
        }
        Err(AwsError::NotFound(_)) => {
            // Parameter doesn't exist — create it.
            put_ssm_parameter(cfg, &creds, name, value, false)?;
            Ok(PushOutcome::Created)
        }
        Err(e) => Err(e),
    }
}

/// Read the current string value of a single SSM parameter (without decryption needed for
/// the comparison — we request decryption so we compare the actual plaintext).
fn get_ssm_parameter(
    cfg: &AwsConfig,
    creds: &AwsCredentials,
    name: &str,
) -> Result<String, AwsError> {
    const TARGET: &str = "AmazonSSM.GetParameter";
    let agent = http_agent();
    let body = serde_json::json!({
        "Name": name,
        "WithDecryption": true,
    })
    .to_string();

    let sig = sign_for_service(
        "ssm",
        &cfg.region,
        endpoint_host(&cfg.endpoint),
        TARGET,
        &body,
        &creds.access_key_id,
        &creds.secret_access_key,
        creds.session_token.as_deref(),
    );

    let body_clone = body.clone();
    let endpoint = cfg.endpoint.clone();
    let resp: serde_json::Value = call_with_retry(|| {
        let mut req = agent
            .post(&endpoint)
            .set("Content-Type", "application/x-amz-json-1.1")
            .set("X-Amz-Target", TARGET)
            .set("X-Amz-Date", &sig.x_amz_date)
            .set("Authorization", &sig.authorization);
        if let Some(ref tok) = sig.x_amz_security_token {
            req = req.set("X-Amz-Security-Token", tok);
        }
        req.send_string(&body_clone)
    })
    .map_err(map_ureq_error)?
    .into_json()
    .map_err(|e| AwsError::Transport(e.to_string()))?;

    resp["Parameter"]["Value"]
        .as_str()
        .map(|s| s.to_string())
        .ok_or_else(|| AwsError::NotFound(name.to_string()))
}

/// Write an SSM parameter via PutParameter. Uses `SecureString` type.
fn put_ssm_parameter(
    cfg: &AwsConfig,
    creds: &AwsCredentials,
    name: &str,
    value: &str,
    overwrite: bool,
) -> Result<(), AwsError> {
    const TARGET: &str = "AmazonSSM.PutParameter";
    let agent = http_agent();
    let body = serde_json::json!({
        "Name": name,
        "Value": value,
        "Type": "SecureString",
        "Overwrite": overwrite,
    })
    .to_string();

    let sig = sign_for_service(
        "ssm",
        &cfg.region,
        endpoint_host(&cfg.endpoint),
        TARGET,
        &body,
        &creds.access_key_id,
        &creds.secret_access_key,
        creds.session_token.as_deref(),
    );

    let body_clone = body.clone();
    let endpoint = cfg.endpoint.clone();
    call_with_retry(|| {
        let mut req = agent
            .post(&endpoint)
            .set("Content-Type", "application/x-amz-json-1.1")
            .set("X-Amz-Target", TARGET)
            .set("X-Amz-Date", &sig.x_amz_date)
            .set("Authorization", &sig.authorization);
        if let Some(ref tok) = sig.x_amz_security_token {
            req = req.set("X-Amz-Security-Token", tok);
        }
        req.send_string(&body_clone)
    })
    .map_err(map_ureq_error)?;

    Ok(())
}

// ── tests ─────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::super::config::{AwsConfig, AwsCredentials};
    use super::*;

    fn test_creds() -> AwsCredentials {
        AwsCredentials {
            access_key_id: "AKID-TEST".into(),
            secret_access_key: "secret-test".into(),
            session_token: None,
        }
    }

    fn cfg(url: &str) -> AwsConfig {
        AwsConfig::with_endpoint("us-east-1", url)
    }

    fn params_response(params: &[(&str, &str)], next_token: Option<&str>) -> String {
        let items: Vec<String> = params
            .iter()
            .map(|(name, value)| {
                format!(r#"{{"Name":"{name}","Value":"{value}","Type":"SecureString"}}"#)
            })
            .collect();
        match next_token {
            Some(tok) => format!(
                r#"{{"Parameters":[{}],"NextToken":"{tok}"}}"#,
                items.join(",")
            ),
            None => format!(r#"{{"Parameters":[{}]}}"#, items.join(",")),
        }
    }

    // ── pure-logic tests ──────────────────────────────────────────────────────

    #[test]
    fn normalize_ssm_name_absolute_path() {
        assert_eq!(
            normalize_ssm_name("/myapp/db-password"),
            "MYAPP_DB_PASSWORD"
        );
    }

    #[test]
    fn normalize_ssm_name_relative_path() {
        assert_eq!(normalize_ssm_name("myapp/api-key"), "MYAPP_API_KEY");
    }

    #[test]
    fn normalize_ssm_name_deep_path() {
        assert_eq!(
            normalize_ssm_name("/prod/myapp/DB_URL"),
            "PROD_MYAPP_DB_URL"
        );
    }

    #[test]
    fn retryable_transport_classifier_detects_timeout() {
        assert!(is_retryable_transport_error("operation timed out"));
        assert!(is_retryable_transport_error("Connection reset by peer"));
        assert!(!is_retryable_transport_error("invalid request payload"));
    }

    #[test]
    fn jittered_delay_stays_within_25_percent_bound() {
        let base = 20;
        let jittered = jittered_delay_secs(base);
        assert!(jittered >= base);
        assert!(jittered <= base + (base / 4));
    }

    #[test]
    fn normalize_ssm_name_simple() {
        assert_eq!(normalize_ssm_name("/DB_URL"), "DB_URL");
    }

    #[test]
    fn normalize_ssm_path_adds_missing_leading_slash() {
        assert_eq!(normalize_ssm_path(Some("myapp/prod/")), "/myapp/prod/");
        assert_eq!(normalize_ssm_path(Some("/myapp/prod/")), "/myapp/prod/");
        assert_eq!(normalize_ssm_path(None), "/");
    }

    // ── mock-server tests ─────────────────────────────────────────────────────

    #[test]
    fn pull_ssm_parameters_empty() {
        let mut server = mockito::Server::new();
        let _m = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParametersByPath")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(r#"{"Parameters":[]}"#)
            .create();

        let result =
            pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("/myapp/"))
                .unwrap();
        assert!(result.is_empty());
    }

    #[test]
    fn pull_ssm_parameters_fetches_and_normalises() {
        let mut server = mockito::Server::new();
        let _m = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParametersByPath")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(params_response(&[("/myapp/db-password", "s3cr3t")], None))
            .create();

        let result =
            pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("/myapp/"))
                .unwrap();
        assert_eq!(result.len(), 1);
        assert_eq!(result[0].0, "MYAPP_DB_PASSWORD");
        assert_eq!(result[0].1, "s3cr3t");
    }

    #[test]
    fn pull_ssm_parameters_pagination() {
        let mut server = mockito::Server::new();
        let _page1 = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParametersByPath")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(params_response(&[("/app/key-a", "val-a")], Some("tok2")))
            .expect(1)
            .create();
        let _page2 = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParametersByPath")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(params_response(&[("/app/key-b", "val-b")], None))
            .expect(1)
            .create();

        let result =
            pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("/app/")).unwrap();
        assert_eq!(result.len(), 2);
        let keys: Vec<&str> = result.iter().map(|(k, _)| k.as_str()).collect();
        assert!(keys.contains(&"APP_KEY_A"));
        assert!(keys.contains(&"APP_KEY_B"));
    }

    #[test]
    fn pull_ssm_parameters_uses_absolute_path_and_ssm_sigv4_scope() {
        let mut server = mockito::Server::new();
        let _m = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParametersByPath")
            .match_header(
                "Authorization",
                mockito::Matcher::Regex(
                    r"Credential=AKID-TEST/\d{8}/us-east-1/ssm/aws4_request".to_string(),
                ),
            )
            .match_body(mockito::Matcher::Regex(r#""Path":"/app/""#.to_string()))
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(r#"{"Parameters":[]}"#)
            .create();

        let result =
            pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("app/")).unwrap();
        assert!(result.is_empty());
    }

    #[test]
    fn pull_ssm_parameters_403_returns_http_error() {
        let mut server = mockito::Server::new();
        let _m = server
            .mock("POST", "/")
            .with_status(403)
            .with_body(r#"{"__type":"AccessDeniedException","message":"Access denied"}"#)
            .create();

        let err = pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("/app/"))
            .unwrap_err();
        assert!(matches!(err, AwsError::Http { status: 403, .. }));
    }

    #[test]
    fn pull_ssm_parameters_429_exhausts_retries() {
        let mut server = mockito::Server::new();
        let _m = server
            .mock("POST", "/")
            .with_status(429)
            .with_header("Retry-After", "0")
            .with_body("Too Many Requests")
            .expect(MAX_RETRIES_429 as usize + 1)
            .create();

        let err = pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("/app/"))
            .unwrap_err();
        assert!(matches!(err, AwsError::Http { status: 429, .. }));
    }

    #[test]
    fn pull_ssm_malformed_json_returns_transport_error() {
        let mut server = mockito::Server::new();
        let _m = server
            .mock("POST", "/")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body("not json {{{{")
            .create();

        let err = pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("/app/"))
            .unwrap_err();
        assert!(matches!(err, AwsError::Transport(_)));
    }

    #[test]
    fn pull_ssm_missing_parameters_array_returns_transport_error() {
        let mut server = mockito::Server::new();
        let _m = server
            .mock("POST", "/")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(r#"{"Unexpected":[]}"#)
            .create();

        let err = pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("/app/"))
            .unwrap_err();
        assert!(
            matches!(err, AwsError::Transport(_)),
            "expected Transport for malformed SSM schema, got {err:?}"
        );
    }

    #[test]
    fn creds_refresh_failure_on_page2_propagates_error() {
        use std::sync::atomic::{AtomicUsize, Ordering};
        let call_count = AtomicUsize::new(0);

        let mut server = mockito::Server::new();
        let _page1 = server
            .mock("POST", "/")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(params_response(&[("/app/key", "val")], Some("tok2")))
            .create();

        let err = pull_ssm_parameters(
            &cfg(&server.url()),
            &|| {
                let n = call_count.fetch_add(1, Ordering::SeqCst);
                if n == 0 {
                    Ok(test_creds())
                } else {
                    Err(AwsError::Auth("creds expired".into()))
                }
            },
            Some("/app/"),
        )
        .unwrap_err();

        assert!(
            matches!(err, AwsError::Auth(_)),
            "expected Auth on page-2 creds failure, got {err:?}"
        );
    }

    #[test]
    fn x_amz_target_header_is_ssm_get_parameters_by_path() {
        let mut server = mockito::Server::new();
        let _m = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParametersByPath")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(r#"{"Parameters":[]}"#)
            .create();

        let result =
            pull_ssm_parameters(&cfg(&server.url()), &|| Ok(test_creds()), Some("/")).unwrap();
        assert!(result.is_empty());
    }

    // ── push_ssm_parameter tests ──────────────────────────────────────────────

    #[test]
    fn push_ssm_creates_when_not_found() {
        let mut server = mockito::Server::new();
        // GetParameter returns 400 with ParameterNotFound
        let _get = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParameter")
            .with_status(400)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(r#"{"__type":"ParameterNotFound","message":"Parameter not found"}"#)
            .create();
        // PutParameter succeeds (create, overwrite=false)
        let _put = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.PutParameter")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(r#"{"Version":1,"Tier":"Standard"}"#)
            .create();

        let outcome = push_ssm_parameter(
            &cfg(&server.url()),
            &|| Ok(test_creds()),
            "/myapp/db-password",
            "val",
            true,
        )
        .unwrap();
        assert_eq!(outcome, PushOutcome::Created);
    }

    #[test]
    fn push_ssm_updates_when_value_differs() {
        let mut server = mockito::Server::new();
        // GetParameter returns existing value
        let _get = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParameter")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(r#"{"Parameter":{"Name":"/myapp/db","Value":"old","Type":"SecureString"}}"#)
            .create();
        // PutParameter (update, overwrite=true)
        let _put = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.PutParameter")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(r#"{"Version":2,"Tier":"Standard"}"#)
            .create();

        let outcome = push_ssm_parameter(
            &cfg(&server.url()),
            &|| Ok(test_creds()),
            "/myapp/db",
            "new",
            true,
        )
        .unwrap();
        assert_eq!(outcome, PushOutcome::Updated);
    }

    #[test]
    fn push_ssm_unchanged_when_value_identical() {
        let mut server = mockito::Server::new();
        // GetParameter returns identical value
        let _get = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.GetParameter")
            .with_status(200)
            .with_header("Content-Type", "application/x-amz-json-1.1")
            .with_body(
                r#"{"Parameter":{"Name":"/myapp/key","Value":"same","Type":"SecureString"}}"#,
            )
            .create();
        let no_put = server
            .mock("POST", "/")
            .match_header("X-Amz-Target", "AmazonSSM.PutParameter")
            .expect(0)
            .create();

        let outcome = push_ssm_parameter(
            &cfg(&server.url()),
            &|| Ok(test_creds()),
            "/myapp/key",
            "same",
            true,
        )
        .unwrap();
        assert_eq!(outcome, PushOutcome::Unchanged);
        no_put.assert();
    }

    #[test]
    fn push_ssm_auth_error_propagates() {
        let server = mockito::Server::new();
        let err = push_ssm_parameter(
            &cfg(&server.url()),
            &|| Err(AwsError::Auth("no creds".into())),
            "/myapp/key",
            "val",
            true,
        )
        .unwrap_err();
        assert!(matches!(err, AwsError::Auth(_)));
    }
}