1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
//! `impl SearchAppState` — builder and lifecycle methods.
//!
//! Why: The impl block alone is 323 lines; splitting it into a sibling file
//! keeps both files under the 500-line cap while maintaining a logical
//! boundary between data definition and behaviour.
//! What: Builder-style `with_*` methods, embedder lifecycle helpers
//! (`install_embedder`, `current_embedder`, `install_embedder_error`, …),
//! chat-provider resolution, and the embedderd pid-slot forwarder.
//! Test: covered by the handler-level tests in `super::tests`.
use dashmap::DashMap;
use std::sync::Arc;
use std::time::Instant;
use tokio::sync::{broadcast, watch, OnceCell, RwLock};
use trusty_common::{ChatProvider, LocalModelConfig};
use crate::core::embed::Embedder;
use crate::core::registry::IndexRegistry;
use super::state::{DaemonEvent, SearchAppState};
impl SearchAppState {
/// Convenience constructor for callers (`daemon`, tests) that want default
/// reindex tracking without hand-rolling the `Arc<DashMap<…>>`. Defaults
/// to BM25-only mode (no embedder); use [`Self::with_embedder`] to enable
/// the vector lane.
pub fn new(registry: IndexRegistry) -> Self {
let openrouter_api_key = std::env::var("OPENROUTER_API_KEY").unwrap_or_default();
let (events_tx, _) = broadcast::channel::<DaemonEvent>(128);
// Default-constructed state has no embedder and the readiness watch
// stays at `false`. Tests exercising BM25-only paths use this default.
// Production daemon boot overrides via `with_embedder_ready_channel`
// so the background init task can flip readiness once the model loads.
let (ready_tx, ready_rx) = watch::channel(false);
// Issue #829: in-process graceful shutdown channel. `false` = running;
// `true` = stop requested. The receiver is polled by `run_daemon`.
let (shutdown_tx, _) = watch::channel(false);
Self {
registry,
cold_store: Arc::new(crate::service::lazy_loader::ColdIndexStore::new()),
reindex_progress: Arc::new(DashMap::new()),
last_reindex_aborted_at: Arc::new(DashMap::new()),
embedder: None,
embedder_slot: Arc::new(RwLock::new(None)),
embedder_ready: ready_rx,
embedder_ready_tx: Arc::new(ready_tx),
embedder_error: Arc::new(RwLock::new(None)),
daemon_port: None,
openrouter_enabled: !openrouter_api_key.is_empty(),
started_at: Instant::now(),
local_model: LocalModelConfig::default(),
openrouter_model: "anthropic/claude-haiku-4.5".to_string(),
openrouter_api_key,
chat_provider: Arc::new(OnceCell::new()),
events: Arc::new(events_tx),
// Default to an empty buffer — `build_router` callers that have
// installed the `LogBufferLayer` override this via
// `with_log_buffer`. Test states keep the empty default.
log_buffer: trusty_common::log_buffer::LogBuffer::new(
trusty_common::log_buffer::DEFAULT_LOG_CAPACITY,
),
disk_bytes: Arc::new(std::sync::atomic::AtomicU64::new(0)),
sys_metrics: Arc::new(tokio::sync::Mutex::new(
trusty_common::sys_metrics::SysMetrics::new(),
)),
embed_pool: Arc::new(RwLock::new(None)),
metrics: None,
embedderd_pid_slot: Arc::new(std::sync::atomic::AtomicU32::new(0)),
embedderd_pid_forwarder_handle: Arc::new(tokio::sync::Mutex::new(None)),
update_available: Arc::new(std::sync::Mutex::new(None)),
warmboot_failed_indexes: Arc::new(std::sync::atomic::AtomicUsize::new(0)),
warmboot_summary: Arc::new(std::sync::Mutex::new(
crate::service::server::state::WarmBootSummary::default(),
)),
prior_index_count: Arc::new(std::sync::atomic::AtomicUsize::new(0)),
last_rss_mb: Arc::new(std::sync::atomic::AtomicU64::new(0)),
last_cpu_pct_bits: Arc::new(std::sync::atomic::AtomicU32::new(0)),
embedder_stall_tracker: Arc::new(
crate::service::stall_tracker::EmbedderStallTracker::new(),
),
shutdown_tx: Arc::new(shutdown_tx),
// PR #1103: in-memory rate-limit gate replacing the sync disk read
// that `search_handler` previously did on every warm query.
last_queried_write_cache: Arc::new(DashMap::new()),
}
}
/// Builder-style: attach a pre-built embedder worker pool (issue #41
/// Phase 1). Production callers (`start.rs`) build the pool once the
/// background embedder-init task completes; tests can skip this.
#[must_use]
pub fn with_embed_pool(self, pool: Arc<crate::service::embed_pool::EmbedPool>) -> Self {
if let Ok(mut slot) = self.embed_pool.try_write() {
*slot = Some(pool);
}
self
}
/// Builder-style: attach the Prometheus recorder handle (issue #41
/// Phase 1). Calling this enables the `/metrics` route in `build_router`.
#[must_use]
pub fn with_metrics(mut self, metrics: crate::service::metrics::MetricsState) -> Self {
self.metrics = Some(metrics);
self
}
/// Install the pool after the deferred embedder init completes.
///
/// Why: the embedder pool must be built *after* `install_embedder` has
/// populated `embedder_slot` — otherwise the pool's workers would hold a
/// reference to the unloaded model. Calling this from the spawned init
/// task keeps the wiring atomic from the caller's perspective.
/// What: writes the pool into the shared `Arc<RwLock<…>>`. Handlers
/// observe the change on their next `embed_pool.read().await.clone()`.
/// Test: hand-checked via the integration `start_brings_pool_online`
/// scenario.
pub async fn install_embed_pool(&self, pool: Arc<crate::service::embed_pool::EmbedPool>) {
let mut slot = self.embed_pool.write().await;
*slot = Some(pool);
}
/// Snapshot the currently-installed embed pool (or `None` while the
/// embedder is still warming up).
pub async fn current_embed_pool(&self) -> Option<Arc<crate::service::embed_pool::EmbedPool>> {
self.embed_pool.read().await.clone()
}
/// Builder-style: attach the daemon's shared [`LogBuffer`] so the
/// `GET /logs/tail` endpoint serves the same lines the tracing subscriber
/// captures.
///
/// Why (issue #35): `start.rs` builds the buffer (via
/// `init_tracing_with_buffer`) before constructing the `SearchAppState`,
/// then hands a clone here so the HTTP handler and the tracing layer
/// observe the same ring.
/// What: replaces the empty default buffer with the supplied one.
/// Test: `logs_tail_returns_recent_lines`.
#[must_use]
pub fn with_log_buffer(mut self, buffer: trusty_common::log_buffer::LogBuffer) -> Self {
self.log_buffer = buffer;
self
}
/// Send a `DaemonEvent` to all connected SSE subscribers.
///
/// Why: Best-effort fan-out — `broadcast::Sender::send` only fails when
/// there are no live receivers, which is fine (no listeners == no work).
/// What: Drops the result, callers don't need to check anything.
/// Test: `emit_propagates_to_subscriber` subscribes then emits and asserts
/// the event arrives.
pub fn emit(&self, event: DaemonEvent) {
let _ = self.events.send(event);
}
/// Builder-style: install user-loaded `local_model` settings (e.g. from
/// `~/.trusty-search/config.toml`). Replaces the default Ollama address.
pub fn with_local_model(mut self, cfg: LocalModelConfig) -> Self {
self.local_model = cfg;
self
}
/// Builder-style: override the OpenRouter model id (defaults to
/// `anthropic/claude-haiku-4.5`).
pub fn with_openrouter_model(mut self, model: impl Into<String>) -> Self {
self.openrouter_model = model.into();
self
}
/// Builder-style: set the OpenRouter API key (loaded from config or env).
pub fn with_openrouter_api_key(mut self, api_key: impl Into<String>) -> Self {
let api_key_str = api_key.into();
self.openrouter_enabled = !api_key_str.is_empty();
self.openrouter_api_key = api_key_str;
self
}
/// Resolve the active chat provider, auto-detecting on first call.
///
/// Why: Provider selection depends on (a) filesystem-loaded config and (b)
/// a network probe to a local Ollama / LM Studio instance, so it must be
/// lazily initialised at runtime. Caching the choice in a `OnceCell` keeps
/// it stable across concurrent chat requests without re-probing.
/// What: On first use prefers an auto-detected local server when
/// `local_model.enabled`, otherwise falls back to OpenRouter when an API
/// key is configured. Returns `None` when neither is available so the
/// caller can emit a 503.
/// Test: Covered by `chat_provider_endpoint_returns_payload` in this crate.
pub async fn chat_provider(&self) -> Option<Arc<dyn ChatProvider>> {
self.chat_provider
.get_or_init(|| async {
if self.local_model.enabled {
if let Some(mut p) =
trusty_common::auto_detect_local_provider(&self.local_model.base_url).await
{
p.model = self.local_model.model.clone();
return Some(Arc::new(p) as Arc<dyn ChatProvider>);
}
}
if !self.openrouter_api_key.is_empty() {
return Some(Arc::new(trusty_common::OpenRouterProvider::new(
self.openrouter_api_key.clone(),
self.openrouter_model.clone(),
)) as Arc<dyn ChatProvider>);
}
None
})
.await
.clone()
}
/// Builder-style: record the actual port the daemon bound. Used by
/// the UI handler to inject `window.__DAEMON_PORT__`.
pub fn with_daemon_port(mut self, port: u16) -> Self {
self.daemon_port = Some(port);
self
}
/// Builder-style: attach a shared embedder so newly registered indexes
/// run the full hybrid pipeline. The embedder is shared across every
/// index registered after this point.
pub fn with_embedder(mut self, embedder: Arc<dyn Embedder>) -> Self {
self.embedder = Some(Arc::clone(&embedder));
// Tests that wire a pre-built embedder expect the daemon to behave as
// if init has already completed. Mirror that to the slot + watch so
// handlers using the deferred-init path see a ready embedder too.
if let Ok(mut slot) = self.embedder_slot.try_write() {
*slot = Some(embedder);
}
let _ = self.embedder_ready_tx.send(true);
self
}
/// Install the embedder produced by the background init task and flip the
/// readiness watch to `true`.
///
/// Why: the daemon starts serving HTTP before the embedder is loaded so
/// readiness probes from `trusty-search start` / `trusty-search index`
/// don't time out waiting for ONNX model load (15–30 s on first run).
/// The init task calls this when `FastEmbedder::new()` completes; any
/// in-flight handler observes the readiness flip via the watch channel.
/// What: writes the embedder into `embedder_slot` and broadcasts `true`
/// on `embedder_ready_tx` so all `*embedder_ready.borrow()` callers
/// transition out of the "initializing" branch.
/// Test: spawn a task that calls this after 1 s; assert `embedder_ready`
/// flips and subsequent `POST /indexes` calls succeed.
pub async fn install_embedder(&self, embedder: Arc<dyn Embedder>) {
let mut slot = self.embedder_slot.write().await;
*slot = Some(embedder);
drop(slot);
// Clear any previously recorded init error — the embedder is now ready.
{
let mut err = self.embedder_error.write().await;
*err = None;
}
let _ = self.embedder_ready_tx.send(true);
}
/// Record a fatal embedder-init error so `/health` can surface it and
/// `POST /indexes` can fail fast with a useful message instead of hanging
/// on "initializing" forever.
///
/// Why (issue #121): the background init task may abort because (a) ORT
/// session init returned `Err` or (b) the init-timeout fired. In either
/// case the embedder slot stays empty AND `embedder_ready` stays `false`;
/// previously this was indistinguishable from "still loading", so callers
/// retried forever. Capturing the error lets handlers and `/health`
/// distinguish "transient" from "broken".
/// What: writes the error message into `embedder_error`. Does NOT flip
/// `embedder_ready` — `is_embedder_ready()` still returns `false`, so
/// hybrid-pipeline code paths keep returning 503 rather than producing a
/// BM25-only index by accident.
/// Test: `install_embedder_error_surfaces_in_health` verifies the message
/// is visible via `/health`.
pub async fn install_embedder_error(&self, message: impl Into<String>) {
let msg = message.into();
tracing::error!("embedder init failed: {msg}");
let mut err = self.embedder_error.write().await;
*err = Some(msg);
}
/// Snapshot the current embedder-init error, if any. `None` means the
/// background init task is still running or completed successfully.
pub fn current_embedder_error(&self) -> Option<String> {
self.embedder_error.try_read().ok().and_then(|g| g.clone())
}
/// Snapshot the currently-installed embedder (post-init) or `None` when
/// the daemon is still warming up. Handlers prefer this over
/// `self.embedder` so the deferred-init flow works transparently.
pub async fn current_embedder(&self) -> Option<Arc<dyn Embedder>> {
let slot = self.embedder_slot.read().await;
slot.clone()
}
/// Non-blocking snapshot of the currently-installed embedder.
///
/// Why (issue #1006): `/health` must never `.await` the embedder `RwLock`
/// because a concurrent write-lock (e.g. `install_embedder` during init or
/// hot-swap) would block the health handler until the write completes —
/// potentially 30 s during a CoreML stall. Using `try_read()` returns
/// immediately with `None` when the lock is contended, which is safe for
/// the health endpoint because we already have `is_embedder_ready()` as the
/// authoritative readiness signal.
///
/// What: calls `try_read()` on the embedder slot; returns `Some(embedder)`
/// when the lock is uncontended and the slot is populated, `None` otherwise.
/// Callers that receive `None` should fall back to the last-known status
/// (e.g. from `is_embedder_ready()`) rather than awaiting.
///
/// Test: `health_non_blocking_when_embedder_slot_write_locked` — holds a
/// write lock on `embedder_slot` and asserts `try_current_embedder()`
/// returns `None` immediately (no deadlock/await).
pub fn try_current_embedder(&self) -> Option<Arc<dyn Embedder>> {
self.embedder_slot
.try_read()
.ok()
.and_then(|guard| guard.clone())
}
/// Cheap, non-blocking readiness check. Returns `true` once the
/// background embedder-init task has flipped the watch channel.
pub fn is_embedder_ready(&self) -> bool {
*self.embedder_ready.borrow()
}
/// Install the live `child_pid_slot` Arc from the `EmbedderSupervisor`
/// after the sidecar spawns (issue #282).
///
/// Why: `build_embedder` in `start.rs` obtains the pid-slot Arc from
/// `spawn_stdio` and calls this method from the background init task.
/// The supervisor loop updates the same Arc on every respawn and clears
/// it to 0 on final exit, so the daemon always reads the current PID
/// without holding any lock.
///
/// Issue #829 (pid-slot task leak): each call previously spawned a NEW
/// forwarder task without cancelling the previous one. On idle-shutdown
/// cycles the old slot's PID never resets to 0 (the supervisor moves on
/// to a fresh slot), so the old forwarder runs forever, leaking one task
/// per embedder lifecycle. The fix: store the previous forwarder's
/// `AbortHandle` in an `Arc<Mutex<Option<AbortHandle>>>` field and abort
/// it before spawning the new task.
///
/// What: atomically copies the PID from the new slot into the field's
/// existing Arc, then spawns exactly one forwarder that copies future
/// PID updates. Any previous forwarder is aborted first.
/// Test: `pid_slot_forwarder_does_not_leak_tasks` in `tests_state.rs`.
pub async fn install_embedderd_pid_slot(&self, slot: Arc<std::sync::atomic::AtomicU32>) {
use std::sync::atomic::Ordering;
let initial_pid = slot.load(Ordering::Acquire);
self.embedderd_pid_slot
.store(initial_pid, Ordering::Release);
// Issue #829: cancel any previously-running forwarder before spawning
// a new one. We keep the AbortHandle in a Mutex stored inside the same
// Arc so callers holding a clone of `SearchAppState` share the handle.
// On the first call the Mutex is empty and no abort is needed.
let src = Arc::clone(&slot);
let dst = Arc::clone(&self.embedderd_pid_slot);
let handle = Arc::clone(&self.embedderd_pid_forwarder_handle);
let join = tokio::spawn(async move {
loop {
let pid = src.load(Ordering::Acquire);
dst.store(pid, Ordering::Release);
if pid == 0 {
// Sidecar exited for the last time; stop forwarding.
break;
}
tokio::time::sleep(std::time::Duration::from_millis(500)).await;
}
});
// Abort the OLD forwarder after the new one is already running so
// there is never a gap in forwarding.
let mut guard = handle.lock().await;
if let Some(old) = guard.take() {
old.abort();
}
*guard = Some(join.abort_handle());
}
/// Current OS PID of the embedderd sidecar, or `None` if no sidecar is
/// running (in-process mode, sidecar not yet spawned, or sidecar exited).
///
/// Why: the health handler uses this to sample the sidecar RSS; `0` is
/// the "no process" sentinel.
/// What: loads `embedderd_pid_slot` with `Relaxed` ordering — a slightly
/// stale PID is fine (the caller will just get `None` from sysinfo if the
/// process already exited).
/// Test: see `health_includes_embedderd_rss_field`.
pub fn current_embedderd_pid(&self) -> Option<u32> {
use std::sync::atomic::Ordering;
let pid = self.embedderd_pid_slot.load(Ordering::Relaxed);
if pid == 0 {
None
} else {
Some(pid)
}
}
}