trusty-mpm 1.8.2

trusty-mpm: unified multi-agent orchestration platform (core, daemon, CLI, TUI, Telegram)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
//! Tests for the worktree ledger, its fold, the recorded creation and the
//! backfill (#8994).

use std::cell::Cell;
use std::io::Write as _;
use std::path::{Path, PathBuf};

use chrono::{TimeZone, Utc};

use super::backfill::backfill_checkouts;
use super::fold::{GIB, fold};
use super::reconcile::{ReconcileReport, reconcile_removed};
use super::record::{CreationIntent, RecordedCreateError, create_recorded, measure_live};
use super::{EventKind, LedgerEvent, Origin, WorktreeLedger, ledger_key};
use crate::session_manager::worktree_git_fixture::GitWorktreeFixture;

fn ev(secs: i64, path: &str, kind: EventKind) -> LedgerEvent {
    LedgerEvent {
        ts: Utc.timestamp_opt(1_800_000_000 + secs, 0).unwrap(),
        path: PathBuf::from(path),
        kind,
    }
}

fn created(repo: &str) -> EventKind {
    EventKind::Created {
        repo: PathBuf::from(repo),
        branch: Some("session/x".into()),
        origin: Origin::TmDaemon,
        session: Some("sid".into()),
    }
}

fn scratch_ledger() -> (tempfile::TempDir, WorktreeLedger) {
    let dir = tempfile::tempdir().expect("tempdir");
    let ledger = WorktreeLedger::under_home(dir.path());
    (dir, ledger)
}

fn intent(repo: &Path) -> CreationIntent<'_> {
    CreationIntent {
        repo,
        branch: Some("session/t".into()),
        origin: Origin::TmCli,
        session: Some("sid".into()),
    }
}

#[test]
fn append_then_read_round_trips_every_event_kind() {
    let (_dir, ledger) = scratch_ledger();
    let events = vec![
        ev(0, "/w/a", created("/r")),
        ev(
            1,
            "/w/b",
            EventKind::Observed {
                repo: PathBuf::from("/r"),
                branch: None,
                origin: Origin::AgentIsolation,
            },
        ),
        ev(2, "/w/a", EventKind::Measured { bytes: 42 }),
        ev(3, "/w/a", EventKind::Removed),
    ];
    for e in &events {
        ledger.append(e).expect("append");
    }
    let read = ledger.read().expect("read");
    assert!(read.present);
    assert_eq!(read.malformed, 0);
    assert_eq!(read.events, events);
    let text = std::fs::read_to_string(ledger.path()).expect("raw");
    assert!(
        text.lines()
            .next()
            .unwrap()
            .contains(r#""event":"created""#),
        "{text}"
    );
}

#[test]
fn read_of_an_absent_ledger_is_empty_not_an_error() {
    let (_dir, ledger) = scratch_ledger();
    let read = ledger.read().expect("absent is not an error");
    assert!(!read.present);
    assert!(read.events.is_empty());
}

#[test]
fn read_counts_a_torn_line_without_losing_the_rest() {
    let (_dir, ledger) = scratch_ledger();
    ledger
        .append(&ev(0, "/w/a", created("/r")))
        .expect("append");
    let mut text = std::fs::read_to_string(ledger.path()).unwrap();
    text.push_str("{\"ts\":\"2027-01-15T08:00:00Z\",\"pa\n");
    std::fs::write(ledger.path(), text).unwrap();
    ledger
        .append(&ev(1, "/w/b", created("/r")))
        .expect("append");
    let read = ledger.read().expect("read");
    assert_eq!(read.malformed, 1);
    assert_eq!(read.events.len(), 2);
}

/// Append `bytes` to the ledger file raw, with no trailing newline — the
/// state a short write (ENOSPC) leaves behind.
fn write_torn_fragment(ledger: &WorktreeLedger, bytes: &[u8]) {
    let mut file = std::fs::OpenOptions::new()
        .append(true)
        .open(ledger.path())
        .expect("open ledger");
    file.write_all(bytes).expect("write fragment");
}

#[test]
fn an_append_after_a_torn_line_with_no_newline_keeps_the_new_event() {
    let (_dir, ledger) = scratch_ledger();
    ledger
        .append(&ev(0, "/w/a", created("/r")))
        .expect("append");
    write_torn_fragment(&ledger, br#"{"ts":"2027-01-15T08:00:00Z","pa"#);
    ledger
        .append(&ev(1, "/w/b", created("/r")))
        .expect("append");
    let read = ledger.read().expect("read");
    assert_eq!(read.malformed, 1, "the fragment is counted: {read:?}");
    assert_eq!(
        read.events.len(),
        2,
        "the append after the fragment survives: {read:?}"
    );
    assert!(fold(&read.events).live.contains_key(Path::new("/w/b")));
}

#[test]
fn a_torn_line_cut_inside_a_multibyte_path_leaves_the_ledger_readable() {
    let (_dir, ledger) = scratch_ledger();
    ledger
        .append(&ev(0, "/w/a", created("/r")))
        .expect("append");
    let whole = serde_json::to_vec(&ev(1, "/w/日本/é", created("/r"))).unwrap();
    let start = whole
        .windows(3)
        .position(|w| w == "日".as_bytes())
        .expect("path bytes");
    // Cut one byte into the three-byte "日", so the file is no longer UTF-8.
    write_torn_fragment(&ledger, &whole[..start + 1]);
    assert!(
        std::str::from_utf8(&std::fs::read(ledger.path()).unwrap()).is_err(),
        "the fixture must leave invalid UTF-8 on disk"
    );
    ledger
        .append(&ev(2, "/w/c", created("/r")))
        .expect("append");
    let read = ledger
        .read()
        .expect("a torn multibyte line must not fail the read");
    assert_eq!(read.malformed, 1, "{read:?}");
    let paths: Vec<_> = read.events.iter().map(|e| e.path.clone()).collect();
    assert_eq!(paths, vec![PathBuf::from("/w/a"), PathBuf::from("/w/c")]);
    assert!(fold(&read.events).live.contains_key(Path::new("/w/c")));
}

// ── criterion 2: the fold ────────────────────────────────────────────────

#[test]
fn fold_created_measured_removed_leaves_nothing_live() {
    let state = fold(&[
        ev(0, "/w/a", created("/r")),
        ev(1, "/w/a", EventKind::Measured { bytes: 10 }),
        ev(2, "/w/a", EventKind::Removed),
    ]);
    assert!(state.live.is_empty(), "{state:?}");
}

#[test]
fn fold_keeps_one_live_entry_with_its_last_measured_size() {
    let state = fold(&[
        ev(0, "/w/a", created("/r")),
        ev(1, "/w/a", EventKind::Measured { bytes: 10 }),
        ev(2, "/w/a", EventKind::Measured { bytes: 30 }),
        // A second `created` for a live path keeps the first attribution.
        ev(3, "/w/a", created("/other")),
        // A measurement of a path that is not live is ignored.
        ev(4, "/w/ghost", EventKind::Measured { bytes: 99 }),
    ]);
    assert_eq!(state.live.len(), 1, "{state:?}");
    let wt = &state.live[Path::new("/w/a")];
    assert_eq!(wt.bytes, Some(30));
    assert_eq!(wt.repo, PathBuf::from("/r"));
    assert_eq!(
        wt.measured_at,
        Some(Utc.timestamp_opt(1_800_000_002, 0).unwrap())
    );
}

#[test]
fn fold_replay_of_the_same_file_is_identical() {
    let (_dir, ledger) = scratch_ledger();
    for e in [
        ev(0, "/w/b", created("/r2")),
        ev(1, "/w/a", created("/r1")),
        ev(2, "/w/a", EventKind::Measured { bytes: 7 }),
        ev(3, "/w/c", created("/r1")),
        ev(4, "/w/c", EventKind::Removed),
    ] {
        ledger.append(&e).unwrap();
    }
    let first = fold(&ledger.read().unwrap().events);
    let second = fold(&ledger.read().unwrap().events);
    assert_eq!(first, second);
    assert_eq!(
        first.live.keys().cloned().collect::<Vec<_>>(),
        vec![PathBuf::from("/w/a"), PathBuf::from("/w/b")]
    );
}

#[test]
fn summary_groups_by_repo_with_count_and_gib() {
    let gib = GIB as u64;
    let state = fold(&[
        ev(0, "/w/a", created("/r1")),
        ev(1, "/w/b", created("/r1")),
        ev(2, "/w/c", created("/r2")),
        ev(3, "/w/a", EventKind::Measured { bytes: gib }),
        ev(4, "/w/b", EventKind::Measured { bytes: gib / 2 }),
    ]);
    let summary = state.by_project();
    assert_eq!(summary.len(), 2);
    assert_eq!(
        (summary[0].count, summary[0].gib, summary[0].unmeasured),
        (2, 1.5, 0)
    );
    assert_eq!(
        (summary[1].count, summary[1].gib, summary[1].unmeasured),
        (1, 0.0, 1)
    );
}

// ── criterion 1 (unit level): the append error is returned ───────────────

#[test]
fn create_recorded_refuses_before_creating_when_the_ledger_is_unwritable() {
    let dir = tempfile::tempdir().unwrap();
    // The ledger path is a DIRECTORY, so the append open fails for any user.
    let ledger_path = dir.path().join("worktrees.jsonl");
    std::fs::create_dir_all(&ledger_path).unwrap();
    let ledger = WorktreeLedger::at(&ledger_path);
    let ran = Cell::new(false);
    let result = create_recorded(&ledger, intent(dir.path()), || {
        ran.set(true);
        Ok(dir.path().join("tree"))
    });
    assert!(
        matches!(result, Err(RecordedCreateError::Ledger(_))),
        "an unwritable ledger must refuse the creation: {result:?}"
    );
    assert!(
        !ran.get(),
        "nothing may be created when the ledger cannot record it"
    );
}

#[test]
fn create_recorded_appends_one_created_event() {
    let (dir, ledger) = scratch_ledger();
    let tree = dir.path().join("tree");
    let path = create_recorded(&ledger, intent(dir.path()), || {
        std::fs::create_dir_all(&tree).map_err(|e| e.to_string())?;
        Ok(tree.clone())
    })
    .expect("recorded");
    assert_eq!(path, tree);
    let state = fold(&ledger.read().unwrap().events);
    let wt = &state.live[&ledger_key(&tree)];
    assert_eq!(wt.origin, Origin::TmCli);
    assert_eq!(wt.session.as_deref(), Some("sid"));
    assert_eq!(state.live.len(), 1);
}

#[test]
fn create_recorded_appends_nothing_when_creation_fails() {
    let (dir, ledger) = scratch_ledger();
    let result = create_recorded(&ledger, intent(dir.path()), || Err("boom".to_string()));
    assert!(matches!(result, Err(RecordedCreateError::Create(ref m)) if m == "boom"));
    assert!(ledger.read().unwrap().events.is_empty());
}

#[test]
fn measure_live_records_the_size_of_each_present_tree() {
    let (dir, ledger) = scratch_ledger();
    let tree = dir.path().join("tree");
    std::fs::create_dir_all(&tree).unwrap();
    std::fs::write(tree.join("f"), vec![7u8; 64 * 1024]).unwrap();
    ledger
        .append(&LedgerEvent::now(ledger_key(&tree), created("/r")))
        .unwrap();
    ledger
        .append(&LedgerEvent::now(dir.path().join("gone"), created("/r")))
        .unwrap();
    let state = fold(&ledger.read().unwrap().events);
    let report = measure_live(&ledger, &state).expect("measure");
    assert_eq!((report.measured, report.missing), (1, 1));
    let after = fold(&ledger.read().unwrap().events);
    let bytes = after.live[&ledger_key(&tree)].bytes.expect("measured");
    assert!(bytes >= 64 * 1024, "allocated bytes {bytes}");
    assert_eq!(after.live[&dir.path().join("gone")].bytes, None);
}

// ── criterion 3: the backfill ────────────────────────────────────────────

#[test]
fn backfill_twice_appends_no_duplicate_events() {
    let fixture = GitWorktreeFixture::new();
    let a = fixture.add_worktree("one");
    let b = fixture.add_worktree("two");
    let (_dir, ledger) = scratch_ledger();
    let checkouts = vec![fixture.repo.clone(), fixture.repo.clone()];

    let first = backfill_checkouts(&ledger, &checkouts).expect("first pass");
    assert_eq!((first.created, first.observed), (2, 0), "{first:?}");
    let after_first = ledger.read().unwrap().events.len();

    let second = backfill_checkouts(&ledger, &checkouts).expect("second pass");
    assert_eq!((second.created, second.observed), (0, 0), "{second:?}");
    let events = ledger.read().unwrap().events;
    assert_eq!(
        events.len(),
        after_first,
        "a second pass must append nothing"
    );
    for tree in [&a, &b] {
        let n = events
            .iter()
            .filter(|e| e.path == ledger_key(tree) && matches!(e.kind, EventKind::Created { .. }))
            .count();
        assert_eq!(n, 1, "exactly one created event for {}", tree.display());
    }
    let state = fold(&events);
    assert_eq!(state.live[&ledger_key(&a)].repo, ledger_key(&fixture.repo));
}

#[test]
fn backfill_observes_agent_isolation_trees() {
    let fixture = GitWorktreeFixture::new();
    let agent = fixture.add_worktree_at(&fixture.repo.join(".claude").join("worktrees"), "agent-x");
    let (_dir, ledger) = scratch_ledger();
    let report = backfill_checkouts(&ledger, std::slice::from_ref(&fixture.repo)).unwrap();
    assert_eq!((report.created, report.observed), (0, 1), "{report:?}");
    let state = fold(&ledger.read().unwrap().events);
    let wt = &state.live[&ledger_key(&agent)];
    assert!(wt.observed_only);
    assert_eq!(wt.origin, Origin::AgentIsolation);
}

#[test]
fn backfill_skips_a_tree_provisioning_already_recorded() {
    let fixture = GitWorktreeFixture::new();
    let (_dir, ledger) = scratch_ledger();
    let tree = create_recorded(&ledger, intent(&fixture.repo), || {
        Ok(fixture.add_worktree("provisioned"))
    })
    .expect("recorded");
    let report = backfill_checkouts(&ledger, std::slice::from_ref(&fixture.repo)).unwrap();
    assert_eq!(
        (report.created, report.already_recorded),
        (0, 1),
        "{report:?}"
    );
    assert_eq!(
        fold(&ledger.read().unwrap().events).live[&ledger_key(&tree)].origin,
        Origin::TmCli
    );
}

#[test]
fn backfill_reports_a_checkout_git_cannot_list() {
    let dir = tempfile::tempdir().unwrap();
    let (_l, ledger) = scratch_ledger();
    let report = backfill_checkouts(&ledger, &[dir.path().to_path_buf()]).unwrap();
    assert_eq!(report.unanswered, vec![dir.path().to_path_buf()]);
    assert!(
        !ledger.read().unwrap().present,
        "nothing to append, so no file"
    );
}

// ── #8994 finding 1: the reconcile never writes `removed` on doubt ───────

/// Record `tree` as created for `repo`, keyed as provisioning keys it.
fn record_tree(ledger: &WorktreeLedger, tree: &Path, repo: &Path) {
    ledger
        .append(&LedgerEvent::now(
            ledger_key(tree),
            EventKind::Created {
                repo: ledger_key(repo),
                branch: None,
                origin: Origin::TmDaemon,
                session: None,
            },
        ))
        .unwrap();
}

fn removed_events(ledger: &WorktreeLedger) -> usize {
    ledger
        .read()
        .unwrap()
        .events
        .iter()
        .filter(|e| e.kind == EventKind::Removed)
        .count()
}

#[test]
fn reconcile_writes_nothing_for_a_gone_tree_git_still_lists() {
    let fixture = GitWorktreeFixture::new();
    let tree = fixture.add_worktree("deleted-not-pruned");
    let (_dir, ledger) = scratch_ledger();
    record_tree(&ledger, &tree, &fixture.repo);
    // Deleted from disk, never `git worktree remove`d: git lists it prunable.
    std::fs::remove_dir_all(&tree).unwrap();
    let report = reconcile_removed(&ledger, &fold(&ledger.read().unwrap().events)).unwrap();
    assert_eq!((report.removed, report.still_listed), (0, 1), "{report:?}");
    assert_eq!(removed_events(&ledger), 0);
    assert_eq!(fold(&ledger.read().unwrap().events).live.len(), 1);
}

#[test]
fn reconcile_writes_nothing_when_the_repo_cannot_be_listed() {
    let fixture = GitWorktreeFixture::new();
    let scratch = tempfile::tempdir().unwrap();
    let not_a_repo = scratch.path().join("plain");
    std::fs::create_dir_all(&not_a_repo).unwrap();
    // A plain directory inside an unrelated repository: git walks up and
    // answers for the enclosing repository, which must not count.
    let nested = fixture.repo.join("nested-plain");
    std::fs::create_dir_all(&nested).unwrap();
    let cases = [
        (
            "repository directory gone",
            scratch.path().join("gone-repo"),
        ),
        ("not a git repository", not_a_repo),
        ("inside an unrelated repository", nested),
    ];
    for (label, repo) in cases {
        let (_dir, ledger) = scratch_ledger();
        record_tree(&ledger, &scratch.path().join("gone-tree"), &repo);
        let report = reconcile_removed(&ledger, &fold(&ledger.read().unwrap().events)).unwrap();
        assert_eq!(
            (report.removed, report.unknown, report.unlistable.len()),
            (0, 1, 1),
            "{label}: {report:?}"
        );
        assert_eq!(removed_events(&ledger), 0, "{label}");
    }
}

#[test]
fn reconcile_writes_nothing_while_the_directory_exists() {
    let fixture = GitWorktreeFixture::new();
    // A directory git does not list at all: only its presence keeps it live.
    let tree = fixture.repo.join("not-a-worktree");
    std::fs::create_dir_all(&tree).unwrap();
    let (_dir, ledger) = scratch_ledger();
    record_tree(&ledger, &tree, &fixture.repo);
    let report = reconcile_removed(&ledger, &fold(&ledger.read().unwrap().events)).unwrap();
    assert_eq!(report, ReconcileReport::default());
    assert_eq!(removed_events(&ledger), 0);
}