trusty-common 0.52.3

//! Coverage for the `control_bus` event types and the types-only boundary.
//!
//! Why: The types moved here from `trusty-agents-common` (#6846) are a wire
//!      contract between separate processes, so their serde shapes need
//!      assertions that live beside the definitions rather than in the crate
//!      they left. The boundary itself also needs a gate: the owner ruling that
//!      put the bus in trusty-console only holds as long as nothing grows a
//!      channel back into this module.
//! What: Serde round-trips for each type and tag shape, the `Filter` matrix,
//!       and `control_bus_declares_no_transport`, which reads this module's own
//!       sources at compile time and fails on any transport spelling.
//! Test: this file.

use super::*;
use serde_json::json;

fn sample_lifecycle() -> LifecycleEvent {
    LifecycleEvent::PmThinking {
        session_id: "s1".into(),
        text: "considering options".into(),
    }
}

fn envelope(payload: HarnessPayload, session: Option<&str>) -> HarnessEvent {
    HarnessEvent {
        source: HarnessSource::Agents,
        session: session.map(str::to_string),
        seq: 0,
        at: chrono::Utc::now(),
        payload,
        id: EventId::new(),
        parent_id: None,
    }
}

// ---- HarnessSource ----

#[test]
fn harness_source_round_trips() {
    for (src, tag) in [
        (HarnessSource::Agents, "\"agents\""),
        (HarnessSource::Mpm, "\"mpm\""),
        (HarnessSource::Code, "\"code\""),
    ] {
        let s = serde_json::to_string(&src).expect("serialize source");
        assert_eq!(s, tag);
        let back: HarnessSource = serde_json::from_str(&s).expect("deserialize source");
        assert_eq!(back, src);
    }
}

// ---- LifecycleEvent ----

#[test]
fn lifecycle_event_serializes_with_type_tag() {
    let s = serde_json::to_string(&sample_lifecycle()).expect("serialize");
    assert!(s.contains("\"type\":\"pm_thinking\""), "{s}");
    assert!(s.contains("\"session_id\":\"s1\""), "{s}");
}

#[test]
fn lifecycle_session_id_returns_correct_field() {
    let ev = LifecycleEvent::AgentMessage {
        session_id: "abc".into(),
        agent: "python".into(),
        text: "hi".into(),
    };
    assert_eq!(ev.session_id(), Some("abc"));
}

#[test]
fn lifecycle_recap_round_trips() {
    let ev = LifecycleEvent::RecapGenerated {
        session_id: "s9".into(),
        summary: "did a thing".into(),
        table_rows: vec![("step".into(), "ok".into())],
    };
    let s = serde_json::to_string(&ev).expect("serialize recap");
    let back: LifecycleEvent = serde_json::from_str(&s).expect("deserialize recap");
    assert_eq!(back, ev);
}

// ---- HarnessPayload tag shapes ----

#[test]
fn payload_lifecycle_round_trips() {
    let p = HarnessPayload::Lifecycle(sample_lifecycle());
    let s = serde_json::to_string(&p).expect("serialize");
    assert!(s.contains("\"domain\":\"lifecycle\""), "{s}");
    assert!(s.contains("\"event\":{"), "{s}");
    assert!(s.contains("\"type\":\"pm_thinking\""), "{s}");
    let back: HarnessPayload = serde_json::from_str(&s).expect("deserialize");
    assert_eq!(back, p);
}

#[test]
fn payload_hook_round_trips() {
    let p = HarnessPayload::Hook {
        kind: "pre_tool_use".into(),
        data: json!({"tool": "bash", "ok": true}),
    };
    let s = serde_json::to_string(&p).expect("serialize");
    assert!(s.contains("\"domain\":\"hook\""), "{s}");
    assert!(s.contains("\"kind\":\"pre_tool_use\""), "{s}");
    let back: HarnessPayload = serde_json::from_str(&s).expect("deserialize");
    assert_eq!(back, p);
}

#[test]
fn payload_ping_round_trips() {
    let p = HarnessPayload::Ping;
    let s = serde_json::to_string(&p).expect("serialize");
    assert_eq!(s, "{\"domain\":\"ping\"}");
    let back: HarnessPayload = serde_json::from_str(&s).expect("deserialize");
    assert_eq!(back, p);
}

#[test]
fn payload_domain_matches_serde_tag() {
    assert_eq!(
        HarnessPayload::Lifecycle(sample_lifecycle()).domain(),
        "lifecycle"
    );
    assert_eq!(
        HarnessPayload::Hook {
            kind: "x".into(),
            data: json!(null)
        }
        .domain(),
        "hook"
    );
    assert_eq!(HarnessPayload::Ping.domain(), "ping");
    assert_eq!(
        HarnessPayload::Action(sample_action_event()).domain(),
        "action"
    );
}

/// A `HarnessEvent` serialized before issue #6847 added `HarnessPayload::Action`
/// still deserializes — proving the new variant does not disturb matching on
/// the existing `domain` tags.
///
/// Why: §3.3's second versioning rule ("a new `kind` or `phase` variant is
///      added without renumbering") only holds if adding `Action` alongside
///      `Lifecycle`/`Hook`/`Ping` is itself invisible to an old-shaped
///      payload — a consumer running today's code must still read yesterday's
///      log.
/// What: A hand-written JSON literal in the exact pre-#6847 `Hook` shape (no
///       `Action` anywhere in the document), deserialized against the current
///       `HarnessPayload` enum.
/// Test: this test itself.
#[test]
fn harness_payload_pre_action_payload_still_deserializes() {
    let json = r#"{"domain":"hook","event":{"kind":"pre_tool_use","data":{"tool":"bash"}}}"#;
    let back: HarnessPayload = serde_json::from_str(json).expect("legacy hook payload parses");
    assert_eq!(
        back,
        HarnessPayload::Hook {
            kind: "pre_tool_use".into(),
            data: json!({"tool": "bash"}),
        }
    );
}

/// A `HarnessPayload::Action` round-trips with the same `{"domain":"action",
/// "event":{...}}` shape every other domain uses.
#[test]
fn harness_payload_action_round_trips() {
    let p = HarnessPayload::Action(sample_action_event());
    let s = serde_json::to_string(&p).expect("serialize");
    assert!(s.contains("\"domain\":\"action\""), "{s}");
    assert!(s.contains("\"kind\":\"session\""), "{s}");
    let back: HarnessPayload = serde_json::from_str(&s).expect("deserialize");
    assert_eq!(back, p);
}

// ---- ActionEvent taxonomy (DOC-73 §3.2) ----

fn sample_meta() -> ActionMeta {
    ActionMeta {
        id: EventId::new(),
        at: chrono::Utc::now(),
        source: HarnessSource::Mpm,
        session: Some("s1".into()),
        parent_id: None,
        actor: Actor::Agent {
            name: "rust-engineer".into(),
            agent_id: "agent-1".into(),
        },
        objects: vec![ObjectRef {
            object_type: ObjectType::Session,
            id: "s1".into(),
            label: "session s1".into(),
        }],
        schema_version: 1,
    }
}

fn sample_action_event() -> ActionEvent {
    ActionEvent::Session {
        meta: sample_meta(),
        phase: SessionPhase::Started,
    }
}

/// Every one of the six `ActionEvent` kinds round-trips through serde with
/// its fields intact.
#[test]
fn action_event_round_trips_all_six_kinds() {
    let meta = sample_meta();
    let events = vec![
        ActionEvent::Workflow {
            meta: meta.clone(),
            phase: WorkflowPhase::Spawn,
            object: ObjectRef {
                object_type: ObjectType::Task,
                id: "t1".into(),
                label: "build the thing".into(),
            },
        },
        ActionEvent::Agent {
            meta: meta.clone(),
            phase: AgentPhase::Spawned,
            agent_id: "agent-1".into(),
        },
        ActionEvent::File {
            meta: meta.clone(),
            phase: FilePhase::Written,
            path: PathRef {
                path: "src/lib.rs".into(),
                diff_ref: Some("diff-1".into()),
            },
        },
        ActionEvent::Tool {
            meta: meta.clone(),
            phase: CallPhase::Finished,
            tool: "bash".into(),
            call_id: "call-1".into(),
        },
        ActionEvent::Session {
            meta: meta.clone(),
            phase: SessionPhase::Done,
        },
        ActionEvent::Inference {
            meta: meta.clone(),
            phase: CallPhase::Started,
            model: "claude-sonnet".into(),
        },
    ];

    for event in events {
        let s = serde_json::to_string(&event).expect("serialize");
        let back: ActionEvent = serde_json::from_str(&s).expect("deserialize");
        assert_eq!(back, event, "round trip for {}: {s}", event.kind());
        assert_eq!(back.meta(), event.meta());
    }
}

/// The wire shape tags each variant with `kind` and flattens `ActionMeta`'s
/// fields alongside the variant-specific ones, rather than nesting them.
#[test]
fn action_event_wire_shape_matches_kind_tag() {
    let event = ActionEvent::Tool {
        meta: sample_meta(),
        phase: CallPhase::Started,
        tool: "bash".into(),
        call_id: "call-1".into(),
    };
    let s = serde_json::to_string(&event).expect("serialize");
    assert!(s.contains("\"kind\":\"tool\""), "{s}");
    assert!(s.contains("\"tool\":\"bash\""), "{s}");
    assert!(s.contains("\"call_id\":\"call-1\""), "{s}");
    assert!(
        s.contains("\"actor\":{\"type\":\"agent\""),
        "meta fields are flattened alongside the variant fields: {s}"
    );
}

#[test]
fn action_event_kind_matches_serde_tag() {
    let meta = sample_meta();
    let cases: Vec<(ActionEvent, &str)> = vec![
        (
            ActionEvent::Workflow {
                meta: meta.clone(),
                phase: WorkflowPhase::Start,
                object: ObjectRef {
                    object_type: ObjectType::Task,
                    id: "t1".into(),
                    label: "l".into(),
                },
            },
            "workflow",
        ),
        (
            ActionEvent::Agent {
                meta: meta.clone(),
                phase: AgentPhase::Done,
                agent_id: "a1".into(),
            },
            "agent",
        ),
        (
            ActionEvent::File {
                meta: meta.clone(),
                phase: FilePhase::Created,
                path: PathRef {
                    path: "x".into(),
                    diff_ref: None,
                },
            },
            "file",
        ),
        (
            ActionEvent::Tool {
                meta: meta.clone(),
                phase: CallPhase::Errored,
                tool: "t".into(),
                call_id: "c1".into(),
            },
            "tool",
        ),
        (
            ActionEvent::Session {
                meta: meta.clone(),
                phase: SessionPhase::Cancelled,
            },
            "session",
        ),
        (
            ActionEvent::Inference {
                meta: meta.clone(),
                phase: CallPhase::Finished,
                model: "m".into(),
            },
            "inference",
        ),
    ];

    for (event, expected) in cases {
        let s = serde_json::to_string(&event).expect("serialize");
        assert_eq!(event.kind(), expected);
        assert!(s.contains(&format!("\"kind\":\"{expected}\"")), "{s}");
    }
}

/// `schema_version` defaults to `1` when absent from the wire, so
/// `ActionMeta`'s own addition of the field is itself additive (DOC-73 §3.3
/// rule 1).
#[test]
fn action_meta_schema_version_defaults_to_one() {
    let json = r#"{
        "kind": "session",
        "id": "018f1e0a-0000-7000-8000-000000000000",
        "at": "2026-01-01T00:00:00Z",
        "source": "mpm",
        "actor": {"type": "system"},
        "phase": "started"
    }"#;
    let event: ActionEvent =
        serde_json::from_str(json).expect("deserialize without schema_version");
    assert_eq!(event.meta().schema_version, 1);
}

#[test]
fn actor_operator_and_system_round_trip() {
    for (actor, tag) in [
        (Actor::Operator, "\"type\":\"operator\""),
        (Actor::System, "\"type\":\"system\""),
    ] {
        let s = serde_json::to_string(&actor).expect("serialize");
        assert_eq!(s, format!("{{{tag}}}"));
        let back: Actor = serde_json::from_str(&s).expect("deserialize");
        assert_eq!(back, actor);
    }
}

#[test]
fn object_type_round_trips_every_variant() {
    for (ty, tag) in [
        (ObjectType::Session, "\"session\""),
        (ObjectType::Agent, "\"agent\""),
        (ObjectType::Task, "\"task\""),
        (ObjectType::Workstream, "\"workstream\""),
        (ObjectType::File, "\"file\""),
        (ObjectType::ToolCall, "\"tool_call\""),
        (ObjectType::Inference, "\"inference\""),
        (ObjectType::Issue, "\"issue\""),
        (ObjectType::Pr, "\"pr\""),
    ] {
        let s = serde_json::to_string(&ty).expect("serialize");
        assert_eq!(s, tag);
        let back: ObjectType = serde_json::from_str(&s).expect("deserialize");
        assert_eq!(back, ty);
    }
}

// ---- HarnessEvent envelope ----

#[test]
fn harness_event_round_trips() {
    let ev = envelope(HarnessPayload::Ping, Some("sess-1"));
    let s = serde_json::to_string(&ev).expect("serialize");
    assert!(s.contains("\"source\":\"agents\""), "{s}");
    assert!(s.contains("\"session\":\"sess-1\""), "{s}");
    assert!(s.contains("\"id\":\""), "id should be present: {s}");
    let back: HarnessEvent = serde_json::from_str(&s).expect("deserialize");
    assert_eq!(back, ev);
    assert_eq!(back.id, ev.id);
}

#[test]
fn harness_event_omits_none_session() {
    let ev = envelope(HarnessPayload::Ping, None);
    let s = serde_json::to_string(&ev).expect("serialize");
    assert!(!s.contains("session"), "session should be omitted: {s}");
}

#[test]
fn harness_event_omits_none_parent_id() {
    let ev = envelope(HarnessPayload::Ping, None);
    let s = serde_json::to_string(&ev).expect("serialize");
    assert!(
        !s.contains("parent_id"),
        "parent_id should be omitted when None: {s}"
    );
}

/// Two independently constructed envelopes never collide on `id`.
///
/// Why: `id` replaces `seq` as the cross-process identity precisely because
///      `seq` collides across producers (DOC-73 §3.1) — the new field has to
///      actually avoid the failure mode it exists to fix.
/// What: Builds two envelopes via the shared `envelope()` helper (which calls
///       `EventId::new()` per call) and asserts their ids differ.
/// Test: this test itself.
#[test]
fn harness_event_id_is_unique_per_event() {
    let a = envelope(HarnessPayload::Ping, None);
    let b = envelope(HarnessPayload::Ping, None);
    assert_ne!(a.id, b.id);
}

/// `parent_id` carries the causal edge from a child event back to the event
/// that spawned it, and that edge survives a serde round trip.
///
/// Why: The tree view (DOC-73 §5.2) assembles a forest purely from
///      `parent_id` — the wire representation has to preserve the exact
///      referenced `id`, not just "some" id.
/// What: Builds a root event, then a child whose `parent_id` is the root's
///       `id`; asserts the JSON carries the root's id under `parent_id` and
///       that deserializing restores the same link.
/// Test: this test itself.
#[test]
fn harness_event_parent_id_links_to_the_causing_event() {
    let root = envelope(HarnessPayload::Ping, Some("s1"));
    let mut child = envelope(HarnessPayload::Ping, Some("s1"));
    child.parent_id = Some(root.id);

    let s = serde_json::to_string(&child).expect("serialize");
    assert!(s.contains(&format!("\"parent_id\":\"{}\"", root.id)), "{s}");

    let back: HarnessEvent = serde_json::from_str(&s).expect("deserialize");
    assert_eq!(back.parent_id, Some(root.id));
    assert_ne!(
        back.parent_id,
        Some(child.id),
        "child is not its own parent"
    );
}

/// A `HarnessEvent` serialized before issue #6847 added `id`/`parent_id`
/// still deserializes.
///
/// Why: Back-compat is the whole point of `#[serde(default)]` on both
///      fields — a rolling upgrade (an old producer, a new consumer, or a
///      durable log written by yesterday's binary) must not start failing to
///      parse the moment this PR merges.
/// What: Serializes a normal envelope to a `serde_json::Value`, deletes the
///       `id` and `parent_id` keys to simulate the legacy wire shape, then
///       deserializes the result and asserts it succeeds with `parent_id`
///       defaulting to `None`.
/// Test: this test itself.
#[test]
fn harness_event_back_compat_missing_fields_deserializes() {
    let ev = envelope(HarnessPayload::Ping, Some("legacy"));
    let mut value = serde_json::to_value(&ev).expect("serialize to value");
    let obj = value
        .as_object_mut()
        .expect("envelope serializes as an object");
    obj.remove("id");
    obj.remove("parent_id");
    let json = serde_json::to_string(&value).expect("serialize legacy shape");

    let back: HarnessEvent =
        serde_json::from_str(&json).expect("legacy payload without id/parent_id should parse");
    assert_eq!(back.source, ev.source);
    assert_eq!(back.session, ev.session);
    assert_eq!(back.seq, ev.seq);
    assert!(back.parent_id.is_none());
}

/// A missing `id` mints a fresh one on every deserialize, rather than a fixed
/// sentinel — proving the `#[serde(default)]` path actually calls
/// `EventId::new()` and not a constant placeholder.
///
/// Why: A nil/constant fallback would let two distinct legacy events collide
///      on `id` the moment they both hit a consumer that indexes by it (the
///      tree view does). Minting fresh keeps that invariant even for events
///      that predate this field.
/// What: Deserializes the same id-less JSON twice and asserts the two
///       results carry different ids.
/// Test: this test itself.
#[test]
fn harness_event_missing_id_mints_a_fresh_id_each_deserialize() {
    let ev = envelope(HarnessPayload::Ping, None);
    let mut value = serde_json::to_value(&ev).expect("serialize to value");
    value
        .as_object_mut()
        .expect("envelope serializes as an object")
        .remove("id");
    let json = serde_json::to_string(&value).expect("serialize legacy shape");

    let a: HarnessEvent = serde_json::from_str(&json).expect("first deserialize");
    let b: HarnessEvent = serde_json::from_str(&json).expect("second deserialize");
    assert_ne!(a.id, b.id);
}

// ---- EventId ----

#[test]
fn event_id_round_trips() {
    let id = EventId::new();
    let s = serde_json::to_string(&id).expect("serialize");
    let back: EventId = serde_json::from_str(&s).expect("deserialize");
    assert_eq!(back, id);
}

#[test]
fn event_id_new_mints_distinct_ids() {
    let a = EventId::new();
    let b = EventId::new();
    assert_ne!(a, b);
}

#[test]
fn event_id_display_matches_serialized_string() {
    let id = EventId::new();
    let json = serde_json::to_string(&id).expect("serialize");
    // `#[serde(transparent)]` writes the inner `Uuid`'s string form as a JSON
    // string; `Display` forwards to the same `Uuid::fmt`, so the two must
    // agree once the JSON quoting is stripped.
    let quoted = format!("\"{id}\"");
    assert_eq!(json, quoted);
}

// ---- Filter matrix ----

#[test]
fn filter_default_matches_all() {
    let f = Filter::default();
    assert!(f.matches(&envelope(HarnessPayload::Ping, None)));
    assert!(f.matches(&envelope(
        HarnessPayload::Lifecycle(sample_lifecycle()),
        Some("x")
    )));
}

#[test]
fn filter_by_source() {
    let f = Filter {
        source: Some(HarnessSource::Mpm),
        ..Default::default()
    };
    let mut ev = envelope(HarnessPayload::Ping, None);
    ev.source = HarnessSource::Mpm;
    assert!(f.matches(&ev));
    ev.source = HarnessSource::Agents;
    assert!(!f.matches(&ev));
}

#[test]
fn filter_by_session() {
    let f = Filter {
        session: Some("sess-7".into()),
        ..Default::default()
    };
    assert!(f.matches(&envelope(HarnessPayload::Ping, Some("sess-7"))));
    assert!(!f.matches(&envelope(HarnessPayload::Ping, Some("other"))));
    // An event with no session never matches a session constraint.
    assert!(!f.matches(&envelope(HarnessPayload::Ping, None)));
}

#[test]
fn filter_by_domain() {
    let f = Filter {
        domains: Some(vec!["hook", "ping"]),
        ..Default::default()
    };
    assert!(f.matches(&envelope(HarnessPayload::Ping, None)));
    assert!(f.matches(&envelope(
        HarnessPayload::Hook {
            kind: "k".into(),
            data: json!({})
        },
        None
    )));
    assert!(!f.matches(&envelope(
        HarnessPayload::Lifecycle(sample_lifecycle()),
        Some("x")
    )));
}

#[test]
fn filter_combination() {
    let f = Filter {
        source: Some(HarnessSource::Code),
        session: Some("s".into()),
        domains: Some(vec!["lifecycle"]),
    };
    let mut ev = envelope(HarnessPayload::Lifecycle(sample_lifecycle()), Some("s"));
    ev.source = HarnessSource::Code;
    assert!(f.matches(&ev));

    // Wrong source fails the conjunction even though session+domain match.
    ev.source = HarnessSource::Mpm;
    assert!(!f.matches(&ev));
}

// ---- types-only boundary ----

/// Every source file in this module, paired with its name for the failure
/// message. `include_str!` resolves relative to this file, so the check reads
/// the real shipped text rather than a list someone has to remember to update.
const MODULE_SOURCES: &[(&str, &str)] = &[
    ("control_bus/mod.rs", include_str!("mod.rs")),
    ("control_bus/action.rs", include_str!("action.rs")),
    ("control_bus/lifecycle.rs", include_str!("lifecycle.rs")),
    ("control_bus/envelope.rs", include_str!("envelope.rs")),
    ("control_bus/event_id.rs", include_str!("event_id.rs")),
    ("control_bus/filter.rs", include_str!("filter.rs")),
    // #6847: `push_client.rs` is the one file in this list that DOES dial a
    // socket — see `control_bus_declares_no_transport`'s doc comment for why
    // the scan below still passes it (it holds no global state, and none of
    // the five forbidden spellings), and `push_client.rs`'s own module doc
    // for the full design. `include_str!` embeds it unconditionally
    // regardless of the `#[cfg(all(unix, feature = "uds"))]` gate on its `mod`
    // declaration, so this scan covers it even in a build with `uds` off.
    ("control_bus/push_client.rs", include_str!("push_client.rs")),
    ("control_bus/tests.rs", include_str!("tests.rs")),
];

/// Transport spellings that must never appear in this module.
///
/// Each needle is assembled by `concat!` so the literal it forms is absent from
/// this file's own source text — that is what lets the scan include `tests.rs`
/// itself instead of carving out an unchecked hole.
const FORBIDDEN_SUBSTRINGS: &[&str] = &[
    concat!("broadcast", "::"),
    concat!("Once", "Lock"),
    concat!("tokio", "::", "sync"),
    concat!("lazy_", "static!"),
    concat!("once_", "cell"),
];

/// Strips a leading visibility qualifier (`pub`, `pub(crate)`, `pub(super)`,
/// `pub(in ...)`) and the whitespace after it, so a static-declaration check
/// can anchor on `static` regardless of which visibility form precedes it.
///
/// Why: The transport scan below needs `static` at the true start of an item
///      declaration; without stripping visibility first, `pub(crate) static`
///      and `pub(in crate::foo) static` slipped past a scan that only knew
///      about bare `static ` and `pub static ` (#6846 review note).
/// What: Removes one `pub` token, and — when followed by a parenthesized
///       qualifier — the balanced `(...)` after it, then trims the remaining
///       leading whitespace. A line with no `pub` prefix passes through
///       unchanged.
/// Test: `static_scan_catches_every_visibility_form`.
fn strip_leading_pub(trimmed: &str) -> &str {
    let Some(rest) = trimmed.strip_prefix("pub") else {
        return trimmed;
    };
    if let Some(after_paren) = rest.strip_prefix('(') {
        // `pub(crate)`, `pub(super)`, `pub(in path::to::mod)` — the
        // qualifier never itself contains `)`, so the first one closes it.
        match after_paren.find(')') {
            Some(close) => after_paren[close + 1..].trim_start(),
            None => rest, // malformed `pub(` with no close — leave as-is
        }
    } else if rest.starts_with(char::is_whitespace) || rest.is_empty() {
        rest.trim_start()
    } else {
        // e.g. "public" — not actually the `pub` keyword.
        trimmed
    }
}

/// The `control_bus` module carries types and nothing that moves them.
///
/// Why: The owner ruling for #6846 puts the one event bus in trusty-console and
///      leaves `trusty-common` holding only the shared types. A grep proves that
///      on the day it is run and nothing afterwards; this test makes the
///      boundary fail the build the moment a channel, a process-global sender,
///      or a mutable global is added back.
/// What: Scans every source file of this module for a channel or global-state
///       spelling, and for any item-position `static` declaration (`static`
///       and `static mut`, under any visibility — `pub`, `pub(crate)`,
///       `pub(super)`, `pub(in ...)`, or none). The substring needles are
///       `concat!`-assembled so scanning this file does not match the needle
///       list itself; `&'static str` in a type position is not an item
///       declaration, so the `static` check is line-anchored (after stripping
///       a leading visibility qualifier) rather than a substring search.
/// Test: this test itself, plus the visibility-form negative control in
///       `static_scan_catches_every_visibility_form`.
#[test]
fn control_bus_declares_no_transport() {
    for (name, src) in MODULE_SOURCES {
        for needle in FORBIDDEN_SUBSTRINGS {
            assert!(
                !src.contains(needle),
                "{name} contains `{needle}`: control_bus holds event TYPES only \
                 — the bus lives in trusty-console (#6846)"
            );
        }

        for (idx, line) in src.lines().enumerate() {
            let candidate = strip_leading_pub(line.trim_start());
            assert!(
                !(candidate.starts_with("static ") || candidate.starts_with("static mut ")),
                "{}:{} declares a global `static`: control_bus holds event TYPES \
                 only — no global state (#6846)\n  {line}",
                name,
                idx + 1
            );
        }
    }
}

/// Negative control for the visibility stripping in
/// `control_bus_declares_no_transport`.
///
/// Why: The scan above is only as good as its line-anchoring. A prior version
///      caught bare `static ` and `pub static ` but missed `pub(crate) static`
///      and `static mut` — this test proves the fix against tiny inline
///      fixtures rather than trusting the real module sources to happen to
///      cover every visibility form.
/// What: Runs the same detection the scan above uses — strip a leading `pub`
///       qualifier, then check for a `static ` or `static mut ` prefix —
///       against three one-line fixtures: a `pub(crate) static` declaration
///       (must be caught), a `static mut` declaration with no visibility
///       (must be caught), and a `&'static` reference in a `let` binding
///       (must NOT be caught).
/// Test: this test itself.
#[test]
fn static_scan_catches_every_visibility_form() {
    let is_static_declaration = |line: &str| -> bool {
        let candidate = strip_leading_pub(line.trim_start());
        candidate.starts_with("static ") || candidate.starts_with("static mut ")
    };

    assert!(
        is_static_declaration("pub(crate) static X: u8 = 0;"),
        "`pub(crate) static` must be detected as a static declaration"
    );
    assert!(
        is_static_declaration("static mut Y: u8 = 0;"),
        "`static mut` with no visibility qualifier must be detected"
    );
    assert!(
        !is_static_declaration("let s: &'static str = \"\";"),
        "`&'static` in a type position must not be flagged as a static declaration"
    );
}

/// The scan above covers every file the module actually ships.
///
/// Why: `MODULE_SOURCES` is a hand-written list, and a new submodule added
///      without a row would be silently unscanned — the fail-open mode that
///      makes a guard worthless. Counting the module's declarations against the
///      list turns that omission into a failure.
/// What: Reads `mod.rs` for its `mod <name>;` declarations and asserts each one
///       has a `MODULE_SOURCES` row, and that the list also covers `mod.rs` and
///       this file.
/// Test: this test itself.
#[test]
fn module_source_scan_covers_every_submodule() {
    let mod_rs = include_str!("mod.rs");

    let declared: Vec<&str> = mod_rs
        .lines()
        .map(str::trim)
        .filter_map(|l| {
            l.strip_prefix("mod ")
                .or_else(|| l.strip_prefix("pub mod "))
        })
        .filter_map(|rest| rest.strip_suffix(';'))
        .collect();

    assert!(
        !declared.is_empty(),
        "found no `mod` declarations in control_bus/mod.rs — the parser above is \
         out of date, which would make the transport scan vacuous"
    );

    for name in &declared {
        let expected = format!("control_bus/{name}.rs");
        assert!(
            MODULE_SOURCES.iter().any(|(n, _)| *n == expected),
            "control_bus/mod.rs declares `mod {name};` but MODULE_SOURCES has no \
             row for {expected} — add one so the transport scan covers it"
        );
    }

    // `mod.rs` and `tests.rs` are not `mod` declarations, so assert them directly.
    for expected in ["control_bus/mod.rs", "control_bus/tests.rs"] {
        assert!(
            MODULE_SOURCES.iter().any(|(n, _)| *n == expected),
            "MODULE_SOURCES is missing {expected}"
        );
    }
}