trustformers-optim 0.1.1

Optimizers for TrustformeRS
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
//! # Schedule-Free Optimizers
//!
//! Implementation of Schedule-Free SGD and Adam optimizers from "The Road Less Scheduled" paper.
//! These optimizers eliminate the need for learning rate scheduling by automatically adapting
//! the learning rate based on the optimization trajectory.
//!
//! ## Key Features
//!
//! - **No Learning Rate Scheduling**: Automatically adapts learning rate without manual schedules
//! - **Theoretical Guarantees**: Maintains convergence guarantees of standard optimizers
//! - **Easy to Use**: Drop-in replacement for SGD and Adam with better generalization
//! - **Memory Efficient**: Minimal overhead compared to standard optimizers
//!
//! ## Research Background
//!
//! Schedule-Free optimizers use a momentum-based approach to automatically adjust the learning
//! rate during training. They maintain two sets of weights: the "momentum weights" used for
//! gradient computation and the "average weights" used for evaluation.

use crate::common::{OptimizerState, StateMemoryStats};
use crate::traits::StatefulOptimizer;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use trustformers_core::errors::{Result, TrustformersError};
use trustformers_core::tensor::Tensor;
use trustformers_core::traits::Optimizer;

/// Configuration for Schedule-Free SGD optimizer
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ScheduleFreeSGDConfig {
    /// Learning rate (typically much higher than standard SGD, e.g., 1.0-10.0)
    pub learning_rate: f32,
    /// Momentum coefficient (default: 0.9)
    pub momentum: f32,
    /// Weight decay coefficient (default: 0.0)
    pub weight_decay: f32,
    /// Warmup steps for learning rate (default: 0)
    pub warmup_steps: usize,
    /// Evaluation mode coefficient (default: 1.0)
    pub r: f32,
}

impl Default for ScheduleFreeSGDConfig {
    fn default() -> Self {
        Self {
            learning_rate: 1.0, // Much higher than standard SGD
            momentum: 0.9,
            weight_decay: 0.0,
            warmup_steps: 0,
            r: 1.0,
        }
    }
}

/// Schedule-Free SGD optimizer implementation
///
/// Based on "The Road Less Scheduled" paper, this optimizer automatically adapts
/// the learning rate without requiring manual scheduling.
#[derive(Debug)]
pub struct ScheduleFreeSGD {
    config: ScheduleFreeSGDConfig,
    state: OptimizerState,
    /// Momentum weights (x in the paper)
    momentum_weights: HashMap<String, Vec<f32>>,
    /// Average weights (y in the paper)
    average_weights: HashMap<String, Vec<f32>>,
}

impl ScheduleFreeSGD {
    /// Create a new Schedule-Free SGD optimizer
    pub fn new(learning_rate: f32, momentum: f32, weight_decay: f32) -> Self {
        let config = ScheduleFreeSGDConfig {
            learning_rate,
            momentum,
            weight_decay,
            warmup_steps: 0,
            r: 1.0,
        };

        Self {
            config,
            state: OptimizerState::new(),
            momentum_weights: HashMap::new(),
            average_weights: HashMap::new(),
        }
    }

    /// Create Schedule-Free SGD with full configuration
    pub fn with_config(config: ScheduleFreeSGDConfig) -> Self {
        Self {
            config,
            state: OptimizerState::new(),
            momentum_weights: HashMap::new(),
            average_weights: HashMap::new(),
        }
    }

    /// Create for large models (higher learning rate)
    pub fn for_large_models() -> Self {
        let config = ScheduleFreeSGDConfig {
            learning_rate: 5.0,
            momentum: 0.95,
            weight_decay: 0.1,
            warmup_steps: 1000,
            r: 1.0,
        };
        Self::with_config(config)
    }

    /// Get current effective learning rate (accounting for warmup)
    pub fn get_effective_lr(&self) -> f32 {
        if self.config.warmup_steps == 0 || self.state.step >= self.config.warmup_steps {
            self.config.learning_rate
        } else {
            self.config.learning_rate * (self.state.step as f32 / self.config.warmup_steps as f32)
        }
    }

    /// Switch to evaluation mode (returns average weights)
    pub fn eval_mode(&mut self, parameters: &mut [Tensor]) -> Result<()> {
        for param in parameters.iter_mut() {
            match param {
                Tensor::F32(param_data) => {
                    let param_id = format!("{:p}", param_data.as_ptr());

                    if let Some(average_weights) = self.average_weights.get(&param_id) {
                        // In eval mode, use average weights instead of momentum weights
                        for (p, &a) in param_data.iter_mut().zip(average_weights.iter()) {
                            *p = a;
                        }
                    }
                },
                _ => {
                    return Err(TrustformersError::tensor_op_error(
                        "Unsupported tensor type for Schedule-Free SGD eval mode",
                        "ScheduleFreeSGD::eval_mode",
                    ))
                },
            }
        }
        Ok(())
    }

    /// Switch to training mode (returns momentum weights)
    pub fn train_mode(&mut self, parameters: &mut [Tensor]) -> Result<()> {
        for param in parameters.iter_mut() {
            match param {
                Tensor::F32(param_data) => {
                    let param_id = format!("{:p}", param_data.as_ptr());

                    if let Some(momentum_weights) = self.momentum_weights.get(&param_id) {
                        // In train mode, use momentum weights
                        for (p, &m) in param_data.iter_mut().zip(momentum_weights.iter()) {
                            *p = m;
                        }
                    }
                },
                _ => {
                    return Err(TrustformersError::tensor_op_error(
                        "Unsupported tensor type for Schedule-Free SGD train mode",
                        "ScheduleFreeSGD::train_mode",
                    ))
                },
            }
        }
        Ok(())
    }
}

impl Optimizer for ScheduleFreeSGD {
    fn update(&mut self, parameter: &mut Tensor, grad: &Tensor) -> Result<()> {
        match (parameter, grad) {
            (Tensor::F32(param), Tensor::F32(grad_arr)) => {
                let param_id = format!("{:p}", param.as_ptr());
                let size = grad_arr.len();

                // Get values before mutable borrows
                let effective_lr = self.get_effective_lr();
                let beta = self.config.momentum;
                let weight_decay = self.config.weight_decay;

                // Initialize buffers if they don't exist
                let momentum_weights = self
                    .momentum_weights
                    .entry(param_id.clone())
                    .or_insert_with(|| param.iter().cloned().collect());
                let average_weights = self
                    .average_weights
                    .entry(param_id)
                    .or_insert_with(|| param.iter().cloned().collect());

                if momentum_weights.len() != size || average_weights.len() != size {
                    return Err(TrustformersError::tensor_op_error(
                        "Schedule-Free SGD state buffer size mismatch",
                        "ScheduleFreeSGD::update",
                    ));
                }

                // Schedule-Free SGD update
                for (((p, &g), m), a) in param
                    .iter_mut()
                    .zip(grad_arr.iter())
                    .zip(momentum_weights.iter_mut())
                    .zip(average_weights.iter_mut())
                {
                    let mut grad_with_wd = g;

                    // Apply weight decay to gradient
                    if weight_decay > 0.0 {
                        grad_with_wd += weight_decay * *p;
                    }

                    // Update momentum weights (x)
                    *m = beta * *m + effective_lr * grad_with_wd;

                    // Update average weights (y)
                    *a = (1.0 - beta) * *a + beta * *m;

                    // Set parameter to momentum weights for training
                    *p = *m;
                }

                Ok(())
            },
            _ => Err(TrustformersError::tensor_op_error(
                "Unsupported tensor types for Schedule-Free SGD",
                "ScheduleFreeSGD::update",
            )),
        }
    }

    fn zero_grad(&mut self) {
        // Schedule-Free optimizers don't need to zero gradients explicitly
    }

    fn step(&mut self) {
        self.state.step();
    }

    fn get_lr(&self) -> f32 {
        self.get_effective_lr()
    }

    fn set_lr(&mut self, lr: f32) {
        self.config.learning_rate = lr;
    }
}

impl StatefulOptimizer for ScheduleFreeSGD {
    type Config = ScheduleFreeSGDConfig;
    type State = OptimizerState;

    fn config(&self) -> &Self::Config {
        &self.config
    }

    fn state(&self) -> &Self::State {
        &self.state
    }

    fn state_mut(&mut self) -> &mut Self::State {
        &mut self.state
    }

    fn state_dict(&self) -> Result<HashMap<String, Tensor>> {
        let mut state_dict = HashMap::new();

        // Save configuration
        state_dict.insert(
            "learning_rate".to_string(),
            Tensor::new(vec![self.config.learning_rate])?,
        );
        state_dict.insert(
            "momentum".to_string(),
            Tensor::new(vec![self.config.momentum])?,
        );
        state_dict.insert(
            "weight_decay".to_string(),
            Tensor::new(vec![self.config.weight_decay])?,
        );
        state_dict.insert(
            "warmup_steps".to_string(),
            Tensor::new(vec![self.config.warmup_steps as f32])?,
        );
        state_dict.insert("r".to_string(), Tensor::new(vec![self.config.r])?);
        state_dict.insert(
            "step".to_string(),
            Tensor::new(vec![self.state.step as f32])?,
        );

        // Save weight buffers
        for (param_id, momentum_weights) in &self.momentum_weights {
            state_dict.insert(
                format!("momentum_weights_{}", param_id),
                Tensor::new(momentum_weights.clone())?,
            );
        }

        for (param_id, average_weights) in &self.average_weights {
            state_dict.insert(
                format!("average_weights_{}", param_id),
                Tensor::new(average_weights.clone())?,
            );
        }

        Ok(state_dict)
    }

    fn load_state_dict(&mut self, state: HashMap<String, Tensor>) -> Result<()> {
        // Load configuration
        if let Some(lr_tensor) = state.get("learning_rate") {
            if let Ok(lr_vec) = lr_tensor.data() {
                if !lr_vec.is_empty() {
                    self.config.learning_rate = lr_vec[0];
                }
            }
        }
        if let Some(momentum_tensor) = state.get("momentum") {
            if let Ok(momentum_vec) = momentum_tensor.data() {
                if !momentum_vec.is_empty() {
                    self.config.momentum = momentum_vec[0];
                }
            }
        }
        if let Some(weight_decay_tensor) = state.get("weight_decay") {
            if let Ok(weight_decay_vec) = weight_decay_tensor.data() {
                if !weight_decay_vec.is_empty() {
                    self.config.weight_decay = weight_decay_vec[0];
                }
            }
        }
        if let Some(warmup_steps_tensor) = state.get("warmup_steps") {
            if let Ok(warmup_steps_vec) = warmup_steps_tensor.data() {
                if !warmup_steps_vec.is_empty() {
                    self.config.warmup_steps = warmup_steps_vec[0] as usize;
                }
            }
        }
        if let Some(r_tensor) = state.get("r") {
            if let Ok(r_vec) = r_tensor.data() {
                if !r_vec.is_empty() {
                    self.config.r = r_vec[0];
                }
            }
        }
        if let Some(step_tensor) = state.get("step") {
            if let Ok(step_vec) = step_tensor.data() {
                if !step_vec.is_empty() {
                    self.state.step = step_vec[0] as usize;
                }
            }
        }

        // Load weight buffers
        for (key, tensor) in state {
            if key.starts_with("momentum_weights_") {
                let param_id = key
                    .strip_prefix("momentum_weights_")
                    .expect("key must have momentum_weights_ prefix")
                    .to_string();
                if let Ok(weights) = tensor.data() {
                    self.momentum_weights.insert(param_id, weights);
                }
            } else if key.starts_with("average_weights_") {
                let param_id = key
                    .strip_prefix("average_weights_")
                    .expect("key must have average_weights_ prefix")
                    .to_string();
                if let Ok(weights) = tensor.data() {
                    self.average_weights.insert(param_id, weights);
                }
            }
        }

        Ok(())
    }

    fn memory_usage(&self) -> StateMemoryStats {
        let momentum_size: usize = self.momentum_weights.values().map(|v| v.len()).sum();
        let average_size: usize = self.average_weights.values().map(|v| v.len()).sum();

        StateMemoryStats {
            momentum_elements: momentum_size,
            variance_elements: 0, // Schedule-free doesn't use variance
            third_moment_elements: average_size,
            total_bytes: ((momentum_size + average_size) * 4),
            num_parameters: self.momentum_weights.len(),
        }
    }

    fn reset_state(&mut self) {
        self.state.clear();
        self.momentum_weights.clear();
        self.average_weights.clear();
    }

    fn num_parameters(&self) -> usize {
        self.momentum_weights.values().map(|v| v.len()).sum()
    }
}

/// Configuration for Schedule-Free Adam optimizer
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ScheduleFreeAdamConfig {
    /// Learning rate (typically 0.1-1.0, higher than standard Adam)
    pub learning_rate: f32,
    /// First moment decay rate (default: 0.9)
    pub beta1: f32,
    /// Second moment decay rate (default: 0.999)
    pub beta2: f32,
    /// Epsilon for numerical stability (default: 1e-8)
    pub epsilon: f32,
    /// Weight decay coefficient (default: 0.0)
    pub weight_decay: f32,
    /// Warmup steps for learning rate (default: 0)
    pub warmup_steps: usize,
    /// Evaluation mode coefficient (default: 1.0)
    pub r: f32,
}

impl Default for ScheduleFreeAdamConfig {
    fn default() -> Self {
        Self {
            learning_rate: 0.25, // Higher than standard Adam
            beta1: 0.9,
            beta2: 0.999,
            epsilon: 1e-8,
            weight_decay: 0.0,
            warmup_steps: 0,
            r: 1.0,
        }
    }
}

/// Schedule-Free Adam optimizer implementation
///
/// Combines the adaptive learning rates of Adam with schedule-free learning rate adaptation.
#[derive(Debug)]
pub struct ScheduleFreeAdam {
    config: ScheduleFreeAdamConfig,
    state: OptimizerState,
    /// Momentum weights (x in the paper)
    momentum_weights: HashMap<String, Vec<f32>>,
    /// Average weights (y in the paper)
    average_weights: HashMap<String, Vec<f32>>,
    /// First moment estimates
    exp_avg: HashMap<String, Vec<f32>>,
    /// Second moment estimates
    exp_avg_sq: HashMap<String, Vec<f32>>,
}

impl ScheduleFreeAdam {
    /// Create a new Schedule-Free Adam optimizer
    pub fn new(
        learning_rate: f32,
        beta1: f32,
        beta2: f32,
        epsilon: f32,
        weight_decay: f32,
    ) -> Self {
        let config = ScheduleFreeAdamConfig {
            learning_rate,
            beta1,
            beta2,
            epsilon,
            weight_decay,
            warmup_steps: 0,
            r: 1.0,
        };

        Self {
            config,
            state: OptimizerState::new(),
            momentum_weights: HashMap::new(),
            average_weights: HashMap::new(),
            exp_avg: HashMap::new(),
            exp_avg_sq: HashMap::new(),
        }
    }

    /// Create Schedule-Free Adam with full configuration
    pub fn with_config(config: ScheduleFreeAdamConfig) -> Self {
        Self {
            config,
            state: OptimizerState::new(),
            momentum_weights: HashMap::new(),
            average_weights: HashMap::new(),
            exp_avg: HashMap::new(),
            exp_avg_sq: HashMap::new(),
        }
    }

    /// Create for language models (optimized hyperparameters)
    pub fn for_language_models() -> Self {
        let config = ScheduleFreeAdamConfig {
            learning_rate: 0.5,
            beta1: 0.9,
            beta2: 0.95,
            epsilon: 1e-8,
            weight_decay: 0.1,
            warmup_steps: 2000,
            r: 1.0,
        };
        Self::with_config(config)
    }

    /// Get current effective learning rate (accounting for warmup)
    pub fn get_effective_lr(&self) -> f32 {
        if self.config.warmup_steps == 0 || self.state.step >= self.config.warmup_steps {
            self.config.learning_rate
        } else {
            self.config.learning_rate * (self.state.step as f32 / self.config.warmup_steps as f32)
        }
    }
}

impl Optimizer for ScheduleFreeAdam {
    fn update(&mut self, parameter: &mut Tensor, grad: &Tensor) -> Result<()> {
        match (parameter, grad) {
            (Tensor::F32(param), Tensor::F32(grad_arr)) => {
                let param_id = format!("{:p}", param.as_ptr());
                let size = grad_arr.len();

                // Get values before mutable borrows
                let effective_lr = self.get_effective_lr();
                let beta1 = self.config.beta1;
                let beta2 = self.config.beta2;
                let eps = self.config.epsilon;
                let weight_decay = self.config.weight_decay;

                // Initialize buffers if they don't exist
                let momentum_weights = self
                    .momentum_weights
                    .entry(param_id.clone())
                    .or_insert_with(|| param.iter().cloned().collect());
                let average_weights = self
                    .average_weights
                    .entry(param_id.clone())
                    .or_insert_with(|| param.iter().cloned().collect());
                let exp_avg =
                    self.exp_avg.entry(param_id.clone()).or_insert_with(|| vec![0.0; size]);
                let exp_avg_sq = self.exp_avg_sq.entry(param_id).or_insert_with(|| vec![0.0; size]);

                if momentum_weights.len() != size
                    || average_weights.len() != size
                    || exp_avg.len() != size
                    || exp_avg_sq.len() != size
                {
                    return Err(TrustformersError::tensor_op_error(
                        "Schedule-Free Adam state buffer size mismatch",
                        "ScheduleFreeAdam::update",
                    ));
                }

                // Bias correction
                let step = (self.state.step + 1) as f32;
                let bias_correction1 = 1.0 - beta1.powf(step);
                let bias_correction2 = 1.0 - beta2.powf(step);

                // Schedule-Free Adam update
                for (((((p, &g), m), a), exp_avg_val), exp_avg_sq_val) in param
                    .iter_mut()
                    .zip(grad_arr.iter())
                    .zip(momentum_weights.iter_mut())
                    .zip(average_weights.iter_mut())
                    .zip(exp_avg.iter_mut())
                    .zip(exp_avg_sq.iter_mut())
                {
                    let mut grad_with_wd = g;

                    // Apply weight decay to gradient
                    if weight_decay > 0.0 {
                        grad_with_wd += weight_decay * *p;
                    }

                    // Update biased first moment estimate
                    *exp_avg_val = beta1 * *exp_avg_val + (1.0 - beta1) * grad_with_wd;

                    // Update biased second moment estimate
                    *exp_avg_sq_val =
                        beta2 * *exp_avg_sq_val + (1.0 - beta2) * grad_with_wd * grad_with_wd;

                    // Compute bias-corrected first and second moment estimates
                    let m_hat = *exp_avg_val / bias_correction1;
                    let v_hat = *exp_avg_sq_val / bias_correction2;

                    // Compute Adam update
                    let adam_update = effective_lr * m_hat / (v_hat.sqrt() + eps);

                    // Update momentum weights (x)
                    *m = beta1 * *m + adam_update;

                    // Update average weights (y)
                    *a = (1.0 - beta1) * *a + beta1 * *m;

                    // Set parameter to momentum weights for training
                    *p = *m;
                }

                Ok(())
            },
            _ => Err(TrustformersError::tensor_op_error(
                "Unsupported tensor types for Schedule-Free Adam",
                "ScheduleFreeAdam::update",
            )),
        }
    }

    fn zero_grad(&mut self) {
        // Schedule-Free optimizers don't need to zero gradients explicitly
    }

    fn step(&mut self) {
        self.state.step();
    }

    fn get_lr(&self) -> f32 {
        self.get_effective_lr()
    }

    fn set_lr(&mut self, lr: f32) {
        self.config.learning_rate = lr;
    }
}

impl StatefulOptimizer for ScheduleFreeAdam {
    type Config = ScheduleFreeAdamConfig;
    type State = OptimizerState;

    fn config(&self) -> &Self::Config {
        &self.config
    }

    fn state(&self) -> &Self::State {
        &self.state
    }

    fn state_mut(&mut self) -> &mut Self::State {
        &mut self.state
    }

    fn state_dict(&self) -> Result<HashMap<String, Tensor>> {
        let mut state_dict = HashMap::new();

        // Save configuration
        state_dict.insert(
            "learning_rate".to_string(),
            Tensor::new(vec![self.config.learning_rate])?,
        );
        state_dict.insert("beta1".to_string(), Tensor::new(vec![self.config.beta1])?);
        state_dict.insert("beta2".to_string(), Tensor::new(vec![self.config.beta2])?);
        state_dict.insert(
            "epsilon".to_string(),
            Tensor::new(vec![self.config.epsilon])?,
        );
        state_dict.insert(
            "weight_decay".to_string(),
            Tensor::new(vec![self.config.weight_decay])?,
        );
        state_dict.insert(
            "warmup_steps".to_string(),
            Tensor::new(vec![self.config.warmup_steps as f32])?,
        );
        state_dict.insert("r".to_string(), Tensor::new(vec![self.config.r])?);
        state_dict.insert(
            "step".to_string(),
            Tensor::new(vec![self.state.step as f32])?,
        );

        // Save all buffers
        for (param_id, momentum_weights) in &self.momentum_weights {
            state_dict.insert(
                format!("momentum_weights_{}", param_id),
                Tensor::new(momentum_weights.clone())?,
            );
        }

        for (param_id, average_weights) in &self.average_weights {
            state_dict.insert(
                format!("average_weights_{}", param_id),
                Tensor::new(average_weights.clone())?,
            );
        }

        for (param_id, exp_avg) in &self.exp_avg {
            state_dict.insert(
                format!("exp_avg_{}", param_id),
                Tensor::new(exp_avg.clone())?,
            );
        }

        for (param_id, exp_avg_sq) in &self.exp_avg_sq {
            state_dict.insert(
                format!("exp_avg_sq_{}", param_id),
                Tensor::new(exp_avg_sq.clone())?,
            );
        }

        Ok(state_dict)
    }

    fn load_state_dict(&mut self, state: HashMap<String, Tensor>) -> Result<()> {
        // Load configuration
        if let Some(lr_tensor) = state.get("learning_rate") {
            if let Ok(lr_vec) = lr_tensor.data() {
                if !lr_vec.is_empty() {
                    self.config.learning_rate = lr_vec[0];
                }
            }
        }
        // ... (similar pattern for other config fields)

        // Load all buffers
        for (key, tensor) in state {
            if key.starts_with("momentum_weights_") {
                let param_id = key
                    .strip_prefix("momentum_weights_")
                    .expect("key must have momentum_weights_ prefix")
                    .to_string();
                if let Ok(weights) = tensor.data() {
                    self.momentum_weights.insert(param_id, weights);
                }
            } else if key.starts_with("average_weights_") {
                let param_id = key
                    .strip_prefix("average_weights_")
                    .expect("key must have average_weights_ prefix")
                    .to_string();
                if let Ok(weights) = tensor.data() {
                    self.average_weights.insert(param_id, weights);
                }
            } else if key.starts_with("exp_avg_") && !key.starts_with("exp_avg_sq_") {
                let param_id = key
                    .strip_prefix("exp_avg_")
                    .expect("key must have exp_avg_ prefix")
                    .to_string();
                if let Ok(weights) = tensor.data() {
                    self.exp_avg.insert(param_id, weights);
                }
            } else if key.starts_with("exp_avg_sq_") {
                let param_id = key
                    .strip_prefix("exp_avg_sq_")
                    .expect("key must have exp_avg_sq_ prefix")
                    .to_string();
                if let Ok(weights) = tensor.data() {
                    self.exp_avg_sq.insert(param_id, weights);
                }
            }
        }

        Ok(())
    }

    fn memory_usage(&self) -> StateMemoryStats {
        let momentum_size: usize = self.momentum_weights.values().map(|v| v.len()).sum();
        let average_size: usize = self.average_weights.values().map(|v| v.len()).sum();
        let exp_avg_size: usize = self.exp_avg.values().map(|v| v.len()).sum();
        let exp_avg_sq_size: usize = self.exp_avg_sq.values().map(|v| v.len()).sum();

        let total_params = momentum_size + average_size + exp_avg_size + exp_avg_sq_size;
        let _total_buffers = self.momentum_weights.len()
            + self.average_weights.len()
            + self.exp_avg.len()
            + self.exp_avg_sq.len();

        StateMemoryStats {
            momentum_elements: momentum_size + exp_avg_size,
            variance_elements: average_size + exp_avg_sq_size,
            third_moment_elements: 0,
            total_bytes: total_params * 4,
            num_parameters: self.momentum_weights.len(),
        }
    }

    fn reset_state(&mut self) {
        self.state.clear();
        self.momentum_weights.clear();
        self.average_weights.clear();
        self.exp_avg.clear();
        self.exp_avg_sq.clear();
    }

    fn num_parameters(&self) -> usize {
        self.momentum_weights.values().map(|v| v.len()).sum()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_schedule_free_sgd_creation() {
        let optimizer = ScheduleFreeSGD::new(1.0, 0.9, 0.01);
        assert_eq!(optimizer.get_lr(), 1.0);
        assert_eq!(optimizer.config.momentum, 0.9);
        assert_eq!(optimizer.config.weight_decay, 0.01);
    }

    #[test]
    fn test_schedule_free_sgd_for_large_models() {
        let optimizer = ScheduleFreeSGD::for_large_models();
        assert_eq!(optimizer.config.learning_rate, 5.0);
        assert_eq!(optimizer.config.momentum, 0.95);
        assert_eq!(optimizer.config.weight_decay, 0.1);
        assert_eq!(optimizer.config.warmup_steps, 1000);
    }

    #[test]
    fn test_schedule_free_adam_creation() {
        let optimizer = ScheduleFreeAdam::new(0.25, 0.9, 0.999, 1e-8, 0.01);
        assert_eq!(optimizer.get_lr(), 0.25);
        assert_eq!(optimizer.config.beta1, 0.9);
        assert_eq!(optimizer.config.beta2, 0.999);
        assert_eq!(optimizer.config.epsilon, 1e-8);
        assert_eq!(optimizer.config.weight_decay, 0.01);
    }

    #[test]
    fn test_schedule_free_adam_for_language_models() {
        let optimizer = ScheduleFreeAdam::for_language_models();
        assert_eq!(optimizer.config.learning_rate, 0.5);
        assert_eq!(optimizer.config.beta1, 0.9);
        assert_eq!(optimizer.config.beta2, 0.95);
        assert_eq!(optimizer.config.weight_decay, 0.1);
        assert_eq!(optimizer.config.warmup_steps, 2000);
    }

    #[test]
    fn test_memory_usage() {
        let optimizer = ScheduleFreeAdam::new(0.1, 0.9, 0.999, 1e-8, 0.0);
        let memory_stats = optimizer.memory_usage();
        assert_eq!(memory_stats.num_parameters, 0); // No parameters added yet
        assert_eq!(memory_stats.total_bytes, 0);
    }
}